[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272336. njames93 added a comment. - Fix compilation failure on rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-21 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked 3 inline comments as done. dang added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:430-440 + std::vector> OptsWithMarshalling; + for (unsigned I = 0, E = Opts.size(); I != E; ++I) { +const Record = *Opts[I]; +// Start a single

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-21 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked 2 inline comments as done. dang added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:468-469 + OS << "};\n"; + OS << "static const unsigned SimpleEnumValueTablesSize = " +"sizeof(SimpleEnumValueTables) /

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-21 Thread Andrew J Wock via Phabricator via cfe-commits
ajwock updated this revision to Diff 272330. ajwock added a comment. It seems one of the issues that my tests revealed was already remedied in very recent changes, causing my test to fail. I changed the test to reflect that while also taking steven's recommendations. CHANGES SINCE LAST ACTION

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ There's no testing

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-21 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang added a comment. LGTM overall with some minor comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14238 BuiltinID == PPC::BI__builtin_vsx_xvrspi) - ID = Intrinsic::round; + ID = Builder.getIsFPConstrained() ?

[PATCH] D82259: Deprecate error prone temporary directory APIs

2020-06-21 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3177 llvm::sys::path::append(Result, "ModuleCache"); } This default path is not ideal for Linux. On Linux, if we want to put this into the home directory, we should follow

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-21 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1887 + if (BTy->isFloatingPoint()) { +PreferredAlign = FieldSize; + } I tried `clang -cc1 -triple powerpc-ibm-aix -fsyntax-only` with : ``` struct A

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

2020-06-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618 + )"; + EXPECT_TRUE(matches(kTest, expr(nullPointerConstant(; } While this test in ASTMatchers might continue to make sense, shouldn't there be a

[PATCH] D82281: [clang-tidy] llvm-twine-local ignores parameters

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: bkramer, alexfh, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Ignore paramater declarations of type `::llvm::Twine`, These don't suffer the same use after free risks as local twines.

[clang] 1d4c873 - [X86] Assign a feature priority to 'tigerlake' so it won't assert when used with function multiversioning

2020-06-21 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-21T13:24:58-07:00 New Revision: 1d4c87335d5236ea1f35937e1014980ba961ae34 URL: https://github.com/llvm/llvm-project/commit/1d4c87335d5236ea1f35937e1014980ba961ae34 DIFF: https://github.com/llvm/llvm-project/commit/1d4c87335d5236ea1f35937e1014980ba961ae34.diff

[clang] 42c176c - [X86] Add 'cooperlake' and 'tigerlake' to __builtin_cpu_is.

2020-06-21 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-21T13:03:18-07:00 New Revision: 42c176c32851833f32863412e74235f085adc801 URL: https://github.com/llvm/llvm-project/commit/42c176c32851833f32863412e74235f085adc801 DIFF: https://github.com/llvm/llvm-project/commit/42c176c32851833f32863412e74235f085adc801.diff

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:31-32 +template struct OptionEnumMapping { + // Must provide: + // static ArrayRef> getEnumMapping(); +}; aaron.ballman wrote: > Any reason not to do: > ``` > static

[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:570 + +// We don't want a warning here as the call to this in Foo is in a scratch +// buffer so its fix-it

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272317. njames93 marked 2 inline comments as done. njames93 added a comment. Use `= delete` for getEnumMapping in template definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

[PATCH] D82223: [clang-tidy] Implement storeOptions for checks missing it.

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdb90d315706b: [clang-tidy] Implement storeOptions for checks missing it. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82223/new/

[clang-tools-extra] db90d31 - [clang-tidy] Implement storeOptions for checks missing it.

2020-06-21 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-06-21T19:01:11+01:00 New Revision: db90d315706b5d5a06cb79607cef1a8d581d0ba8 URL: https://github.com/llvm/llvm-project/commit/db90d315706b5d5a06cb79607cef1a8d581d0ba8 DIFF: https://github.com/llvm/llvm-project/commit/db90d315706b5d5a06cb79607cef1a8d581d0ba8.diff

[PATCH] D82185: [Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers

2020-06-21 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:256 + SVal SubVal = State->getSVal(UO->getSubExpr(), C.getLocationContext()); + SVal Result = State->getSVal(UO,

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I like the direction of this, thank you! LGTM with a small suggestion, but you should wait a few days in case one of the other reviewers has comments. Comment

[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:570 + +// We don't want a warning here as the call to this in Foo is in a scratch +// buffer so its fix-it wouldn't be applied, resulting in invalid

[PATCH] D82223: [clang-tidy] Implement storeOptions for checks missing it.

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82223/new/ https://reviews.llvm.org/D82223

[clang] 448bbc5 - fix clang/PCH/delayed-pch-instantiate test

2020-06-21 Thread Luboš Luňák via cfe-commits
Author: Luboš Luňák Date: 2020-06-21T19:00:42+02:00 New Revision: 448bbc512f456df6fc817b0d7041897eea2375b7 URL: https://github.com/llvm/llvm-project/commit/448bbc512f456df6fc817b0d7041897eea2375b7 DIFF: https://github.com/llvm/llvm-project/commit/448bbc512f456df6fc817b0d7041897eea2375b7.diff

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, steveire, klimek, gribozavr. Currently, using the nullPointerConstant AST matcher can lead to assertions in situations where a node to be matched does not have a valid type associated with it, such as a ParenListExpr.

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

2020-06-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 ___ cfe-commits mailing

[PATCH] D69585: Add option to instantiate templates already in the PCH

2020-06-21 Thread Luboš Luňák via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa45f713c6730: add option to instantiate templates already in the PCH (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69585?vs=265918=272312#toc Repository: rG LLVM Github

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

2020-06-21 Thread Luboš Luňák via Phabricator via cfe-commits
llunak added a comment. So what more needs to be done here to get this change accepted? It's already missed 10.0 and 11.1 is getting branched off in about 3 weeks. - The change was already accepted once and the problem leading to its revert has already been fixed. - It just enables for PCH

[clang] a45f713 - add option to instantiate templates already in the PCH

2020-06-21 Thread Luboš Luňák via cfe-commits
Author: Luboš Luňák Date: 2020-06-21T17:05:52+02:00 New Revision: a45f713c673001abb4fe0612b909c698073eb356 URL: https://github.com/llvm/llvm-project/commit/a45f713c673001abb4fe0612b909c698073eb356 DIFF: https://github.com/llvm/llvm-project/commit/a45f713c673001abb4fe0612b909c698073eb356.diff

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

2020-06-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: klimek, ymandel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Skip over elidable nodes, and ensure that intermediate CXXFunctionalCastExpr nodes are also skipped if they are semantic. Repository: rG LLVM

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

2020-06-21 Thread Juneyoung Lee via Phabricator via cfe-commits
aqjune added a comment. In D81678#2105077 , @eugenis wrote: > > Could you explicitly state that if it is aggregate or vector type all > > elements and paddings should be frozen too? > > If an aggregate is passed as an aggregate at IR level, we should not

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

2020-06-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert requested changes to this revision. jdoerfert added a comment. This revision now requires changes to proceed. First, apologies for being late, I didn't properly monitor the list recently. --- This diff is impossible to review and later to understand. I would ask you to split it, at

[clang] 0dbeffd - [clang][utils] Minor tweak to make-ast-dump-check.sh

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:10+01:00 New Revision: 0dbeffddd1decda612f00e552c35cbcdb59907ab URL: https://github.com/llvm/llvm-project/commit/0dbeffddd1decda612f00e552c35cbcdb59907ab DIFF: https://github.com/llvm/llvm-project/commit/0dbeffddd1decda612f00e552c35cbcdb59907ab.diff

[clang] ecbf2f5 - [clang][test][NFC] Also test for serialization in AST dump tests, part 2/n.

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:11+01:00 New Revision: ecbf2f5f3d2e2868c6059320c185897f8f23de41 URL: https://github.com/llvm/llvm-project/commit/ecbf2f5f3d2e2868c6059320c185897f8f23de41 DIFF: https://github.com/llvm/llvm-project/commit/ecbf2f5f3d2e2868c6059320c185897f8f23de41.diff

[clang] ef3adbf - [clang][NFC] Fix typos/wording in the comments of ConstantExpr.

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:10+01:00 New Revision: ef3adbfc70bd593e14430c2db31c1426d3834fb4 URL: https://github.com/llvm/llvm-project/commit/ef3adbfc70bd593e14430c2db31c1426d3834fb4 DIFF: https://github.com/llvm/llvm-project/commit/ef3adbfc70bd593e14430c2db31c1426d3834fb4.diff

[clang] e7ce052 - [clang][Serialization] Fix the serialization of ConstantExpr.

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:10+01:00 New Revision: e7ce0528202306d8b751f132d9d3a6519ce4e688 URL: https://github.com/llvm/llvm-project/commit/e7ce0528202306d8b751f132d9d3a6519ce4e688 DIFF: https://github.com/llvm/llvm-project/commit/e7ce0528202306d8b751f132d9d3a6519ce4e688.diff

[clang] e560280 - [clang][NFC] Regenerate test/AST/ast-dump-lambda.cpp with --match-full-lines.

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:11+01:00 New Revision: e560280cd5739503cd9a75e05da769a6742918b5 URL: https://github.com/llvm/llvm-project/commit/e560280cd5739503cd9a75e05da769a6742918b5 DIFF: https://github.com/llvm/llvm-project/commit/e560280cd5739503cd9a75e05da769a6742918b5.diff

[clang] cddc999 - [clang][test][NFC] Also test for serialization in AST dump tests, part 3/n.

2020-06-21 Thread Bruno Ricci via cfe-commits
Author: Bruno Ricci Date: 2020-06-21T13:59:11+01:00 New Revision: cddc9993eafd76f08989beea037d085521d48127 URL: https://github.com/llvm/llvm-project/commit/cddc9993eafd76f08989beea037d085521d48127 DIFF: https://github.com/llvm/llvm-project/commit/cddc9993eafd76f08989beea037d085521d48127.diff

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-21 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 272306. njames93 added a comment. Update doc comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

2020-06-21 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp:130 +llvm::errs() << " (" << ND->getQualifiedNameAsString() << ')'; + llvm::errs() << " {" << Call.getNumArgs() << '}'; +

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

2020-06-21 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Here's another example where it is not appropriate to transform a template instantiation: http://clang-developers.42468.n3.nabble.com/Questions-discussions-about-cast-types-in-clang-td4068626.html "If we call foo, it can be a const_cast, but if we call foo, it has to

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

2020-06-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Hmm, given that you're using ARC, you're probably intending to turn the review title/summary into a commit message. Let's make it prettier then: - Commit messages are typically written in imperative mood, eg. "Enabling" -> "Enable", "Adding"/"Added" -> "Add". -

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

2020-06-21 Thread Wenlei He via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7c8a6936bf6b: [Remarks] Add callsite locations to inline remarks (authored by wenlei). Changed prior to commit: https://reviews.llvm.org/D82213?vs=272263=272289#toc Repository: rG LLVM Github

[clang] 7c8a693 - [Remarks] Add callsite locations to inline remarks

2020-06-21 Thread Wenlei He via cfe-commits
Author: Wenlei He Date: 2020-06-20T23:32:10-07:00 New Revision: 7c8a6936bf6b578518673f442c6c292d62cdd465 URL: https://github.com/llvm/llvm-project/commit/7c8a6936bf6b578518673f442c6c292d62cdd465 DIFF: https://github.com/llvm/llvm-project/commit/7c8a6936bf6b578518673f442c6c292d62cdd465.diff