[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272910. lxfind added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82415/new/ https://reviews.llvm.org/D82415 Files: clang/lib/Sema/SemaCoroutine.cpp Index:

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-23 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. In D82029#2109167 , @lxfind wrote: > Test failures are being fixed in https://reviews.llvm.org/D82338/new/ Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

2020-06-23 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG050ed9720f84: [cmake] configure the host triple on an Apple Silicon machine correctly (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D82428?vs=272891=272908#toc Repository:

[clang] 1a342ff - test fix: add missing system-darwin REQUIRES

2020-06-23 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-23T21:17:58-07:00 New Revision: 1a342ff3753d0354bab3d82fa8e493e21d50c79f URL: https://github.com/llvm/llvm-project/commit/1a342ff3753d0354bab3d82fa8e493e21d50c79f DIFF: https://github.com/llvm/llvm-project/commit/1a342ff3753d0354bab3d82fa8e493e21d50c79f.diff

[clang] 565603c - [clang][driver] set macOS as the target OS for -arch arm64 when clang

2020-06-23 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-23T21:08:11-07:00 New Revision: 565603cc94d79a8d0de6df840fd53714899fb890 URL: https://github.com/llvm/llvm-project/commit/565603cc94d79a8d0de6df840fd53714899fb890 DIFF: https://github.com/llvm/llvm-project/commit/565603cc94d79a8d0de6df840fd53714899fb890.diff

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

2020-06-23 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: nemanjai, lei, saghir, hfinkel, power-llvm-team, PowerPC. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements builtins for the following prototypes: int vec_test_lsbb_all_ones (vector

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-23 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. ping for code review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

2020-06-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D82428#2110506 , @steven_wu wrote: > LGTM. > > Not sure if it makes more sense to break the patch into two commits: > > - config.guess change is for building the correct host triple on apple > silicon machine without

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272905. lxfind added a comment. Address lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82415/new/ https://reviews.llvm.org/D82415 Files: clang/lib/Sema/SemaCoroutine.cpp Index:

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272904. lxfind added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Tackle this problem inside CoroSplit as an optimization. Instead of only handling one particular case, we now look at every local variable in the

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

2020-06-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: c-rhodes, kmclaughlin, efriedma, sdesmalen, ctetreau. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added projects: clang, LLVM. The following intrinsics has been added:

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. In D82314#2109437 , @lxfind wrote: > In D82314#2107910 , @junparser wrote: > > > Rather than doing it here, can we build await_resume call expression with > > MaterializedTemporaryExpr

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-23 Thread Ahsan Saghir via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. saghir marked an inline comment as done. Closed by commit rGf4c337ab85c0: [PowerPC] Add support for vector bool __int128 for Power10 (authored by saghir). Changed prior to commit:

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. In D82314#2109893 , @rsmith wrote: > In D82314#2109728 , @lxfind wrote: > > > @rsmith Thanks. That's a good point. Do you know if there already exists > > optimization passes in LLVM

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-23 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1881 + if (isAIXLayout(Context) && FieldOffset == CharUnits::Zero() && + (IsUnion || NonOverlappingEmptyFieldFound)) { +FirstNonOverlappingEmptyFieldHandled = true;

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

2020-06-23 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

2020-06-23 Thread Steven Wu via Phabricator via cfe-commits
steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Not sure if it makes more sense to break the patch into two commits: - config.guess change is for building the correct host triple on apple silicon machine without explicitly

[PATCH] D82428: [clang][driver] allow `-arch arm64` to be used to build for mac when on Apple Silicon Mac without explicit `-target`

2020-06-23 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, danielkiss, ributzka, jkorous, kristof.beyls, mgorny. Herald added a project: LLVM. steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted

[clang] f4c337a - [PowerPC] Add support for vector bool __int128 for Power10

2020-06-23 Thread Ahsan Saghir via cfe-commits
Author: Ahsan Saghir Date: 2020-06-23T21:25:56-05:00 New Revision: f4c337ab85c0b7ec206da0f2c6576730eefb36c2 URL: https://github.com/llvm/llvm-project/commit/f4c337ab85c0b7ec206da0f2c6576730eefb36c2 DIFF: https://github.com/llvm/llvm-project/commit/f4c337ab85c0b7ec206da0f2c6576730eefb36c2.diff

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-23 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added reviewers: hans, nick. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some libraries use empty function to ignore unused variable warnings, which gets a new warning from `-Wuninitialized-const-reference`, discussed here

[PATCH] D82346: [WebAssebmly] Fully disable 'protected' visibility

2020-06-23 Thread Sam Clegg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5804a8b1228b: [WebAssebmly] Fully disable protected visibility (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82346/new/

[clang] 5804a8b - [WebAssebmly] Fully disable 'protected' visibility

2020-06-23 Thread Sam Clegg via cfe-commits
Author: Sam Clegg Date: 2020-06-23T17:50:05-07:00 New Revision: 5804a8b1228ba890d48f4085a3a192ef83c73e00 URL: https://github.com/llvm/llvm-project/commit/5804a8b1228ba890d48f4085a3a192ef83c73e00 DIFF: https://github.com/llvm/llvm-project/commit/5804a8b1228ba890d48f4085a3a192ef83c73e00.diff

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-06-23 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D79895#2110345 , @nick wrote: > > We didn't see it in the code bases I work with, so is boost a special case, > > or an example of a common practice? > > I do not have resources to make such statistics, but there are

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbf8b63ed296c: [clang codegen] Fix alignment of Address for incomplete array pointer. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-06-23 Thread Nikita Kniazev via Phabricator via cfe-commits
nick added a comment. > We didn't see it in the code bases I work with, so is boost a special case, > or an example of a common practice? I do not have resources to make such statistics, but there are compilers where casting to void is not enough to suppress the warning.

[clang] bf8b63e - [clang codegen] Fix alignment of "Address" for incomplete array pointer.

2020-06-23 Thread Eli Friedman via cfe-commits
Author: Eli Friedman Date: 2020-06-23T17:16:17-07:00 New Revision: bf8b63ed296c1ecad03c83b798ffbfa039cbceb4 URL: https://github.com/llvm/llvm-project/commit/bf8b63ed296c1ecad03c83b798ffbfa039cbceb4 DIFF: https://github.com/llvm/llvm-project/commit/bf8b63ed296c1ecad03c83b798ffbfa039cbceb4.diff

[clang] d144601 - DR458: Search template parameter scopes in the right order.

2020-06-23 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-23T17:14:33-07:00 New Revision: d1446017f3fdc2f6a9efba222008d20afa1e26cc URL: https://github.com/llvm/llvm-project/commit/d1446017f3fdc2f6a9efba222008d20afa1e26cc DIFF: https://github.com/llvm/llvm-project/commit/d1446017f3fdc2f6a9efba222008d20afa1e26cc.diff

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow =

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 272855. guiand added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand marked 4 inline comments as done. guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3331 + // case Intrinsic::x86_avx512_mask_sub_sd_round: + // case Intrinsic::x86_avx512_mask_mul_sd_round: + // case

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In D81678#2109059 , @nlopes wrote: > I'm a bit concerned with this patch as it increases the amount of UB that > LLVM exploits without any study of the impact. > For example, right now it's ok do this with clang (not with

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. >> Also, what's the plan to detect these cases in ubsan? > > I don't think this has any practical impact on our goals with sanitizers. We > should detect undefined behavior before it gets to the point of actually > passing or returning an undef or poison value. MSan

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

2020-06-23 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4095 +} + } call->setCallingConv(getRuntimeCC()); eugenis wrote: > guiand wrote: > > jdoerfert wrote: > > > Why would we do this? Function attributes are valid at the call site, no

[clang] 4f5f6c1 - Move late-parsed class member attribute handling adjacent to all the

2020-06-23 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-23T15:43:11-07:00 New Revision: 4f5f6c1b83cb60354b7b4dea8fc7da561b6758fd URL: https://github.com/llvm/llvm-project/commit/4f5f6c1b83cb60354b7b4dea8fc7da561b6758fd DIFF: https://github.com/llvm/llvm-project/commit/4f5f6c1b83cb60354b7b4dea8fc7da561b6758fd.diff

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument : F.args()) { avl wrote:

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second, LowShadow, IRB.getInt32(0)); + guiand wrote: > eugenis

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

2020-06-23 Thread Changpeng Fang via Phabricator via cfe-commits
cfang added a comment. -ffast-math flag got lost in the Builder after this change. FMF.isFast() is true before updateFastMathFlags(FMF, FPFeatures), but turns false after. It seems the Builder.FMF has been correctly set before, but I am not clear what FPFeatures should be at this point:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Alexey Lapshin via Phabricator via cfe-commits
avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument :

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 272842. guiand added a comment. Use shufflevector, move test over to IR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files:

[PATCH] D82386: [clangd] Config: Fragments and parsing from YAML

2020-06-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/ConfigFragment.h:9 +// +// Various clangd features have configurable behaviour (or can be disabled). +// The configuration system allows users to control this: i think this paragraph belongs to

[PATCH] D82415: [Coroutines] Special handle __builtin_coro_resume for final_suspend nothrow check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. Herald added subscribers: cfe-commits, modocache. Herald added a project: clang. lxfind added reviewers: modocache, lewissbaker, junparser. lxfind requested review of this revision. In https://reviews.llvm.org/D82029 we added the conformance check that the

[clang] 4935419 - Remove clang::Codegen::EHPadEndScope as unused

2020-06-23 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2020-06-23T15:18:49-07:00 New Revision: 4935419d779bdc6cc2f1c2f9e78821ad550d3b56 URL: https://github.com/llvm/llvm-project/commit/4935419d779bdc6cc2f1c2f9e78821ad550d3b56 DIFF: https://github.com/llvm/llvm-project/commit/4935419d779bdc6cc2f1c2f9e78821ad550d3b56.diff

[clang] f724ce0 - [clang][driver] allow macOS 11 OS version in the driver

2020-06-23 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-23T15:14:26-07:00 New Revision: f724ce0d73eb3f85364e346a036588825bc47567 URL: https://github.com/llvm/llvm-project/commit/f724ce0d73eb3f85364e346a036588825bc47567 DIFF: https://github.com/llvm/llvm-project/commit/f724ce0d73eb3f85364e346a036588825bc47567.diff

[PATCH] D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information.

2020-06-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: echristo, erichkeane, LuoYuanke. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. craig.topper added reviewers: RKSimon, spatel. craig.topper marked an inline comment as done. craig.topper added inline

[PATCH] D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information.

2020-06-23 Thread Craig Topper via Phabricator via cfe-commits
craig.topper marked an inline comment as done. craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:36 + // i386-generation processors. + { "i386", CK_i386, ~0U, PROC_32_BIT }, + // i486-generation processors. Once we have

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument : F.args()) { avl wrote:

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. In D82249#2110054 , @hctim wrote: > In D82249#2109920 , @eugenis wrote: > > > I'm OK with this as a workaround, but it would be more natural to detect > > the unsupported IR pattern in

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-23 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. In D82249#2110010 , @arsenm wrote: > I don't follow. It no longer falls back, so what is the problem? HWASan-globals end up with an address that's outside of the code model (due to the tag), so the normal instruction sequence of

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. > This patch changes types of some integer function arguments or return values > from si_int to the default int type (typedefed to native_int to make it > obvious this is intentional) to make it more compatible with libgcc. Please drop

[clang] a6308c0 - When performing a substitution into a dependent alias template, mark the

2020-06-23 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-06-23T14:43:04-07:00 New Revision: a6308c0ad954a08645d9abf0a5e77dc488b8ca28 URL: https://github.com/llvm/llvm-project/commit/a6308c0ad954a08645d9abf0a5e77dc488b8ca28 DIFF: https://github.com/llvm/llvm-project/commit/a6308c0ad954a08645d9abf0a5e77dc488b8ca28.diff

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Alexey Lapshin via Phabricator via cfe-commits
avl updated this revision to Diff 272829. avl edited the summary of this revision. avl added a comment. addressed comments: 1. removed PointerMayBeCaptured() used for CalledFunction. 2. rewrote CanTRE() to visiting instructions only once. 3. replaced areAllLastFuncCallsRecursive() with

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 272828. fpetrogalli added a comment. Updates: 1. extracted bfloat C tests into separate files (`*-bfloat.c). 2. Added missing tests (`clast[a|b]`, `last[a|b]`) 3. Tested warning is raised for missing declaration when macro `__ARM_FEATURE_SVE_BF16` is

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-23 Thread Mitch Phillips via Phabricator via cfe-commits
hctim added a comment. In D82249#2109920 , @eugenis wrote: > I'm OK with this as a workaround, but it would be more natural to detect the > unsupported IR pattern in globalisel and fall back instead of disabling it > entirely. Is it difficult to do for

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-23 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 272824. Xiangling_L marked 2 inline comments as done. Xiangling_L added a comment. Adjust the function name; Adjust the comment; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 Files:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-23 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. I need to make another revision that makes a couple more of the fp options, like ffp-contract, "benign" and add a test case that demonstrates fp options don't carry over from pch-create to pch-use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-23 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D82249#2107845 , @hctim wrote: > In D82249#2105036 , @arsenm wrote: > > > Is the fallback not working correctly in this case for some reason? > > > I'm fairly sure that G_GLOBAL_VALUE

[PATCH] D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp

2020-06-23 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG47fb21d2ea90: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp (authored by LukeZhuang, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`

2020-06-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, as previous version only saves a single character, i.e. pressing a single tab after qualifier vs hitting `:` twice, while it is annoying for the non-qualified case, now you need to

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Alexey Lapshin via Phabricator via cfe-commits
avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument :

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks LGTM! Comment at: clang-tools-extra/clangd/index/Background.h:140 + // In production an explicit value is passed. + size_t ThreadPoolSize = 4,

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

2020-06-23 Thread Jeff Trull via Phabricator via cfe-commits
jaafar updated this revision to Diff 272813. jaafar marked an inline comment as done. jaafar added a comment. One more simplification from Aaron. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files:

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. LGTM I'm OK with this as a workaround, but it would be more natural to detect the unsupported IR pattern in globalisel and fall back instead of disabling it entirely. Is it difficult to do for some reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-06-23 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Two nits and one question about removed check lines. If they can be re-added, LGTM. Otherwise we need to look into that. Comment at:

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

2020-06-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Support/Triple.cpp:220 case Win32: return "windows"; + case ZOS: +return "zos"; Follow the local style by deleting the newline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/

[clang] 47fb21d - fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp

2020-06-23 Thread Erich Keane via cfe-commits
Author: Zhi Zhuang Date: 2020-06-23T13:34:35-07:00 New Revision: 47fb21d2ea903fc4cce38f8da8160cf0eacc16d0 URL: https://github.com/llvm/llvm-project/commit/47fb21d2ea903fc4cce38f8da8160cf0eacc16d0 DIFF: https://github.com/llvm/llvm-project/commit/47fb21d2ea903fc4cce38f8da8160cf0eacc16d0.diff

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-23 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 272808. mibintc added a comment. The difference between this patch and the earlier one today is that I modified the new test case I misunderstood why the test case was failing. The BENIGN_LANGOPT is working as desired and those pch diagnostics are no

[PATCH] D81285: [builtins] Change si_int to int in some helper declarations

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. (Please wait a few days before merging to see if anyone else has comments.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81285/new/

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

2020-06-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks for the info @uabelho! this looks like a dormant warning though, as StringRef is not implicitly convertible to NoneType (and vice-versa) hence anyone trying to make use of the hidden overload would get a hard compile error anyways. Moreover this class is mostly

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand marked an inline comment as done. guiand added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second, LowShadow, IRB.getInt32(0)); +

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D82314#2109728 , @lxfind wrote: > @rsmith Thanks. That's a good point. Do you know if there already exists > optimization passes in LLVM that attempts to shrink the range of lifetime > intrinsics? If so, I am curious why that

[PATCH] D82224: [OpenMP][NFC] Remove hard-coded line numbers from test

2020-06-23 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thx! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82224/new/ https://reviews.llvm.org/D82224 ___

[PATCH] D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp

2020-06-23 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang updated this revision to Diff 272805. LukeZhuang added a comment. Fixed. If it looks good to you, could you please help me commit it? Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82403/new/ https://reviews.llvm.org/D82403 Files:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument : F.args()) { avl wrote:

[PATCH] D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp

2020-06-23 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 suggestion to the test, but otherwise looks OK. Let me know if you'd like this committed for you. Comment at:

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-23 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 272798. mibintc added a comment. I responded to review from @riccibruno and @rjmccall : I put the dump() routines into the .cpp file and changed them to use the x-macros. I moved CXXOperatorCall.FPOptionsOverride from the Expr bits into the OperatorCall

[PATCH] D82403: fix test failure for clang/test/CodeGen/builtin-expect-with-probability.cpp

2020-06-23 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang created this revision. LukeZhuang added a reviewer: erichkeane. LukeZhuang added projects: LLVM, clang. Herald added a subscriber: cfe-commits. LukeZhuang edited the summary of this revision. Fix test case added by D79830 Rewrite the test case, which

[PATCH] D79830: Add support of __builtin_expect_with_probability

2020-06-23 Thread Zhi Zhuang via Phabricator via cfe-commits
LukeZhuang added a comment. In D79830#2109324 , @erichkeane wrote: > @LukeZhuang : This patch causes the buildbots to fail, as O1 > means something slightly > different with the new pass manager : > >

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Alexey Lapshin via Phabricator via cfe-commits
avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument :

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. @rsmith Thanks. That's a good point. Do you know if there already exists optimization passes in LLVM that attempts to shrink the range of lifetime intrinsics? If so, I am curious why that does not help in this case. Or is it generally unsafe to move the lifetime

[PATCH] D81176: [HIP] Add default header and include path

2020-06-23 Thread Han Zhu via Phabricator via cfe-commits
zhuhan0 added a comment. In D81176#2106382 , @yaxunl wrote: > In D81176#2105944 , @zhuhan0 wrote: > > > This broke a test `clang/test/Tooling/clang-check-offload.cpp` for a > > critical Linux distro at Facebook.

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D82314#2109437 , @lxfind wrote: > In D82314#2107910 , @junparser wrote: > > > Rather than doing it here, can we build await_resume call expression with > > MaterializedTemporaryExpr when

[PATCH] D82332: [Coroutines] Handle dependent promise types for final_suspend non-throw check

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind created this revision. Herald added subscribers: cfe-commits, modocache. Herald added a project: clang. lxfind updated this revision to Diff 272553. lxfind added a comment. lxfind added reviewers: Benabik, lewissbaker, junparser. lxfind updated this revision to Diff 272786. lxfind edited

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-23 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument : F.args()) { avl wrote:

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Evgenii Stepanov via Phabricator via cfe-commits
eugenis added a comment. The test should be in LLVM, under test/Instrumentation/MemorySanitizer Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:3077 +Value *LowShadow = IRB.CreateOr(LowA, LowB); +Value *Shadow = IRB.CreateInsertElement(Second,

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

2020-06-23 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. In D79895#2109414 , @nick wrote: > > I feel like doing interprocedural analysis for this is overkill. What is > > the benefit of boost::ignore_unused(foo); rather than the more common > > (void) foo;? Any examples? > > > > > I

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; c-rhodes wrote: >

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 272776. guiand added a comment. Ran clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82398/new/ https://reviews.llvm.org/D82398 Files: clang/test/CodeGen/msan-intrinsics.c

[PATCH] D82399: [AArch64][SVE2] Add bfloat16 support to whilerw/whilewr intrinsics

2020-06-23 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, efriedma, kmclaughlin, david-arm, fpetrogalli, stuij. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82399

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-06-23 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2424 + (T->isSpecificBuiltinType(BuiltinType::LongDouble) && + Target->supportsAIXPowerAlignment())) // Don't increase the alignment if an alignment attribute was specified on

[PATCH] D82398: [MSAN] Handle x86 {round,min,max}sd intrinsics

2020-06-23 Thread Gui Andrade via Phabricator via cfe-commits
guiand created this revision. guiand added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. guiand updated this revision to Diff 272776. guiand added a comment. Ran clang-format These need special handling over the simple

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

2020-06-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82298/new/ https://reviews.llvm.org/D82298 ___ cfe-commits

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-23 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 3 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen)

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

2020-06-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } Why ` llvm::dbgs() << llvm::getBugReportMsg();` when -gen-reproducer is specified? The user requests to generate a reproduce

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-23 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with `KeyPathPrefix` moved to the patch that actually uses it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen) jdoerfert wrote: > clementval wrote: > > thakis

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-23 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D78655#2108047 , @pfultz2 wrote: > > Could you give an example to demonstrate current use and how it will break? > > Here is place where it would break: > >

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

2020-06-23 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin updated this revision to Diff 272759. kmclaughlin added a comment. - Moved bfloat tests into separate files - Added checks to the bfloat test files which test the warnings given when ARM_FEATURE_SVE_BF16 is omitted in the RUN line CHANGES SINCE LAST ACTION

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

2020-06-23 Thread Zoe Carver via Phabricator via cfe-commits
zoecarver created this revision. zoecarver added reviewers: rjmccall, mboehme. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `CodeGen::emitCXXDestructorCall`, a function that creates a CodeGenFunction using the arguments provided, then invokes

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

2020-06-23 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, kmclaughlin, efriedma, david-arm, fpetrogalli. Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-23 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82314#2107910 , @junparser wrote: > Rather than doing it here, can we build await_resume call expression with > MaterializedTemporaryExpr when expand the coawait expression. That's how gcc > does. There doesn't appear to be

  1   2   3   >