[PATCH] D82199: [clang-format] restore indent in conditionals when AlignOperands is DontAlign

2020-06-24 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6287 + Style.BreakBeforeTernaryOperators = false; + verifyFormat("int x = aaa ? aa :\n" + "? cc :\n"

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-24 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 273226. hliao added a comment. Rebase to the trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > jdoerfert wrote: > >

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, maybe a minor adjustment necessary. Comment at: clang/lib/Basic/OpenMPKinds.cpp:583 OpenMPDirectiveKind DKind) { - assert(DKind <= OMPD_unknown); +

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. @vrnithinkumar what's your preferred `Full Name ` for llvm's git? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/ https://reviews.llvm.org/D82256 ___ cfe-commits mailing

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 273225. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. Add predicate to the patterns in the backend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82429/new/

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:7 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -triple

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:452 + EquivalenceClass(const EquivalenceClass &) = default; + EquivalenceClass =(const EquivalenceClass &) = default; + EquivalenceClass(EquivalenceClass &&) = default;

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked 11 inline comments as done. fpetrogalli added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-counting-bits.ll:1 ; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>%t | FileCheck %s ; RUN: FileCheck --check-prefix=WARN

[PATCH] D82461: [VE] Add clang tests for VE

2020-06-24 Thread Kazushi Marukawa via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6036bf53090e: [VE] Add clang tests for VE (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82461/new/ https://reviews.llvm.org/D82461

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Mmm, well, on second thought, no, that probably won't be sufficient. As long as we're willing to warn on containers about which we know //absolutely nothing//, we'll still have some of those false positives. And if we stop warning on such containers, the check will

[clang] 6036bf5 - [VE] Add clang tests for VE

2020-06-24 Thread Kazushi Marukawa via cfe-commits
Author: Kazushi (Jam) Marukawa Date: 2020-06-25T12:03:19+09:00 New Revision: 6036bf53090e03537f7d06a8daecda84a72a9bc9 URL: https://github.com/llvm/llvm-project/commit/6036bf53090e03537f7d06a8daecda84a72a9bc9 DIFF:

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval updated this revision to Diff 273216. clementval added a comment. add unsigned cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82518/new/ https://reviews.llvm.org/D82518 Files: clang/lib/Basic/OpenMPKinds.cpp

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D71607#2112228 , @MaskRay wrote: > +@NoQ on comments whether clang static analyzer can catch these cases. > > `clang++ --analyze a.cc` does not warn on `a.size()-2` AFAICT. Implementing such check in the static analyzer with the

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 3 inline comments as done. clementval added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:197 } return DKind < OMPD_unknown ? static_cast(DKind) : OMPD_unknown; vdmitrie wrote: > Should this

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval created this revision. clementval added reviewers: vdmitrie, jdoerfert, jdenny. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. Previously OMPD_unknown was last item in the Directive enumeration and its position was used in various

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

2020-06-24 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak created this revision. ahatanak added reviewers: rjmccall, hans. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes PR45997 (https://bugs.llvm.org/show_bug.cgi?id=45997), which is caused by a bug that has existed since we started passing

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I also recall `harfbuzz` having some fairly unsettling C++ code to analyze. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81592/new/ https://reviews.llvm.org/D81592 ___

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, that explains! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81598/new/ https://reviews.llvm.org/D81598

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

2020-06-24 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Thanks! I'll commit. Comment at: clang/lib/StaticAnalyzer/Core/CheckerManager.cpp:669 ProgramPoint L = ProgramPoint::getProgramPoint( - cast(Call.getOriginExpr()), + Call.getOriginExpr(),

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

2020-06-24 Thread Yifan Shen via Phabricator via cfe-commits
aelitashen updated this revision to Diff 273189. aelitashen added a comment. Formatting the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82505/new/ https://reviews.llvm.org/D82505 Files: clang/tools/clang-format/git-clang-format

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Nikita Kniazev via Phabricator via cfe-commits
nick added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:435 if ((*I)->getType().isConstQualified()) -classify((*I), ConstRefUse); +if (!hasTrivialBody(CE)) + classify((*I), ConstRefUse); zequanwu wrote:

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-24 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings jdoerfert wrote: > fghanim wrote: > > What's the benefit of this over just maintaining

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

2020-06-24 Thread Greg Clayton via Phabricator via cfe-commits
clayborg added a comment. This seems like a continuation of https://reviews.llvm.org/D82477. I would close this one down by selecting abandon revision, and then click the "update diff" button in D82477 and upload your new patch. I am guessing you did this

[PATCH] D82506: [HIP] Add missing options for lto

2020-06-24 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:76 +MAttrString.append(Args.MakeArgString(OneFeature)); +if (OneFeature != Features.back()) + MAttrString.append(","); I think StringRef will result in comparison by value.

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:435 if ((*I)->getType().isConstQualified()) -classify((*I), ConstRefUse); +if (!hasTrivialBody(CE)) + classify((*I),

[clang] 6330653 - [unittest] Fix FrontendTests CanGenerateCC1CommandLineFlag when LLVM_DEFAULT_TARGET_TRIPLE is not normalized after D79796

2020-06-24 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-06-24T16:18:58-07:00 New Revision: 6330653547f492646c92553738dab6a99d7d9710 URL: https://github.com/llvm/llvm-project/commit/6330653547f492646c92553738dab6a99d7d9710 DIFF: https://github.com/llvm/llvm-project/commit/6330653547f492646c92553738dab6a99d7d9710.diff

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 273184. zequanwu marked an inline comment as done. zequanwu added a comment. Add test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82425/new/ https://reviews.llvm.org/D82425 Files:

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-24 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3c5745cb1f3c: [clangd] Make background index thread count calculation clearer (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-24 Thread Valeriy Dmitriev via Phabricator via cfe-commits
vdmitrie added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:197 } return DKind < OMPD_unknown ? static_cast(DKind) : OMPD_unknown; Should this be a comparison against llvm::omp::Directive_enumSize rather than

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

2020-06-24 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. AFAIK CppCheck has little to no dependencies, you just need to clone and compile it, that might also be worth a shot. Rtags, tmux, capnproto are also relatively painless, and are also quick to analyze. Xerces also has very few dependencies, and is a mid-sized

[PATCH] D82506: [HIP] Add missing options for lto

2020-06-24 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, arsenm, ashi1. Herald added subscribers: dexonsmith, inglorion, wdng. Add -mcpu, -mattr, -mllvm, and -save-temps options for lto when necessary. https://reviews.llvm.org/D82506 Files: clang/lib/Driver/ToolChains/HIP.cpp

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-24 Thread Alexey Lapshin via Phabricator via cfe-commits
avl updated this revision to Diff 273174. avl added a comment. check valid TRE candidate into findTRECandidate()(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files:

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:140 + // In production an explicit value is passed. + size_t ThreadPoolSize = 4, std::function OnProgress = nullptr);

[PATCH] D82362: Move default module cache from system temporary directory

2020-06-24 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

2020-06-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up. I don't think I want to know how you came to meet the no-name selectors... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 3c5745c - [clangd] Make background index thread count calculation clearer

2020-06-24 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-06-25T00:18:53+02:00 New Revision: 3c5745cb1f3c501e551a8fa63b8f1d564c35016d URL: https://github.com/llvm/llvm-project/commit/3c5745cb1f3c501e551a8fa63b8f1d564c35016d DIFF: https://github.com/llvm/llvm-project/commit/3c5745cb1f3c501e551a8fa63b8f1d564c35016d.diff

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-24 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 273173. lxfind added a comment. Remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 Files: llvm/lib/Transforms/Coroutines/CoroSplit.cpp

[PATCH] D82505: [lldb-vscode] Add Support for Module Event

2020-06-24 Thread Yifan Shen via Phabricator via cfe-commits
aelitashen created this revision. aelitashen added reviewers: wallace, clayborg. aelitashen added a project: LLDB. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make lldb-vscode receive and process module events so that modules can be rendered in the IDE. Repository:

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

2020-06-24 Thread Jeff Trull via Phabricator via cfe-commits
jaafar added a comment. I do need someone to commit this, yes, thank you. I'm Jeff Trull edas...@att.net CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 ___ cfe-commits mailing list

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-24 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 273171. lxfind added a comment. A few unintended changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 Files: llvm/lib/Transforms/Coroutines/CoroSplit.cpp

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-06-24 Thread Amy Kwan via Phabricator via cfe-commits
amyk requested changes to this revision. amyk added a comment. This revision now requires changes to proceed. I have a few comments from the last time we looked at this together. Just also FYI that the backend tests will be apart of the `p10-vsx-builtins.ll` file introduced in

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-24 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 273169. lxfind added a comment. Actually it seems pretty easy to handle the case of multiple BitCastInst, so did it here. Also added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

2020-06-24 Thread Alexey Lapshin via Phabricator via cfe-commits
avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:830 + !CI->isTailCall()) +return false; +} laytonio wrote: > Is this correct? I think we want to

[PATCH] D82256: [analyzer] Enable constructor support in evalCall event

2020-06-24 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 273162. vrnithinkumar added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/ https://reviews.llvm.org/D82256 Files:

[PATCH] D80981: [AST] Fix a crash on accessing a class without definition in constexpr function context.

2020-06-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Minor suggestions but this LGTM. Comment at: clang/lib/AST/ExprConstant.cpp:4320 +if (!RD->hasDefinition()) + return

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Putting it on hold as we need to guard those patterns with `HasBF16`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-06-24 Thread Albion Fung via Phabricator via cfe-commits
Conanap created this revision. Conanap added reviewers: power-llvm-team, PowerPC, nemanjai, saghir, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Implemented following functions for Load VSX Vector Sign extend nad zero extend instructions: vector signed __int128 vec_xl_sext (signed

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: kmclaughlin, efriedma, ctetreau, sdesmalen, david-arm. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

2020-06-24 Thread Amy Kwan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd82f26cc4bc7: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit… (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D80941?vs=268470=273156#toc

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-24 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D81869#2112440 , @mibintc wrote: > I decided that I shouldn't make float options that define a macro, like > -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior > and rounding-mode BENIGN That

[PATCH] D82473: [Matrix] Use 1st/2nd instead of first/second in matrix diags.

2020-06-24 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82473/new/ https://reviews.llvm.org/D82473

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 3 inline comments as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > What's the benefit of

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-24 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 273147. hliao added a comment. Revise again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu

[clang] d82f26c - [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

2020-06-24 Thread Amy Kwan via cfe-commits
Author: Amy Kwan Date: 2020-06-24T16:03:45-05:00 New Revision: d82f26cc4bc7cb78f7ef327fa43a93e3d0ff9706 URL: https://github.com/llvm/llvm-project/commit/d82f26cc4bc7cb78f7ef327fa43a93e3d0ff9706 DIFF: https://github.com/llvm/llvm-project/commit/d82f26cc4bc7cb78f7ef327fa43a93e3d0ff9706.diff

Re: [clang] 1b8125b - Don't assert if we find a dependently-typed variable in the

2020-06-24 Thread David Blaikie via cfe-commits
Could/should this test be testing something more than "does not crash"? I'd expect here's some specific behavior that would be tested/desired rather than "anything other than crashing" - but I understand if it's not practical to test, or perhap insufficiently interesting with the new

Re: [clang] 719c87e - remove gold linker

2020-06-24 Thread David Blaikie via cfe-commits
(ah, sorry, saw the follow-up commit where this was reverted/committed by accident) On Wed, Jun 24, 2020 at 1:50 PM David Blaikie wrote: > > "Remove gold linker support from the PS4 toolchain" might've been a > more precise commit message - "Remove gold linker" seems a bit too > vague. > > On

Re: [clang] 719c87e - remove gold linker

2020-06-24 Thread David Blaikie via cfe-commits
"Remove gold linker support from the PS4 toolchain" might've been a more precise commit message - "Remove gold linker" seems a bit too vague. On Tue, Jun 16, 2020 at 1:03 PM Yuanfang Chen via cfe-commits wrote: > > > Author: Yuanfang Chen > Date: 2020-06-16T13:03:31-07:00 > New Revision:

Re: [clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces].

2020-06-24 Thread David Blaikie via cfe-commits
Generally it'd be helpful to describe what the change is in the subject line ("Add braces around initialization of a subobject [-Wmissing-braces]") as that's more informative than "Silence compiler warning [-Wmissing braces]", the latter doesn't say how it was silenced, which might make a

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-24 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I've forked off 1. D82497 (`getFileIDLocal` optimizations) 2. D82498 (don't check `Invalid` for calls to `getLocalSLocEntry`) I agree those should be the less controversial parts of this diff.

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-24 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:967 if (isOffsetInFileID(FileID::get(-int(MiddleIndex) - 2), SLocOffset)) { FileID Res = FileID::get(-int(MiddleIndex) - 2); kadircet wrote: > my comments above

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-24 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers retitled this revision from "[SourceManager] don't check Invalid param of getLocalSLocEntry()" to "[SourceManager] don't check

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. @tra After chatting with @hfinkel I know now why we don't see the calls in the libc++ case. libc++ implements std::complex without `_Complex` types, stdlib++ does. If the user uses `_Complex` directly we need these functions for sure as the standard defines them (I

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

2020-06-24 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. A recent Linux kernel commit exposed a performance cliff in Clang. Calls to SourceManager::getFileIDLocal() when there's a cache miss against

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-24 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:62-64 +// OPT-NOT: alloca +// OPT-NOT: ptrtoint +// OPT-NOT: inttoptr hliao wrote: > arsenm wrote: > > Positive checks are preferable (here and through the rest of

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

2020-06-24 Thread Fady Ghanim via Phabricator via cfe-commits
fghanim added a comment. Thanks for the Patch. I have few questions to help me understand what's going on. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings What's

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ https://reviews.llvm.org/D82324

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3f8913d2ad: Fix crash on XCore on unused inline in EmitTargetMetadata (authored by nigelp-xmos, committed by erichkeane). Changed prior to commit: https://reviews.llvm.org/D77068?vs=273100=273138#toc

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev marked an inline comment as done. ABataev added a comment. In D82324#2112388 , @jdoerfert wrote: > Let me rephrase. Does the user needs to request the fast path or the user > needs to request the slow but correct path? Only the former is

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

2020-06-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 273133. mibintc added a comment. I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN, I modified the pch test case to test that the

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-24 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:16 +template +class RecordingVisitorBase : public TestVisitor { + bool VisitPostOrder;

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Let me rephrase. Does the user needs to request the fast path or the user needs to request the slow but correct path? Only the former is acceptable IMHO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and to the right

2020-06-24 Thread Mikhail Brusnikin via Phabricator via cfe-commits
ambroyz added a comment. In D27651#2111783 , @MyDeveloperDay wrote: > I don't see any LLVM contributions from the original author @KP for some > time, @ambroyz are you pinging this issue because your keen for someone to > look at it? I'm not sure if

[clang] 56b530d - Fix a pair of wtype-limits and 3 wparentheses warnings from 29125ddf1

2020-06-24 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-06-24T12:50:25-07:00 New Revision: 56b530d92c42e962a1828e14783601d2861ba353 URL: https://github.com/llvm/llvm-project/commit/56b530d92c42e962a1828e14783601d2861ba353 DIFF: https://github.com/llvm/llvm-project/commit/56b530d92c42e962a1828e14783601d2861ba353.diff

[clang] dc3f891 - Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Erich Keane via cfe-commits
Author: Nigel Perks Date: 2020-06-24T12:48:17-07:00 New Revision: dc3f8913d2ad33b1129ea488393e12cc88061aff URL: https://github.com/llvm/llvm-project/commit/dc3f8913d2ad33b1129ea488393e12cc88061aff DIFF: https://github.com/llvm/llvm-project/commit/dc3f8913d2ad33b1129ea488393e12cc88061aff.diff

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a reviewer: kiranchandramohan. jdoerfert added a comment. @kiranchandramohan You can add yourself and others ;) Can we test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I talked to others about the test, and they suggested the correct way to validate this is to make it simply a 'doesn't crash' test, so I'll remove the filecheck/check lines and submit

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Personally, I think this behavior is a bit mysterious given that there are *much* better ways to silence unused variable warnings (like casting to `void`) that have been well-supported by compilers for a long time and I'd prefer not to penalize every call

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

2020-06-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added subscribers: NoQ, MaskRay. MaskRay added a comment. +@NoQ on comments whether clang static analyzer can catch these cases. `clang++ --analyze a.cc` does not warn on `a.size()-2` AFAICT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

2020-06-24 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar marked 5 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp:130 +llvm::errs() << " (" << ND->getQualifiedNameAsString() << ')'; + llvm::errs() << " {" <<

[PATCH] D82224: [OpenMP][NFC] Remove hard-coded line numbers from test

2020-06-24 Thread Joel E. Denny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG01ddb2a7b044: [OpenMP][NFC] Remove hard-coded line numbers from test (authored by jdenny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

2020-06-24 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Thank you for updating the patch with the missing tests. I only have one request for the code involving assertions, and the use of `let Predicates = ...`. Francesco

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

2020-06-24 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 273117. vrnithinkumar added a comment. Fixing test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/ https://reviews.llvm.org/D82256 Files:

[PATCH] D82224: [OpenMP][NFC] Remove hard-coded line numbers from test

2020-06-24 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. @jdoerfert Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82224/new/ https://reviews.llvm.org/D82224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81098/new/ https://reviews.llvm.org/D81098

[clang] cdd6a27 - [ObjC] Copy a block to the heap if it is passed as a variadic argument

2020-06-24 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-06-24T11:46:38-07:00 New Revision: cdd6a2788caced6b377af818154138d9983dba5f URL: https://github.com/llvm/llvm-project/commit/cdd6a2788caced6b377af818154138d9983dba5f DIFF:

[clang] 01ddb2a - [OpenMP][NFC] Remove hard-coded line numbers from test

2020-06-24 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-06-24T14:35:01-04:00 New Revision: 01ddb2a7b044f697a15043e47acdb93e2825809a URL: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a DIFF: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a.diff

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. gribozavr2 added reviewers: ymandel, eduucaldas. These tests show a bug: post-order traversal introduces an extra call to WalkUp*, that is not present in pre-order traversal. I'm fixing

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

2020-06-24 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, ymandel. How does RecursiveASTVisitor call the WalkUp callback for expressions? - In pre-order traversal mode, RecursiveASTVisitor calls the WalkUp

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-24 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Bumping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:410 + if (FunctionDecl *fd = CE->getDirectCallee()) { +if (FunctionTemplateDecl *ftd = fd->getPrimaryTemplate()) + return

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

2020-06-24 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 273103. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82425/new/ https://reviews.llvm.org/D82425 Files:

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Nigel Perks via Phabricator via cfe-commits
nigelp-xmos added a comment. I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" nig...@xmos.com ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068

[PATCH] D79472: [X86] Remove support some inline assembly constraints that are no longer supported by gcc.

2020-06-24 Thread Craig Topper via Phabricator via cfe-commits
craig.topper planned changes to this revision. craig.topper added a comment. I committed part of this, but got nervous when I found icc supported some of this. Still need to check our internal tests to see if they are used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3fa666b - [OpenMP][Docs] Mark TR8 `present` as claimed in docs

2020-06-24 Thread Joel E. Denny via cfe-commits
Author: Joel E. Denny Date: 2020-06-24T14:21:11-04:00 New Revision: 3fa666b883625a678cfcfd9ad96b2daabcef09e8 URL: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8 DIFF: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8.diff

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

2020-06-24 Thread Nigel Perks via Phabricator via cfe-commits
nigelp-xmos updated this revision to Diff 273100. nigelp-xmos retitled this revision from "[XCore] fix crash on unused inline in EmitTargetMetadata" to "Fix crash on XCore on unused inline in EmitTargetMetadata". nigelp-xmos added a comment. Added explanatory comment and CHECK lines to test

[PATCH] D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information.

2020-06-24 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc92142e3c5: [X86] Replace PROC macros with an enum and a lookup table of processor… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D82414?vs=272837=273101#toc

[PATCH] D78899: [Driver] Add callback to Command execution

2020-06-24 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >