[clang-tools-extra] c19e82c - [Docs] Fix typo and test git commit access. NFC.

2020-06-26 Thread via cfe-commits
Author: lh123 Date: 2020-06-27T13:35:59+08:00 New Revision: c19e82c6b38b74c56d595cb69582b7c3727762b5 URL: https://github.com/llvm/llvm-project/commit/c19e82c6b38b74c56d595cb69582b7c3727762b5 DIFF: https://github.com/llvm/llvm-project/commit/c19e82c6b38b74c56d595cb69582b7c3727762b5.diff LOG:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Where are the test cases? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 ___ cfe-commits mailing list

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D82617#2118253 , @sammccall wrote: > In D82617#2118118 , @dblaikie wrote: > > > In D82617#2117441 , @sammccall > > wrote: > > > > > In

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: ab, t.p.northover, dexonsmith. Herald added subscribers: llvm-commits, danielkiss, ributzka, jkorous, kristof.beyls. Herald added projects: clang, LLVM. arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12"

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. @t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the right target features when we're passing in a11 or older, so that's why my test file has the `INFER-A12` separate line. Do you think this is a bug? This is decided here: else if ((A =

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D82617#2118118 , @dblaikie wrote: > In D82617#2117441 , @sammccall wrote: > > > In D82617#2117086 , @Quuxplusone > > wrote: > > > > > FWIW, I

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-26 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked an inline comment as done. clementval added a comment. In D81736#2117858 , @thakis wrote: > This seems to cause build errors sometimes when buildling libclang. Maybe > there are more missing dependencies? Example failure: >

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

2020-06-26 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous, hiraditya. Herald added a project: LLVM. This change ensures that the Darwin driver doesn't add unsupported libraries to the link invocation when linking

[clang] 2b00cac - [darwin][driver] NFC, split addStartObjectFileArgs into multiple functions

2020-06-26 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-26T17:15:37-07:00 New Revision: 2b00cacb2835d11cab6f71466604b7b1bdd46a8d URL: https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d DIFF: https://github.com/llvm/llvm-project/commit/2b00cacb2835d11cab6f71466604b7b1bdd46a8d.diff

[clang] 253988f - [darwin][driver] Do not link with libarclite when building for Apple Silicon macOS

2020-06-26 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-06-26T17:15:37-07:00 New Revision: 253988f0f400201adb094d0f81d2c0c3fac94f4f URL: https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f DIFF: https://github.com/llvm/llvm-project/commit/253988f0f400201adb094d0f81d2c0c3fac94f4f.diff

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

2020-06-26 Thread Tom Stellard via Phabricator via cfe-commits
tstellar created this revision. tstellar added a reviewer: smeenai. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. If we are building static libraries we don't need to link them into clang-shlib, since clang-shlib already has all the individual object files linked

[clang] d298acd - [X86] Don't disable xsave when avx is disabled. Implicitly enable xsave with avx is enabled and xsave wasn't explciitly disabled

2020-06-26 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-06-26T16:45:44-07:00 New Revision: d298acde828f4abc5e7c82ba1f6092890d910097 URL: https://github.com/llvm/llvm-project/commit/d298acde828f4abc5e7c82ba1f6092890d910097 DIFF: https://github.com/llvm/llvm-project/commit/d298acde828f4abc5e7c82ba1f6092890d910097.diff

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

2020-06-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

2020-06-26 Thread Xun Li via Phabricator via cfe-commits
lxfind added a comment. In D82314#2117543 , @lewissbaker wrote: > > There are still room for improvements, in particular, GCC has a 4K frame > > for this function. > > I think GCC having a smaller coroutine frame is probably because it does not > yet

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D82617#2117441 , @sammccall wrote: > In D82617#2117086 , @Quuxplusone > wrote: > > > FWIW, I think the example you gave is **correct** for GCC to warn on. > > > Everything the warning

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674 , and reland with this hunk? That way if a revert is necessary in the future, it's only one. Also so that before/after metrics are together and

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:901 // across FileID lookups. if (!LocalSLocEntryTable[MiddleIndex].isExpansion()) LastFileIDLookup = Res; nickdesaulniers wrote: > oh, this case here

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers added a comment. Alternatively, I could revert dffc1420451f674

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Steven Wan via Phabricator via cfe-commits
stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList , +ArgStringList ) const { stevewan wrote: > I

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:901 // across FileID lookups. if (!LocalSLocEntryTable[MiddleIndex].isExpansion()) LastFileIDLookup = Res; oh, this case here should have been removed,

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-06-26 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:117-118 - // TODO: Add a note to bug reports describing this decision. - C.addTransition( -

[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files

2020-06-26 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. > Plus replacing a few std::map with llvm::StringMap That doesn't sound NFC since it changes ordering semantics. It seems to me like it should be done separately from the

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-06-26 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 273841. vrnithinkumar added a comment. Moving dereference precondition checks into `checkPreCall`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81315/new/ https://reviews.llvm.org/D81315 Files:

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 273835. gribozavr added a comment. Unified recordCallback and recordDefaultImplementation into one call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files:

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. > Now, in all the test cases we are calling the default implementation. We are > not surfacing that WalkUpFrom can not walk up. I think we are. The log of callbacks called from the default implementation is indented to the right, so we clearly see what the default

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. thanks a lot! haven't checked the tests yet. Comment at: clang-tools-extra/clangd/Hover.cpp:716 + for (unsigned I = 0; I < CE->getNumArgs() && I < FD->getNumParams(); ++I) { +auto *Arg = CE->getArg(I); +if (Arg != OuterNode.ASTNode.get())

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr updated this revision to Diff 273834. gribozavr added a comment. Removed an unused argument from recordDefaultImplementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files:

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/test/CodeGenCXX/aarch64-sve-typeinfo.cpp:4 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu %s -emit-llvm -o - \ -// RUN: -target-feature +sve | FileCheck %s +// RUN: -target-feature +sve,+bf16 | FileCheck %s

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c:9 +// A simple used,unused... macro, long enough to represent any SVE builtin. +#define SVE_ACLE_FUNC(A1,A2_UNUSED,A3,A4_UNUSED) A1##A3 +#else

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-26 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This seems to cause build errors sometimes when buildling libclang. Maybe there are more missing dependencies? Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8876400305251533648/+/steps/gclient_runhooks/0/stdout

[clang] b10bd6d - [NFC] Bump ObjCOrBuiltinIDBits to 15

2020-06-26 Thread JF Bastien via cfe-commits
Author: JF Bastien Date: 2020-06-26T13:48:51-07:00 New Revision: b10bd6dfc62161671892b2dd3be5152754d14995 URL: https://github.com/llvm/llvm-project/commit/b10bd6dfc62161671892b2dd3be5152754d14995 DIFF: https://github.com/llvm/llvm-project/commit/b10bd6dfc62161671892b2dd3be5152754d14995.diff

[clang] ddbdff3 - [sve][acle] Recommit https://reviews.llvm.org/D82501

2020-06-26 Thread Francesco Petrogalli via cfe-commits
Author: Francesco Petrogalli Date: 2020-06-26T20:45:29Z New Revision: ddbdff3accb667860d4cbd436746ca28ea343b25 URL: https://github.com/llvm/llvm-project/commit/ddbdff3accb667860d4cbd436746ca28ea343b25 DIFF:

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Steven Wan via Phabricator via cfe-commits
stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:167 +void AIX::AddClangSystemIncludeArgs(const ArgList , +ArgStringList ) const { I don't think this is the revision you intended to post.

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Reverted in https://github.com/llvm/llvm-project/commit/ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I appreciate you taking the time to review, and find additional optimizations! It's not populated yet, but IIUC, this should be the link with more test results:

[clang] ff5ccf2 - Revert "[sve][acle] Add reinterpret intrinsics for brain float."

2020-06-26 Thread Francesco Petrogalli via cfe-commits
Author: Francesco Petrogalli Date: 2020-06-26T20:19:49Z New Revision: ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c URL: https://github.com/llvm/llvm-project/commit/ff5ccf258e297df29f32d6b5e4fa0a7b95c44f9c DIFF:

[clang] 467ba4c - More corrections to documented spelling of ffinite-math to ffinite-math-only

2020-06-26 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2020-06-26T13:17:55-07:00 New Revision: 467ba4c92f5bfafd88e154c1657d6ac11dfb34df URL: https://github.com/llvm/llvm-project/commit/467ba4c92f5bfafd88e154c1657d6ac11dfb34df DIFF:

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. Ops, I accidentally removed the C tests... I'll revert, add the tests and recommit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdffc1420451f: [clang][SourceManager] cache Macro Expansions (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. > what would be really useful is to clarify your position on whether the > warning in clang is delivering value I have no special information on that. Clearly someone thought it was adding value when they added it (way back in 2009;

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

2020-06-26 Thread Shuhong Liu via Phabricator via cfe-commits
ShuhongL updated this revision to Diff 273819. ShuhongL retitled this revision from "[AIX] Modify AIX customized clang driver toolchain to include AIX system headers in search path" to "[Clang] Handle AIX Include management in the driver". ShuhongL edited the summary of this revision.

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

2020-06-26 Thread Lei Huang via Phabricator via cfe-commits
lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___ cfe-commits mailing list

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:426-427 + let Predicates = [HasSVE, HasBF16] in { +def : Pat<(nxv8bf16 (AArch64dup (bf16 FPR16:$src))), + (DUP_ZZI_H

[clang] 13fdcd3 - [NFC] Builtins: list 'R' for restrict

2020-06-26 Thread JF Bastien via cfe-commits
Author: JF Bastien Date: 2020-06-26T12:58:17-07:00 New Revision: 13fdcd37b325f62ff2513c59807de9ad0a9d2a51 URL: https://github.com/llvm/llvm-project/commit/13fdcd37b325f62ff2513c59807de9ad0a9d2a51 DIFF: https://github.com/llvm/llvm-project/commit/13fdcd37b325f62ff2513c59807de9ad0a9d2a51.diff

[clang] dffc142 - [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-26T12:52:43-07:00 New Revision: dffc1420451f674731cb36799c8ae084104ff0b5 URL: https://github.com/llvm/llvm-project/commit/dffc1420451f674731cb36799c8ae084104ff0b5 DIFF:

[clang] 7cc5307 - Correct documented spelling of ffinite-math to ffinite-math-only

2020-06-26 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2020-06-26T12:50:45-07:00 New Revision: 7cc5307c73caa72f22edd4208b175e3c36eec46e URL: https://github.com/llvm/llvm-project/commit/7cc5307c73caa72f22edd4208b175e3c36eec46e DIFF:

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

2020-06-26 Thread Vedant Kumar via Phabricator via cfe-commits
vsk updated this revision to Diff 273815. vsk added a comment. Use the `IsKindOfClass` CallArgList when emitting the check, and add a runtime test to ensure that an objc-cast diagnostic is not emitted on correct code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

2020-06-26 Thread John Brawn via Phabricator via cfe-commits
john.brawn updated this revision to Diff 273816. john.brawn edited the summary of this revision. john.brawn added a comment. Don't print the diagnostic with -gen-reproducer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 Files:

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

2020-06-26 Thread John Brawn via Phabricator via cfe-commits
john.brawn marked an inline comment as done. john.brawn added inline comments. Comment at: clang/tools/driver/driver.cpp:515 + + llvm::dbgs() << llvm::getBugReportMsg(); } MaskRay wrote: > john.brawn wrote: > > MaskRay wrote: > > > Why ` llvm::dbgs()

[PATCH] D71491: [ubsan] Check implicit casts in ObjC for-in statements

2020-06-26 Thread Vedant Kumar via Phabricator via cfe-commits
vsk marked 2 inline comments as done. vsk added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1860 + CGM.getObjCRuntime().GetClass(*this, InterfaceTy->getDecl()); + Args.add(RValue::get(Cls), C.getObjCClassType()); + llvm::Value *IsClass =

[PATCH] D82677: [AIX] Modify AIX customized clang driver toolchain to include AIX system headers in search path

2020-06-26 Thread Shuhong Liu via Phabricator via cfe-commits
ShuhongL created this revision. ShuhongL added reviewers: daltenty, stevewan. Herald added a project: clang. Herald added a subscriber: cfe-commits. ShuhongL retitled this revision from "Modify AIX customized clang driver toolchain to include AIX system headers in search path" to "[AIX] Modify

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:426-427 + let Predicates = [HasSVE, HasBF16] in { +def : Pat<(nxv8bf16 (AArch64dup (bf16 FPR16:$src))), + (DUP_ZZI_H (INSERT_SUBREG (IMPLICIT_DEF), FPR16:$src, hsub),

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 273813. fpetrogalli marked 7 inline comments as done. fpetrogalli added a comment. Hi @c-rhodes, I have addressed all your comments but one, the one that asks to add the test cases for the splat, as it deserves a separate patch. I will ping you when it

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. > indicating how I would disentangle that code if I owned it. Hopefully that > comment clarifies my position somewhat. So your position on how to best write that code is interesting (I disagree, but I think there are probably types of projects where your priorities

[clang] 9e03bde - AMDGPU: Add llvm.amdgcn.sqrt intrinsic

2020-06-26 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2020-06-26T15:07:07-04:00 New Revision: 9e03bdebc17a223416d682f64ef2046b8bf0fc98 URL: https://github.com/llvm/llvm-project/commit/9e03bdebc17a223416d682f64ef2046b8bf0fc98 DIFF:

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

2020-06-26 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. I have found this in ASTContext.h: // A traversal scope limits the parts of the AST visible to certain analyses. // RecursiveASTVisitor::TraverseAST will only visit reachable

[PATCH] D82675: [PowerPC][Power10] Implement Vector Extract Mask builtins in LLVM/Clang

2020-06-26 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, lei, saghir, kamaub. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch adds the implementation for the following function prototypes: unsigned int

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM! Thanks for bearing with me on splitting the patches and such! Let's land it and see if this is going to regress any projects. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

2020-06-26 Thread Lewis Baker via Phabricator via cfe-commits
lewissbaker added a comment. > There are still room for improvements, in particular, GCC has a 4K frame > for this function. I think GCC having a smaller coroutine frame is probably because it does not yet implement the allocation-elision optimisation which inlines the nested coroutine

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

2020-06-26 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: > We probably shouldn't check the effects of

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

2020-06-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. LGTM. Thank you for taking my comments into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620

[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files

2020-06-26 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 273792. njames93 added a comment. Herald added subscribers: usaxena95, kadircet, jkorous. Fix some issues with tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

2020-06-26 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS We probably shouldn't check the effects of LLVM passes in the

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Oops, I misread and forgot one point. The public interface can't (only) take `optional` because that's not implicitly convertible from a std::string which is what we usually want to pass. Thus the silly overloads, which we were going to fix with a more careful

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

2020-06-26 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a comment. A more general feedback. From our conversation one of the issues was that the tests wre only surfacing overriden methods. For instance, whenever we recorded a WalkUpFromExpr, and thus the callback showed up in the test, we actually did **not** walk up. Now, in all

[PATCH] D82661: [clang-tidy][NFC} Remove unnecessary includes throughout clang-tidy header files

2020-06-26 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I think will be good idea to run Include What You Use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82661/new/ https://reviews.llvm.org/D82661 ___ cfe-commits mailing

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. Cool, should be good for review. This change is now nice an isolated, in case we need to revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. In D82617#2117441 , @sammccall wrote: > In D82617#2117086 , @Quuxplusone > wrote: > > > FWIW, I think the example you gave is **correct** for GCC to warn on. > > > Everything the

[PATCH] D81920: [clangd] Change FSProvider::getFileSystem to take CurrentWorkingDirectory

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. > And then in class RealFileSystemProvider, you want to override > doGetDefaultFileSystem() while leaving doGetFileSystem untouched. Does that > basically reflect your intent here? Yes, except with fewer confusing names :-) The name used now (there was a rename

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

2020-06-26 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D82617#2117086 , @Quuxplusone wrote: > FWIW, I think the example you gave is **correct** for GCC to warn on. Everything the warning says is correct, but in this pattern the polymorphic usage is the whole point of the

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-06-26 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Why not legalize to the signed operation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 ___ cfe-commits mailing list

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-26 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 added a comment. > What's the expected HD property of this template function clip? I think it is intended to be host-only. The function `f` will launch a kernel or threads to utilize the passed lambda. Ideally, it would be nice to make all inlineable functions implicitly HD. There is

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

2020-06-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In D82598#2116373 , @xazax.hun wrote: > > I suspect that it would be pretty bad if you, say, kill the condition of > > the `if`-statement before picking the branch. Or kill the initializer in > > the `DeclStmt` before putting it

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 273780. nickdesaulniers added a comment. - rebase on D82497 & D82498 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80681/new/

[PATCH] D82662: [CodeGen] Use the common semantic for fixed-point codegen, not the result semantic.

2020-06-26 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82662/new/ https://reviews.llvm.org/D82662

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-26 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 273778. cchen added a comment. Rebase and resolve conflictions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, kmclaughlin, fpetrogalli. Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: clang. Patch adds tests for mangling of svbfloat16_t and

[PATCH] D82636: Work around a bug in MSVC in the syntax tree test

2020-06-26 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Hi Dmitri, Eduardo, thank you for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82636/new/ https://reviews.llvm.org/D82636 ___ cfe-commits mailing list

[PATCH] D82362: Move default module cache from system temporary directory

2020-06-26 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Reverted for now in 4d5c4489435dc1cb3d4989614e96b157c74afdea Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82362/new/ https://reviews.llvm.org/D82362

[clang] 4d5c448 - Revert "[clang driver] Move default module cache from system temporary directory"

2020-06-26 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-06-26T13:25:45-04:00 New Revision: 4d5c4489435dc1cb3d4989614e96b157c74afdea URL: https://github.com/llvm/llvm-project/commit/4d5c4489435dc1cb3d4989614e96b157c74afdea DIFF: https://github.com/llvm/llvm-project/commit/4d5c4489435dc1cb3d4989614e96b157c74afdea.diff

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Nick Desaulniers via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8cce7af090bd: [SourceManager] dont check invalid param of getLocalSLocEntry() (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82620: [clang-format] Preserve whitespace in selected macros

2020-06-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82620/new/ https://reviews.llvm.org/D82620

[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

2020-06-26 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes created this revision. c-rhodes added reviewers: sdesmalen, kmclaughlin, fpetrogalli. Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. - svget2/3/4 - svset2/3/4 - svcreate2/3/4 -

[clang] 8cce7af - [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-26T10:22:26-07:00 New Revision: 8cce7af090bd011f6371dec34dfcab494cc74c46 URL: https://github.com/llvm/llvm-project/commit/8cce7af090bd011f6371dec34dfcab494cc74c46 DIFF:

[PATCH] D82654: [libTooling] Improve error message from failure in selection Stencil

2020-06-26 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG30deabf89f93: [libTooling] Improve error message from failure in selection Stencil (authored by ymandel). Changed prior to commit: https://reviews.llvm.org/D82654?vs=273706=273763#toc Repository: rG

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan updated this revision to Diff 273762. ebevhan added a comment. Fixed some broken CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82663/new/ https://reviews.llvm.org/D82663 Files: clang/include/clang/Basic/FixedPoint.h

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-26 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. In D78655#2117216 , @pfultz2 wrote: > > Now, back to the specifics of your example. I'm still not 100% sure I > > understand what the problem is. Can you boil down the use case to an > > example on godbolt? > > I dont have a

[clang] 30deabf - [libTooling] Improve error message from failure in selection Stencil

2020-06-26 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2020-06-26T16:17:28Z New Revision: 30deabf89f93f724315e803ebcb2df09b8d36f2a URL: https://github.com/llvm/llvm-project/commit/30deabf89f93f724315e803ebcb2df09b8d36f2a DIFF: https://github.com/llvm/llvm-project/commit/30deabf89f93f724315e803ebcb2df09b8d36f2a.diff

[PATCH] D82662: [CodeGen] Use the common semantic for fixed-point codegen, not the result semantic.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added a reviewer: leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using the result semantic is wrong in some cases, such as unsigned fixed-point + signed integer. In this case, the result semantic is unsigned and the

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-06-26 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. The design of unsigned fixed-point with padding did not really work as originally intended downstream. The issue with the design is that

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-26 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 added a comment. > Now, back to the specifics of your example. I'm still not 100% sure I > understand what the problem is. Can you boil down the use case to an example > on godbolt? I dont have a specific example, but there could be code like this generic `clip` operator: template

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa15722c5ce47: [sve][acle] Add reinterpret intrinsics for brain float. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

2020-06-26 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 273745. amyk added a comment. Updated to the correct indentation for the functions in `altivec.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-26 Thread Chi Chun Chen via Phabricator via cfe-commits
cchen updated this revision to Diff 273747. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D82661: [clang-tidy] Remove unnecessary includes throughout clang-tidy header files

2020-06-26 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added subscribers: cfe-commits, lebedev.ri, arphaman, dexonsmith, steven_wu, kbarton, hiraditya, xazax.hun, nemanjai. Herald added a reviewer: lebedev.ri. Herald added a project: clang. Plus replacing a few

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-26 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 273742. adamcz marked 2 inline comments as done. adamcz added a comment. Formatting changed to spell out [const] reference and hide type unless conversion happens. Defining what the "correct" behavior is on various cases is very difficult. This is my best

[clang] a15722c - [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via cfe-commits
Author: Francesco Petrogalli Date: 2020-06-26T15:20:58Z New Revision: a15722c5ce4759c12960fe434ee6bd8aac70bb16 URL: https://github.com/llvm/llvm-project/commit/a15722c5ce4759c12960fe434ee6bd8aac70bb16 DIFF:

[PATCH] D82636: Work around a bug in MSVC in the syntax tree test

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfa1b48877618: Work around a bug in MSVC in the syntax tree test (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82636/new/

[PATCH] D82501: [sve][acle] Add reinterpret intrinsics for brain float.

2020-06-26 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 273737. fpetrogalli marked an inline comment as done. fpetrogalli added a comment. I removed the duplicate tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82501/new/ https://reviews.llvm.org/D82501

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

2020-06-26 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:646 + * receives a DataRecursionQueue, can't call WalkUpFrom after traversing \ + * children because it only enqueues the children.

  1   2   3   >