[PATCH] D81355: [PowerPC] Enable -fstack-clash-protection option for ppc64

2020-07-04 Thread Kai Luo via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG68e07da3e5d5: [clang][PowerPC] Enable -fstack-clash-protection option for ppc64 (authored by lkail). Changed prior to commit: https://reviews.llvm.org/D81355?vs=269094=275538#toc Repository: rG LLVM

Re: [clang-tools-extra] 7e2d27b - Fix two -Wrange-loop-analysis warnings that Xcode 12 beta incorrectly complains about

2020-07-04 Thread James Y Knight via cfe-commits
Seems like we should disable the warning for this compiler instead of making the code worse for the benefit of a temporarily broken warning? On Sat, Jul 4, 2020, 8:42 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Nico Weber > Date: 2020-07-04T20:41:33-04:00 > New

[clang] 68e07da - [clang][PowerPC] Enable -fstack-clash-protection option for ppc64

2020-07-04 Thread Kai Luo via cfe-commits
Author: Kai Luo Date: 2020-07-05T03:43:56Z New Revision: 68e07da3e5d5175e24caa309e2b13cb65c8c URL: https://github.com/llvm/llvm-project/commit/68e07da3e5d5175e24caa309e2b13cb65c8c DIFF: https://github.com/llvm/llvm-project/commit/68e07da3e5d5175e24caa309e2b13cb65c8c.diff LOG:

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-07-04 Thread Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
JohelEGP requested changes to this revision. JohelEGP added a comment. This revision now requires changes to proceed. Thank you. Everything I reported works fine now. I have two more cases for now. First are your examples in the OP. You have template concept bool EqualityComparable =

[clang-tools-extra] 7e2d27b - Fix two -Wrange-loop-analysis warnings that Xcode 12 beta incorrectly complains about

2020-07-04 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-07-04T20:41:33-04:00 New Revision: 7e2d27bc554eb607c90e55c89d2537f5d711234c URL: https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c DIFF: https://github.com/llvm/llvm-project/commit/7e2d27bc554eb607c90e55c89d2537f5d711234c.diff

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-07-04 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 275520. njames93 added a comment. Solved the mac issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-07-04 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri reopened this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Reverted in 7ea46aee3670981827c04df89b2c3a1cbdc7561b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-07-04 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyOptionsTest.cpp:225 +// FIXME: Figure out why this test causes crashes on mac os. +#ifndef __APPLE__ @aaron.ballman @thakis I

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 275517. MaskRay added a comment. Add a -working-directory test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83015/new/ https://reviews.llvm.org/D83015 Files:

[PATCH] D83154: clang: Add -fcoverage-prefix-map

2020-07-04 Thread Keith Smiley via Phabricator via cfe-commits
keith updated this revision to Diff 275506. keith added a comment. Fix tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154/new/ https://reviews.llvm.org/D83154 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D83015: [Driver] Add -fld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

2020-07-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 275507. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83015/new/ https://reviews.llvm.org/D83015 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[clang] 7fed3cf - [clang] Fix two tests that are affected by llvm opt change

2020-07-04 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2020-07-04T18:26:22+03:00 New Revision: 7fed3cfadbdfe1880e16c217a0edac97cbe288d2 URL: https://github.com/llvm/llvm-project/commit/7fed3cfadbdfe1880e16c217a0edac97cbe288d2 DIFF: https://github.com/llvm/llvm-project/commit/7fed3cfadbdfe1880e16c217a0edac97cbe288d2.diff

[PATCH] D83157: [clangd] Extract BackgroundIndex::Options struct. NFC

2020-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184 +TFS, CDB, BackgroundIndexStorage::createDiskBackedStorageFactory( [](llvm::StringRef File) { return

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2424 + (T->isSpecificBuiltinType(BuiltinType::LongDouble) && + Target->supportsAIXPowerAlignment())) // Don't increase the alignment if an alignment attribute was specified on

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

2020-07-04 Thread Kristóf Umann via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb6cbe6cb0399: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core… (authored by Szelethus). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b6cbe6c - [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

2020-07-04 Thread Kirstóf Umann via cfe-commits
Author: Kirstóf Umann Date: 2020-07-04T12:31:51+02:00 New Revision: b6cbe6cb0399d4671e5384dcc326af56bc6bd122 URL: https://github.com/llvm/llvm-project/commit/b6cbe6cb0399d4671e5384dcc326af56bc6bd122 DIFF: https://github.com/llvm/llvm-project/commit/b6cbe6cb0399d4671e5384dcc326af56bc6bd122.diff

[PATCH] D83157: [clangd] Extract BackgroundIndex::Options struct. NFC

2020-07-04 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks for doing this! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184 +TFS, CDB,

[PATCH] D83157: [clangd] Extract BackgroundIndex::Options struct. NFC

2020-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. I've dropped the background context parameter, since we in practice just pass the current context

[clang-tools-extra] 4f2e7f6 - [clangd] Try to fix windows buildbot. NFC

2020-07-04 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-04T12:03:46+02:00 New Revision: 4f2e7f6fb1f212a84d1647920963b66b21175a24 URL: https://github.com/llvm/llvm-project/commit/4f2e7f6fb1f212a84d1647920963b66b21175a24 DIFF: https://github.com/llvm/llvm-project/commit/4f2e7f6fb1f212a84d1647920963b66b21175a24.diff

[PATCH] D83095: [clangd] Config: compute config in TUScheduler and BackgroundIndex

2020-07-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG15a60fe09f46: [clangd] Config: compute config in TUScheduler and BackgroundIndex (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D83095?vs=275388=275487#toc Repository: rG

[PATCH] D83095: [clangd] Config: compute config in TUScheduler and BackgroundIndex

2020-07-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:748 +Context ClangdServer::createProcessingContext(PathRef File) const { + if (!ConfigProvider) kadircet wrote: > sammccall

[clang-tools-extra] 15a60fe - [clangd] Config: compute config in TUScheduler and BackgroundIndex

2020-07-04 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-04T11:18:14+02:00 New Revision: 15a60fe09f4618a7fb451f37aebfd1a671f83713 URL: https://github.com/llvm/llvm-project/commit/15a60fe09f4618a7fb451f37aebfd1a671f83713 DIFF: https://github.com/llvm/llvm-project/commit/15a60fe09f4618a7fb451f37aebfd1a671f83713.diff

[PATCH] D82964: [clangd] Config: loading and caching config from disk.

2020-07-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bd000a65fe4: [clangd] Config: loading and caching config from disk. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D82964?vs=275384=275484#toc Repository: rG LLVM Github

[clang-tools-extra] 8bd000a - [clangd] Config: loading and caching config from disk.

2020-07-04 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2020-07-04T10:48:31+02:00 New Revision: 8bd000a65fe4452c09855115d5204a2a46838004 URL: https://github.com/llvm/llvm-project/commit/8bd000a65fe4452c09855115d5204a2a46838004 DIFF: https://github.com/llvm/llvm-project/commit/8bd000a65fe4452c09855115d5204a2a46838004.diff

[PATCH] D82365: [Power10] Implement Vector Insert Builtins in LLVM/Clang

2020-07-04 Thread Biplob Mishra via Phabricator via cfe-commits
biplmish marked an inline comment as done. biplmish added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:12 +// RUN: -target-cpu pwr10 -triple powerpc64le-unknown-unknown -emit-llvm %s \ +// RUN: -o - | FileCheck %s -check-prefix=CHECK-LE +