[PATCH] D83369: hwasan: Don't pass the tagged-globals target-feature to non-aarch64 backends.

craig.topper created this revision. craig.topper added reviewers: pcc, vitalybuka, hctim. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. The other backends don't know what this feature is and print a message to stderr. I recently tried to rework some target

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

NoQ added a comment. This looks great to me but i'd very much rather have someone else have a look, just because of the nature of the problem (: Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1586 + // 4. Update disequality relations + if (const

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

qiucf added a comment. Thanks for this patch! If I understand correctly, only `isEmptyRecord`/`isEmptyField` and places checking any field is zero bit-width may need change for this? Since `isSingleElementStruct` and `isHomogeneousAggregate` just use them to skip empty fields in aggregate. I

[clang] 065fc1e - PR45521: Preserve the value kind when performing a standard conversion

Author: Richard Smith Date: 2020-07-07T18:28:28-07:00 New Revision: 065fc1eafe7c6f67f8029bcd38e6864b3c429e35 URL: https://github.com/llvm/llvm-project/commit/065fc1eafe7c6f67f8029bcd38e6864b3c429e35 DIFF: https://github.com/llvm/llvm-project/commit/065fc1eafe7c6f67f8029bcd38e6864b3c429e35.diff

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276294. aelitashen added a comment. Add Path Verification in Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

Conanap created this revision. Conanap added reviewers: power-llvm-team, PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Includes instruction defintion and MC Tests for above instructions. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83364

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1254 + // space or zero-extent array. + if (DefaultsToAIXPowerAlignment && !getDataSize().isZero()) { +PreferredBaseAlign = BaseAlign; This needs to check

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser.add_argument('tests', nargs='+')

[PATCH] D83317: [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rG04027052a72f: [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83317/new/

[clang] 0402705 - [Sema] Teach -Wcast-align to compute alignment of CXXThisExpr

Author: Akira Hatanaka Date: 2020-07-07T17:45:04-07:00 New Revision: 04027052a72f982c9e09472427ec7339415fb777 URL: https://github.com/llvm/llvm-project/commit/04027052a72f982c9e09472427ec7339415fb777 DIFF:

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang/test/SemaCXX/warn-suggest-destructor-override:1 +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify -Wsuggest-destructor-override + logan-5 wrote: > dblaikie wrote: >

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 marked an inline comment as done. logan-5 added inline comments. Comment at: clang/test/SemaCXX/warn-suggest-destructor-override:1 +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s -verify -Wsuggest-destructor-override + dblaikie wrote: > Does GCC have

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just test for paths and this will be good to go! Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:35 +

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang created this revision. LukeZhuang added reviewers: lebedev.ri, erichkeane, xbolva00, RKSimon, rsmith. LukeZhuang added a project: clang. Herald added subscribers: cfe-commits, martong. Previously some places that should have handled `__builtin_expect_with_probability` is missing, so

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie added a comment. Generally looks good to me (description/commit message should be updated now that the inconsistent inconsistency is no longer an issue) Comment at: clang/test/SemaCXX/warn-suggest-destructor-override:1 +// RUN: %clang_cc1 -fsyntax-only -std=c++11 %s

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276274. aelitashen added a comment. Fix messy diff stack Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477 Files:

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

jdoerfert accepted this revision. jdoerfert added a comment. LGTM. @lebedev.ri ? Comment at: llvm/lib/Transforms/Scalar/AlignmentFromAssumptions.cpp:227 } - - if (!AAPtr) -return false; - - // Sign extend the offset to 64 bits (so that it is like all of the other -

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Could you include some comparative data in the description/commit message demonstrating this generally ends up emitting all the same types for a clang build before/after (& explanations

[PATCH] D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1125 +#include "llvm/Frontend/OpenMP/OMPKinds.def" +} While we are here, remove

[PATCH] D82906: [flang][openmp] Use common Directive and Clause enum from llvm/Frontend

jdoerfert added a comment. YAY :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82906/new/ https://reviews.llvm.org/D82906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 64788d7 - [clang] Include missing LangOpts in `getModuleHash`.

Author: Michael Spencer Date: 2020-07-07T17:13:23-06:00 New Revision: 64788d7d5377345af5e3080d26cb6a76c324ab5b URL: https://github.com/llvm/llvm-project/commit/64788d7d5377345af5e3080d26cb6a76c324ab5b DIFF:

[PATCH] D79147: [WIP] Merge -debug-info-kind=constructor into -debug-info-kind=limited

akhuang updated this revision to Diff 276252. akhuang added a comment. Herald added a subscriber: fedor.sergeev. Instead of merging =constructor and =limited, change the default to use =constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

JonChesterfield added a comment. __kmpc_spmd_kernel_init is always called with RequiresDataSharing == 0 Specifically, it's only called from clang, and emitSPMDEntryHeader unconditionally passes zero to it I.e. I think there's more stuff that can be cleaned up in the theme of the above, suggest

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:757-759 + // In host compilation, deferred diagnostics are only emitted for functions + // which are sure to be emitted on host side since there is no reliable + // way to check if a function is emitted on

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added a comment. I still haven't seen a strong argument keeping a command line option `-enable-npm-call-graph-profile`. Asked in D62627 . `Opts.getProfileUse() != CodeGenOptions::ProfileNone ` in Opts.CallGraphProfile = Opts.getProfileUse() !=

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:202-219 +ProgramStateRef +SmartPtrModeling::updateTrackedRegion(const CallEvent , CheckerContext , +

[PATCH] D83349: [OpenMP][NFC] Remove unused and untested code from the device runtime

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Applied to the amdgcn implementation. Compiles fine, tests all passing. Seems likely that this lot really is dead. Interesting that this removes*_data_sharing_environment. I

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 276248. logan-5 added a comment. Fall back to -Wsuggest-override if -Winconsistent-missing-override is disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 Files:

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. In D82728#2137492 , @dblaikie wrote: > Oh, yep, there's a way - it's usually used for performance-costly warnings, > to not spend the resources computing the warning if it's disabled anyway. Wow, thanks--overlooked that in a

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:94 /// If it contains any dynamic allocas, returns false. static bool canTRE(Function ) { // Because of PR962, we don't TRE dynamic allocas. If we're not

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie added a comment. In D82728#2137061 , @logan-5 wrote: > In D82728#2137021 , @dblaikie wrote: > > > I think it might be nice to make the -Wno-inconsistent-missing-override > > -Wsuggest-override situation a

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

shafik updated this revision to Diff 276229. shafik marked 5 inline comments as done. shafik added a comment. - Removing spurious local variables in test - Simplifying the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 Files:

[PATCH] D83349: [OpenMP][NFC] Remove unused and untested code from the device runtime

jdoerfert added a comment. Please let me know if something slipped through my "clever" grep logic and is actually used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83349/new/ https://reviews.llvm.org/D83349

[PATCH] D83349: [OpenMP][NFC] Remove unused and untested code from the device runtime

jdoerfert created this revision. jdoerfert added reviewers: hfinkel, jhuber6, fghanim, JonChesterfield, grokos, AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis, Hahnfeld, ABataev, hbae, ronlieb, gregrodgers. Herald added subscribers: cfe-commits, aaron.ballman, sstefan1, jfb, guansong,

[PATCH] D78655: [CUDA][HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 276211. yaxunl added a comment. refactor CUDACheckLambdaCapture and add comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu updated this revision to Diff 276208. zequanwu marked an inline comment as done. zequanwu added a comment. Herald added subscribers: dexonsmith, steven_wu. - Disable `enable-call-graph-profile` by default in opt. - Disable `CGProfilePass` by default in clang unless `-no-integrated-as` is

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:521 + // [[no_unique_address]] attribute (since C++20). Those do count + // as empty according to the Itanium ABI. This property is currently + // only respected if the

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

fpetrogalli updated this revision to Diff 276204. fpetrogalli added a comment. Addressed code review, moving the code and adding more testing, including the `v8.5` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83079/new/

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 276187. logan-5 added a comment. Addressed minor feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

efriedma added a comment. I'm tempted to say this is a bugfix for the implementation of no_unique_address, and just fix it globally for all ABIs. We're never going to get anything done here if we require a separate patch for each ABI variant clang supports. Comment at:

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager MaskRay wrote: > zequanwu wrote: > >

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Herald added a subscriber: jfb. Changed prior to commit: https://reviews.llvm.org/D79910?vs=272117=275687#toc

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d9e499840af: [x86][seses] Add clang flag; Use lvi-cfi with seses (authored by zbrid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/

[clang] 9d9e499 - [x86][seses] Add clang flag; Use lvi-cfi with seses

Author: Zola Bridges Date: 2020-07-07T13:20:13-07:00 New Revision: 9d9e499840af670b9644af77ce846c52085c23a1 URL: https://github.com/llvm/llvm-project/commit/9d9e499840af670b9644af77ce846c52085c23a1 DIFF: https://github.com/llvm/llvm-project/commit/9d9e499840af670b9644af77ce846c52085c23a1.diff

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276196. zbrid added a comment. rebase prior to commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1064 setSize(getSize() + PtrWidth); setDataSize(getSize()); } I would suggest setting `HandledFirstNonOverlappingEmptyField` to `true` here with an

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > cchen wrote: > > ABataev wrote: > > > You need to insert an

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > ABataev wrote: > > You need

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

ymandel added a comment. Thanks for this fix! Comment at: clang/lib/AST/Expr.cpp:3001 Expr *A = C->getArg(0); -if (A->getSourceRange() == SR || !isa(C)) +if (A->getSourceRange() == SR || C->isElidable()) { E = A;

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' ABataev wrote: > You need to insert an

[PATCH] D83301: [clang-tidy] More strict on matching the standard memset function in memset-usage check.

njames93 added a comment. If you want to be super explicit. Why not add `parameterCountIs(3)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83301/new/ https://reviews.llvm.org/D83301 ___ cfe-commits

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

rsmith added a comment. @aaron.ballman We will need to do something like this in general, but I'm not sure it's going to be as easy as just inheriting the attribute in the general case. What do you think? Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:3540 +Attr

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap created this revision. Conanap added reviewers: PowerPC, power-llvm-team, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Implemented the following vector right and left shift builtins and its test cases: vector unsigned __int128 vec_sl(vector unsigned

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So looks like you didn't use "git commit --amend -a" again here. These changes are incremental changes on your patch which hasn't been submitted yet? Comment

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 marked 2 inline comments as done. logan-5 added a comment. In D82728#2137021 , @dblaikie wrote: > I think it might be nice to make the -Wno-inconsistent-missing-override > -Wsuggest-override situation a bit better (by having it still do the same

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 ___ cfe-commits mailing list

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

MaskRay added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager zequanwu wrote: > zequanwu wrote: > >

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay added a comment. `compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c.gcov` is clumsy to update. The filename is also wrong: gcov has nothing to do with instrprof. I'll update the tests separately like my fba8523fb55c8e3bc853df7a250845cf51e5fc99

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay updated this revision to Diff 276173. MaskRay marked 6 inline comments as done. MaskRay added a comment. Test __gcov_dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83149/new/ https://reviews.llvm.org/D83149 Files:

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

aelitashen updated this revision to Diff 276172. aelitashen added a comment. Add test for loading symbols, other module info and Add version to module info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82477/new/ https://reviews.llvm.org/D82477

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie added a comment. I'm generally on board with this, but would like @rsmith 's sign off to be sure. I think it might be nice to make the -Wno-inconsistent-missing-override -Wsuggest-override situation a bit better (by having it still do the same thing as -Wsuggest-override) but I don't

[PATCH] D83334: [OPENMP]Fix PR46593: Reduction initializer missing construnctor call.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. If user-defined reductions with the initializer are used with classes, wthe compiler misses the constructor call whe trying to create a private copy of

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn updated this revision to Diff 276166. kpn added a comment. Add the -fexperimental-strict-floating-point flag to enable on hosts that are not marked as supporting strict FP yet. Add test and documentation. Update tests to use the new flag. This eliminates the XFAIL lines and should keep the

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie added a comment. In D82728#2136887 , @logan-5 wrote: > In D82728#2135149 , @dblaikie wrote: > > > Is the implementation you're proposing fairly consistent with GCC's? Run it > > over any big codebases to

[PATCH] D82930: [HIP] Fix rocm detection

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) arsenm wrote: > tra wrote: > > arsenm wrote: > > > yaxunl wrote: >

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. In D82659#2136909 , @michele.scandale wrote: > Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than > being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`? > > Moreover I've noticed that

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:118 + + if (!llvm::AArch64::getArchFeatures(ArchKind, Features)) +return false; Would it be more consistent to move this Comment at:

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan updated this revision to Diff 276163. ebevhan added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 Files: clang-tools-extra/clang-tidy/bugprone/VirtualNearMissCheck.cpp

[clang] a707da4 - Clang crashed while checking for deletion of copy and move ctors

Author: Vy Nguyen Date: 2020-07-07T14:40:37-04:00 New Revision: a707da4728dea51c1446cf582a46fb271f3969c3 URL: https://github.com/llvm/llvm-project/commit/a707da4728dea51c1446cf582a46fb271f3969c3 DIFF: https://github.com/llvm/llvm-project/commit/a707da4728dea51c1446cf582a46fb271f3969c3.diff

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 276162. logan-5 added a comment. clang-formatted the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D82659: Fix missing build dependency on omp_gen.

michele.scandale added a comment. Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`? Moreover I've noticed that with the recent changes where `omp_gen` has been added as a dependency in several

[PATCH] D82930: [HIP] Fix rocm detection

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:167 +llvm::ErrorOr> VersionFile = +FS.getBufferForFile(BinPath + "/.hipVersion"); +if (!VersionFile) tra wrote: > arsenm wrote: > > yaxunl wrote: > > > yaxunl wrote:

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEXT: FunctionPass Manager

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. In D82728#2135149 , @dblaikie wrote: > Is the implementation you're proposing fairly consistent with GCC's? Run it > over any big codebases to check it warns in the same places GCC does? This patch has the same behavior as

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276153. zbrid added a comment. Herald added a subscriber: jfb. update seses flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

uweigand updated this revision to Diff 276151. uweigand added a comment. Rebased against mainline. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81583/new/ https://reviews.llvm.org/D81583 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/systemz-abi.cpp Index:

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

serge-sans-paille added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -fprintf(stderr, "unable to find

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) { atmnpatel wrote: > ABataev wrote: > >

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel marked an inline comment as done. atmnpatel added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) {

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid updated this revision to Diff 276147. zbrid added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) { atmnpatel wrote: > ABataev wrote: > >

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2787 + if (getLangOpts().OpenMP < 51 && Kind == OMPC_default && + static_cast(Val.getValue().Type) == + OMP_DEFAULT_firstprivate) { ABataev wrote: > ABataev wrote: > > No

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 276143. Xiangling_L marked 14 inline comments as done. Xiangling_L added a comment. Fixed typedef issue on incomplete array field and add a test for it; Added a test for where pack attribute on object also apply on base classes; Addressed other comments;

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1225 + Context.getTargetInfo().getTriple().isPS4() || + Context.getTargetInfo().getTriple().isOSAIX())) + ? CharUnits::One()

[PATCH] D79842: [clang][Driver] Correct tool search path priority

stevewan added a comment. Yes, this issue was hit with the reland applied. When given a `--` format LLVM_DEFAULT_TARGET_TRIPLE, Clang would expand the target triple to `---`, and therefore causes the name mismatch between what the driver searches for and what the test case creates as the

[clang] 80a1b95 - [SystemZ ABI] Allow class types in GetSingleElementType

Author: Ulrich Weigand Date: 2020-07-07T19:56:19+02:00 New Revision: 80a1b95b8e72674cef7efb39636dc73c248ae6f3 URL: https://github.com/llvm/llvm-project/commit/80a1b95b8e72674cef7efb39636dc73c248ae6f3 DIFF:

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-no-escape.rst:13 + + .. code-block:: objc +void foo(__attribute__((noescape)) int *p) { ellis wrote: > It looks like I triggered a build failure for the

[clang-tools-extra] aef04d3 - Speculatively fix the sphinx build.

Author: Aaron Ballman Date: 2020-07-07T13:54:28-04:00 New Revision: aef04d3306bff492f69f50675f65c9c4eedfab57 URL: https://github.com/llvm/llvm-project/commit/aef04d3306bff492f69f50675f65c9c4eedfab57 DIFF: https://github.com/llvm/llvm-project/commit/aef04d3306bff492f69f50675f65c9c4eedfab57.diff

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

ellis marked an inline comment as done. ellis added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-no-escape.rst:13 + + .. code-block:: objc +void foo(__attribute__((noescape)) int *p) { It looks like I triggered a build

[PATCH] D83149: [gcov] Add __gcov_dump/__gcov_reset and delete __gcov_flush

MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: compiler-rt/test/profile/Inputs/instrprof-dlopen-dlclose-main.c:49 dlerror(); - void (*gcov_flush1)() = (void (*)())dlsym(f1_handle, "__gcov_flush"); - if (gcov_flush1 == NULL) { -

[PATCH] D82611: [SemaObjC] Add a warning for @selector expressions that potentially refer to objc_direct methods

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. erik.pilkington marked an inline comment as done. Closed by commit rG7437a9496528: [SemaObjC] Add a warning for @selector expressions that

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cf0dac1ca3f: orrectly generate invert xor value for Binary Atomics of int size 64 (authored by jyu2). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82574: Merge TableGen files used for clang options

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. We can look at splitting it up again once we know what the dependencies are. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a comment. In D62574#2136553 , @danilaml wrote: > In D62574#2135662 , @ebevhan wrote: > > > It's generally not safe to alter address spaces below the top level. C is > > just very permissive about

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

ebevhan created this revision. ebevhan added reviewers: svenvh, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. When performing a pointer conversion as the second conversion in an SCS where the conversion is a derived-to-base and the address space of the type

[PATCH] D82904: [clang-tidy] Warn pointer captured in async block

aaron.ballman closed this revision. aaron.ballman added a comment. In D82904#2136686 , @ellis wrote: > Hey @aaron.ballman, thanks for accepting my diff! Would you mind landing my > diff since I don't have commit access yet? Gladly -- I've committed on

[clang-tools-extra] dfa0db7 - Warn pointer captured in async block

Author: Ellis Hoag Date: 2020-07-07T13:31:14-04:00 New Revision: dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 URL: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574 DIFF: https://github.com/llvm/llvm-project/commit/dfa0db79d0e37d5cf24a63d1e2b7ba5f40617574.diff

[PATCH] D83315: Turn arcmt-* options into a single option

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. I have a slight preference for `-arcmt-action=`, but up to you if you want to change it. Otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional… (authored by

  1   2   3   >