[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc98699582a63: [OpenMP][NFC] Remove unused (always fixed) arguments (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D83268?vs=275871=277218#toc Repository: rG LLVM Github

[clang] c986995 - [OpenMP][NFC] Remove unused (always fixed) arguments

2020-07-10 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-11T00:51:51-05:00 New Revision: c98699582a6333bbe76ff7853b4cd6beb45754cf URL: https://github.com/llvm/llvm-project/commit/c98699582a6333bbe76ff7853b4cd6beb45754cf DIFF:

[clang] b5667d0 - [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-11T00:40:05-05:00 New Revision: b5667d00e0447747419a783697b84a37f59ce055 URL: https://github.com/llvm/llvm-project/commit/b5667d00e0447747419a783697b84a37f59ce055 DIFF:

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb5667d00e044: [OpenMP][CUDA] Fix std::complex in GPU regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Thx for the reviews! FWIW, OpenMP should be able to use the C/C++ standard functions/macros for this eventually. Getting the overloads right if you don't have type system support is tricky though and I need more time... On a separate note, we should bundle the

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

2020-07-10 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added subscribers: eugenis, guiand, vitalybuka. vitalybuka added a comment. After this patch we have false msan reports on code like this: bool iv_compare2(const int *op1, const int *op2) { if (op1[1] != op2[1]) return op1[1] < op2[1]; for (int i = 1; i >= 0; i--) { if

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. LGTM. This fixed the regression caused by previous change. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

2020-07-10 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 277215. jdenny added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83061/new/ https://reviews.llvm.org/D83061 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-10 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG849d4405f534: [HIP] Fix rocm detection (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D82930?vs=277095=277214#toc Repository: rG LLVM Github

[clang] 849d440 - [HIP] Fix rocm detection

2020-07-10 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2020-07-10T23:20:15-04:00 New Revision: 849d4405f534434ebbda9889f24ff20122e34671 URL: https://github.com/llvm/llvm-project/commit/849d4405f534434ebbda9889f24ff20122e34671 DIFF:

[PATCH] D83616: [clang] Add 'override' to virtual function overrides generated by ClangAttrEmitter

2020-07-10 Thread Logan Smith via Phabricator via cfe-commits
logan-5 created this revision. logan-5 added reviewers: rsmith, aaron.ballman, john.brawn. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. ClangAttrEmitter.cpp generates `ParsedAttr` derived classes with virtual overrides in them (which end up in AttrParsedAttrImpl.inc);

[PATCH] D83611: [clang][NFC] Add 'override' keyword to virtual function overrides

2020-07-10 Thread Logan Smith via Phabricator via cfe-commits
logan-5 created this revision. logan-5 added a project: clang. Herald added subscribers: cfe-commits, martong. This patch adds `override` to several overriding virtual functions that were missing the keyword within the clang/ directory. NFC. These were found by a Clang build equipped with

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

2020-07-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Vy Nguyen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG17ea41e47256: Summary: [clang] Provide a way for WhileStmt to report the location of its… (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 17ea41e - Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Vy Nguyen via cfe-commits
Author: Vy Nguyen Date: 2020-07-10T21:31:16-04:00 New Revision: 17ea41e472566823e16d3a04661221fbd18d9fae URL: https://github.com/llvm/llvm-project/commit/17ea41e472566823e16d3a04661221fbd18d9fae DIFF: https://github.com/llvm/llvm-project/commit/17ea41e472566823e16d3a04661221fbd18d9fae.diff

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D83591#2145512 , @JonChesterfield wrote: > In D83591#2145437 , @jdoerfert wrote: > > > I did not know they are using __clang_cuda headers. (Site note, we should > > rename them then.) > >

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. In D83591#2145437 , @jdoerfert wrote: > I did not know they are using __clang_cuda headers. (Site note, we should > rename them then.) I also did not know that. I am repeatedly caught out by things named 'cuda',

[clang] 3a5617c - Fix build error

2020-07-10 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-07-10T17:40:37-07:00 New Revision: 3a5617c02e38618bd5534491077afbc7178adf3f URL: https://github.com/llvm/llvm-project/commit/3a5617c02e38618bd5534491077afbc7178adf3f DIFF:

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

2020-07-10 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9bf0a710c99: [CodeGen] Store the return value of the target function call to the thunks… (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e9bf0a7 - [CodeGen] Store the return value of the target function call to the

2020-07-10 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2020-07-10T17:24:13-07:00 New Revision: e9bf0a710c993b932fa69c95ef6d0130fd721115 URL: https://github.com/llvm/llvm-project/commit/e9bf0a710c993b932fa69c95ef6d0130fd721115 DIFF:

[PATCH] D83349: [OpenMP][NFC] Remove unused and untested code from the device runtime

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0ea03e6f15: [OpenMP][NFC] Remove unused and untested code from the device runtime (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cd0ea03 - [OpenMP][NFC] Remove unused and untested code from the device runtime

2020-07-10 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-10T19:09:41-05:00 New Revision: cd0ea03e6f157e8fb477cd8368b29e1448eeb265 URL: https://github.com/llvm/llvm-project/commit/cd0ea03e6f157e8fb477cd8368b29e1448eeb265 DIFF:

[PATCH] D83478: [OPENMP]Fix compiler crash for target data directive without actual target codegen.

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83478/new/ https://reviews.llvm.org/D83478

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 277173. jdoerfert added a comment. Keep the std:: functions in non-OpenMP mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83591/new/ https://reviews.llvm.org/D83591 Files:

[PATCH] D78155: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7f1e6fcff942: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7f1e6fc - [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in wrapper headers

2020-07-10 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-10T18:53:34-05:00 New Revision: 7f1e6fcff9427adfa8efa3bfeeeac801da788b87 URL: https://github.com/llvm/llvm-project/commit/7f1e6fcff9427adfa8efa3bfeeeac801da788b87 DIFF:

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D83591#2145411 , @tra wrote: > In D83591#2145378 , @JonChesterfield > wrote: > > > Fine by me. Let's get nvptx working properly in tree now and work out how > > to wire up amdgcn

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

2020-07-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82513/new/ https://reviews.llvm.org/D82513

[PATCH] D82477: [lldb-vscode] Add Support for Module Event

2020-07-10 Thread Yifan Shen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f80159753b: [lldb-vscode] Add Support for Module Event (authored by aelitashen, committed by Walter Erquinigo walterme...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D83591#2145378 , @JonChesterfield wrote: > Fine by me. Let's get nvptx working properly in tree now and work out how to > wire up amdgcn subsequently. I'm sure a reasonable abstraction will present > itself. I'm missing

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:654 + unsigned LaneIDBits = + CGF.getTarget().getGridValue(llvm::omp::GV_Warp_Size_Log2); return Bld.CreateAShr(getNVPTXThreadID(CGF), LaneIDBits, "nvptx_warp_id");

[PATCH] D82513: [CodeGen] Store the return value of the target function call to the thunk's return value slot directly when the return type is an aggregate instead of doing so via a temporary

2020-07-10 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak updated this revision to Diff 277163. ahatanak added a comment. Assert in `EmitReturnFromThunk` that the result type isn't an aggregate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82513/new/ https://reviews.llvm.org/D82513 Files:

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Fine by me. Let's get nvptx working properly in tree now and work out how to wire up amdgcn subsequently. I'm sure a reasonable abstraction will present itself.

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
Release+Asserts on x86_64-linux and the debug-info-codeview-buildinfo.c test. Sorry if the latter wasn't clear :) -eric On Fri, Jul 10, 2020 at 4:12 PM Alexandre Ganea wrote: > Thanks for letting me know Eric. What test fails exactly? What config? > > > > *De :* Eric Christopher > *Envoyé :*

RE: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Alexandre Ganea via cfe-commits
Thanks for letting me know Eric. What test fails exactly? What config? De : Eric Christopher Envoyé : July 10, 2020 7:04 PM À : reviews+d80833+public+da87cf0eabdca...@reviews.llvm.org; Alexandre Ganea via Phabricator Cc : Alexandre Ganea ; Hans Wennborg ; Adrian McCarthy ; Martin Storsjo ;

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
You'll probably want the assert as well: assert.h assertion failed at llvm-project/llvm/lib/MC/MCStreamer.cpp:134 in virtual void llvm::MCStreamer::emitIntValue(uint64_t, unsigned int): (isUIntN(8 * Size, Value) || isIntN(8 * Size, Value)) && "Invalid size" On Fri, Jul 10, 2020 at 4:03 PM Eric

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337

[clang] 41d2813 - [PDB] Attempt fix for debug-info-codeview-buildinfo.c test

2020-07-10 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-07-10T18:52:52-04:00 New Revision: 41d2813a5faea1c18b7d329109e0287c5cd9ffea URL: https://github.com/llvm/llvm-project/commit/41d2813a5faea1c18b7d329109e0287c5cd9ffea DIFF:

[PATCH] D83592: [Parser] Add comment to skipped regions

2020-07-10 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Not sure if this is good idea to untrack comments, it breaks many tests under CoverageMapping. Repository: rG LLVM Github Monorepo

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 11 inline comments as done. yaxunl added a comment. thanks. will fix when commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82930/new/ https://reviews.llvm.org/D82930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83497: [PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.

2020-07-10 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 277153. amyk retitled this revision from "[PowerPC][Power10] Fix the VINSW instruction to have an i32 argument." to "[PowerPC][Power10] Fix VINS* (vector insert byte/half/word) instructions to have i32 arguments.". amyk edited the summary of this revision. amyk

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

2020-07-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. What's the tradeoff of representing these in IR as vscale'ed vector types, as opposed to fixed-wdith vector types? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83553/new/ https://reviews.llvm.org/D83553 ___

[PATCH] D83591: [OpenMP][CUDA] Fix std::complex in GPU regions

2020-07-10 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: tra, hfinkel, JonChesterfield. Herald added subscribers: sstefan1, guansong, bollu, yaxunl. Herald added a project: clang. The old way worked to some degree for C++-mode but in C mode we actually tried to introduce variants of macros

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 277148. oontvoo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83529/new/ https://reviews.llvm.org/D83529 Files: clang/include/clang/AST/Stmt.h clang/include/clang/Parse/Parser.h

[clang] 1d68a78 - [clang-shlib] Don't link with static clang libraries

2020-07-10 Thread Tom Stellard via cfe-commits
Author: Tom Stellard Date: 2020-07-10T14:28:05-07:00 New Revision: 1d68a780b34e1f18f865d0754fce6c6177dc5d21 URL: https://github.com/llvm/llvm-project/commit/1d68a780b34e1f18f865d0754fce6c6177dc5d21 DIFF: https://github.com/llvm/llvm-project/commit/1d68a780b34e1f18f865d0754fce6c6177dc5d21.diff

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

2020-07-10 Thread Tom Stellard via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1d68a780b34e: [clang-shlib] Dont link with static clang libraries (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82694/new/

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo added a comment. In D83529#2145087 , @riccibruno wrote: > No objection from me, but I am not a reviewer. I am just accepting this to > cancel my comment on the missing serialization. No worries. Thanks for your input! I think Dmitri has

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. No objection from me, but I am not a reviewer. I am just accepting this to cancel my comment on the missing serialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

2020-07-10 Thread Michele Scandale via Phabricator via cfe-commits
michele.scandale added a comment. In D83454#2144386 , @JDevlieghere wrote: > In D83454#2142719 , > @michele.scandale wrote: > > > I tested locally the standalone build of Clang with D83426 > >

[clang] cb6c110 - [analyzer] Silence a warning.

2020-07-10 Thread Artem Dergachev via cfe-commits
Author: Artem Dergachev Date: 2020-07-10T13:25:46-07:00 New Revision: cb6c1106141efa721a3902a98c37a54d135464fd URL: https://github.com/llvm/llvm-project/commit/cb6c1106141efa721a3902a98c37a54d135464fd DIFF:

[PATCH] D83120: [Analyzer][StreamChecker] Using BugType::SuppressOnSink at resource leak report.

2020-07-10 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Before i forget again: commit messages (and, therefore, review titles) are traditionally written in imperative mood, i.e. "Using" -> "Use" as if you ask git to change something in the project. Comment at:

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-07-10 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D77341#2144974 , @asbirlea wrote: > Thank you for the testing. Could you help with with instructions on how to > run the tracker myself? > My local testing showed a negligible regression for mafft and a negligible >

[PATCH] D83516: [PowerPC][Power10] 128-bit Binary Integer Operation instruction definitions and MC Tests

2020-07-10 Thread Lei Huang via Phabricator via cfe-commits
lei accepted this revision. lei added a comment. This revision is now accepted and ready to land. LGTM Please address the nits on commit. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1022 + def XSCVUQQP : X_VT5_XO5_VB5<63, 3, 836, "xscvuqqp", []>; + def XSCVSQQP:

[PATCH] D83502: Change behavior with zero-sized static array extents

2020-07-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Thanks for the review, I've gone ahead and committed in 006c49d890da633d1ce502117fc2a49863cd65b7

[clang] 006c49d - Change behavior with zero-sized static array extents

2020-07-10 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2020-07-10T15:58:11-04:00 New Revision: 006c49d890da633d1ce502117fc2a49863cd65b7 URL: https://github.com/llvm/llvm-project/commit/006c49d890da633d1ce502117fc2a49863cd65b7 DIFF: https://github.com/llvm/llvm-project/commit/006c49d890da633d1ce502117fc2a49863cd65b7.diff

[PATCH] D83502: Change behavior with zero-sized static array extents

2020-07-10 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: clang/lib/CodeGen/CGCall.cpp:2515 +} else { + AI->addAttr(llvm::Attribute::NonNull); +}

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

2020-07-10 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. Thank you for the testing. Could you help with with instructions on how to run the tracker myself? My local testing showed a negligible regression for mafft and a negligible improvement on other benchmarks, so it looked like noise on average. Repository: rG LLVM

[PATCH] D83516: [PowerPC][Power10] Vector shift Instruction definitions and MC Tests

2020-07-10 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 277127. Conanap added a comment. Added a new line to the end of ppc64-encoding-ISA31.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83516/new/ https://reviews.llvm.org/D83516 Files:

[PATCH] D83513: [AST][ObjC] Fix crash when printing invalid objc categories

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGea201e83e292: [AST][ObjC] Fix crash when printing invalid objc categories (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D83513?vs=276841=277126#toc Repository: rG LLVM

[clang] ea201e8 - [AST][ObjC] Fix crash when printing invalid objc categories

2020-07-10 Thread David Goldman via cfe-commits
Author: David Goldman Date: 2020-07-10T15:35:14-04:00 New Revision: ea201e83e292f39c3ee7fe8810a348ee98000398 URL: https://github.com/llvm/llvm-project/commit/ea201e83e292f39c3ee7fe8810a348ee98000398 DIFF: https://github.com/llvm/llvm-project/commit/ea201e83e292f39c3ee7fe8810a348ee98000398.diff

[PATCH] D81728: [InstCombine] Add target-specific inst combining

2020-07-10 Thread Sebastian Neubauer via Phabricator via cfe-commits
Flakebi marked an inline comment as done. Flakebi added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:540 + bool instCombineIntrinsic(InstCombiner , IntrinsicInst , +Instruction **ResultI) const; + bool

[PATCH] D83502: Change behavior with zero-sized static array extents

2020-07-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 277120. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83502/new/ https://reviews.llvm.org/D83502 Files:

[PATCH] D83502: Change behavior with zero-sized static array extents

2020-07-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2515 +} else { + AI->addAttr(llvm::Attribute::NonNull); +} rjmccall wrote: > aaron.ballman wrote: > > rjmccall wrote: > > > Isn't the

[clang] dafc310 - [Sema] Emit a -Wformat warning for printf("%s", (void*)p)

2020-07-10 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-07-10T15:10:24-04:00 New Revision: dafc3106d2069b806a10e072306a2196f1cda585 URL: https://github.com/llvm/llvm-project/commit/dafc3106d2069b806a10e072306a2196f1cda585 DIFF:

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

2020-07-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1244 +if (!Base->Class->isEmpty() && !HandledFirstNonOverlappingEmptyField) { + IsFirstNonEmptyBase = true; + // By handling a base class that is not empty, we're

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Vy Nguyen via Phabricator via cfe-commits
oontvoo updated this revision to Diff 277115. oontvoo marked 3 inline comments as done. oontvoo added a comment. Added unit test and the missing serialisation code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83529/new/

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-10 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. LGTM in principle. Few style comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:161 +unsigned Minor = 0; +auto Splits =

[PATCH] D83055: [clang][Driver] Fix tool path priority test failures

2020-07-10 Thread Steven Wan via Phabricator via cfe-commits
stevewan added inline comments. Comment at: clang/test/Driver/program-path-priority.c:117 +/// Check file exists first in case $DEFAULT_TRIPLE == %target_triple +// RUN: file -E %t/$DEFAULT_TRIPLE-gcc 2>&1 > /dev/null && \ +// RUN: mv %t/$DEFAULT_TRIPLE-gcc %t/prefix || true

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-07-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D82087#2140778 , @sameerds wrote: > The documentation for HIP __ballot seems to indicate that the user does not > have to explicitly specify the warp size. How is that achieved with these new > builtins? Can this be captured

[clang] 8c8a2fd - [OpenCL] Fixed typo for ctor stub name in UsersManual

2020-07-10 Thread Anastasia Stulova via cfe-commits
Author: Anastasia Stulova Date: 2020-07-10T19:04:49+01:00 New Revision: 8c8a2fd1f015525d048444610a6e27c66aa96293 URL: https://github.com/llvm/llvm-project/commit/8c8a2fd1f015525d048444610a6e27c66aa96293 DIFF:

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-07-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm marked 2 inline comments as done. arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:288 + if (!IsNullCPU) { +// Default to wave32 if available, or wave64 if not +if (Features.count("wavefrontsize32") == 0 && sameerds

[PATCH] D83513: [AST][ObjC] Fix crash when printing invalid objc categories

2020-07-10 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/DeclPrinterTest.cpp:180 + return PrintedDeclMatches(Code, Args, NodeMatch, ExpectedPrinted, "input.m", +

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

2020-07-10 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D82087#2140778 , @sameerds wrote: > The documentation for HIP __ballot seems to indicate that the user does not > have to explicitly specify the warp size. How is that achieved with these new > builtins? Can this be captured

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 277105. dgoldman added a comment. rebase, phabricator keeps getting confused Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 277103. dgoldman added a comment. Move up null check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files: clang-tools-extra/clangd/FindTarget.cpp Index:

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

2020-07-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D83013#2143470 , @hans wrote: > Still lgtm. For what it's worth, I think you could have just re-committed > with the fixes rather than uploading for review again. This may be a difference of habits but I usually upload the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 277100. dgoldman added a comment. Find target fixes + symbol collector test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D82930: [HIP] Fix rocm detection

2020-07-10 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 277095. yaxunl marked 2 inline comments as done. yaxunl added a comment. Herald added a reviewer: dang. Separate detecting ROCm path and device library path. Assume 3.5 as default HIP version. If -rocm-path is specified, do not require version file to exist.

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-10 Thread Luke Geeson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG954db63cd149: [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM (authored by LukeGeeson). Changed prior to commit: https://reviews.llvm.org/D83206?vs=277074=277093#toc Repository: rG

[clang] 954db63 - [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-10 Thread Luke Geeson via cfe-commits
Author: Luke Geeson Date: 2020-07-10T18:24:11+01:00 New Revision: 954db63cd149df031d9b660bf68f0fe1de1defb9 URL: https://github.com/llvm/llvm-project/commit/954db63cd149df031d9b660bf68f0fe1de1defb9 DIFF: https://github.com/llvm/llvm-project/commit/954db63cd149df031d9b660bf68f0fe1de1defb9.diff

[PATCH] D83519: [NewPM] Support optnone under new pass manager

2020-07-10 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D83519#2144463 , @aeubanks wrote: > In D83519#2144403 , @ychen wrote: > > > High-level request: how about split this patch into two, the first for the > > `require` pass part; the

[PATCH] D83502: Change behavior with zero-sized static array extents

2020-07-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2515 +} else { + AI->addAttr(llvm::Attribute::NonNull); +} aaron.ballman wrote: > rjmccall wrote: > > Isn't the old logic still correct? If

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
dgoldman marked 5 inline comments as done and an inline comment as not done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:273 Flags |= Rel::Underlying; // continue with the underlying decl. +} else if (const

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

2020-07-10 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 277084. dgoldman added a comment. Swap to getPreferredDecl and improve targetDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83501/new/ https://reviews.llvm.org/D83501 Files:

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno requested changes to this revision. riccibruno added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:275 + S->setLParenLoc(readSourceLocation()); + S->setRParenLoc(readSourceLocation()); }

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

2020-07-10 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D82663#2144219 , @ebevhan wrote: > In D82663#2142426 , @rjmccall wrote: > > > Would it be sensible to use a technical design more like what the matrix > > folks are doing, where LLVM

[PATCH] D81728: [InstCombine] Add target-specific inst combining

2020-07-10 Thread Nikita Popov via Phabricator via cfe-commits
nikic added inline comments. Comment at: llvm/include/llvm/Analysis/TargetTransformInfo.h:540 + bool instCombineIntrinsic(InstCombiner , IntrinsicInst , +Instruction **ResultI) const; + bool simplifyDemandedUseBitsIntrinsic(InstCombiner ,

[PATCH] D82574: Merge TableGen files used for clang options

2020-07-10 Thread Daniel Grumberg via Phabricator via cfe-commits
dang added a comment. Sorry again, removed the offending options in a2cffb11e287 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574

[clang] a2cffb1 - Remove clang options that were added back when merging the TableGen files

2020-07-10 Thread Daniel Grumberg via cfe-commits
Author: Daniel Grumberg Date: 2020-07-10T17:54:44+01:00 New Revision: a2cffb11e287f0e35685ac404400edab12cae51e URL: https://github.com/llvm/llvm-project/commit/a2cffb11e287f0e35685ac404400edab12cae51e DIFF:

[PATCH] D83529: Summary: [clang] Provide a way for WhileStmt to report the location of its LParen and RParen.

2020-07-10 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Could you take a look at test failures and check if they are relevant? `linux > Clang.AST::ast-dump-attr.cpp` looks extremely close to the area you're working on. I'm not quite

[PATCH] D83426: Unbreak Clang standalone build.

2020-07-10 Thread Saleem Abdulrasool via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7a5ad56b60: repair standalone clang builds (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83426/new/

[clang] aa7a5ad - repair standalone clang builds

2020-07-10 Thread Saleem Abdulrasool via cfe-commits
Author: Saleem Abdulrasool Date: 2020-07-10T09:36:27-07:00 New Revision: aa7a5ad56b6028e0963e1a8d45b4e82f3f6bc70e URL: https://github.com/llvm/llvm-project/commit/aa7a5ad56b6028e0963e1a8d45b4e82f3f6bc70e DIFF:

[PATCH] D83519: [NewPM] Support optnone under new pass manager

2020-07-10 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks marked an inline comment as done. aeubanks added a comment. In D83519#2144403 , @ychen wrote: > High-level request: how about split this patch into two, the first for the > `require` pass part; the second for the PassInstrument callback. Then we

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-10 Thread Dave Green via Phabricator via cfe-commits
dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 ___ cfe-commits mailing list

[PATCH] D83206: [PATCH] [ARM] Add Cortex-A78 and Cortex-X1 Support for Clang and LLVM

2020-07-10 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson updated this revision to Diff 277074. LukeGeeson added a comment. removed FP16FML feature CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83206/new/ https://reviews.llvm.org/D83206 Files: clang/test/Driver/aarch64-cpus.c clang/test/Driver/arm-cortex-cpus.c

[PATCH] D83519: [NewPM] Support optnone under new pass manager

2020-07-10 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. High-level request: how about split this patch into two, the first for the `require` pass part; the second for the PassInstrument callback. Then we could discuss the choices of first patch and D82344 . Comment at:

[clang] f33c2c2 - Fix crash on `user defined literals`

2020-07-10 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-07-10T16:21:11Z New Revision: f33c2c27a8d4ea831aa7c2c2649066be91318d85 URL: https://github.com/llvm/llvm-project/commit/f33c2c27a8d4ea831aa7c2c2649066be91318d85 DIFF: https://github.com/llvm/llvm-project/commit/f33c2c27a8d4ea831aa7c2c2649066be91318d85.diff

[PATCH] D82157: Fix crash on `user defined literals`

2020-07-10 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf33c2c27a8d4: Fix crash on `user defined literals` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D82157?vs=277060=277071#toc Repository: rG LLVM Github Monorepo

  1   2   3   >