[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

2020-07-29 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. I'm looking into it. If needed this can be reverted as it's not blocking the work for DomTree updates with a CFGView. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ https://reviews.llvm.org/D84713

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/include/clang/Analysis/IssueHash.h:35 +/// /// In case a new hash is introduced, the old one should still be maintained for /// a while. One should not introduce a new hash for every change, it is Szelethus wrote:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 281797. NoQ marked 5 inline comments as done. NoQ added a comment. Rebase! Re-do the comments. Rename `GetIssueHash()` to `getIssueHashV1` because there's a high chance we'll want more different kinds of hashes (also starts with a small letter, while we're at

[PATCH] D84005: Introduce ns_error_domain attribute.

2020-07-29 Thread Michael Forster via Phabricator via cfe-commits
MForster updated this revision to Diff 281791. MForster added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td

[PATCH] D83788: Removed unused variable in clang

2020-07-29 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. Not sure why this didnt get closed after the patch is merged in: https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83788/new/ https://reviews.llvm.org/D83788

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

2020-07-29 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. arphaman added a reviewer: steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous, kristof.beyls, mgorny, dberris. arphaman requested review of this revision. This change lets compiler-rt build the libclang_rt.sim.a library with the arm64 Apple

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

2020-07-29 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. May be this check belongs to `bugprone` module? Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Finds complex conditions using <, >, <=, and >= that have no mathematical + meaning. Please enclose comparison

[clang] f71deb4 - [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2020-07-29T19:55:20-07:00 New Revision: f71deb43abea588901c083d3e6d6d25371b486ae URL: https://github.com/llvm/llvm-project/commit/f71deb43abea588901c083d3e6d6d25371b486ae DIFF: https://github.com/llvm/llvm-project/commit/f71deb43abea588901c083d3e6d6d25371b486ae.diff

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf71deb43abea: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors. (authored by akhuang). Changed prior to commit: https://reviews.llvm.org/D84870?vs=281722=281785#toc Repository: rG

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

2020-07-29 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 281783. Conanap added a comment. Replaced a forgotten test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 Files: clang/lib/Headers/altivec.h

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: alexfh, gribozavr, dcoughlin, delcypher, yln, kubamracek, vsavchenko, njames93. Herald added subscribers: martong, mgehre, Charusso, xazax.hun. NoQ requested review of this revision. I debugged the problem from D84453

[PATCH] D84898: clang-tidy] Add new checker for complex conditions with no meaning

2020-07-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. I believe this is ready for review. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 ___ cfe-commits mailing list

[clang] a648834 - PR46729: Reject explicit and partial specializations with C linkage.

2020-07-29 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-07-29T17:44:32-07:00 New Revision: a64883431369f28f3fac311c496a4dfad480058f URL: https://github.com/llvm/llvm-project/commit/a64883431369f28f3fac311c496a4dfad480058f DIFF: https://github.com/llvm/llvm-project/commit/a64883431369f28f3fac311c496a4dfad480058f.diff

[PATCH] D84898: clang-tidy] Add new checker for complex conditions with no meaning

2020-07-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 281770. vabridgers added a comment. Another update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

2020-07-29 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. That did the trick, thanks! The bot was broken for > 5h and 43 builds. We got lucky that nothing else broke in the meantime, but red bots make it more difficult to analyze new regressions that appear when the bots are already red. Next time, please revert while you

[PATCH] D84898: clang-tidy] Add new checker for complex conditions with no meaning

2020-07-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers updated this revision to Diff 281769. vabridgers added a comment. Correct some simple mistakes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 Files:

[PATCH] D84898: clang-tidy] Add new checker for complex conditions with no meaning

2020-07-29 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. Herald added subscribers: cfe-commits, phosek, Charusso, mgorny. Herald added a project: clang. vabridgers requested review of this revision. This checker finds cases where relational expressions have no meaning. For example, (x <= y <= z) has no meaning, but

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. Latest update diff: < + std::vector Data; < + for (unsigned I = 0; I < 8; ++I) < +Data.push_back((uint8_t)(Num >> (I * 8))); --- > + uint8_t Data[8]; > + support::endian::write64le(Data, Num); Comment at:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281764. yamauchi added a comment. Use endian::write64le. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinlto_expect1.proftext

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. Here's the diff in the latest update: < +union { < + uint64_t N; < + uint8_t C[8]; < +} Data; < +Data.N = (uint64_t)SIVisitor.getNumOfSelectInsts(); < +JCH.update(Data.C); < +Data.N =

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:661 +} Data; +Data.N = (uint64_t)SIVisitor.getNumOfSelectInsts(); +JCH.update(Data.C); MaskRay wrote: > MaskRay wrote: > > `#include

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281760. yamauchi added a comment. Fix the endianness issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files:

[PATCH] D81242: [StackSafety] Run ThinLTO

2020-07-29 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added a comment. I just noticed that generateParamAccessSummary is taking a bit over 5% of the ThinLTO thin link step in an internal build (and will soon be more than 5% as I found another analysis that is hogging compile time that I'm going to work on fixing). This is currently the

[PATCH] D84814: [clang-tidy] readability-identifier-naming checks configs for included files

2020-07-29 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 281756. njames93 added a comment. Rebase from parent and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84814/new/ https://reviews.llvm.org/D84814 Files:

[PATCH] D84894: [clangd] Implement Relations request for remote index

2020-07-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 281754. kbobyrev added a comment. Fix comment in proto file and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:661 +} Data; +Data.N = (uint64_t)SIVisitor.getNumOfSelectInsts(); +JCH.update(Data.C); MaskRay wrote: > `#include "llvm/Support/Endian.h"` > > and

[clang] dc22182 - [darwin] build and link with a separate compiler-rt builtins library

2020-07-29 Thread Alex Lorenz via cfe-commits
Author: Alex Lorenz Date: 2020-07-29T15:32:30-07:00 New Revision: dc22182d1f7489239388f7bdd04170573c0652a3 URL: https://github.com/llvm/llvm-project/commit/dc22182d1f7489239388f7bdd04170573c0652a3 DIFF: https://github.com/llvm/llvm-project/commit/dc22182d1f7489239388f7bdd04170573c0652a3.diff

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

2020-07-29 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGdc22182d1f74: [darwin] build and link with a separate compiler-rt builtins library (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp:661 +} Data; +Data.N = (uint64_t)SIVisitor.getNumOfSelectInsts(); +JCH.update(Data.C); `#include "llvm/Support/Endian.h"` and use

[PATCH] D84812: [clang-tidy][NFC] Added convienence methods for getting optional options

2020-07-29 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 281752. njames93 added a comment. Revert to using warning for logging parsing errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84812/new/ https://reviews.llvm.org/D84812 Files:

[PATCH] D84894: [clangd] Implement Relations request for remote index

2020-07-29 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is the last missing bit in

[PATCH] D62574: Initial draft of target-configurable address spaces.

2020-07-29 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. > This was also only an initial concept. I think that even once all the issues > with the patch have been ironed out, it would require a round of wider review > since it's a fairly hefty API change. You don't always need a super polished prototype to justify adding

[clang] ae7589e - Revert "[PGO] Include the mem ops into the function hash."

2020-07-29 Thread Hiroshi Yamauchi via cfe-commits
Author: Hiroshi Yamauchi Date: 2020-07-29T15:04:57-07:00 New Revision: ae7589e1f100b30a4ae13da713c9273733e69fe1 URL: https://github.com/llvm/llvm-project/commit/ae7589e1f100b30a4ae13da713c9273733e69fe1 DIFF:

[PATCH] D62574: Initial draft of target-configurable address spaces.

2020-07-29 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D62574#2136423 , @ebevhan wrote: > It seems that D70605 attempted to > ameliorate the issues that I observed (pointer-conversion doing too much), > but it didn't manage to solve the problem

Re: [PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Xinliang David Li via cfe-commits
right. It occurred to me during review, but did not think of the hard coded values in proftext depends on LE. On Wed, Jul 29, 2020 at 3:04 PM Hiroshi Yamauchi via Phabricator < revi...@reviews.llvm.org> wrote: > yamauchi added a comment. > > Builtbot failure: >

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added a comment. Builtbot failure: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/51984 I think it's an endian issue in the hash computation. Will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

2020-07-29 Thread Thomas Lively via Phabricator via cfe-commits
tlively added a comment. Since this changes opcodes, it needs to be landed in concert with the corresponding Binaryen change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84820/new/ https://reviews.llvm.org/D84820

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D84870#2183096 , @akhuang wrote: > remove change to add class types to retained types list, > > also fix the test case to be a struct that

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

2020-07-29 Thread Alexander Lanin via Phabricator via cfe-commits
AlexanderLanin planned changes to this revision. AlexanderLanin added a comment. The reason was that I thought that line doesn't do anything. Of course "not crashing" is a valid expectation. If nothing else, then "not crashing" should indeed be tested. I'll try to improve this ancient diff.

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Ye Luo via Phabricator via cfe-commits
ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. My applications run as expected now. PR46824, PR46012, PR46868 all work fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: jdoerfert, RaviNarayanaswamy. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Need to map the component as TO instead of the literal,

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

2020-07-29 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 281735. Conanap added a comment. Fixed formatting based on bot feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 Files: clang/lib/Headers/altivec.h

[clang] 120e66b - [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via cfe-commits
Author: Hiroshi Yamauchi Date: 2020-07-29T13:59:40-07:00 New Revision: 120e66b3418b37b95fc1dbbb23e296a602a24fa8 URL: https://github.com/llvm/llvm-project/commit/120e66b3418b37b95fc1dbbb23e296a602a24fa8 DIFF:

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG120e66b3418b: [PGO] Include the mem ops into the function hash. (authored by yamauchi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] b08abf4 - [OpenMP] Fix D83281 issue on windows by allowing `dso_local` in CHECK [2/1]

2020-07-29 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-29T15:47:45-05:00 New Revision: b08abf4c808e98718b8806dafcae1626328676d4 URL: https://github.com/llvm/llvm-project/commit/b08abf4c808e98718b8806dafcae1626328676d4 DIFF:

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

2020-07-29 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D83281#2183100 , @thakis wrote: > Looks like it's still failing with that change: > http://45.33.8.238/win/20885/step_7.txt dso_local is *before* the void,.. 2 min Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

2020-07-29 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like it's still failing with that change: http://45.33.8.238/win/20885/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/ https://reviews.llvm.org/D83281

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 281722. akhuang added a comment. remove change to add class types to retained types list, also fix the test case to be a struct that previously didn't get complete debug info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang added a comment. In D84870#2182463 , @dblaikie wrote: > I think it'd be good to separate these two issues/patches. > > In part because I'm curious whether, even with a trivial ctor - if we did the > retained types thing - would that be enough? I

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread David Li via Phabricator via cfe-commits
davidxl accepted this revision. davidxl added a comment. lgtm Just realized that we need a test case to show it fixes the original issue (existence with memop --> different hash). Ok as a follow up . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281716. yamauchi added a comment. Address comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinlto_expect1.proftext

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/test/Transforms/PGOProfile/Inputs/multiple_hash_profile.proftext:20 18 12 davidxl wrote: > nit: change 12 to a different value say 6.(otherwise if the option is an nop, > the test will still succeed). Done.

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. LGTM as well with @davidxl's comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

2020-07-29 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D83281#2182507 , @thakis wrote: > This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt > > Please take a look, and revert while you investigate if it takes a while to > fix. Should be fixed by

[clang] 8723280 - [OpenMP] Fix D83281 issue on windows by allowing `dso_local` in CHECK

2020-07-29 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-07-29T15:18:20-05:00 New Revision: 8723280b68b1e5ed97a699466720b36a32a9e406 URL: https://github.com/llvm/llvm-project/commit/8723280b68b1e5ed97a699466720b36a32a9e406 DIFF:

[clang-tools-extra] 6ce97ee - Fix invalid attempted explicit instantiation, which Clang now rejects.

2020-07-29 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-07-29T13:07:34-07:00 New Revision: 6ce97eee35463be2ccd82ae659034506ae9b25f1 URL: https://github.com/llvm/llvm-project/commit/6ce97eee35463be2ccd82ae659034506ae9b25f1 DIFF: https://github.com/llvm/llvm-project/commit/6ce97eee35463be2ccd82ae659034506ae9b25f1.diff

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread David Li via Phabricator via cfe-commits
davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm (with the small test enhancement) Comment at: llvm/test/Transforms/PGOProfile/Inputs/multiple_hash_profile.proftext:20 18 12 nit: change 12 to a

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi added inline comments. Comment at: llvm/test/Transforms/PGOProfile/Inputs/multiple_hash_profile.proftext:1 # IR level Instrumentation Flag :ir davidxl wrote: > We can convert this test case to cover the new option introduced: > > basically create

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281708. yamauchi added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files: clang/test/CodeGen/Inputs/thinlto_expect1.proftext

[PATCH] D84886: Create LoopNestPass

2020-07-29 Thread Ta-Wei Tu via Phabricator via cfe-commits
TaWeiTu created this revision. TaWeiTu added reviewers: Whitney, etiotto, fedor.sergeev, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, asbirlea, dexonsmith, steven_wu, hiraditya, mgorny. Herald added projects: clang, LLVM. TaWeiTu requested review of this revision. Per

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

2020-07-29 Thread David Tenty via Phabricator via cfe-commits
daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84880/new/ https://reviews.llvm.org/D84880

[clang] 1cbdf93 - PR46231: Promote diagnostic for 'template<...>;' from ExtWarn to Error.

2020-07-29 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-07-29T12:35:18-07:00 New Revision: 1cbdf932b41eb58ed94fbc240e93b63653d95bd3 URL: https://github.com/llvm/llvm-project/commit/1cbdf932b41eb58ed94fbc240e93b63653d95bd3 DIFF: https://github.com/llvm/llvm-project/commit/1cbdf932b41eb58ed94fbc240e93b63653d95bd3.diff

[clang] e69138d - PR46859: Fix crash if declaring a template in a DeclScope with no DeclContext.

2020-07-29 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-07-29T12:02:55-07:00 New Revision: e69138dad5a535c4027a1931f05cabab0f484974 URL: https://github.com/llvm/llvm-project/commit/e69138dad5a535c4027a1931f05cabab0f484974 DIFF: https://github.com/llvm/llvm-project/commit/e69138dad5a535c4027a1931f05cabab0f484974.diff

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

2020-07-29 Thread Lei Huang via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7aaa85627b59: [PowerPC] Add options to control paired vector memops support (authored by bsaleil, committed by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7aaa856 - [PowerPC] Add options to control paired vector memops support

2020-07-29 Thread Lei Huang via cfe-commits
Author: Baptiste Saleil Date: 2020-07-29T14:00:53-05:00 New Revision: 7aaa85627b5937364d4c944d8f6828a6a3759785 URL: https://github.com/llvm/llvm-project/commit/7aaa85627b5937364d4c944d8f6828a6a3759785 DIFF:

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2d0b44a7cd2: [DFSan] Add efficient fast16labels instrumentation mode. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES

[clang] e2d0b44 - [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via cfe-commits
Author: Matt Morehouse Date: 2020-07-29T18:58:47Z New Revision: e2d0b44a7cd261218c9e527d23eb5d13425afe8b URL: https://github.com/llvm/llvm-project/commit/e2d0b44a7cd261218c9e527d23eb5d13425afe8b DIFF: https://github.com/llvm/llvm-project/commit/e2d0b44a7cd261218c9e527d23eb5d13425afe8b.diff

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

2020-07-29 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, jasonliu, stevewan, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Repository: rG LLVM Github Monorepo

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281690. ABataev added a comment. Fixed comment in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; vitalybuka wrote: > morehouse wrote: > >

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse updated this revision to Diff 281687. morehouse marked 2 inline comments as done. morehouse added a comment. - Remove preinit stuff and API warnings; use custom union-load callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread David Li via Phabricator via cfe-commits
davidxl added inline comments. Comment at: llvm/test/Transforms/PGOProfile/Inputs/multiple_hash_profile.proftext:1 # IR level Instrumentation Flag :ir We can convert this test case to cover the new option introduced: basically create another profile entry

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-07-29 Thread Gui Andrade via Phabricator via cfe-commits
guiand marked 5 inline comments as done. guiand added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2148-2150 +} else if (const VarDecl *VDecl = dyn_cast(TargetDecl)) { + // Function pointer + HasStrictReturn &= !VDecl->isExternC();

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-07-29 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 281676. guiand added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

2020-07-29 Thread Gui Andrade via Phabricator via cfe-commits
guiand updated this revision to Diff 281679. guiand added a comment. Updated comment on disable-noundef-args option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 Files:

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread George Rokos via Phabricator via cfe-commits
grokos added inline comments. Comment at: clang/test/OpenMP/target_data_codegen.cpp:659-660 // PRESENT=0x1000 | TARGET_PARAM=0x20 = 0x1020 - // MEMBER_OF_9=0x9 | PRESENT=0x1000 | FROM=0x2 | TO=0x1 = 0x91003 - // MEMBER_OF_9=0x9 |

[PATCH] D84824: [HIP] Emit target-id module flag

2020-07-29 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:603-605 +TargetIDStr == "" +? TargetIDStr +: (Twine(getTriple().str()) + "-" +

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281682. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

2020-07-29 Thread Hiroshi Yamauchi via Phabricator via cfe-commits
yamauchi updated this revision to Diff 281673. yamauchi added a comment. Rebase past D84865 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 Files:

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

2020-07-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit about the tests, though I'm still surprised `IdentLoc` is valid even when there's no identifier present. :-) Comment at:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-07-29 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. LGTM, modulo couple of nits. @jyknight are you OK with this? In D71726#2179428 , @yaxunl wrote: > Make IEEE single and double type as supported for fp atomics in all targets > by default. This is based on the assumption that

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

2020-07-29 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin abandoned this revision. aheejin added a comment. It looks it was already addressed by https://github.com/llvm/llvm-project/commit/1603470e59a99a39ebdc4bf62a3a16c8c4ebea36#diff-761bab5bd4145e54cef902c493740880. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

2020-07-29 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

2020-07-29 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 281665. ABataev added a comment. Rebase + apply to global pointers only. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84767/new/ https://reviews.llvm.org/D84767 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

2020-07-29 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin created this revision. aheejin added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. aheejin requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. After D84697

[PATCH] D84843: [Analyzer] Remove inclusion of uniqueing decl from diagnostic profile.

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Aha, ok, yeah, so that's what caused it! I guess if we want a uniqueing decl for this case, we should use the original template decl rather than the instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84303: [analyzer][tests] Fix SATest update functionality

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. We absolutely needed this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84303/new/ https://reviews.llvm.org/D84303

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

2020-07-29 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71d0a2b8a313: [DFSan][NewPM] Port DataFlowSanitizer to NewPM (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 71d0a2b - [DFSan][NewPM] Port DataFlowSanitizer to NewPM

2020-07-29 Thread Arthur Eubanks via cfe-commits
Author: Arthur Eubanks Date: 2020-07-29T10:19:15-07:00 New Revision: 71d0a2b8a31344ab29d1afd0c54d89873fb3cc9e URL: https://github.com/llvm/llvm-project/commit/71d0a2b8a31344ab29d1afd0c54d89873fb3cc9e DIFF:

[PATCH] D84743: [Clang][AMDGCN] Universal device offloading macros header

2020-07-29 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. Also, do we need the header at all? It would be much easier to just get clang itself to add normalized macros without trying to reconstruct them from the existing macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

2020-07-29 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 ___ cfe-commits mailing list

[PATCH] D84494: [Analyzer] Use of BugType in DereferenceChecker (NFC).

2020-07-29 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko accepted this revision. vsavchenko added a comment. Awesome, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84494/new/ https://reviews.llvm.org/D84494 ___ cfe-commits mailing list

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

2020-07-29 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks check-clang on Windows: http://45.33.8.238/win/20850/step_7.txt Please take a look, and revert while you investigate if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83281/new/

[PATCH] D84707: [DFSan][NewPM] Port DataFlowSanitizer to NewPM

2020-07-29 Thread Matt Morehouse via Phabricator via cfe-commits
morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84707/new/ https://reviews.llvm.org/D84707 ___ cfe-commits mailing list

[PATCH] D84837: [clangd] Fix an assertion failure in TargetFinder's heuristic resolution of dependent type.

2020-07-29 Thread Nathan Ridge via Phabricator via cfe-commits
nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:171 // or more declarations that it likely references. -std::vector resolveDependentExprToDecls(const Expr *E) {

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. I think it'd be good to separate these two issues/patches. In part because I'm curious whether, even with a trivial ctor - if we did the retained types thing - would that be enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84870: [DebugInfo] Fix to ctor homing to ignore classes with trivial ctors.

2020-07-29 Thread Amy Huang via Phabricator via cfe-commits
akhuang created this revision. akhuang added a reviewer: dblaikie. Herald added subscribers: cfe-commits, aprantl. Herald added a project: clang. akhuang requested review of this revision. Previously ctor homing was omitting debug info for classes if they have both trival and nontrivial

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

2020-07-29 Thread Jaydeep Chauhan via Phabricator via cfe-commits
Jac1494 updated this revision to Diff 281644. Jac1494 added a comment. Address @aaron.ballman review comments. I have added your test case that is passing as well. This patch covers this scenario also. Thanks @aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

2020-07-29 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D80391#2179182 , @MaskRay wrote: > Ping... Was hoping to get some more discussion on the general debug flag naming thread on the GCC list, but that hasn't happened - so I've replied/poked it a bit:

  1   2   >