[PATCH] D84136: [clang] Fix visitation of ConceptSpecializationExpr in constrained-parameter

nridge updated this revision to Diff 282807. nridge added a comment. Rebase on top of D85108 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84136/new/ https://reviews.llvm.org/D84136 Files: clang-tools-extra/clan

[clang-tools-extra] 4ede396 - [clang] Include trailing-requires-clause in FunctionDecl's source range

Author: Nathan Ridge Date: 2020-08-04T02:52:01-04:00 New Revision: 4ede3968498174f35f8456cd4bf95d14811d40d1 URL: https://github.com/llvm/llvm-project/commit/4ede3968498174f35f8456cd4bf95d14811d40d1 DIFF: https://github.com/llvm/llvm-project/commit/4ede3968498174f35f8456cd4bf95d14811d40d1.diff

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ede39684981: [clang] Include trailing-requires-clause in FunctionDecl's source range (authored by nridge). Repository: rG LLVM Github Monorepo C

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282805. nridge added a comment. Rebase to avoid dependency on D84136 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-too

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660 return; + if (SrcType->isIntegerType() && DestType->isFixedPointType()) +return; vabridgers wrote: > bjope wrote: > > Is this really the intention with the patch? > > > > It does

[PATCH] D85108: [clang] Include trailing-requires-clause in FunctionDecl's source range

nridge updated this revision to Diff 282804. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85108/new/ https://reviews.llvm.org/D85108 Files: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D85124: [Concepts] Include the found concept decl when dumping the ConceptSpecializationExpr

nridge accepted this revision. nridge added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-concepts.cpp:18 // CHECK: TemplateTypeParmDecl {{.*}} referenced Concept {{.*}} 'binary_concept' - // CHECK-NEXT: |-ConceptS

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song updated this revision to Diff 282801. yonghong-song added a comment. add a test case in clang where testing type existence of a named struct and the typedef of that named struct will result in different IR intrinsic func arguments which will prevent CSE which may lose one of ditype

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song added a comment. In D85174#2192269 , @ast wrote: > Is it a cleanup or is it a fix for some bug? If latter there should be a new > test for it? This is also to fix the CSE issue where two builtins are CSE'ed if one has type "struct t" and t

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song added a comment. In D83242#2192130 , @anakryiko wrote: > LGTM. One question: why didn't we run into the need for SeqNumVal trick with > field-based relocations? We seem to need it for all other types (including > type ID-based), but not for

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:36 const Preprocessor &PP, \ const cross_tu::CrossTranslationUnitContext &CTU); +#include "clang/Analysis/PathDi

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 282798. NoQ marked an inline comment as done. NoQ added a reviewer: vsavchenko. NoQ added a comment. Herald added a subscriber: steakhal. And rebase. Addressed comments. With @Szelethus's refactoring work the patch actually looks much cleaner than it used to.

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullDereference.h:21 +namespace ento { +namespace nullDereference { + Namespaces are traditionally snake_case rather than camelCase. Comment at: clang/lib/StaticAnalyzer/C

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45849 This is caused by gap area not emitted if either `AfterLoc` or `BeforeLoc` is a macro loca

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. Tested locally. Previously failing tests are now passing. All recorded relocations look correct. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

ast added a comment. Is it a cleanup or is it a fix for some bug? If latter there should be a new test for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85174/new/ https://reviews.llvm.org/D85174 __

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > bjope wrote: > > > This should be added before the line saying `/* All fol

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers updated this revision to Diff 282776. vabridgers marked 2 inline comments as done. vabridgers added a comment. remove -DFIXED_POINT from lit test, since it's not needed in this casting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/n

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers marked 5 inline comments as done. vabridgers added a comment. I updated the commit header with more details since the first submission was obviously too terse. @bjope, I believe the update should address your comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers updated this revision to Diff 282775. vabridgers added a comment. improve the commit message detail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85157/new/ https://reviews.llvm.org/D85157 Files: clang/lib/Sema/SemaCast.cpp clang/te

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. yonghong-song added a project: clang. Herald added subscribers: llvm-commits, cfe-commits, JDevlieghere, hiraditya. Herald added a project: LLVM. yonghong-song requested review of this revision. This patch simplifi

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:86 + if (const auto *DR = dyn_cast(DerefRegion)) { +auto SmartPtrName = DR->getDecl()->getName(); +OS << " '" << SmartPtrName << "'"; NoQ wrote: > Plea

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar updated this revision to Diff 282771. vrnithinkumar marked 10 inline comments as done. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Addressing review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 1beb00d - Fix use-after-scope in 7209f83112db caught by the sanitizer bots

Author: Daniel Sanders Date: 2020-08-03T16:55:00-07:00 New Revision: 1beb00db1f5197efb73f839da681b8e439f37628 URL: https://github.com/llvm/llvm-project/commit/1beb00db1f5197efb73f839da681b8e439f37628 DIFF: https://github.com/llvm/llvm-project/commit/1beb00db1f5197efb73f839da681b8e439f37628.diff

[clang-tools-extra] 3b44b6c - [clang-tidy][NFC] Use correct size call for reserve

Author: Nathan James Date: 2020-08-04T00:31:19+01:00 New Revision: 3b44b6c900d1b71e6a6590e376d11dc303ac5159 URL: https://github.com/llvm/llvm-project/commit/3b44b6c900d1b71e6a6590e376d11dc303ac5159 DIFF: https://github.com/llvm/llvm-project/commit/3b44b6c900d1b71e6a6590e376d11dc303ac5159.diff

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

anakryiko accepted this revision. anakryiko added a comment. LGTM. One question: why didn't we run into the need for SeqNumVal trick with field-based relocations? We seem to need it for all other types (including type ID-based), but not for field-based? Repository: rG LLVM Github Monorepo C

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

hctim added a comment. Hi folks, looks like this patch broke `check-clang` under ASan/MSan, would you mind taking a look? Thanks. FAIL: Clang :: Driver/darwin-dsymutil.c (6208 of 24675) TEST 'Clang :: Driver/darwin-dsymutil.c' FAILED Script: --

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 282757. njames93 added a comment. - Rebased trunk - Cleaned up test cases - Added support for specifying to include as system include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/ https://reviews.l

[clang] 045e79e - [VE] Extend integer arguments and return values smaller than 64 bits

Author: Kazushi (Jam) Marukawa Date: 2020-08-04T08:07:05+09:00 New Revision: 045e79e77c252f2c73c640e820e977ef52836d50 URL: https://github.com/llvm/llvm-project/commit/045e79e77c252f2c73c640e820e977ef52836d50 DIFF: https://github.com/llvm/llvm-project/commit/045e79e77c252f2c73c640e820e977ef52836

[PATCH] D85071: [VE] Extend integer arguments and return values smaller than 64 bits

This revision was automatically updated to reflect the committed changes. Closed by commit rG045e79e77c25: [VE] Extend integer arguments and return values smaller than 64 bits (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85071/ne

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/test/Sema/warn-bad-function-cast.c:49 +#ifdef FIXED_POINT + (void)(_Fract) if1(); // no warning +#endif bjope wrote: > bjope wrote: > > This should be added before the line saying `/* All following casts issue > >

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

bjope added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2660 return; + if (SrcType->isIntegerType() && DestType->isFixedPointType()) +return; Is this really the intention with the patch? It does match the "summary" above, but isn't the war

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

aeubanks added a comment. I'm looking at enabling the -enable-npm-optnone flag and FullUnroll.ll fails. I understand that loop unrolling should be forced when some metadata is present, but the FullUnroll.ll test seems to check for a lot more than that. It checks for (roughly) two unconditional

[clang] 7cf4603 - Reland D61689 Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED) with integrated assembler

Author: Fangrui Song Date: 2020-08-03T15:12:01-07:00 New Revision: 7cf4603faee366a6e5860b6fdbedadd91872e231 URL: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231 DIFF: https://github.com/llvm/llvm-project/commit/7cf4603faee366a6e5860b6fdbedadd91872e231.diff

[PATCH] D85097: [Sema] add warning for comparisons like 'x<=y<=z'

njames93 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14047 +static bool isComparisonOpSamePrecedence(BinaryOperatorKind Opc) { + switch (Opc) { Quuxplusone wrote: > Same precedence as what? > I think this should just be called `isRelationalO

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

jdoerfert added a comment. I think this is good. Let's see if there are objections Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 ___ cfe-commits mailing list cf

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

lanza added a comment. ping @rjmccall. Any update on a timeline for this review process? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits m

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb327922101b: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHA

[clang] cb32792 - [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

Author: Thomas Lively Date: 2020-08-03T13:54:00-07:00 New Revision: cb327922101b28ea70ec68d7f026da0e5e388eed URL: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed DIFF: https://github.com/llvm/llvm-project/commit/cb327922101b28ea70ec68d7f026da0e5e388eed.diff

[PATCH] D85157: [Sema] Add casting check for integer to fixed point conversions

vabridgers created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. vabridgers requested review of this revision. This change squelches the warning for a cast from integer to fixed point conversions. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

This revision was automatically updated to reflect the committed changes. Closed by commit rG41b1e97b12c1: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 41b1e97 - [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as

Author: Akira Hatanaka Date: 2020-08-03T13:25:25-07:00 New Revision: 41b1e97b12c1407e40d8e5081bf1f9cf183934b0 URL: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0 DIFF: https://github.com/llvm/llvm-project/commit/41b1e97b12c1407e40d8e5081bf1f9cf183934b0.diff

[clang] 7209f83 - Allow .dSYM's to be directly placed in an alternate directory

Author: Daniel Sanders Date: 2020-08-03T13:18:52-07:00 New Revision: 7209f83112db4dbe15d8328705f9d2aff0624fbd URL: https://github.com/llvm/llvm-project/commit/7209f83112db4dbe15d8328705f9d2aff0624fbd DIFF: https://github.com/llvm/llvm-project/commit/7209f83112db4dbe15d8328705f9d2aff0624fbd.diff

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

This revision was automatically updated to reflect the committed changes. Closed by commit rG7209f83112db: Allow .dSYM's to be directly placed in an alternate directory (authored by dsanders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84572/new/

RE: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Committed dca23ed; should be fixed now. -Eli From: Azhar Mohammed Sent: Monday, August 3, 2020 11:01 AM To: Eli Friedman ; Eli Friedman via Phabricator ; Eli Friedman Cc: sander.desma...@arm.com; sjoerd.mei...@arm.com; t.p.northo...@gmail.com; cameron.mcina...@nyu.edu; blitzrak...@gmail.com;

[PATCH] D83863: [OpenMP] Change version 4.5 hardcoded clang tests to default OpenMP version

saiislam abandoned this revision. saiislam added a comment. Abandoning in favor of D84844 and D85150 i.e. adding default version testing along with version 4.5 testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane added a comment. In D82562#2191512 , @dmajor wrote: > @erichkeane, could you help me understand what is the action item of these > warnings? > > In Firefox we don't require AVX so our compilations generally don't enable > the feature. (A very

[PATCH] D82562: Implement AVX ABI Warning/error

dmajor added a comment. @erichkeane, could you help me understand what is the action item of these warnings? In Firefox we don't require AVX so our compilations generally don't enable the feature. (A very small number of files do come with AVX versions, mostly in imported media codecs, but the

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I would appreciate it, if somebody could commit this patch on my behalf. Thorsten Schuett schu...@gmail.com Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-co

[PATCH] D83788: Removed unused variable in clang

dblaikie closed this revision. dblaikie added a comment. In D83788#2183684 , @hiraditya wrote: > Not sure why this didnt get closed after the patch is merged in: > https://reviews.llvm.org/rG4fd91b0f946f49370a3ab33c480a807a3f48b247 The commit didn't cont

[PATCH] D85144: [clang] Improve Dumping of APValues

riccibruno added inline comments. Comment at: clang/lib/AST/APValue.cpp:539 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy.getCanonicalType())->getElementType(); } -

[PATCH] D85144: [clang] Improve Dumping of APValues

riccibruno added a comment. Thanks for finishing this. I don't see why you are adding `dumpPretty`; the point of the `dump` function I added is to dump the `APValue` as the tree-like structure it is. But your `dumpPretty` doesn't do that at all. Instead it is just an alias for `printPretty`. S

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. In D84782#2191243 , @MaskRay wrote: > @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 > and > 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d >

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1778 -std::pair FieldInfo = - Context.getTypeInfoInChars(D->getType()); -EffectiveFieldSize = FieldSize = FieldInfo.first; ebevhan wrote: > It seems that in factoring o

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:4076-4077 + R"cpp( +struct X{ + struct Y{}; +}; Please add spaces before `{`. ===

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

eduucaldas added a comment. Additionally deleting TraverseParenTypeLoc changes nothing in the tests. I can also investigate that, I can try to come up with a test that makes this Traverse override relevant and if I'm not able, I would remove this override. Comment at: clang/u

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

efriedma added a comment. Not going to write detailed review comments, but this looks like the right approach in general. One high-level thing to consider: we could still decide that in IR generation, we want to represent VLSTs registers using scalable vector types, like the original patch did

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D85146 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/unittests/Tooling/S

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

efriedma added a comment. Would it be worth looking into improving our general test coverage here? The fact that we don't have any test that verifies the actual signatures of the NEON intrinsics (which could be used to compare against other compilers) seems bad. Repository: rG LLVM Github

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker updated this revision to Diff 282687. Tyker added a comment. remove unintended code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85144/new/ https://reviews.llvm.org/D85144 Files: clang/include/clang/AST/APValue.h clang/include/clang/AS

Re: [PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Hey Eli, Looks like this is causing the test-suite build to fail. Can you please take a look. Refer to http://green.lab.llvm.org/green/job/test-suite-verify-machineinstrs-aarch64-O3/8035/consoleFull

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11883-11885 ExprResult Result = ActOnFinishFullExpr(Init, VDecl->getLocation(), /*DiscardedValue*/ false, VDecl->isConstexpr()); rsmith wrote: > This may cre

[PATCH] D85144: [clang] Improve Dumping of APValues

Tyker created this revision. Tyker added reviewers: rsmith, riccibruno. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker requested review of this revision. this is required for proper testing of D63640 Repository: rG LLVM Github Mon

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 282682. Tyker edited the summary of this revision. Tyker added a comment. Sorry for the delay In D63640#2151016 , @rsmith wrote: > Are we at a point where we can test this now? Yes we can use consteval to test it. so i

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively updated this revision to Diff 282680. tlively added a comment. - Renumber i32x4.dot_i16x8_s to match V8 as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84820/new/ https://reviews.llvm.org/D84820 Files: clang/include/clang/Basic/Bui

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5, 5.0, and default - Part 1

saiislam updated this revision to Diff 282678. saiislam added a comment. Removed redundant testing for version 5.0 with its version string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/ https://reviews.llvm.org/D84844 Files: clang/tes

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. Would you like to pick it back up? We laid out an implementation path: we need to track the fact that a delete was of an incomplete class type in the AST and then unconditionally treat such operations as trivial to destroy in IRGen. Repository: rC Clang CHANGES SI

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84540/new/ https://reviews.llvm.org/D84540 _

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; arsenm wrote: > rjmccall wrote: > > In principle, this can be `inreg` just as much as Indirect ca

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

baloghadamsoftware updated this revision to Diff 282675. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76604/new/ https://reviews.llvm.org/D76604 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp clang/lib/StaticAnalyzer/Che

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a subscriber: hans. MaskRay added a comment. @yamauchi Do we need cd890944ad344b1b8cac58332ab11c9eec6b61e9 and 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d

[PATCH] D77697: libc++: adjust modulemap for non-modular C

compnerd abandoned this revision. compnerd added a comment. Given that the original motivation here was to help with NetBSD, and the submodule visibility flag handling unblocks NetBSD, I think that I will hold off on this unless some other motivation arises. Repository: rG LLVM Github Monore

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:345 Diag(Loc, diag::err_omp_declare_mapper_wrong_var) -<< DMD->getVarName().getAsString(); +<< getOpenMPDeclareMapperVarName(); Diag(D->getLocation(), diag::note_entity_declared_at

[PATCH] D81242: [StackSafety] Run ThinLTO

tejohnson added a comment. In D81242#2190041 , @vitalybuka wrote: > In D81242#2188467 , @tejohnson wrote: > >> In D81242#2188441 , @vitalybuka >> wrote: >> >>> In D81242#218

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

tschuett added a comment. Stupid questions. - Is it for convenience? You get arrays, global variables, structs, ... . Vectorization becomes easier ... - Are there any potential performance benefits over scalable vectors? - Is it compatible with GCC? Repository: rG LLVM Github Monorepo CHA

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang added a comment. still waiting for inputs. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84246/new/ https://reviews.llvm.org/D84246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware updated this revision to Diff 282642. baloghadamsoftware added a comment. Option made hidden. However, I think we should create a category "advanced" for options which affect the internal modeling. Our users are programmers and the advanced among them should see this option (a

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___

[PATCH] D85016: [clang-format] Add space between method modifier and a tuple return type in C#

krasimir accepted this revision. krasimir added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85016/new/ https://reviews.llvm.org/D85016 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

balazske added a comment. Really I am still not totally familiar how the checkers work and if it is good to have these function names. I was thinking about any checker that needs a string length information. It could get the data from CStringChecker using a "get" function or test if there is da

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett updated this revision to Diff 282637. tschuett added a comment. added missing "alignment" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/clang/Basic/Diagnost

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

tschuett added a comment. I wanted to save space. I know that the alignment is missing there, but the line is already too long. I have no rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

jfb accepted this revision. jfb added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/atomics-sema-alignment.c:43 + Foo bar; + __atomic_load(foo, &bar, __ATOMIC_RELAXED); // expected-warning {{misaligned atomic operation may inc

[PATCH] D84303: [analyzer][tests] Fix SATest update functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rG10851f9db5f7: [analyzer][tests] Fix SATest update functionality (authored by vsavchenko). Herald added a subscriber: steakhal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 10851f9 - [analyzer][tests] Fix SATest update functionality

Author: Valeriy Savchenko Date: 2020-08-03T18:21:15+03:00 New Revision: 10851f9db5f7d163135374b8dfc945e1b4a9c7d6 URL: https://github.com/llvm/llvm-project/commit/10851f9db5f7d163135374b8dfc945e1b4a9c7d6 DIFF: https://github.com/llvm/llvm-project/commit/10851f9db5f7d163135374b8dfc945e1b4a9c7d6.d

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

baloghadamsoftware added a comment. In D83190#2164361 , @gamesh411 wrote: > I experienced 2 crashes with and without this patch using commit > `1af9fc82132da7c876e8f70c4e986cc9c59010ee` on master: > I have used the clang built on that revision to analyse

[PATCH] D77229: [Analyzer] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 282626. baloghadamsoftware added a comment. Crash Fix: do not retrieve first iterator argument in advance. (It may happen that although argument count is more than zero, there is no argument at all.) CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D83325: [Sema] Be more thorough when unpacking the AS-qualified pointee for a pointer conversion.

ebevhan added a comment. In D83325#2170813 , @rjmccall wrote: > `removeAddrSpaceQualType` should guarantee that it removes the address space > qualifier; you shouldn't need to do something special here. That means it > needs to iteratively desugar and c

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} whisperity wrote: > aaron.ballman wrote: >

[PATCH] D85034: [analyzer] Simplify functions SVal::getAsSymbolicExpression and similar ones

vsavchenko added a comment. > Ready! Sorry, I remember, you've already told me. Nothing to be sorry about! It's really not that big of a deal. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85034/new/ https://reviews.llvm.org/D85034

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

sunfish updated this revision to Diff 282608. sunfish added a comment. - Update clang/test/CodeGen/builtins-wasm.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85074/new/ https://reviews.llvm.org/D85074 Files: clang/include/clang/Basic/Builtin

[PATCH] D84599: [clang-index] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. (Disclaimer: I am not at all familiar with this code) **A few notes in no particular order**: Some entities with special names should presumably be mangled, but are currently not. Example: namespace special_names { struct S { operator int(); }; int operator""_u

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes abandoned this revision. c-rhodes added a comment. I've posted a prototype D85128 with an alternative implementation, given it's quite different to this patch I've posted it as a separate patch and am abandoning this one. See new patch for more details

[PATCH] D85010: [clang][ARM] Add name-mangling test for direct __fp16 arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed0e4c70c99d: [clang][ARM] Add name-mangling test for direct __fp16 arguments. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8501

[clang] ed0e4c7 - [clang][ARM] Add name-mangling test for direct __fp16 arguments.

Author: Simon Tatham Date: 2020-08-03T13:30:50+01:00 New Revision: ed0e4c70c99d3afd87fb202ab03bda40512677e7 URL: https://github.com/llvm/llvm-project/commit/ed0e4c70c99d3afd87fb202ab03bda40512677e7 DIFF: https://github.com/llvm/llvm-project/commit/ed0e4c70c99d3afd87fb202ab03bda40512677e7.diff

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} aaron.ballman wrote: > Because this rule

[clang-tools-extra] 5191f70 - [clangd] Support new/deleta operator in TargetFinder.

Author: Haojian Wu Date: 2020-08-03T14:10:21+02:00 New Revision: 5191f70ab1f4b0b9225b2e9e11584e199172418c URL: https://github.com/llvm/llvm-project/commit/5191f70ab1f4b0b9225b2e9e11584e199172418c DIFF: https://github.com/llvm/llvm-project/commit/5191f70ab1f4b0b9225b2e9e11584e199172418c.diff LO

[PATCH] D85028: [clangd] Support new/delete operator in TargetFinder.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5191f70ab1f4: [clangd] Support new/deleta operator in TargetFinder. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85028: [clangd] Support new/delete operator in TargetFinder.

hokein updated this revision to Diff 282590. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85028/new/ https://reviews.llvm.org/D85028 Files: clang-tools-extra/cla

[PATCH] D83717: [clang-tidy] Add check fo SEI CERT item ENV32-C

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cert/ExitHandlerCheck.cpp:33 +bool isExitFunction(StringRef FnName) { + return FnName == "_Exit" || FnName == "exit" || FnName == "quick_exit"; +} Because this rule applies in C++ as w

  1   2   >