[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2020-08-04 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Awesome, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 ___ cfe-commits mailing

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:312 + const NoteTag *getNoteTag( + std::function Cb, + bool IsPrunable = false) { The callback is taken is an rvalue reference in

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D80858#2193970 , @tra wrote: > What is expected to happen to device statics in anonymous name spaces? It may > be worth adding them to the tests. > > LGTM otherwise. static device var in anonymous name space will have external

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. In D79279#2195299 , @rjmccall wrote: > Patch looks basically okay to me, although I'll second Richard's concern that > we shouldn't absent-mindedly start producing overloaded `memcpy`s for > ordinary `__builtin_memcpy`. Yeah I

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 283121. jfb marked 2 inline comments as done. jfb added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/docs/LanguageExtensions.rst

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Patch looks basically okay to me, although I'll second Richard's concern that we shouldn't absent-mindedly start producing overloaded `memcpy`s for ordinary `__builtin_memcpy`. Comment at: clang/docs/LanguageExtensions.rst:2446 +order in which they

[PATCH] D85272: [clangd] Semantic highlighting for dependent template name in template argument

2020-08-04 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D82725: [PowerPC] Implement Move to VSR Mask builtins in LLVM/Clang

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 283113. amyk added a comment. Rebased patch, and removed MC tests from the original patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82725/new/ https://reviews.llvm.org/D82725 Files:

[PATCH] D66564: [clang-tidy] new altera struct pack align check

2020-08-04 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies added a comment. @njames93 Thanks for the clarification! Your suggestion worked, but then I realized that I was working off of an improperly worded comment, which I've corrected. I looked through the AST Matcher reference, and didn't find anything that would trigger on a templated

[PATCH] D82726: [PowerPC] Implement Vector Count Mask Bits builtins in LLVM/Clang

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 283109. amyk added a comment. Rebased patch and removed MC tests from the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82726/new/ https://reviews.llvm.org/D82726 Files:

[PATCH] D67421: [analyzer] NFC: Move IssueHash to libAnalysis.

2020-08-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 283108. NoQ added a comment. Herald added a subscriber: steakhal. Get rid of the "V1" suffix. Indeed, we'll just rename the API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67421/new/ https://reviews.llvm.org/D67421 Files:

[PATCH] D66564: [clang-tidy] new altera struct pack align check

2020-08-04 Thread Frank Derry Wanye via Phabricator via cfe-commits
ffrankies updated this revision to Diff 283106. ffrankies added a comment. Clarified a comment: we don't want the warnings to trigger on templated struct //declarations//, not instantiations. We don't want it to trigger on any instantiations. Added a test case that checks if warnings are

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. Thanks. I'd like @rjmccall to approve too, but the design of these intrinsics and the Sema and constant evaluation parts seem fine. (We don't strictly need constant evaluation to abort on library UB, so I think not catching the misalignment case is OK.)

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> But I think that and this are separate changes and I'd prefer not to combine >> them. Yeah, right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: compiler-rt/test/ubsan/TestCases/Misc/builtins-ctz-clz.cpp:1 +// REQUIRES: arch=x86_64 +// Phab is confused I did a git rename of `compiler-rt/test/ubsan/TestCases/Misc/builtins.cpp` and it thinks this is new, and I

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. Thanks for the detailed comments, I think I've addressed all of them! I also added UBSan support to check the builtin invocation. I think this patch is pretty much ready to go. A follow-up will need to add the support functions to compiler-rt (they're currently optional,

[PATCH] D79279: Add overloaded versions of builtin mem* functions

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
jfb updated this revision to Diff 283078. jfb marked 6 inline comments as done. jfb added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Address Richard's comments, add UBSan support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D83273#2194869 , @echristo wrote: > That said, it's a 10% compile time regression for compiling something like > the linux kernel or anything that's very explicit what flags they set. Digging into the profile a little

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D85256#2194892 , @xbolva00 wrote: > Could this solve https://bugs.llvm.org/show_bug.cgi?id=40921 ? Not directly; `GetExprRange` in `SemaChecking` apparently intentionally treats casts as producing an arbitrary value of the

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 283072. rsmith added a comment. N/A Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 283070. rsmith added a comment. Unbreak test that was autobroken by lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256 Files:

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D71726#2182667 , @tra wrote: > LGTM, modulo couple of nits. > > @jyknight are you OK with this? > > In D71726#2179428 , @yaxunl wrote: > >> Make IEEE single and double type as supported

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 283067. yaxunl added a comment. Herald added subscribers: atanasyan, sdardis. added tests for targets supporting fp atomics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files:

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:881 + [(set v16i8:$vD, (int_ppc_altivec_vexpandbm + v16i8:$vB))]>; def VEXPANDHM : VXForm_RD5_XO5_RS5<1602, 1, (outs

[PATCH] D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 283065. amyk added a comment. Rebased the patch and removed MC tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82727/new/ https://reviews.llvm.org/D82727 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

2020-08-04 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added inline comments. Comment at: clang/test/CoverageMapping/macro-expressions.cpp:63 // CHECK-NEXT: File 0, [[@LINE+1]]:16 -> [[@LINE+1]]:18 = #2 if (EXPR(i)) {} // CHECK-NEXT: Expansion,File 0, [[@LINE+2]]:9 -> [[@LINE+2]]:14 = (#0 + #3) The gap

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

2020-08-04 Thread Albion Fung via Phabricator via cfe-commits
Conanap updated this revision to Diff 283061. Conanap marked 2 inline comments as done. Conanap added a comment. Clang formatted relevant lines, combined LE and BE tests as they produced the same ASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Could this solve https://bugs.llvm.org/show_bug.cgi?id=40921? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85256/new/ https://reviews.llvm.org/D85256 ___ cfe-commits mailing

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Sent D85257 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing list

[PATCH] D85174: BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-04 Thread Yonghong Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00602ee7ef0b: BPF: simplify IR generation for __builtin_btf_type_id() (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES

[clang] 00602ee - BPF: simplify IR generation for __builtin_btf_type_id()

2020-08-04 Thread Yonghong Song via cfe-commits
Author: Yonghong Song Date: 2020-08-04T16:29:42-07:00 New Revision: 00602ee7ef0bf6c68d690a2bd729c12b95c95c99 URL: https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99 DIFF: https://github.com/llvm/llvm-project/commit/00602ee7ef0bf6c68d690a2bd729c12b95c95c99.diff

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. In D83273#2194842 , @nickdesaulniers wrote: > In D83273#2194832 , @craig.topper > wrote: > >> It's a pretty nasty revert in our downstream tree where we have prototyped >> future ISAs.

[PATCH] D85256: Add -Wtautological-value-range-compare warning.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith created this revision. rsmith added a reviewer: rtrieu. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsmith requested review of this revision. This warning diagnoses cases where an expression is compared to a constant, and the comparison is tautological due to the

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I can optimize getImpliedDisabledFeatures & getImpliedEnabledFeatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D83273#2194832 , @craig.topper wrote: > It's a pretty nasty revert in our downstream tree where we have prototyped > future ISAs. So I'd like a little time to take a look. > > @nickdesaulniers what cpu and fetaures

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. It's a pretty nasty revert in our downstream tree where we have prototyped future ISAs. So I'd like a little time to take a look. @nickdesaulniers what cpu and fetaures are on your command lines. getImpliedDisabledFeatures should only be called if some feature is

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a subscriber: nikic. nickdesaulniers added a comment. cc @nikic http://llvm-compile-time-tracker.com/compare.php?from=094e99d264c937cad33796b8c92fe123cb544c9e=16f3d698f2afbbea43e0c3df81df6f2a640ce806=instructions gives me an error, am I holding it wrong? Repository: rG

Re: [PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Eric Christopher via cfe-commits
Ow. Can revert and reapply after we fix the caching problem perhaps? -eric On Tue, Aug 4, 2020 at 3:48 PM Nick Desaulniers via Phabricator < revi...@reviews.llvm.org> wrote: > nickdesaulniers added a comment. > > I just collected a perf profile for an entire build. >

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. I just collected a perf profile for an entire build. `getImpliedDisabledFeatures` is at the top with 9.15% of time spent in self. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

2020-08-04 Thread Ilya Golovenko via Phabricator via cfe-commits
ilya-golovenko added reviewers: kadircet, sammccall. ilya-golovenko added a comment. I'm not quite sure my fix is the best way to fix the issue, so any advices are appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85253/new/

[PATCH] D85253: [clangd] Show correct hover tooltip for non-preamble macro definition.

2020-08-04 Thread Ilya Golovenko via Phabricator via cfe-commits
ilya-golovenko created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. ilya-golovenko requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Incorrect definition is shown in tooltip when

[PATCH] D85252: [Driver] Accept -fno-lto in clang-cl

2020-08-04 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added subscribers: cfe-commits, dang, dexonsmith, inglorion. Herald added a project: clang. aeubanks requested review of this revision. Some compiler-rt tests check for the presence of the compiler accepting -fno-lto

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

2020-08-04 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added subscribers: Nathan-Huckleberry, nickdesaulniers. nickdesaulniers added a comment. Hi @craig.topper , @Nathan-Huckleberry and I are seeing `getImpliedEnabledFeatures` at the top of our profiles now. It seems that `llvm::X86::getImpliedFeatures` is repeatedly queried for

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. This file is auto generated. The real documentation should go to `clang/include/clang/Driver/Options.td` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85239/new/ https://reviews.llvm.org/D85239 ___ cfe-commits

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 283028. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D85247: [Darwin] [Driver] Clang should invoke dsymutil for multiarch builds

2020-08-04 Thread Daniel Sanders via Phabricator via cfe-commits
dsanders created this revision. dsanders added reviewers: bogner, beanz, JDevlieghere. Herald added subscribers: cfe-commits, dexonsmith, aprantl. Herald added a project: clang. dsanders requested review of this revision. Herald added a subscriber: ormris. Much like with debug info with LTO, this

Re: [PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Eric Christopher via cfe-commits
Could maybe add an assert along with the patch as well as an assert only test? On Tue, Aug 4, 2020, 1:42 PM Sterling Augustine via Phabricator < revi...@reviews.llvm.org> wrote: > saugustine added a comment. > > The darwin-dsymutil.c tests this code path right now on line 33. I found > this

[PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine added a comment. The darwin-dsymutil.c tests this code path right now on line 33. I found this error by running it under asan; otherwise it was fully latent. It seems pretty clear to me that when End == -1 (StringRef::npos), creating a string ref from that is obviously a bug. I'm

[PATCH] D85185: [SyntaxTree] Add test coverage for `->*` operator

2020-08-04 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2330 +int X::*pmi; +void test(X x, X y, X* xp) { x = y; Could you add `pmi` as a

[PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Can you add a test that exercises this code path? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85231/new/ https://reviews.llvm.org/D85231 ___ cfe-commits mailing list

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-08-04 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1865 +if (isSpecialLLVMGlobalArrayForStaticInit()) { + if (GlobalUniqueModuleId.empty()) { +GlobalUniqueModuleId = getUniqueModuleId(); jasonliu wrote: > We

[PATCH] D85074: [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

2020-08-04 Thread sunfishcode via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47f7174ffa71: [WebAssembly] Use signed char instead of char in SIMD intrinsics. (authored by sunfishcode). Changed prior to commit:

[clang] 47f7174 - [WebAssembly] Use "signed char" instead of "char" in SIMD intrinsics.

2020-08-04 Thread Dan Gohman via cfe-commits
Author: Dan Gohman Date: 2020-08-04T12:48:40-07:00 New Revision: 47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d URL: https://github.com/llvm/llvm-project/commit/47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d DIFF: https://github.com/llvm/llvm-project/commit/47f7174ffa71d339c1a65d1dd9a2ac5ff2abc95d.diff

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

2020-08-04 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Looks okay (one grammar nit), probably worth waiting for someone else to chime in. Comment at: clang/docs/ClangCommandLineReference.rst:2139 -Enable stack protectors for some functions vulnerable to stack smashing. This uses a loose heuristic

[PATCH] D84780: Setting the /bigobj option globally for Windows debug build. https://bugs.llvm.org/show_bug.cgi?id=46733

2020-08-04 Thread Lei Zhang via Phabricator via cfe-commits
antiagainst accepted this revision. antiagainst added a comment. This revision is now accepted and ready to land. LGTM for SPIR-V side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84780/new/ https://reviews.llvm.org/D84780

[PATCH] D85239: [DOCS] Add more detail to stack protector documentation

2020-08-04 Thread Peter Smith via Phabricator via cfe-commits
psmith created this revision. psmith added reviewers: jfb, Shayne, emaste, kristof.beyls, mattdr, ojhunt, probinson, reames, serge-sans-paille, dim. Herald added a subscriber: dexonsmith. psmith requested review of this revision. The Clang -fstack-protector documentation mentions what functions

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

2020-08-04 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. LGTM, and can we write a test in the test-suite? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85236/new/ https://reviews.llvm.org/D85236

[PATCH] D85118: [clang][AArch64] Correct return type of Neon vqmovun intrinsics

2020-08-04 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Probably the simplest way to verify return types would be using decltype. (`static_assert(std::is_same_v);`.) For arguments, maybe more complicated. I guess you could write a C++ class with conversion operators for every integer type, mark all of them except one "=

[PATCH] D85236: [CUDA] Work around a bug in rint() caused by a broken implementation provided by CUDA.

2020-08-04 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: sanjoy.google, bixia, yaxunl. Herald added a project: clang. tra requested review of this revision. Normally math functions are forwarded to __nv_* counterparts provided by CUDA's libdevice bitcode. However,

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Generally i think this is shaping up nicely, with the couple of minor nits addressed i'm happy to land this. Like, there are a few cornercases that we could address but we could do that in follow-up patches. Folks, do you see anything else here? Comment

[PATCH] D82675: [PowerPC] Implement Vector Extract Mask builtins in LLVM/Clang

2020-08-04 Thread Baptiste Saleil via Phabricator via cfe-commits
bsaleil accepted this revision as: bsaleil. bsaleil added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82675/new/ https://reviews.llvm.org/D82675

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = >NullDereferenceBugType; } vrnithinkumar wrote: > NoQ wrote: > > Wait, i don't

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

2020-08-04 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1997 case ABIArgInfo::Ignore: + case ABIArgInfo::IndirectAliased: return false; rjmccall wrote: > arsenm wrote: > > rjmccall wrote: > > > In principle, this can be `inreg` just

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

2020-08-04 Thread Nathan Lanza via Phabricator via cfe-commits
lanza added a comment. No problem! Thank you, John! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85231: Protect against filenames with no extension at all.

2020-08-04 Thread Sterling Augustine via Phabricator via cfe-commits
saugustine created this revision. saugustine added a reviewer: echristo. Herald added a reviewer: JDevlieghere. Herald added a project: clang. Herald added a subscriber: cfe-commits. saugustine requested review of this revision. Such as the one in the darwin-dsymutil.c test. Repository: rG

[clang] e18c6ef - [clang] improve diagnostics for misaligned and large atomics

2020-08-04 Thread JF Bastien via cfe-commits
Author: Thorsten Schuett Date: 2020-08-04T11:10:29-07:00 New Revision: e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d URL: https://github.com/llvm/llvm-project/commit/e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d DIFF:

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-04 Thread JF Bastien via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe18c6ef6b41a: [clang] improve diagnostics for misaligned and large atomics (authored by tschuett, committed by jfb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko added a comment. > This is different than testing whether a type exists or not where we want to > precisely test whether that type exists or not, so we want to preserve > `typedef` type vs. `struct t` type. `typedef t` and `struct t` are also different for field relocations (those t

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

2020-08-04 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. What is expected to happen to device statics in anonymous name spaces? It may be worth adding them to the tests. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

2020-08-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Sorry, this slipped out of my mind. I've started the process internally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75574/new/ https://reviews.llvm.org/D75574 ___

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > I guess with what you're suggesting the bitcast could still be emitted there > but the cast operations could be limited in Sema to cases where ultimately > ConvertType would return a type that requires bitcasting, or are you saying > that could be avoided

[PATCH] D84457: [OPENMP]Fix PR37671: Privatize local(private) variables in untied tasks.

2020-08-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 282958. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84457/new/ https://reviews.llvm.org/D84457 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll planned changes to this revision. simoll added a comment. Thanks for the feedback! Planned change: interpret the `N` in `vector_size(N)` as the number of bytes in the type, such that, for example, a `vector_size(2)` bool vector holds 16 bits Repository: rG LLVM Github Monorepo

[clang] 83cb98f - Fix sphinx indentation warnings by adding explicit line breaks to address space hierarchy

2020-08-04 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-04T17:48:54+01:00 New Revision: 83cb98f9e7a57360e137b32b26500fca630df617 URL: https://github.com/llvm/llvm-project/commit/83cb98f9e7a57360e137b32b26500fca630df617 DIFF: https://github.com/llvm/llvm-project/commit/83cb98f9e7a57360e137b32b26500fca630df617.diff

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, JonChesterfield, hliao. Herald added a subscriber: dang. yaxunl requested review of this revision. This is separated from https://reviews.llvm.org/D80858 For -fgpu-rdc mode, static device vars in different TU's may have the

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc

2020-08-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 282952. yaxunl retitled this revision from "[CUDA][HIP] Support accessing static device variable in host code" to "[CUDA][HIP] Support accessing static device variable in host code for -fno-gpu-rdc". yaxunl edited the summary of this revision. yaxunl added a

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Simon Moll via Phabricator via cfe-commits
simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D85218: In clang-tidy base checks prevent anonymous functions from triggering assertions

2020-08-04 Thread Bogdan Serea via Phabricator via cfe-commits
bogser01 created this revision. bogser01 added reviewers: djasper, alexfh. bogser01 added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. bogser01 requested review of this revision. Skeleton checks generated by clang-tidy add_check.py cause

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

2020-08-04 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:110 + SmartPtrChecker *Checker = Mgr.registerChecker(); + NullDereferenceBugTypePtr = >NullDereferenceBugType; } NoQ wrote: > Wait, i don't understand

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-04 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:473 +architectures. The size parameter of a boolean vector type is the number of +bits in the vector (for all non-bool vectors, the number refers to the number +of bytes in the vector).

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

2020-08-04 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 6 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1058 + /// Add an sterm finalizer to its own llvm.global_dtors entry. + void AddCXXStermFinalizerToGlobalDtor(llvm::Function *StermFinalizer, +

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

2020-08-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 282942. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. > This is not ideal, since it makes the calculations char size dependent, and breaks for sizes that are not a multiple of the char size. How can we have a non-bitfield member whose size is not a multiple of the size of a char? Repository: rG LLVM Github Monorepo

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. #clang does not have many people. You might need to add people explicitly.. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 +static const char *getAsNeededOption(const ToolChain , bool ignore) { + //

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-04 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1841 auto setDeclInfo = [&](bool IsIncompleteArrayType) { -TypeInfo TI = Context.getTypeInfo(D->getType()); -FieldAlign = Context.toCharUnitsFromBits(TI.Align); +auto TI =

[clang] 6d67506 - [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Yonghong Song via cfe-commits
Author: Yonghong Song Date: 2020-08-04T08:39:53-07:00 New Revision: 6d6750696400e7ce988d66a1a00e1d0cb32815f8 URL: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8 DIFF: https://github.com/llvm/llvm-project/commit/6d6750696400e7ce988d66a1a00e1d0cb32815f8.diff

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

2020-08-04 Thread Yonghong Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d6750696400: [clang][BPF] support type exist/size and enum exist/value relocations (authored by yonghong-song). Repository: rG LLVM Github

[clang] 5e0a9dc - Separate code-block tag with a newline to fix code snippet html output

2020-08-04 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-04T16:36:00+01:00 New Revision: 5e0a9dc0ad7704b7c49995101629010f5ff98cd2 URL: https://github.com/llvm/llvm-project/commit/5e0a9dc0ad7704b7c49995101629010f5ff98cd2 DIFF: https://github.com/llvm/llvm-project/commit/5e0a9dc0ad7704b7c49995101629010f5ff98cd2.diff

[PATCH] D84844: [OpenMP] Ensure testing for versions 4.5 and default - Part 1

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. Next two (independent) parts are: D85150 and D85214 . More to come. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84844/new/

[PATCH] D82575: [OpenMP] OpenMP Clang tests without 50 version string after upgrading to 5.0

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam abandoned this revision. saiislam added a comment. Abandoning in favor of D85214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82575/new/ https://reviews.llvm.org/D82575

[PATCH] D85214: [OpenMP] Ensure testing for versions 4.5 and default - Part 3

2020-08-04 Thread Saiyedul Islam via Phabricator via cfe-commits
saiislam added a comment. This patch updates 101 out 320 test files. Remaining will be posted as a separate patch to ease review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85214/new/ https://reviews.llvm.org/D85214

[PATCH] D85213: Use --dsym-dir when compiling with a compiler that supports it

2020-08-04 Thread Daniel Sanders via Phabricator via cfe-commits
dsanders created this revision. dsanders added reviewers: JDevlieghere, beanz, bogner. Herald added subscribers: cfe-commits, dang, mgorny. Herald added projects: clang, LLVM. dsanders requested review of this revision. As part of this, a couple tweaks to --dsym-dir have been made. It now starts

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

2020-08-04 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus accepted this revision. Szelethus added a reviewer: gamesh411. Szelethus added a comment. LGTM on my end, but please wait for approval from either @gamesh411 or @NoQ. In D77150#2191049 , @baloghadamsoftware wrote: > However, I think we should

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

2020-08-04 Thread Daniel Kiss via Phabricator via cfe-commits
danielkiss added a comment. Would it be better to add a new value to `"sign-return-address"` as `"none"`? I don't see any other alternative option, I'm open to any other idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181

[clang] 0a8ac91 - Permit nowthrow and nonnull with multiversioning.

2020-08-04 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-08-04T07:40:27-07:00 New Revision: 0a8ac91a084504929b1ef4ec1fee693455bd796d URL: https://github.com/llvm/llvm-project/commit/0a8ac91a084504929b1ef4ec1fee693455bd796d DIFF: https://github.com/llvm/llvm-project/commit/0a8ac91a084504929b1ef4ec1fee693455bd796d.diff

[clang] 961da69 - Improve diagnostics for disallowed attributes used with multiversioning

2020-08-04 Thread Erich Keane via cfe-commits
Author: Erich Keane Date: 2020-08-04T07:40:27-07:00 New Revision: 961da69d7eafe44411d5ac9719209653d196f9e2 URL: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2 DIFF: https://github.com/llvm/llvm-project/commit/961da69d7eafe44411d5ac9719209653d196f9e2.diff

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

2020-08-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4961 } +if (IS->getCond()->isValueDependent()) + return EvaluateDependentExpr(IS->getCond(), Info); The `if` stmt (the same to

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

2020-08-04 Thread Amy Kwan via Phabricator via cfe-commits
amyk added inline comments. Comment at: clang/lib/Headers/altivec.h:17217 + +/* vs[l | r | ra] */ +static __inline__ vector unsigned __int128 __ATTRS_o_ai Add a space after this comment. Comment at: clang/lib/Headers/altivec.h:17227

[PATCH] D85146: [SyntaxTree] Fix crash on pointer to member function

2020-08-04 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce15f7eeb12: [SyntaxTree] Fix crash on pointer to member function (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85146/new/

  1   2   >