[PATCH] D85596: [Docs] Link to --print-supported-cpus option

tmfink created this revision. tmfink added reviewers: nickdesaulniers, ziangwan. tmfink added a project: clang. tmfink requested review of this revision. Adds link and avoids rendering two dashes as non-ascii "en dash" in HTML output. Repository: rG LLVM Github Monorepo

[clang] a4d78d2 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Petr Hosek Date: 2020-08-08T17:08:23-07:00 New Revision: a4d78d23c53451ccefe0df0adfff9a1ac3077f10 URL: https://github.com/llvm/llvm-project/commit/a4d78d23c53451ccefe0df0adfff9a1ac3077f10 DIFF: https://github.com/llvm/llvm-project/commit/a4d78d23c53451ccefe0df0adfff9a1ac3077f10.diff

[PATCH] D85590: [clang][HeaderInsert] Do not treat defines with values as header guards

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet requested review of this revision. This was resulting in inserting headers at bogus locations, see

[clang] f4aba9d - Backout a test that is dependent on an uncommited diff. Fix another.

Author: Brad Smith Date: 2020-08-08T18:39:43-04:00 New Revision: f4aba9d76c61cc4c87b45e4edb57b1968eb7194c URL: https://github.com/llvm/llvm-project/commit/f4aba9d76c61cc4c87b45e4edb57b1968eb7194c DIFF: https://github.com/llvm/llvm-project/commit/f4aba9d76c61cc4c87b45e4edb57b1968eb7194c.diff

[clang] 430db35 - fix typo

Author: Brad Smith Date: 2020-08-08T17:58:13-04:00 New Revision: 430db35bf21505015c618e292e98793e2ed49169 URL: https://github.com/llvm/llvm-project/commit/430db35bf21505015c618e292e98793e2ed49169 DIFF: https://github.com/llvm/llvm-project/commit/430db35bf21505015c618e292e98793e2ed49169.diff

[clang] 4eb4ebf - Hook up OpenBSD 64-bit PowerPC support

Author: Brad Smith Date: 2020-08-08T17:51:19-04:00 New Revision: 4eb4ebf76a6e26b0632968dd299d1dc6ad07e694 URL: https://github.com/llvm/llvm-project/commit/4eb4ebf76a6e26b0632968dd299d1dc6ad07e694 DIFF: https://github.com/llvm/llvm-project/commit/4eb4ebf76a6e26b0632968dd299d1dc6ad07e694.diff

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added a comment. And we caught one more bug in LLVM repo (in libcxx) const char* TestCaseSetOne[] = {"", "s", "bac", "bacasf" "lkajseravea", "adsfkajdsfjkas;lnc441324513,34535r34525234",

[clang] 090f9d5 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2020-08-08T19:12:11+01:00 New Revision: 090f9d5a55338ee815f5a6ef7aaa1ed712f65e05 URL: https://github.com/llvm/llvm-project/commit/090f9d5a55338ee815f5a6ef7aaa1ed712f65e05 DIFF: https://github.com/llvm/llvm-project/commit/090f9d5a55338ee815f5a6ef7aaa1ed712f65e05.diff

[clang] cd5ab56 - Change the default target CPU for OpenBSD/i386 to i586

Author: Brad Smith Date: 2020-08-08T13:49:45-04:00 New Revision: cd5ab56bc406c3f9a6f593f98c63dafb53547ab1 URL: https://github.com/llvm/llvm-project/commit/cd5ab56bc406c3f9a6f593f98c63dafb53547ab1 DIFF: https://github.com/llvm/llvm-project/commit/cd5ab56bc406c3f9a6f593f98c63dafb53547ab1.diff

[clang] 6cd2355 - [Clang] Fixed buildboit failure; bot defaults to older C++ standard

Author: Dávid Bolvanský Date: 2020-08-08T19:37:50+02:00 New Revision: 6cd23558d3a9fbe8bc73e96d4df4e52c8261d1b5 URL: https://github.com/llvm/llvm-project/commit/6cd23558d3a9fbe8bc73e96d4df4e52c8261d1b5 DIFF:

[clang] 0fef780 - [Clang] Avoid whitespace in fixit note

Author: Dávid Bolvanský Date: 2020-08-08T19:34:07+02:00 New Revision: 0fef780aa70b48551ae6df373955b5e4f5130fa4 URL: https://github.com/llvm/llvm-project/commit/0fef780aa70b48551ae6df373955b5e4f5130fa4 DIFF:

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:79 + +// TODO: Enabale this test when "std::swap" is modeled seperately. +void derefOnStdSwappedNullPtr() { vrnithinkumar wrote: > NoQ wrote: > > Instead of commenting

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added a comment. In D84600#2203604 , @Szelethus wrote: > Layering violations are a running theme in the analyzer -- CheckerRegistry > and the entire MallocChecker fiasco > are two glaring

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc096a66cb51: [Diagnostics] Diagnose missing comma in string array initialization (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dc096a6 - [Diagnostics] Diagnose missing comma in string array initialization

Author: Dávid Bolvanský Date: 2020-08-08T19:24:30+02:00 New Revision: dc096a66cb519532121fb0fbedb13265bd4b29ec URL: https://github.com/llvm/llvm-project/commit/dc096a66cb519532121fb0fbedb13265bd4b29ec DIFF:

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 added a comment. Thank you all for code review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 updated this revision to Diff 284136. xbolva00 added a comment. Fixed nit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaExpr.cpp

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrChecker.cpp:33 +// Static global pointer to NullDereferenceBugType. +static const BugType *NullDereferenceBugTypePtr; xazax.hun wrote: > I find this comment redundant as

[PATCH] D84600: [Analyzer] Support note tags for smart ptr checker

vrnithinkumar updated this revision to Diff 284137. vrnithinkumar marked 4 inline comments as done. vrnithinkumar added a comment. - Review comment changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84600/new/ https://reviews.llvm.org/D84600

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

Quuxplusone added a comment. LGTM; nothing further from me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 284106. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in lld/test/CMakeLists.txt

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

lxfind added a comment. In D79219#2201415 , @phosek wrote: > In D79219#2201109 , @lxfind wrote: > >> @phosek, Under this change, now when I build LLVM (with a basic config >> `cmake -G Ninja

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

riccibruno added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:1 -// RUN: %check_clang_tidy -std=c++14,c++17 %s modernize-use-trailing-return-type %t -- -- -fdeclspec -fexceptions +// RUN: %check_clang_tidy

[PATCH] D84068: AMDGPU/clang: Search resource directory for device libraries

arsenm added a comment. In D84068#2159391 , @tra wrote: > Could you walk me through how you see this working in practice? > > IIUIC, the idea is to have bitcode files located somewhere within clang > installation. Yes > If that's the case, will we ship

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

riccibruno added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:1 -// RUN: %check_clang_tidy -std=c++14,c++17 %s modernize-use-trailing-return-type %t -- -- -fdeclspec -fexceptions +// RUN: %check_clang_tidy

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit, but you should give other reviewers a chance to comment if they have additional feedback. Comment at: clang/lib/Sema/SemaExpr.cpp:6911

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 updated this revision to Diff 284128. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaExpr.cpp clang/test/Sema/string-concat.c Index:

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

xbolva00 updated this revision to Diff 284127. xbolva00 added a comment. Addressed review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85545/new/ https://reviews.llvm.org/D85545 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaExpr.cpp

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:430 + AT->getKeyword() == AutoTypeKeyword::Auto && + !hasAnyNestedLocalQualifiers(F->getDeclaredReturnType())) +return;

[PATCH] D85193: [clang] Do not use an invalid expression to update the initializer.

aaron.ballman added a comment. Should the `StructuredIndex` still be incremented even in the case of an error, as done around line 1589 and 1647? Do we need a similar change around line 2405? I sort of wonder if the correct change is to make `UpdateStructuredListElement()` resilient to being

[PATCH] D85536: [clang] Add a matcher for template template parameters.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85536/new/ https://reviews.llvm.org/D85536

[PATCH] D85545: [Diagnostics] Diagnose missing comma in string array initialization

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3003 +def warn_concatenated_literal_array_init : Warning< + "concatenated literal in a string array initialization - " + "possibly missing a comma">, How about:

[PATCH] D85575: [ARM] Speed up arm-cortex-cpus.c test

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Yeah, nice. Sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85575/new/ https://reviews.llvm.org/D85575

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal added a comment. In D85528#2203325 , @NoQ wrote: > Aha, ok, sounds like the right thing to do. Like, for Z3 it's actually the > wrong thing to do (you'd prefer to evaluate the cast perfectly by adding > `SymbolCast`) but for pure

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 284126. steakhal marked 3 inline comments as done. steakhal edited the summary of this revision. steakhal added a comment. - Using `dump`s instead of `reaching` in tests. - Not requiring complete enums anymore //(unlike we did before the patch)//.

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

phosek added a comment. Would it be possible to add a test case in `clang/test/Driver/linux-ld.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85582/new/ https://reviews.llvm.org/D85582 ___

[PATCH] D85582: [clang][Driver] Search lib32 on Linux/sparc64 with -m32

ro created this revision. ro added reviewers: echristo, MaskRay, phosek. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. ro requested review of this revision. When building current master on `sparc64-unknown-linux-gnu` (Debian 5.7.10), all 32-bit tests failed to