[PATCH] D85692: python bindings: fix DeprecationWarning

2020-08-19 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Does this mean we officially no longer support python 2, which this change breaks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85692/new/ https://reviews.llvm.org/D85692 ___

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-19 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you preparing this i1 patch and doing it on clang side only. We were testing this patch and sending problem reports. Now, we can use this patch without modifying llvm code. We can define vector mask types like below. Then, we can define intrinsic functions using

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

2020-08-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org/D83298

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

2020-08-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys

2020-08-19 Thread Robert Widmann via Phabricator via cfe-commits
CodaFi updated this revision to Diff 286697. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85981/new/ https://reviews.llvm.org/D85981 Files: clang/include/clang/Serialization/ModuleManager.h clang/lib/Serialization/ModuleManager.cpp Index:

[PATCH] D82860: Port ObjCMTAction to new option parsing system

2020-08-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

2020-08-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 286688. zequanwu added a comment. minor fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/ https://reviews.llvm.org/D84988 Files: clang/include/clang/Lex/Lexer.h

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

2020-08-19 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This looks OK to me. I think we'll also need updates for `_ExtInt` now too -- we have more fundamental types with padding than only `long double` and `bool` now. (I continue to be displeased that we assume 8-bit `char` in

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG724f570ad255: [X86] Add support tune in target attribute (authored by craig.topper). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 724f570 - [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-08-19T15:58:19-07:00 New Revision: 724f570ad25568acc3a33dcdce9cadd776de2382 URL: https://github.com/llvm/llvm-project/commit/724f570ad25568acc3a33dcdce9cadd776de2382 DIFF: https://github.com/llvm/llvm-project/commit/724f570ad25568acc3a33dcdce9cadd776de2382.diff

[clang] 4a36711 - [X86] Add mtune command line test cases that should have gone with 4cbceb74bb5676d0181d4d0cab5194d90a42c2ec

2020-08-19 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-08-19T15:58:06-07:00 New Revision: 4a367114397ab5d175cb8b74ee6144978e7fdeba URL: https://github.com/llvm/llvm-project/commit/4a367114397ab5d175cb8b74ee6144978e7fdeba DIFF: https://github.com/llvm/llvm-project/commit/4a367114397ab5d175cb8b74ee6144978e7fdeba.diff

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-19 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D86223#2226876 , @xazax.hun wrote: > Exactly, but you could return a StringRef to static storage. > > I am fine with both approach. Whichever you find cleaner. Eh, I'm not sure if it worth it to put these into virtual

[clang] c1c1bed - [c++14] Implement missed piece of N3323: use "converted constant" rules

2020-08-19 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-19T15:45:51-07:00 New Revision: c1c1bed5d0828f1905f1e9a09a32c02f05de9b41 URL: https://github.com/llvm/llvm-project/commit/c1c1bed5d0828f1905f1e9a09a32c02f05de9b41 DIFF: https://github.com/llvm/llvm-project/commit/c1c1bed5d0828f1905f1e9a09a32c02f05de9b41.diff

[PATCH] D85981: [clang][Modules] Increase the Entropy of ModuleManager Map Keys

2020-08-19 Thread Robert Widmann via Phabricator via cfe-commits
CodaFi updated this revision to Diff 286679. CodaFi retitled this revision from "[clang][Modules] Use File Names Instead of inodes As Loaded Module Keys" to "[clang][Modules] Increase the Entropy of ModuleManager Map Keys". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

2020-08-19 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar marked 2 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:362-363 + const auto *InnerPointVal = State->get(ThisRegion); + if (!InnerPointVal) +return; + xazax.hun

[PATCH] D86029: [analyzer] Add modeling for unque_ptr::get()

2020-08-19 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 286675. vrnithinkumar edited the summary of this revision. vrnithinkumar added a comment. - Using conjureSymbolVal in case of missing inner pointer value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83088: Introduce CfgTraits abstraction

2020-08-19 Thread Jakub Kuderski via Phabricator via cfe-commits
kuhar added a comment. Hi Nicoali, In D83088#2227151 , @nhaehnle wrote: > ... > Take a look here for example: > https://github.com/nhaehnle/llvm-project/blob/715450fa7f968ceefaf9c3b04b47066866c97206/llvm/lib/Analysis/GenericConvergenceUtils.cpp#L499 >

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

2020-08-19 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added a comment. In D86193#2227129 , @davidxl wrote: > A heads up -- I won't be able to review patch until mid Sept. Hope this is > fine. Thanks for the heads-up. That's fine. We can wait for your input. Repository: rG LLVM Github Monorepo

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

2020-08-19 Thread Hongtao Yu via Phabricator via cfe-commits
hoy updated this revision to Diff 286664. hoy edited the summary of this revision. hoy added a comment. Updating D86193 : [CSSPGO] Pseudo probe instrumentation for basic blocks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 286661. craig.topper added a comment. Refine the diagnostic message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 Files: clang/include/clang/AST/Attr.h clang/include/clang/Basic/Attr.td

[PATCH] D83088: Introduce CfgTraits abstraction

2020-08-19 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. In D83088#2225415 , @dblaikie wrote: >>> But I guess coming back to the original/broader design: What problems is >>> this intended to solve? The inability to write non-template algorithms over >>> graphs? What cost does that

[PATCH] D86193: [CSSPGO] Pseudo probe instrumentation for basic blocks.

2020-08-19 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. A heads up -- I won't be able to review patch until mid Sept. Hope this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86193/new/ https://reviews.llvm.org/D86193 ___

[PATCH] D85762: [OPENMP]Do not allow threadprivates as base for array-like reduction.

2020-08-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 286658. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85762/new/ https://reviews.llvm.org/D85762 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-19 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1847 +IsIncompleteArrayType ? CharUnits::Zero() : TI.first; +AlignIsRequired =

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/Sema/attr-target.c:26 +//expected-warning@+1 {{unsupported tune 'hiss' in the 'target' attribute string; 'target' attribute ignored}} +int __attribute__((target("tune=hiss,tune=woof"))) apple_tree() { return 4; } +

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

2020-08-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev updated this revision to Diff 286651. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attr.h:346 + Tune == Other.Tune && + BranchProtection == Other.BranchProtection && + Features == Other.Features; craig.topper wrote: > Was it a bug that

[clang] 7cffaf5 - [X89] Ignore -mtune=generic to fix failures some users are seeing after D85384

2020-08-19 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-08-19T13:17:57-07:00 New Revision: 7cffaf510f97eabef89b0d45aeb939df40e8e9d3 URL: https://github.com/llvm/llvm-project/commit/7cffaf510f97eabef89b0d45aeb939df40e8e9d3 DIFF: https://github.com/llvm/llvm-project/commit/7cffaf510f97eabef89b0d45aeb939df40e8e9d3.diff

[PATCH] D86164: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

2020-08-19 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb4acd37fe60: [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fb4acd3 - [OPENMP]Fix PR47158, case 2: do not report host-only functions in unused function in device mode.

2020-08-19 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-08-19T16:14:33-04:00 New Revision: fb4acd37fe60a08a0077560d2814053d76ea1c41 URL: https://github.com/llvm/llvm-project/commit/fb4acd37fe60a08a0077560d2814053d76ea1c41 DIFF: https://github.com/llvm/llvm-project/commit/fb4acd37fe60a08a0077560d2814053d76ea1c41.diff

[PATCH] D86239: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.

2020-08-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added reviewers: jdoerfert, cchen. Herald added subscribers: guansong, yaxunl. Herald added a reviewer: aaron.ballman. Herald added a project: clang. ABataev requested review of this revision. Herald added a subscriber: sstefan1. OpenMP 5.0 supports nested

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/test/Sema/attr-target.c:26 +//expected-warning@+1 {{unsupported tune 'hiss' in the 'target' attribute string; 'target' attribute ignored}} +int __attribute__((target("tune=hiss,tune=woof"))) apple_tree() { return 4; } +

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286634. RKSimon edited the summary of this revision. RKSimon added a comment. Added -x c++ RUN lines to the existing popcnt-builtins.c file - thanks @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

2020-08-19 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:130 +// Returns empty type if not found valid inner pointer type. +static QualType getInnerPointerType(const CallEvent , CheckerContext ) { + QualType InnerType{};

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

2020-08-19 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 286632. vrnithinkumar marked 5 inline comments as done. vrnithinkumar added a comment. Changes to use conjureSymbolVal if the inner pointer value is missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86027: [analyzer] Add bool operator modeling for unque_ptr

2020-08-19 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:147 -if (!move::isMovedFrom(State, ThisR)) { - // TODO: Model this case as well. At least, avoid invalidation of - // globals. - return false; +if

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-19 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. Exactly, but you could return a StringRef to static storage. I am fine with both approach. Whichever you find cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86223/new/ https://reviews.llvm.org/D86223

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

2020-08-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D85384#2226866 , @craig.topper wrote: > In D85384#2226842 , @aeubanks wrote: > >> This doesn't work with -mtune=generic >> (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D85384#2226842 , @aeubanks wrote: > This doesn't work with -mtune=generic > (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility > be added? > > (https://crbug.com/1119448) > > $ cat /tmp/a.c >

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + RKSimon wrote: > arsenm wrote: > > RKSimon wrote: > > >

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + arsenm wrote: > RKSimon wrote: > > craig.topper wrote: > > >

[PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

2020-08-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. This doesn't work with -mtune=generic (https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html), can gcc compatibility be added? (https://crbug.com/1119448) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85384/new/

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-19 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D86223#2226630 , @xazax.hun wrote: > I wonder whether having a virtual method for symbols to get the prefix would > be cleaner (something like getKindCStr), but I do not insist. Are you implying to have something like:

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

2020-08-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:483 bool GapRegion = CR.value().Kind == CounterMappingRegion::GapRegion; if (CR.index() + 1 == Regions.size() || vsk wrote: > zequanwu wrote: > > vsk

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/AST/Attr.h:346 + Tune == Other.Tune && + BranchProtection == Other.BranchProtection && + Features == Other.Features; Was it a bug that BranchProtection wasn't in

[PATCH] D84988: [Coverage] Add empty line regions to SkippedRegions

2020-08-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 286622. zequanwu added a comment. Add a wrapped segment at location of zero-length segment with last pushed region count. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84988/new/

[PATCH] D66854: [index-while-building] PathIndexer

2020-08-19 Thread Jan Korous via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4da126c3748f: [index-while-building] PathIndexer (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 4da126c - [index-while-building] PathIndexer

2020-08-19 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-08-19T11:25:21-07:00 New Revision: 4da126c3748f3b6c6251e45614b12d3aa118d047 URL: https://github.com/llvm/llvm-project/commit/4da126c3748f3b6c6251e45614b12d3aa118d047 DIFF: https://github.com/llvm/llvm-project/commit/4da126c3748f3b6c6251e45614b12d3aa118d047.diff

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + RKSimon wrote: > craig.topper wrote: > > RKSimon wrote: > > >

[PATCH] D86146: [ARM][BFloat16] Change types of some Arm and AArch64 bf16 intrinsics

2020-08-19 Thread Dave Green via Phabricator via cfe-commits
dmgreen added a comment. Do we need to upgrade the old bfmmla to the new signatures? Comment at: llvm/test/CodeGen/ARM/arm-bf16-dotprod-intrinsics.ll:176 - -define <4 x float> @test_vbfmlaltq_laneq_f32_v2(<4 x float> %r, <8 x bfloat> %a, <8 x bfloat> %b) { -; CHECK-LABEL:

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. In D86187#2226621 , @craig.topper wrote: > Add a note to AttrDocs.td Thanks for the docs update, continues to LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/

[PATCH] D86221: [compiler-rt][builtins] Do not assume int to be at least 32 bit wide

2020-08-19 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a subscriber: scanon. atrosinenko added a comment. On one hand, this `clzdi()` implementation should be completely harmless when fallback is implemented via `clzsi()`. On the other hand, it may possibly be completely removed. This code snippet mimics one already existing for

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + craig.topper wrote: > RKSimon wrote: > > arsenm wrote: > > >

[clang] a407ec9 - Revert "Revert "[NFC][llvm] Make the contructors of `ElementCount` private.""

2020-08-19 Thread Mehdi Amini via cfe-commits
Author: Mehdi Amini Date: 2020-08-19T17:26:36Z New Revision: a407ec9b6db1e29e9aa361819f499ad11038d2dd URL: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd DIFF: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd.diff LOG:

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-19 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! I wonder whether having a virtual method for symbols to get the prefix would be cleaner (something like getKindCStr), but I do not insist. Repository: rG LLVM Github Monorepo

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286605. RKSimon added a comment. Require x86-registered-target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/lib/Headers/popcntintrin.h

[clang] 4fc56d7 - Revert "[NFC][llvm] Make the contructors of `ElementCount` private."

2020-08-19 Thread Mehdi Amini via cfe-commits
Author: Mehdi Amini Date: 2020-08-19T17:21:37Z New Revision: 4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 URL: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 DIFF: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6.diff LOG:

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 286602. craig.topper added a comment. Add a note to AttrDocs.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187 Files: clang/include/clang/AST/Attr.h clang/include/clang/Basic/Attr.td

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + arsenm wrote: > Missing required register target? sure, oddly we

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + arsenm wrote: > Missing required register target? Do we need

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286601. RKSimon added a comment. add c++11 limiter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/lib/Headers/popcntintrin.h

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: clang/test/CodeGen/popcnt-builtins.cpp:3 +// RUN: %clang_cc1 -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s + + Missing required register target? Repository: rG LLVM Github

[PATCH] D83296: [clang-format] Add a MacroExpander.

2020-08-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:186 +Tok->MacroCtx = MacroContext(MR_ExpandedArg); + pushToken(Tok); +} klimek wrote: > sammccall wrote: > > you're pushing here without copying. This means the

[clang] bcaa806 - [Clang] Fix BZ47169, loader_uninitialized on incomplete types

2020-08-19 Thread Jon Chesterfield via cfe-commits
Author: Jon Chesterfield Date: 2020-08-19T18:11:50+01:00 New Revision: bcaa806a4747595116b538e8b75b12966e6607f6 URL: https://github.com/llvm/llvm-project/commit/bcaa806a4747595116b538e8b75b12966e6607f6 DIFF:

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

2020-08-19 Thread Jon Chesterfield via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcaa806a4747: [Clang] Fix BZ47169, loader_uninitialized on incomplete types (authored by JonChesterfield). Repository: rG LLVM Github Monorepo

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Comment at: clang/lib/Headers/popcntintrin.h:16 +#ifdef __cplusplus +#define __DEFAULT_FN_ATTRS_CONSTEXPR __DEFAULT_FN_ATTRS constexpr craig.topper wrote: > Do we need to check for C++11? I don't actually know - its trivial to

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

2020-08-19 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Works out cleanly, thanks for the suggestion. Comment at: clang/lib/Sema/SemaDecl.cpp:12478 if (!Var->isInvalidDecl() && RealDecl->hasAttr()) { + if (Var->getStorageClass() == SC_Extern) { Same as first diff except

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

2020-08-19 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield updated this revision to Diff 286598. JonChesterfield added a comment. - Use more specific diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85990/new/ https://reviews.llvm.org/D85990 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Headers/popcntintrin.h:16 +#ifdef __cplusplus +#define __DEFAULT_FN_ATTRS_CONSTEXPR __DEFAULT_FN_ATTRS constexpr Do we need to check for C++11? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-19 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:333 +/// expression . template_opt id-expression +/// id-expression +/// e.g. `x.a`, `xp->a` or even just `a` when we have an implicit `this->`.

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-19 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, echristo, spatel, erichkeane, andreadb. Herald added a project: clang. RKSimon requested review of this revision. This is a RFC first step patch to enable constexpr support and testing to a large number of x86 intrinsics. All

[PATCH] D86132: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

2020-08-19 Thread Caroline via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33c554d8444a: [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive (authored by CarolineConcatto). Repository: rG LLVM

[clang] 33c554d - [clang][driver]Add quotation mark in test/fortran.f95 to avoid false positive

2020-08-19 Thread Caroline Concatto via cfe-commits
Author: Caroline Concatto Date: 2020-08-19T17:54:32+01:00 New Revision: 33c554d8444a5ce1fb85def04de8c0ebfec643b9 URL: https://github.com/llvm/llvm-project/commit/33c554d8444a5ce1fb85def04de8c0ebfec643b9 DIFF:

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-19 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 286593. eduucaldas added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

2020-08-19 Thread Nathan Lanza via Phabricator via cfe-commits
lanza added a comment. > This change provides a codegen options flag to clang > -fobjc-export-direct-method-wrappers to generate the wrapper functions that > begin with the prefix objc_direct_wrapper and are marked as > attribute__((alwaysinline)). This way within a link unit the wrapper >

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-19 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86227 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[clang] 6b742cc - [clang] Replace call to private ctor with ElementCount::getScalable (2/2)

2020-08-19 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-08-19T09:40:46-07:00 New Revision: 6b742cc48d91f35bfa98844d5add3655f33f8326 URL: https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326 DIFF:

[clang] fc53bd6 - [clang] Replace call to private ctor with ElementCount::getScalable

2020-08-19 Thread Jonas Devlieghere via cfe-commits
Author: Jonas Devlieghere Date: 2020-08-19T09:35:08-07:00 New Revision: fc53bd610ff95d2824617095bcf4976035b4cb9a URL: https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a DIFF:

[PATCH] D83296: [clang-format] Add a MacroExpander.

2020-08-19 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:186 +Tok->MacroCtx = MacroContext(MR_ExpandedArg); + pushToken(Tok); +} sammccall wrote: > you're pushing here without copying. This means the original tokens from the

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-19 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, vsavchenko, xazax.hun, mikhail.ramalho, ddcc. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-19 Thread Arnold Schwaighofer via Phabricator via cfe-commits
aschwaighofer updated this revision to Diff 286575. aschwaighofer added a comment. Try to sooth clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp

[PATCH] D86221: [compiler-rt][builtins] Do not assume int to be at least 32 bit wide

2020-08-19 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: efriedma, MaskRay, aykevl, uabelho. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. This patch drops implicit assumptions on int/unsigned types being

[PATCH] D83296: [clang-format] Add a MacroExpander.

2020-08-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Somehow I missed the email from your replies. Mostly nits that you can take or leave, but I think potential bugs around functionlike-vs-objectlike and multiple-expansion of args. Comment at: clang/lib/Format/FormatToken.h:177 +/// EndOfExpansion:

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-19 Thread Arnold Schwaighofer via Phabricator via cfe-commits
aschwaighofer created this revision. aschwaighofer added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. aschwaighofer requested review of this revision. rdar://67351073 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86218

[PATCH] D86217: rename sram-ecc as sramecc in clang

2020-08-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: kzhuravl, arsenm. Herald added subscribers: llvm-commits, dang, kerbowa, hiraditya, nhaehnle, jvesely. Herald added a project: LLVM. yaxunl requested review of this revision. Herald added a subscriber: wdng. As backend will rename sram-ecc to

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

2020-08-19 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 286561. adamcz added a comment. Added comment in place of a FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86069/new/ https://reviews.llvm.org/D86069 Files:

[clang] b98e25b - Make helpers static. NFC.

2020-08-19 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-08-19T16:00:03+02:00 New Revision: b98e25b6d7231798a4d819aae3a93f6f1627931a URL: https://github.com/llvm/llvm-project/commit/b98e25b6d7231798a4d819aae3a93f6f1627931a DIFF:

[PATCH] D84886: Create LoopNestPass

2020-08-19 Thread Whitney Tsang via Phabricator via cfe-commits
Whitney added a comment. > I was trying to convert the LoopInterchange pass into a loop-nest pass. > However, there seems to be no corresponding loop pass for the NPM. > Any particular reason for this? That's true, LoopInterchange pass is not already ported to the NPM, likely because no one

[clang-tools-extra] 1014a93 - Fix unused variable warnings. NFCI.

2020-08-19 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-19T14:34:32+01:00 New Revision: 1014a93a4e0203eccc20190c31169b26ec4b9058 URL: https://github.com/llvm/llvm-project/commit/1014a93a4e0203eccc20190c31169b26ec4b9058 DIFF: https://github.com/llvm/llvm-project/commit/1014a93a4e0203eccc20190c31169b26ec4b9058.diff

[clang] 916b750 - [CodeGen] Use existing EmitLambdaVLACapture (NFC)

2020-08-19 Thread Aaron Puchert via cfe-commits
Author: Aaron Puchert Date: 2020-08-19T15:20:05+02:00 New Revision: 916b750a8d1ab47d41939b42bf1d6eeddbdef686 URL: https://github.com/llvm/llvm-project/commit/916b750a8d1ab47d41939b42bf1d6eeddbdef686 DIFF: https://github.com/llvm/llvm-project/commit/916b750a8d1ab47d41939b42bf1d6eeddbdef686.diff

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, but perhaps there should be some changes in AttrDocs.td to document the new support? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/ https://reviews.llvm.org/D86187

[PATCH] D86209: [clang-tidy] run-clang-tidy.py: Fix -allow-enabling-analyzer-alpha-checkers always being passed

2020-08-19 Thread Joachim Priesner via Phabricator via cfe-commits
jspam created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, xazax.hun. Herald added a project: clang. jspam requested review of this revision. The `action='store_true'` option of

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-19 Thread Harmen Stoppels via Phabricator via cfe-commits
haampie added inline comments. Comment at: llvm/lib/Support/CMakeLists.txt:217 + endif() + if(CMAKE_SHARED_LIBRARY_PREFIX AND CMAKE_SHARED_LIBRARY_SUFFIX AND + zlib_library MATCHES "^${CMAKE_SHARED_LIBRARY_PREFIX}.*${CMAKE_SHARED_LIBRARY_SUFFIX}$") This

Re: [PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

2020-08-19 Thread Eric Christopher via cfe-commits
This would be because at that point the default cpu was that and it probably had something to do with fallbacks. At this point it can be changed I imagine to whatever makes sense. On Wed, Aug 19, 2020, 1:12 AM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper added

[PATCH] D86187: [X86] Add support 'tune' in target attribute

2020-08-19 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. CFE changes look right to me. Please give the rest of the reviews a little while to take a look though CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86187/new/

[PATCH] D84603: Thread safety analysis: More consistent warning message

2020-08-19 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84603/new/ https://reviews.llvm.org/D84603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86207: (De-)serialize BindingDecls before DecompositionDecl

2020-08-19 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert requested review of this revision. When parsing a C++17 binding declaration, we first create the BindingDecls in

[PATCH] D85485: Fix quiet mode in git-clang-format

2020-08-19 Thread Gvald Ike via Phabricator via cfe-commits
Gvald marked an inline comment as done. Gvald added a comment. Tried to `arc land` but don't have the permissions. From LLVM docs : > It is sufficient to add a comment to the approved review indicating you > cannot commit the patch

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

2020-08-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, I was just not reading the test clearly. LGTM Comment at: clang/lib/Serialization/ASTReader.cpp:4990 PP.makeModuleVisible(Imported, Import.ImportLoc);

  1   2   >