[PATCH] D85031: [builtins] Unify the softfloat division implementation

2020-08-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:99 + // 0 < x0(b) < 1 + // abs(x0(b) - 1/b) <= 3/4 - 1/sqrt(2) + atrosinenko wrote: > sepavloff wrote: > > This estimation is absent from the original comment. Do you

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMacro("__BOOL__"); MaskRay wrote: > What is

[PATCH] D86329: Fix spelling errors in the doc

2020-08-20 Thread YangZhihui via Phabricator via cfe-commits
YangZhihui created this revision. YangZhihui added reviewers: rsmith, craig.topper. Herald added a project: clang. Herald added a subscriber: cfe-commits. YangZhihui requested review of this revision. Fix some spelling error in the doc Repository: rG LLVM Github Monorepo

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

2020-08-20 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Heh, nice! Did you try to measure the actual impact of this change on memory and/or performance? I think it'd make perfect sense to keep the offset in a side map. We don't compute it for all regions, and for most regions it doesn't need to be computed *at all*.

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Please do this as a very late check rather than the first check. You need to check for extra atomic padding. If there's any difference between the sizes of the atomic type and its element, just add it as opaque data. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

2020-08-20 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea requested changes to this revision. asbirlea added a comment. This revision now requires changes to proceed. A couple of quick comments, I haven't gone into details yet. - please split off the changes that are NFCs (deleted spaces) and clang-format for ease to review. - the test

[clang] fe86dbb - [clang]: Remove assertion which checks explicit declaration

2020-08-20 Thread Richard Smith via cfe-commits
Author: Gousemoodhin Nadaf Date: 2020-08-20T18:15:43-07:00 New Revision: fe86dbb32da21e1c8c6eb4864a00f61ed3d003a3 URL: https://github.com/llvm/llvm-project/commit/fe86dbb32da21e1c8c6eb4864a00f61ed3d003a3 DIFF:

[PATCH] D83929: [clang]: Remove assertion which checks explicit declaration

2020-08-20 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe86dbb32da2: [clang]: Remove assertion which checks explicit declaration (authored by gousemoodhin, committed by rsmith). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

2020-08-20 Thread Volodymyr Sapsai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7ac737e56bee: [HeaderSearch] Fix processing #import-ed headers multiple times with modules… (authored by vsapsai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7ac737e - [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

2020-08-20 Thread Volodymyr Sapsai via cfe-commits
Author: Volodymyr Sapsai Date: 2020-08-20T17:41:28-07:00 New Revision: 7ac737e56bee721fb3535006140362c6e08726bb URL: https://github.com/llvm/llvm-project/commit/7ac737e56bee721fb3535006140362c6e08726bb DIFF:

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

2020-08-20 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 7092398 - Improve pretty-printing for APValues of void type.

2020-08-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-20T17:14:22-07:00 New Revision: 70923983e54253723600eb2f4cdfb0fbb347a364 URL: https://github.com/llvm/llvm-project/commit/70923983e54253723600eb2f4cdfb0fbb347a364 DIFF: https://github.com/llvm/llvm-project/commit/70923983e54253723600eb2f4cdfb0fbb347a364.diff

[clang-tools-extra] efeb65d - Fix up clangd after Clang 038edf6029bafe70b1f7165abe2b0e61ddf506b3.

2020-08-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-20T16:36:25-07:00 New Revision: efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9 URL: https://github.com/llvm/llvm-project/commit/efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9 DIFF: https://github.com/llvm/llvm-project/commit/efeb65d53b88d9c3ac3a185c396efd8db8c9f7d9.diff

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

2020-08-20 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Overall that would likely work for XLA. Something I'd like to mention though in response to: > The veclib type is also tied to the accepted values for -fveclib, which is a > list of supported lib, `-fveclib` is a Clang thing, it shouldn't limit what LLVM does. Of

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

2020-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/int_mulv_impl.inc:1 -//===-- mulvdi3.c - Implement __mulvdi3 ---===// +//===-- int_mulv_impl.inc - Implement __mulv[sdt]i3 ---===// //

[PATCH] D85990: [Clang] Fix BZ47169, loader_uninitialized on incomplete types

2020-08-20 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/test/CodeGenCXX/attr-loader-uninitialized.cpp:34 + +// CHECK: @templ_int = global %struct.templ undef, align 8 +templ templ_int [[clang::loader_uninitialized]]; This broke 32 bit builds where the pointer

[clang] 3d82c9b - Fix 32 bit build broken by D85990 by dropping align from filecheck pattern

2020-08-20 Thread via cfe-commits
Author: JonChesterfield Date: 2020-08-20T23:50:33+01:00 New Revision: 3d82c9b6960afe50a76b8c23e9bc42c51d41e767 URL: https://github.com/llvm/llvm-project/commit/3d82c9b6960afe50a76b8c23e9bc42c51d41e767 DIFF:

[clang] 038edf6 - Don't reject uses of void-returning consteval functions.

2020-08-20 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-08-20T15:40:09-07:00 New Revision: 038edf6029bafe70b1f7165abe2b0e61ddf506b3 URL: https://github.com/llvm/llvm-project/commit/038edf6029bafe70b1f7165abe2b0e61ddf506b3 DIFF: https://github.com/llvm/llvm-project/commit/038edf6029bafe70b1f7165abe2b0e61ddf506b3.diff

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

2020-08-20 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. @lanza I did it as a CodeGen option for now because we don't want anything like this to be the default until the ABI is fleshed out. I think one danger in altering the name of the function to some extent is you dont want to clash potentially with user defined C

[PATCH] D78902: [Driver] Add output file to properties of Command

2020-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. What's the advantage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

2020-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. It would be nice to have this fix in clang11. Do you think it's qualified for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85528/new/ https://reviews.llvm.org/D85528 ___

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

2020-08-20 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. In D86154#2224272 , @arsenm wrote: > In D86154#2224270 , @nhaehnle wrote: > >> Note that part of my motivation here over D84639 >> is to support more

[PATCH] D86154: AMDGPU: Add llvm.amdgcn.{read,readfirst,write}lane2 intrinsics with type overloads

2020-08-20 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle updated this revision to Diff 286898. nhaehnle added a comment. Don't duplicate the intrinsics. Rely on D86317 to reduce the pain of this change caused to downstream users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cff0db0 - [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-08-20T21:38:04+01:00 New Revision: cff0db08761f310dfebb5b41b307d2c12bda85fc URL: https://github.com/llvm/llvm-project/commit/cff0db08761f310dfebb5b41b307d2c12bda85fc DIFF: https://github.com/llvm/llvm-project/commit/cff0db08761f310dfebb5b41b307d2c12bda85fc.diff

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcff0db08761f: [X86] Enable constexpr on POPCNT intrinsics (PR31446) (authored by RKSimon). Changed prior to commit:

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

2020-08-20 Thread sameeran joshi via Phabricator via cfe-commits
sameeranjoshi added a comment. Thanks for the work. A couple of comments on `clang/` related changes: An `out-of-tree` build with this patch fails for me: Here's what I did: I initially used `ENABLE_PROJECTS="clang;mlir"` to build `llvm-project`, I didn't build `flang` during this run. Then I

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. Just FWIW, a similar change was made in libunwind earlier (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 ), which then required workarounds for cmake issues on both mingw and macos (see

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D86308#2228917 , @tambre wrote: > I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is > enabled by compiler-rt anyway and CMake can recognize the files as assembly > anyway. Can we remove that function

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +Builder.defineMacro("__BOOL__"); What is strict -std=c89? `!Opts.C99` ?

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

2020-08-20 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar updated this revision to Diff 286868. vrnithinkumar added a comment. - Add assignment to nullptr case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86293/new/ https://reviews.llvm.org/D86293 Files:

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

2020-08-20 Thread Nathan Huckleberry via Phabricator via cfe-commits
Nathan-Huckleberry updated this revision to Diff 286866. Nathan-Huckleberry added a comment. - Attach translation unit names to trace processes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82994/new/ https://reviews.llvm.org/D82994 Files:

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

2020-08-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: efriedma, echristo, RKSimon, spatel. Herald added subscribers: nikic, dexonsmith, steven_wu, javed.absar, hiraditya, dschuff. Herald added a project: LLVM. craig.topper requested review of this revision. This is an attempt at

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286861. RKSimon added a comment. Added constexpr tests - I went for the -ve array size approach as thats the approach in clang\test\Sema\constant-builtins-2.c etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85692: python bindings: fix DeprecationWarning

2020-08-20 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In D85692#2228860 , @nickdesaulniers wrote: > In D85692#2227531 , @jdenny wrote: > >> Does this mean we officially no longer support python 2, which this change >> breaks? > > Send a patch

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Raul Tambre via Phabricator via cfe-commits
tambre added a comment. I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway. @teemperor Could you give this a try? If this doesn't work, could you upload the Ninja file for me to

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan marked 3 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +Builder.defineMacro("__BOOL__"); +Builder.defineMacro("__LONGNAME__");

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Abhina Sree via Phabricator via cfe-commits
abhina.sreeskantharajan updated this revision to Diff 286853. abhina.sreeskantharajan marked an inline comment as done. abhina.sreeskantharajan added a comment. Thanks Hubert, I updated the comments, and also the check-prefix to your suggestion. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D85031: [builtins] Unify the softfloat division implementation

2020-08-20 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko added a comment. //Some general context:// The final goal was to have an explanation why this particular number of iteration (3, 4 or 5, depending on type) are enough for any `a` and `b` passed as input arguments taking into account errors due to particular finite precision

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Raul Tambre via Phabricator via cfe-commits
tambre created this revision. tambre added reviewers: phosek, teemperor. Herald added subscribers: Sanitizers, cfe-commits, dexonsmith, kristof.beyls, mgorny, dberris. Herald added projects: clang, Sanitizers. tambre requested review of this revision. It isn't very wise to pass an assembly file

[PATCH] D85692: python bindings: fix DeprecationWarning

2020-08-20 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added a comment. In D85692#2227531 , @jdenny wrote: > Does this mean we officially no longer support python 2, which this change > breaks? Send a patch to support both and I'll approve it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

2020-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D86295#2228745 , @xazax.hun wrote: > But unless you add a comment one will probably replace the offset with an > optional as the part of a refactoring. Sure, I will leave a note. I was thinking using a PointerIntUnion

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D86223#2228855 , @steakhal wrote: > I wanted to conditionally, aka. in debug configuration override the base > implementation of the SymbolData::getKindStr I see. Yeah, that does not make much sense. I was thinking about

[PATCH] D78899: [Driver] Add callback to Command execution

2020-08-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78902: [Driver] Add output file to properties of Command

2020-08-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D86223#2228731 , @xazax.hun wrote: > In D86223#2227353 , @steakhal wrote: > >> Eh, I'm not sure if it worth it to put these into virtual functions - as >> conditionally overriding

[PATCH] D77925: Revert "[TLI] Per-function fveclib for math library used for vectorization"

2020-08-20 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. In D77925#2220177 , @wenlei wrote: > In D77925#2220169 , @mehdi_amini > wrote: > >> I rather have a non closed list of veclib: if you just have a map keyed by >> string instead of an enum

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Should we test the intrinsics in a constexpr context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 ___ cfe-commits mailing list

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

2020-08-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. MemRegion is a popular class to instantiate in the analyzer so it looks good to me. But unless you add a comment one will probably replace the offset with an optional as the part of a refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86223: [analyzer][z3] Use more elaborate z3 variable names in debug build

2020-08-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D86223#2227353 , @steakhal wrote: > Eh, I'm not sure if it worth it to put these into virtual functions - as > conditionally overriding functions is not really a good idea. I am not sure I follow. What do you mean by

[PATCH] D85031: [builtins] Unify the softfloat division implementation

2020-08-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added inline comments. Comment at: compiler-rt/lib/builtins/fp_div_impl.inc:99 + // 0 < x0(b) < 1 + // abs(x0(b) - 1/b) <= 3/4 - 1/sqrt(2) + This estimation is absent from the original comment. Do you have reference where it came from? Also the

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

2020-08-20 Thread Simon Moll via Phabricator via cfe-commits
simoll planned changes to this revision. simoll marked 6 inline comments as done. simoll added inline comments. Comment at: clang/docs/LanguageExtensions.rst:492 + +The memory representation of a boolean vector is the smallest fitting +power-of-two integer. The alignment is the

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286837. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229 Files: clang/docs/ReleaseNotes.rst clang/lib/Headers/popcntintrin.h clang/test/CodeGen/popcnt-builtins.c

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon updated this revision to Diff 286835. RKSimon added a comment. Added release note entry - this will need to revised as we add more intrinsics, so is just an initial placeholder. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/

[PATCH] D84414: [RISCV] Support Shadow Call Stack

2020-08-20 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. In D84414#2186257 , @jrtc27 wrote: > There is a possibly-compelling argument against using x18: RV32E only gives > x0-x15, so would not be able to support the current implementation. We discussed this on the RISC-V LLVM Sync-up

[PATCH] D86299: [compiler-rt][builtins] Factor out some common bit manipulations

2020-08-20 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: howard.hinnant, jfb, vsk, lebedev.ri. Herald added subscribers: Sanitizers, dexonsmith, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. This patch incapsulates some commonly used hacks in a

[PATCH] D86298: [SyntaxTree] Add support for `this`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86298 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D86065: [SVE] Make ElementCount members private

2020-08-20 Thread David Sherwood via Phabricator via cfe-commits
david-arm added a comment. Hi @ctetreau, I agree with @efriedma that keeping the two classes distinct for now seems best. The reason is I spent quite a lot of time trying to unify these classes already and I hit a stumbling block - TypeSize has the ugly uint64_t() cast operator, which makes

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e983e24043: [SyntaxTree] Split tests related to Namespace (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e4e983e - [SyntaxTree] Split tests related to Namespace

2020-08-20 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-08-20T15:14:56Z New Revision: e4e983e240430b3a0dc92402cc940292bd0d263f URL: https://github.com/llvm/llvm-project/commit/e4e983e240430b3a0dc92402cc940292bd0d263f DIFF: https://github.com/llvm/llvm-project/commit/e4e983e240430b3a0dc92402cc940292bd0d263f.diff

[PATCH] D86295: [analyzer] Reorder the the layout of MemRegion and cache by hand for optimal size

2020-08-20 Thread Balázs Benics via Phabricator via cfe-commits
steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, Szelethus, vsavchenko, ASDenysPetrov. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project:

[PATCH] D86139: [SyntaxTree] Split tests related to Namespace

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 286823. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. answer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86139/new/ https://reviews.llvm.org/D86139 Files:

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

2020-08-20 Thread Nithin VR via Phabricator via cfe-commits
vrnithinkumar created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vrnithinkumar requested review of this

[clang] a4ef9e8 - [SyntaxTree] Unify logic for generating `id-expression`

2020-08-20 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-08-20T14:57:35Z New Revision: a4ef9e8643e2f3f8972e19c5b25f4dd81ba03508 URL: https://github.com/llvm/llvm-project/commit/a4ef9e8643e2f3f8972e19c5b25f4dd81ba03508 DIFF: https://github.com/llvm/llvm-project/commit/a4ef9e8643e2f3f8972e19c5b25f4dd81ba03508.diff

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGba32915db2ce: [SyntaxTree] Add support for `MemberExpression` (authored by eduucaldas). Changed prior to commit: https://reviews.llvm.org/D86227?vs=286811=286820#toc Repository: rG LLVM Github

[clang] ba32915 - [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via cfe-commits
Author: Eduardo Caldas Date: 2020-08-20T14:57:35Z New Revision: ba32915db2ce78256115a9db7b07bb3806e6364a URL: https://github.com/llvm/llvm-project/commit/ba32915db2ce78256115a9db7b07bb3806e6364a DIFF: https://github.com/llvm/llvm-project/commit/ba32915db2ce78256115a9db7b07bb3806e6364a.diff

[PATCH] D83088: Introduce CfgTraits abstraction

2020-08-20 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. > Based on your description and the DomTree patches, if I understand correctly, > the primary motivation is to facilitate writing CFG-representation-agnostic > algorithms/analyses (e.g., dominators, divergence, convergence analyses), > such that you can later lift the

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init-zos.c:5 +// +// S390X-ZOS-CXX:#define _EXT 1 +// S390X-ZOS-C99:#define _ISOC99_SOURCE 1 Should this be `GNUXX`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

2020-08-20 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:736 +MacroBuilder ) const override { +// FIXME: LONG_LONG should not be defined under -std=c89 +Builder.defineMacro("_LONG_LONG"); Minor

[PATCH] D83048: [LiveDebugValues] 3/4 Add Xclang and CodeGen options for using instr-ref variable locations

2020-08-20 Thread Jeremy Morse via Phabricator via cfe-commits
jmorse updated this revision to Diff 286814. jmorse added a comment. Herald added a subscriber: dang. Add a test for the driver -Xclang option. As far as I understand this, we're just checking that the switch is accepted by the driver, not that it does anything in particular (please correct me

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 286811. eduucaldas marked 2 inline comments as done. eduucaldas added a comment. Unify logic for generating `id-expression` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/

[PATCH] D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals

2020-08-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:66 + if (const auto *Negated = Result.Nodes.getNodeAs(Id)) { +if (Negated->getOpcode() == UO_LNot && +isa(Negated->getSubExpr()))

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

2020-08-20 Thread Richard Barton via Phabricator via cfe-commits
richard.barton.arm requested changes to this revision. richard.barton.arm added a comment. A few specific comments to address here as well as the pre-commit linting ones. Comment at: clang/lib/Driver/Driver.cpp:1584 void Driver::PrintVersion(const Compilation , raw_ostream )

[clang] 1ecf120 - [index-while-building] Fix build with -DBUILD_SHARED_LIBS=True

2020-08-20 Thread Alex Bradbury via cfe-commits
Author: Alex Bradbury Date: 2020-08-20T15:12:56+01:00 New Revision: 1ecf120246e7d3e5c9a9ed1db637914bbf4b5702 URL: https://github.com/llvm/llvm-project/commit/1ecf120246e7d3e5c9a9ed1db637914bbf4b5702 DIFF: https://github.com/llvm/llvm-project/commit/1ecf120246e7d3e5c9a9ed1db637914bbf4b5702.diff

[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

2020-08-20 Thread Anatoly Trosinenko via Phabricator via cfe-commits
atrosinenko created this revision. atrosinenko added reviewers: MaskRay, kamleshbhalui, luismarques, efriedma, aykevl. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. atrosinenko requested review of this revision. The existing implementations are almost

[PATCH] D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals

2020-08-20 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:66 + if (const auto *Negated = Result.Nodes.getNodeAs(Id)) { +if (Negated->getOpcode() == UO_LNot && +isa(Negated->getSubExpr()))

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

2020-08-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/test/Modules/Inputs/inherit-attribute/b.h:3 + +class Foo; + Does this forward declaration impact the test? I can't quite tell whether this exists to test that the attribute is attached to the non-defining

[clang] 2bac004 - Add triples to fixed-point tests which lacked them.

2020-08-20 Thread Bevin Hansson via cfe-commits
Author: Bevin Hansson Date: 2020-08-20T15:36:15+02:00 New Revision: 2bac004c905dc8db99fd3766678d33aa5a0eec2b URL: https://github.com/llvm/llvm-project/commit/2bac004c905dc8db99fd3766678d33aa5a0eec2b DIFF: https://github.com/llvm/llvm-project/commit/2bac004c905dc8db99fd3766678d33aa5a0eec2b.diff

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:911 + S->getEndLoc()), + idExpression, nullptr); +

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. I reverted in adf0b8cc70325f027d202139e3ff984c41896b57 to get the bots green again . Feel free to ping if you need someone to test the patch on macOS. Repository: rG LLVM Github Monorepo

[clang] adf0b8c - Revert "[compiler-rt] Compile assembly files as ASM not C"

2020-08-20 Thread Raphael Isemann via cfe-commits
Author: Raphael Isemann Date: 2020-08-20T15:25:22+02:00 New Revision: adf0b8cc70325f027d202139e3ff984c41896b57 URL: https://github.com/llvm/llvm-project/commit/adf0b8cc70325f027d202139e3ff984c41896b57 DIFF:

[PATCH] D85706: [compiler-rt] Compile assembly files as ASM not C

2020-08-20 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. This broke Green Dragon's compiler-rt builds and also my local compiler-rt build. See for example here: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23424/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 03ded54 - Fix -allow-enabling-analyzer-alpha-checkers always being passed to run-clang-tidy.py

2020-08-20 Thread Aaron Ballman via cfe-commits
Author: Joachim Priesner Date: 2020-08-20T09:15:29-04:00 New Revision: 03ded5497a2f458b6af054fa7bac0da0240e7b7a URL: https://github.com/llvm/llvm-project/commit/03ded5497a2f458b6af054fa7bac0da0240e7b7a DIFF:

[PATCH] D86209: [clang-tidy] run-clang-tidy.py: Fix -allow-enabling-analyzer-alpha-checkers always being passed

2020-08-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf as 03ded5497a2f458b6af054fa7bac0da0240e7b7a , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D86209: [clang-tidy] run-clang-tidy.py: Fix -allow-enabling-analyzer-alpha-checkers always being passed

2020-08-20 Thread Joachim Priesner via Phabricator via cfe-commits
jspam added a comment. Yes please. I am fine with the license agreement, and please use Joachim Priesner as the commit author. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86209/new/ https://reviews.llvm.org/D86209

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:900 + +auto *unqualifiedId = new (allocator()) syntax::UnqualifiedId; +Builder.foldNode(Builder.getRange(S->getMemberLoc(), S->getEndLoc()),

[PATCH] D86227: [SyntaxTree] Add support for `MemberExpression`

2020-08-20 Thread Eduardo Caldas via Phabricator via cfe-commits
eduucaldas updated this revision to Diff 286799. eduucaldas marked 10 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86227/new/ https://reviews.llvm.org/D86227 Files:

[PATCH] D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`

2020-08-20 Thread Aleksandr Platonov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG445739826567: [clangd] Dont crash on `#pragma clang __debug parser_crash` (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86279/new/

[clang-tools-extra] 4457398 - [clangd] Don't crash on `#pragma clang __debug parser_crash`

2020-08-20 Thread Aleksandr Platonov via cfe-commits
Author: Aleksandr Platonov Date: 2020-08-20T15:53:21+03:00 New Revision: 445739826567e5402b558f2c130d76dc916c82ec URL: https://github.com/llvm/llvm-project/commit/445739826567e5402b558f2c130d76dc916c82ec DIFF:

[PATCH] D86284: [clangd] Remove useless stderr logging.

2020-08-20 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG707138d67786: [clangd] Remove useless stderr logging. (authored

[clang-tools-extra] 707138d - [clangd] Remove useless stderr logging.

2020-08-20 Thread Adam Czachorowski via cfe-commits
Author: Adam Czachorowski Date: 2020-08-20T14:52:04+02:00 New Revision: 707138d677861182083b3c6c3b44b76951fd36ef URL: https://github.com/llvm/llvm-project/commit/707138d677861182083b3c6c3b44b76951fd36ef DIFF:

[PATCH] D86284: [clangd] Remove useless stderr logging.

2020-08-20 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was accidentally added in

[PATCH] D85923: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-08-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:77 + CI.getHeaderSearchOpts().ModuleCachePath = ModuleCachePath.c_str(); + llvm::errs() << "MC: " << ModuleCachePath << "\n"; + llvm::errs().flush(); errs should

[PATCH] D86229: [X86] Enable constexpr on POPCNT intrinsics (PR31446)

2020-08-20 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added a comment. I think that's everything - I'd prefer to handle the registered target fixes in separate commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86229/new/ https://reviews.llvm.org/D86229

[PATCH] D86282: [Fixed Point] Use FixedPointBuilder to codegen fixed-point IR.

2020-08-20 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan created this revision. ebevhan added reviewers: leonardchan, rjmccall. Herald added a subscriber: bjope. Herald added a project: clang. ebevhan requested review of this revision. This changes the methods in CGExprScalar to use FixedPointBuilder to generate IR for fixed-point conversions

[clang-tools-extra] 53b9199 - [clangd] Fix crash-bug in preamble indexing when using modules.

2020-08-20 Thread Adam Czachorowski via cfe-commits
Author: Adam Czachorowski Date: 2020-08-20T14:19:52+02:00 New Revision: 53b9199a5cdba8a6e294e1fb183f308ec558db22 URL: https://github.com/llvm/llvm-project/commit/53b9199a5cdba8a6e294e1fb183f308ec558db22 DIFF:

[PATCH] D86069: [clang] When loading preamble from AST file, re-export modules in Sema.

2020-08-20 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbaeff989b050: [clang] When loading preamble from AST file, re-export modules in Sema. (authored by adamcz). Repository: rG LLVM Github Monorepo

[PATCH] D85923: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-08-20 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG53b9199a5cdb: [clangd] Fix crash-bug in preamble indexing when using modules. (authored by adamcz). Repository: rG

[clang-tools-extra] baeff98 - [clang] When loading preamble from AST file, re-export modules in Sema.

2020-08-20 Thread Adam Czachorowski via cfe-commits
Author: Adam Czachorowski Date: 2020-08-20T14:19:52+02:00 New Revision: baeff989b050e0f63412c52c1b8f9d8f3e91f671 URL: https://github.com/llvm/llvm-project/commit/baeff989b050e0f63412c52c1b8f9d8f3e91f671 DIFF:

[PATCH] D86279: [clangd] Don't crash on `#pragma clang __debug parser_crash`

2020-08-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86279/new/ https://reviews.llvm.org/D86279

  1   2   >