[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. This change adds three PDT calculations to the standard pipeline. Please try to avoid the PDT calculations if PGO is not used, possibly by using LazyBPI. CHANGES SINCE LAST ACTION

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo added inline comments. Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:408 FunctionToLoopPassAdaptor createFunctionToLoopPassAdaptor(LoopPassT Pass, bool UseMemorySSA = false, +bool UseBlockFrequencyInfo = false,

[PATCH] D86156: [BFI] Preserve BFI information through loop passes via VH callbacks inside LoopStandardAnalysisResults

modimo updated this revision to Diff 287152. modimo added a comment. Herald added subscribers: lxfind, nikic. @asbirlea Thanks for taking a look! I updated BFI to resemble MSSA as recommended which removed the BFI calculation unless LICM is invoked. Also removed the spurious diffs from

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk updated this revision to Diff 287142. amyk added a comment. Address review comments: - Further consolidate the custom codegen of the two builtins - Add SemaChecking for if the third argument is a constant, if the third argument is in range and if the second argument is the same type as the

[PATCH] D86293: [analyzer] Add modeling of Eq operator in smart ptr

NoQ added a comment. This looks outright correct to me. I have random suggestions on note text here and there. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:132 + std::unique_ptr PToMove; // expected-note {{Default constructed smart pointer 'PToMove' is null}} +

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

NoQ added a comment. This is easier than D86293 because there's no old value in the freshly constructed smart pointer, right? I suspect that you can still re-use a lot of the implementation with D86293 , at least partially.

[PATCH] D81703: [Clang] Don't leave Expr::Classification fields uninitialized in default constructor

vitalybuka added a comment. Compiler warning should already catch this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81703/new/ https://reviews.llvm.org/D81703 ___ cfe-commits mailing list

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added inline comments. Comment at: clang/test/Driver/cl-options.c:685 +// vctoolsdir is handled by the driver; just check that we don't error. Pass -c because fakedir isn't a real toolchain path +// RUN: %clang_cl -c -vctoolsdir fakedir -- %s 2>&1 One

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

efriedma added a comment. As far as I know, there are basically three categories of things that depend on the alignment of a type. 1. The default alignment of load/store/alloca. On trunk, load/store/alloca always have explicitly specified alignment in memory. That said, old bitcode doesn't

[PATCH] D86376: [HIP] Improve kernel launching latency

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. yaxunl requested review of this revision. Currently clang emits emits the following code for triple chevron kernel call for HIP: __hipPushCallConfiguration(grids, blocks, shmem, stream); kernel_stub(); whereas for each

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added a comment. We use BuildXL. Thanks for the comments. I'll make the requested changes and get a new rev posted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85998/new/ https://reviews.llvm.org/D85998 ___ cfe-commits mailing

[PATCH] D86218: Teach the swift calling convention about _Atomic types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added subscribers: amccarth, dblaikie. aganea added a comment. In D85998#2231001 , @zahen wrote: > The build system strives to be deterministic When you say build system, you mean MSBuild? Other? For example, Fastbuild purposely calls

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:295 + P->foo(); // No warning. +} I was trying to test the below code. ``` void foo_() { std::unique_ptr PToMove; std::unique_ptr&& AfterRValeRefCast =

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vrnithinkumar requested review of this

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu added inline comments. Comment at: clang/test/SemaCXX/ms_dynamic_cast.cpp:16 +B *b = new D1(); +auto d = dynamic_cast(b); // expected-warning{{should not use dynamic_cast with /GR-}} +} lebedev.ri wrote: > I'm not sure it makes sense to talk

[PATCH] D84713: [DominatorTree] Simplify ChildrenGetter.

asbirlea added a comment. Done in https://reviews.llvm.org/rG7ea0ee30588, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84713/new/ https://reviews.llvm.org/D84713 ___ cfe-commits mailing list

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/ms_dynamic_cast.cpp:16 +B *b = new D1(); +auto d = dynamic_cast(b); // expected-warning{{should not use dynamic_cast with /GR-}} +} I'm not sure it makes sense to talk about MSVC/clang-cl

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. zequanwu requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86369 Files:

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

craig.topper added a comment. In D86310#2231136 , @efriedma wrote: > I'm afraid the AutoUpgrade component of this isn't compatible with existing > IR without some additional work. I'm most concerned about cases like the > following: > > #pragma

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

efriedma added a comment. I'm afraid the AutoUpgrade component of this isn't compatible with existing IR without some additional work. I'm most concerned about cases like the following: #pragma pack(8) struct X { __int128 x; }; // Not a packed struct in IR because the native alignment is

[PATCH] D83088: Introduce CfgTraits abstraction

dblaikie added a comment. (side note: this code review is a bit hard to follow with all the linting messages about naming - might be a bit more readable if it conformed to the naming conventions?) In D83088#2227151 , @nhaehnle wrote: > In

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

zahen added a comment. The build system strives to be deterministic so all file probes need to be accounted for; environment variables are also problematic. Our builds deliberately don't run from a Visual Studio command prompt. In addition, we'd like to avoid coupling clang tools that don't

[PATCH] D85998: Add clang-cl "vctoolsdir" option to specify the location of the msvc toolchain

aganea added a comment. Could you please explain a little bit more what motivated this change? You can achieve almost the same with `env VCToolsInstallDir=F:\Your_Path\ clang-cl ...`. You would also want to pass `-fmsc-version=...` to avoid extracting the version from `cl.exe`. If you're

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

nemanjai accepted this revision. nemanjai added a comment. LGTM aside from a couple of minor nits. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13405 + // This combine is only eligible for a BUILD_VECTOR of v1i128. + // Other return types are not valid for the

[clang] c0ec37e - [docs] Move the label for __builtin_shufflevector below __builtin_dump_struct so the see also link in 'vector operations' will go to the right place and have the right name.

Author: Craig Topper Date: 2020-08-21T11:51:15-07:00 New Revision: c0ec37ee65d0d21fddc6194fe1cce9db4107a902 URL: https://github.com/llvm/llvm-project/commit/c0ec37ee65d0d21fddc6194fe1cce9db4107a902 DIFF: https://github.com/llvm/llvm-project/commit/c0ec37ee65d0d21fddc6194fe1cce9db4107a902.diff

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM from my end; although @MaskRay might want another look. Comment at: clang/lib/Basic/Targets/OSTargets.h:758 +

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added a comment. In D83174#2230795 , @gargvaibhav64 wrote: > I updated the -triple option to x86_64-pc-windows-msvc (as it was more > consistent with current tests). I also updated the path to Unix style in the > -I option. Thank you for

[clang] aca191c - Re-land 7a527f17776be78ec44b88e82b39afb65fc148e4 with fixes.

Author: Vaibhav Garg Date: 2020-08-21T14:40:09-04:00 New Revision: aca191cce1c4dbab28a65cfe4caa6348e698a2b3 URL: https://github.com/llvm/llvm-project/commit/aca191cce1c4dbab28a65cfe4caa6348e698a2b3 DIFF: https://github.com/llvm/llvm-project/commit/aca191cce1c4dbab28a65cfe4caa6348e698a2b3.diff

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

sameeranjoshi requested changes to this revision. sameeranjoshi added a comment. Thanks for working on it. A few review comments/questions on changes in `flang` part from the patch. Comment at: flang/include/flang/Frontend/CompilerInstance.h:93 + + static

[PATCH] D86239: [OPENMP]Fix PR47158, case 3: allow devic_typein nested declare target region.

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86239/new/ https://reviews.llvm.org/D86239 ___

[PATCH] D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249)

rsmith added a comment. (Same comments as for the bitreverse patch.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86342/new/ https://reviews.llvm.org/D86342 ___ cfe-commits mailing list

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

rsmith added a comment. Can you also add documentation to LanguageExtensions.rst? Thanks! Comment at: clang/docs/ReleaseNotes.rst:61 + ``__builtin_bitreverse32`` and ``__builtin_bitreverse64`` may now be used + within constexpr expressions. There's no such

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86339/new/ https://reviews.llvm.org/D86339

[PATCH] D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249)

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Its a bit of a shame that the two implementations (left/right) differ by only a single character, an y ideas for combining them cleanly? I might also consider combining the two 'if'

[PATCH] D86089: [flang][driver]Add experimental flang driver and frontend with help screen

richard.barton.arm added inline comments. Comment at: flang/test/lit.cfg.py:40 +# exclude the tests for flang_new driver while there are two drivers +if config.include_flang_new_driver_test == "OFF": + config.excludes = ['Inputs', 'CMakeLists.txt', 'README.txt', 'LICENSE.txt',

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 287060. gargvaibhav64 added a comment. I updated the -triple option to x86_64-pc-windows-msvc (as it was more consistent with current tests). I also updated the path to Unix style in the -I option. CHANGES SINCE LAST ACTION

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

JamesNagurne added a comment. In D83174#2230763 , @aaron.ballman wrote: > Unfortunately, I had to revert the change as it was causing some buildbots to > fail. I reverted in 58c305f466d1f78adb10e7295b9bc9fc192a6e09 >

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added a comment. Unfortunately, I had to revert the change as it was causing some buildbots to fail. I reverted in 58c305f466d1f78adb10e7295b9bc9fc192a6e09 . Some failures include:

[clang] 58c305f - Revert "Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute"

Author: Aaron Ballman Date: 2020-08-21T12:42:10-04:00 New Revision: 58c305f466d1f78adb10e7295b9bc9fc192a6e09 URL: https://github.com/llvm/llvm-project/commit/58c305f466d1f78adb10e7295b9bc9fc192a6e09 DIFF: https://github.com/llvm/llvm-project/commit/58c305f466d1f78adb10e7295b9bc9fc192a6e09.diff

[PATCH] D86218: Teach the swift calling convention about _Atomic types

aschwaighofer updated this revision to Diff 287055. aschwaighofer added a comment. Respect atomic padding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

ABataev updated this revision to Diff 287053. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84887/new/ https://reviews.llvm.org/D84887 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman added a comment. In D83174#2230616 , @gargvaibhav64 wrote: > In D83174#2230546 , @aaron.ballman > wrote: > >> LGTM, thank you for the fix! Do you need someone to commit on your behalf? >> If so,

[clang] 7a527f1 - Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

Author: Vaibhav Garg Date: 2020-08-21T12:04:43-04:00 New Revision: 7a527f17776be78ec44b88e82b39afb65fc148e4 URL: https://github.com/llvm/llvm-project/commit/7a527f17776be78ec44b88e82b39afb65fc148e4 DIFF: https://github.com/llvm/llvm-project/commit/7a527f17776be78ec44b88e82b39afb65fc148e4.diff

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM, but let's give others a chance to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86277/new/ https://reviews.llvm.org/D86277

[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM, but let's give others a chance to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86289/new/ https://reviews.llvm.org/D86289

[PATCH] D86274: [Constants] Handle FNeg in getWithOperands.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc72a3ab949e: [Constants] Handle FNeg in getWithOperands. (authored by fhahn). Changed prior to commit:

[clang] bc72a3a - [Constants] Handle FNeg in getWithOperands.

Author: Florian Hahn Date: 2020-08-21T16:50:56+01:00 New Revision: bc72a3ab949e14b990c080985fc1e74475f1e7d2 URL: https://github.com/llvm/llvm-project/commit/bc72a3ab949e14b990c080985fc1e74475f1e7d2 DIFF: https://github.com/llvm/llvm-project/commit/bc72a3ab949e14b990c080985fc1e74475f1e7d2.diff

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan marked 5 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:743 +Builder.defineMacro("__BFP__"); +// FIXME: __BOOL__ should be defined under strict -std=c89. +

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

riccibruno added a comment. Friendly ping on this patch: this is the last change to `SequenceChecker` I had in mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81003/new/ https://reviews.llvm.org/D81003

[PATCH] D84599: [Index/USRGeneration] Use NamedDecl::getDeclName() instead of NamedDecl::printName in USRGenerator::EmitDeclName

riccibruno added a comment. Friendly ping on this patch; the patches depending on this patch (D84658 and D85033 on Phab + others not uploaded yet) significantly improve the handling of unnamed entities in diagnostics.

[PATCH] D85324: [SystemZ][z/OS] Add z/OS Target and define macros

abhina.sreeskantharajan updated this revision to Diff 287043. abhina.sreeskantharajan added a comment. Thanks for reviewing. I've updated the comments and removed ISOC99_SOURCE macro. I've updated the lit test to reflect these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 added a comment. In D83174#2230546 , @aaron.ballman wrote: > LGTM, thank you for the fix! Do you need someone to commit on your behalf? If > so, please be sure you're fine with the license agreement and let us know > what name and email

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2229712 , @NoQ wrote: > Heh, nice! Did you try to measure the actual impact of this change on memory > and/or performance? Eh, I don't really know how to bench this. Here is how I did it in nutshell: Added STATISTIC

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Do you need someone to commit on your behalf? If so, please be sure you're fine with the license agreement and let us know what name and email

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG1beb11c61ae4: [SyntaxTree] Use annotations in Statement tests (authored by eduucaldas). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86345/new/

[clang] 1beb11c - [SyntaxTree] Use annotations in Statement tests

Author: Eduardo Caldas Date: 2020-08-21T14:42:33Z New Revision: 1beb11c61ae4b0130cb87ed56b9e010ef6a06691 URL: https://github.com/llvm/llvm-project/commit/1beb11c61ae4b0130cb87ed56b9e010ef6a06691 DIFF: https://github.com/llvm/llvm-project/commit/1beb11c61ae4b0130cb87ed56b9e010ef6a06691.diff

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

atrosinenko added inline comments. Comment at: compiler-rt/lib/builtins/int_mulv_impl.inc:1 -//===-- mulvdi3.c - Implement __mulvdi3 ---===// +//===-- int_mulv_impl.inc - Implement __mulv[sdt]i3 ---===// //

[PATCH] D86289: [NFC][compiler-rt] Factor out __mulo[sdt]i3 implementations to .inc file

atrosinenko updated this revision to Diff 287032. atrosinenko added a comment. Explicitly mark .inc file as a C source like is already done for almost all `*_impl.inc` files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86289/new/

[PATCH] D86277: [NFC][compiler-rt] Factor out __mulv[sdt]i3 implementations to .inc file

atrosinenko updated this revision to Diff 287031. atrosinenko added a comment. Explicitly mark .inc file as a C source like is already done for almost all `*_impl.inc` files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86277/new/

[PATCH] D86169: Initial support for letting plugins perform custom parsing of attribute arguments.

aaron.ballman added reviewers: john.brawn, rsmith, erichkeane. aaron.ballman added a comment. Thank you for the work in progress patch as a starting point for discussion! I'm adding a few more reviewers who may be interested in this work. One part of the design I'm not yet certain of is passing

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added inline comments. Comment at: clang/test/SemaCXX/abstract.cpp:282 - void foo( C& c ) {} + void foo( C& c ) {} // expected-note {{candidate function not viable: expects an l-value for 1st argument}} sammccall wrote: > the new diagnostics are

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 287030. hokein added a comment. update a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 287029. hokein marked 2 inline comments as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files:

[PATCH] D85611: Improve dynamic AST matching diagnostics for conversion errors

aaron.ballman added a comment. In D85611#2218144 , @aaron.ballman wrote: > Ping Ping x2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85611/new/ https://reviews.llvm.org/D85611 ___ cfe-commits

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Somehow this ended up failing on Fuchsia with a plain "Exit code 1", but not sure what's the fault. I'll revert until I figured that out. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86176: [clang-tidy] readability-simplify-boolean-expr detects negated literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Comment at: clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp:66 + if (const auto *Negated =

[clang] c1dd5df - Revert "Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)"

Author: Raphael Isemann Date: 2020-08-21T16:08:37+02:00 New Revision: c1dd5df4255cd870e96a59e73163b22d85fbaba3 URL: https://github.com/llvm/llvm-project/commit/c1dd5df4255cd870e96a59e73163b22d85fbaba3 DIFF:

[PATCH] D85716: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

hokein updated this revision to Diff 287025. hokein marked an inline comment as done. hokein added a comment. simplify the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85716/new/ https://reviews.llvm.org/D85716 Files:

[PATCH] D85716: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG466590192b42: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved. (authored by hokein). Repository: rG LLVM Github

[clang] 4665901 - [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

Author: Haojian Wu Date: 2020-08-21T15:48:59+02:00 New Revision: 466590192b4202ceb294eb82f881193d013dc90c URL: https://github.com/llvm/llvm-project/commit/466590192b4202ceb294eb82f881193d013dc90c DIFF: https://github.com/llvm/llvm-project/commit/466590192b4202ceb294eb82f881193d013dc90c.diff

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. It seems that this patch is stuck. How can I reproduce the crash? @OikawaKirie The closest I could come up with was: void clang_analyzer_eval(int); void clang_analyzer_printState(); void foo(int a, int b) { if (a > 5) return; if (b < 4)

[PATCH] D84013: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4c3ed42ba56: Correctly emit dwoIDs after ASTFileSignature refactoring (D81347) (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM

[clang] a4c3ed4 - Correctly emit dwoIDs after ASTFileSignature refactoring (D81347)

Author: Raphael Isemann Date: 2020-08-21T15:05:02+02:00 New Revision: a4c3ed42ba5625af54254584d762ebf96cc06942 URL: https://github.com/llvm/llvm-project/commit/a4c3ed42ba5625af54254584d762ebf96cc06942 DIFF:

[PATCH] D86065: [SVE] Make ElementCount members private

paulwalker-arm added inline comments. Comment at: llvm/include/llvm/Support/TypeSize.h:56 + friend bool operator>(const ElementCount , const ElementCount ) { +assert(LHS.Scalable == RHS.Scalable && david-arm wrote: > ctetreau wrote: > > fpetrogalli wrote:

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas added a reviewer: gribozavr2. eduucaldas added a comment. Sorry for doing this after asking for review. I think it might be interesting landing this patch before : https://reviews.llvm.org/D85330 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86345: [SyntaxTree] Use annotations in Statement tests

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86345 Files: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp Index:

[PATCH] D86065: [SVE] Make ElementCount members private

david-arm updated this revision to Diff 287003. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86065/new/ https://reviews.llvm.org/D86065 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CodeGenTypes.cpp llvm/include/llvm/Analysis/VectorUtils.h

[PATCH] D86342: Enable constexpr on ROTATELEFT/ROTATERIGHT builtin intrinsics (PR47249)

RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, spatel. Herald added a project: clang. RKSimon requested review of this revision. This enables us to use the __builtin_rotateleft / __builtin_rotateright 8/16/32/64 intrinsics inside constexpr code. Repository: rG

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 287004. gargvaibhav64 marked an inline comment as done. gargvaibhav64 added a comment. Updated the regex to be less-greedy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. In D85649 I suggested a different version of module flags, which is a bit nicer to use, e.g. one can say just getModuleFlag("sign-return-address-with-bkey") != nullptr instead of a) checking for the flag presence, b) getting its value

[PATCH] D85753: [clangd] Discard diagnostics from another SourceManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4889353207a: [clangd] Discard diagnostics from another SourceManager. (authored by adamcz). Changed prior to commit: https://reviews.llvm.org/D85753?vs=285961=287000#toc Repository: rG LLVM Github

[clang-tools-extra] b488935 - [clangd] Discard diagnostics from another SourceManager.

Author: Adam Czachorowski Date: 2020-08-21T13:11:21+02:00 New Revision: b4889353207aefd6f2641cef0301f78838c5b52e URL: https://github.com/llvm/llvm-project/commit/b4889353207aefd6f2641cef0301f78838c5b52e DIFF:

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. New diagnostics are really good :-) Comment at: clang/test/SemaCXX/abstract.cpp:282 - void foo( C& c ) {} + void foo( C& c ) {} // expected-note {{candidate

[PATCH] D86339: Enable constexpr on BITREVERSE builtin intrinsics (PR47249)

RKSimon created this revision. RKSimon added reviewers: rsmith, craig.topper, spatel. Herald added a project: clang. RKSimon requested review of this revision. This enables us to use the __builtin_bitreverse 8/16/32/64 intrinsics inside constexpr code. Repository: rG LLVM Github Monorepo

[PATCH] D85716: [AST][RecoveryExpr] Fix a bogus unused diagnostic when the type is preserved.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/recovery-expr-type.cpp:80 +namespace test6 { +struct Base { +private: nit: can the testcase be simplified? Isn't

[PATCH] D85635: [clangd] Compute the inactive code range for semantic highlighting.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think the code could be a bit clearer, but up to you. The tests are good so feel free to submit any version you're happy with. Comment at:

[clang] 9ffc412 - [X86] Enable constexpr on BITSCAN intrinsics (PR31446)

Author: Simon Pilgrim Date: 2020-08-21T11:44:20+01:00 New Revision: 9ffc412e1afba9e4853c94669d26c9ba0707096c URL: https://github.com/llvm/llvm-project/commit/9ffc412e1afba9e4853c94669d26c9ba0707096c DIFF: https://github.com/llvm/llvm-project/commit/9ffc412e1afba9e4853c94669d26c9ba0707096c.diff

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/BuildTreeTest.cpp:107-110 int main() { if (1) {} if (1) {} else if (0) {} } eduucaldas wrote: > I just noticed that we didn't yet use annotations on statement tests. > I think

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

gribozavr2 added a comment. Output format LGTM! Comment at: clang/lib/Tooling/Syntax/Tree.cpp:160 + assert(N); + if (auto *L = llvm::dyn_cast(N)) { +OS << "'"; Comment at: clang/lib/Tooling/Syntax/Tree.cpp:169 - auto *T = cast(N);

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/Tree.cpp:158 if (!Marks.empty()) OS << Marks << ": "; gribozavr2 wrote: > Maybe the marks should be moved after the primary identifier of the node, > WDYT? That would be more

[PATCH] D85330: [SyntaxTree] Extend the syntax tree dump

eduucaldas updated this revision to Diff 286983. eduucaldas added a comment. Adapt Statement tests to new testing infrastructure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85330/new/ https://reviews.llvm.org/D85330 Files:

[PATCH] D86334: [analyzer] Remove redundant output errs

nullptr.cpp added a comment. I don't have commit access, can you help commit it? In D86334#2230032 , @xazax.hun wrote: > LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86334/new/

[clang] c8e6bf0 - [X86] Enable constexpr on BSWAP intrinsics (PR31446)

Author: Simon Pilgrim Date: 2020-08-21T10:55:15+01:00 New Revision: c8e6bf0a65fdbda7a611e8047e2a644777f15b24 URL: https://github.com/llvm/llvm-project/commit/c8e6bf0a65fdbda7a611e8047e2a644777f15b24 DIFF: https://github.com/llvm/llvm-project/commit/c8e6bf0a65fdbda7a611e8047e2a644777f15b24.diff

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll added a comment. In D81083#2227760 , @rsandifo-arm wrote: > I'm not qualified to review the CodeGen stuff (or accept the patch, obvs. > :-)) but FWIW, here are some comments on the doc and Sema side. Thanks for your comments! Maybe you know

[clang] c6863a4 - [X86] Enable constexpr on POPCNT intrinsics (PR31446)

Author: Simon Pilgrim Date: 2020-08-21T10:20:37+01:00 New Revision: c6863a4ab8b96ba4b878cb2da7e101bc6bcfaeef URL: https://github.com/llvm/llvm-project/commit/c6863a4ab8b96ba4b878cb2da7e101bc6bcfaeef DIFF: https://github.com/llvm/llvm-project/commit/c6863a4ab8b96ba4b878cb2da7e101bc6bcfaeef.diff

[PATCH] D86334: [analyzer] Remove redundant output errs

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86334/new/ https://reviews.llvm.org/D86334

[PATCH] D41179: [Sema] Diagnose template specializations with C linkage

miyuki abandoned this revision. miyuki added a comment. Abandoning in favour of: commit a64883431369f28f3fac311c496a4dfad480058f Author: Richard Smith Date: Wed Jul 29 16:49:05 2020 -0700 PR46729: Reject explicit and

[PATCH] D81083: [Clang] Allow "vector_size" applied to Booleans

simoll updated this revision to Diff 286971. simoll edited the summary of this revision. simoll added a comment. - Rebased. - Allow comparisons on boolean vectors. - Restored result type for vector comparisons on other types. - Added operator, alignment and constexpr tests. Repository: rG

[clang] 33bb80b - [X86] ia32intrin.h - pull out common attributes into defines. NFCI.

Author: Simon Pilgrim Date: 2020-08-21T10:03:28+01:00 New Revision: 33bb80bc7a6e67be90cf9b5e8d0f679e5e3acbaf URL: https://github.com/llvm/llvm-project/commit/33bb80bc7a6e67be90cf9b5e8d0f679e5e3acbaf DIFF: https://github.com/llvm/llvm-project/commit/33bb80bc7a6e67be90cf9b5e8d0f679e5e3acbaf.diff

  1   2   >