[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. In D86671#2246486 , @dougpuob wrote: > In D86671#2246480 , @Eugene.Zelenko > wrote: > >> By the word, you must mention new option in documentation too. > > Hi @Eugene.Zelenko, > Is

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2246480 , @Eugene.Zelenko wrote: > By the word, you must mention new option in documentation too. Hi @Eugene.Zelenko, Is the `clang-tools-extra/docs/ReleaseNotes.rst` file that you mentioned? If YES, seems pretty

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added a comment. By the word, you must mention new option in documentation too. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 +- Added: Support variables could be checked with Hungarian Notation which the + prefix encodes the actual data type of the

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked an inline comment as done. dougpuob added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 +- Added: Support variables could be checked with Hungarian Notation which the + prefix encodes the actual data type of the variable.

[clang] 6ae7b40 - Set alignment of .llvmbc and .llvmcmd to 1

Author: Fangrui Song Date: 2020-08-29T18:27:34-07:00 New Revision: 6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67 URL: https://github.com/llvm/llvm-project/commit/6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67 DIFF: https://github.com/llvm/llvm-project/commit/6ae7b403c3e1aebcb825d3dd4777d3c1149d6d67.diff

[clang] 4fbf063 - Remove OpenBSD/sparc support

Author: Brad Smith Date: 2020-08-29T20:47:18-04:00 New Revision: 4fbf0636a214abbc30b6eee42bd5b7755dfd5f38 URL: https://github.com/llvm/llvm-project/commit/4fbf0636a214abbc30b6eee42bd5b7755dfd5f38 DIFF: https://github.com/llvm/llvm-project/commit/4fbf0636a214abbc30b6eee42bd5b7755dfd5f38.diff

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert marked 4 inline comments as done. aaronpuchert added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafety.h:205 + /// Warn when calling a function that the negative capability is not held. + /// \param D -- The decl for the function

[PATCH] D84603: Thread safety analysis: More consistent warning message

aaronpuchert updated this revision to Diff 288820. aaronpuchert added a comment. Herald added a subscriber: danielkiss. Remove "holding" and moved to a separate message because the overlap was getting smaller. Also introduced a separate function because it's more consistent with the other

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 288818. atmnpatel added a comment. Fixed comment in C++ test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel updated this revision to Diff 288817. atmnpatel edited the summary of this revision. atmnpatel added a comment. Sorry, Fixed the test, added a C++ test. I checked the C++, OpenCL C, and OpenCL C++ specs and couldn't find anything that diverged from C spec in this regard, but none of

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

jfb requested changes to this revision. jfb added a comment. This revision now requires changes to proceed. MSC54-CPP refers to POF, which as I pointed out above isn't relevant anymore. I'd much rather have a diagnostic which honors the state of things after http://wg21.link/p0270.

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:73 +- Added: Support variables could be checked with Hungarian Notation which the + prefix encodes the actual data type of the variable. See examples for entry format

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked 8 inline comments as done. dougpuob added a comment. I fixed all review suggestions from @aaron.ballman, @Eugene.Zelenko, and @njames93, Thank you. But I still can't sure I did everything correct. I encountered a problem when I use `arc diff` or `arc diff --update D86671`,

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob updated this revision to Diff 288812. dougpuob added a comment. Herald added a subscriber: danielkiss. Improved for suggestions of code review. 1. Moved release notes to `Changes in existing checks` section. Eugene.Zelenko] 2. Modified release notes can be describe user-facing.

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

lebedev.ri added a comment. Does that wording apply to both the C and C++ (OpenCL?)? Regardless, might be good to test that. Comment at: clang/test/CodeGen/attr-noprogress.c:1-2 +// RUN: %clang_cc1 -S -emit-llvm %s -o - | grep " noprogress " | count 1 +// RUN: %clang_cc1 -S

[PATCH] D86841: [clang] Adds noprogress attribute deduction for infinite loops

atmnpatel created this revision. atmnpatel added reviewers: jdoerfert, aqjune, RalfJung. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. atmnpatel requested review of this revision. The `noprogress` LLVM IR attribute currently under discussion is deduced for

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. Please review. I would like to get this in a mergeable state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 ___ cfe-commits mailing

[PATCH] D86838: Improved for suggestions of code review. 1. Moved release notes to `Changes in existing checks` section. [Eugene.Zelenko] 2. Modified release notes can be describe user-facing. [Eu

Eugene.Zelenko added a comment. You need just upload new diff into existing Phabricator revision, not create new one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86838/new/ https://reviews.llvm.org/D86838

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 288792. tambre added a comment. Herald added subscribers: danielkiss, jfb. Rebase, fix new MS builtins and other tests, XFAIL pthread_create() test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/

[PATCH] D86838: Improved for suggestions of code review. 1. Moved release notes to `Changes in existing checks` section. [Eugene.Zelenko] 2. Modified release notes can be describe user-facing. [Eu

dougpuob created this revision. Herald added subscribers: cfe-commits, danielkiss. Herald added a project: clang. dougpuob requested review of this revision. ...-identifier-naming-hungarain-notion.cpp` file. [Eugene.Zelenko] 4. Removed unrelated change. [Nathan James] 5. Renamed

[clang] 85fce44 - [Sema] Simplify ShouldDiagnoseUnusedDecl, NFC

Author: Aaron Puchert Date: 2020-08-29T18:42:58+02:00 New Revision: 85fce449dc43447bf9d75163bda81e157f5b73e7 URL: https://github.com/llvm/llvm-project/commit/85fce449dc43447bf9d75163bda81e157f5b73e7 DIFF: https://github.com/llvm/llvm-project/commit/85fce449dc43447bf9d75163bda81e157f5b73e7.diff

[clang] b4a2d36 - [Sema] ICK_Function_Conversion is a third kind conversion

Author: Aaron Puchert Date: 2020-08-29T18:42:36+02:00 New Revision: b4a2d36c3f74ea5574cd03a9c1a704bcffb1869e URL: https://github.com/llvm/llvm-project/commit/b4a2d36c3f74ea5574cd03a9c1a704bcffb1869e DIFF: https://github.com/llvm/llvm-project/commit/b4a2d36c3f74ea5574cd03a9c1a704bcffb1869e.diff

[PATCH] D67113: ICK_Function_Conversion is a third kind conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a2d36c3f74: [Sema] ICK_Function_Conversion is a third kind conversion (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67113/new/

[PATCH] D14484: [clang-format] Formatting constructor initializer lists by putting them always on different lines

FStefanni added a comment. Herald added a subscriber: danielkiss. Hi to all, I am also interested to this option, since match my personal style, but more important, in my experience, this kind of formatting is very used. I hope it will be implemented in a near future. Which is the current

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante updated this revision to Diff 288781. Mordante marked an inline comment as done. Mordante added a comment. Reworked the patch to match the behaviour as discussed in D86559 . - The likelihood attributes only have an effect when used directly on the

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2243583 , @staffantj wrote: > The use case for this becomes clearer when considering that the attribute > that will be used 95% of the time is [[unlikely]]. You may have a constructor > that you wish to ask the

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. In D86559#2243575 , @staffantj wrote: > As one of the SG14 industry members driving this, I'm firmly in the camp that > this is what we're expecting. In the first case the 1/2 case are "neutral". > This is a very explicit, and

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

Mordante added a comment. Herald added a subscriber: danielkiss. In D86559#2242713 , @aaron.ballman wrote: > In D86559#2242586 , @Mordante wrote: > >>> That is exactly the behavior I am coming to believe we should

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib updated this revision to Diff 288777. bruntib added a comment. Note texts are now describing what kind of C++ constructs were used. The warning message also explains better the reason of the issue: "signal handlers must be plain old functions, C++-only constructs are not allowed"

[PATCH] D85091: [Sema, CodeGen] Implement [[likely]] and [[unlikely]] in IfStmt

Mordante marked 7 inline comments as done. Mordante added inline comments. Herald added a subscriber: danielkiss. Comment at: clang/include/clang/Basic/Attr.td:1288 +def Likely : StmtAttr { + let Spellings = [CXX11<"", "likely", 201803>]; + let Documentation =

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert-signal-handler-must-be-plain-old-function.cpp:22 + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: do not use C++ constructs in signal handlers [cert-msc54-cpp] + // CHECK-MESSAGES:

[PATCH] D33825: [clang-tidy] signal handler must be plain old function check

bruntib updated this revision to Diff 288774. bruntib added a comment. Test file has been extended with the second line of the "note" diagnostic message which designates the location of the suspicious "C++ construct". The full clang-tidy output looks like this:

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss updated this revision to Diff 288775. danielkiss edited the summary of this revision. danielkiss added a comment. Sync with D85649 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 Files:

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

danielkiss abandoned this revision. danielkiss added a comment. Abandoning in favour of D85649 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75181/new/ https://reviews.llvm.org/D75181 ___ cfe-commits

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

khoroshansky added a comment. Herald added a subscriber: danielkiss. Will this ever be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73425: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc2dac4116df: [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fc2dac4 - [PPC] Fix platform definitions when compiling FreeBSD powerpc64 as LE

Author: Dimitry Andric Date: 2020-08-29T12:03:20+02:00 New Revision: fc2dac4116df62c25396b15ec9730f67a0b1aac7 URL: https://github.com/llvm/llvm-project/commit/fc2dac4116df62c25396b15ec9730f67a0b1aac7 DIFF:

[PATCH] D81930: [AArch64] Add -mmark-bti-property flag.

danielkiss updated this revision to Diff 288765. danielkiss marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81930/new/ https://reviews.llvm.org/D81930 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Thanks, looks good now :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 ___ cfe-commits mailing