[clang] f1cd659 - [AST][FPEnv] Keep FP options in trailing storage of CastExpr

Author: Serge Pavlov Date: 2020-09-14T12:15:21+07:00 New Revision: f1cd6593da3ad763eb3f7aaf7761d06fb303493a URL: https://github.com/llvm/llvm-project/commit/f1cd6593da3ad763eb3f7aaf7761d06fb303493a DIFF: https://github.com/llvm/llvm-project/commit/f1cd6593da3ad763eb3f7aaf7761d06fb303493a.diff

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

thakis added a comment. Heads-up: We're seeing fairly widespread test failures with this in Chromium that go away when we force this flag off. It's possible that it's due to only a small number of issues and they might be previously-benign UB (no idea), but I figured I'd give an early note.

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. Thanks for working on this @russell.gallop! I've reproduced your tests, please see below. The only difference is that I've used a ThinLTO build for stage2: -DCMAKE_CXX_FLAGS="/GS- -Xclang -O3 -fstrict-aliasing -march=skylake-avx512 -flto=thin -fwhole-program-vtables"

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

rsmith added a comment. In D86048#2254607 , @sammccall wrote: > The crux is we're forcing `decltype(N)` to be a (unique) dependent type, > which feels wrong. > [...] > There are three behaviors: > > - standard up to C++14: traversing the expr looking for

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

bcardiff created this revision. bcardiff added reviewers: JDevlieghere, phosek, smeenai. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, cfe-commits, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. bcardiff requested review of this revision. Changes

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

rsmith added a comment. For what it's worth, the most recent thoughts from CWG on this question are from 2015 (prior to guaranteed copy elision, which probably changes the answer): http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#1965. That direction would permit `const_cast` to

[PATCH] D87565: [Sema] Improve const_cast conformance to N4261

rsmith requested changes to this revision. rsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaCast.cpp:1781-1782 // type T2 using the cast const_cast; and //-- if T1 is a class type, a prvalue of type

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

JakeMerdichAMD edited reviewers, added: MyDeveloperDay; removed: jmerdich. JakeMerdichAMD requested changes to this revision. JakeMerdichAMD added a subscriber: MyDeveloperDay. JakeMerdichAMD added a comment. This revision now requires changes to proceed. After looking at more of the history (ie,

[PATCH] D87566: [Sema] Permit conversions to arrays of unknown bound

rsmith added a comment. I made a start on this a while back and found a bunch more places that needed updates: https://github.com/zygoloid/llvm-project/commit/c23440979ac4f07ce38657ce0e69d010d2afa83e Feel free to either take that patch as a basis or as inspiration for the remaining changes.

[PATCH] D87561: [Sema] List conversion validate character array

rsmith added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:4988 + +if (ToType->isArrayType() && ToType->isCharType() && +isa(From->getInit(0))) { `isCharType` is too narrow a check here. We also need to check for all the other types

[PATCH] D86841: [clang] Add mayprogress and llvm.loop.mustprogress attribute deduction

atmnpatel updated this revision to Diff 291471. atmnpatel added a comment. Flipped direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86841/new/ https://reviews.llvm.org/D86841 Files: clang/lib/CodeGen/CGLoopInfo.cpp

[PATCH] D87563: [Sema] Improve overload resolution

rsmith added a comment. Looks like this is an implementation of DR1307. Please also add a test to `test/CXX/drs/dr13xx.cpp`. Comment at: clang/include/clang/Sema/Overload.h:548-549 + +/// The std::initializer_list expression to convert from. +const InitListExpr

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry updated this revision to Diff 291468. kuzkry added a comment. Formatted code after CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 Files:

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry updated this revision to Diff 291466. kuzkry added a comment. Adjusted tests IncludeFixerTest.cpp after CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 Files:

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 291467. JonasToth added a comment. - fix left over merge marker and one formatting problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87588/new/ https://reviews.llvm.org/D87588 Files:

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth created this revision. JonasToth added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, steven.zhang. Herald added a project: clang. JonasToth requested review of this revision. The analysis for const-ness of local variables required a view generally useful matchers

[clang] c0bcd11 - [ASTImporter] Add basic support for comparing Stmts and compare function bodies

Author: Raphael Isemann Date: 2020-09-13T18:25:04+02:00 New Revision: c0bcd11068fc13e45b253c6c315882097f94c121 URL: https://github.com/llvm/llvm-project/commit/c0bcd11068fc13e45b253c6c315882097f94c121 DIFF:

[PATCH] D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0bcd11068fc: [ASTImporter] Add basic support for comparing Stmts and compare function bodies (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. In D86671#2259492 , @njames93 wrote: > In D86671#2259443 , @dougpuob wrote: > >> In D86671#2259364 , @njames93 wrote: >> >>> Did you upload this

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry added a comment. This fixes https://bugs.llvm.org/show_bug.cgi?id=47290. @Jake I decided I would at least create this pull request so you can decide whether you want it or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/

[PATCH] D87587: [clang-format] Make one-line namespaces resistant to FixNamespaceComments, update documentation

kuzkry created this revision. kuzkry added reviewers: krasimir, JakeMerdichAMD, jmerdich, rsmith. kuzkry added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. kuzkry requested review of this revision. clang-format documentation states that having

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Sorry for missing this review, i simply hadn't time :/ All my concerns are addressed and I think this is LGTM after rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

JonasToth added a comment. Herald added subscribers: mgehre, Charusso. ping. This checks seems pretty much done. @jranieri-grammatech do you think there is something missing? Otherwise it could be rebased and comitted? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D87291: [clang-format][regression][PR47461] ifdef causes catch to be seen as a function

MyDeveloperDay updated this revision to Diff 291452. MyDeveloperDay added a comment. Minimize other places where try could be incorrectly seen as an identifier try // foo { or try /* foo */ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87291/new/

[PATCH] D75107: [clang-tidy] hicpp-signed-bitwise IgnorePositiveIntegerLiterals now partially recursive

JonasToth added a comment. ping. @njames93 are you revisiting this patch? What is the missing piece? Maybe i can help out a bit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75107/new/ https://reviews.llvm.org/D75107

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 291449. alokmishra.besu added a comment. Updated patch to make it extendable to more selectors Implemented device_arch and implementation_vendor selectors as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 63182c2 - [gcov] Add spanning tree optimization

Author: Fangrui Song Date: 2020-09-13T00:07:31-07:00 New Revision: 63182c2ac0b643a60d397274e8a31166fc7243fa URL: https://github.com/llvm/llvm-project/commit/63182c2ac0b643a60d397274e8a31166fc7243fa DIFF: https://github.com/llvm/llvm-project/commit/63182c2ac0b643a60d397274e8a31166fc7243fa.diff