[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-copy-initialization.cpp:409 + +namespace std { + flx wrote: > gribozavr2 wrote: > > Could you add a nested inline namespace to better imitate what de

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

njames93 added a comment. Probably not quite as verbose but should do the job // RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* -- -std=c++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

njames93 added a comment. How does this type alias and typedef, In theory that should also be handled. using Functor = std::function<...>; Functor Copy = Orig; // No warning. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:39-44 +AST

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

lebedev.ri added a comment. In D66324#2336186 , @phosek wrote: > I apologize for the late response, I somehow missed the earlier responses. We > have successfully used this feature in Fuchsia and found it useful, but I > agree that the issues raised need

[PATCH] D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: dantrushin, hokein, daltenty, stevewan, jasonliu. Herald added a subscriber: hiraditya. Herald added projects: clang, LLVM. hubert.reinterpretcast requested review of this revision. Comparing 32-bit `ptrdiff_t`

LLVM buildbot will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58559: emit '(assertions enabled)' in the version string for a build of clang with assertions enabled

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Marking as "Request changes" to get this off my queue; are you still interested in pursuing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D89608: Make sure Objective-C category support in IncludeSorter handles top-level imports

compositeprimes created this revision. compositeprimes added reviewers: alexfh, gribozavr. compositeprimes added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. compositeprimes requested review of this revision. Currently, this would not correct

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. We can't have it always match, that would require us to reject the conversion to a bare function-pointer type, which is required by the standard. I'm not sure if MSVC's multiple conversions hack is conformant or not, but it's at least more conformant than that. CHANG

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2335627 , @jvesely wrote: > In D89372#2335027 , @Anastasia wrote: > >> In D89372#2334728 , @jvesely wrote: >> >>> In D89372#2334225

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rsmith wrote: > rsmith wrote: > > erichkeane wrote: > > > rjmccall wrote: > > > > ...I made this commen

[clang] d4aac67 - Make the check for whether we should memset(0) an aggregate

Author: Richard Smith Date: 2020-10-16T16:48:22-07:00 New Revision: d4aac67859640bdb7e8ed3123a00c3f200f89b9c URL: https://github.com/llvm/llvm-project/commit/d4aac67859640bdb7e8ed3123a00c3f200f89b9c DIFF: https://github.com/llvm/llvm-project/commit/d4aac67859640bdb7e8ed3123a00c3f200f89b9c.diff

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

aganea marked an inline comment as done. aganea added inline comments. Comment at: lld/Common/ErrorHandler.cpp:78 } - _exit(val); + llvm::sys::Process::Exit(val); } rnk wrote: > This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, >

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added a comment. I apologize for the late response, I somehow missed the earlier responses. We have successfully used this feature in Fuchsia and found it useful, but I agree that the issues raised need to be addressed. Unfortunately @paulkirth is no longer working on this project. I hop

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2445 + FPO.getFPExceptionMode() != LangOptions::FPE_Ignore || + FPO.getAllowFEnvAccess()) && Info.Ctx.getLangOpts().CPlusPlus) { +Info.FFDiag(E, diag::note_constexpr_float_arithmetic_strict);

[PATCH] D70378: [LLD][COFF] Cover usage of LLD as a library

rnk added inline comments. Comment at: lld/Common/ErrorHandler.cpp:78 } - _exit(val); + llvm::sys::Process::Exit(val); } This appears to have regressed shutdown. `sys::Process::Exit` calls `exit`, not `_exit`, so now atexit destructors are run. That's unin

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rsmith wrote: > erichkeane wrote: > > rjmccall wrote: > > > ...I made this comment in my first review, but

[PATCH] D86819: [PowerPC][Power10] Implementation of 128-bit Binary Vector Rotate builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGd30155feaa9c: [PowerPC] Implementation of 128-bit Binary Vector Rotate builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D86819?vs=295393&id=298770#toc Repository: rG

[clang] d30155f - [PowerPC] Implementation of 128-bit Binary Vector Rotate builtins

Author: Albion Fung Date: 2020-10-16T18:03:22-04:00 New Revision: d30155feaa9c4ddd09cb115fb30ea5810f63af9c URL: https://github.com/llvm/llvm-project/commit/d30155feaa9c4ddd09cb115fb30ea5810f63af9c DIFF: https://github.com/llvm/llvm-project/commit/d30155feaa9c4ddd09cb115fb30ea5810f63af9c.diff L

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; erichkeane wrote: > rjmccall wrote: > > ...I made this comment in my first review, but Phabricator threw it

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith updated this revision to Diff 298764. rsmith added a comment. Rebase on D89523 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 Files: clang/lib/AST/ExprConstant.c

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG552c6c232872: PR44406: Follow behavior of array bound constant folding in more recent… (authored by rsmith). Changed prior to commit: https://revi

[clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

Author: Richard Smith Date: 2020-10-16T14:34:35-07:00 New Revision: 552c6c2328723a248c2b4d2765f75d49129dff20 URL: https://github.com/llvm/llvm-project/commit/552c6c2328723a248c2b4d2765f75d49129dff20 DIFF: https://github.com/llvm/llvm-project/commit/552c6c2328723a248c2b4d2765f75d49129dff20.diff

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

yaxunl added a comment. I am OK with the changes regarding null pointer. I guess people seldom set pointer to zero address in OpenCL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89520/new/ https://reviews.llvm.org/D89520 ___

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298759. dgoldman added a comment. Fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd/

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298757. dgoldman added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd

[PATCH] D89496: [Format/ObjC] Correctly handle base class with lightweight generics and protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rG24b5266892c3: [Format/ObjC] Correctly handle base class with lightweight generics and protocol (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] 24b5266 - [Format/ObjC] Correctly handle base class with lightweight generics and protocol

Author: Ben Hamilton Date: 2020-10-16T15:12:25-06:00 New Revision: 24b5266892c30e2c9cb6ea28c2631e988a5754b6 URL: https://github.com/llvm/llvm-project/commit/24b5266892c30e2c9cb6ea28c2631e988a5754b6 DIFF: https://github.com/llvm/llvm-project/commit/24b5266892c30e2c9cb6ea28c2631e988a5754b6.diff

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

efriedma added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:807 +default: + break; +} Do we want to error in the "default" case? Not that anyone is likely to use -mfloat-abi on those targets, but I'd prefer not to silently miscompile

[PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

bcardiff abandoned this revision. bcardiff added a comment. Closing in favor of D84563 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/ https://reviews.llvm.org/D87590 _

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 _

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:52 AllowedTypes( utils::options::parseStringList(Options.get("AllowedTypes", ""))) {} lebedev.ri wrote: > flx wrote: > > lebedev

[PATCH] D89332: [clang-tidy] performance-unnecessary-copy-initialization: Always allow std::function to be copied.

flx updated this revision to Diff 298745. flx added a comment. Add more complete fake version of std::function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89332/new/ https://reviews.llvm.org/D89332 Files: clang-tools-extra/clang-tidy/performa

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e801ca0efa9: Treat constant contexts as being in the default rounding mode. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 7e801ca - Treat constant contexts as being in the default rounding mode.

Author: Richard Smith Date: 2020-10-16T13:26:15-07:00 New Revision: 7e801ca0efa99f7cec7a2aea30513ad282030b51 URL: https://github.com/llvm/llvm-project/commit/7e801ca0efa99f7cec7a2aea30513ad282030b51 DIFF: https://github.com/llvm/llvm-project/commit/7e801ca0efa99f7cec7a2aea30513ad282030b51.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298740. atmnpatel added a comment. fixed splice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transfo

[clang] 48c70c1 - Extend memset-to-zero optimization to C++11 aggregate functional casts

Author: Richard Smith Date: 2020-10-16T13:21:08-07:00 New Revision: 48c70c1664aa4512cb7e08352dd8eb33dde4807c URL: https://github.com/llvm/llvm-project/commit/48c70c1664aa4512cb7e08352dd8eb33dde4807c DIFF: https://github.com/llvm/llvm-project/commit/48c70c1664aa4512cb7e08352dd8eb33dde4807c.diff

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298736. atmnpatel added a comment. nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/llvm/Transforms/Utils

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis added a comment. I don't like the %clang_bin substitution - imho it's unclear for the test authors when to use it instead of %clang, but I can't come up with a better idea. Is it true that %clang_bin is only necessary when the automatically added -disable-noundef-analysis flag triggers

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 298734. atmnpatel added a comment. Reverted to prior diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 Files: clang/test/Misc/loop-opt-setup.c llvm/include/ll

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

guiand added a comment. Did we decide that we wanted this change then? I remember there being discussion around whether it's the right approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85788/new/ https://reviews.llvm.org/D85788

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added a subscriber: sstefan1. If you're still interested in pursuing this, I'm happy to review it. A general comment is that there are a couple of functional changes in

[PATCH] D89429: clang/Basic: Replace SourceManager::getMemoryBufferForFile, NFC

JDevlieghere added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:705 +llvm::Optional +SourceManager::getMemoryBufferForFileOrNone(const FileEntry *File) { const SrcMgr::ContentCache *IR = getOrCreateContentCache(File); Would it make sense to r

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/ https://reviews.llvm.org/D89360

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith added a comment. In D89360#2329167 , @rjmccall wrote: > Okay. I can accept the fairly unfortunate thing with `const int` > initializers. When is `IsConstantContext` set in C, just static initializers? This affects static initializers, enumerator

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335704 , @arsenm wrote: > In D89582#2335671 , @rampitec wrote: > >> In D89582#2335619 , @arsenm wrote: >> >>> In D89582#2335574

[PATCH] D89360: Treat constant contexts as being in the default rounding mode.

rsmith updated this revision to Diff 298724. rsmith added a comment. - Add more testcases to demonstrate behavior in C. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89360/new/ https://reviews.llvm.org/D89360 Files: clang/lib/AST/ExprConstant.cp

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm added a comment. In D89582#2335671 , @rampitec wrote: > In D89582#2335619 , @arsenm wrote: > >> In D89582#2335574 , @yaxunl wrote: >> >>> What if a device function is

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335619 , @arsenm wrote: > In D89582#2335574 , @yaxunl wrote: > >> What if a device function is called by kernels with different work group >> sizes, will caller's work group siz

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2335027 , @Anastasia wrote: > In D89372#2334728 , @jvesely wrote: > >> In D89372#2334225 , @Anastasia >> wrote: >> >>> >>> Ok, so th

[PATCH] D89520: Don't permit array bound constant folding in OpenCL.

rsmith added a comment. In D89520#2334477 , @Anastasia wrote: >> I couldn't find any spec justification for accepting the kinds of cases >> that D20090 accepts, so a reference to >> where in the OpenCL specification >> th

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm added a comment. In D89582#2335574 , @yaxunl wrote: > What if a device function is called by kernels with different work group > sizes, will caller's work group size override callee's work group size? It's user error to call a function with a larg

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

yaxunl added a comment. What if a device function is called by kernels with different work group sizes, will caller's work group size override callee's work group size? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89582/new/ https://reviews.llvm.org/D89582 ___

[clang] dd4e8a5 - [docs] Fix some out-of-date / inaccurate text and missing formatting in the User's Manual.

Author: Richard Smith Date: 2020-10-16T12:00:13-07:00 New Revision: dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84 URL: https://github.com/llvm/llvm-project/commit/dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84 DIFF: https://github.com/llvm/llvm-project/commit/dd4e8a54b2ba9cec78441ba537b94f4eaa5acd84.diff

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith added a comment. In D89523#2333939 , @efriedma wrote: > Also update the documentation? See > https://clang.llvm.org/docs/UsersManual.html#differences-between-various-standard-modes > . Done. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298705. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.llvm.org/D89523 Files: clang/docs/Users

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. Perhaps a better example: (gdb) p CallOperator->getType()->dump() FunctionProtoType 0x1177edf0 'void (void) __attribute__((vectorcall)) const' const vectorcall `-AutoType 0x1177a0d0 'void' sugar `-BuiltinType 0x11716dc0 'void' CHANGES SINCE LAST ACTION https://

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added a comment. In D89559#2335557 , @rjmccall wrote: > No, if you put a calling convention on a lambda and then convert it to a > function pointer, you almost certainly want that CC to be honored. > > Is the `AttributedType` still present in `

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. No, if you put a calling convention on a lambda and then convert it to a function pointer, you almost certainly want that CC to be honored. Is the `AttributedType` still present in `CallOperator->getType()`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

arsenm created this revision. arsenm added reviewers: yaxunl, rampitec. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. arsenm requested review of this revision. Herald added a subscriber: wdng. When the default flat work group size is 256, it should also ap

[PATCH] D89523: PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

rsmith updated this revision to Diff 298702. rsmith marked 2 inline comments as done. rsmith added a comment. - Update User's Manual to more accurately describe GNU mode and Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89523/new/ https://reviews.l

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. 4dc5573acc0d2e7c59d8bac2543eb25cb4b32984 added `FileEntryRef` in order to help enable sharing of a `FileManager` between `CompilerIn

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:621-623 + if (auto AT = TL->getAs()) +S = AT.getModifiedLoc() +.getSourceRange(); // should we just return false? Let me know if you think it would be

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. dgoldman requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Nullability annotations are implmented using attributes; previusly clan

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85788/new/ https://reviews.llvm.org/D85788 ___

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

thakis resigned from this revision. thakis added a comment. hans and compnerd got this, no need for so many reviewers :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63473/new/ https://reviews.llvm.org/D63473 ___ cfe-commits mailing list cfe

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. Thanks for updating the patch. Please add a test case for the earlyclobber case. In particular, if none of the in-tree tests failed for the initial version of this

[PATCH] D89573: [Driver] Incorporate -mfloat-abi in the computed triple on ARM

john.brawn created this revision. john.brawn added reviewers: efriedma, vhscampos, chill. Herald added subscribers: dexonsmith, steven_wu, hiraditya, kristof.beyls. Herald added a project: clang. john.brawn requested review of this revision. LLVM assumes that when it creates a call to a C library

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a mass-market ver

[clang] c4d10e7 - [AMDGPU][HIP] Switch default DWARF version to 5

Author: Scott Linder Date: 2020-10-16T17:53:27Z New Revision: c4d10e7e9bb47b77fad43d8ddcfa328298f36c88 URL: https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88 DIFF: https://github.com/llvm/llvm-project/commit/c4d10e7e9bb47b77fad43d8ddcfa328298f36c88.diff LOG:

[PATCH] D89484: [AMDGPU][HIP] Switch default DWARF version to 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4d10e7e9bb4: [AMDGPU][HIP] Switch default DWARF version to 5 (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:66 // Don't bother listing the implicitly true features -constexpr GPUInfo AMDGCNGPUs[43] = { +constexpr GPUInfo AMDGCNGPUs[44] = { // Name Canonic

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane updated this revision to Diff 298666. erichkeane marked an inline comment as done. erichkeane added a comment. Calc->get. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 Files: clang/lib/Sema/SemaLambda.cpp clang/test/SemaCXX/lamb

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; rjmccall wrote: > ...I made this comment in my first review, but Phabricator threw it away. > > The at

[PATCH] D89487: [AMDGPU] gfx1032 target

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack *TBA* +

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464 _

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1268 +calcLambdaConversionFunctionCallConv(Sema &S, + const FunctionProtoType *CallOpProto) { + CallingConv DefaultFree =

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1278 + if (CallOpCC == DefaultMember) +return DefaultFree; + return CallOpCC; ...I made this comment in my first review, but Phabricator threw it away. The attributes let you explici

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added a comment. I agree that it seems reasonable to preserve an explicit CC from the lambda on the converted function pointer. Comment at: clang/lib/Sema/SemaLambda.cpp:1268 +calcLambdaConversionFunctionCallConv(Sema &S, + const Fu

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini updated this revision to Diff 298660. mantognini added a comment. Keep cl_khr_byte_addressable_store and cles_khr_int64 out of this PR. Add more details on the extensions being removed in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D89372: [OpenCL] Remove unused extensions

Anastasia added a comment. In D89372#2334728 , @jvesely wrote: > In D89372#2334225 , @Anastasia wrote: > >>> >> >> Ok, so the pragma is supposed to control the pointer dereferencing which >> seems like a valid cas

[PATCH] D89487: [AMDGPU] gfx1032 target

foad added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack *TBA* +

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane created this revision. erichkeane added reviewers: rsmith, rjmccall. erichkeane requested review of this revision. As mentioned in the defect, the lambda static invoker does not follow the calling convention of the lambda itself, which seems wrong. This patch ensures that the calling co

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298644. kadircet added a comment. s/memoryTree/memoryUsage/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cl

[PATCH] D89464: Revert "[clang-format] Fix AlignConsecutive on PP blocks"

sylvestre.ledru updated this revision to Diff 298639. sylvestre.ledru added a comment. Add the test which was failing + add the previous tests (but disabled) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89464/new/ https://reviews.llvm.org/D89464

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added a comment. +1 for revert Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd marked 3 inline comments as done. compnerd added a comment. Thanks for the feedback! Comment at: clang/include/clang/APINotes/Types.h:1 +//===-- Types.h - API Notes Data Types --*- C++ -*-===// +// martong wrote: > So we are ma

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:623 {"typeHierarchyProvider", true}, +{"memoryTreeProvider", true}, // clangd exte

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski commandeered this revision. awarzynski edited reviewers, added: CarolineConcatto; removed: awarzynski. awarzynski added a comment. Since @CarolineConcatto has recently moved to a different project, I am assigning this to myself and will be responding to the future review comments. Tha

[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

awarzynski updated this revision to Diff 298635. awarzynski added a comment. Rebase + refector the unit test This is re-based on top of the latest version of D87989 . The unit test is update for consistency with D87989 . Reposit

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

dexonsmith created this revision. dexonsmith added a reviewer: arphaman. Herald added subscribers: ributzka, martong. Herald added a reviewer: shafik. dexonsmith requested review of this revision. It turns out that `FileInfo` *always* has a ContentCache. Clarify that in the code: - Update the pri

[PATCH] D88154: Initial support for vectorization using Libmvec (GLIBC vector math library).

spatel added a subscriber: aeubanks. spatel added a comment. In D88154#2328312 , @venkataramanan.kumar.llvm wrote: > I can add few more float type tests with meta data for VF=8. please let me > know your suggestions. I may be missing some subtlety of

[clang] 59a3b1a - clang-format: Assert in-memory file created in createInMemoryFile, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-16T10:20:32-04:00 New Revision: 59a3b1afb28541d5bf37445b028bfd711e3c556a URL: https://github.com/llvm/llvm-project/commit/59a3b1afb28541d5bf37445b028bfd711e3c556a DIFF: https://github.com/llvm/llvm-project/commit/59a3b1afb28541d5bf37445b028bfd711e3c

[PATCH] D89528: [clang][test] Fix prefix operator++ signature in iterators

martong added a comment. What is the context here? Did it cause any crash/bug or were you just reading through the code for a good night sleep? :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89528/new/ https://reviews.llvm.org/D89528 __

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 298601. ffrankies marked 7 inline comments as done. ffrankies added a comment. Addressed comments by @aaron.ballman regarding the diagnostic warning. I tried to add a test case for when the filename is `kernel.cl`, `verilog.cl`, or `vhdl.cl`, but that did

[PATCH] D89443: [PowerPC][AIX] Make `__vector [un]signed long` an error

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/DeclSpec.cpp:1200 + // It has also been historically deprecated on AIX (as an alias for + // "vector int" in both 32-bit and 64-bi

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa updated this revision to Diff 298624. jonpa added a comment. That makes sense... Patch updated to keep the tying of operands for this case of earlyclobber. @nickdesaulniers : Can you see if this patch now passes your builds? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new

[PATCH] D89372: [OpenCL] Remove unused extensions

jvesely added a comment. In D89372#2334225 , @Anastasia wrote: >> > > Ok, so the pragma is supposed to control the pointer dereferencing which > seems like a valid case but however, it is not implemented now. Do we know of > any immediate plans from any

[PATCH] D79674: [clang-tidy] Better support for Override function in RenamerClangTidy based checks

njames93 updated this revision to Diff 298616. njames93 added a comment. Updated release notes to reflect change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79674/new/ https://reviews.llvm.org/D79674 Files: clang-tools-extra/clang-tidy/utils/R

  1   2   >