[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

2020-10-24 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90009/new/ https://reviews.llvm.org/D90009

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling support for non-type template parameters of class type and template parameter objects.

2020-10-24 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 300524. rsmith added a comment. - Fix incorrect mangling for zero-but-not-null template arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89998/new/ https://reviews.llvm.org/D89998 Files:

[clang] 7b35158 - For P0732R2, P1907R1: ensure that template parameter objects don't refer

2020-10-24 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-24T22:11:43-07:00 New Revision: 7b3515880c22c887cd5ca4825dfb060ad82d3ebc URL: https://github.com/llvm/llvm-project/commit/7b3515880c22c887cd5ca4825dfb060ad82d3ebc DIFF: https://github.com/llvm/llvm-project/commit/7b3515880c22c887cd5ca4825dfb060ad82d3ebc.diff

[PATCH] D89670: [clangd] Store the containing symbol for refs

2020-10-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:349 +SymbolRef{SM.getFileLoc(Loc), Roles, + dyn_cast_or_null(ASTNode.Parent)}); // Don't continue indexing if this is

[PATCH] D89670: [clangd] Store the containing symbol for refs

2020-10-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 300518. nridge added a comment. Use Decl rather than NamedDecl, and add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89670/new/ https://reviews.llvm.org/D89670 Files:

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 300517. tianshilei1992 added a comment. Fixed some test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

2020-10-24 Thread Florin Iucha via Phabricator via cfe-commits
0x8000- added a comment. Would it be possible to split this review further, into "checking" and "fixing" portions? I understand that fix-it portion is more difficult, and sometimes results in multiple 'const' keywords being added, but for the past year we have used the check as part of

[PATCH] D90110: Use --use-color in run-clang-tidy.py

2020-10-24 Thread David Sanders via Phabricator via cfe-commits
dsanders11 created this revision. dsanders11 added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. dsanders11 requested review of this revision. Now that D79477 landed, it's a better user experience to use '--use-color'

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-24 Thread David Sanders via Phabricator via cfe-commits
dsanders11 added a comment. Added a few inline comments for clarification. **Note**: I was not able to get a debug build and unit tests working on my Windows set up, so this has only been tested manually. I'm not sure if the unit test added in D79477 runs on

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-24 Thread David Sanders via Phabricator via cfe-commits
dsanders11 created this revision. dsanders11 added reviewers: aaron.ballman, njames93. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, xazax.hun. Herald added projects: clang, LLVM. dsanders11 requested review of this revision. On Windows the --use-color option cannot be used for

[clang-tools-extra] aaa8b44 - [clangd] Add a TestWorkspace utility

2020-10-24 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2020-10-24T20:15:17-04:00 New Revision: aaa8b44d19918ea1764339224cec68c27445aa8e URL: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e DIFF: https://github.com/llvm/llvm-project/commit/aaa8b44d19918ea1764339224cec68c27445aa8e.diff

[PATCH] D89297: [clangd] Add a TestWorkspace utility

2020-10-24 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaa8b44d1991: [clangd] Add a TestWorkspace utility (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89297: [clangd] Add a TestWorkspace utility

2020-10-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 300513. nridge marked 4 inline comments as done. nridge added a comment. address final review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89297/new/ https://reviews.llvm.org/D89297 Files:

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

2020-10-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Note, I've cargo-culted this comment into `declToTypeHierarchyItem()` as well, so whatever change we make here should be made there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 300509. tianshilei1992 added a comment. Fixed an issue that caused compiler crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90101/new/ https://reviews.llvm.org/D90101 Files:

[PATCH] D83088: Introduce CfgTraits abstraction

2020-10-24 Thread Nicolai Hähnle via Phabricator via cfe-commits
nhaehnle added a comment. I replied on llvm-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83088/new/ https://reviews.llvm.org/D83088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

2020-10-24 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert updated this revision to Diff 300507. aaronpuchert added a comment. `LiteralPtr`s aren't always globals, local variables are also translated that way. So we ask the stored `ValueDecl` if it `isDefinedOutsideFunctionOrMethod`. That seems like the right thing. Repository: rG LLVM

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

2020-10-24 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert reopened this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Almost forgot about that. I think I've figured it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84604/new/

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-10-24 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 300494. mibintc retitled this revision from "Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress" to "Enable '#pragma STDC FENV_ACCESS' in frontend". mibintc added a comment. I updated the test cases, added documentation about

[PATCH] D90101: [Clang][OpenMP][WIP] Avoid unnecessary privatization of mapper array when there is no user defined mapper

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. In current implementation, if it requires an

[clang] 39a0d68 - [X86] Add a stub for Intel's alderlake.

2020-10-24 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-10-24T19:01:22+02:00 New Revision: 39a0d6889dee636af3b7fbb69e1ac5c8af777ad0 URL: https://github.com/llvm/llvm-project/commit/39a0d6889dee636af3b7fbb69e1ac5c8af777ad0 DIFF:

[clang] bd2cf96 - [X86] Add a stub for znver3 based on the little public information there is in AMD's manuals

2020-10-24 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-10-24T19:01:22+02:00 New Revision: bd2cf96c098ed0020f5178eda12cf30d3980d9bd URL: https://github.com/llvm/llvm-project/commit/bd2cf96c098ed0020f5178eda12cf30d3980d9bd DIFF:

[clang] b8d2b6f - Unbreak the clang-interpreter example after 0aec49c8531bc5282b095730d34681455826bc2c

2020-10-24 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-10-24T19:01:21+02:00 New Revision: b8d2b6f6cf6015751fc950c3e8149404e8b37fe8 URL: https://github.com/llvm/llvm-project/commit/b8d2b6f6cf6015751fc950c3e8149404e8b37fe8 DIFF:

[PATCH] D90099: [Clang][OpenMP] Added the support for target data nowait

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Previously we added support for target nowait,

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

2020-10-24 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 300489. MyDeveloperDay added a comment. Rebase the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D89844: [Clang][OpenMP] Fixed an issue of segment fault when using target nowait

2020-10-24 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 added a comment. I don't think the failed case has anything to do with this patch. It must be a random issue in the bolt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89844/new/ https://reviews.llvm.org/D89844

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

2020-10-24 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:60 + *RBrace = cast_or_null( + Stmt->findChild(syntax::NodeRole::CloseParen)); +if (!LBrace || !RBrace) sammccall wrote: > strictly

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

2020-10-24 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Thank you all for your input! Before merging I took the liberty to rename `NoClangOption` as `FlangOnlyOption`. The new name reflects better what the flag is introduced for. Also, based on responses to [1], it is unlikely that it will be used beyond flang-only

[PATCH] D87989: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

2020-10-24 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5906cffd04: [Flang][Driver] Add infrastructure for basic frontend actions and file I/O (authored by CarolineConcatto, committed by awarzynski).

[clang] 4c5906c - [Flang][Driver] Add infrastructure for basic frontend actions and file I/O

2020-10-24 Thread Andrzej Warzynski via cfe-commits
Author: Caroline Concatto Date: 2020-10-24T14:58:32+01:00 New Revision: 4c5906cffd04202387d2f6b50a47d39c0e4f2c0e URL: https://github.com/llvm/llvm-project/commit/4c5906cffd04202387d2f6b50a47d39c0e4f2c0e DIFF:

[PATCH] D90073: [Clang][CodeGen] fix failed assertion

2020-10-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4640 /*D=*/nullptr); -LT = getLLVMLinkageVarDefinition(cast(GD.getDecl()), - D->getType().isConstQualified()); +

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

2020-10-24 Thread Kirill Bobyrev via Phabricator via cfe-commits
kbobyrev updated this revision to Diff 300479. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Decompose locations and add checks for FileID == MainFileID. Also, rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION