[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

bryanpkc added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64SchedTSV110.td:9 +// +// This file defines the machine model for ARM Huawei TSV110 to support +// instruction scheduling and other instruction cost heuristics. I suggest deleting the word

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

rupprecht added a comment. In D84604#2363445 , @aaronpuchert wrote: > Pushed a fix in rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97 > . For > now we just consider all static members as

[clang] edd6ed3 - [NFC] Don't run clang/bindings/python/tests with msan

Author: Vitaly Buka Date: 2020-10-29T22:29:25-07:00 New Revision: edd6ed364151adf3f0eede3d6d22db1018bfd601 URL: https://github.com/llvm/llvm-project/commit/edd6ed364151adf3f0eede3d6d22db1018bfd601 DIFF: https://github.com/llvm/llvm-project/commit/edd6ed364151adf3f0eede3d6d22db1018bfd601.diff

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp added a comment. In D88295#2358845 , @aaronpuchert wrote: > Could you perhaps integrate this into the existing test > `clang/test/CXX/special/class.copy/implicit-move.cpp` instead? > Whenever you have something that closely corresponds to

[PATCH] D88295: [Sema] Fix volatile check when test if a return object can be implicitly move

nullptr.cpp updated this revision to Diff 301810. nullptr.cpp added a comment. make test more clearly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88295/new/ https://reviews.llvm.org/D88295 Files: clang/lib/Sema/SemaStmt.cpp

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/ms-inline-asm-prefix.c:1 +// RUN:%clang_cc1 %s -ferror-limit 0 -triple=x86_64-pc-widows-msvc -target-feature +avx512f -target-feature +avx2 -target-feature +avx512vl -fasm-blocks -mllvm -x86-asm-syntax=intel -S

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. LiuChen3 requested review of this revision. For MASM syntax, the prefixes are not enclosed in braces. The assembly code should like: "evex vcvtps2pd xmm0, xmm1"

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

On Thu, 29 Oct 2020 at 19:32, Nico Weber wrote: > On Thu, Oct 29, 2020 at 6:10 PM Richard Smith > wrote: > >> On Thu, 29 Oct 2020 at 08:07, Nico Weber wrote: >> >>> Hi Richard, >>> >>> this fires on >>> >>> thakis@thakis:~/src/llvm-project$ cat foo.m >>> static const int gSignals[] = { 0, 1,

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

On Thu, Oct 29, 2020 at 6:10 PM Richard Smith wrote: > On Thu, 29 Oct 2020 at 08:07, Nico Weber wrote: > >> Hi Richard, >> >> this fires on >> >> thakis@thakis:~/src/llvm-project$ cat foo.m >> static const int gSignals[] = { 0, 1, 2, 3, 4 }; >> static const int kNumSignals = sizeof(gSignals) /

[PATCH] D89184: Support complex target features combinations

LiuChen3 added a comment. In D89184#2363591 , @echristo wrote: > Let's go ahead and unblock you, but getting a lot of this refactored would be > great if you can. I think it's hitting the limits of the original design. :) Thanks! :) CHANGES SINCE

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

echristo added a comment. In D89158#2363220 , @aeubanks wrote: > Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to > thinking that we should provide a way to to all callbacks. Then in the case > of passes added via TargetMachine,

[PATCH] D89184: Support complex target features combinations

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Let's go ahead and unblock you, but getting a lot of this refactored would be great if you can. I think it's hitting the limits of the original design. :) CHANGES SINCE LAST ACTION

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks added a comment. I'm more convinced now that my initial direction was the cleanest way. It would simplify users of `PassBuilder` quite a bit. I don't want to include PassManager.h into TargetMachine.h just to get `PassBuilder::OptimizationLevel`, so either we could factor out

[PATCH] D90437: [NFC] Clean up PassBuilder

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90437/new/ https://reviews.llvm.org/D90437

[clang-tools-extra] f1e0944 - clang-tidy: Make tests more hermetic

Author: Nico Weber Date: 2020-10-29T20:14:57-04:00 New Revision: f1e0944fe5bbafd99e7cddb0892d6396a7eba01f URL: https://github.com/llvm/llvm-project/commit/f1e0944fe5bbafd99e7cddb0892d6396a7eba01f DIFF: https://github.com/llvm/llvm-project/commit/f1e0944fe5bbafd99e7cddb0892d6396a7eba01f.diff

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

jdoerfert added a comment. In D90415#2363056 , @fodinabor wrote: > Thanks, will land it later. > > For the bug see: https://bugs.llvm.org/show_bug.cgi?id=48014 > Do I have to create a new phabricator review, too? > I'm currently building the release/11.x

[PATCH] D90440: [OpenMP][NFC] Clang format ParseOpenMP

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Strongly in favour. Whitespace differencess vs clang format impose a cost to patches, reviews and downstream forks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 301789. gulfem added a comment. Fix the typo in the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td

[PATCH] D90440: [OpenMP][NFC] Clang format ParseOpenMP

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. ParseOpenMP.cpp was pretty much clang-formatted

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added a comment. Pushed a fix in rGbbed8cfe80cd27d3a47d877c7608d9be4e487d97 . For now we just consider all static members as inaccessible, so we'll treat them as we did before this change. I have proposed making

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 301787. gulfem added a comment. Add IR and bitcode tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td

[clang] bbed8cf - Thread safety analysis: Consider static class members as inaccessible

Author: Aaron Puchert Date: 2020-10-30T00:35:14+01:00 New Revision: bbed8cfe80cd27d3a47d877c7608d9be4e487d97 URL: https://github.com/llvm/llvm-project/commit/bbed8cfe80cd27d3a47d877c7608d9be4e487d97 DIFF: https://github.com/llvm/llvm-project/commit/bbed8cfe80cd27d3a47d877c7608d9be4e487d97.diff

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

eugenis accepted this revision. eugenis added a comment. LGTM I was confused about the ABI statement in the description at the first glance - could you reword it to make it clear that HWASan ABI is not affected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

eugenis accepted this revision. eugenis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90424/new/ https://reviews.llvm.org/D90424 ___ cfe-commits mailing list

[PATCH] D90437: [NFC] Clean up PassBuilder

aeubanks created this revision. aeubanks added reviewers: ychen, asbirlea. Herald added subscribers: llvm-commits, cfe-commits, steven_wu, hiraditya. Herald added projects: clang, LLVM. aeubanks requested review of this revision. Make DebugLogging a member variable so that users of PassBuilder

[PATCH] D89761: Split out llvm/Support/FileSystem/UniqueID.h and clang/Basic/FileEntry.h, NFC

rnk added a comment. I just saw this in passing. Thanks a lot, I had noticed that Filesystem.h is super expensive. Comment at: llvm/include/llvm/Support/FileSystem/UniqueID.h:36 + bool operator<(const UniqueID ) const { +return std::tie(Device, File) <

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90424/new/ https://reviews.llvm.org/D90424 ___

[PATCH] D90436: [HIP] Use argv[0] as the default choice for the Executable name.

tra created this revision. tra added reviewers: sfantao, yaxunl, sdmitriev. Herald added a subscriber: bixia. Herald added a project: clang. tra requested review of this revision. The path produced by `getMainExecutable()` may not be the right one when the files are installed in a symlinked tree

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

pcc added a comment. For the kernel I measured a small regression in boot time (with a version of this change that uses x20 for the v1 checks as well since the kernel doesn't use short granules yet) -- from 6.65s to 6.70s or 0.8%. But that's a fraction of the size gains which were 4% for

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaee608448c8: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers. (authored by fodinabor). Repository: rG LLVM Github

[clang] eaee608 - [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

Author: Joachim Meyer Date: 2020-10-29T23:24:49+01:00 New Revision: eaee608448c832e8f806faae30ae4100620c4688 URL: https://github.com/llvm/llvm-project/commit/eaee608448c832e8f806faae30ae4100620c4688 DIFF: https://github.com/llvm/llvm-project/commit/eaee608448c832e8f806faae30ae4100620c4688.diff

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

aaronpuchert added a comment. In D84604#2363134 , @rupprecht wrote: > I'm seeing failures which I think are due to this patch -- I don't have a > nice godbolt repro yet, but it's something like: Yes, that's very likely. > I'm also seeing the same error

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

hctim accepted this revision. hctim added a comment. This revision is now accepted and ready to land. LGTM - I'm assuming this doesn't regress performance because there's no latency of the additional store due to its locality? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90434: [CodeGen] Correct codegen for self-capturing __block var

ille created this revision. ille added reviewers: rjmccall, jfb. Herald added a project: clang. ille requested review of this revision. This is based on my previous patch, https://reviews.llvm.org/D89903, but is an attempt at a full fix rather than a minimal one, following rjmccall's suggestion

Re: [clang] 552c6c2 - PR44406: Follow behavior of array bound constant folding in more recent versions of GCC.

On Thu, 29 Oct 2020 at 08:07, Nico Weber wrote: > Hi Richard, > > this fires on > > thakis@thakis:~/src/llvm-project$ cat foo.m > static const int gSignals[] = { 0, 1, 2, 3, 4 }; > static const int kNumSignals = sizeof(gSignals) / sizeof(gSignals[0]); > static int

[PATCH] D89158: [NewPM] Run callbacks added via registerPipelineStartEPCallback under -O0

aeubanks added a comment. Looking at BackendUtil.cpp in Clang as well as the Rust code, I'm back to thinking that we should provide a way to to all callbacks. Then in the case of passes added via TargetMachine, we should extend `TargetMachine::registerPassBuilderCallbacks` to also take a

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

aaron.ballman added a comment. In D89743#2360258 , @sammccall wrote: > (while this is useful to you, let's keep discussing, but I'm also happy to > stop and land this with your preferred API/semantics - just LMK if changes > are needed) Let's hold off

[PATCH] D90123: [Sema] Improve notes for value category mismatch in overloading

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4280 "candidate %sub{select_ovl_candidate_kind}0,1,2 not viable: " -"expects an l-value for " +

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 added a comment. > Oh, how neat. The bug you linked to was closed as a dup of another bug. The > other bug was then closed as something that's not in scope with the general > product direction, whatever that means. Yea, typical Microsoft/Windows fun there. > Yeah, that would be

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, LGTM. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv

[PATCH] D84604: Thread safety analysis: Consider global variables in scope

rupprecht added a comment. I'm seeing failures which I think are due to this patch -- I don't have a nice godbolt repro yet, but it's something like: foo.h: class Foo { public: static void DoStuff(); // Grabs mu_ private: static std::vector blah_ GUARDED_BY(mu_);

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

dsanders11 updated this revision to Diff 301755. dsanders11 added a comment. code review changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90109/new/ https://reviews.llvm.org/D90109 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D90430: [clang][NFC] Remove unused FileCheck prefix

keith created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. keith requested review of this revision. This is to enable --allow-unused-duplicates=false. This prefix appears to be outdated and intentionally unused. Repository: rG LLVM Github Monorepo

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor added a comment. Thanks, will land it later. For the bug see: https://bugs.llvm.org/show_bug.cgi?id=48014 Do I have to create a new phabricator review, too? I'm currently building the release/11.x branch with the patch cherry-picked (which worked flawlessly). Repository: rG LLVM

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane updated this revision to Diff 301746. erichkeane marked an inline comment as done. erichkeane added a comment. @rjmccall : Think I got everything, is this what you mean? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89559/new/ https://reviews.llvm.org/D89559 Files:

[PATCH] D90424: AArch64: Use SBFX instead of UBFX to extract address granule in outlined HWASan checks.

pcc created this revision. pcc added reviewers: eugenis, hctim. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. pcc requested review of this revision. In a kernel (or in general in environments where bit 55 of the address is set)

[PATCH] D90422: AArch64: Switch to x20 as the shadow base register for outlined HWASan checks.

pcc created this revision. pcc added reviewers: eugenis, hctim. Herald added subscribers: Sanitizers, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, Sanitizers, LLVM. pcc requested review of this revision. >From a code size perspective it turns out to be better

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const; + erichkeane wrote: > rjmccall wrote: > > Probably worth

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor updated this revision to Diff 301726. fodinabor edited the summary of this revision. fodinabor added a comment. Add missing macro definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90415/new/ https://reviews.llvm.org/D90415

[PATCH] D90419: [AMDGPU] Add gfx90c target

tpr updated this revision to Diff 301723. tpr added a comment. V2: Fixed copy-o in AMDGPUUsage.rst change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90419/new/ https://reviews.llvm.org/D90419 Files: clang/include/clang/Basic/Cuda.h

[clang] 661797b - [AMDGPU] Update AMD GPU documentation

Author: Tony Date: 2020-10-29T20:12:47Z New Revision: 661797bd763331284f1a058609502c0311f8dd38 URL: https://github.com/llvm/llvm-project/commit/661797bd763331284f1a058609502c0311f8dd38 DIFF: https://github.com/llvm/llvm-project/commit/661797bd763331284f1a058609502c0311f8dd38.diff LOG:

[PATCH] D90364: [AMDGPU] Update AMD GPU documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG661797bd7633: [AMDGPU] Update AMD GPU documentation (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90419: [AMDGPU] Add gfx90c target

tpr created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm, jholewinski. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM. tpr requested review of

[PATCH] D90054: Added remotely ran compiler-rt tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aaafa06b2af: Added remotely ran compiler-rt tests. (authored by aorlov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8aaafa0 - Added remotely ran compiler-rt tests.

Author: Alex Orlov Date: 2020-10-30T00:11:16+04:00 New Revision: 8aaafa06b2afce8d0c7ac062708fd91aae01909f URL: https://github.com/llvm/llvm-project/commit/8aaafa06b2afce8d0c7ac062708fd91aae01909f DIFF: https://github.com/llvm/llvm-project/commit/8aaafa06b2afce8d0c7ac062708fd91aae01909f.diff

[clang] 9bb9b73 - Remove HAVE_VCS_VERSION_INC, not needed

Author: Marcel Hlopko Date: 2020-10-29T13:09:05-07:00 New Revision: 9bb9b737c5573cf3850230bc4db8dac7be0e1e85 URL: https://github.com/llvm/llvm-project/commit/9bb9b737c5573cf3850230bc4db8dac7be0e1e85 DIFF: https://github.com/llvm/llvm-project/commit/9bb9b737c5573cf3850230bc4db8dac7be0e1e85.diff

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb9b737c557: Remove HAVE_VCS_VERSION_INC, not needed (authored by hlopko, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

MaskRay accepted this revision. MaskRay added a comment. Herald added a subscriber: dexonsmith. Thanks! Assuming you don't have a commit bit, I'll commit on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

erichkeane added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const; + rjmccall wrote: > Probably worth clarifying in the comment

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. You need to define & undefine the macro around the includes of `__clang_cuda_complex_builtins.h` in `clang/lib/Headers/openmp_wrappers/complex` and

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

aaron.ballman added a comment. In D90109#2360538 , @dsanders11 wrote: >> What issues did you run into regarding testing, because I feel like the >> patch should have test coverage (esp given that color vs ANSI escape codes >> are a bit of an oddity to

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc marked 2 inline comments as done. mibintc added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2967 +PP.Diag(Tok.getLocation(), diag::warn_pragma_fp_ignored) +<< PragmaName.getIdentifierInfo()->getName(); +return;

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

mibintc updated this revision to Diff 301708. mibintc added a comment. respond to @aaron.ballman 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90316/new/ https://reviews.llvm.org/D90316 Files:

[PATCH] D82278: Fix traversal over CXXConstructExpr in Syntactic mode

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82278/new/ https://reviews.llvm.org/D82278 ___ cfe-commits mailing list

[PATCH] D90415: [OpenMP] Use __OPENMP_NVPTX__ instead of _OPENMP in complex wrapper headers.

fodinabor created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. fodinabor requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. This is very similar to 7f1e6fcff942

[PATCH] D89559: PR47372: Fix Lambda invoker calling conventions

rjmccall added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1013 CXXMethodDecl *getLambdaStaticInvoker() const; + CXXMethodDecl *getLambdaStaticInvoker(CallingConv CC) const; + Probably worth clarifying in the comment which invoker is

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

efriedma added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64;

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362327 , @lebedev.ri wrote: > In D90392#2362308 , @ckennelly wrote: > >> In D90392#2362118 , @njames93 wrote: >> >>> IIUC, this is

[PATCH] D84362: [NFC] Refactor DiagnosticBuilder and PartialDiagnostic

rjmccall added a comment. It sounds like what you want is a diagnostic library that's almost completely abstracted over the kinds of entities that can be stored in a diagnostic, including the definition of a source location. I don't think that's incompatible with this patch; there's no need

[clang-tools-extra] 7df80a1 - [clangd] Add support for multiple DecisionForest model experiments.

Author: Utkarsh Saxena Date: 2020-10-29T19:49:40+01:00 New Revision: 7df80a1204f0dc91fb8bba7635e2354adf08989f URL: https://github.com/llvm/llvm-project/commit/7df80a1204f0dc91fb8bba7635e2354adf08989f DIFF:

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7df80a1204f0: [clangd] Add support for multiple DecisionForest model experiments. (authored by usaxena95). Repository: rG LLVM Github Monorepo

[clang] 5d1eae7 - Add support of the next Ubuntu (Ubuntu 21.04 - Hirsute Hippo)

Author: Sylvestre Ledru Date: 2020-10-29T19:11:32+01:00 New Revision: 5d1eae7d23e3477d6044cf9d60a90ce9719f17e6 URL: https://github.com/llvm/llvm-project/commit/5d1eae7d23e3477d6044cf9d60a90ce9719f17e6 DIFF:

[PATCH] D90357: [WebAssembly] Implement SIMD signselect instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe6f50798e79: [WebAssembly] Implement SIMD signselect instructions (authored by tlively). Herald added a subscriber: wingo. Repository: rG LLVM

[clang] be6f507 - [WebAssembly] Implement SIMD signselect instructions

Author: Thomas Lively Date: 2020-10-29T11:06:20-07:00 New Revision: be6f50798e79336cdfd8fe464f37d41ac135640d URL: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d DIFF: https://github.com/llvm/llvm-project/commit/be6f50798e79336cdfd8fe464f37d41ac135640d.diff

[PATCH] D89670: [clangd] Store the containing symbol for refs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Ref.h:91 RefKind Kind = RefKind::Unknown; + SymbolID Container; }; i am afraid we are going to have an indeterminate value here if for whatever reason `Container` detection fails.

[PATCH] D90397: [clangd] Value initialize SymbolIDs

kadircet updated this revision to Diff 301678. kadircet marked an inline comment as done. kadircet added a comment. - change invalid -> null. - add an implicit bool conversion operator. - update apis returning optionals. Note that all the functional changes are in SymbolID.h, rest is api

[PATCH] D90367: [darwin] add support for __isPlatformVersionAtLeast check for if (@available)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/CodeGen/CGObjC.cpp:3874 if (!CGM.IsOSVersionAtLeastFn) { llvm::FunctionType *FTy = Isn't the rest of the function

[PATCH] D88233: [clang][aarch64] Address various fixed-length SVE vector operations

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88233/new/ https://reviews.llvm.org/D88233 ___ cfe-commits

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

thakis added a comment. Is it possible to add an automated test for this in clang/test/Format/... using chmod -w in a RUN line? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121

[PATCH] D90316: [FPEnv] Diagnose pragmas FENV_ROUND,_ACCESS and float_control if target does not support StrictFP

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:107 +if (!PP.getTargetInfo().hasStrictFP() && !PP.getLangOpts().ExpStrictFP) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_fp_ignored) + << "FENV_ACCESS"; Can

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. Gabor or Petr, Can any one of you help me commit this change? Not sure if I could commit myself. In D90362#2361400 , @xazax.hun wrote: > I know that the current situation is a mess, but there is an alternative > version of

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire marked an inline comment as done. steveire added a comment. Reviving this so it can be used to port `clang-tidy` checks to `IgnoreUnlessSpelledInSource`. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual

[PATCH] D89799: [clang][driver] Rename DriverOption as NoXarchOption (NFC)

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:1203 +unsigned DiagID = +Diags.getCustomDiagID(DiagnosticsEngine::Error, + "invalid

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire updated this revision to Diff 301667. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80623/new/ https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13aee94bc710: [ThinLTO] Fix empty .llvmcmd sections (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 13aee94 - [ThinLTO] Fix empty .llvmcmd sections

Author: Mircea Trofin Date: 2020-10-29T09:57:42-07:00 New Revision: 13aee94bc710bfa6277c1f07146c714ee65bf2de URL: https://github.com/llvm/llvm-project/commit/13aee94bc710bfa6277c1f07146c714ee65bf2de DIFF: https://github.com/llvm/llvm-project/commit/13aee94bc710bfa6277c1f07146c714ee65bf2de.diff

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

aabbaabb added a comment. Differential Revision: https://reviews.llvm.org/D90362 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ cfe-commits mailing list

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. @thakis We've stumbled upon this problem when tried to format in-place a read-only file. `clang-format` tries to report this problem via `DiagnosticEngine`, and that fails on assert

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3458 +llvm::CallInst *TrapCall = +Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::ubsantrap), + llvm::ConstantInt::get(CGM.Int32Ty, CheckHandlerID));

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:799 + return CB(Offset.takeError()); +if (auto O = positionToOffset(Inputs->Inputs.Contents,

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

vsk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3447 // If we're optimizing, collapse all calls to trap down to just one per // function to save on code size. + if (TrapBBs.size() <= CheckHandlerID) 'per check, per function'?

[clang] dee7704 - [AMDGPU] Add __builtin_amdgcn_grid_size

Author: Jon Chesterfield Date: 2020-10-29T16:25:13Z New Revision: dee7704829bd421ad3cce4b2132d28f4459b7319 URL: https://github.com/llvm/llvm-project/commit/dee7704829bd421ad3cce4b2132d28f4459b7319 DIFF: https://github.com/llvm/llvm-project/commit/dee7704829bd421ad3cce4b2132d28f4459b7319.diff

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdee7704829bd: [AMDGPU] Add __builtin_amdgcn_grid_size (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90366/new/ https://reviews.llvm.org/D90366

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

lebedev.ri added a comment. In D90392#2362308 , @ckennelly wrote: > In D90392#2362118 , @njames93 wrote: > >> IIUC, this is handling the case where `Ptr.reset(new int)` which is >> different to `Ptr.reset(new

[PATCH] D90366: [ThinLTO] Fix empty .llvmcmd sections

mtrofin updated this revision to Diff 301650. mtrofin marked an inline comment as done. mtrofin added a comment. updated description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90366/new/ https://reviews.llvm.org/D90366 Files:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362118 , @njames93 wrote: > IIUC, this is handling the case where `Ptr.reset(new int)` which is different > to `Ptr.reset(new int())` because the former doesn't initialise the int while > the latter default(zero)

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301649. ckennelly marked 3 inline comments as done. ckennelly added a comment. Apply review feedback from njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301648. ckennelly added a comment. Apply feedback from ymandel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files:

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

jkorous added a comment. Friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/ https://reviews.llvm.org/D89959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >