[PATCH] D90291: [clangd] Add lit tests for remote index

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:42 + found_init_message = False + for line in index_server_process.stderr: +if b'Server listening' in line: so if we think `.readline()` is blocking bu

[PATCH] D90588: [clangd] NFC: Only pass ASTContext and TokenBuffer in getFoldingRanges API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Follow-up on https://reviews.llvm

[PATCH] D90587: [clangd] Control the delay between index hot reloading in remote-server-index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This helps reduce the time needed for remote

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:51 + clangd_process.wait() + os.kill(index_server_process.pid, 9) + kadircet wrote: > can we rather use `signal.SIGXXX` here instead of `9` ? > > Also rat

[PATCH] D90291: [clangd] Add lit tests for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76a168bce01d: [clangd] Add lit tests for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] 76a168b - [clangd] Add lit tests for remote index

Author: Kirill Bobyrev Date: 2020-11-02T08:38:16+01:00 New Revision: 76a168bce01dd950852bc86effd6f379ecf78f82 URL: https://github.com/llvm/llvm-project/commit/76a168bce01dd950852bc86effd6f379ecf78f82 DIFF: https://github.com/llvm/llvm-project/commit/76a168bce01dd950852bc86effd6f379ecf78f82.diff

[PATCH] D90110: [clang-tidy] Use --use-color in run-clang-tidy.py

dsanders11 added a comment. No one has raised any concerns, so if someone with commit access wants to commit this on my behalf it would be appreciated.. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90110/new/ https://reviews.llvm.org/D901

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:36 + ], + stderr=subprocess.PIPE) + kadircet wrote: > nit: formatting looks off, is this really what yapf offers? Y

[PATCH] D90291: [clangd] Add lit tests for remote index

kbobyrev updated this revision to Diff 302213. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve post-LGTM commentts, increase index hot reload frequency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90291/new/ https://r

[PATCH] D90384: [clangd] Fix ParsedASTTest.TopLevelDecls test.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d15a28a853d: [clangd] Fix ParsedASTTest.TopLevelDecls test. (authored by ilya-golovenko, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang-tools-extra] 6d15a28 - [clangd] Fix ParsedASTTest.TopLevelDecls test.

Author: Ilya Golovenko Date: 2020-11-02T08:37:04+01:00 New Revision: 6d15a28a853d5eb453d58324141c9ec75d55c2da URL: https://github.com/llvm/llvm-project/commit/6d15a28a853d5eb453d58324141c9ec75d55c2da DIFF: https://github.com/llvm/llvm-project/commit/6d15a28a853d5eb453d58324141c9ec75d55c2da.diff

[clang] 95824be - [MemProf] Fix test failure on windows

Author: Teresa Johnson Date: 2020-11-01T19:06:50-08:00 New Revision: 95824be18fcd70a90787fecd1e51ca0c67d8bd20 URL: https://github.com/llvm/llvm-project/commit/95824be18fcd70a90787fecd1e51ca0c67d8bd20 DIFF: https://github.com/llvm/llvm-project/commit/95824be18fcd70a90787fecd1e51ca0c67d8bd20.diff

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

steven.zhang added a comment. Sorry, accept the revision by mistake. Please hold on until my comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

steven.zhang accepted this revision. steven.zhang added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Basic/Targets/PPC.cpp:122 if (LongDoubleWidth == 128) { Builder.defineMacro("__LONG_DOUBLE_128__"); Builder.defineMacro("__

[PATCH] D17993: [CodeGen] Apply 'nonnull' to 'this' pointer arguments.

rsmith added a comment. Thanks! We should also have a test for the behavior when targeting the MS ABI, where we sometimes don't emit the `nonnull dereferenceable` because the "`this`" pointer might actually point outside the object, but otherwise I think this is ready to go. Please can you als

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:130 m(ObjcIvar) \ +m(HungarianNotation) \ Is this line needed? Comment at: clang-tools-extra/clang-tidy/readability/Iden

[clang] 0949f96 - [MemProf] Pass down memory profile name with optional path from clang

Author: Teresa Johnson Date: 2020-11-01T17:38:23-08:00 New Revision: 0949f96dc6521be80ebb8ebc1e1c506165c22aac URL: https://github.com/llvm/llvm-project/commit/0949f96dc6521be80ebb8ebc1e1c506165c22aac DIFF: https://github.com/llvm/llvm-project/commit/0949f96dc6521be80ebb8ebc1e1c506165c22aac.diff

[PATCH] D89087: [MemProf] Pass down memory profile name with optional path from clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0949f96dc652: [MemProf] Pass down memory profile name with optional path from clang (authored by tejohnson). Repository: rG LLVM Github Monorepo

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 updated this revision to Diff 302191. njames93 added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Fix bug where prepare would return true erroneously when enum contains duplicated constants Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:441-456 +static IdentifierNamingCheck::HungarianPrefixOption +parseHungarianPrefix(std::string OptionVal) { + for (auto &C : OptionVal) +C = toupper(C); + + if (s

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

myhsu updated this revision to Diff 302188. myhsu retitled this revision from "[Driver][M68K] (Patch 8/8) Add driver support for M68K" to "[Driver][M68k] (Patch 8/8) Add driver support for M68k". myhsu edited the summary of this revision. myhsu added a comment. [NFC] Rename M680x0 to M68k CHANG

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

myhsu updated this revision to Diff 302187. myhsu retitled this revision from "[cfe][M68K] (Patch 7/8) Basic Clang support" to "[cfe][M68k] (Patch 7/8) Basic Clang support". myhsu edited the summary of this revision. myhsu added a comment. Herald added a subscriber: dexonsmith. [NFC] Rename M680x

[PATCH] D90447: [AMDGPU] Add gfx1033 target

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM provided the other files are updated as other reviews have mentioned. Comment at: llvm/docs/AMDGPUUsage.rst:317 +

[PATCH] D90447: [AMDGPU] Add gfx1033 target

tpr added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:317 + names. + ``gfx1033`` ``amdgcn`` dGPU - wavefrontsize64 *TBA* +

[PATCH] D90572: [clang] [MinGW] Allow using the vptr sanitizer

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a project: clang. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90572 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/test/Driver/mingw-sanitizers.c

[PATCH] D90571: [compiler-rt] [ubsan] Use the itanium type info lookup for mingw targets

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added subscribers: Sanitizers, dberris. Herald added a project: Sanitizers. mstorsjo requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90571 Files: compiler-rt/lib/ubsan/ubsa

[PATCH] D90568: [clang] Add [is|set]Nested methods to NamespaceDecl

njames93 created this revision. njames93 added a reviewer: rsmith. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. njames93 requested review of this revision. Adds support for NamespaceDecl to inform if its part of a nested namespace.

[PATCH] D90535: [clang-tidy] Allow -warnings-as-errors to be specified from run_clang_tidy.py

schaerfo added a comment. In D90535#2366731 , @njames93 wrote: > Just a general drive by comment, there have been quite a few patches recently > that add arguments that just get forwarded straight to clang-tidy, would it > not be a whole lot simpler if w

[PATCH] D90535: [clang-tidy] Allow -warnings-as-errors to be specified from run_clang_tidy.py

schaerfo updated this revision to Diff 302152. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90535/new/ https://reviews.llvm.org/D90535 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py ==

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

njames93 added a comment. In D61989#2314544 , @collinjackson wrote: > Are there any updates on this change? I see there's a comment that hasn't > been addressed yet. Is that the only roadblock stopping this from getting > merged? Tbh clang-tidy already

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz added a comment. This change is required to fix testsuite failures as a result of this fix: https://reviews.llvm.org/D90524 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ https://reviews.llvm.org/D90549

[PATCH] D90555: [clangd] Handle duplicate enum constants in PopulateSwitch tweak

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. If an enum has different names fo

[PATCH] D90553: Rename CXXUnresolvedConstructExpr::arg_size for consistency

steveire created this revision. steveire added reviewers: aaron.ballman, ymandel. Herald added subscribers: cfe-commits, martong. Herald added a reviewer: shafik. Herald added a project: clang. steveire requested review of this revision. Make it possible to use argumentCountIs and hasArgument with

[PATCH] D90534: [clang-format] Add new option PenaltyIndentedWhitespace

mnauw updated this revision to Diff 302144. mnauw added a comment. Patch updated to include unit test and documentation changes (and to use full diff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90534/new/ https://reviews.llvm.org/D90534 Files

[PATCH] D90552: [clangd] Set the User option for clang-tidy to mimick its behaviour

njames93 created this revision. njames93 added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. njames93 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Probably not essential as afaik o

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz updated this revision to Diff 302142. glaubitz retitled this revision from "[Driver] Fix search paths on x32" to "[Driver] Fix architecture triplets and search paths for Linux x32". glaubitz edited the summary of this revision. glaubitz added reviewers: chandlerc, rengolin. glaubitz added

[PATCH] D90531: [clangd][WIP] Start implementing clang-tidy options into clangd config

njames93 updated this revision to Diff 302141. njames93 added a comment. Added unittests for reading and compiling config and fixed the bugs causing said unittests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90531/new/ https://reviews.l

[PATCH] D87563: [Sema] Improve overload resolution

Mordante updated this revision to Diff 302140. Mordante added a comment. - No longer store the `InitListExpr` instead store the size difference between the array and initializer list. - Removed the dead code for P0388. - Don't add overloads where the initializer list has more elements than the

[PATCH] D87563: [Sema] Improve overload resolution

Mordante added inline comments. Comment at: clang/include/clang/Sema/Overload.h:548-549 + +/// The std::initializer_list expression to convert from. +const InitListExpr *StandardInitializerListFrom{nullptr}; + rsmith wrote: > Storing the `IntListExpr` her

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302139. glaubitz added a comment. The previous patch accidentally missed the necessary files changes in Inputs/debian_multiarch_tree, let's hope this one is correct now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302133. glaubitz edited the summary of this revision. glaubitz added a comment. Update the patch to include the linux-header-search.cpp tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90549/new/ h

[PATCH] D90533: [clang-format] Always consider option PenaltyBreakBeforeFirstCallParameter

mnauw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4481 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; + Style.PenaltyBreakBeforeFirstCallParameter = 0; Style.AlignOperands = FormatStyle::OAS_DontAlign; MyDeveloperDay

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz updated this revision to Diff 302131. glaubitz edited the summary of this revision. glaubitz added a comment. Update commit comment to reflect the rename of CHECK-DEBIAN-SPARC32 to CHECK-DEBIAN-SPARC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. The tests are fixed by this change: https://reviews.llvm.org/D90549. The tests CHECK-DEBIAN-SPARC32 is outdated and does not reflect the fact that sparc and sparc64 use MultiArch on Debian as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D90549: [Driver] Switch CHECK-DEBIAN-SPARC tests to use debian_multiarch_tree

glaubitz created this revision. glaubitz added reviewers: chandlerc, rengolin. Herald added subscribers: cfe-commits, steven.zhang, pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: clang. glaubitz requested review of this revision. Both sparc and sparc64 are using the MultiArch m