[PATCH] D90507: Adding DWARF64 clang flag

ikudrin added a comment. 1. The patch needs tests to check the added functionality. 2. DWARF64 can be generated only for a limited number of targets. There should be diagnostics for invalid switch combinations to prevent misuse. @MaskRay mentioned that in the patch for `llc`, D87011#2254749

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

pengfei accepted this revision. pengfei added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822 ___ cfe-commits mailing list

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG247c5b5d6963: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size (authored by MaskRay). Repository: rG LLVM Github

[clang] 247c5b5 - [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

Author: Fangrui Song Date: 2020-11-05T20:08:23-08:00 New Revision: 247c5b5d69631c9f5fce9bf914f09f84e5cf8232 URL: https://github.com/llvm/llvm-project/commit/247c5b5d69631c9f5fce9bf914f09f84e5cf8232 DIFF: https://github.com/llvm/llvm-project/commit/247c5b5d69631c9f5fce9bf914f09f84e5cf8232.diff

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2377883 , @rsmith wrote: > Perhaps we could address both the UB and the debug info homing issue by > adding a new attribute on the libc++ types that says it's valid to create an > instance of the type without calling

[PATCH] D90754: [analyzer][NFCi] Mark CallEvent::getOriginExpr virtual, some cleanup

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90754/new/ https://reviews.llvm.org/D90754

[PATCH] D52957: [analyzer] Teach CallEvent about C++17 aligned new.

NoQ added a comment. Everything looks good to me here. The new-expression `new int;` has 1 implicit argument (allocation size passed to the implementation of operator new, the value is probably 4) and 0 placement arguments (the ones that are explicitly written down after `new` and before

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rsmith added a comment. Perhaps we could address both the UB and the debug info homing issue by adding a new attribute on the libc++ types that says it's valid to create an instance of the type without calling a constructor? (If we want to support old libc++ with trunk clang, we could detect

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/test/Sema/vecshift.c:3-4 +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify=expected,vecelemsize %s +// RUN: %clang_cc1 -fsyntax-only -DERR -verify %s -Wno-vec-elem-size +// RUN:

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303310. MaskRay added a comment. Fix vecshift.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie added inline comments. Comment at: clang/test/Sema/vecshift.c:3-4 +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify=expected,vecelemsize %s +// RUN: %clang_cc1 -fsyntax-only -DERR -verify %s -Wno-vec-elem-size +// RUN: %clang_cc1 -fsyntax-only -DEXT -DERR -verify %s

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added a comment. D90896 is the alternative solution that doesn't add any new enumeration values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194

[PATCH] D90896: [Clang][Driver] default to nossp

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, rnk. Herald added subscribers: cfe-commits, jdoerfert, atanasyan, jrtc27, kbarton, nemanjai. Herald added a project: clang. nickdesaulniers requested review of this revision. This patch does 2 things: 1. the default

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303303. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[clang] c67656b - Revert "Allow searching for prebuilt implicit modules."

Author: Stella Stamenova Date: 2020-11-05T17:16:14-08:00 New Revision: c67656b994c87224e0b33e2c4b09093986a5cfa6 URL: https://github.com/llvm/llvm-project/commit/c67656b994c87224e0b33e2c4b09093986a5cfa6 DIFF:

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. In D90719#2377485 , @dblaikie wrote: > In D90719#2377324 , @rnk wrote: > >> I had another thought, which is that even if it is UB, perhaps we really >> shouldn't be using UB as the basis

[clang] 4fcdfc4 - [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

Author: Stanislav Mekhanoshin Date: 2020-11-05T16:29:16-08:00 New Revision: 4fcdfc4398bdf9295cd0259d6416a7dc1d2da47f URL: https://github.com/llvm/llvm-project/commit/4fcdfc4398bdf9295cd0259d6416a7dc1d2da47f DIFF:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

Bigcheese accepted this revision. Bigcheese added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 23c6d15 - [amdgpu] Add `llvm.amdgcn.endpgm` support.

Author: Michael Liao Date: 2020-11-05T19:06:50-05:00 New Revision: 23c6d1501d80073784cab367d30d50419ffa5706 URL: https://github.com/llvm/llvm-project/commit/23c6d1501d80073784cab367d30d50419ffa5706 DIFF: https://github.com/llvm/llvm-project/commit/23c6d1501d80073784cab367d30d50419ffa5706.diff

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23c6d1501d80: [amdgpu] Add `llvm.amdgcn.endpgm` support. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers added a comment. In D90194#2377337 , @rnk wrote: > Given that only three tests fail when the `nossp` attribute gets added from > `-cc1` with no stack protector, I think it's reasonable to add it and skip > adding the extra enum. Sorry,

[PATCH] D68997: Allow searching for prebuilt implicit modules.

stella.stamenova added a comment. This change broke the windows lldb bot: http://lab.llvm.org:8011/#/builders/83/builds/570 Can you please fix this or revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303277. MaskRay added a comment. Discard an unintentional change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay updated this revision to Diff 303273. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90874/new/ https://reviews.llvm.org/D90874 Files: clang/test/Modules/diagnose-missing-import.m

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay added inline comments. Comment at: clang/test/Sema/implicit-decl.c:2 +// RUN: %clang_cc1 %s -verify=expected,implicit -fsyntax-only -Werror=implicit-function-declaration +// RUN: %clang_cc1 %s -verify -fsyntax-only -Wno-implicit-function-declaration +

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 303272. Xiangling_L added a comment. Remove unused function parameters; Move testcases to CodeGenCXX folder; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D90767: Add new matchers for dependent names in templates

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2859 +AST_MATCHER_P(CXXDependentScopeMemberExpr, hasMemberName, std::string, N) { + return Node.getMember().getAsString() == N; +} aaron.ballman wrote: > This will allow

[PATCH] D90767: Add new matchers for dependent names in templates

steveire updated this revision to Diff 303271. steveire marked an inline comment as done. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90767/new/ https://reviews.llvm.org/D90767 Files:

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:506 +if (const auto *CTSD = Node.get()) { + auto SK = CTSD->getSpecializationKind(); + if (SK == TSK_ExplicitInstantiationDeclaration || aaron.ballman wrote: >

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

dblaikie added a comment. Thanks for taking a look at this! Comment at: clang/test/Sema/implicit-decl.c:2 +// RUN: %clang_cc1 %s -verify=expected,implicit -fsyntax-only -Werror=implicit-function-declaration +// RUN: %clang_cc1 %s -verify -fsyntax-only

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, yusra.syeda, aaron.ballman, sfertile, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. Xiangling_L requested review of this revision. Support

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

compnerd added a comment. @thakis, thanks for the heads up, I've disabled the test on Windows - I should've disabled it on Windows in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88859/new/ https://reviews.llvm.org/D88859

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang/unittests/AST/ASTTraverserTest.cpp:1092 + +// Explicit instantiation of template functions do not appear in the AST +template float timesTwo(float); aaron.ballman wrote:

[PATCH] D90763: Traverse-ignore explicit template instantiations

steveire updated this revision to Diff 303268. steveire added a comment. Uppate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90763/new/ https://reviews.llvm.org/D90763 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D90891: [clang] ns_error_domain attribute also supports CFString typed variables

arphaman created this revision. arphaman added reviewers: erik.pilkington, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The change in a5b8757506b07e3091fe243b6c1e004220d3cba3

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Avoid requiring an actual MemoryBuffer in ComputePreambleBounds, when a MemoryBufferRef will do just fine.

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2377324 , @rnk wrote: > I had another thought, which is that even if it is UB, perhaps we really > shouldn't be using UB as the basis for debug info emission. All programs have > bugs, and most bugs invoke some form

[PATCH] D90889: Remove RemappedFiles param from ASTUnit::LoadFromASTFile, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. This parameter is always set to `None`. Remove it. https://reviews.llvm.org/D90889 Files:

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2377231 , @mibintc wrote: > I'm sorry, I don't see how to build up an identifier with an arbitrary number > of characters using the token pasting, for example an ident with 4095 > characters is not a power of 2. I

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:1135-1141 // Ensure that Clang has a FileManager with the right VFS, which may have // changed above in AddImplicitPreamble. If VFS is nullptr, rely on // createFileManager to create one.

[PATCH] D90888: Frontend: Remove redundant call to CompilerInstance::setFileManager, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. `ASTUnit::Parse` sets up the `FileManager` earlier in the same function, ensuring `ASTUnit::getFileManager()` matches

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. As part of reducing use of PreprocessorOptions::RemappedFileBuffers, stop abusing it to pass information around remapped files

[PATCH] D90885: Tooling: Remove dead code for ToolingInvocation::mapVirtualFile

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Follows through on c4cb3b10dc8c50e46c9fb1b7ae95e3c3c94975d3's FIXME from 2015. Anyone using this should migrate to

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added a comment. Having looked a bit more at the callers here, I think the pattern we're going to want is: - everywhere that prints a template argument list also asks for a list of corresponding template parameters - if the list of template parameters is unknown (perhaps because the

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem added a comment. I don't have commit access. @jdoerfert, please commit the change if you think it's ready. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 ___ cfe-commits mailing

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D90809#2377221 , @hliao wrote: > In D90809#2377083 , @rampitec wrote: > >> In D90809#2376994

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

dreachem updated this revision to Diff 303258. dreachem added a comment. Marking the "begin/end declare variant" feature as 'done' in the 5.1 table. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90802/new/ https://reviews.llvm.org/D90802 Files: clang/docs/OpenMPSupport.rst Index:

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

rnk added a comment. Given that only three tests fail when the `nossp` attribute gets added from `-cc1` with no stack protector, I think it's reasonable to add it and skip adding the extra enum. I think it would be weird if we LTO'd together three kinds of objects (sp on, sp off, sp

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

jdoerfert added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1242 +def int_ubsantrap : Intrinsic<[], [llvm_i8_ty], + [IntrNoReturn, IntrCold, ImmArg>]>; should this be readonly and inaccesiblememonly? CHANGES

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

rnk added a comment. Why does `-cc1` need to distinguish between enabled, disabled, unset? The design philosophy is that the driver figures out all the target-specific configuration stuff, and then tells cc1 which features to enable. See, for example, -fexceptions, which is off by default in

[PATCH] D90802: [OpenMP] [DOCS] Update OMP5.1 feature status table [NFC]

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/OpenMPSupport.rst:343

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

rnk added a comment. I had another thought, which is that even if it is UB, perhaps we really shouldn't be using UB as the basis for debug info emission. All programs have bugs, and most bugs invoke some form of UB. If we don't provide sufficient info when UB is involved, it can become harder

[PATCH] D68997: Allow searching for prebuilt implicit modules.

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3382 } +if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) + CmdArgs.push_back("-fprebuilt-implicit-modules"); You need to use a fno_ flag as 2nd param

[clang] e551578 - APINotes: repair the Windows builders

Author: Saleem Abdulrasool Date: 2020-11-05T21:25:52Z New Revision: e55157874cf20acef55ca20a87699bf77b7cfd3a URL: https://github.com/llvm/llvm-project/commit/e55157874cf20acef55ca20a87699bf77b7cfd3a DIFF: https://github.com/llvm/llvm-project/commit/e55157874cf20acef55ca20a87699bf77b7cfd3a.diff

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

scanon added a comment. I do not much like faststd, as there's nothing "standard" about it. I do not, however, have a better suggestion off the top of my head. Let's pause and consider the name a little bit longer, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

mibintc added a comment. I'm sorry, I don't see how to build up an identifier with an arbitrary number of characters using the token pasting, for example an ident with 4095 characters is not a power of 2. I tried pasting together X2048 X1024 X512 etc but that doesn't work fu.cpp:12:18: error:

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added a comment. In D90809#2377083 , @rampitec wrote: > In D90809#2376994 , @b-sumner wrote: > >> Should this also be IntrConvergent? > > Probably yes... This is

[PATCH] D68997: Allow searching for prebuilt implicit modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e108cd86e7: Allow searching for prebuilt implicit modules. (authored by arames). Changed prior to commit:

[clang] 71e108c - Allow searching for prebuilt implicit modules.

Author: Alexandre Rames Date: 2020-11-05T13:10:53-08:00 New Revision: 71e108cd86e70b06c5fa3a63689dcb3555c3d13f URL: https://github.com/llvm/llvm-project/commit/71e108cd86e70b06c5fa3a63689dcb3555c3d13f DIFF:

[clang] d2e7dca - [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

Author: Jan Ole Hüser Date: 2020-11-05T12:57:17-08:00 New Revision: d2e7dca5ca92c655e451d6fcb806df38d7f2d56b URL: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b DIFF: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b.diff

[PATCH] D90630: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e7dca5ca92: [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C… (authored by j0le, committed by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90763: Traverse-ignore explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:503 TraversalKind Traversal, BindKind Bind) { +auto ScopedTraversal = TraversingTemplateInstantiationNotSpelledInSource; + Please spell this

[PATCH] D90835: [RFC][clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:249-251 + if (!HeaderFilter) +HeaderFilter = +std::make_unique(*getOptions().HeaderFilterRegex); This should also check if the Optional has a

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG1af037f643fc: [PowerPC] Correct cpsgns behaviour on PowerPC to match that of the ABI (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1af037f - [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Author: Albion Fung Date: 2020-11-05T15:35:14-05:00 New Revision: 1af037f643fc5499f83d92e5aec199950871d475 URL: https://github.com/llvm/llvm-project/commit/1af037f643fc5499f83d92e5aec199950871d475 DIFF: https://github.com/llvm/llvm-project/commit/1af037f643fc5499f83d92e5aec199950871d475.diff

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

Yes, that's right. I think most errors are caught in Sema. There "if there is an error, the output should be suppressed" should be a consensus. For some auxiliary files it was a bit fuzzy to me. So I checked .dwo which is a similar auxiliary output - the output is suppressed with an error - so it

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames marked an inline comment as done. arames added a comment. Fixed the trailing whitespace. I also just got commit rights, so I will commit it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added a comment. In D90809#2376994 , @b-sumner wrote: > Should this also be IntrConvergent? Probably yes... This is control flow after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/

[PATCH] D90874: [test] Properly test -Werror-implicit-function-declaration and -Wvec-elem-size

MaskRay created this revision. MaskRay added a reviewer: dblaikie. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90874 Files:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D90329: [PowerPC] Fix va_arg in Objective-C on 32-bit ELF targets

kernigh added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4723 + bool isInt = Ty->isIntegerType() || Ty->hasPointerRepresentation() || + Ty->isAggregateType(); bool isF64 = Ty->isFloatingType() && getContext().getTypeSize(Ty) == 64;

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

On Wed, Nov 4, 2020 at 9:07 PM Fāng-ruì Sòng wrote: > > It is rare to report an error in BackendUtil.cpp . So I checked the > other Diags.Report instance and noticed that -split-dwarf-file a.dwo > -split-dwarf-output a.dwo (when a.dwo is not writable) suppresses the > output. So there is no

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

b-sumner added a comment. Should this also be IntrConvergent? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 ___ cfe-commits mailing list

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

thakis added a comment. Looks like the test doesn't pass on Windows: http://45.33.8.238/win/27342/step_7.txt Please take a look, and revert if it takes a while to fix. Here's the output of the diff on that Win bot: thakis@thakis6-w MINGW64 /c/src/llvm-project (merge) $ diff

[PATCH] D90871: [Sema] Fold VLAs to constant arrays in a few more contexts

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. D89523 removed support for promoting VLAs to constant arrays when

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>;

[clang-tools-extra] 3b9b90a - [clang-tidy] Extend IdentifierNamingCheck per file config

Author: Nathan James Date: 2020-11-05T19:51:05Z New Revision: 3b9b90a1914f1e470ba7d333b26bd34787337806 URL: https://github.com/llvm/llvm-project/commit/3b9b90a1914f1e470ba7d333b26bd34787337806 DIFF: https://github.com/llvm/llvm-project/commit/3b9b90a1914f1e470ba7d333b26bd34787337806.diff LOG:

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9b90a1914f: [clang-tidy] Extend IdentifierNamingCheck per file config (authored by njames93). Changed prior to commit:

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

hliao updated this revision to Diff 303213. hliao added a comment. Add `IntrCold`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/ https://reviews.llvm.org/D90809 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def

[PATCH] D90767: Add new matchers for dependent names in templates

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2838 +/// Matches template-dependent, but known, member names +/// Missing full stop at the end of the comment. Comment at:

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Okay. It sounds like strict compatibility with GCC implies ignoring pragmas in fast, and that's what we're most concerned with, since this is originally a GCC option. So the only question I have now is whether `faststd` is the best name for this. Does anyone want

[PATCH] D90507: Adding DWARF64 clang flag

ayermolo updated this revision to Diff 303209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2376667 , @rnk wrote: > lgtm > > I think the test case looks good as is, FWIW. Token pasting might make it > more readable, but it's improving the existing test, and not necessarily in > scope for this patch. Oh,

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

aeubanks updated this revision to Diff 303207. aeubanks added a comment. small cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90870/new/ https://reviews.llvm.org/D90870 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as done. gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: >

[PATCH] D90870: [NFC][NewPM] Reuse PassBuilder callbacks with -O0

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks requested review of this revision. This removes lots of duplicated code which was necessary before https://reviews.llvm.org/D89158. Mostly sanitizer stuff. Repository: rG LLVM

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some tiny nits! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:172 SmallString<64> StyleString; + auto

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

dblaikie added a comment. In D90714#2375911 , @mibintc wrote: > In D90714#2374913 , @dblaikie wrote: > >> Since the same code is used to mangle all these things, probably just test >> one of them? >> >> Could use

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 303200. gulfem added a comment. Remove direct from description and ObjCMethod for Obj functionality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files:

[PATCH] D90832: [clang-tidy] Extend IdentifierNamingCheck per file config

njames93 updated this revision to Diff 303198. njames93 added a comment. Herald added a subscriber: aheejin. Removed unnecessary formatting changes Added test cases. With the test cases I removed some cases that actually were never tested due to the order in which clang-tidy handles applying

[clang] b69af88 - [gn build] (manually) port 82f86ae01

Author: Nico Weber Date: 2020-11-05T14:11:26-05:00 New Revision: b69af88481aa88e04ff4490dc8d420ec570ec0f1 URL: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1 DIFF: https://github.com/llvm/llvm-project/commit/b69af88481aa88e04ff4490dc8d420ec570ec0f1.diff

[PATCH] D88859: APINotes: add APINotesYAMLCompiler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82f86ae01a54: APINotes: add APINotesYAMLCompiler (authored by compnerd). Changed prior to commit:

[clang] 82f86ae - APINotes: add APINotesYAMLCompiler

Author: Saleem Abdulrasool Date: 2020-11-05T18:55:13Z New Revision: 82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba URL: https://github.com/llvm/llvm-project/commit/82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba DIFF: https://github.com/llvm/llvm-project/commit/82f86ae01a54ff8e3a5aaefd24745ef2b7b917ba.diff

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

dblaikie added a comment. How's this compare to the similar checks for variable templates? Is there some code/checking we could share here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

dblaikie added a comment. In D90719#2376388 , @rnk wrote: > In D90719#2372656 , @dblaikie wrote: > >> My understanding is that such code is UB, is that right? > > I guess I'm not convinced it's UB, and need some

[PATCH] D90714: [clang]Fix length threshold for MicrosoftMangle md5 hash

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I think the test case looks good as is, FWIW. Token pasting might make it more readable, but it's improving the existing test, and not necessarily in scope for this patch. Repository: rG

[clang] c6a384d - [Sema] Special case -Werror-implicit-function-declaration and reject other -Werror-

Author: Fangrui Song Date: 2020-11-05T10:25:30-08:00 New Revision: c6a384df1f8ab85815160297543ab329e02560ef URL: https://github.com/llvm/llvm-project/commit/c6a384df1f8ab85815160297543ab329e02560ef DIFF: https://github.com/llvm/llvm-project/commit/c6a384df1f8ab85815160297543ab329e02560ef.diff

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; Mayby also IntrCold? Repository:

[PATCH] D90822: [X86] use macros to split GFNI intrinsics into different kinds

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90822/new/ https://reviews.llvm.org/D90822

  1   2   >