[PATCH] D90457: [clang][driver] Set LTO mode based on input files

MaskRay added a comment. Is the motivation just to avoid -flto or -flto=lto at link time? I am afraid that the advantage probably is not large enough to justify the potentially costly object file parsing in the driver. Before this, as I understand it, object files are opaque to the driver. The

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 added inline comments. Comment at: clang/lib/AST/Stmt.cpp:801 +// since we don't support masm style prefix in backend. +if (Instruction.startswith("vex ")) + MSAsmString += '{' + Instruction.substr(0, 3).str() + '}' + From X86AsmParser, the

[PATCH] D90441: [X86] Add support for vex, vex2, vex3, and evex for MASM

LiuChen3 updated this revision to Diff 304730. LiuChen3 added a comment. Rebase. Adding the '{}' to prefix when generate IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90441/new/ https://reviews.llvm.org/D90441 Files: clang/lib/AST/Stmt.cpp

[PATCH] D71880: [clangd] Implement Decl canonicalization rules for rename

kbobyrev updated this revision to Diff 304729. kbobyrev added a comment. Use early return in FieldDecl canonicalization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71880/new/ https://reviews.llvm.org/D71880 Files: clang-tools-extra/clangd/ref

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

zinovy.nis updated this revision to Diff 304719. zinovy.nis added a comment. Fixed fix-it section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91037/new/ https://reviews.llvm.org/D91037 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp clang-tools-ex

[PATCH] D91243: [NFC][Coroutines] Remove unused `IsImplicit` argument in maybeTailCall

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd89c4dbdd3a: [NFC][coroutines] remove unused argument in SemaCoroutine (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[clang] cd89c4d - [NFC][coroutines] remove unused argument in SemaCoroutine

Author: Chuanqi Xu Date: 2020-11-12T13:22:20+08:00 New Revision: cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e URL: https://github.com/llvm/llvm-project/commit/cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e DIFF: https://github.com/llvm/llvm-project/commit/cd89c4dbdd3a32749f85cb3ac666b1e9e43e9c0e.diff LO

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gulfem wrote: > > aaron.ballman wrote: > >

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke updated this revision to Diff 304703. LuoYuanke added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 Files: clang/include/clang/Basic/BuiltinsX86_64.def clang/lib/Headers/a

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11. Herald added subscribers: llvm-commits, ributzka, hiraditya. Herald added a project: LLVM. dexonsmith requested review of this revision. Add an overload of `RedirectingFileSystem::create` that builds a redire

[clang] 2d4035e - Fix structural comparison of template template arguments to compare the

Author: Richard Smith Date: 2020-11-11T19:15:21-08:00 New Revision: 2d4035e493e3933e8819ee090a66fd6db3cbd8ef URL: https://github.com/llvm/llvm-project/commit/2d4035e493e3933e8819ee090a66fd6db3cbd8ef DIFF: https://github.com/llvm/llvm-project/commit/2d4035e493e3933e8819ee090a66fd6db3cbd8ef.diff

[PATCH] D87981: [X86] AMX programming model prototype.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:101 + unsigned SubIdx = (BitSize == 8) ? X86::sub_8bit : X86::sub_16bit; + unsigned Opc = (BitSize == 8) ? X86::MOV8mr : X86::MOV16mr; + MachineInstr *NewMI = LuoYuanke wrote: >

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90887/new/ https://reviews.llvm.org/D90887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2abc336 - [PowerPC] [Clang] Define macros to identify quad-fp semantics

Author: Qiu Chaofan Date: 2020-11-12T10:26:13+08:00 New Revision: 2abc33683b2b702c00c366d56c6285fda6d1e436 URL: https://github.com/llvm/llvm-project/commit/2abc33683b2b702c00c366d56c6285fda6d1e436 DIFF: https://github.com/llvm/llvm-project/commit/2abc33683b2b702c00c366d56c6285fda6d1e436.diff L

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rG2abc33683b2b: [PowerPC] [Clang] Define macros to identify quad-fp semantics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ ht

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90484/new/ https://reviews.llvm.org/D90484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D91315: [RISCV] Handle zfh in the arch string.

HsiangKai created this revision. HsiangKai added reviewers: craig.scott, asb, kito-cheng, luismarques, Jim. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, lenary, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rog

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. In D90042#2368219 , @aaron.ballman wrote: > In D90042#2360042 , @flx wrote: > >> In D90042#2357078 , @aaron.ballman >> wrote: >> >>> In D90042#2356265

[PATCH] D86217: rename sram-ecc as sramecc in clang

yaxunl added a comment. Herald added a subscriber: dexonsmith. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86217/new/ https://reviews.llvm.org/D86217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D91311: Add new 'preferred_name' attribute.

rsmith created this revision. rsmith added reviewers: aaron.ballman, EricWF. Herald added a subscriber: jdoerfert. Herald added projects: clang, libc++. Herald added a reviewer: libc++. rsmith requested review of this revision. This attribute permits a typedef to be associated with a class templat

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

shchenz added a comment. Using dform with offset 0 can save one register r0/X0, this is benefit for register allocation? But adding it in `PPCPreEmitPeephole` pass which is after register allocation will make the benefit gone. Maybe we need to do it before register allocation? For example at the

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

yaxunl created this revision. yaxunl added a reviewer: kzhuravl. Herald added subscribers: dang, kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely. yaxunl requested review of this revision. Herald added a subscriber: wdng. Add option -mcode-object-version=n to control code object version for AMDG

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. This make sense to me, thank you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 ___ cfe-comm

[PATCH] D91277: [Syntax] Tablegen literal expressions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1630e50874a9: [Syntax] Tablegen literal expressions. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 1630e50 - [Syntax] Tablegen literal expressions.

Author: Sam McCall Date: 2020-11-12T01:26:02+01:00 New Revision: 1630e50874a9ab6dae778bbdbb30d7dff6ade164 URL: https://github.com/llvm/llvm-project/commit/1630e50874a9ab6dae778bbdbb30d7dff6ade164 DIFF: https://github.com/llvm/llvm-project/commit/1630e50874a9ab6dae778bbdbb30d7dff6ade164.diff LO

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. Thanks for working on this! I think the scope of this patch is probably bigger than we need, at least initially: - it adds a new TidyProvider system with a lot of flexibility. But our config needs are quite static. The only flexibility we need initially is being able

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

ilinpv marked 10 inline comments as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15653 +// http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p0493r1.pdf +// (2) low level libgcc and compiler-rt support implemented

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

amyk added a comment. Please also address the clang-format comment. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:417 + + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXV

[PATCH] D91303: Simplify implementation of container-size-empty

steveire created this revision. steveire added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. Use IgnoreUnlessSpelledInSource to make the matcher code smaller and more visibly-related to the code. Repository:

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire created this revision. steveire added a reviewer: alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. steveire requested review of this revision. readability-container-size-empty currently modifies source code based on AST nodes in template instantiations, which

[clang] b6ccff3 - [NewPM] Provide method to run all pipeline callbacks, used for -O0

Author: Arthur Eubanks Date: 2020-11-11T15:10:27-08:00 New Revision: b6ccff3d5f3b8e26439c7471f433cb16eaf66863 URL: https://github.com/llvm/llvm-project/commit/b6ccff3d5f3b8e26439c7471f433cb16eaf66863 DIFF: https://github.com/llvm/llvm-project/commit/b6ccff3d5f3b8e26439c7471f433cb16eaf66863.diff

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ccff3d5f3b: [NewPM] Provide method to run all pipeline callbacks, used for -O0 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[clang] e7f3e21 - Suppress printing template arguments that match default template

Author: Richard Smith Date: 2020-11-11T15:05:51-08:00 New Revision: e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 URL: https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8 DIFF: https://github.com/llvm/llvm-project/commit/e7f3e2103cdb567dda4fd52f81bf4bc07179f5a8.diff

[clang] 5f12f4f - Suppress printing of inline namespace names in diagnostics by default,

Author: Richard Smith Date: 2020-11-11T15:05:51-08:00 New Revision: 5f12f4ff9078455cad9d4806da01f570553a5bf9 URL: https://github.com/llvm/llvm-project/commit/5f12f4ff9078455cad9d4806da01f570553a5bf9 DIFF: https://github.com/llvm/llvm-project/commit/5f12f4ff9078455cad9d4806da01f570553a5bf9.diff

[clang-tools-extra] 686d8a0 - [clangd] Add index server request logging

Author: Sam McCall Date: 2020-11-11T23:58:18+01:00 New Revision: 686d8a0911de7d9b13617c5aef66f6cebde05d5b URL: https://github.com/llvm/llvm-project/commit/686d8a0911de7d9b13617c5aef66f6cebde05d5b DIFF: https://github.com/llvm/llvm-project/commit/686d8a0911de7d9b13617c5aef66f6cebde05d5b.diff LO

[PATCH] D90654: [clangd] Add index server request logging

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG686d8a0911de: [clangd] Add index server request logging (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D90654?vs=30242

[PATCH] D90654: [clangd] Add index server request logging

sammccall marked 5 inline comments as done. sammccall added a comment. Oops, took a while to get back to this. Planning to land this with some style unaddressed (%/S, --input-file) but please do LMK if they're important and I'll fix. Comment at: clang-tools-extra/clangd/test/r

[PATCH] D91200: [PowerPC] Prevent the use of MMA with P9 and earlier

bsaleil updated this revision to Diff 304662. bsaleil added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91200/new/ https://reviews.llvm.org/D91200 Files: clang/lib/Basic/Targets/PPC.cpp clang/test/Driver/ppc-mma-suppo

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. In D89158#2389520 , @aeubanks wrote: > Thanks, I wasn't aware of this. Looks like other `opt -passes='default'` > tests also look at if it pres

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 304657. aeubanks added a comment. forgot to amend commit with test updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D90890: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c55c3b66dea: Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4c55c3b - Frontend: Change ComputePreambleBounds to take MemoryBufferRef, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-11T17:19:51-05:00 New Revision: 4c55c3b66dea3a1d6058392e1e96e166d318a2ff URL: https://github.com/llvm/llvm-project/commit/4c55c3b66dea3a1d6058392e1e96e166d318a2ff DIFF: https://github.com/llvm/llvm-project/commit/4c55c3b66dea3a1d6058392e1e96e166d318

[PATCH] D91299: [clangd] Also detect corrupt stri table size.

sammccall added a comment. (going to wait for a while for the other patch to get through the buildbots, in case rlimit causes trouble) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91299/new/ https://reviews.llvm.org/D91299 __

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

dexonsmith accepted this revision. dexonsmith added 1 blocking reviewer(s): arphaman. dexonsmith added a comment. This LGTM, but I'd like @arphaman to look as well in case he originally tried `getPhysicalFileSystem` and it caused a problem. I've switched him to a blocking reviewer. CHANGES SIN

[clang-tools-extra] 3c09103 - [clangd] Sanity-check array sizes read from disk before allocating them.

Author: Sam McCall Date: 2020-11-11T23:16:53+01:00 New Revision: 3c09103291686630564c1ff3f78c0f8dc69d069f URL: https://github.com/llvm/llvm-project/commit/3c09103291686630564c1ff3f78c0f8dc69d069f DIFF: https://github.com/llvm/llvm-project/commit/3c09103291686630564c1ff3f78c0f8dc69d069f.diff LO

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c0910329168: [clangd] Sanity-check array sizes read from disk before allocating them. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D91300: WIP: Frontend: Use an InMemoryFileSystem for the RemappedFiles parameter in ASTUnit

dexonsmith added a subscriber: kadircet. dexonsmith added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:571-579 +if (OverriddenFilesFS) { + std::unique_ptr Buffer; + if (moveOnNoError(OverriddenFilesFS->getBufferForFile(F.first()), +

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304648. saudi added a comment. Simplified the `RealFS` initialization, as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

dexonsmith added inline comments. Comment at: clang/test/ClangScanDeps/relative_directory.cpp:12-13 + +// The output order is non-deterministic when using more than one thread, +// so check the output using two runs. +// RUN: clang-scan-deps -compilation-database %t.cdb -j 2 | Fi

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:158-160 + llvm::IntrusiveRefCntPtr PhysicalFileSystem( + llvm::vfs::createPhysicalFileSystem().release()); + RealFS = new llvm::vfs::ProxyFileSystem(PhysicalFil

[PATCH] D89980: [hip] Remove the coercion on aggregate kernel arguments.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89980/new/ https://reviews.llvm.org/D89980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D91300: WIP: Frontend: Use an InMemoryFileSystem for the RemappedFiles parameter in ASTUnit

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Re-implement the `RemappedFiles` parameter to various `ASTUnit` entry points by storing buffers in an `In

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91258/new/ https://reviews.llvm.org/D91258

[PATCH] D91299: [clangd] Also detect corrupt stri table size.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:209 +// Theoretical max ratio from https://zlib.net/zlib_tech.html +constexpr int MaxCompressionR

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

aganea added a comment. In D83025#2389486 , @hokein wrote: > In D83025#2389140 , @aganea wrote: > >> We're seeing the same issue mentionned in PR45498 >> , but with the

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d5daed1997d: [Matrix] Update mangling to use paramterized vendor ext type syntax. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANG

[clang] 1d5daed - [Matrix] Update mangling to use paramterized vendor ext type syntax.

Author: Florian Hahn Date: 2020-11-11T21:39:22Z New Revision: 1d5daed1997d2fc1fbb6fd19156518bde93d1034 URL: https://github.com/llvm/llvm-project/commit/1d5daed1997d2fc1fbb6fd19156518bde93d1034 DIFF: https://github.com/llvm/llvm-project/commit/1d5daed1997d2fc1fbb6fd19156518bde93d1034.diff LOG:

[PATCH] D91299: [clangd] Also detect corrupt stri table size.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo ht

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

asbirlea added a comment. AFAICT all issues were addressed. @Meinersbur: are there any concerns left with this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158

[PATCH] D91298: Frontend: Always create a new FileManager in ASTUnit::CodeComplete

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, arphaman, jansvoboda11, akyrtzi. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. The filesystem underneath it may have changed. This matches other `ASTUnit` entry points like `Reparse`, a

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, arphaman, jansvoboda11. Herald added subscribers: usaxena95, ributzka, kadircet. dexonsmith requested review of this revision. Clarify that `PrecompiledPreamble::CanReuse` requires non-null arguments for `VFS` and `MainFil

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi marked 2 inline comments as not done. saudi added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:158-160 + llvm::IntrusiveRefCntPtr PhysicalFileSystem( + llvm::vfs::createPhysicalFileSystem().release()); + RealFS = new

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, jansvoboda11. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Clarify the logic for using the preamble (and overriding the main file buffer) in `ASTUnit::CodeComplete` by factor

[PATCH] D91295: Frontend: Remove unused parameter from ASTUnit::LoadFromCompilerInvocationAction, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, jansvoboda11. Herald added subscribers: ributzka, arphaman. dexonsmith requested review of this revision. Drop `IncludeBriefCommentsInCodeCompletion` since it is always `false`. https://reviews.llvm.org/D91295 Files:

[PATCH] D91251: [VE] Support vector register in inline asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e0ae20f3b98: [VE] Support vector register in inline asm (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 6e0ae20 - [VE] Support vector register in inline asm

Author: Kazushi (Jam) Marukawa Date: 2020-11-12T06:18:35+09:00 New Revision: 6e0ae20f3b98b7bb5a44ced22c3da42a8fe5dbc8 URL: https://github.com/llvm/llvm-project/commit/6e0ae20f3b98b7bb5a44ced22c3da42a8fe5dbc8 DIFF: https://github.com/llvm/llvm-project/commit/6e0ae20f3b98b7bb5a44ced22c3da42a8fe5d

[PATCH] D90957: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e9af3d47847: Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 4e9af3d - Frontend: Skip namespace around createVFSFromCompilerInvocation definition, NFC

Author: Duncan P. N. Exon Smith Date: 2020-11-11T16:15:06-05:00 New Revision: 4e9af3d47847c68b0ffa8a062ae029702b06214d URL: https://github.com/llvm/llvm-project/commit/4e9af3d47847c68b0ffa8a062ae029702b06214d DIFF: https://github.com/llvm/llvm-project/commit/4e9af3d47847c68b0ffa8a062ae029702b06

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

saudi updated this revision to Diff 304629. saudi added a comment. Removed use of ProxyFileSystem CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91204/new/ https://reviews.llvm.org/D91204 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp clang/test/ClangScanDe

[PATCH] D91047: Add a call super attribute plugin example

aaron.ballman added a comment. I have more review to do on this but have to run for a while and wanted to get you this feedback sooner rather than later. Comment at: clang/docs/ClangPlugins.rst:119 + +Attribute plugin to mark a virtual method as `call_super`, subclasses must

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

dexonsmith added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1066 if (getTriple().getArch() == llvm::Triple::x86_64 || - getTriple().isAArch64() || getTriple().isRISCV()) + (getTriple().isAArch64() && getTriple().isArch64Bit()) || + getTriple().i

[PATCH] D91037: [clang-tidy] Fix crash in bugprone-redundant-branch-condition on ExprWithCleanups

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-redundant-branch-condition.cpp:1092 + // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: redundant condition 'isSet' [bugprone-redundant-branch-condition] + // CHECK-FIXES: {

[PATCH] D91204: [clang-scan-deps] Fix for input file given as relative path in compilation database "command" entry

dexonsmith added a comment. In D91204#2387050 , @saudi wrote: > Updated the patch. > > Followed suggestion from @dexonsmith. Indeed it simplifies the code. > Also, improved the test, to also test with -j 2 A couple of more comments. @arphaman , can you co

[PATCH] D82860: Port ObjCMTAction to new option parsing system

mehdi_amini added a comment. Reverted in f917356f9ce0 ; I suspect a `static constexpr` in a class missing a definition out of class (required pre-c++17). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] f917356 - Revert "[clang][cli] Port ObjCMTAction to new option parsing system"

Author: Mehdi Amini Date: 2020-11-11T20:01:03Z New Revision: f917356f9ce026f9be9972b8c75cd3ba00e43497 URL: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497 DIFF: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497.diff LOG: R

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks added a comment. In D89158#2388991 , @Meinersbur wrote: > Could you try configuring LLVM with `-DLLVM_BYE_LINK_INTO_TOOLS=ON`? I assume > the test will break because it unconditionally adds a FunctionPass. Thanks, I wasn't aware of this. Looks l

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L updated this revision to Diff 304616. Xiangling_L added a comment. Add testcases to both CodeGen and CodeGenCXX folder; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90892/new/ https://reviews.llvm.org/D90892 Files: clang/lib/CodeGen

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

aeubanks updated this revision to Diff 304617. aeubanks added a comment. fix tests when Bye plugin is present Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp cla

[clang-tools-extra] 956c899 - [clangd] Fix serialization error check.

Author: Sam McCall Date: 2020-11-11T20:46:04+01:00 New Revision: 956c899296dc19593c66b06af87e60564dff18e0 URL: https://github.com/llvm/llvm-project/commit/956c899296dc19593c66b06af87e60564dff18e0 DIFF: https://github.com/llvm/llvm-project/commit/956c899296dc19593c66b06af87e60564dff18e0.diff LO

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91253/new/ https://reviews.llvm.org/D91253

[PATCH] D83025: [clang] Include type specifiers in typo correction when checking isCXXDeclarationSpecifiers.

hokein added a comment. In D83025#2389140 , @aganea wrote: > We're seeing the same issue mentionned in PR45498 > , but with the repro below. `git > bisect` points to this patch. Could anyone please possibly co

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:3523 mangleType(T->getElementType()); + Out << "I"; } rjmccall wrote: > Your `I`s and `E`s are backwards. Argh, used different orders for comment

[PATCH] D91253: [Matrix] Update mangling to use paramterized vendor ext type syntax.

fhahn updated this revision to Diff 304605. fhahn added a comment. Update comment and fix I and E order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91253/new/ https://reviews.llvm.org/D91253 Files: clang/lib/AST/ItaniumMangle.cpp clang/test/

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl updated this revision to Diff 304604. yaxunl edited the summary of this revision. yaxunl added a comment. rename faststd to fast-honor-pragmas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 Files: clang/docs/LanguageExtensions.rst cl

[PATCH] D90892: [AIX][FE] Support constructor/destructor attribute

Xiangling_L added a comment. In D90892#2386908 , @aaron.ballman wrote: > I think this generally seems reasonable, but I'm far from an AIX expert so > you should wait a few days in case other reviewers have feedback. Thanks for reviews. And @sfertile has

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

sammccall updated this revision to Diff 304578. sammccall marked 2 inline comments as done. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91258/new/ https://reviews.llvm.org/D91258 Files: clang-tools-e

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dexonsmith added a comment. In D82860#2388916 , @jpienaar wrote: > This seems to breaking clang-5 builds: > > utils/TableGen/CMakeFiles/llvm-tblgen.dir/OptParserEmitter.cpp.o: In function > `llvm::EmitOptParser(llvm::RecordKeeper&, llvm::raw_ostream&)': >

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

rjmccall added a comment. Probably should be pluralized for consistency, `fast-honor-pragmas`, but yeah, that's fine with me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90174/new/ https://reviews.llvm.org/D90174 ___ cfe-commits mailing li

[PATCH] D91103: [tooling] Add support for fixits that indicate code will need reformatting

njames93 updated this revision to Diff 304574. njames93 marked an inline comment as done. njames93 added a comment. Address nit by replacing optional. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91103/new/ https://reviews.llvm.org/D91103 Files:

[PATCH] D90956: [clang][SVE] Activate macro `__ARM_FEATURE_SVE_VECTOR_OPERATORS`.

rsandifo-arm added a comment. The tests look good to me FWIW. The Sema side is already covered by `Sema/attr-arm-sve-vector-bits.c` and the patch seems to test for the important ABI bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90956/new/

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

yaxunl added a comment. In D90174#2389269 , @tra wrote: > In D90174#2387518 , @scanon wrote: > >> Strictly speaking, fp-contract=fast probably should have been a separate >> flag entirely (since there's no _express

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

tra added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91281/new/ https://reviews.llvm.org/D91281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

tra added a comment. In D90174#2387518 , @scanon wrote: > Strictly speaking, fp-contract=fast probably should have been a separate flag > entirely (since there's no _expression_ being contracted in fast). > Unfortunately, that ship has sailed, and it doe

[PATCH] D91258: [clangd] Sanity-check array sizes read from disk before allocating them.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:121 + template + LLVM_NODISCARD bool consumeSize(T &Container, unsigned MinSize = 1) { +auto Size = consumeVar(); kadi

[PATCH] D91262: [AArch64][SVE] Allow C-style casts between fixed-size and scalable vectors

c-rhodes added a comment. @joechrisellis thanks for the patch Joe, I've added a few comments. I also noticed this only covers C++, do we want to test C as well? Comment at: clang/lib/Sema/SemaCast.cpp:-2227 +// Allow bitcasting if either the source or destination is a

  1   2   3   >