[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ added a comment. > if the TCB-based functions are a small subset of the code then this attribute > is better Yes, that's exactly the case. We want most functions to be untrusted by default but also have no restrictions imposed or warnings emitted for them when they do their usual function

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 created this revision. psionic12 added reviewers: john.brawn, aaron.ballman, Tyker. Herald added a project: clang. Herald added a subscriber: cfe-commits. psionic12 requested review of this revision. Make the example compiled and the test case passed. Repository: rG LLVM Github

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

airlied added a comment. this file has never been clang-format clean, happy to make changes if reviewer decides they are needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92004/new/ https://reviews.llvm.org/D92004

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. It looks like `CallHierarchy.IncomingOneFile` in failing on a few of the buildbots (e.g. clang-ppc64be-linux and clang-s390x-linux ), while passing on most of them.

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D91930#2411338 , @kadircet wrote: > Thanks a lot for working on improving clangd! > > Can you also give a high-level overview of what kind of functionality you are > providing here? Looks like there's a lot going on

[PATCH] D91812: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91812/new/ https://reviews.llvm.org/D91812

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2412874 , @venkataramanan.kumar.llvm wrote: > In D88712#2412366 , @MaskRay wrote: > >> In D88712#2411841 , >> @venkataramanan.kumar.llvm

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. In D88712#2412366 , @MaskRay wrote: > In D88712#2411841 , > @venkataramanan.kumar.llvm wrote: > >> > > For your example: > > extern double log (double) asm (""

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

orivej added a comment. Sorry, I don't understand the issue and can't write a better description. Since this test triggers an assert in getCommonPtr that it "Cannot retrieve a NULL type pointer" of Ty->getPointeeType(), the fix just checks that the pointee is not null before using

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

orivej updated this revision to Diff 307239. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92001/new/ https://reviews.llvm.org/D92001 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/ubsan-assume-aligned-crash.c Index: clang/test/CodeGen/ubsan-assume-aligned-crash.c

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

orivej created this revision. orivej added reviewers: lebedev.ri, Tyker, rsmith. orivej added projects: clang, Sanitizers. Herald added a subscriber: cfe-commits. orivej requested review of this revision. Fixes PR45813 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92001

[PATCH] D73156: [clang] Build clang-shlib on mingw

mstorsjo added a comment. This actually is done (almost) like this in current git master, see D87547 and D89225 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73156/new/

[PATCH] D91651: [clang] Add a warning (à la gcc) for too small enum bitfields

faisalv requested review of this revision. faisalv marked 4 inline comments as done. faisalv added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91651/new/ https://reviews.llvm.org/D91651

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) ro wrote: > MaskRay wrote: > > ro wrote: > > > MaskRay wrote: > > > > ro wrote: > > > > > MaskRay

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2fb114475d1: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux (authored by glaubitz, committed by MaskRay). Changed prior to

[clang] c2fb114 - [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

Author: John Paul Adrian Glaubitz Date: 2020-11-23T19:25:36-08:00 New Revision: c2fb114475d15a1d39545f700b8c6d6e18367ca9 URL: https://github.com/llvm/llvm-project/commit/c2fb114475d15a1d39545f700b8c6d6e18367ca9 DIFF:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/Driver/linux-header-search.cpp:266 +// CHECK-DEBIAN-SPARC: "{{[^"]*}}clang{{[^"]*}}" "-cc1" +// CHECK-DEBIAN-SPARC: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" +// CHECK-DEBIAN-SPARC: "-isysroot"

[libunwind] bb13411 - [libunwind] Multiple preprocessor fixes on PowerPC*

Author: Brandon Bergren Date: 2020-11-23T19:07:21-08:00 New Revision: bb1341161478dc589893cda9f808e5f5b859b5ae URL: https://github.com/llvm/llvm-project/commit/bb1341161478dc589893cda9f808e5f5b859b5ae DIFF:

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

rsmith added a comment. I'd suggest instead of removing these warnings, we split the warning flag in two: 1. A warning flag that warns that there is implicit fallthrough that's not equivalent to `break;` (which sounds like it's what the kernel folks want in the 99% case) -- that is, warn if

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

nickdesaulniers added a comment. I'm happy to modify the patch based on feedback from LKML, though switch (x) { case 0: ++x; default: break; } is the important case that's 99% of the differences between GCC and Clang, which should not get removed from this patch.

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

JonChesterfield added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:1344 +FieldDecl *clang::CodeGen::CodeGenUtil::CodeGenUtil::addFieldToRecordDecl( +ASTContext , DeclContext *DC, QualType FieldTy) { This appears to be the same as the

[PATCH] D92000: [clangd] Collect main file refs by default

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is needed for call hierarchy to be able to

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307229. njames93 added a comment. Added PathRef to TidyProvider, this handles finding clang-tidy files when the compile command directory isn't the project root. Use elog for reporting errors instead of `llvm::errs` - It was an artefact from the code in

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdced150375d0: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy() (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a4f99c494d0: [clangd] Call hierarchy (ClangdLSPServer layer) (authored by nridge). Changed prior to commit:

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb976e014db: [clangd] Call hierarchy (ClangdServer layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e6e6a2db674: [clangd] Call hierarchy (XRefs layer, incoming calls) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] dced150 - [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

Author: Nathan Ridge Date: 2020-11-23T20:44:14-05:00 New Revision: dced150375d09df6266448342fbb066d638b59ef URL: https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef DIFF: https://github.com/llvm/llvm-project/commit/dced150375d09df6266448342fbb066d638b59ef.diff

[clang-tools-extra] 0a4f99c - [clangd] Call hierarchy (ClangdLSPServer layer)

Author: Nathan Ridge Date: 2020-11-23T20:44:07-05:00 New Revision: 0a4f99c494d007a21652b1b3939bde4753042c33 URL: https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33 DIFF: https://github.com/llvm/llvm-project/commit/0a4f99c494d007a21652b1b3939bde4753042c33.diff

[clang-tools-extra] 4cb976e - [clangd] Call hierarchy (ClangdServer layer)

Author: Nathan Ridge Date: 2020-11-23T20:43:41-05:00 New Revision: 4cb976e014db80efd20dfca45ba218c3a69aac42 URL: https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42 DIFF: https://github.com/llvm/llvm-project/commit/4cb976e014db80efd20dfca45ba218c3a69aac42.diff

[clang-tools-extra] 3e6e6a2 - [clangd] Call hierarchy (XRefs layer, incoming calls)

Author: Nathan Ridge Date: 2020-11-23T20:43:38-05:00 New Revision: 3e6e6a2db674cd85b33c06b75685c6bce5acb154 URL: https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154 DIFF: https://github.com/llvm/llvm-project/commit/3e6e6a2db674cd85b33c06b75685c6bce5acb154.diff

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. Thank you for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 307223. nridge marked 2 inline comments as done. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D88630: [clang/CMake] Respect LLVM_TOOLS_INSTALL_DIR

vchuravy added a comment. > Well, I've tested it and it doesn't seem to break anything for us (Gentoo) > but I don't really understand why you'd have a different install dir for LLVM > and Clang. We (Julia) ship LLVM as a dependency and put all the LLVM binaries into a separate `tools` folder

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1102 + return llvm::any_of(B->succs(), + [this](const CFGBlock::AdjacentBlock ) { +if (const CFGBlock *S =

[PATCH] D91895: [Clang] improve -Wimplicit-fallthrough GCC compat

nathanchance added a comment. I think that not warning upon falling through to `goto` or `return` is a mistake. We have a confirmed case of a bug where `clang` would catch this bug whereas `gcc` would not: https://lore.kernel.org/lkml/20201121124019.21116-1-ogab...@kernel.org/. I suspect that

[PATCH] D91895: [Clang] avoid -Wimplicit-fallthrough for fallthrough to break

nickdesaulniers updated this revision to Diff 307218. nickdesaulniers added a comment. - git-clang-format HEAD~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91895/new/ https://reviews.llvm.org/D91895 Files:

[PATCH] D91895: [Clang] avoid -Wimplicit-fallthrough for fallthrough to break

nickdesaulniers updated this revision to Diff 307217. nickdesaulniers added a comment. - rewrite to handle a few more cases from the Linux kernel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91895/new/ https://reviews.llvm.org/D91895 Files:

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

craig.topper added a comment. In D91927#2412604 , @LuoYuanke wrote: > In D91927#2412557 , @craig.topper > wrote: > >> I only took a quick pass through this so far. What happens if a bitcast >> between x86amx and

[PATCH] D91779: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGe42021d5cc25: [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final… (authored by Ben Dunbobbin ben.dunbob...@sony.com). Herald added a project: clang. Herald added a subscriber:

[clang] e42021d - [Clang][-fvisibility-from-dllstorageclass] Set DSO Locality from final visibility

Author: Ben Dunbobbin Date: 2020-11-24T00:32:14Z New Revision: e42021d5cc25a8dc7e3efac1e7007cc0c1a7b2bd URL: https://github.com/llvm/llvm-project/commit/e42021d5cc25a8dc7e3efac1e7007cc0c1a7b2bd DIFF: https://github.com/llvm/llvm-project/commit/e42021d5cc25a8dc7e3efac1e7007cc0c1a7b2bd.diff

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added a comment. In D91927#2412557 , @craig.topper wrote: > I only took a quick pass through this so far. What happens if a bitcast > between x86amx and v256i32(or any other 1024-bit vector type) exists in the > IR but isn't next to a

[PATCH] D91029: [clangd] Implement clang-tidy options from config

njames93 updated this revision to Diff 307213. njames93 added a comment. Fix assertion in provideDefaultChecks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91029/new/ https://reviews.llvm.org/D91029 Files:

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. Thanks so much! Would you mind pushing that change for me? I don't have commit access at the moment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. @psmith Do they have concerns? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760 ___ cfe-commits mailing list

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

craig.topper added a comment. I only took a quick pass through this so far. What happens if a bitcast between x86amx and v256i32(or any other 1024-bit vector type) exists in the IR but isn't next to a load/store? Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:5334

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#2351069 , @rjmccall wrote: >> Yes, there are no generically available libcalls for atomic float math -- >> but that's okay -- let LLVM handle transform into a cmpxchg loop when >> required. > > I suspect Yaxun's target

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

smhc added a comment. Yes all looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91908/new/ https://reviews.llvm.org/D91908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 307206. yaxunl edited the summary of this revision. yaxunl added a comment. revised by John's comments. Added target hook and diagnostics for generic atomic operations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. > So if I understand it well you are suggesting to perform a check for every > parsed macro definition that would identify whether the macro has a name > matching what is provided in -cl-ext=? Then if the name matches it would > check whether the macro should be

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

glaubitz added a comment. I changed it to 4.5 to be consisted with the other Multi-Arch tests for x86, MIPS and PowerPC. That's all. Debian Multi-Arch on sparc/sparc64 behaves the exact same way as it does on mips*, powerpc* and x86, so I think it makes sense to use the exact same path

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek added inline comments. Comment at: clang/test/Driver/linux-ld.c:1292 +// CHECK-DEBIAN-SPARC: "{{.*}}/usr/lib/gcc/sparc-linux-gnu/4.5{{/|}}crtbegin.o" +// CHECK-DEBIAN-SPARC: "-L[[SYSROOT]]/usr/lib/gcc/sparc-linux-gnu/4.5" +// CHECK-DEBIAN-SPARC:

[PATCH] D91998: [OpenMP50][DOCS] Mark target data non-contiguous as done, NFC.

cchen created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 307192. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Addressed some of the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/new/ https://reviews.llvm.org/D89684 Files:

[PATCH] D91997: APINotes: add bitcode format schema definitions

compnerd created this revision. compnerd added reviewers: martong, gribozavr2, MForster. compnerd added a project: clang. Herald added a subscriber: rnkovacs. compnerd requested review of this revision. This adds the bitcode format schema required for serialization of the YAML data to a binary

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert updated this revision to Diff 307194. jdoerfert added a comment. Generalize check lines [NFC] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/ https://reviews.llvm.org/D91979 Files: clang/docs/LanguageExtensions.rst

[PATCH] D91104: APINotes: add property models for YAML attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b02ecd027a: APINotes: add property models for YAML attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] f6b02ec - APINotes: add property models for YAML attributes

Author: Saleem Abdulrasool Date: 2020-11-23T21:29:17Z New Revision: f6b02ecd027a825f1f4a1804c464f9f96d9372c9 URL: https://github.com/llvm/llvm-project/commit/f6b02ecd027a825f1f4a1804c464f9f96d9372c9 DIFF: https://github.com/llvm/llvm-project/commit/f6b02ecd027a825f1f4a1804c464f9f96d9372c9.diff

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + jdoerfert wrote: > ABataev wrote: > >

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > ABataev wrote: > >

[PATCH] D91996: [clang-format] Remove double trim

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir, klimek. HazardyKnusperkeks added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. HazardyKnusperkeks requested review of this revision.

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

MaskRay added a comment. In D88712#2411841 , @venkataramanan.kumar.llvm wrote: > For your example: extern double log (double) asm ("" "log_finite") __attribute__ ((nothrow)); double mylog (double d) { return log(d); } The intention is to emit

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

alanphipps added a comment. Looks like _LIBCPP_HAS_NO_THREADS is being set for libcxxabi, and the build now fails with this change: llvm-project/libcxxabi/../libcxx/include/__config:1172:2: error: _LIBCPP_HAS_NO_THREADS cannot be set when __STDCPP_THREADS__ is set Repository: rG LLVM

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

njames93 added a comment. In D91908#2410240 , @smhc wrote: > Thank you - I don't have commit access so am unable to merge it myself. The > clang-tidy tests are passing fine. Just checking, Has this landed correctly, showing you are the author? I'm

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. Yes I thought the same wrt the doco. There is also a hungarian notation config option in the works which does the same thing. I nearly reworked it but figured it would be best done under a separate patch It does have the potential to be less searchable through google for

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc updated this revision to Diff 307177. smhc marked an inline comment as done. smhc added a comment. Removed unnecessary diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files:

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

This revision was automatically updated to reflect the committed changes. Closed by commit rG269ef315d1be: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check (authored by smhc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 269ef31 - [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

Author: smhc Date: 2020-11-23T20:46:43Z New Revision: 269ef315d1beaff534a038b60389226b0f0f5d4f URL: https://github.com/llvm/llvm-project/commit/269ef315d1beaff534a038b60389226b0f0f5d4f DIFF: https://github.com/llvm/llvm-project/commit/269ef315d1beaff534a038b60389226b0f0f5d4f.diff LOG:

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

njames93 added a comment. Just one last small nit. // You can ignore this, nothing to do with this patch. All these changes in the documentation tell me we should probably restructure the documentation for this check. Right now we have NxM lines of documentation for each combination of style

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

leonardchan added a comment. In D91747#2412212 , @rnk wrote: > Does rG64802d48d51d651bd2e4567b2f228f8795569542 > fix it? Yup, looks like it does. Thanks for the quick fix!

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk added a comment. Does rG64802d48d51d651bd2e4567b2f228f8795569542 fix it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 ___ cfe-commits mailing list

[clang] 64802d4 - Make check-clang depend on the LLVM split-file utility

Author: Reid Kleckner Date: 2020-11-23T12:21:44-08:00 New Revision: 64802d48d51d651bd2e4567b2f228f8795569542 URL: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542 DIFF: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542.diff

[PATCH] D91428: Add support for multiple program address spaces

jrtc27 added a comment. Currently `P0-P1` is valid and results in the program address space being 1, but this patch changes the semantics of that. How sure are you that nothing will break? I do not like the idea of reusing existing valid syntax to mean something else; if you want to introduce

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk added a comment. I'll push a fix to add it to the cmake deps list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 ___ cfe-commits mailing list

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. Thanks for the reviews everyone, I have updated the title and summary. Unfortunately I don't have push access to llvm - could someone help to push this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282

[PATCH] D91428: Add support for multiple program address spaces

arichardson added a comment. The change to rename getProgramAddressSpace getDefaultProgramAddressSpace seems fine to me since it matches the GlobalsAddressSpace. By the way, your test already seems to work (if you add an explicit `call addrspace(1) void %ref()` for llc:

[PATCH] D91428: Add support for multiple program address spaces

arichardson requested changes to this revision. arichardson added a comment. I don't see why you would need multiple program address spaces to support calls to other address spaces. You can already do the following: define i32 @foo(i32) addrspace(1) { %ret = add i32 %0, 1 ret i32

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc updated this revision to Diff 307157. smhc marked an inline comment as done. smhc added a comment. Fixed uk/us spelling difference as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files:

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3edc323a88: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid… (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D91915?vs=306854=307156#toc

[clang-tools-extra] 9f3edc3 - [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

Author: Nathan James Date: 2020-11-23T20:04:51Z New Revision: 9f3edc323a88c1a179a0a5a9dc9a87a2964c0d48 URL: https://github.com/llvm/llvm-project/commit/9f3edc323a88c1a179a0a5a9dc9a87a2964c0d48 DIFF: https://github.com/llvm/llvm-project/commit/9f3edc323a88c1a179a0a5a9dc9a87a2964c0d48.diff LOG:

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

leonardchan added a comment. Hi, it seems that `p2.cpp` is failing on our production builder (https://luci-milo.appspot.com/p/fuchsia/builders/prod/clang-linux-x64/b8862835022166171808): FAIL: Clang :: CXX/cpp/cpp.predefined/p2.cpp (1210 of 26900) TEST 'Clang ::

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

avl added a comment. The change for DWARFLinker is fine. I also think it is better to split the patch up into separate patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91844/new/ https://reviews.llvm.org/D91844

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

HazardyKnusperkeks updated this revision to Diff 307142. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. I've rebased it to master, ran the documentation script and have build the targets clang-format clang-tidy pp-trace clang-include-fixer clangd

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. > Filed https://gcc.gnu.org/PR97943 for that. Avoiding the crash is trivial, > deciding what we want to do exactly for flexible array members (which are > beyond the C++ standard) is harder. Yes, and we should try to do the same thing in this case. Currently, this

[clang] b3f1b19 - [AArch64] Update clang CodeGen tests I missed in 4252f7773a5b98b825d17e5f77c7d349cb2fb7c7.

Author: Craig Topper Date: 2020-11-23T11:10:27-08:00 New Revision: b3f1b19c9cecd2ac8f8153aa25f8025dbd5702b8 URL: https://github.com/llvm/llvm-project/commit/b3f1b19c9cecd2ac8f8153aa25f8025dbd5702b8 DIFF: https://github.com/llvm/llvm-project/commit/b3f1b19c9cecd2ac8f8153aa25f8025dbd5702b8.diff

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:47 bool isSupported(llvm::StringRef Ext, const LangOptions ) const { +auto E = OptMap.find(Ext); +if (E == OptMap.end()) { erik2020 wrote: > Anastasia wrote: > >

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

Anastasia added a comment. In D91531#2411725 , @azabaznov wrote: >> Perhaps if you give me an example it would help to understand > > I was meant that this can potentially be used to undefine macros inside clang > directly. In this case there will no

[clang] 47eb5ce - [mac/arm] fix clang/test/Driver/darwin-ld-dedup.c

Author: Nico Weber Date: 2020-11-23T13:32:29-05:00 New Revision: 47eb5ce19ab10bcfe00af04e6a6e39613e2cb3c9 URL: https://github.com/llvm/llvm-project/commit/47eb5ce19ab10bcfe00af04e6a6e39613e2cb3c9 DIFF: https://github.com/llvm/llvm-project/commit/47eb5ce19ab10bcfe00af04e6a6e39613e2cb3c9.diff

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10333 + /// Check if there is an active global `omp begin assumes` directive. + bool isInOpenMPAssumeScope() { return !OMPAssumeScoped.empty(); } + ABataev wrote: > `const` member

[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

lebedev.ri added subscribers: gchatelet, courbet, lebedev.ri. lebedev.ri edited reviewers, added: aaron.ballman, njames93; removed: gchatelet, courbet. lebedev.ri added a comment. This revision now requires review to proceed. Whoa, that's a fun bug :) Repository: rG LLVM Github Monorepo

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

tschuett added a comment. Swift uses a similar mechanism: https://github.com/apple/swift/blob/887464b7b67d5202bfa7adc4e3f045ff1027a5a7/stdlib/public/core/Array.swift#L829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

venkataramanan.kumar.llvm added a comment. Hi, I am on Ubuntu 18 machine and it has finite math header . This header is included by the glibc 2.27. This header has this following definition. extern double log (double) __asm__ ("" "__log_finite") __attribute__ ((__nothrow__ )); Consider the

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman, jhuber6, grokos, ggeorgakoudis, ABataev. Herald added subscribers: llvm-commits, guansong, bollu, yaxunl. Herald added projects: clang, LLVM. jdoerfert requested review of this revision. Herald added a

[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, aaron.ballman, jhuber6. Herald added a subscriber: bollu. Herald added a project: clang. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. The `assume` attribute is a way to provide

[clang] e0e334a - [mac/arm] make clang/test/Driver/clang_f_opts.c pass consistently

Author: Nico Weber Date: 2020-11-23T12:56:52-05:00 New Revision: e0e334a9c1ace7dd9339ca6cb5866ff7b7885e11 URL: https://github.com/llvm/llvm-project/commit/e0e334a9c1ace7dd9339ca6cb5866ff7b7885e11 DIFF: https://github.com/llvm/llvm-project/commit/e0e334a9c1ace7dd9339ca6cb5866ff7b7885e11.diff

[PATCH] D86097: [OpenMP][AMDGCN] Generate global variables and attributes for AMDGCN

saiislam updated this revision to Diff 307108. saiislam added a comment. 1. Simplifies overall patch after D90248 . 2. Removes MaxParallelLevel and thus target specific PrePostActionTy. 3. Removes ExternallyInitialized qualifier from shared variables for AMDGCN.

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

erik2020 added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:47 bool isSupported(llvm::StringRef Ext, const LangOptions ) const { +auto E = OptMap.find(Ext); +if (E == OptMap.end()) { Anastasia wrote: > Btw how about we use

[PATCH] D91975: clang-tidy: detect narrowing conversions involving typedefs

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91975/new/ https://reviews.llvm.org/D91975

[PATCH] D91676: Avoid redundant work when computing vtable vcall visibility

tejohnson added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91676/new/ https://reviews.llvm.org/D91676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   3   >