[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 309167. yonghong-song added a comment. fix clang-format warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https://reviews.llvm.org/D72184 Files: llvm/lib/Target/BPF/BPFInstrFormats.td

[clang] a36f8fb - [NFC] Add proper triple for arc.ll test

Author: Yuanfang Chen Date: 2020-12-02T23:31:06-08:00 New Revision: a36f8fb021d0a1719400eda446131290be21c3ed URL: https://github.com/llvm/llvm-project/commit/a36f8fb021d0a1719400eda446131290be21c3ed DIFF: https://github.com/llvm/llvm-project/commit/a36f8fb021d0a1719400eda446131290be21c3ed.diff

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ hubert.reinterpretcast wr

[PATCH] D91147: AArch64: classify Triple::aarch64_32 as AArch64

Gerolf accepted this revision. Gerolf added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91147/new/ https://reviews.llvm.org/D91147 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

MaskRay added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ qiucf wrote: > MaskRay

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay wrote: > Generall

[clang] 222da77 - [NFC] [Clang] Move ppc64le f128 vaargs OpenMP test

Author: Qiu Chaofan Date: 2020-12-03T10:50:42+08:00 New Revision: 222da77a82d17cbc6b989779e2ba2bb4904bb672 URL: https://github.com/llvm/llvm-project/commit/222da77a82d17cbc6b989779e2ba2bb4904bb672 DIFF: https://github.com/llvm/llvm-project/commit/222da77a82d17cbc6b989779e2ba2bb4904bb672.diff L

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 added a comment. I've added test cases which demonstrate what these copies/moves are about. The move constructor probably would never get used. I can't see of a reason to move the contents of a ref counted pointer. In which case there could be an argument to delete it. The copy construc

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92529/new/ https://reviews.llvm.org/D92529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good with a minor cleanup. Thanks! Comment at: clang/lib/Sema/SemaTemplate.cpp:2081-2085 TypeLocBuilder InnerTLB; QualType Transformed = TransformTyp

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 updated this revision to Diff 309120. njames93 added a comment. Added test cases demonstrating copy and move behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/lib/ASTMatcher

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith added a comment. In D90733#2429976 , @dexonsmith wrote: > Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 > due to > a bot failure; I'll need to look i

[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

dexonsmith added a comment. Note that the original commit was reviewed here: https://reviews.llvm.org/D90733. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92531/new/ https://reviews.llvm.org/D92531 ___

[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, jansvoboda11. Herald added subscribers: ributzka, JDevlieghere. Herald added a project: clang. dexonsmith requested review of this revision. This reverts commit b34632201987eed369bb7ef4646f341b901c95b8

[clang] c4fb772 - PR48339: Improve diagnostics for invalid dependent unqualified function calls.

Author: Richard Smith Date: 2020-12-02T17:54:55-08:00 New Revision: c4fb7720ceb30f25c38d994fb375e4d1978de144 URL: https://github.com/llvm/llvm-project/commit/c4fb7720ceb30f25c38d994fb375e4d1978de144 DIFF: https://github.com/llvm/llvm-project/commit/c4fb7720ceb30f25c38d994fb375e4d1978de144.diff

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

dexonsmith added a comment. Hmm, I had to revert this in b34632201987eed369bb7ef4646f341b901c95b8 due to a bot failure; I'll need to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] b346322 - Revert "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:36:20-08:00 New Revision: b34632201987eed369bb7ef4646f341b901c95b8 URL: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c95b8 DIFF: https://github.com/llvm/llvm-project/commit/b34632201987eed369bb7ef4646f341b901c

[PATCH] D92529: ASTImporter: Migrate to the FileEntryRef overload of SourceManager::createFileID, NFC

dexonsmith created this revision. dexonsmith added reviewers: shafik, arphaman, jansvoboda11. Herald added subscribers: teemperor, ributzka, martong. Herald added a reviewer: a.sidorin. Herald added a project: clang. dexonsmith requested review of this revision. Migrate `ASTImporter::Import` over

[PATCH] D91315: [RISCV] Handle zfh in the arch string.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG432d05174ed0: [RISCV] Handle zfh in the arch string. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 432d051 - [RISCV] Handle zfh in the arch string.

Author: Hsiangkai Wang Date: 2020-12-03T09:16:44+08:00 New Revision: 432d05174ed00a217c0ad37e2e823154624c1311 URL: https://github.com/llvm/llvm-project/commit/432d05174ed00a217c0ad37e2e823154624c1311 DIFF: https://github.com/llvm/llvm-project/commit/432d05174ed00a217c0ad37e2e823154624c1311.diff

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b18a594c771: Frontend: Sink named pipe logic from CompilerInstance down to FileManager (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 3b18a59 - Frontend: Sink named pipe logic from CompilerInstance down to FileManager

Author: Duncan P. N. Exon Smith Date: 2020-12-02T17:14:27-08:00 New Revision: 3b18a594c7717a328c33b9c1eba675e9f4bd367c URL: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd367c DIFF: https://github.com/llvm/llvm-project/commit/3b18a594c7717a328c33b9c1eba675e9f4bd

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + I am not super excited about this solution, I feel like several bugs

[PATCH] D88220: [C++20] P1825R0: More implicit moves

davidstone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else Quuxplusone wrote: > Quuxplusone wrote: > > @rsmith @david_stone (or anyone), what is the status in C++20 of the > > following test

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

dexonsmith added inline comments. Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:75-80 + // Copy and move constructors/assignments are no-ops as the RefCount isn't + // dictated by the class directly. RefCountedBase(const RefCountedBase &) {} + RefCountedBase(RefCou

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:75-76 RefCountedBase() = default; + // Copy and move constructors/assignments are no-ops as the RefCount isn't + // dictated by the class directly. RefCountedBase(const RefCountedBase &

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added a comment. In D92439#2429511 , @jdoerfert wrote: > Still unsure if we should also error out for NVPTX but that is a different > story. Looks OK from my side, assuming you address the earlier comment. With this change if NVPTX need diagnostic f

[PATCH] D90887: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcc4f7f3c4b4: ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] dcc4f7f - ARCMigrate: Stop abusing PreprocessorOptions for passing back file remappings, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-02T16:28:33-08:00 New Revision: dcc4f7f3c4b4442710ae73d6f73cded665426678 URL: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded665426678 DIFF: https://github.com/llvm/llvm-project/commit/dcc4f7f3c4b4442710ae73d6f73cded66542

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 added reviewers: chandlerc, dblaikie. njames93 added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:190-196 +// Use a custom deleter for the TrueMatcherInstance ManagedStatic. This prevents +// an assert firing when the refcount is nonzero wh

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

benlangmuir removed a reviewer: benlangmuir. benlangmuir added a comment. Removing myself as reviewer since I no longer work in this area. Someone who is more involved with llvm Support/ADT should review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 3a781b9 - Fix assertion in tryEmitAsConstant

Author: Yaxun (Sam) Liu Date: 2020-12-02T19:10:01-05:00 New Revision: 3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab URL: https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab DIFF: https://github.com/llvm/llvm-project/commit/3a781b912fc7b492a21fe52cc8ce6c9e5854a9ab.dif

[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

njames93 updated this revision to Diff 309093. njames93 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix assertion due to a pointer stored in a ManagedStatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92516/new/ https://reviews.llvm.org/D92516

[PATCH] D92516: ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC

dexonsmith created this revision. dexonsmith added reviewers: rnk, dblaikie. Herald added subscribers: ributzka, jfb, hiraditya. Herald added projects: clang, LLVM. dexonsmith requested review of this revision. Prepare to delete `AlignedCharArrayUnion` by migrating its users over to `std::aligned_

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/AST/APValue.h:405 assert(isInt() && "Invalid accessor"); -return *(APSInt*)(char*)Data.buffer; +return *(APSInt *)(char *)&Data; } shafik wrote: > I notice that in `ASTTypeTraits.h`

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

shafik added inline comments. Comment at: clang/include/clang/AST/APValue.h:405 assert(isInt() && "Invalid accessor"); -return *(APSInt*)(char*)Data.buffer; +return *(APSInt *)(char *)&Data; } I notice that in `ASTTypeTraits.h` we use `reinterpret

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

dblaikie accepted this revision. dblaikie added a comment. Yeah, looks good to me - I'd probably go with your suggestion of committing the cleanup pre-emptively, then the alias change. But dealer's choice. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.or

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

rnk added a comment. Sorry, racing updates. I agree, landing them together is better, since there is risk that some corner case platform won't have this support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.org/D92512 __

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

dexonsmith updated this revision to Diff 309071. dexonsmith added a comment. Fix some build errors on the clang side of the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92512/new/ https://reviews.llvm.org/D92512 Files: clang/include/clang/AST/APValue.h clang/include/clang/A

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. Comment at: llvm/include/llvm/Support/ErrorOr.h:256-257 union { AlignedCharArrayUnion TStorage; AlignedCharArrayUnion ErrorStorage; }; ---

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added a subscriber: davidstone. Quuxplusone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:22 + return c; +} +#else Quuxplusone wrote: > @rsmith @david_stone (or anyone), what is the status in C++20 of th

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 updated this revision to Diff 309067. jyu2 retitled this revision from "Fix missing error for use of 128-bit integer inside SPIR64 device code." to "[CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.". jyu2 added a comment. Fix problem with @jdoerfert pointed wh

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

dexonsmith added a comment. Optionally, I could commit everything but the change to `AlignedCharArrayUnion` separately, just updating all the users to stop looking inside. If we think there's a chance of a revert that might be better... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

dexonsmith created this revision. dexonsmith added a reviewer: rnk. Herald added subscribers: ributzka, martong, hiraditya. Herald added a reviewer: shafik. Herald added projects: clang, LLVM. dexonsmith requested review of this revision. Update all the users of `AlignedCharArrayUnion` to stop pee

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert added a comment. Still unsure if we should also error out for NVPTX but that is a different story. Looks OK from my side, assuming you address the earlier comment. Maybe someone else should accept though. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAu

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman updated this revision to Diff 309056. jacobdweightman added a comment. I separated the handling of `ConditionalOperator`s and `BinaryConditionalOperator`s in order to eliminate handling of `OpaqueValueExpression`s in general, and asserted that the OVE's `SourceExpr` is not null.

[PATCH] D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs

shafik added a comment. In D92101#2428104 , @martong wrote: > In D92101#2423685 , @shafik wrote: > >> Should we add a test for the `regular function template` case as well? > > I think this issue is specific for a `

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

MaskRay updated this revision to Diff 309058. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: cfe-commits, sunfish, aheejin, dschuff. Herald added a project: clang. Fix two clang/test/CodeGen tests Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D91980: [OpenMP] Add initial support for `omp [begin/end] assumes`

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1296-1297 +: Error<"'#pragma omp end assumes' with no matching '#pragma omp begin assumes'">; +def err_expected_assumption_clause +: Error<"'%0' directive requires at least one c

[PATCH] D91373: [OpenMP5.0] Support more kinds of lvalues in map clauses

jacobdweightman added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16869 +// Allow results of method calls to be mapped. +if (isa(ME->getMemberDecl())) { + RelevantExpr = ME; ABataev wrote: > I don't think it should always return `true`

[PATCH] D78058: option to write files to memory instead of disk

marcrasi added a comment. Ping on this. Could anyone take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78058/new/ https://reviews.llvm.org/D78058 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490 +OMPC_MAP_MODIFIER_present); +ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation()); + } ABataev wrote: > Why need to add an empty `SourceLoc

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG32c501dd88b6: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and… (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D90497?v

[clang] 32c501d - Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-02T14:07:23-08:00 New Revision: 32c501dd88b62787d3a5ffda7aabcf4650dbe3cd URL: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650dbe3cd DIFF: https://github.com/llvm/llvm-project/commit/32c501dd88b62787d3a5ffda7aabcf4650db

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 309052. aeubanks added a comment. add comments to new methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/llvm/IR/IRPrintingPasses.h llvm/i

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

jamieschmeiser added a comment. I previously saw unrelated changes showing up in the differences here but this no longer seems to be the case so that comment can be ignored. Comment at: llvm/include/llvm/IR/PassInstrumentation.h:126 + void addClassToPassName(StringRef Class

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:3310 + case OMPC_DEFAULTMAP_MODIFIER_present: +// If implicit-behavior is present, each variable referenced in the +// construct in the category specified by variable-category is treated as if

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24d4291ca704: [CSSPGO] Pseudo probes for function calls. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 24d4291 - [CSSPGO] Pseudo probes for function calls.

Author: Hongtao Yu Date: 2020-12-02T13:45:20-08:00 New Revision: 24d4291ca704fa5ee2419b4163aa324eca693fd6 URL: https://github.com/llvm/llvm-project/commit/24d4291ca704fa5ee2419b4163aa324eca693fd6 DIFF: https://github.com/llvm/llvm-project/commit/24d4291ca704fa5ee2419b4163aa324eca693fd6.diff LO

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGacb6f80d96b7: [CUDA][HIP] Fix overloading resolution (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D80450?vs=308515&id=309044#toc Repo

[clang] acb6f80 - [CUDA][HIP] Fix overloading resolution

Author: Yaxun (Sam) Liu Date: 2020-12-02T16:33:33-05:00 New Revision: acb6f80d96b74af3ec515bb9811d213abb406c31 URL: https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31 DIFF: https://github.com/llvm/llvm-project/commit/acb6f80d96b74af3ec515bb9811d213abb406c31.dif

[clang] 0849047 - Add a less ambiguous macro for Android version.

Author: Dan Albert Date: 2020-12-02T13:26:28-08:00 New Revision: 0849047860a343d8bcf1f828a82d585e89079943 URL: https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943 DIFF: https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943.diff LO

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; lebede

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap added a comment. Replied to a comment Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9213 + + if (bot) { +SplatNode = DAG.getNode( NeHuang wrote: > I do not quite understand the `if` and `else` logic here, current logic seems > we

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 309039. Conanap marked 6 inline comments as done. Conanap added a comment. Addressed some formatting comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jyu2 wrote: > jdoerfer

[clang] 2ac5880 - Update MS ABI mangling for union constants based on new information from

Author: Richard Smith Date: 2020-12-02T12:17:52-08:00 New Revision: 2ac58801873ab99dd5de48ad7557b76f1803100b URL: https://github.com/llvm/llvm-project/commit/2ac58801873ab99dd5de48ad7557b76f1803100b DIFF: https://github.com/llvm/llvm-project/commit/2ac58801873ab99dd5de48ad7557b76f1803100b.diff

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks great to me, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92495/new/ https://reviews.llvm.org/D92495 ___

[PATCH] D92444: [CMake][Fuchsia] Install llvm-elfabi

This revision was automatically updated to reflect the committed changes. Closed by commit rG70764c02e474: [CMake][Fuchsia] Install llvm-elfabi (authored by mcgrathr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92444/new/ https://reviews.llvm.org

[clang] 70764c0 - [CMake][Fuchsia] Install llvm-elfabi

Author: Roland McGrath Date: 2020-12-02T11:59:14-08:00 New Revision: 70764c02e474504e2ebfb5b230a3b2ccdbedc5c2 URL: https://github.com/llvm/llvm-project/commit/70764c02e474504e2ebfb5b230a3b2ccdbedc5c2 DIFF: https://github.com/llvm/llvm-project/commit/70764c02e474504e2ebfb5b230a3b2ccdbedc5c2.diff

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2710 +**SpacesInLineComments** (``SpacesInLineComment``) + How many spaces are allowed at the start of a line comment. To disable the MyDeveloperDay wrote: > Is this c

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2428563 , @sfertile wrote: >> On FreeBSD, the main use of this will be on the new powerpc64le arch, where >> we need to build a 32-bit LE bootloader for use with pseries. (it is easier >> to retarget LLVM than make a

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2153 +def SwiftAttr : InheritableAttr { + let Spellings = [Clang<"swift_attr">]; + let Args = [StringArgument<"Attribute">]; The other swift attributes use a GNU spelling and don

[PATCH] D92355: [clang] add a `swift_async_name` attribute

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. There's no information in either the attribute definition in Attr.td or in the documentation as to what subject this attribute applies to. Comment at

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

wmi accepted this revision. wmi added a comment. This revision is now accepted and ready to land. In D91756#2427795 , @hoy wrote: > In D91756#2427759 , @wmi wrote: > >> Another question. Sorry for not bringing it up

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

nickdesaulniers added a comment. Hi @trixirt , thanks for the follow up. I think the lint feedback about qualifying `auto` with pointers where applicable would be nice to have. Please make those suggested changes. Should https://reviews.llvm.org/D90180 be abandoned in favor of this patch? Wou

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 309020. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver

[PATCH] D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGa65d8c5d720d: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX (authored by jasonliu). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D91455?vs=308752&

[clang] a65d8c5 - [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX

Author: jasonliu Date: 2020-12-02T18:42:44Z New Revision: a65d8c5d720db8c646adb0ad9dac54da5d5fa230 URL: https://github.com/llvm/llvm-project/commit/a65d8c5d720db8c646adb0ad9dac54da5d5fa230 DIFF: https://github.com/llvm/llvm-project/commit/a65d8c5d720db8c646adb0ad9dac54da5d5fa230.diff LOG: [XCO

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

tra added a comment. In D80450#2428631 , @yaxunl wrote: >> Also, naming. `-ffix-overload-resolution` is rather non-specific. I didn't >> mean to use it literally. The problem is that I can't think of a good >> descriptive name for what we do here. `-fgp

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

MaskRay added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ Generally `%clang` is o

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

erik.pilkington created this revision. erik.pilkington added reviewers: arphaman, doug.gregor, aaron.ballman. Herald added subscribers: dexonsmith, ributzka, jfb, jkorous. erik.pilkington requested review of this revision. You can read more about the clang attributes for swift async here: https://

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

adamcz updated this revision to Diff 309003. adamcz added a comment. -bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92494/new/ https://reviews.llvm.org/D92494 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/un

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This can happen when, for example, merging results from an external index t

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 308994. xndcn added a comment. `getHoverInfo(CXXThisExpr->getType()->getPointeeType(), ...)` does not output namespace scope and template parameters without specialization: F14499632: Pointee.png while `getHoverInfo(CXXThis

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; vsk wrote

[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

vsk added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524 // defined. - if (Ty->getPointeeType().isVolatileQualified()) + if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified()) return; Is the pointee t

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. In D87216#2428359 , @jamieschmeiser wrote: > I see you have made the requested changes (nit: clang-tidy complained about > the capitalization of the function) but why are there so many other, > unrelated changes shown? Is ther

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 added inline comments. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the 128-bit integer types are unavailable to name lookup, jdoerfert wrote: > jyu

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 309000. aeubanks added a comment. clean up some more unnecessary llvm:: add comments to function declarations in PrintPasses.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 308995. aeubanks added a comment. fix capitalization remove extra declaration and fixup includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 Files: llvm/include/

[PATCH] D92439: Fix missing error for use of 128-bit integer inside SPIR64 device code.

jdoerfert added a comment. So, NVPTX seems to do something sensible with i128, though I haven't done rigorous testing. Comment at: clang/lib/Sema/Sema.cpp:241 + (Context.getAuxTargetInfo() && + Context.getAuxTargetInfo()->hasInt128Type())) { // If either of the

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2428743 , @hvdijk wrote: > In D52050#2428735 , @glaubitz wrote: > >> Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. > > Most autoconf-using software wo

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428743 , @hvdijk wrote: > In D52050#2428735 , @glaubitz wrote: > >> Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. > > Most autoconf-using software

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2428735 , @glaubitz wrote: > Hmm, I was pretty sure that autoconf can deal with x32 inside an x32 chroot. Most autoconf-using software won't be dealing with a copy of `config.guess` that was last updated in 2011. Updatin

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

peterwaller-arm updated this revision to Diff 308989. peterwaller-arm added a comment. Tweak message to address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92487/new/ https://reviews.llvm.org/D92487 Files: clang/include/clang/B

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2428709 , @hvdijk wrote: > `sys::getDefaultTargetTriple()` defaults to `LLVM_DEFAULT_TARGET_TRIPLE`, > which in turn defaults to `LLVM_HOST_TRIPLE`, which in turn defaults to > `LLVM_INFERRED_HOST_TRIPLE`, which calls

  1   2   >