[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaeb56503ec8: [clang][cli] Convert Analyzer option string based options to new option parsing… (authored by jansvoboda11). Repository: rG LLVM Git

[clang] caeb565 - [clang][cli] Convert Analyzer option string based options to new option parsing system

Author: Jan Svoboda Date: 2020-12-18T08:56:06+01:00 New Revision: caeb56503ec897c7244cff0657c11e87d2644f82 URL: https://github.com/llvm/llvm-project/commit/caeb56503ec897c7244cff0657c11e87d2644f82 DIFF: https://github.com/llvm/llvm-project/commit/caeb56503ec897c7244cff0657c11e87d2644f82.diff L

[clang] 8c1f2d1 - Following up on PR48517, fix handling of template arguments that refer

Author: Richard Smith Date: 2020-12-17T23:54:37-08:00 New Revision: 8c1f2d15b826591cdf6bd6b468b8a7d23377b29e URL: https://github.com/llvm/llvm-project/commit/8c1f2d15b826591cdf6bd6b468b8a7d23377b29e DIFF: https://github.com/llvm/llvm-project/commit/8c1f2d15b826591cdf6bd6b468b8a7d23377b29e.diff

[clang] 4b38885 - Ensure that we transform types into the current instantiation even if

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 4b388859f527f822a27bcee409242c421f199f1d URL: https://github.com/llvm/llvm-project/commit/4b388859f527f822a27bcee409242c421f199f1d DIFF: https://github.com/llvm/llvm-project/commit/4b388859f527f822a27bcee409242c421f199f1d.diff

[clang] 71886c5 - Where possible, don't try to ask whether a template argument is

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 71886c56f336667969be4cac0b6a17a3f75b7555 URL: https://github.com/llvm/llvm-project/commit/71886c56f336667969be4cac0b6a17a3f75b7555 DIFF: https://github.com/llvm/llvm-project/commit/71886c56f336667969be4cac0b6a17a3f75b7555.diff

[clang] 638867a - DR2064: decltype(E) is only a dependent type if E is type-dependent, not

Author: Richard Smith Date: 2020-12-17T23:23:05-08:00 New Revision: 638867afd4bce4a2c56dea041299428af3727d61 URL: https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61 DIFF: https://github.com/llvm/llvm-project/commit/638867afd4bce4a2c56dea041299428af3727d61.diff

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93490/new/ https://reviews.llvm.org/D93490

[clang] d3bf0bb - PR24076, PR33655, C++ CWG 1558: Consider the instantiation-dependence of

Author: Richard Smith Date: 2020-12-17T21:31:23-08:00 New Revision: d3bf0bb18952d830fe6df6f791a64552b271000b URL: https://github.com/llvm/llvm-project/commit/d3bf0bb18952d830fe6df6f791a64552b271000b DIFF: https://github.com/llvm/llvm-project/commit/d3bf0bb18952d830fe6df6f791a64552b271000b.diff

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312676. ffrankies added a comment. - removed unnecessary comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72235/new/ https://reviews.llvm.org/D72235 Files: clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp clang-tools-extra/clang-

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 312675. ffrankies marked 9 inline comments as done. ffrankies added a comment. - Rebased with master branch - Diagnostics are re-worded so they're not complete sentences Check ready for further review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

tejohnson added a comment. In D73418#2461943 , @ayermolo wrote: > @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in > general where can I find more information about it. > > When I step through the code in emitVTableTypeMetadata, it'

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:20-21 #include "clang/Basic/Version.h" #include "clang/CrossTU/CrossTranslationUnit.h" #include "clang/Frontend/ASTUnit.h" #include "clang/Lex/Preprocessor.h" Will these

[PATCH] D92493: [IR] Add hot to function attributes and use hot/cold attribute in function section prefix/suffix

This revision was automatically updated to reflect the committed changes. Closed by commit rG3733463dbb58: [IR][PGO] Add hot func attribute and use hot/cold attribute in func section (authored by xur). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 3733463 - [IR][PGO] Add hot func attribute and use hot/cold attribute in func section

Author: Rong Xu Date: 2020-12-17T18:41:12-08:00 New Revision: 3733463dbb58a29892be3872bd32f93cb9af492c URL: https://github.com/llvm/llvm-project/commit/3733463dbb58a29892be3872bd32f93cb9af492c DIFF: https://github.com/llvm/llvm-project/commit/3733463dbb58a29892be3872bd32f93cb9af492c.diff LOG:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, Is there any more concerns, feedbacks or suggestions? thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 ___ cfe-commits mailing

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

ayermolo added a comment. @tejohnson I was wondering where does this @anon.{{.*}} gets set, or in general where can I find more information about it. When I step through the code in emitVTableTypeMetadata, it's still. @0 = private unnamed_addr constant { [2 x i8*] } { [2 x i8*] [i8* bitcast (%

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 312658. ffrankies marked an inline comment as done. ffrankies added a comment. @aaron.ballman hmm, that is strange. I've rebased the patch and updated the diff, let me know if this one doesn't work either or there's something else you'd like me to try. Tha

[PATCH] D93436: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2808f597f872: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang-tools-extra] 2808f59 - [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

Author: Nathan James Date: 2020-12-18T02:07:27Z New Revision: 2808f597f872e68a8bd69d5b53f5d583665b4c4f URL: https://github.com/llvm/llvm-project/commit/2808f597f872e68a8bd69d5b53f5d583665b4c4f DIFF: https://github.com/llvm/llvm-project/commit/2808f597f872e68a8bd69d5b53f5d583665b4c4f.diff LOG:

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I think this is in pretty good shape, remaining stuff is up to you. Let me know if/when you want me to land this! Comment at: clang-tools-extra/clangd/Hover.cp

[PATCH] D78058: option to write files to memory instead of disk

sammccall added a comment. It's great that you're looking at this! Clang tooling in general and clangd in particular a lot of use of VFS (particularly when deployed inside google), so I've got a fair bit of interest/experience in these interfaces. And we'd also looked at virtualizing module cac

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

JonChesterfield added a comment. Ah, this may be one of the things aomp changed for nvptx. We did something around linking but I've never looked into exactly what. In that case fine by me - it's a sharp edge, but I'd expect it to make a difference in benchmarks until whole program optimisation

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. @ahatanak this patch should now be a nfc for types that don't have anything to do with the trivial-abi attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 312629. zoecarver added a comment. - Fix base-derived case. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 ___ cfe-commits mailing list cfe-commits

[clang] 3203143 - CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

Author: Tom Stellard Date: 2020-12-17T14:30:31-08:00 New Revision: 3203143f1356a4e4e3ada231156fc6da6e1a9f9d URL: https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9d DIFF: https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9d.diff

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

This revision was automatically updated to reflect the committed changes. tstellar marked an inline comment as done. Closed by commit rG3203143f1356: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int) (authored by tstellar). Herald added a subscriber: pengfei. Repository:

[PATCH] D93333: tidy: supress warning for default member funcs

malcolm.parsons accepted this revision as: malcolm.parsons. malcolm.parsons added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9 ___

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:1846 +(*Iter)->setInvalidDecl(); + } } rjmccall wrote: > You can have multiple tag declarations because of complex declarators or > type-specifiers, e.g. `

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman updated this revision to Diff 312613. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 Files: clang/lib/Sema/SemaStmt.cpp clang/test/Sema/for.c Index: clang/tes

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2461497 , @lebedev.ri wrote: > @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, > and unfortunately it came back green.. > I don't recall if i can reproduce it locally (on vanilla test suite,

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a subscriber: dmajor. lebedev.ri added a comment. @mstorsjo i've bothered @dmajor to give this a try on some of mozilla's CI, and unfortunately it came back green.. I don't recall if i can reproduce it locally (on vanilla test suite, i'll recheck), but right now it would seem th

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

danielkiss added a comment. In D93428#2461343 , @apazos wrote: > Thanks Daniel for the explanation. No problem at all. In D93428#2461343 , @apazos wrote: > Was the support added for GNU assembler as well? Is it t

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc755e41c336c: Fix -Wno-error= parsing in clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] c755e41 - Fix -Wno-error= parsing in clang-format.

Author: Joachim Meyer Date: 2020-12-17T22:23:42+01:00 New Revision: c755e41c336c898873db6c3c58a2819a982f60de URL: https://github.com/llvm/llvm-project/commit/c755e41c336c898873db6c3c58a2819a982f60de DIFF: https://github.com/llvm/llvm-project/commit/c755e41c336c898873db6c3c58a2819a982f60de.diff

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, JakeMerdichAMD, JVApen. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48539 Add support for Qt Translator Comment

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312596. fodinabor added a comment. Update ClangFormat.rst. This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Thanks Daniel for the explanation. Was the support added for GNU assembler as well? Is it the same flag name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93428/new/ https://reviews.llvm.org/D93428 ___

[PATCH] D93458: clang-cl: Remove /Zd flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG49c248bd62a3: clang-cl: Remove /Zd flag (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93458/new/ https:/

[clang] 49c248b - clang-cl: Remove /Zd flag

Author: Nico Weber Date: 2020-12-17T15:39:40-05:00 New Revision: 49c248bd62a3cb2f0e7e3991ee0190943bd2bbec URL: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec DIFF: https://github.com/llvm/llvm-project/commit/49c248bd62a3cb2f0e7e3991ee0190943bd2bbec.diff LO

[PATCH] D93439: [OpenMP][NFC] Provide a new remark and documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG994bb6eb7d01: [OpenMP][NFC] Provide a new remark and documentation (authored by jdoerfert). Herald added a project: clang. Herald added a subscriber:

[clang] 994bb6e - [OpenMP][NFC] Provide a new remark and documentation

Author: Johannes Doerfert Date: 2020-12-17T14:38:26-06:00 New Revision: 994bb6eb7d01db1d9461e54d17a63af2ba1af2c9 URL: https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9 DIFF: https://github.com/llvm/llvm-project/commit/994bb6eb7d01db1d9461e54d17a63af2ba1af2c9.d

[PATCH] D68410: [AttrDocs] document always_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGe75fec2b238f: [AttrDocs] document always_inline (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm

[clang] e75fec2 - [AttrDocs] document always_inline

Author: Nick Desaulniers Date: 2020-12-17T12:34:23-08:00 New Revision: e75fec2b238f0e26cfb7645f2208baebe3440d41 URL: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41 DIFF: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41.di

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 _

[PATCH] D93483: Add element-type to the Vector TypeLoc types.

erichkeane created this revision. erichkeane added reviewers: fhahn, rjmccall. erichkeane requested review of this revision. As shown by bug 48540, GCC vector types would cause a crash when the declaration hada ParenType. This was because the walking of the declaration would try to expand the 'inn

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4c8b8031800: [openmp] Remove clause from OMPKinds.def and use OMP.td info (authored by clementval). Repository: rG LLVM Github Monorepo CHANGES

[clang] f4c8b80 - [openmp] Remove clause from OMPKinds.def and use OMP.td info

Author: Valentin Clement Date: 2020-12-17T14:08:12-05:00 New Revision: f4c8b80318005ca61bfed9b40ee9e6039194159b URL: https://github.com/llvm/llvm-project/commit/f4c8b80318005ca61bfed9b40ee9e6039194159b DIFF: https://github.com/llvm/llvm-project/commit/f4c8b80318005ca61bfed9b40ee9e6039194159b.di

[PATCH] D93458: clang-cl: Remove /Zd flag

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93458/new/ https://reviews.llvm.org/D93458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. `byval` actually means it'll be passed on the stack, not as a pointer, so yes, that's a real change in conventions from an indirect argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.o

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:1846 +(*Iter)->setInvalidDecl(); + } } You can have multiple tag declarations because of complex declarators or type-specifiers, e.g. `struct A (*var)(struct B)

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

CarolineConcatto accepted this revision. CarolineConcatto added a comment. Thank you @awarzynski for implementing fsyntax-only. It is another feature that the new driver provides, it is nice to see thing falling into place. The patch looks good to me! Comment at: flang/includ

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2892978e919: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_… (authored by bsaleil, committed by Conanap). Repository

[clang] c289297 - [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

Author: Baptiste Saleil Date: 2020-12-17T13:19:27-05:00 New Revision: c2892978e919bf66535729c70fba73c4c3224548 URL: https://github.com/llvm/llvm-project/commit/c2892978e919bf66535729c70fba73c4c3224548 DIFF: https://github.com/llvm/llvm-project/commit/c2892978e919bf66535729c70fba73c4c3224548.dif

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 312547. awarzynski added a comment. Tidy-up include paths This was pointed out by @CarolineConcatto offline, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92854/new/ https://reviews.llvm.org/D928

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

danielkiss added a comment. > Is there a reason why assembly files have a different flag (i.e. > -mmark-bti-property) to create the .note.gnu.property with the BTI entry? In assembly the compiler can't guarantee the landing pads are in place, therefore it doesn't add it automatically. The origi

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:618 + } else { +CXXRecordDecl *D = QT->getAsCXXRecordDecl(); +if (D && D->isLambda()) sammccall wrote: > You've rewritten this logic compared to the old `getHoverContents(Qual

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau updated this revision to Diff 312545. qchateau marked 3 inline comments as done. qchateau added a comment. I updated this diff according to your review. There are a few things that may still need change but I need your input, see my other comments :) Repository: rG LLVM Github Monore

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. In D92361#2459655 , @rjmccall wrote: > In D92361#2459513 , @zoecarver wrote: > >>> I think that as long as the class leaves a copy/move constructor defaulted, >>> there's no need for a ne

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

rjmccall added a comment. Oh yes, somehow I overlooked that, sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312538. ArcsinX added a comment. `StringRef` => `llvm::StringRef` in one more place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/i

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

Bigcheese added a comment. This looks fine to be as that code is definitely dead. I would wait for @SjoerdMeijer in case there's a bug in the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93395/new/ https://reviews.llvm.org/D93395

[PATCH] D93436: [clangd] Print .clang-tidy configuration parsing errors using [ev]?log.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! From here it seems like mostly a question of plumbing/refactoring on the clangd side to be able to surface these diagnostics, similar to how you did it with config files. At some

[PATCH] D84672: [clang][cli] Port PreprocessorOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84672/new/ https://reviews.llvm.org/D84672 ___

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

jdoerfert updated this revision to Diff 312535. jdoerfert added a comment. Rebase on top of D93439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93079/new/ https://reviews.llvm.org/D93079 Files: clang/include/cl

[PATCH] D84671: [clang][cli] Port LangOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 __

[PATCH] D93458: clang-cl: Remove /Zd flag

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm, but perhaps Reid should take a look Comment at: clang/docs/ReleaseNotes.rst:127 + +- clang-cl's ``/Zd`` flag no longer exist. But ``-gline-tables-only`` still + ex

[PATCH] D84670: [clang][cli] Port HeaderSearch simple string options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with nit. Comment at: clang/include/clang/Driver/Options.td:1815 + HelpText<"Specify the interval (in seconds) after which a module file will be considered unuse

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX marked an inline comment as done. ArcsinX added a comment. Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 ___ cfe-commits mailing l

[PATCH] D84668: [clang][cli] Port TargetOpts simple string based options to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the fix above. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:264-265 +template ::value, bool> = true> +static void denormalizeSimpleEnum(SmallVector

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312530. ArcsinX added a comment. `unique_function indexedFiles() const` => `unique_function indexedFiles() const` `StringRef` => `llvm::StringRef` for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D92290: [clangd] Use clangd's Context mechanism to make the ASTContext of the AST being operated on available everywhere

sammccall added a comment. Sorry for taking a while to get to this... I'm not sure this is really a helpful use of Context. (Though some would argue that there are no good uses, my manager was appalled when we added it...) Does this enable some future work, or is it reasonable to evaluate this p

[PATCH] D93464: [analyzer] Refine suppression mechanism to better support AST checks

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. vsavchenko requested review of this revision. Herald added a project: clang. Herald add

[PATCH] D84669: [clang][cli] Port CodeGenOpts simple string flags to new option parsing system

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm with the comment. Comment at: clang/include/clang/Driver/Options.td:2123-2125 def fpatchable_function_entry_EQ : Joined<["-"], "fpatchable-function-entry=">, Gro

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

apazos added a comment. Thanks for clarifying - so the property is being set for C/C++ files but not for assembly files. I think it should be set automatically for both when one uses clang driver to compile/assemble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

aaron.ballman closed this revision. aaron.ballman added a comment. In D93102#2460034 , @tmatheson wrote: > In D93102#2458433 , @aaron.ballman > wrote: > >> LGTM aside from a minor nit. Thank you for the patch! Do y

[clang] f500662 - Detect section type conflicts between functions and variables

Author: Tomas Matheson Date: 2020-12-17T11:43:47-05:00 New Revision: f50066292477fb26806336e5604615d0eddde399 URL: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399 DIFF: https://github.com/llvm/llvm-project/commit/f50066292477fb26806336e5604615d0eddde399.diff

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau planned changes to this revision. qchateau added a comment. > Periodic malloc_trim seems like it solves a real problem, one I don't > personally fully understand but we may never do - I feel convinced we should > use it anyway. It probably has some overhead, who knows how much. It does

[PATCH] D93453: [flang][driver] Add support for `-I`

awarzynski added a comment. Hi @FarisRehman ! Thank you for working on this! Could you add tests? Comment at: clang/lib/Driver/ToolChains/Flang.cpp:75 + Args.AddAllArgs(CmdArgs, options::OPT_I); + This would ideally go to a dedicated method for parsing prepr

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

fodinabor updated this revision to Diff 312518. fodinabor added a comment. Add lit test to ensure behaviour of the -Wno-error=unkown flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 Files: clang/test

[PATCH] D93428: [AArch64] Add bti note property when compiling asm files with -mbranch-protection=bti

steplong added a comment. In D93428#2460032 , @danielkiss wrote: > The `.note.gnu.property` is already generated when C/C++ files are compiled > with `-mbranch-protection=bti`. > `-mmark-bti-property` is only for assembly file where the > `.note.gnu.pr

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

tskeith added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:228 + // Note: GCC drops anything following an end-of-line character. + llvm::StringRef::size_type End = MacroBody.find_first_of("\n\r"); + MacroBody = MacroBody.substr(0, End); --

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312508. ArcsinX added a comment. Fix comment inside IndexClient::indexedFiles() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93393/new/ https://reviews.llvm.org/D93393 Files: clang-tools-extra/clangd/index/

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Fantastic, thanks so much! Comment at: clang-tools-extra/clangd/index/Merge.cpp:129 +StaticContainsFile{Static->indexedFiles()} + ](llvm::StringRef FileURI) mutabl

[PATCH] D93258: [amdgpu] Default to code object v3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf39e3f2dba: [amdgpu] Default to code object v3 (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] daf39e3 - [amdgpu] Default to code object v3

Author: Jon Chesterfield Date: 2020-12-17T16:09:33Z New Revision: daf39e3f2dba18bd39cd89a1c91bae126a31d4fe URL: https://github.com/llvm/llvm-project/commit/daf39e3f2dba18bd39cd89a1c91bae126a31d4fe DIFF: https://github.com/llvm/llvm-project/commit/daf39e3f2dba18bd39cd89a1c91bae126a31d4fe.diff L

[PATCH] D93452: [clangd] Trim memory after buildINdex

sammccall added a comment. Wow, all abstractions truly are lies. Thanks for the investigation! After doing some reading[1], my understanding is roughly: - our pattern of allocations causes glibc malloc to retain a *much* larger heap than our outstanding allocations, growing without (or with lar

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6502 + // except that it has a non-trivial member *with* the trivial_abi attribute. + for (auto Base : D->bases()) { +if (auto CxxRecord = Base.getType()->getAsCXXRecordDecl()) zo

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman, thank you for working on this! This looks really good and I think that it's almost ready. I did leave a few comments, but most are a matter of style and should be easy to address. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:70-7

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau updated this revision to Diff 312500. qchateau added a comment. Herald added a subscriber: mgorny. Add macro to use malloc_trim only if available Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https://reviews.llvm.org/D93452 Fil

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

njames93 added a comment. In D93459#2460445 , @fodinabor wrote: > Btw. is there a way to add tests for command-line options, so this won't > happen unnoticed again? I'd guess some lit tests could be used to verify the command line syntax is correct /

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

seanyoung added a comment. Patch submitted https://lore.kernel.org/bpf/20201217150102.ga13...@gofer.mess.org/T/#u Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93103/new/ https://reviews.llvm.org/D93103 ___

[PATCH] D92800: [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb0f7288051e: [Clang] Make nomerge attribute a function attribute as well as a statement… (authored by zequanwu). Repository: rG LLVM Github Monor

[clang] fb0f728 - [Clang] Make nomerge attribute a function attribute as well as a statement attribute.

Author: Zequan Wu Date: 2020-12-17T07:45:38-08:00 New Revision: fb0f7288051eb2745bb9211306f53ff9aa6f73e2 URL: https://github.com/llvm/llvm-project/commit/fb0f7288051eb2745bb9211306f53ff9aa6f73e2 DIFF: https://github.com/llvm/llvm-project/commit/fb0f7288051eb2745bb9211306f53ff9aa6f73e2.diff LOG

[PATCH] D93393: [clangd] Ignore the static index refs from the dynamic index files.

ArcsinX updated this revision to Diff 312497. ArcsinX added a comment. Make `indexedFiles()` to return `[](StringRef){return false;}` instead of `nullptr`. Add comments. Do not call `indexedFiles()` at every file check for `MergeIndex`. Consume error if `URI::resolve()` fails. Repository: rG

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau added a comment. > Side note is this memory failing to free behaviour observed on windows? No idea, I only develop on linux. Looking at the the github issues, it seems people that had the issue were also using the linux version...so we can't conclude anything about windows =

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman added a comment. In D92577#2458903 , @rjmccall wrote: > Please test that there's actually an object declared and that it's not *just* > a tag declaration. Good catch, I've corrected this and added some more test coverage. CHANGES SINCE LA

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman updated this revision to Diff 312494. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/ https://reviews.llvm.org/D92577 Files: clang/lib/Sema/SemaStmt.cpp clang/test/Sema/for.c Index: clang/tes

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfinx.td:102 +: InstAlias; + use GPR as instruction operand may cause the codegen part of zfinx report errors. Because the GPR has data type i32 or i64, However, the zfinx will

[PATCH] D91444: [InstCombine] Preserve !annotation on newly created instructions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01089c876bff: [InstCombine] Preserve !annotation on newly created instructions. (authored by fhahn). Changed prior to commit: https://reviews.llvm

  1   2   >