[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2463733 , @mstorsjo wrote: > In D87188#2463566 , @lebedev.ri > wrote: > >> Once again, thank you @mstorsjo and @dmgreen! > > Awesome, thanks guys! > > I'll let you know tomorrow

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added subscribers: erik.pilkington, arphaman, Bigcheese. dexonsmith added a comment. I think this is important; thanks for working on it! I'm sorry I missed it before... coincidentally, I'm working in a similar problem space right now (likely I'll post a patch with an RFC next week)

[clang-tools-extra] 2b62e62 - [clangd] Fix windows path handling in .clang-tidy parsing

Author: Sam McCall Date: 2020-12-19T02:24:25+01:00 New Revision: 2b62e62328841b7d2dc01e390e13fb9151d06263 URL: https://github.com/llvm/llvm-project/commit/2b62e62328841b7d2dc01e390e13fb9151d06263 DIFF: https://github.com/llvm/llvm-project/commit/2b62e62328841b7d2dc01e390e13fb9151d06263.diff

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

sammccall added a comment. Thanks! Changes to ClangdServer are definitely good, I'm less sure about renderTUAction. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1183 // are familiar by C++ programmers. std::string renderTUAction(const PreambleAction PA, const

[clang-tools-extra] 2fced5a - [clangd] Don't cancel requests based on "updates" with same content

Author: Sam McCall Date: 2020-12-19T02:03:40+01:00 New Revision: 2fced5a07b45ef527ac00a13e63bfca61e407ee3 URL: https://github.com/llvm/llvm-project/commit/2fced5a07b45ef527ac00a13e63bfca61e407ee3 DIFF: https://github.com/llvm/llvm-project/commit/2fced5a07b45ef527ac00a13e63bfca61e407ee3.diff

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

dexonsmith marked an inline comment as done. dexonsmith added a comment. Thanks for the review! Comment at: clang/lib/Basic/SourceManager.cpp:167 + // (which may have come from a stat cache). + if (ContentsEntry->isNamedPipe()) { +// Check the buffer size directly if

[PATCH] D93148: Basic: Add native support for stdin to SourceManager and FileManager

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Nice, it looks cleaner than the override of file contents that was used before. Left one NIT comment Comment at: clang/lib/Basic/FileManager.cpp:352 + + STDIN =

[clang-tools-extra] b061564 - [clangd] Make our printing policies for Hover more consistent, especially tags

Author: Sam McCall Date: 2020-12-19T00:52:55+01:00 New Revision: b0615642f647bea1483659f1e14515a836015254 URL: https://github.com/llvm/llvm-project/commit/b0615642f647bea1483659f1e14515a836015254 DIFF: https://github.com/llvm/llvm-project/commit/b0615642f647bea1483659f1e14515a836015254.diff

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0615642f647: [clangd] Make our printing policies for Hover more

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

arphaman added a comment. Left one minor suggestion , but LGTM otherwise Comment at: clang/lib/Basic/SourceManager.cpp:167 + // (which may have come from a stat cache). + if (ContentsEntry->isNamedPipe()) { +// Check the buffer size directly if this is a named pipe.

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added a comment. We could probably do something like what this patch is doing and determine whether a class can be passed in registers based on whether its subobjects can be passed in registers. If all of the subobjects can be passed in registers, the current class can be passed in

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

sammccall added a comment. In D93553#2463577 , @qchateau wrote: > Looks good to me, it removes a lot of duplication and corner cases. > > I'd have printed the tag for reference and pointers as well (`class Foo*` > instead of `Foo*`). I don't think `Foo*`

[PATCH] D93452: [clangd] Trim memory periodically

sammccall added a comment. Thanks, this looks much closer to something we can land. Bunch of nits :-) Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1306 + + { +auto Now = std::chrono::steady_clock::now(); can you leave a FIXME to do this

Re: [clang-tools-extra] 95c7b6c - [clangd] zap a few warnings

Thanks! On Fri, 18 Dec 2020 at 07:34, Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Date: 2020-12-18T16:34:34+01:00 > New Revision: 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc > > URL: >

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar created this revision. tstellar added reviewers: ddunbar, krememek. Herald added subscribers: Charusso, mgorny. tstellar requested review of this revision. Herald added a project: clang. I'm not exactly sure what this is, but it appears to be a tool for reporting internal issues at

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ahatanak added a comment. This latest patch changes the way `D` is passed in the following example, which doesn't use `trivial_abi` at all: struct B0 { int a; B0(); B0(const B0 &) = default; B0(B0 &&) = delete; }; struct B1 { int a; B1(); B1(const B1 &) =

[PATCH] D78938: Make LLVM build in C++20 mode

bmahjour added inline comments. Comment at: llvm/include/llvm/ADT/DirectedGraph.h:40 /// Static polymorphism: delegate implementation (via isEqualTo) to the /// derived class. + bool operator==(const DGEdge ) const { jfb wrote: > That comment, so

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

sammccall added a comment. In D93531#2463126 , @njames93 wrote: > In D93531#2463052 , @sammccall wrote: > >> This adds a bit of complexity, making the code here a fair amount harder to >> follow and verify the

[clang] f5cef87 - [www] Remove '$Date$' marker from cxx_dr_status.

Author: Richard Smith Date: 2020-12-18T14:14:52-08:00 New Revision: f5cef870d116104354fe557c71025a9d4bfbe952 URL: https://github.com/llvm/llvm-project/commit/f5cef870d116104354fe557c71025a9d4bfbe952 DIFF: https://github.com/llvm/llvm-project/commit/f5cef870d116104354fe557c71025a9d4bfbe952.diff

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsmith added a comment. The implementation looks fine to me. That said, I'm concerned that the design of this feature will severely limit its utility. For classes and enums, operators are typically defined in an associated namespace so that they can be found by ADL. For these types, there are

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

sammccall added a comment. In theory, this version doesn't seem so useful - a simple JSON pretty-printer that ignores column widths etc is easy to write, doesn't need any of clang-format's infrastructure, and this isn't a particularly great one. In practice though, not having to configure yet

[PATCH] D93333: [clang-tidy] ppcoreguidelines-pro-type-member-init: suppress warning for default member funcs

cwarner-8702 added a comment. @malcolm.parsons Could you or someone with commit access merge this on my behalf? Author Name: Chris Warner Author Email: cwar...@esri.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/

[clang] 72d8f79 - [c++2b] Add tests for feature test macros.

Author: Richard Smith Date: 2020-12-18T13:42:23-08:00 New Revision: 72d8f79f0c31c9b95454672b2319ac3eea8d2f9b URL: https://github.com/llvm/llvm-project/commit/72d8f79f0c31c9b95454672b2319ac3eea8d2f9b DIFF: https://github.com/llvm/llvm-project/commit/72d8f79f0c31c9b95454672b2319ac3eea8d2f9b.diff

[clang] ed13d8c - Fix memory leak complicated non-type template arguments.

Author: Richard Smith Date: 2020-12-18T13:42:24-08:00 New Revision: ed13d8c66781b50ff007cb089c5905f9bb9e8af2 URL: https://github.com/llvm/llvm-project/commit/ed13d8c66781b50ff007cb089c5905f9bb9e8af2 DIFF: https://github.com/llvm/llvm-project/commit/ed13d8c66781b50ff007cb089c5905f9bb9e8af2.diff

[clang] 939ba0b - Add tests for the absence of feature test macros for features we don't

Author: Richard Smith Date: 2020-12-18T13:42:23-08:00 New Revision: 939ba0b501b27a2535c9bb62b6f6dc027d49f76d URL: https://github.com/llvm/llvm-project/commit/939ba0b501b27a2535c9bb62b6f6dc027d49f76d DIFF: https://github.com/llvm/llvm-project/commit/939ba0b501b27a2535c9bb62b6f6dc027d49f76d.diff

[clang] b4c63ef - [c++20] Mark class type NTTPs as done and start defining the feature test macro.

Author: Richard Smith Date: 2020-12-18T13:42:23-08:00 New Revision: b4c63ef6dd90dba9af26a111c9a78b121c5284b1 URL: https://github.com/llvm/llvm-project/commit/b4c63ef6dd90dba9af26a111c9a78b121c5284b1 DIFF: https://github.com/llvm/llvm-project/commit/b4c63ef6dd90dba9af26a111c9a78b121c5284b1.diff

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added a comment. In D92160#2453814 , @OikawaKirie wrote: > Replies from the original author Hao Zhang > > --- > > Sorry for replying late. > >> I think it would be good to understand why the tests failed. Are some >> clients relying on the

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

dexonsmith added a comment. I've reviewed the code and it seems to do the right thing. I'd like a SYCL maintainer to take a look too though. (If for some reason changing the interface to an enum isn't desirable, maybe there's a compromise where there's an accessor that converts back to an

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 312882. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td

[PATCH] D84675: [clang][cli] Streamline MarhsallingInfoFlag description

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/ https://reviews.llvm.org/D84675

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

efriedma added a reviewer: rsmith. efriedma added a subscriber: rsmith. efriedma added a comment. @rsmith, can you look at the changes to overloading? I haven't looked at that code in a very long time. Otherwise looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/ https://reviews.llvm.org/D84189

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks updated this revision to Diff 312877. HazardyKnusperkeks added a comment. Test case adapted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ https://reviews.llvm.org/D93240 Files:

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17569 + // The order of intrinsic operands is (maskedoff, op1, op2, mask, vl). + SmallVector ShuffleOps(Ops.size()); + ShuffleOps[0] = Ops[1]; I think this whole

[PATCH] D51650: Implement target_clones multiversioning

lebedev.ri added a comment. In D51650#2454830 , @erichkeane wrote: > Since there seems to be at least a little renewed interest in this from a > handful of people lately, I spend the time to rebase this and do some minor > cleanup tasks. FWIW yes, i'm

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2463566 , @lebedev.ri wrote: > Once again, thank you @mstorsjo and @dmgreen! Awesome, thanks guys! I'll let you know tomorrow in the unlikely case if this still caused some other regressions as well (or possibly

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsandifo-arm added a comment. Herald added a subscriber: NickHung. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77056/new/ https://reviews.llvm.org/D77056 ___ cfe-commits mailing list

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); I think this function

[PATCH] D93452: [clangd] Trim memory periodically

MaskRay added inline comments. Comment at: llvm/lib/Support/Unix/Process.inc:122 +#if defined(HAVE_MALLOC_TRIM) + return malloc_trim(Pad); +#else If the user uses jemalloc/tcmalloc with glibc, malloc_trim may exist while the function may do nothing.

[PATCH] D93452: [clangd] Trim memory periodically

qchateau updated this revision to Diff 312853. qchateau added a comment. - Fix clang-tidy errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https://reviews.llvm.org/D93452 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

qchateau added a comment. Looks good to me, it removes a lot of duplication and corner cases. I'd have printed the tag for reference and pointers as well (`class Foo*` instead of `Foo*`). I don't think `Foo*` is much more understandable than `Foo`, so we decide that printing `class Foo` is

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. Once again, thank you @mstorsjo and @dmgreen! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://reviews.llvm.org/D87188 ___ cfe-commits mailing list

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG897c985e1e21: [InstCombine] Canonicalize SPF to abs intrinsic (authored by lebedev.ri). Changed prior to commit:

[clang] 897c985 - [InstCombine] Canonicalize SPF to abs intrinsic

Author: Roman Lebedev Date: 2020-12-18T21:18:14+03:00 New Revision: 897c985e1e21927b2870f964bb07ff293bd74407 URL: https://github.com/llvm/llvm-project/commit/897c985e1e21927b2870f964bb07ff293bd74407 DIFF: https://github.com/llvm/llvm-project/commit/897c985e1e21927b2870f964bb07ff293bd74407.diff

[clang] 5e5ef53 - [clang-format][NFC] Expand BreakBeforeBraces examples

Author: Björn Schäpers Date: 2020-12-18T19:08:03+01:00 New Revision: 5e5ef5359742c3feb6f41058a356a28c7ab3ea6d URL: https://github.com/llvm/llvm-project/commit/5e5ef5359742c3feb6f41058a356a28c7ab3ea6d DIFF:

[PATCH] D93170: [clang-format][NFC] Expand BreakBeforeBraces examples

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5ef5359742: [clang-format][NFC] Expand BreakBeforeBraces examples (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[clang] 7fef551 - Revert "Revert "[FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.""

Author: Kevin P. Neal Date: 2020-12-18T12:42:06-05:00 New Revision: 7fef551cb123d9f1956f8ec7a142bd8a63d25fa9 URL: https://github.com/llvm/llvm-project/commit/7fef551cb123d9f1956f8ec7a142bd8a63d25fa9 DIFF: https://github.com/llvm/llvm-project/commit/7fef551cb123d9f1956f8ec7a142bd8a63d25fa9.diff

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. Ok, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93221/new/ https://reviews.llvm.org/D93221

[PATCH] D93553: [clangd] Make our printing policies for Hover more consistent, especially tags

sammccall created this revision. sammccall added a reviewer: qchateau. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Different cases were using a

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2463447 , @dmgreen wrote: > Yeah. The reproducer seems to work OK with a patch something like this: > > diff --git a/llvm/lib/Analysis/InstructionSimplify.cpp > b/llvm/lib/Analysis/InstructionSimplify.cpp > index

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

dmgreen added a comment. Yeah. The reproducer seems to work OK with a patch something like this: diff --git a/llvm/lib/Analysis/InstructionSimplify.cpp b/llvm/lib/Analysis/InstructionSimplify.cpp index 35c21a0..c517286 100644

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop updated this revision to Diff 312827. russell.gallop edited the summary of this revision. russell.gallop added a comment. Apologies for the delay, I've had other things taking my time. Latest version uploaded. This fixes stage1 lit tests (on Windows and Linux) and adds scudo_cxx

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2463285 , @dmgreen wrote: > Thanks for the reproducer. I verified that it does indeed fail with this > patch. > > It seems to be doing this as a knock-on effect: https://godbolt.org/z/Y4z3je, > which does not

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

ftynse added a comment. Thanks! I have a couple of comments, but I will defer to @jdoerfert for approval in any case. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:676 + + /// Capture the above-defined paraneters for the parallel regions. + ///

[PATCH] D93525: [OpenMP] Add unbundling of archives containing bundled object files into device specific archives

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:142-144 + } else { +return Triple; + } No need `else` here Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:953-957

[PATCH] D72235: [clang-tidy] new altera unroll loops check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/altera/UnrollLoopsCheck.cpp:22 +void UnrollLoopsCheck::registerMatchers(MatchFinder *Finder) { + const auto ANYLOOP = anyOf(forStmt(), whileStmt(), doStmt()); + Finder->addMatcher(stmt(allOf(ANYLOOP, //

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

dmgreen added a comment. Thanks for the reproducer. I verified that it does indeed fail with this patch. It seems to be doing this as a knock-on effect: https://godbolt.org/z/Y4z3je, which does not verify: https://alive2.llvm.org/ce/z/PN7Rv5 ? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3356 EnumArgument<"State", "LoopHintState", - ["enable", "disable", "numeric", "assume_safety", "full"], - ["Enable", "Disable",

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies added a comment. @aaron.ballman @njames93 thanks for testing this out, the feedback, and the commit! Could you also take a look at D72235 unroll loops check ? It's been updated and is ready for review. CHANGES SINCE LAST ACTION

[PATCH] D89031: [SVE] Add support to vectorize_width loop pragma for scalable vectors

david-arm updated this revision to Diff 312802. david-arm edited the summary of this revision. Herald added a subscriber: NickHung. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89031/new/ https://reviews.llvm.org/D89031 Files: clang/docs/LanguageExtensions.rst

[PATCH] D93546: [clangd][NFC] Improve clangd status messages

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. clangd actions have

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 updated this revision to Diff 312796. njames93 added a comment. Moved a few members out of the class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://reviews.llvm.org/D93531 Files:

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2671-2673 + // See if this is a VLST coerced to a VLAT at the function boundary and + // the types match up. If so, use llvm.experimental.vector.extract to + // perform the conversion.

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/test/SemaObjC/attr-called-once.m:7 +void test2(double x CALLED_ONCE); // expected-error{{'called_once' attribute only applies to function-like parameters}} + +void test3(void (*foo)() CALLED_ONCE); // no-error

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2462995 , @vsavchenko wrote: > In D92039#2462889 , @aaron.ballman > wrote: > >> Your test cases suggest that this is not inter-procedurally checked; it >> seems to require

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:353 if (auto *AT = D->getType()->getContainedAutoType()) { - if (!AT->getDeducedType().isNull()) -DeducedType = AT->getDeducedType(); + DeducedType = AT->desugar(); }

[clang-tools-extra] 95c7b6c - [clangd] zap a few warnings

Author: Sam McCall Date: 2020-12-18T16:34:34+01:00 New Revision: 95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc URL: https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc DIFF: https://github.com/llvm/llvm-project/commit/95c7b6cadbc9a3d4376ef44edbeb3c8bb5b8d7fc.diff

[PATCH] D93543: clang-tidy: Leave the possibility of opting out having coloured diagnostic messages.

Abpostelnicu created this revision. Abpostelnicu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Afer this commit landed we always have coloured

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 added a comment. In D93531#2463052 , @sammccall wrote: > This adds a bit of complexity, making the code here a fair amount harder to > follow and verify the correctness of. > > - Do we have evidence that these allocations are causing a problem?

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

This revision was automatically updated to reflect the committed changes. Closed by commit rGc46c7c9bcf97: [clangd] Smarter hover on auto and decltype (authored by qchateau, committed by sammccall). Changed prior to commit: https://reviews.llvm.org/D93227?vs=312757=312791#toc Repository: rG

[clang-tools-extra] c46c7c9 - [clangd] Smarter hover on auto and decltype

Author: Quentin Chateau Date: 2020-12-18T16:27:09+01:00 New Revision: c46c7c9bcf9752971fe4bbcf67140c99066ad2e0 URL: https://github.com/llvm/llvm-project/commit/c46c7c9bcf9752971fe4bbcf67140c99066ad2e0 DIFF:

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:353 if (auto *AT = D->getType()->getContainedAutoType()) { - if (!AT->getDeducedType().isNull()) -DeducedType = AT->getDeducedType(); + DeducedType = AT->desugar(); }

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

curdeius added a comment. In D93528#2463030 , @HazardyKnusperkeks wrote: > In D93528#2462969 , @MyDeveloperDay > wrote: > >> So I guess my question is: >> >> 1. is this useful to pursue (either as is, or by

[PATCH] D84675: [clang][cli] Streamline MarhsallingInfoFlag description

jansvoboda11 updated this revision to Diff 312790. jansvoboda11 added a comment. Rebase, remove `DefaultValue` to avoid confusion with `Default` used for `BoolOptionBase`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

MyDeveloperDay added a comment. Maybe @JVApen can help as they logged https://bugs.llvm.org/show_bug.cgi?id=48539 I'm not a Qt developer so I can't really comment beyond fixing what was in the bug rpeort Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84675: Streamline MarhsallingInfoFlag description

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84675/new/

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

sammccall added a comment. This adds a bit of complexity, making the code here a fair amount harder to follow and verify the correctness of. - Do we have evidence that these allocations are causing a problem? (e.g. do we observe a significant decrease in RSS after the patch)? Naively I would

[PATCH] D93540: [clang] Use enum for LangOptions::SYCLVersion instead of unsigned

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese, bader, ABataev. Herald added subscribers: Anastasia, ebevhan, yaxunl. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a comment. In D93528#2462969 , @MyDeveloperDay wrote: > So I guess my question is: > > 1. is this useful to pursue (either as is, or by switching to us the reformat > method) > 2. is this useful standalone as the first pass > 3.

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 updated this revision to Diff 312785. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 Files: clang/include/clang/Driver/Options.td

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

thakis added a comment. Thanks for the fix :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92663/new/ https://reviews.llvm.org/D92663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. In D92039#2462889 , @aaron.ballman wrote: > Your test cases suggest that this is not inter-procedurally checked; it seems > to require all of the APIs to be annotated in order to get the same effect > that an

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay added a comment. In D93528#2462723 , @curdeius wrote: > Why not using clang-format's support for JavaScript? It seems more > complicated now, but it will probably allow to more easily change/add style > options. WDYT? > And what happens

[PATCH] D93452: [clangd] Trim memory after buildINdex

qchateau updated this revision to Diff 312781. qchateau added a comment. Herald added subscribers: llvm-commits, dexonsmith, hiraditya. Herald added a project: LLVM. - Add MallocTrim to llvm::sys::Process - Implement malloc trimming in ClangdLSPServer Repository: rG LLVM Github Monorepo

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. I don't know if this really fixes the problem. From the Docs: > An alternative way to attach

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall added a comment. In D92663#2462642 , @thakis wrote: > Seems to break tests on windows: http://45.33.8.238/win/30129/step_9.txt Sorry (and for the delay getting back to keyboard). 0336ff0a17e6aec831334aeb50e6685f6b184065

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

kristof.beyls added a comment. In D93221#2459903 , @ostannard wrote: > Why is this restricted to v7-A or later? The DSB and ISB instructions have > existed since v6T2 and v6M. This mitigation is never needed for M-class cores nor for v6T2. By

[clang-tools-extra] 0336ff0 - [clangd] Fix broken JSON test on windows

Author: Sam McCall Date: 2020-12-18T15:11:08+01:00 New Revision: 0336ff0a17e6aec831334aeb50e6685f6b184065 URL: https://github.com/llvm/llvm-project/commit/0336ff0a17e6aec831334aeb50e6685f6b184065 DIFF: https://github.com/llvm/llvm-project/commit/0336ff0a17e6aec831334aeb50e6685f6b184065.diff

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 updated this revision to Diff 312780. njames93 added a comment. Extend buffer behaviour to sendMessage. Calls to this function seem to be guarded(up the call stack) by a mutex so again we shouldn't worry about races. Besides there is no synchronization in the function currently when

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

aaron.ballman added a comment. In D92039#2462255 , @vsavchenko wrote: > In D92039#2458392 , @aaron.ballman > wrote: > >> > > > >> There have been efforts to add cross-TU support to the static analyzer, so >> I'm

[PATCH] D92577: Don't reject tag declarations in for loop clause-1

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the review! I've commit in 2d2498ec6c42b12eae873257e6ddcefe8348 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92577/new/

[clang] 2d2498e - No longer reject tag declarations in the clause-1 of a for loop.

Author: Aaron Ballman Date: 2020-12-18T07:56:17-05:00 New Revision: 2d2498ec6c42b12eae873257e6ddcefe8348 URL: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348 DIFF: https://github.com/llvm/llvm-project/commit/2d2498ec6c42b12eae873257e6ddcefe8348.diff

[PATCH] D84189: [clang][cli] Let denormalizer decide how to render the option based on the option class

jansvoboda11 updated this revision to Diff 312761. jansvoboda11 added a comment. Rebase, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84189/new/ https://reviews.llvm.org/D84189 Files: clang/include/clang/Driver/Options.td

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::readRawMessage

njames93 added a comment. 100% sure that failure is from trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://reviews.llvm.org/D93531 ___ cfe-commits mailing list

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

njames93 added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's something else > you'd like me to try. Thanks!

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

aaron.ballman closed this revision. aaron.ballman added a comment. In D72241#2461921 , @ffrankies wrote: > @aaron.ballman hmm, that is strange. I've rebased the patch and updated the > diff, let me know if this one doesn't work either or there's

[clang-tools-extra] e69e551 - new altera single work item barrier check

Author: Frank Derry Wanye Date: 2020-12-18T07:52:20-05:00 New Revision: e69e551e0e5fddffb6479da6a2998457104ba9e6 URL: https://github.com/llvm/llvm-project/commit/e69e551e0e5fddffb6479da6a2998457104ba9e6 DIFF:

  1   2   >