[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:243 +} +// If load has mutli-user, duplicate a amx load. +// %src = load <256 x i32>, <256 x i32>* %addr, align 64 vector Comment at: llv

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:124 + auto *II = cast(Tile); + // Tile is output from AMX intrinsic. The first operand of the + // intrinsic is row, the second operand of the intrinsic is column. pengfei wro

[PATCH] D93031: Enable fexec-charset option

tahonermann added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:244 bool Pascal; + ConversionState TranslationState; + abhina.sreeskantharajan wrote: > tahonermann wrote: > > Same concern here with respect to persisting the conversion

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 marked 2 inline comments as done. Bdragon28 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2152 + "powerpcle-unknown-linux-gnu", + "powerpcle-unknown-freebsd"

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313654. Bdragon28 added a comment. - Address review comment from MaskRay. - Incorporate changes from the Void powerpcle patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llv

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

aqjune created this revision. aqjune added reviewers: spatel, lebedev.ri, efriedma, nlopes, regehr, RKSimon, zhengyangl, nikic, hfinkel. Herald added subscribers: dmgreen, kbarton, hiraditya, nemanjai. aqjune requested review of this revision. Herald added projects: clang, LLVM. Herald added subsc

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313651. Bdragon28 added a comment. Trying again.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTar

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added a comment. The lld/ELF part change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313650. hoy marked an inline comment as done. hoy added a comment. Removing unnecessary test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llv

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313649. Bdragon28 edited the summary of this revision. Bdragon28 added a comment. Splitting up into multiple commits as per MaskRay's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy marked an inline comment as done. hoy added inline comments. Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:20 + +!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, enums: !2) +!1 = !DIFile(filename: "test.c", directory: "") -

[PATCH] D78058: option to write files to memory instead of disk

dexonsmith added a comment. In D78058#2464262 , @dexonsmith wrote: > I'll reply here once I've posted the RFC and patch (as I said, I'm hoping > next week) so you can take a look. I don't quite have my patch and RFC ready (and I may not until I'm back fr

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:20-21 #include "clang/Basic/Version.h" #include "clang/CrossTU/CrossTranslationUnit.h" #include "clang/Frontend/ASTUnit.h" #include "clang/Lex/Preprocessor.h" steakhal w

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added a comment. In D91927#2470818 , @LuoYuanke wrote: > In D91927#2469977 , @pengfei wrote: > >>> In my test case, it is transformed after Combine redundant instructions. >> >> Can we disable it for AMX typ

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2468350 , @spatel wrote: > It would be good to update those for consistency; the codegen tests are > supposed to be representative of what comes out of the IR optimizer. IIUC, we > could do the substitution on those file

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-linkage-names.ll:20 + +!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, enums: !2) +!1 = !DIFile(filename: "test.c", directory: "") is the debug info

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel added a comment. Yep, sorry, I'm just waiting for a final stamp of approval from one of the reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

xbolva00 added a comment. Can you reland this patch now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86844/new/ https://reviews.llvm.org/D86844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313639. LuoYuanke added a comment. Improve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c llvm/include/llvm

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3593 +def EnforceTCBLeaf : InheritableAttr { + let Spellings = [Clang<"enforce_tcb_leaf">]; + let Subjects = SubjectList<[Function]>; aaron.ballman wrote: > Are these two attributes mutual

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313635. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c llvm/includ

[PATCH] D91898: [attributes] Add a facility for defining and enforcing a Trusted Computing Base.

NoQ updated this revision to Diff 313633. NoQ added a comment. Add an error for conflicting attributes! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91898/new/ https://reviews.llvm.org/D91898 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/in

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added a comment. In D91927#2469977 , @pengfei wrote: >> In my test case, it is transformed after Combine redundant instructions. > > Can we disable it for AMX type? The pointer to AMX type is meaningless and > may result in bad perfomance. Ok,

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers created this revision. vabridgers added a reviewer: Szelethus. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. Herald a

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313630. hoy added a comment. Adding PTO checks in LLVM test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llvm/Passes/PassBuilder.h llvm/lib/Pass

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Is it because the triple is separated by `-`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93786/new/ https://reviews.llvm.org/

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote: > a

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

jdoerfert created this revision. jdoerfert added reviewers: tianshilei1992, jhuber6, JonChesterfield. Herald added subscribers: pengfei, guansong, bollu, hiraditya, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added proje

[PATCH] D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last

jdoerfert created this revision. jdoerfert added reviewers: tianshilei1992, jhuber6, JonChesterfield. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. S

[clang] 69132d1 - [Clang] Reverse test to save on indentation. NFC.

Author: Alexandre Ganea Date: 2020-12-23T19:24:53-05:00 New Revision: 69132d12deae749a8e4c9def5498ffa354ce1fa6 URL: https://github.com/llvm/llvm-project/commit/69132d12deae749a8e4c9def5498ffa354ce1fa6 DIFF: https://github.com/llvm/llvm-project/commit/69132d12deae749a8e4c9def5498ffa354ce1fa6.dif

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global aeubanks wrote

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 313621. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global hoy wrote: > a

[PATCH] D93148: Basic: Add native support for stdin to SourceManager and FileManager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ee43adfb20d: Basic: Add native support for stdin to SourceManager and FileManager (authored by dexonsmith). Changed prior to commit: https://revi

[clang] 3ee43ad - Basic: Add native support for stdin to SourceManager and FileManager

Author: Duncan P. N. Exon Smith Date: 2020-12-23T15:18:50-08:00 New Revision: 3ee43adfb20d5dc56b7043b314bd22f457c55483 URL: https://github.com/llvm/llvm-project/commit/3ee43adfb20d5dc56b7043b314bd22f457c55483 DIFF: https://github.com/llvm/llvm-project/commit/3ee43adfb20d5dc56b7043b314bd22f457c5

[PATCH] D92531: Basic: Support named pipes natively in SourceManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG245218bb3555: Basic: Support named pipes natively in SourceManager and FileManager (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D92531?vs=311004&id=313618#toc Repository:

[clang] 245218b - Basic: Support named pipes natively in SourceManager and FileManager

Author: Duncan P. N. Exon Smith Date: 2020-12-23T14:57:41-08:00 New Revision: 245218bb355599771ba43a0fe1449d1670f2666c URL: https://github.com/llvm/llvm-project/commit/245218bb355599771ba43a0fe1449d1670f2666c DIFF: https://github.com/llvm/llvm-project/commit/245218bb355599771ba43a0fe1449d1670f2

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

njames93 added a comment. Can you apply the clang-format patch suggested by the pre-merge bot. Alternatively, if you have a recent version of clang-format and the appropriate git-hooks you should be able to run `git clang-format` for the same effect. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Functionally LGTM. Minor suggestion. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:2169 + return false; +} + Is this something that could reasonably just

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

abhinavgaba added a comment. The patch currently asserts for the following: #include typedef struct { int a; double *b; } C; #pragma omp declare mapper(default: C s) map(s.a, s.b[0:2]) int

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global aeubanks wrote: > h

[clang-tools-extra] 74b3ace - [clangd] Fix case mismatch crash on in CDB on windows after 92dd077af1ff8

Author: Sam McCall Date: 2020-12-23T22:42:45+01:00 New Revision: 74b3acefc7b6355e89bb9b09dc88a5948f65c342 URL: https://github.com/llvm/llvm-project/commit/74b3acefc7b6355e89bb9b09dc88a5948f65c342 DIFF: https://github.com/llvm/llvm-project/commit/74b3acefc7b6355e89bb9b09dc88a5948f65c342.diff LO

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks added a comment. In D93776#2470524 , @curdeius wrote: > Seems okay at the first glance. I'm wondering if we can find a better name > though. I'm all in for a better name. :) I could not think of any (my first shot was `IgnoredMacros`,

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global hoy wrote: > a

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global aeubanks wrote: > d

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

curdeius added a comment. Seems okay at the first glance. I'm wondering if we can find a better name though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 ___

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 313607. hoy added a comment. Undoing changes to the clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h llvm/lib

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2470387 , @dblaikie wrote: > Please remove the clang test change - if this is an LLVM change with LLVM > test coverage, that's enough. (we don't generally test every LLVM change from > both LLVM and Clang) Sounds good. >

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:54 TYPE(FunctionTypeLParen) \ + TYPE(StatementAttributeLikeMacro) \ TYPE(ImplicitStringLite

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, JVApen. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rG47877c9079c2: [clang-format] Add SpaceBeforeCaseColon option (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ http

[clang] 47877c9 - [clang-format] Add SpaceBeforeCaseColon option

Author: Björn Schäpers Date: 2020-12-23T22:07:14+01:00 New Revision: 47877c9079c27f19a954b660201ea47717c82fec URL: https://github.com/llvm/llvm-project/commit/47877c9079c27f19a954b660201ea47717c82fec DIFF: https://github.com/llvm/llvm-project/commit/47877c9079c27f19a954b660201ea47717c82fec.diff

[PATCH] D93163: [clang-format] Fix handling of ## comments in TextProto

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG374f1d81febf: [clang-format] Fix handling of TextProto comments (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 374f1d8 - [clang-format] Fix handling of TextProto comments

Author: Björn Schäpers Date: 2020-12-23T22:07:13+01:00 New Revision: 374f1d81febf8143e8e633296a42c2311699c5b3 URL: https://github.com/llvm/llvm-project/commit/374f1d81febf8143e8e633296a42c2311699c5b3 DIFF: https://github.com/llvm/llvm-project/commit/374f1d81febf8143e8e633296a42c2311699c5b3.diff

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2467915 , @nlopes wrote: > This patch regressed the following test of Transforms/InstCombine/abs-1.ll: > (need to drop NSW in this case). > > define i8 @nabs_canonical_3(i8 %x) { > %0: > %cmp = icmp slt i8 %x,

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global hoy wrote: > d

[PATCH] D93775: [WebAssembly] Prototype extending pairwise add instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D93772: [Clang][Driver] Fix read-after-free when using /clang:

aganea created this revision. aganea added reviewers: thakis, hans, rnk, neerajksingh. aganea requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in https://bugs.llvm.org/show_bug.cgi?id=42501 Fixes PR42501 Repository: rG LLVM

[clang] c7e825b - [format][NFC] Use unsigned char as the base of all enums in FormatStyle

Author: Nathan James Date: 2020-12-23T20:27:44Z New Revision: c7e825b910a96c42bda1de4e7fb34c369da76625 URL: https://github.com/llvm/llvm-project/commit/c7e825b910a96c42bda1de4e7fb34c369da76625 DIFF: https://github.com/llvm/llvm-project/commit/c7e825b910a96c42bda1de4e7fb34c369da76625.diff LOG:

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

This revision was automatically updated to reflect the committed changes. Closed by commit rGc7e825b910a9: [format][NFC] Use unsigned char as the base of all enums in FormatStyle (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

atmnpatel updated this revision to Diff 313593. atmnpatel added a comment. As expected, @fhahn was right, adding willreturn to all those tests was an artifact from previous revisions of this patch and it passed the tests so I didn't pay them any mind, but I removed them now. Repository: rG L

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global dblaikie wrote: > D

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

lebedev.ri added a comment. In D87188#2470392 , @thakis wrote: > Heads up: Breaks a test for us: > https://bugs.chromium.org/p/chromium/issues/detail?id=1161542 > > (No reduced repro yet, might be UB, just fyi at this point.) Thanks for headsup. For now

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

dblaikie added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:48-49 +// LPIPELINE: Unique Internal Linkage Names +// NPIPELINE: Running pass: UniqueInternalLinkageNamesPass // PLAIN: @_ZL4glob = internal global Does this test

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

thakis added a comment. Heads up: Breaks a test for us: https://bugs.chromium.org/p/chromium/issues/detail?id=1161542 (No reduced repro yet, might be UB, just fyi at this point.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87188/new/ https://re

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. Please remove the clang test change - if this is an LLVM change with LLVM test coverage, that's enough. (we don't generally test every LLVM change from both LLVM and Clang) I'd still be curious if you could look around to see whether there are other cases of function

[PATCH] D93082: Append ".__part." to all basic block section symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34e70d722dfd: Append ".__part." to every basic block section symbol. (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://revie

[clang] 34e70d7 - Append ".__part." to every basic block section symbol.

Author: Sriraman Tallam Date: 2020-12-23T11:35:44-08:00 New Revision: 34e70d722dfd0e73d460802e8d43d3a885d24784 URL: https://github.com/llvm/llvm-project/commit/34e70d722dfd0e73d460802e8d43d3a885d24784 DIFF: https://github.com/llvm/llvm-project/commit/34e70d722dfd0e73d460802e8d43d3a885d24784.dif

[clang] 4c37453 - clang: Build and run FrontendTests with CLANG_ENABLE_STATIC_ANALYZER=OFF too

Author: Nico Weber Date: 2020-12-23T14:27:09-05:00 New Revision: 4c37453a04f942dd676af1eda5d0760d4ffe8927 URL: https://github.com/llvm/llvm-project/commit/4c37453a04f942dd676af1eda5d0760d4ffe8927 DIFF: https://github.com/llvm/llvm-project/commit/4c37453a04f942dd676af1eda5d0760d4ffe8927.diff LO

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. ...and two more in 1876a2914fe0bedf50f7be6a305f5bf35493e496 . Sorry for the churn! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://revie

[clang] 1876a29 - Revert more changes that landed on top of 741978d727

Author: Nico Weber Date: 2020-12-23T14:20:21-05:00 New Revision: 1876a2914fe0bedf50f7be6a305f5bf35493e496 URL: https://github.com/llvm/llvm-project/commit/1876a2914fe0bedf50f7be6a305f5bf35493e496 DIFF: https://github.com/llvm/llvm-project/commit/1876a2914fe0bedf50f7be6a305f5bf35493e496.diff LO

[clang] bbd758a - Revert "This is a test commit"

Author: Alan Phipps Date: 2020-12-23T13:04:37-06:00 New Revision: bbd758a7913b1c374ca26e5a734a01200754fe0e URL: https://github.com/llvm/llvm-project/commit/bbd758a7913b1c374ca26e5a734a01200754fe0e DIFF: https://github.com/llvm/llvm-project/commit/bbd758a7913b1c374ca26e5a734a01200754fe0e.diff L

[clang] b920adf - This is a test commit

Author: Alan Phipps Date: 2020-12-23T12:57:27-06:00 New Revision: b920adf3b4f16bef8dde937b67874d8e8ac1030e URL: https://github.com/llvm/llvm-project/commit/b920adf3b4f16bef8dde937b67874d8e8ac1030e DIFF: https://github.com/llvm/llvm-project/commit/b920adf3b4f16bef8dde937b67874d8e8ac1030e.diff L

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

Quuxplusone added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:265 + // We don't use `SuppressAccessChecks` here because + // it supresses ALL the dignostics kinds, but we need to keep some of them. + // For instance marked as unavailable: Sp

[PATCH] D93769: RFC [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:429 + case PFC_Source: +//Builder.defineMacro("__FLT_EVAL_METHOD__", Twine("0")); +NewFPFeatures.setFPEvalMethodOverride(LangOptions::FEM_Source); @rjmccall I would like to push a new

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. I reverted this (and a bunch of stuff that landed on top of it) in 7ad666798f12456d9e663e763e17e29007c3728d for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D93769: RFC [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc created this revision. mibintc added reviewers: kpn, sepavloff, andrew.w.kaylor, rjmccall. Herald added subscribers: dexonsmith, dang. mibintc requested review of this revision. Herald added a project: clang. The Intel compiler supports the option -fp-model={source|double|extended} which

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2470189 , @hoy wrote: > In D93747#2470178 , @tmsriram wrote: > >> In D93747#2469556 , @hoy wrote: >> In D93656

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2470178 , @tmsriram wrote: > In D93747#2469556 , @hoy wrote: > >>> In D93656 , @dblaikie wrote: >>> Though the C case is interesting - it means you'll

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. I verified it's due to this change. https://bugs.chromium.org/p/chromium/issues/detail?id=1161230#c15 has a stand-alone repro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 _

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Please, somebody look at this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 313566. hoy edited the summary of this revision. hoy added a comment. Checking pipeline in clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: clang/lib/Co

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2469556 , @hoy wrote: >> In D93656 , @dblaikie wrote: >> Though the C case is interesting - it means you'll end up with C functions >> with the same DWARF 'name' but different linkage na

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

njames93 added a comment. In D93758#2470124 , @MyDeveloperDay wrote: > I don't have any major issues with this other than it makes Format.h a bit > more ugly. (there are more ugly and harder to understand pieces of code than > this change!) > > We'll on

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

MyDeveloperDay added a comment. I don't have any major issues with this other than it makes Format.h a bit more ugly. (there are more ugly and harder to understand pieces of code than this change!) We'll only normally really have 1 of these in play at any one time, but it is passed around quit

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

njames93 updated this revision to Diff 313559. njames93 added a comment. - Update dump_format_style script Only tweaked regex to support enum : ... { Decided there wasn't much to gain from supporting nested types etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

thakis added a comment. Heads-up: Looks like one of these changes, likely this one for CodeGen, made sanitizer output way larger: https://bugs.chromium.org/p/chromium/issues/detail?id=1161230 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2522fa053b62: [clangd] Do not take stale definition from the static index. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ h

[clang-tools-extra] 2522fa0 - [clangd] Do not take stale definition from the static index.

Author: Aleksandr Platonov Date: 2020-12-23T18:21:38+03:00 New Revision: 2522fa053b62520ae48b4b27117ca003a2c878ab URL: https://github.com/llvm/llvm-project/commit/2522fa053b62520ae48b4b27117ca003a2c878ab DIFF: https://github.com/llvm/llvm-project/commit/2522fa053b62520ae48b4b27117ca003a2c878ab.

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2468853 , @aaron.ballman wrote: > Yeah, I kind of figured that might be the cause. I'm not 100% convinced (one > way or the other) if the suppress attribute should get a GNU spelling. The > `[[]]` spellings are avai

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. rapgenic requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. On some editors (namely VSCode) documentLinks are rendered with an unde

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 313550. vsavchenko added a comment. Refine condition for statement attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: clang/lib/Parse/ParseStmt.cpp

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG031743cb5b3c: [clang-format] PR48539 ReflowComments breaks Qt translation comments (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rG5426b2f9ed9f: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 031743c - [clang-format] PR48539 ReflowComments breaks Qt translation comments

Author: mydeveloperday Date: 2020-12-23T14:45:14Z New Revision: 031743cb5b3c6c2df85a67d8533ef72a95e76cdc URL: https://github.com/llvm/llvm-project/commit/031743cb5b3c6c2df85a67d8533ef72a95e76cdc DIFF: https://github.com/llvm/llvm-project/commit/031743cb5b3c6c2df85a67d8533ef72a95e76cdc.diff LOG

[clang] 5426b2f - [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

Author: mydeveloperday Date: 2020-12-23T14:45:14Z New Revision: 5426b2f9ed9f6f3a3e1d6452325f7a49a5d08ec4 URL: https://github.com/llvm/llvm-project/commit/5426b2f9ed9f6f3a3e1d6452325f7a49a5d08ec4 DIFF: https://github.com/llvm/llvm-project/commit/5426b2f9ed9f6f3a3e1d6452325f7a49a5d08ec4.diff LOG

[PATCH] D93758: [format][NFC] Use unsigned char as the base of all enums in FormatStyle

njames93 added a comment. In D93758#2469967 , @MyDeveloperDay wrote: > We should probably check the docs/tools/dump_format_style.py still works Good catch, I'll update the script to optionally take an underlying type argument. Should that be part of thi

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added inline comments. Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:163 + } + static bool canBeCalled(Kind K) { +return (K & DefinitelyCalled) == DefinitelyCalled && K != Reported; NoQ wrote: > "Can be called" sounds like "Someone's allowed

  1   2   >