[PATCH] D86743: [analyzer] Ignore VLASizeChecker case that could cause crash

vabridgers added a comment. @baloghadamsoftware , these changes do seem to help the case described. This patch isn't quite up to date, and needs to be integrated with changes from @balazske (my integration is hacky and needs to be cleaned up). I'll continue working on this, and get back to

[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. If that's how it's supposed to look, than this patch is fine. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. I don't fully understand the new control flow, but at least the new //behavior// (after applying this patch) looks like an improvement to me. I recommend rebasing on top-of-tree,

[PATCH] D93806: [clang-format] PR48569 clang-format fails to align case label with `switch` with Whitesmith Indentation

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, curdeius, JakeMerdichAMD, jbcoe. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48569 This is a tentative fix which

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. I think this LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313700. MarkMurrayARM added a comment. More review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D93786: [OpenMP][Fix] Make the arch selector for x86_64 work

jdoerfert added a comment. In D93786#2470796 , @tianshilei1992 wrote: > Is it because the triple is separated by `-`? x86 and 64 is separated by - in the architecture list so `getArchTypeForLLVMName` will not recognize "x86_64". Repository: rG LLVM

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:151 +AARCH64_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + (AArch64::AEK_RAS)) AARCH64_CPU_NAME("cortex-r82", ARMV8R, FK_CRYPTO_NEON_FP_ARMV8,

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313694. MarkMurrayARM added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files: clang/test/Driver/aarch64-cpus.c

[PATCH] D93800: [clangd][WIP] Add caching behaviour for clang-format config

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, hokein. Herald added subscribers: usaxena95, arphaman, mgorny. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. I'm not super

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

dmgreen added inline comments. Comment at: llvm/include/llvm/Support/ARMTargetParser.def:306 +ARM_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + ARM::AEK_RAS) ARM_CPU_NAME("cortex-x1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

nlopes added inline comments. Comment at: llvm/lib/IR/IRBuilder.cpp:1021 Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC)); return CreateShuffleVector(V, Undef, Zeros, Name + ".splat"); } while at it, don't you want to change this one

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien abandoned this revision. pvellien added a comment. This change is wrong, the different patch is landed in llvm to handle global address space access in gfx60x for HSA Os. So closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92115/new/ https://reviews.llvm.org/D92115

[PATCH] D93022: [ARM][AArch64] Add Cortex-A78C Support for Clang and LLVM

MarkMurrayARM updated this revision to Diff 313678. MarkMurrayARM added a comment. Incorporate reviewer comments. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 Files:

[PATCH] D93796: [clangd][fuzzyFind] Do not show stale symbols in the result.

ArcsinX created this revision. ArcsinX added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is follow up to D93393

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke added a comment. In D91927#2471140 , @pengfei wrote: > LGTM. Thanks for the refactors. Maybe better to wait for a few days to see if > others have objections. Thank Pengfei for the review. Sure, I'll wait for a few days. Repository: rG

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the refactors. Maybe better to wait for a few days to see if others have objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313669. LuoYuanke added a comment. Refine comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c

[PATCH] D93763: [clangd] Add a flag to disable the documentLinks LSP request

rapgenic updated this revision to Diff 313667. rapgenic added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93763/new/ https://reviews.llvm.org/D93763 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313663. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thank you. I'm happy with the analysis and i have nothing more to say really :) Comment at: clang/lib/Analysis/CalledOnceCheck.cpp:822 + /// calling the parameter