[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 313828. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

aqjune added inline comments. Comment at: llvm/lib/IR/IRBuilder.cpp:1021 Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC)); return CreateShuffleVector(V, Undef, Zeros, Name + ".splat"); } aqjune wrote: > nikic wrote: > > aqjune wrote:

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

JohelEGP added a comment. I have another case: `.clang-format`: BraceWrapping: AfterStruct: true SplitEmptyRecord: true BreakBeforeBraces: Custom Input and expected formatted output: template struct rep> { using type = T; }; Actual formatted output: template struct

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. Okay, I'll gently land this. I was just wondering whether insertelements having heterogenous placeholder would be problematic (this patch makes some of insertelement use poison, but not all), but it may not matter very much. Repository: rG LLVM Github Monorepo

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

njames93 added a comment. In D93844#2472346 , @MyDeveloperDay wrote: > I'm a little confused why this is needed as clang-format always read up the > directory tree until it see a .clang-format file, perhaps I don't quite > understand the use case.

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks added a comment. In D93844#2472346 , @MyDeveloperDay wrote: > I'm a little confused why this is needed as clang-format always read up the > directory tree until it see a .clang-format file, perhaps I don't quite > understand the use

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

MyDeveloperDay added a comment. I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory? Repository: rG

[PATCH] D93846: Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added a comment. Thank you for this patch, a few process issues. Comment at: clang/include/clang/Format/Format.h:58 + /// If true, the empty line is inserted before access modifiers + /// \code you need to run clang/doc/tools/dump_style.py

[PATCH] D93846: Add flag to suppress empty line insertion before access modifier

thezbyg created this revision. thezbyg added a reviewer: MyDeveloperDay. thezbyg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add new option called InsertEmptyLineBeforeAccessModifier. Empty line before access modifier is inserted if

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

nikic added a comment. In D93586#2472314 , @aqjune wrote: > There are 3 more patches: > > https://reviews.llvm.org/D93793 (IRBuilder's CreateVectorSplat) > https://reviews.llvm.org/D93817 (Other transformations) > https://reviews.llvm.org/D93818

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

aqjune added inline comments. Comment at: llvm/lib/IR/IRBuilder.cpp:1021 Value *Zeros = ConstantAggregateZero::get(VectorType::get(I32Ty, EC)); return CreateShuffleVector(V, Undef, Zeros, Name + ".splat"); } nikic wrote: > aqjune wrote: > > nlopes wrote:

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. There are 3 more patches: https://reviews.llvm.org/D93793 (IRBuilder's CreateVectorSplat) https://reviews.llvm.org/D93817 (Other transformations) https://reviews.llvm.org/D93818 (LangRef) Would it be desirable if I land all of these at once as well as this (93586) when

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, krasimir, klimek, njames93, mitchell-stellar. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:1073 for (unsigned i = 0; i != VWidth; ++i) { if (!DemandedElts[i]) { // If not

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:252 + + if (Tok && Tok->is(tok::kw_template) && + Style.BraceWrapping.SplitEmptyRecord && EmptyBlock) { Why is this not just also in the previous if?

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat use poison as inselt's placeholder

nikic added inline comments. Comment at: llvm/lib/IR/IRBuilder.cpp:1012 // First insert it into an undef vector so we can shuffle it. Type *I32Ty = getInt32Ty(); undef vector -> poison vector Comment at: llvm/lib/IR/IRBuilder.cpp:1021

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

lebedev.ri added a comment. In D76572#2472256 , @Quuxplusone wrote: > In D76572#2472221 , @lebedev.ri > wrote: > >> Do you plan to follow-up with the diagnostic itself, in some form? > > No, I don't. My diagnostic

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone added a subscriber: oneraynyday. Quuxplusone added a comment. In D76572#2472221 , @lebedev.ri wrote: > Do you plan to follow-up with the diagnostic itself, in some form? No, I don't. My diagnostic code was just an ad-hoc noisy hack with no

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

JohelEGP accepted this revision. JohelEGP added a comment. This revision is now accepted and ready to land. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

lebedev.ri added a comment. Do you plan to follow-up with the diagnostic itself, in some form? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572 ___ cfe-commits

[PATCH] D93822: [clang][Sema] Add diagnostics for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 313788. lebedev.ri added a comment. - Properly handle dependent types (bailout instead of crashing) - Add `ASTContext::getCorrespondingSignedType()` - Add fix-it for the `unsigned long r = int(x) * int(y)` case Repository: rG LLVM Github Monorepo

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, klimek. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48594 Empty or small templates were not being treated the

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

qchateau added a comment. Note: Build fails due to clang-tidy warnings in tests. I chose to keep the naming consistent with what's already in place rather than fix the clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

qchateau updated this revision to Diff 313776. qchateau added a comment. - Smaller reversed refs memory usage - Fix Dex::estimateMemoryUsage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files:

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. In D92257#2452063 , @MyDeveloperDay wrote: > This didn't really address the comments, what is the point of the maximum? > what if the maximum is > the ColumnLimit?

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks updated this revision to Diff 313774. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. I'm back! I've reworked the change to correctly(*) work with line comment sections. *: That is