[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

aeubanks added a comment. Thanks, and checking other compilers with godbolt is a good idea (I had tried gcc locally but it was likely too old) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[clang-tools-extra] b4c5e19 - Temporarily disable to clang-tidy tests on Windows

Author: Nico Weber Date: 2021-01-01T23:19:48-05:00 New Revision: b4c5e19da74773b86662cbe5a7437f72116f3615 URL: https://github.com/llvm/llvm-project/commit/b4c5e19da74773b86662cbe5a7437f72116f3615 DIFF: https://github.com/llvm/llvm-project/commit/b4c5e19da74773b86662cbe5a7437f72116f3615.diff

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added a comment. In D92936#2476091 , @aeubanks wrote: > This broke [ https://godbolt.org/z/9EG7ev ] > is this intentional? Yes, intentional. This brings Clang's C++14 conformance into line with GCC/EDG/MSVC, who all already (correctly)

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

aeubanks added a comment. This broke struct A { A(); A(A&&)=delete; private: A(const A&); friend class B; }; struct B { A foo() { A a; return a; } }; with /tmp/a.cc:12:12: error: call to deleted constructor of 'A' return a;

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. @MyDeveloperDay Would you mind explaining what changes you're wanting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___ cfe-commits

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 314229. alokmishra.besu added a comment. Rebased with current branch to avoid patch failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944 Files:

[clang] ec9f2c3 - test/OpenMP/parallel_codegen.cpp: Allow multiple result attributes

Author: Fangrui Song Date: 2021-01-01T10:46:34-08:00 New Revision: ec9f2c3be070ec2fc4d45f13c70e68c8c0deafc2 URL: https://github.com/llvm/llvm-project/commit/ec9f2c3be070ec2fc4d45f13c70e68c8c0deafc2 DIFF: https://github.com/llvm/llvm-project/commit/ec9f2c3be070ec2fc4d45f13c70e68c8c0deafc2.diff

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1) maybe I

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki reclaimed this revision. danielmarjamaki added a comment. ok.. thanks for the reviews. I will see if I can make some new check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92634/new/ https://reviews.llvm.org/D92634

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu added a comment. Emitting error instead of instantiation in clang/lib/Sema/TreeTransform.h. Added a TODO for future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944

[PATCH] D91944: OpenMP 5.0 metadirective

alokmishra.besu updated this revision to Diff 314224. alokmishra.besu marked an inline comment as done. alokmishra.besu added a comment. All clang test and clang-tidy pass. Ran clang-format on all code, except clang/include/clang/Serialization/ASTBitCodes.h which was formatting unrelated code

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/diagnostic-initialization.cpp:7 +template +class initializer_list { + const _E *__begin_; Looking at other places like `clang/test/CXX/dcl.decl/dcl.init/dcl.init.list/p3.cpp`, I think you don't

[PATCH] D93962: [Sema] Fix the program state in reference initialization

Quuxplusone added a comment. This could use some tests. (What's observably bad about the old code's behavior? does this patch fix that behavior?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93962/new/ https://reviews.llvm.org/D93962

[PATCH] D93955: [Sema] Add support for reporting multiple errors during initialization

nullptr.cpp updated this revision to Diff 314214. nullptr.cpp edited the summary of this revision. nullptr.cpp added a comment. Separate out D93962 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93955/new/

[PATCH] D93962: [Sema] Fix the program state in reference initialization

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to [dcl.init.ref]p5: > A reference to type “cv1 T1” is initialized by an expression of type “cv2 T2” > as follows: > > — If the

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg added a comment. When access modifier is in the same line with previous tokens, **UnwrappedLineFormatter::formatFirstToken** is called with **RootToken.NewlinesBefore** == 0, but empty line is only inserted if **RootToken.NewlinesBefore** == 1. The following change fixes this and

[PATCH] D93961: [clang-tidy][NFC] Fix a build warning due to an extra semicolon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd5324c052b21: [clang-tidy][NFC] Fix a build warning due to an extra semicolon (authored by nullptr.cpp). Repository:

[clang-tools-extra] d5324c0 - [clang-tidy][NFC] Fix a build warning due to an extra semicolon

Author: Yang Fan Date: 2021-01-01T16:00:20+08:00 New Revision: d5324c052b21741d8d9f980d796604589b85c97a URL: https://github.com/llvm/llvm-project/commit/d5324c052b21741d8d9f980d796604589b85c97a DIFF: https://github.com/llvm/llvm-project/commit/d5324c052b21741d8d9f980d796604589b85c97a.diff