[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. Turns out the `true/true` bug goes quite deep. I've managed to resolve the first bit of it with a hack that I'm sure will warrant some criticism, but I haven't familiarised myself with this codebase enough to write a cleaner version. The second issue I'm still

[PATCH] D93817: Update transformations to use poison for insertelement/shufflevector's placeholder value

aqjune added a comment. I'll split this patch into smaller pieces, so they're able to get reviewed more easily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93817/new/ https://reviews.llvm.org/D93817

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. After writing a unit test, I've found that a combination of `AfterEnum: true` and `AllowShortEnumsOnASingleLine: true` doesn't function properly. My next revision will include a fix for that alongside the unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

vitalybuka added a comment. Something is not initialized tihttp://lab.llvm.org:8011/#/builders/74/builds/1834/steps/9/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D93979: [clang-tidy] Fix windows tests

njames93 added a comment. I don't have a (reliable) windows machine to test so can you take a look please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93979/new/ https://reviews.llvm.org/D93979 ___

[PATCH] D93979: [clang-tidy] Fix windows tests

njames93 created this revision. njames93 added a reviewer: thakis. Herald added subscribers: kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attempt to fix the 2 failing tests identifier in 48646.

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f0d162d672: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. > This seems to be that in "Attach" mode, then > AllowShortEnumsOnASingleLine=false doesn't attach the brace. That is correct, but the main issue is that `AfterEnum: false`, which Attach mode implies, doesn't function correctly. > Said all that, it *seems* to me that

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2475852 , @dblaikie wrote: > In D93747#2470504 , @hoy wrote: > >> In D93747#2470387 , @dblaikie wrote: >> >>> Please remove the clang test

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 314259. hoy added a comment. Adding a switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy updated this revision to Diff 314257. hoy added a comment. Addressing comments from dblaikie. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93656/new/ https://reviews.llvm.org/D93656 Files: llvm/include/llvm/Passes/PassBuilder.h

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

hoy added a comment. In D93656#2475856 , @dblaikie wrote: > Looks good - test cases might benefit from some descriptive comments > (explaining why the pseudo probe pass needs to be enabled to test the unique > linkage name pass - I guess to check that

[clang-tools-extra] 7af6a13 - [NFC] Switch up some dyn_cast calls

Author: Nathan James Date: 2021-01-02T19:56:27Z New Revision: 7af6a134508cd1c7f75c6e3441ce436f220f30a4 URL: https://github.com/llvm/llvm-project/commit/7af6a134508cd1c7f75c6e3441ce436f220f30a4 DIFF: https://github.com/llvm/llvm-project/commit/7af6a134508cd1c7f75c6e3441ce436f220f30a4.diff LOG:

[clang] 4c77a0f - [PowerPC] NFC: Apply minor clang-format fix

Author: Brandon Bergren Date: 2021-01-02T12:21:28-06:00 New Revision: 4c77a0f1ce6f950805f567ff6505f7c18e62e288 URL: https://github.com/llvm/llvm-project/commit/4c77a0f1ce6f950805f567ff6505f7c18e62e288 DIFF:

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cee9d0cf896: [PowerPC] Support powerpcle target in Clang [3/5] (authored by Bdragon28). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 2288319 - [PowerPC] Enable OpenMP for powerpcle target. [5/5]

Author: Brandon Bergren Date: 2021-01-02T12:18:07-06:00 New Revision: 2288319733cd5f525bf7e24dece08bfcf9d0ff9e URL: https://github.com/llvm/llvm-project/commit/2288319733cd5f525bf7e24dece08bfcf9d0ff9e DIFF:

[clang] 6cee9d0 - [PowerPC] Support powerpcle target in Clang [3/5]

Author: Brandon Bergren Date: 2021-01-02T12:17:58-06:00 New Revision: 6cee9d0cf896d83fa8f87b7f8d67ae2dfdbc1bf9 URL: https://github.com/llvm/llvm-project/commit/6cee9d0cf896d83fa8f87b7f8d67ae2dfdbc1bf9 DIFF:

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The DefineOutline tweak can now

[PATCH] D93977: [clangd] Pass DraftStore to Tweak Apply and Prepare.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This enables multi file edit

[PATCH] D93919: [PowerPC] Support powerpcle target in Clang [3/5]

Bdragon28 updated this revision to Diff 314246. Bdragon28 added a comment. Update altivec changes after fd739804e0591468762eb87488a497a3f7d4afb0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nlopes added a comment. In D87188#2476230 , @thakis wrote: > In D87188#2470401 , @lebedev.ri > wrote: > >> In D87188#2470392 , @thakis wrote: >> >>> Heads up: Breaks a test

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

thakis added a comment. In D87188#2470401 , @lebedev.ri wrote: > In D87188#2470392 , @thakis wrote: > >> Heads up: Breaks a test for us: >> https://bugs.chromium.org/p/chromium/issues/detail?id=1161542 >> >> (No

[PATCH] D72281: [Matrix] Add matrix type to Clang.

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7855 + return; +RowsExpr = Columns.get(); + } else { @fhahn Should this be ColsExpr? ``` ColsExpr = Columns.get(); ``` Noticed when looking at

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added a comment. In D93938#2476186 , @MyDeveloperDay wrote: > I think we are missing some clarity in this bug as to what the actual problem > is, I do agree the test looks wrong, I agree on this. If like to see a more exhaustive test suite for

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. I think we are missing some clarity in this bug as to what the actual problem is, I do agree the test looks wrong, This seems to be that in "Attach" mode, then AllowShortEnumsOnASingleLine=false doesn't attach the brace. I'm somewhat struggling to understand

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki added a comment. > Besides, the return value should be the exact value computed from the two > integers, even unknown, rather than undefined. As the developers may overflow > an integer on purpose. I am not sure what you mean. If there is undefined behavior then the value