[PATCH] D95204: [lld-macho] Switch default to new Darwin port

int3 updated this revision to Diff 321921. int3 marked an inline comment as done. int3 added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D96196: [Sema][NFC] Create Sema::BuildImplicitCast

fcloutier created this revision. Herald added a subscriber: jfb. Herald added a reviewer: aaron.ballman. fcloutier requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This change creates

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: dexonsmith, hiraditya. yaxunl requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Currently managed variables are emitted as undefined symbols, which causes

[PATCH] D95970: [HIP] Allow undefined symbols

yaxunl abandoned this revision. yaxunl added a comment. In D95970#2540669 , @tra wrote: > In D95970#2540414 , @yaxunl wrote: > >> In D95970#2540303 , @tra wrote: >> >>>

[PATCH] D95204: [lld-macho] Switch default to new Darwin port

smeenai added inline comments. Comment at: llvm/utils/gn/build/BUILD.gn:240 if (host_os == "mac") { - ldflags += [ "-fuse-ld=lld.darwinnew" ] + ldflags += [ "-fuse-ld=ld64.lld" ] } else { I'm pretty sure `-fuse-ld=ld64.lld` won't work ... the

[PATCH] D96156: [clang][cli] Generate and round-trip PreprocessorOutput options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96156/new/ https://reviews.llvm.org/D96156

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added a comment. @Meinersbur Sorry, I haven't gotten very far yet in reviewing this, but I'll try to work on this more soon. Comment at: clang/include/clang/AST/StmtOpenMP.h:31 +/// Representation of an OpenMP canonical loop. +/// I think it would be

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

MaskRay added a comment. The problem is that we have `-lc++ (optional -lc++abi/-lcxxrt/others) (optional -lpthread))` dependency. While we can control `-lpthread` with `-pthread` (which does extra things on its own), we cannot control `(optional -lc++abi/-lcxxrt/others)`, which is depended by

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

protze.joachim added a comment. Reverting this commit fixes the compiler errors. This issue is tracked in https://bugs.llvm.org/show_bug.cgi?id=48953 , which is marked as blocking the 12 release. Without any knowledge about the compiler backend or the Debug codegen: might it be possible, that

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. In D96090#2544477 , @steakhal wrote: > Please, consider removing D95799 from the > parent revisions if that is not a hard requirement of this patch. Actually D95799

[PATCH] D94735: CGDebugInfo CreatedLimitedType: Drop file/line for RecordType with invalid location

protze.joachim added subscribers: jdoerfert, protze.joachim. protze.joachim added a comment. @jdoerfert This commit introduced the compile errors when OpenMP code is compiled with debug information. The symptom in llvm tests are the failing libarcher tests (which seem to be the only OpenMP

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov created this revision. azabaznov added reviewers: svenvh, Anastasia. Herald added a subscriber: yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change affects 'SemaOpenCLCXX/newdelete.cl' test, thus the

[PATCH] D96171: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38a285885dd5: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__ (authored by sbc100). Repository: rG LLVM Github Monorepo

[clang] 38a2858 - [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__

Author: Sam Clegg Date: 2021-02-05T13:53:05-08:00 New Revision: 38a285885dd5f3634d7824da2a6aefe5e39782a7 URL: https://github.com/llvm/llvm-project/commit/38a285885dd5f3634d7824da2a6aefe5e39782a7 DIFF: https://github.com/llvm/llvm-project/commit/38a285885dd5f3634d7824da2a6aefe5e39782a7.diff

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

mstorsjo added a comment. As is, this breaks compilation for mingw. With the three modifications I suggest here, it no longer breaks compilation for me - I have no idea if it actually works in mingw configurations though, but not breaking compilation is at least the first step.

[PATCH] D96175: [clang] Add support for attribute 'swift_async_error'

erik.pilkington created this revision. erik.pilkington added reviewers: doug.gregor, aaron.ballman. Herald added subscribers: jdoerfert, jkorous. erik.pilkington requested review of this revision. This attribute specifies how an error is represented for a swift async method. rdar://71941280

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil updated this revision to Diff 321860. Vexthil added a comment. Updating clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96147/new/ https://reviews.llvm.org/D96147 Files: clang/include/clang/Sema/Sema.h Index:

[PATCH] D96000: Don't emit coverage mapping for excluded functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. phosek marked an inline comment as done. Closed by commit rG9fd9b5a9c9ec: Dont emit coverage mapping for excluded functions (authored by phosek). Repository: rG

[clang] 9fd9b5a - Don't emit coverage mapping for excluded functions

Author: Petr Hosek Date: 2021-02-05T13:03:57-08:00 New Revision: 9fd9b5a9c9ece53ce36ec87e7dc8389d0f572476 URL: https://github.com/llvm/llvm-project/commit/9fd9b5a9c9ece53ce36ec87e7dc8389d0f572476 DIFF: https://github.com/llvm/llvm-project/commit/9fd9b5a9c9ece53ce36ec87e7dc8389d0f572476.diff

[PATCH] D96171: [clang][emscripten] Add builtin define for __EMSCRIPTEN_PTHREADS__

sbc100 created this revision. Herald added subscribers: wingo, jfb, dschuff. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Currently the emscripten frontend driver injects this when building with thread support. Moving

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

NoQ added a comment. Thanks!! > We have a bad track record of finishing, but forgetting to enable GSoC > projects -- did the same happen to SmartPtrChecker or that still needs > refinement? Still needs refinement. One large missing piece is that inlined defensive check suppressions weren't

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGb008ea304d43: [CUDA][HIP] Fix device variable linkage (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b008ea3 - [CUDA][HIP] Fix device variable linkage

Author: Yaxun (Sam) Liu Date: 2021-02-05T15:11:12-05:00 New Revision: b008ea304d438f0aa818918caceb3bd864412304 URL: https://github.com/llvm/llvm-project/commit/b008ea304d438f0aa818918caceb3bd864412304 DIFF:

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. I ended up reverting the changes I made to `llvm/lib/IR/AutoUpgrade.cpp` as the file was including `llvm/Analysis/ObjCARCUtil.h`, which was violating layering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96102: [clangd] Fix missing __syncthreads.

jdoerfert added a comment. In D96102#2545644 , @oToToT wrote: > OK, I've found what's wrong with my fix here. I should check for the clangd > compile mechanism with more detail to fix this problem. > > Sorry for disturbance. No worries. I'm not sure how

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman updated this revision to Diff 321842. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

LukasHanel added a comment. Hi, thanks for discussing my proposal! Although I think it can stand as is, I was looking for feedback: - Is the name good? - Is the `readability` group good? Or better in `misc`? - too slow, too fast? - More precision required? - Usefulness of the fix-it's - Should

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

stuart requested changes to this revision. stuart added a comment. This revision now requires changes to proceed. Looks good. Small nit about the test case. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1500 StringRef typeNameRef = typeName; // Turn

[PATCH] D96151: [OpenCL] Fix pipe type printing in arg info metadata

stuart added a comment. This looks like a really good cleanup, in addition to fixing the metadata for pipes. Minor nit: "matadata" -> "metadata" in the description, and there's a StringRef construction that could be sunk. Comment at:

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

tstellar added a comment. You can push this directly to the release/12.x branch when it's ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

thakis added a comment. @vabridgers: ping ^ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

Szelethus created this revision. Szelethus added reviewers: tstellar, NoQ, vsavchenko, dcoughlin, vrnithinkumar, xazax.hun, baloghadamsoftware, martong, balazske, steakhal, jkorous, dkrupp, gamesh411, ASDenysPetrov, aabbaabb, isthismyaccount. Szelethus added a project: clang. Herald added

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:337 + if (Name.empty()) +Name = ""; + return Name; I think that this will become unreachable after D84658 and D85033. I may be missing

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil added a comment. I have no idea what this error means or what to do about it i'm afraid but it does not look related to the changes I have made. I also do not have access to a Linux machine easily so reproducing it locally is not going to be easy. If anyone knows this error better and

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity marked 6 inline comments as done. whisperity added inline comments. Herald added a subscriber: nullptr.cpp. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:177 + const std::size_t StartIndex)

[PATCH] D96102: [clangd] Fix missing __syncthreads.

oToToT abandoned this revision. oToToT added a comment. OK, I've found what's wrong with my fix here. I should check for the clangd compile mechanism with more detail to fix this problem. Sorry for disturbance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96102/new/

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. OpenCL spec doesn't seem to describe the behavior correctly for type printing in **GetKernelArgInfo**

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00a62547da7e: Stop traping on sNaN in __builtin_isnan (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 00a6254 - Stop traping on sNaN in __builtin_isnan

Author: Thomas Preud'homme Date: 2021-02-05T18:28:48Z New Revision: 00a62547da7e609d1641c107d01d95504883921f URL: https://github.com/llvm/llvm-project/commit/00a62547da7e609d1641c107d01d95504883921f DIFF: https://github.com/llvm/llvm-project/commit/00a62547da7e609d1641c107d01d95504883921f.diff

[PATCH] D93003: [libunwind][ELF] Hide unw_getcontext with LIBUNWIND_HIDE_SYMBOLS

steven_wu added inline comments. Comment at: libunwind/src/assembly.h:82 .globl SYMBOL_NAME(aliasname) SEPARATOR \ - WEAK_SYMBOL(aliasname) SEPARATOR \ + EXPORT_SYMBOL(SYMBOL_NAME(aliasname))

[PATCH] D96158: [clang][cli] Generate and round-trip Target options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining target

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:184 + llvm::SmallPtrSet BaseSpecSeen; + for (const auto : BaseSpecList) { +auto BaseType = BaseSpec->getType(); vsavchenko wrote: > vsavchenko wrote: > > LLVM

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321816. RedDocMD marked 10 inline comments as done. RedDocMD added a comment. Some more aesthetic cleanup, added a failing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/

[PATCH] D96156: [clang][cli] Generate and round-trip PreprocessorOutput options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining

[PATCH] D96155: [clang][cli] Generate and round-trip Frontend options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining

[PATCH] D96000: Don't emit coverage mapping for excluded functions

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96000/new/ https://reviews.llvm.org/D96000

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 321801. varungandhi-apple added a comment. Correct documentation on tail call behavior as pointed out by John. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561

[PATCH] D96151: [OpenCL] Fix pipe type printing in arg info metadata

Anastasia created this revision. Anastasia added reviewers: svenvh, mantognini. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Pipe element type spelling for arg info matadata should follow the same behavior as normal type spelling. We should not return

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

kpn accepted this revision. kpn added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 ___

[PATCH] D96150: [OpenCL][Docs] Describe internals of TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add a high level explanation of the `-fdeclare-opencl-builtins` option.

[PATCH] D96149: [clang][cli] Store InputKind in FrontendOptions

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch stores the `InputKind` (parsed mainly from `-x`) to `FrontendOptions`. This

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfed995ef9020: [clangd] Trace queue state for each TUScheduler action. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96027/new/

[clang-tools-extra] fed995e - [clangd] Trace queue state for each TUScheduler action.

Author: Sam McCall Date: 2021-02-05T17:56:51+01:00 New Revision: fed995ef9020ef2845ff78e9f4aa97e6d512c586 URL: https://github.com/llvm/llvm-project/commit/fed995ef9020ef2845ff78e9f4aa97e6d512c586 DIFF: https://github.com/llvm/llvm-project/commit/fed995ef9020ef2845ff78e9f4aa97e6d512c586.diff

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

Vexthil created this revision. Vexthil added a reviewer: rsmith. Vexthil added a project: clang. Vexthil requested review of this revision. Herald added a subscriber: cfe-commits. https://bugs.llvm.org/show_bug.cgi?id=40858 CheckShadow is now called for each binding in the structured binding to

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

ASDenysPetrov added a comment. I downloaded and tested this patch. On the whole it works OK. See my suggestions below. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:205 + llvm::SmallPtrSet BaseSpecSeen; + for (const auto : BaseSpecList) { +auto

[clang] 01bf529 - Recommit of a2fdf9d4d734732a6fa9288f1ffdf12bf8618123.

Author: Michael Liao Date: 2021-02-05T11:27:30-05:00 New Revision: 01bf529db2cf465b029e29e537807576bfcbc452 URL: https://github.com/llvm/llvm-project/commit/01bf529db2cf465b029e29e537807576bfcbc452 DIFF: https://github.com/llvm/llvm-project/commit/01bf529db2cf465b029e29e537807576bfcbc452.diff

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 321766. balazske added a comment. Re-organized testing header files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files:

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Herald added a subscriber: nullptr.cpp. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-signal-handler-posix.c:4 +// RUN: [{key: bugprone-signal-handler.AsyncSafeFunctionSet, value: "POSIX"}]}' \ +// RUN: -- -isystem

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180 +bool noRepeatedElements( +const llvm::ImmutableList ) { RedDocMD wrote: > vsavchenko wrote: > > nit: functions represent actions, in languages verbs act

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

aganea added a comment. A few questions: Does this work on x86 targets? Are the scudo tests below being built with /MD or with /MT? Would this change compile/work on MinGW as well? Comment at: compiler-rt/lib/scudo/scudo_platform.h:72 +#elif SANITIZER_WINDOWS +const uptr

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

steveire added a comment. In D96082#2545106 , @Eugene.Zelenko wrote: > In D96082#2544778 , @steveire wrote: > >> @Eugene.Zelenko Why did you remove me from the reviewers list? > > Only project's maintainers should

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd88c55ab95c9: [OpenCL] Add macro definitions of OpenCL C 3.0 features (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] d88c55a - [OpenCL] Add macro definitions of OpenCL C 3.0 features

Author: Anton Zabaznov Date: 2021-02-05T18:42:25+03:00 New Revision: d88c55ab95c9985e366b62569f2a50cf8ce5c469 URL: https://github.com/llvm/llvm-project/commit/d88c55ab95c9985e366b62569f2a50cf8ce5c469 DIFF:

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

aaron.ballman added a comment. In D96082#2545106 , @Eugene.Zelenko wrote: > In D96082#2544778 , @steveire wrote: > >> @Eugene.Zelenko Why did you remove me from the reviewers list? > > Only project's maintainers

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

Eugene.Zelenko added a comment. In D96082#2544778 , @steveire wrote: > @Eugene.Zelenko Why did you remove me from the reviewers list? Only project's maintainers should be reviewers and approve patch. Sure, nobody prevents you from making comments.

[clang] 4cbea09 - [ASTMatchers] Fix segfault when Action is nullptr

Author: Stephen Kelly Date: 2021-02-05T15:17:13Z New Revision: 4cbea09431cd7d976770348d8e3d67cf1d3637e8 URL: https://github.com/llvm/llvm-project/commit/4cbea09431cd7d976770348d8e3d67cf1d3637e8 DIFF: https://github.com/llvm/llvm-project/commit/4cbea09431cd7d976770348d8e3d67cf1d3637e8.diff

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

mibintc updated this revision to Diff 321756. mibintc retitled this revision from "RFC [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly" to "[clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly". mibintc edited the

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

njames93 added a comment. I'm not sure about this. The warning is good and addresses a real problem. I'm not sure what the infrastructure surrounding this is but in clang it would show a "stack trace" of instantiations that result in this warning. Maybe we should think of something similar in

[PATCH] D96142: [clang-tidy] Simplify too-small loop variable check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't issue a warning from within a template

[PATCH] D96141: [clang-tidy] Simplify const params check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

thakis added a comment. This breaks check-clang everywhere: http://45.33.8.238/linux/38812/step_7.txt Please run tests before landing. Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96140: [clang-tidy] Simplify inefficient algorithm check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180 +bool noRepeatedElements( +const llvm::ImmutableList ) { vsavchenko wrote: > nit: functions represent actions, in

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rsmith wrote: > rjmccall wrote: > > rsmith wrote:

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because it no longer relies on finding implicit

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. I believe that the MCJIT failures are due to bug https:/bugs.llvm.org/show_bug.cgi?id=24978 rather than a problem in the Scudo port so I have added details of how I hit it to that bugzilla and opened two reviews to get this landed:

[PATCH] D96135: [clang-tidy] Simplify braced init check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The normalization of matchers means that this now

[clang] 42e0189 - [OpenCL] Add cl_khr_subgroup_shuffle* to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-05T14:16:13Z New Revision: 42e018997b23af74eee4acdc0388ae44b36d69f9 URL: https://github.com/llvm/llvm-project/commit/42e018997b23af74eee4acdc0388ae44b36d69f9 DIFF: https://github.com/llvm/llvm-project/commit/42e018997b23af74eee4acdc0388ae44b36d69f9.diff

[PATCH] D96132: [clang-tidy] Simplify throw keyword missing check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, xazax.hun. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D96131: [clang-tidy] Simplify function complexity check

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added subscribers: nullptr.cpp, lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. In D94880#2544895 , @aaron.ballman wrote: > In D94880#2544873 , @steveire wrote: > >> That page collapses the documentation for each matcher, as you know. >> >> You need to expand the

[clang] 4a64d8f - [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Author: Akira Hatanaka Date: 2021-02-05T06:09:42-08:00 New Revision: 4a64d8fe392449b205e59031aad5424968cf7446 URL: https://github.com/llvm/llvm-project/commit/4a64d8fe392449b205e59031aad5424968cf7446 DIFF:

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. In D94880#2544873 , @steveire wrote: > That page collapses the documentation for each matcher, as you know. > > You need to expand the docs for `mapAnyOf`, as you know. > > You seem to

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180 +bool noRepeatedElements( +const llvm::ImmutableList ) { nit: functions represent actions, in languages verbs act the same way, so it's recommended to

[clang] 538677a - Add an API to simplify setting TraversalKind in clang-tidy matchers

Author: Stephen Kelly Date: 2021-02-05T14:03:40Z New Revision: 538677abbde4e74795d0bc21a77a3d263893c37d URL: https://github.com/llvm/llvm-project/commit/538677abbde4e74795d0bc21a77a3d263893c37d DIFF: https://github.com/llvm/llvm-project/commit/538677abbde4e74795d0bc21a77a3d263893c37d.diff

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG538677abbde4: Add an API to simplify setting TraversalKind in clang-tidy matchers (authored by stephenkelly). Changed prior to commit:

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cba22c23a76: [clang-tidy] Simplify implementation of container-size-empty (authored by stephenkelly). Herald added a subscriber: nullptr.cpp.

[clang-tools-extra] 2cba22c - [clang-tidy] Simplify implementation of container-size-empty

Author: Stephen Kelly Date: 2021-02-05T14:03:41Z New Revision: 2cba22c23a769103f4f0c31968620a488f13b625 URL: https://github.com/llvm/llvm-project/commit/2cba22c23a769103f4f0c31968620a488f13b625 DIFF: https://github.com/llvm/llvm-project/commit/2cba22c23a769103f4f0c31968620a488f13b625.diff

[clang] 2fbbb18 - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly"

Author: Akira Hatanaka Date: 2021-02-05T06:00:05-08:00 New Revision: 2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 URL: https://github.com/llvm/llvm-project/commit/2fbbb18c1dbeb124dfc3c2aebae97d4780ff9bd6 DIFF:

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. That page collapses the documentation for each matcher, as you know. You need to expand the docs for `mapAnyOf`, as you know. You seem to know all this. What's the remaining issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5173 + if (auto *PLE = llvm::dyn_cast(Base)) +Base = PLE->getExpr(PLE->getNumExprs() - 1); + if (OtherOpBase) {

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321724. Budovi added a comment. Changes: - Added a unit test with a different `IndentWidth` - Removed a unit test that contained a class nested in function; didn't add much IMHO - Added brief comments about potentially non-obvious behaviour to some tests

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:38 +typedef uint cl_mem_fence_flags; +#define CLK_GLOBAL_MEM_FENCE 0x02 + Anastasia wrote: > Should we add this conditionally if the base header is not included? > >

[PATCH] D96130: Correct swift_bridge duplicate attribute warning logic

aaron.ballman created this revision. aaron.ballman added a reviewer: compnerd. aaron.ballman requested review of this revision. Herald added a project: clang. The `swift_bridge` attribute warns when the attribute is applied multiple times to the same declaration. However, it warns about the

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fe3946d9a95: [ObjC][ARC] Use operand bundle clang.arc.rv instead of explicitly (authored by ahatanak). Repository: rG LLVM Github Monorepo

[clang] 3fe3946 - [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly

Author: Akira Hatanaka Date: 2021-02-05T05:55:18-08:00 New Revision: 3fe3946d9a958b7af6130241996d9cfcecf559d4 URL: https://github.com/llvm/llvm-project/commit/3fe3946d9a958b7af6130241996d9cfcecf559d4 DIFF:

[PATCH] D96082: [clang-tidy] Add 'readability-useless-return-value' check

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. This check, more specifically the fixes, seem quite dangerous. Changing function signatures is highly likely to cause compilation issues. For a starters this check doesn't

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:1529 + foreach name = ["reduce_", "scan_exclusive_", "scan_inclusive_"] in { +foreach op = ["add", "min", "max", "mul"] in { + def : Builtin<"sub_group_non_uniform_" # name # op, [AGenType1,

  1   2   >