[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This call to ProhibitAttributes() is almost always dead code. For GNU

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; LiuChen3 wrote: > LuoYuanke wrote: > > pengfei wrote: > > > Is there much value to differentiate the type? We are

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; LuoYuanke wrote: > pengfei wrote: > > Is there much value to differentiate the type? We are using the same AMX > >

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LuoYuanke added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; pengfei wrote: > Is there much value to differentiate the type? We are using the same AMX type > in the builtins.

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

nullptr.cpp created this revision. nullptr.cpp added reviewers: alexfh, aaron.ballman, njames93, balazske. Herald added subscribers: xazax.hun, mgorny. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Finds redundant `using`

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei added inline comments. Comment at: clang/lib/Headers/amxintrin.h:283 +typedef struct __tile1024bf16_str { + const unsigned short row; Is there much value to differentiate the type? We are using the same AMX type in the builtins. What do you think?

[PATCH] D97265: [clang] Allow clang-check to customize output file name

OikawaKirie added a comment. In D97265#2581653 , @sammccall wrote: > > It looks like either we're in syntax-only mode (and -o will be ignored > regardless) or we're in analyzer mode, and want -o. > It seems tempting to just stop stripping it in this

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 updated this revision to Diff 325988. LiuChen3 added a comment. Adding back 'avx512f' to amx-tile-basic.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 Files:

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai updated this revision to Diff 325987. HsiangKai added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 created this revision. Herald added subscribers: pengfei, hiraditya. LiuChen3 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Adding support for intrinsics of AMX-BF16. This patch alse fix a bug that AMX-INT8

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8560c2d4268c: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from… (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 8560c2d - [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

Author: Vitaly Buka Date: 2021-02-23T22:14:41-08:00 New Revision: 8560c2d4268c32fb57a3ffeb99b3745e0999 URL: https://github.com/llvm/llvm-project/commit/8560c2d4268c32fb57a3ffeb99b3745e0999 DIFF: https://github.com/llvm/llvm-project/commit/8560c2d4268c32fb57a3ffeb99b3745e0999.diff

[PATCH] D97116: Reduce the number of attributes attached to each function

This revision was automatically updated to reflect the committed changes. Closed by commit rG053dc95839b3: Reduce the number of attributes attached to each function (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

pengfei added a comment. I don't think the patch is doing right. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 +} else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support operations on _Float16 or __fp16 other than + // load

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added a comment. https://reviews.llvm.org/D97353 should fix the unitest failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 ___ cfe-commits mailing

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl updated this revision to Diff 325972. yaxunl marked 2 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. revised comments and fixed test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97318/new/ https://reviews.llvm.org/D97318 Files:

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

OikawaKirie requested review of this revision. OikawaKirie added a comment. @aaron.ballman My only concern is the recursive call to this function on line 1359. If you think it is also OK for the recursive call on line 1359, I will update the patch as you mentioned above. BTW, how can I test

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked 2 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:466-467 + return; +OS << "Obtained null inner pointer from"; +checkAndPrettyPrintRegion(OS, ThisRegion); + }));

[PATCH] D96195: [HIP] Fix managed variable linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3ce7f5cd2ae: [HIP] Fix managed variable linkage (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a3ce7f5 - [HIP] Fix managed variable linkage

Author: Yaxun (Sam) Liu Date: 2021-02-23T22:34:45-05:00 New Revision: a3ce7f5cd2ae236bec7752e343f4b63ddda7ebe7 URL: https://github.com/llvm/llvm-project/commit/a3ce7f5cd2ae236bec7752e343f4b63ddda7ebe7 DIFF:

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 325966. tentzen added a comment. Herald added a subscriber: jfb. changed option name and a couple of minor changes per John McCall's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/

[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

dexonsmith added a comment. If we do add this, I'd suggest a separate function rather than modifying the current one. I also think implementing it should be optional. Something like: virtual ErrorOr status(const Twine ) = 0; virtual ErrorOr status(const Twine , bool FollowSymlinks) { //

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 325964. yubing added a comment. Fix some comments and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1024 +#define RVV_TUPLE(Name, ElemId, Id, SingletonId, NE, EB, NF, IsSigned, IsFP) \ + QualType SingletonId; #include "clang/Basic/RISCVVTypes.def" HsiangKai wrote: >

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 +} else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support _Float16 or __fp16. When used in + // languages

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1024 +#define RVV_TUPLE(Name, ElemId, Id, SingletonId, NE, EB, NF, IsSigned, IsFP) \ + QualType SingletonId; #include "clang/Basic/RISCVVTypes.def" craig.topper wrote: >

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai marked 3 inline comments as done. HsiangKai added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10672 + if (Ty->isRecordType() && !Ty->getAsRecordDecl()->field_empty() && + Ty->getAsRecordDecl()->field_begin()->getType()->isSizelessType())

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai updated this revision to Diff 325957. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/Builtins.def

[PATCH] D97351: [clangd] Use flags from open files when opening headers they include

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Currently our

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:593 MostRecentLocation = *StartLoc; - completeDeferred(Count, MostRecentLocation); } vsk wrote: > Does this mean a deferred gap region following a `break;`

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur marked an inline comment as done. Meinersbur added a comment. In D94973#2575395 , @jdenny wrote: > This patch has no effect if the OpenMP IR builder is not enabled, and it's > disabled by default. Is that right? Yes, this is how it is

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

pengfei requested changes to this revision. pengfei added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 +} else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 325947. zequanwu marked an inline comment as done. zequanwu added a comment. - Revert the deletion of completeDeferred in pushRegion. - Emit zero gap region only if OutCounter is different from parentCounter in whil, for statements. - Update test cases.

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

thakis added a comment. Looks like this landed in b32d40417e25bad79e9b5bc0f0a29d7ba0222ad9 but the review feedback was never addressed. With a more fine-grained thing, we could use this to add a compile-time error to libcxxabi for D97323 . Repository: rL

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

thakis added a comment. Reverted for now in ab5b00ada9e77437ed2c76f73cfb8481bb9826a5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638

[clang] ab5b00a - Revert "[Driver][Windows] Support per-target runtimes dir layout for profile instr generate"

Author: Nico Weber Date: 2021-02-23T20:38:39-05:00 New Revision: ab5b00ada9e77437ed2c76f73cfb8481bb9826a5 URL: https://github.com/llvm/llvm-project/commit/ab5b00ada9e77437ed2c76f73cfb8481bb9826a5 DIFF: https://github.com/llvm/llvm-project/commit/ab5b00ada9e77437ed2c76f73cfb8481bb9826a5.diff

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

thakis added a comment. This broke check-clang on all platforms, e.g. here: http://45.33.8.238/linux/40161/step_7.txt http://45.33.8.238/macm1/4018/step_6.txt http://45.33.8.238/win/33805/step_7.txt Please run tests before committing. (It also breaks check-clang in a local cmake build. The

[PATCH] D96209: [clang-tidy] Fix readability-avoid-const-params-in-decls removing const in template paramaters

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96209/new/ https://reviews.llvm.org/D96209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97288: Added `Follow` parameter to llvm::vfs::FileSystem::status()

alexfh added a comment. In D97288#2581908 , @sammccall wrote: > How strong is the need for this? > This adds complexity to a widely implemented and used interface, and the > combination of virtual + default parameters can be at least a little >

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

erichkeane added a comment. In D97324#2583286 , @jyknight wrote: > I can imagine there being some cases where these could theoretically be > useful. > > But if you've tested this change and it doesn't cause build failures with any > existing uses of

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4451eb4f38: [NFC] Make TrailingObjects non-copyable/non-movable (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88220: [C++20] P1825R0: More implicit moves

aaronpuchert added a comment. In D88220#2581538 , @aaron.ballman wrote: > We usually rely on the release notes to say something, but we didn't do that > here. Perhaps @nullptr.cpp could add something there? The file is `clang/docs/ReleaseNotes.rst`.

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4050 << ", mem=" << ProcStat->PeakMemory << " Kb\n"; - } - if (!StatReportFile.empty()) { + } else { // CSV format. aganea wrote: > The previous

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

vvereschaka updated this revision to Diff 325930. vvereschaka added a comment. Thank you @aganea Updated diff: - removed `ClaimAllArgs` for `OPT_fproc_stat_report_EQ` (used in `getLastArg`); - used `const char*` instead of `std::string` for `CCPrintStatReportFilename`; - removed unnecessary

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

Eugene.Zelenko added a comment. Please mention new option in Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-easily-swappable-parameters.rst:89 +warning about the two parameters are silenced. +Defaults to ``1``. +Might be any positive

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1024 +#define RVV_TUPLE(Name, ElemId, Id, SingletonId, NE, EB, NF, IsSigned, IsFP) \ + QualType SingletonId; #include "clang/Basic/RISCVVTypes.def" craig.topper wrote: > Why

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

jyknight accepted this revision. jyknight added a comment. This revision is now accepted and ready to land. I can imagine there being some cases where these could theoretically be useful. But if you've tested this change and it doesn't cause build failures with any existing uses of

[PATCH] D97340: [HIP] Support Spack packages

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang, kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Spack is a package management tool extensively used by HPC community. As ROCm packages are built by Spack by HPC

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

jsji added inline comments. Comment at: llvm/unittests/ProfileData/CoverageMappingTest.cpp:211 Expressions, Data.Regions); EXPECT_THAT_ERROR(Reader.read(), Succeeded()); } Somehow previous value of `Data.Filenames`

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

craig.topper added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1024 +#define RVV_TUPLE(Name, ElemId, Id, SingletonId, NE, EB, NF, IsSigned, IsFP) \ + QualType SingletonId; #include "clang/Basic/RISCVVTypes.def" Why is this QualType and

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:10672 + if (Ty->isRecordType() && !Ty->getAsRecordDecl()->field_empty() && + Ty->getAsRecordDecl()->field_begin()->getType()->isSizelessType()) Are we able to test this yet?

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:59 #ifndef RVV_VECTOR_TYPE_FLOAT #define RVV_VECTOR_TYPE_FLOAT(Name, Id, SingletonId, NumEls, ElBits, NF) \ RVV_VECTOR_TYPE(Name, Id, SingletonId, NumEls, ElBits, NF, false, true)

[PATCH] D96570: [scan-build-py] Add sarif-html support in scan-build-py

This revision was automatically updated to reflect the committed changes. Closed by commit rG97a304cc8f94: [scan-build-py] Add sarif-html support in scan-build-py (authored by Daniel Hwang ar...@google.com, committed by charco). Herald added a project: clang. Herald added a subscriber:

[clang] 97a304c - [scan-build-py] Add sarif-html support in scan-build-py

Author: Daniel Hwang Date: 2021-02-23T14:41:48-08:00 New Revision: 97a304cc8f949e40693d63b855b4b24bc81fa729 URL: https://github.com/llvm/llvm-project/commit/97a304cc8f949e40693d63b855b4b24bc81fa729 DIFF: https://github.com/llvm/llvm-project/commit/97a304cc8f949e40693d63b855b4b24bc81fa729.diff

[PATCH] D93446: [RISCV] Add vadd with mask and without mask builtin.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93446/new/ https://reviews.llvm.org/D93446

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ah, sorry, I missed that. In that case, LGTM, but you may want to respond to other reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

tejohnson accepted this revision. tejohnson added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 ___ cfe-commits mailing list

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

brentdax added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1639 const char *Prefix = ThisTokBuf; - while (ThisTokBuf[0] != '(') + while (ThisTokBuf - Prefix < 16 && ThisTokBuf[0] != '(') ++ThisTokBuf; Nit: "16" is a

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka abandoned this revision. vitalybuka added a comment. in favor of D96320 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96456/new/ https://reviews.llvm.org/D96456

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

vitalybuka updated this revision to Diff 325895. vitalybuka marked an inline comment as done. vitalybuka added a comment. rename variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 Files:

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

brentdax accepted this revision. brentdax added a comment. This revision is now accepted and ready to land. Looks good. Thanks for implementing this! Comment at: clang/lib/Lex/LiteralSupport.cpp:1647 ThisTokEnd -= ThisTokBuf - Prefix; assert(ThisTokEnd >=

[PATCH] D96519: [Clang][OpenMP] Fixed an issue that `target team` is emitted incorrectly

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. This patch is abandoned and will propose a new patch to unify interface of `target` and `target teams`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96519/new/

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG039f79c78cfa: [SEMA] Added warn_decl_shadow support for structured bindings (authored by Vexthil, committed by rsmith). Changed prior to commit: https://reviews.llvm.org/D96147?vs=325578=325892#toc

[clang] 039f79c - [SEMA] Added warn_decl_shadow support for structured bindings

Author: David Crook Date: 2021-02-23T13:37:05-08:00 New Revision: 039f79c78cfa2c0d0d61de117ff46aa43cb5e831 URL: https://github.com/llvm/llvm-project/commit/039f79c78cfa2c0d0d61de117ff46aa43cb5e831 DIFF: https://github.com/llvm/llvm-project/commit/039f79c78cfa2c0d0d61de117ff46aa43cb5e831.diff

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9d5d6e444c: [Driver][Windows] Support per-target runtimes dir layout for profile instr… (authored by zero9178). Repository: rG LLVM Github

[clang] 7f9d5d6 - [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

Author: zero9178 Date: 2021-02-23T22:35:19+01:00 New Revision: 7f9d5d6e444c91ce6f2e377b312ac573dfc6779a URL: https://github.com/llvm/llvm-project/commit/7f9d5d6e444c91ce6f2e377b312ac573dfc6779a DIFF: https://github.com/llvm/llvm-project/commit/7f9d5d6e444c91ce6f2e377b312ac573dfc6779a.diff

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 325889. cjdb added a comment. applies @aaron.ballman's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked an inline comment as done. cjdb added a comment. In D94640#2579447 , @aaron.ballman wrote: > In D94640#2560647 , @cjdb wrote: > >> fixes block expressions >> >> @aaron.ballman I'm not sure I follow

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote:

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added a comment. In D96838#2582965 , @probinson wrote: >> For ELF, `used` does not retain the entity, regardless of this patch. > > That statement does not match my experience. You probably used C identifier name sections with

[PATCH] D96320: [ThinLTO, NewPM] Run OptimizerLastEPCallbacks from buildThinLTOPreLinkDefaultPipeline

aeubanks added a comment. I guess this is fine. I'm worried that various OptimizerLastEPCallbacks will only expect to be run once, and adding a special case of not adding those callbacks during thinlto post link will be confusing for other uses of OptimizerLastEPCallbacks, but maybe it won't

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

yln accepted this revision. yln added a comment. This revision is now accepted and ready to land. LGTM, cleanup only, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97327/new/ https://reviews.llvm.org/D97327

[PATCH] D96838: Add GNU attribute 'retain'

probinson added a comment. > For ELF, `used` does not retain the entity, regardless of this patch. That statement does not match my experience. Note that there are two separate variables documented in the LangRef: `llvm.used` (which corresponds to source attribute `used` and is documented as

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638 ___ cfe-commits mailing list

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4083-4084 - - // not_tail_called has no effect on an indirect call even if the call can - // be resolved at compile time. - return (*fn)(a); This paragraph about indirect

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. @arphaman @jansvoboda11 ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. In D96572#2563707 , @jansvoboda11 wrote: > In D96572#2561216 , @delcypher wrote: > >> @jansvoboda11 I noticed that the `Options.td` file is making use of some >> fancy mixins that mean

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

delcypher created this revision. delcypher added reviewers: jansvoboda11, arphaman, kubamracek, yln, aralisza. Herald added a subscriber: dang. delcypher requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change simplifies

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 325872. delcypher added a comment. Rebase and fix merge conflict caused by f2f59d2a060788f17040ad924ee2d11da0e215c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 325868. zero9178 added a comment. Herald added a subscriber: mstorsjo. Refactored getCompilerRTBasename. It now simply refers to getCompilerRT, which gathers a full path to the specified runtime library. getCompilerRTBasename then simply returns only the

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2825 + // gcc where 16 bit integer is used in place of _Float16 or __fp16. + Lo = Integer; } tra wrote: > Do we need to set `Hi`,

[PATCH] D97324: [NFC] Make TrailingObjects non-copyable/non-movable

erichkeane created this revision. erichkeane added reviewers: jyknight, jfb, hubert.reinterpretcast. Herald added a subscriber: dexonsmith. erichkeane requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This got me pretty recently...

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2825 + // gcc where 16 bit integer is used in place of _Float16 or __fp16. + Lo = Integer; } Do we need to set `Hi`, too? We do set it for `int128`. CHANGES SINCE LAST

[PATCH] D97322: [clang-tidy][test] Allow specifying potentially unused suffixes

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a check-suffix is only required for a CHECK-FIXES or

[PATCH] D96906: [AMDGPU] gfx90a support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote: >

[PATCH] D97318: [clang][CodeGen] Allow fp16 arg pass by register

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added a subscriber: pengfei. yaxunl requested review of this revision. HIP supports _Float16 and __fp16 types. In x86_64 host they are for storage only. Since they have the same size and alignment as int16, they are supposed

[PATCH] D97313: [clang-tidy] Tweak misc-static-assert fix in c++17

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-static-assert.cpp:40-41 assert(myfunc(1, 2)); - // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: found assert() that could be replaced by static_assert() [misc-static-assert] - //

[PATCH] D97313: [clang-tidy] Tweak misc-static-assert fix in c++17

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If C++17 mode is enabled and the assert doesn't have a string

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:555 +auto Insert = Lexer::getSourceText(FixIt.InsertFromRange, M, L, ); +if (!Invalid) + Result.newText = Insert.str();

[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet added a comment. In D97223#2581587 , @jyknight wrote: > In D97223#2581126 , @rjmccall wrote: > >> Looks like you didn't update the .bc reader/writer and the .ll >> printer/parser. > > The instructions

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

steakhal added a reviewer: xazax.hun. steakhal added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:466-467 + return; +OS << "Obtained null inner pointer from"; +checkAndPrettyPrintRegion(OS,

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:98 +This support is available in GNU ``ld`` and ``gold`` as of binutils 2.36, as +well as in ``ld.lld`` 13. + }]; probinson wrote: > As a

[PATCH] D96838: Add GNU attribute 'retain'

probinson added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:98 +This support is available in GNU ``ld`` and ``gold`` as of binutils 2.36, as +well as in ``ld.lld`` 13. + }]; As a user, this seems like a complicated thing to figure out.

[PATCH] D97275: [clang-tidy] Add cppcoreguidelines-prefer-member-initializer to ReleaseNotes

This revision was automatically updated to reflect the committed changes. Closed by commit rG2af5275f72da: [clang-tidy] Add cppcoreguidelines-prefer-member-initializer to ReleaseNotes (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2af5275 - [clang-tidy] Add cppcoreguidelines-prefer-member-initializer to ReleaseNotes

Author: Nathan James Date: 2021-02-23T18:29:22Z New Revision: 2af5275f72dad18b76d4db641c3c861d76aa29be URL: https://github.com/llvm/llvm-project/commit/2af5275f72dad18b76d4db641c3c861d76aa29be DIFF: https://github.com/llvm/llvm-project/commit/2af5275f72dad18b76d4db641c3c861d76aa29be.diff LOG:

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:466-467 + return; +OS << "Obtained null inner pointer from"; +checkAndPrettyPrintRegion(OS, ThisRegion); + }));

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 325827. RedDocMD added a comment. Making output more gramatically sensible when pretty printing is unavailable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files:

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

njames93 updated this revision to Diff 325826. njames93 added a comment. Update tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97123/new/ https://reviews.llvm.org/D97123 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D96838: Add GNU attribute 'retain'

rnk added a comment. It should be possible to make retain work on COFF for internal linkage things by emitting a non-comdat section, even when /Gy / -ffunction/data-sections are enabled. That's complicated if the thing being retained is in a comdat group, but I think it's doable. If the group

  1   2   >