[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

njames93 added a comment. Please can you upload diffs with full context or using arcanist . It may be worth adding a case where if

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing marked 15 inline comments as done. yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInser

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

lebedev.ri added a comment. In D97577#2596458 , @hokein wrote: > In D97577#2592827 , @flx wrote: > >> In D97577#2592093 , @lebedev.ri >> wrote: >> >>> It is best not to chan

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. In D97577#2592827 , @flx wrote: > In D97577#2592093 , @lebedev.ri > wrote: > >> It is best not to change exist

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 327362. yubing edited the summary of this revision. yubing added a comment. address comments above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/

[PATCH] D96853: [clang][AVR] Support variable decorator '__flash'

benshi001 updated this revision to Diff 327361. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96853/new/ https://reviews.llvm.org/D96853 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/Targets/AVR.cpp clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/add

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. We should never silently accept and ignore an attribute unless (1) that's allowable semantics for the attribute or (2) we have to for source compatibility. That test is specifically checking that we allow `__attribute__((nomerge))` before `@try` statements. Are we ju

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); ArcsinX wrote: > kadircet wrote: > > it feels weird to choo

[PATCH] D97733: Fix infinite recursion during IR emission if a constant-initialized lifetime-extended temporary object's initializer refers back to the same object.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e2579dbf434: Fix infinite recursion during IR emission if a constant-initialized lifetime… (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 9e2579d - Fix infinite recursion during IR emission if a constant-initialized lifetime-extended temporary object's initializer refers back to the same object.

Author: Richard Smith Date: 2021-03-01T22:19:21-08:00 New Revision: 9e2579dbf434e996b3d35f27b5a1762019cf27bb URL: https://github.com/llvm/llvm-project/commit/9e2579dbf434e996b3d35f27b5a1762019cf27bb DIFF: https://github.com/llvm/llvm-project/commit/9e2579dbf434e996b3d35f27b5a1762019cf27bb.diff

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder added a comment. Well we test them on `@try` in `tests/Parser/stmt-attributes.m`, but they are not being diagnosed as invalid. Should I instead keep the `ProhibitAttributes()` call and change the test to make sure they //are// being diagnosed? Repository: rG LLVM Github Monorepo CH

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

rjmccall added a comment. Do we really consider the existing atomic intrinsics to not impose added alignment restrictions? I'm somewhat concerned that we're going to produce IR here that's either really suboptimal or, worse, unimplementable, just because we over-interpreted some cue about alig

[PATCH] D97116: Reduce the number of attributes attached to each function

xbolva00 added a comment. In D97116#2596275 , @crownyanguan wrote: > However, this commit will cause performance regression. More details? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97116/new/ https://

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

rjmccall added a comment. We don't have any reason to allow attributes on any of the `@` statements, but there's no reason to disallow them grammatically, as long as we still diagnose them as invalid (which I assume is tested somewhere?). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added a comment. Sorry. I have no problem with continuing the existing pattern, I guess. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D97733: Fix infinite recursion during IR emission if a constant-initialized lifetime-extended temporary object's initializer refers back to the same object.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. No, I like this approach, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97733/new/ https://reviews.llvm.org/D97733

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 _

[clang] 1ff9361 - [PowerPC] Add missing overloads of vec_promote to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-01T21:40:30-06:00 New Revision: 1ff93618e58df210def48d26878c20a1b414d900 URL: https://github.com/llvm/llvm-project/commit/1ff93618e58df210def48d26878c20a1b414d900 DIFF: https://github.com/llvm/llvm-project/commit/1ff93618e58df210def48d26878c20a1b414d900.di

[PATCH] D97116: Reduce the number of attributes attached to each function

crownyanguan added a comment. However, this commit will cause performance regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97116/new/ https://reviews.llvm.org/D97116 ___ cfe-commits mailing list

[PATCH] D97561: [clang] Use CompilerInstance::createTarget to createTarget

oToToT added a comment. Kindly ping. Since the part I modified is quite... old (about 4 to 7 years ago?), I hope I've found the right person to review for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97561/new/ https://reviews.llvm.org/D97

[clang] 38a34e2 - [PowerPC] Use modulo arithmetic for vec_extract in altivec.h

Author: Nemanja Ivanovic Date: 2021-03-01T19:49:26-06:00 New Revision: 38a34e207f30747a4b0288d97ce67e422bf5f363 URL: https://github.com/llvm/llvm-project/commit/38a34e207f30747a4b0288d97ce67e422bf5f363 DIFF: https://github.com/llvm/llvm-project/commit/38a34e207f30747a4b0288d97ce67e422bf5f363.di

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. This patch In D97669#2596073 , @aykevl wrote: > Looks reasonable to me. But again, I would like this to be reviewed also by > someone familiar with the internals of Clang (I'm not). Actually this patch is copied from msp430, w

[libunwind] b17d464 - [libunwind] This adds support in libunwind for rv32 hard float

Author: Kamlesh Kumar Date: 2021-03-02T06:58:24+05:30 New Revision: b17d46430fce665d23661e23ade3ca57c3791836 URL: https://github.com/llvm/llvm-project/commit/b17d46430fce665d23661e23ade3ca57c3791836 DIFF: https://github.com/llvm/llvm-project/commit/b17d46430fce665d23661e23ade3ca57c3791836.diff

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:942 pushRegion(Counter::getZero()); -auto &ZeroRegion = getRegion(); -ZeroRegion.setDeferred(true); -LastTerminatedRegion = {EndLoc, RegionStack.size()}; +if (!HasTerminateSt

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. If I understand this right, the right patch description should be "fix regression where we didn't pass `-platform_version` to new ld64.lld after D95204 ", righ

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2594394 , @HazardyKnusperkeks wrote: > In D94500#2593229 , @timwoj wrote: > >> In D94500#2592448 , >> @HazardyKnusperkeks wrote: >> >>> Do

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

aykevl added a comment. Looks reasonable to me. But again, I would like this to be reviewed also by someone familiar with the internals of Clang (I'm not). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97669/new/ https://reviews.llvm.org/D97669 _

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay updated this revision to Diff 327320. MaskRay retitled this revision from "Define __GCC_HAVE_DWARF2_CFI_ASM to 1 on ELF/Mach-O if CC1 -munwind-tables is specified" to "Define __GCC_HAVE_DWARF2_CFI_ASM if applicable". MaskRay edited the summary of this revision. MaskRay added a comment. C

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall added a comment. In D94554#2595625 , @njames93 wrote: > Address some comments, though I have a feeling @Sammccall, I may have to wait > until DraftStore has been refactored first before continuing on with this. D97738

[clang] 1490f6b - Fix build 5de2d189e6ad4

Author: Yuanfang Chen Date: 2021-03-01T16:06:30-08:00 New Revision: 1490f6b72c30f690b18018ceefd499562b255efa URL: https://github.com/llvm/llvm-project/commit/1490f6b72c30f690b18018ceefd499562b255efa DIFF: https://github.com/llvm/llvm-project/commit/1490f6b72c30f690b18018ceefd499562b255efa.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM to 1 on ELF/Mach-O if CC1 -munwind-tables is specified

MaskRay created this revision. MaskRay added reviewers: dexonsmith, jansvoboda11. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. % diff <(gcc -fno-asynchronous-unwind-tables -dM -E a.c) <(gcc -dM -E a.c) 130a131 > #define __G

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de2d189e6ad: [Diagnose] Unify MCContext and LLVMContext diagnosing (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 5de2d18 - [Diagnose] Unify MCContext and LLVMContext diagnosing

Author: Yuanfang Chen Date: 2021-03-01T15:58:37-08:00 New Revision: 5de2d189e6ad466a1f0616195e8c524a4eb3cbc0 URL: https://github.com/llvm/llvm-project/commit/5de2d189e6ad466a1f0616195e8c524a4eb3cbc0 DIFF: https://github.com/llvm/llvm-project/commit/5de2d189e6ad466a1f0616195e8c524a4eb3cbc0.diff

[PATCH] D97741: [clang+lld] Pass -platform_version args to ld64.lld

int3 created this revision. int3 added reviewers: lld-macho, thakis. Herald added subscribers: steven_wu, hiraditya. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that ld64.lld points to the new Darwin backend, we can pass it the

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327304. ychen added a comment. - Remove dead code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td clang/inclu

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

sammccall created this revision. sammccall added reviewers: njames93, kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. ClangdServer already gets notifi

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/include/llvm/MC/MCContext.h:67 class SourceMgr; + template class function_ref; With `std::function`, this can be dropped. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2595415 , @MaskRay wrote: > LG. Can you attach an example triggering clang `InlineAsmDiagHandler2`? I > want to check what the diagnostics look like before and now. `clang/test/CodeGen/asm-errors.c` should trigger it. R

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327300. ychen added a comment. - Revert to use std::function since MCContext needs to own the handler callback - Fix a typo in BackendConsumer::SrcMgrDiagHandler: DI.getKind() -> DI.getSeverity() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra created this revision. sivachandra added a reviewer: phosek. Herald added subscribers: jansvoboda11, dang. sivachandra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The experimental option is named -experimental-link-llvmlibc.

[clang] 9ecbb34 - Fix test cxx-call-kernel.cpp

Author: Yaxun (Sam) Liu Date: 2021-03-01T17:10:53-05:00 New Revision: 9ecbb34e1d2dc77e768638b6ecd94d63e451915d URL: https://github.com/llvm/llvm-project/commit/9ecbb34e1d2dc77e768638b6ecd94d63e451915d DIFF: https://github.com/llvm/llvm-project/commit/9ecbb34e1d2dc77e768638b6ecd94d63e451915d.dif

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabbe9e227ed3: [clang-tidy] Added command line option `fix-notes` (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] abbe9e2 - [clang-tidy] Added command line option `fix-notes`

Author: Nathan James Date: 2021-03-01T22:07:11Z New Revision: abbe9e227ed31e5dde9bb7567bb9f0dd047689c6 URL: https://github.com/llvm/llvm-project/commit/abbe9e227ed31e5dde9bb7567bb9f0dd047689c6 DIFF: https://github.com/llvm/llvm-project/commit/abbe9e227ed31e5dde9bb7567bb9f0dd047689c6.diff LOG:

[PATCH] D97733: Fix infinite recursion during IR emission if a constant-initialized lifetime-extended temporary object's initializer refers back to the same object.

rsmith added a comment. @rjmccall We could alternatively address this by creating and registering the global first, and only then building and adding its initializer, but either way we're going to need some special-case code to detect and handle this situation (because we might need to change t

[PATCH] D97708: [CUDA] Remove `noreturn` attribute from __assertfail().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32e064527623: [CUDA] Remove `noreturn` attribute from __assertfail(). (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 32e0645 - [CUDA] Remove `noreturn` attribute from __assertfail().

Author: Artem Belevich Date: 2021-03-01T13:59:22-08:00 New Revision: 32e0645276230bb5b736e378860df3b92b1f4ba8 URL: https://github.com/llvm/llvm-project/commit/32e0645276230bb5b736e378860df3b92b1f4ba8 DIFF: https://github.com/llvm/llvm-project/commit/32e0645276230bb5b736e378860df3b92b1f4ba8.diff

[PATCH] D97733: Fix infinite recursion during IR emission if a constant-initialized lifetime-extended temporary object's initializer refers back to the same object.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `GetAddrOfGlobalTemporary` previously tried to emit the initializer of a global temporary before updating the global tem

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

arnamoy10 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-", "--"], "print-rocm-search-dirs">, + HelpText<"Print the paths used for finding ROCm installation">; def p

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8bfc14193170: [clang-tidy] Added option to uniqueptr delete release check (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 8bfc141 - [clang-tidy] Added option to uniqueptr delete release check

Author: Nathan James Date: 2021-03-01T21:52:13Z New Revision: 8bfc14193170c95a49fca3e66aa077203783a137 URL: https://github.com/llvm/llvm-project/commit/8bfc14193170c95a49fca3e66aa077203783a137 DIFF: https://github.com/llvm/llvm-project/commit/8bfc14193170c95a49fca3e66aa077203783a137.diff LOG:

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 327280. njames93 marked an inline comment as done. njames93 added a comment. Address some comments, though I have a feeling @Sammccall, I may have to wait until DraftStore has been refactored first before continuing on with this. Repository: rG LLVM Gith

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rnk added a comment. I guess my only concern is, what happens if MSVC fixes assert.h? Do we need to make the implicit `#define static_assert _Static_assert` conditional on the absence of any `static_assert` definition? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://r

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:159 ClangdServer(const GlobalCompilationDatabase &CDB, const ThreadsafeFS &TFS, - const Options &Opts, Callbacks *Callbacks = nullptr);

[clang] 53d3038 - Fix build failure due to dump()

Author: Yaxun (Sam) Liu Date: 2021-03-01T16:44:08-05:00 New Revision: 53d30381f54fbeef3e9ca7f9b52d29d235365f19 URL: https://github.com/llvm/llvm-project/commit/53d30381f54fbeef3e9ca7f9b52d29d235365f19 DIFF: https://github.com/llvm/llvm-project/commit/53d30381f54fbeef3e9ca7f9b52d29d235365f19.dif

[PATCH] D86376: [HIP] Emit kernel symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cf2a37f1255: [HIP] Emit kernel symbol (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D86376?vs=322894&id=327268#toc Repository: rG LLVM Github

[clang] 5cf2a37 - [HIP] Emit kernel symbol

Author: Yaxun (Sam) Liu Date: 2021-03-01T16:31:40-05:00 New Revision: 5cf2a37f1255700d4da9d5f45e82bdfff09aee8c URL: https://github.com/llvm/llvm-project/commit/5cf2a37f1255700d4da9d5f45e82bdfff09aee8c DIFF: https://github.com/llvm/llvm-project/commit/5cf2a37f1255700d4da9d5f45e82bdfff09aee8c.dif

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 __

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:22 def note_fe_inline_asm_here : Note<"instantiated into assembly here">; +def err_fe_source_mgr : Error<"%0">, CatSourceMgr; +def warn_fe_source_mgr : Warning<"%0">, CatSourceMgr, InG

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 updated this revision to Diff 327258. njames93 added a comment. Add test demonstrating we aren't detecting bound member functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97630/new/ https://reviews.llvm.org/D97630 Files: clang-too

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-uniqueptr-delete-release.cpp:40 + + delete (P2.release()); + // CHECK-MESSAGES-NULLPTR: :[[@LINE-1]]:3: warning: prefer '= nullptr' aaron.ballman wrote: > njames

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:869 +SMLoc Loc, +std::function GetMessage) { + SourceMgr SM; MaskRay wrote: > ychen wrote: > > MaskRay wrote: > > > Use lightweight function_ref since you don't need to store the callback

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1586-1589 + for (const ParsedAttr &A : *this) { +if (A.getSyntax() != ParsedAttr::Syntax::AS_GNU) + return false; + } Comment at: cl

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327256. ychen added a comment. - Use function_ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td clang/inclu

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. LG. Can you attach an example triggering clang `InlineAsmDiagHandler2`? I want to check what the diagnostic looks like now. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:22 def note_fe_inline_asm_here : Note<"instantiated into assem

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added a comment. In D97449#2595390 , @MaskRay wrote: > Is the https://github.com/ClangBuiltLinux/linux/issues/1269 unreachable error > fixed? > > Reproduce: > > git clone https://android.googlesource.com/kernel/common.git --branch > android-4.19-

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-uniqueptr-delete-release.cpp:40 + + delete (P2.release()); + // CHECK-MESSAGES-NULLPTR: :[[@LINE-1]]:3: warning: prefer '= nullptr' njames93 wrote: > aaron.

[clang] 564f5b0 - Revert "[c++20] Mark class type NTTPs as done and start defining the feature test macro."

Author: Richard Smith Date: 2021-03-01T12:53:35-08:00 New Revision: 564f5b0734bd5d265a0046e5ca9d08ae5bc303eb URL: https://github.com/llvm/llvm-project/commit/564f5b0734bd5d265a0046e5ca9d08ae5bc303eb DIFF: https://github.com/llvm/llvm-project/commit/564f5b0734bd5d265a0046e5ca9d08ae5bc303eb.diff

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

MaskRay added a comment. Is the https://github.com/ClangBuiltLinux/linux/issues/1269 unreachable error fixed? Reproduce: git clone https://android.googlesource.com/kernel/common.git --branch android-4.19-stable cd common PATH=path/to/your/clang/bin:$PATH make -s -j 30 LLVM=1 O=/tmp/out/a

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-uniqueptr-delete-release.cpp:40 + + delete (P2.release()); + // CHECK-MESSAGES-NULLPTR: :[[@LINE-1]]:3: warning: prefer '= nullptr' aaron.ballman wrote: > Not th

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 327243. yaxunl marked 2 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca52815fb3c: [clang-format][PR47290] Add ShortNamespaceLines format option (authored by kuzkry, committed by HazardyKnus

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG418b4a7b3158: [clang-format] Respect spaces in line comment section... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[clang] 6ca5281 - [clang-format][PR47290] Add ShortNamespaceLines format option

Author: Krystian Kuzniarek Date: 2021-03-01T21:28:14+01:00 New Revision: 6ca52815fb3cb32343b9a008fdf9f593da39f203 URL: https://github.com/llvm/llvm-project/commit/6ca52815fb3cb32343b9a008fdf9f593da39f203 DIFF: https://github.com/llvm/llvm-project/commit/6ca52815fb3cb32343b9a008fdf9f593da39f203.

[clang] 418b4a7 - [clang-format] Respect spaces in line comment section...

Author: Björn Schäpers Date: 2021-03-01T21:28:14+01:00 New Revision: 418b4a7b3158b47043c4c8891eb2e27966a55fa2 URL: https://github.com/llvm/llvm-project/commit/418b4a7b3158b47043c4c8891eb2e27966a55fa2 DIFF: https://github.com/llvm/llvm-project/commit/418b4a7b3158b47043c4c8891eb2e27966a55fa2.diff

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:32 +static llvm::SmallString<0> findSPACKPackage(const Driver &D, + const llvm::SmallString<0> &Path, +

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-uniqueptr-delete-release.cpp:40 + + delete (P2.release()); + // CHECK-MESSAGES-NULLP

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

int3 added a comment. I've reverted the clang driver changes for now in rG922de2574c17a755279358be928e5343dcf56c56 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ htt

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Ping! Please, review this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order a

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 updated this revision to Diff 327230. arnamoy10 added a comment. Minor changes as per comments, also updated commit message to include description of changes related to Setters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 Files:

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, bader. Herald added subscribers: jansvoboda11, dexonsmith, dang, Anastasia, ebevhan, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. SYCL compilations initiated by the driver wi

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

rnk accepted this revision. rnk added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499 CmdArgs.push_back("-guard:cf-"); +} else if (GuardArgs.equals_lower("ehcont")) { + CmdArgs.push_back("/guar

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2595049 , @akhuang wrote: > In D97411#2594345 , @ldionne wrote: > >> I don't have an opinion about the attribute itself. I do have an opinion >> about using that attribute in lib

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

steveire added a comment. In D97158#2594973 , @njames93 wrote: > Should we make `nullPtrConstant()` a top level mather? I feel like this > change would actually throw users off. This would make this matcher a "convenience" matcher. https://reviews.llvm.

[PATCH] D97713: [ASTMatchers] Add documentation for convenience matchers

steveire created this revision. steveire added reviewers: aaron.ballman, njames93. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97713 Files: clang/docs/LibASTMa

[clang] 922de25 - [lld-macho] Partial revert of D95204

Author: Jez Ng Date: 2021-03-01T11:29:42-08:00 New Revision: 922de2574c17a755279358be928e5343dcf56c56 URL: https://github.com/llvm/llvm-project/commit/922de2574c17a755279358be928e5343dcf56c56 DIFF: https://github.com/llvm/llvm-project/commit/922de2574c17a755279358be928e5343dcf56c56.diff LOG: [

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia added a comment. In D97052#2587043 , @azabaznov wrote: > I see the update regaring this functionality on github issue: > https://github.com/KhronosGroup/OpenCL-Docs/issues/82#issuecomment-785496025. > Is it a right way to reflect this informati

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2594345 , @ldionne wrote: > I don't have an opinion about the attribute itself. I do have an opinion > about using that attribute in libc++ instead of fixing the underlying issue > (I think we shouldn't do it). Can you

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

Anastasia updated this revision to Diff 327204. Anastasia added a comment. - Reorder fields, - make constructor parameters explicit - use `insert_or_assign` member of `StringMap`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 Files: clang/in

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia marked 13 inline comments as done. Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:221 +triggers in the parsing) should not be added to clang. Moreover, the acceptable +behavior of pragmas should provide useful functionality to the user. +

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4280-4281 HelpText<"Dump provenance">; +def fdebug_module_writer : Flag<["-"],"fdebug-module-writer">, + HelpText<"Enables showing debug messages while writing module files.">;

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 327199. Anastasia added a comment. - Added suggestions from Sven and Marco. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D97708: [CUDA] Remove `noreturn` attribute from __assertfail().

tra updated this revision to Diff 327197. tra edited the summary of this revision. tra added a comment. Added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97708/new/ https://reviews.llvm.org/D97708 Files: clang/lib/Headers/__clang_cu

[PATCH] D97158: [ASTMatchers] Make nullPointerConstant usable at top-level

njames93 added a comment. Should we make `nullPtrConstant()` a top level mather? I feel like this change would actually throw users off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97158/new/ https://reviews.llvm.org/D97158

[PATCH] D97708: [CUDA] Remove `noreturn` attribute from __assertfail().

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Maybe add a comment on assertfail that we don't want it to be noreturn because blah blah? So someone doesn't come back and add it when we're not looking. :) Repository: rG LLVM Github Mon

[PATCH] D97708: [CUDA] Remove `noreturn` attribute from __assertfail().

tra created this revision. tra added a reviewer: jlebar. Herald added subscribers: bixia, yaxunl. tra requested review of this revision. Herald added a project: clang. `noreturn` complicates control flow and tends to trigger a known bug in ptxas if the assert is used within loops in sufficiently c

[PATCH] D97706: Make -f[no-]split-dwarf-inlining CC1 default align with driver default (no inlining)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd942a82a076d: Make -f[no-]split-dwarf-inlining CC1 default align with driver default (no… (authored by MaskRay). Repository: rG LLVM Github Monore

[clang] d942a82 - Make -f[no-]split-dwarf-inlining CC1 default align with driver default (no inlining)

Author: Fangrui Song Date: 2021-03-01T10:55:19-08:00 New Revision: d942a82a076d35130376fa786adfc933c7db1c89 URL: https://github.com/llvm/llvm-project/commit/d942a82a076d35130376fa786adfc933c7db1c89 DIFF: https://github.com/llvm/llvm-project/commit/d942a82a076d35130376fa786adfc933c7db1c89.diff

[clang-tools-extra] 8f9f7d0 - [clang-tidy] Tweak misc-static-assert fix in c++17

Author: Nathan James Date: 2021-03-01T18:51:50Z New Revision: 8f9f7d02aaac98f8539158e05975e7acbbb58fcc URL: https://github.com/llvm/llvm-project/commit/8f9f7d02aaac98f8539158e05975e7acbbb58fcc DIFF: https://github.com/llvm/llvm-project/commit/8f9f7d02aaac98f8539158e05975e7acbbb58fcc.diff LOG:

  1   2   3   >