[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, mgorny. aheejin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D96347: Include function return type in JSON AST dumps.

rokups added a comment. Hey @Temtaime, Until we can rely on this i opted in for poor man's workaround - splitting type/qualType field at the first ( and using first part. I realize it is not reliable and will break when function pointers are used, but since they arent in my project that is an

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86.td:865 +// Alderlake + list ADLAdditionalFeatures = [FeatureSERIALIZE, Extra spaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. But let's wait one day or two to see if others object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/

[PATCH] D97801: [clangd] Add `limit` extension on completion and workspace-symbols

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:784 Server->workspaceSymbols( - Params.query, Opts.CodeComplete.Limit, + Params.query,

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe created this revision. Herald added subscribers: pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97832 Files:

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97573/new/ https://reviews.llvm.org/D97573 ___

[PATCH] D97825: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e675b3da1d: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES

[clang] f7e675b - [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

Author: Hsiangkai Wang Date: 2021-03-03T13:42:54+08:00 New Revision: f7e675b3da1d7afd43af51c5a5e9140c87ef945d URL: https://github.com/llvm/llvm-project/commit/f7e675b3da1d7afd43af51c5a5e9140c87ef945d DIFF:

[PATCH] D97831: [Clang][Sema] Implement GCC -Wcast-function-type

ychen created this revision. ychen added reviewers: aaron.ballman, rsmith. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Warn when a function pointer is cast to an incompatible function pointer. In a cast involving function

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu added inline comments. Comment at: clang/test/CoverageMapping/deferred-region.cpp:43 if (true) -return; // CHECK: Gap,File 0, [[@LINE]]:11 +return; else vsk wrote: > I'm confused by this change. Do we lose the gap here? I assumed it was

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

zequanwu updated this revision to Diff 327661. zequanwu marked an inline comment as done. zequanwu added a comment. - Deprecate deferred region. Use the notion of gap region inserted in VisitStmt to replace deferred region. - Emit gap region with OutCounter from last statement if exists. - Move

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wrote:

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" :

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC);

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327655. 0x8000- added a comment. Add an option "IgnoredVariableNames" that allows filtering out acceptable variable names (similar to the loop counters); also implemented via regex. Added tests for the IgnoredVariableNames option. CHANGES SINCE

[PATCH] D97826: [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

khchen added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97826/new/ https://reviews.llvm.org/D97826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

pengfei added a comment. Thanks for the review. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499 CmdArgs.push_back("-guard:cf-"); +} else if (GuardArgs.equals_lower("ehcont")) { + CmdArgs.push_back("/guard:ehcont"); rnk wrote: > This is

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

pengfei updated this revision to Diff 327654. pengfei added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96709/new/ https://reviews.llvm.org/D96709 Files: clang/docs/UsersManual.rst

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:21 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is `2`).

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327653. 0x8000- marked an inline comment as done. 0x8000- added a comment. Use regular expression for filtering out loop counter variables to ignore. Fully document the options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked an inline comment as done. 0x8000- added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:9 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-variable-length.rst:9 + +Loop counter variables are expected to have a length of at least +`MinimumLoopCounterNameLength` characters (default is 2). Additionally, `i`,

[PATCH] D97553: [clang][NFC] pack StaticDiagInfoRec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG335375ef2c66: [clang][NFC] pack StaticDiagInfoRec (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 335375e - [clang][NFC] pack StaticDiagInfoRec

Author: Nathan James Date: 2021-03-03T02:53:10Z New Revision: 335375ef2c66408da751223d13758d14da248cd3 URL: https://github.com/llvm/llvm-project/commit/335375ef2c66408da751223d13758d14da248cd3 DIFF: https://github.com/llvm/llvm-project/commit/335375ef2c66408da751223d13758d14da248cd3.diff LOG:

[PATCH] D97639: [clang-tidy][NFC] Use equalsBoundNode matchers to simplify LoopConvertCheck

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a91b8232a5d: [clang-tidy][NFC] Use equalsBoundNode matchers to simplify LoopConvertCheck (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 1a91b82 - [clang-tidy][NFC] Use equalsBoundNode matchers to simplify LoopConvertCheck

Author: Nathan James Date: 2021-03-03T02:51:34Z New Revision: 1a91b8232a5d31ef3a4f8eb52f5a7aaf79525b9b URL: https://github.com/llvm/llvm-project/commit/1a91b8232a5d31ef3a4f8eb52f5a7aaf79525b9b DIFF: https://github.com/llvm/llvm-project/commit/1a91b8232a5d31ef3a4f8eb52f5a7aaf79525b9b.diff LOG:

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 327649. 0x8000- added a comment. Addressed most of the review comments with the exception of switching to regex for ignoring loop counters; this change is in the follow-up review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- marked 10 inline comments as done. 0x8000- added a comment. @Eugene.Zelenko and @njames93 Thank you both for the kind and thoughtful feedback. I am incorporating all recommended changes. First step are all the smaller scope comments, with regex support in a follow-up commit.

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/DraftStore.h:37 + DraftStore(const ThreadsafeFS ); + sammccall wrote: > having DraftStore sit on top of TFS seems a bit inside-out, giving it bigger > scope than necessary. > > What about

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 327646. njames93 added a comment. Getting there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D97826: [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

craig.topper created this revision. craig.topper added reviewers: evandro, HsiangKai, rogfer01, khchen, arcbbb. Herald added subscribers: StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D97816: [clang] Note that -debug-pass only works with legacy PM when using new PM

ychen added a comment. Sorry, I forgot that codegen is still legacy PM, so `-debug-pass=Structure` does give the correct output. Then users need to specify both -debug-pass-manager and `-debug-pass=x` to get the pass information. Hmm, not a big deal but seems hassles. Maybe we should bridge

[PATCH] D97825: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97825/new/ https://reviews.llvm.org/D97825

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

ahatanak added a comment. We could emit a call to `@llvm.objc.retain` instead of the call to `@llvm.objc.retainAutoreleasedReturnValue`, but this doesn't seem to happen often and ARC optimizer can remove or replace the call anyway, so I'm just letting the front-end emit

[PATCH] D97825: [RISCV] Use RISCVV_BUILTIN for vector intrinsic checking.

HsiangKai created this revision. HsiangKai added a reviewer: craig.topper. Herald added subscribers: StephenFan, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook. HsiangKai requested review of this revision. Herald added

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added a subscriber: jkorous. ahatanak requested review of this revision. This bug was causing the call to `replaceAllUsesWith` to crash because the old call instruction and the new call

[PATCH] D97823: Update default arch on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, the default arch level should match the minimum supported arch level of the OS version Repository: rG LLVM Github Monorepo

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

smeenai added a comment. In D92808#2593331 , @ahatanak wrote: > In D92808#2593204 , @thakis wrote: > >> FYI, we're seeing test failures caused by this patch in iOS/arm64 builds >> when arc is used (simulator is

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. I think they're all singular types, like __hash_node . Actually, `__tree_node` might not be problematic. I could look more at the types if it's helpful;

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa189b3b9e8bb: [clang-tidy] performance-for-range-copy: Dont trigger on implicit type… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a189b3b - [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

Author: Felix Berger Date: 2021-03-02T20:02:48-05:00 New Revision: a189b3b9e8bb398d9fe8770956f8ad1d58c2a214 URL: https://github.com/llvm/llvm-project/commit/a189b3b9e8bb398d9fe8770956f8ad1d58c2a214 DIFF: https://github.com/llvm/llvm-project/commit/a189b3b9e8bb398d9fe8770956f8ad1d58c2a214.diff

[PATCH] D97577: [clang-tidy] performance-for-range-copy: Don't trigger on implicit type conversions.

flx added a comment. Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97577/new/ https://reviews.llvm.org/D97577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d1983f2d0a0: [CMake] Enable Polly for Fuchsia toolchain build (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 1d1983f - [CMake] Enable Polly for Fuchsia toolchain build

Author: Petr Hosek Date: 2021-03-02T16:51:16-08:00 New Revision: 1d1983f2d0a04f2516881aae258d7264624a609e URL: https://github.com/llvm/llvm-project/commit/1d1983f2d0a04f2516881aae258d7264624a609e DIFF: https://github.com/llvm/llvm-project/commit/1d1983f2d0a04f2516881aae258d7264624a609e.diff

[PATCH] D97796: [test] Fix apparent typo in clang/test/Driver/std.c

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. I have no memories of this file, but I agree with your analysis :) Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97796/new/

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. Looks like `test/FixIt/fixit-static-assert.cpp` is failing in Phabricator's pre-merge checks: B91556 . Please take a look at that before landing this; I think there's a decent chance that it's indicative of a real problem. CHANGES

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to enable the use of Polly in

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

smeenai added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:81 -add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests" +add_lit_testsuite(check-clang-tools-extra "Running the Clang tools extra' regression tests"

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM. If you care about eventually getting rid of the old `check-clang-tools` alias, you'd want to have a mailing list announcement/deprecation notices/etc. (I don't think leaving it

[PATCH] D97817: [CMake] Rename check-clang-tools to check-clang-tools-extra

phosek created this revision. phosek added a reviewer: smeenai. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Match the top-level project name (that is the name developers would use in

[PATCH] D97101: [Coverage] Emit zero count gap region between statements if first statements contains return, throw, goto, co_return

vsk added a comment. Thanks for the patient explanation. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1391 +// Clear DeferredRegion because we don't need to complete it after switch. +DeferredRegion = None; + Is the reason why we don't need to

[PATCH] D97816: [clang] Note that -debug-pass only works with legacy PM when using new PM

aeubanks created this revision. aeubanks added a reviewer: ychen. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to https://reviews.llvm.org/D97810. Repository: rG LLVM Github Monorepo

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. In some cases `BugReport.isInteresting(InnerPointerVal.getAsSymbol())` would yield us exactly what we want. But if there's no symbol we have no choice but to interact with the `trackExpressionValue` facility and this may turn out to be pretty challenging. We could, for

[PATCH] D97340: [HIP] Support Spack packages

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM modulo couple of nits. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-",

[PATCH] D95691: Implement P2173 for attributes on lambdas

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic",

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2598625 , @akhuang wrote: > In D97411#2595155 , @dblaikie wrote: > >> In D97411#2595049 , @akhuang wrote: >> >>> In D97411#2594345

[libunwind] 5c3fc50 - [libunwind] [risc-v] This patch is for fixing

Author: Kamlesh Kumar Date: 2021-03-03T04:32:47+05:30 New Revision: 5c3fc5093aaf7d9422459d295eb4eb769abcbaa4 URL: https://github.com/llvm/llvm-project/commit/5c3fc5093aaf7d9422459d295eb4eb769abcbaa4 DIFF: https://github.com/llvm/llvm-project/commit/5c3fc5093aaf7d9422459d295eb4eb769abcbaa4.diff

[PATCH] D88220: [C++20] P1825R0: More implicit moves

rsmith added inline comments. Comment at: clang/www/cxx_status.html:1206-1210 + + More implicit moves + https://wg21.link/p1825r0;>P1825R0 (DR) + Clang 13 + We have, so far, listed DR papers only in the section of `cxx_status` for the

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 327596. yaxunl marked 5 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 HelpText<"Print the registered targets">; +def print_rocm_search_dirs : Flag<["-", "--"], "print-rocm-search-dirs">, + HelpText<"Print the paths

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang added a comment. In D97411#2595155 , @dblaikie wrote: > In D97411#2595049 , @akhuang wrote: > >> In D97411#2594345 , @ldionne wrote: >> >>> I don't have an opinion

[PATCH] D96347: Include function return type in JSON AST dumps.

Temtaime added a comment. Merge it, please. I badly need this field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96347/new/ https://reviews.llvm.org/D96347 ___ cfe-commits mailing list

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau added a comment. I am much more afraid of providing bad results than I am afraid of degrading performance. I mean, eventually the "real" preamble is built, and the results are just as correct as before, but it may yield incorrect results until we invalidate the AST. That is especially

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, assuming none of the later changes have effected the documentation script. In D97156#2598398 , @steveire wrote: > In D97156#2593209

[PATCH] D97806: [clang-query] Fix help text after D91918

njames93 created this revision. njames93 added a reviewer: aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After rG5e1801813d93210acae84ff3c68a01512c2df9bc

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbca3e24139cc: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer. (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang-tools-extra] bca3e24 - [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

Author: Sam McCall Date: 2021-03-02T22:58:50+01:00 New Revision: bca3e24139cc301d7deae56a020057cf657035b6 URL: https://github.com/llvm/llvm-project/commit/bca3e24139cc301d7deae56a020057cf657035b6 DIFF: https://github.com/llvm/llvm-project/commit/bca3e24139cc301d7deae56a020057cf657035b6.diff

[clang-tools-extra] 00c7d66 - [cte][NFC] Remove all references to stdlib stream headers.

Author: Nathan James Date: 2021-03-02T21:57:16Z New Revision: 00c7d6699a3937cd1fe34921f1fbc0c4fc09cebd URL: https://github.com/llvm/llvm-project/commit/00c7d6699a3937cd1fe34921f1fbc0c4fc09cebd DIFF: https://github.com/llvm/llvm-project/commit/00c7d6699a3937cd1fe34921f1fbc0c4fc09cebd.diff LOG:

[PATCH] D97771: [cte][NFC] Remove all references to stdlib stream headers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. njames93 marked an inline comment as done. Closed by commit rG00c7d6699a39: [cte][NFC] Remove all references to stdlib stream headers. (authored by njames93). Changed

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

njames93 created this revision. njames93 added reviewers: aaron.ballman, steveire. njames93 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add option `set match-scope (include-headers|main-file-only)` to control only printing matches

[PATCH] D97784: [ASTMatchers] Always create a "binding" for the node being matched on.

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, steveire. njames93 published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Most often when using matchers, there is a need to get the root node that the matcher

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 327572. arnamoy10 added a comment. Rebased on main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall updated this revision to Diff 327574. sammccall added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97803/new/ https://reviews.llvm.org/D97803 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D97142: [clang-tidy] Simplify unused RAII check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b6fc9a1055a: [clang-tidy] Simplify unused RAII check (authored by stephenkelly). Changed prior to commit:

[clang-tools-extra] 7b6fc9a - [clang-tidy] Simplify unused RAII check

Author: Stephen Kelly Date: 2021-03-02T21:33:34Z New Revision: 7b6fc9a1055a7eae07645fb7d3085dc89a8d54ab URL: https://github.com/llvm/llvm-project/commit/7b6fc9a1055a7eae07645fb7d3085dc89a8d54ab DIFF: https://github.com/llvm/llvm-project/commit/7b6fc9a1055a7eae07645fb7d3085dc89a8d54ab.diff

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall updated this revision to Diff 327565. sammccall edited the summary of this revision. sammccall added a comment. fix bug link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97803/new/ https://reviews.llvm.org/D97803 Files:

[PATCH] D97803: [clangd] Overload bundles are only deprecated if each overloads is.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire added a comment. In D97156#2593209 , @njames93 wrote: > Is it not nicer to name the class `PolymorphicMatcher` and do away with > `WithParamN`, It may require partial specialization for the empty parameters > case. > But I think it would be

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

steveire updated this revision to Diff 327559. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97156/new/ https://reviews.llvm.org/D97156 Files: clang/docs/tools/dump_ast_matchers.py

[PATCH] D97801: [clangd] Add `limit` extension on completion and workspace-symbols

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This overrides the --limit-results

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77b5c40d576: Add __builtin_isnan(__fp16) testcase (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e77b5c4 - Add __builtin_isnan(__fp16) testcase

Author: Thomas Preud'homme Date: 2021-03-02T21:01:51Z New Revision: e77b5c40d57633a66842e75410585696895ecf4d URL: https://github.com/llvm/llvm-project/commit/e77b5c40d57633a66842e75410585696895ecf4d DIFF: https://github.com/llvm/llvm-project/commit/e77b5c40d57633a66842e75410585696895ecf4d.diff

[PATCH] D97320: Use a fast path when initializing LineOffsetMapping

lattner added a comment. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97320/new/ https://reviews.llvm.org/D97320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LGTM OK, I think we've established that the request was for a way to dump out clangd's whole index, and workspace/symbol isn't actually a good way to do that. Nevertheless, this seems

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

mitchell-stellar added a comment. I am in favor of a new option, `IncludeIsMainAllowBraces`. It keeps things simple and does not cause any backwards-compatibility issues. The `${}` variables are clever, but if "users unconcerned with formatting ... could get the current functionality by

[PATCH] D97796: [test] Fix apparent typo in clang/test/Driver/std.c

DanielMcIntosh-IBM created this revision. DanielMcIntosh-IBM added a reviewer: thakis. DanielMcIntosh-IBM requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently the test on line 3 is identical to the test on line 1. Looking at the rest

[PATCH] D97187: [Clang][Sema] Warn when function argument is less aligned than parameter

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM . Just a few coding style nits to fix. But please wait a couple of days to see if someone else has anything else to say. Comment at:

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap marked 2 inline comments as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8593 + return !convertToNonDenormSingle(ArgAPFloat); +} + stefanp wrote: > I'm wondering if it would not be better to just inline

[PATCH] D93031: Enable fexec-charset option

rsmith added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:145 ModuleLoader + LiteralConverter LT; Please give this a longer name. Abbreviation names should only be used in fairly small scopes where it's easy to look up what

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 327537. Conanap added a comment. Addressed Stefan's comments, converted the check to a mirror of the original function for XXSPLTIDP except non-destructive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

vitalybuka added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:489 + if (TC.getSanitizerArgs().needsScudoRt()) { +for (const auto : {"scudo", "scudo_cxx"}) { We need this for both legacy and standalone scudo?

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem closed this revision. gulfem added a comment. Since this patch has been merged and the issue in the test has been resolved, I'm closing this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, but please make sure that Richard is happy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 ___

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

nlopes added a comment. @rsmith already gave his blessing, so please go ahead. I hope you guys have a plan to enable this by default at some point as features behind a flag get rotten and no one uses them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. For sure. I'll upload a rebased patch shortly and give it another day or so for people to look, and then push if there aren't any issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/

[PATCH] D97777: Add __builtin_isnan(__fp16) testcase

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://reviews.llvm.org/D9

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

eugenis added a comment. Any more comments/opinions? Gui, would you like to push it to main if no one objects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D97738: [clangd] Move DraftStore from ClangdLSPServer into ClangdServer.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/DraftStore.cpp:66 // We treat versions as opaque, but the protocol says they increase. -if (*Version <=

[PATCH] D95017: [clang-format] Add case aware include sorting.

PragmaNull added a comment. In D95017#2595230 , @HazardyKnusperkeks wrote: > > Do you make a change? Otherwise I will do, but that will take some time, > because I'm rather busy. Sorry, I have not; unfortunately I've been rather busy myself and

  1   2   >