[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

LuoYuanke added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 328408. yubing added a comment. Address pengfei's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93594/new/ https://reviews.llvm.org/D93594 Files: llvm/include/llvm/CodeGen/Passes.h

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng updated this revision to Diff 328407. kito-cheng added a comment. Reupload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97916/new/ https://reviews.llvm.org/D97916 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng updated this revision to Diff 328406. kito-cheng marked 2 inline comments as done. kito-cheng added a comment. - Fix build issue. - Address Jim Lin's and Zakk's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97916/new/

[PATCH] D98010: [XCOFF] [DWARF] set default DWARF version to 3

shchenz created this revision. shchenz added reviewers: jsji, hubert.reinterpretcast, jasonliu, PowerPC. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We support DWARF for XCOFF in D95518 . In

[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie updated this revision to Diff 328396. OikawaKirie retitled this revision from "[clang] Allow clang-check to customize output file name" to "[clang] Allow clang-check to customize analyzer output file or dir name". OikawaKirie edited the summary of this revision. OikawaKirie added a

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng marked 5 inline comments as done. kito-cheng added a comment. Here is another solution for flexible multi-lib configuration I consider before: - Add an option called `-fmultilib-config=` - Using same or similar syntax with GCC's `--with-multilib-generator` But the problem is it's

[clang] 931a3aa - [Driver][test] Fix ClangDriverTest

Author: Fangrui Song Date: 2021-03-04T22:44:37-08:00 New Revision: 931a3aa96726ec6d2052e24e9966fe32d98ddd3e URL: https://github.com/llvm/llvm-project/commit/931a3aa96726ec6d2052e24e9966fe32d98ddd3e DIFF: https://github.com/llvm/llvm-project/commit/931a3aa96726ec6d2052e24e9966fe32d98ddd3e.diff

[clang] 087e7ab - [Driver] Switch Exherbo/Alpine/Arch Linux to /etc/os-release

Author: Fangrui Song Date: 2021-03-04T22:31:05-08:00 New Revision: 087e7ab459e74ad3b33701296ade581cb4c3ba6c URL: https://github.com/llvm/llvm-project/commit/087e7ab459e74ad3b33701296ade581cb4c3ba6c DIFF: https://github.com/llvm/llvm-project/commit/087e7ab459e74ad3b33701296ade581cb4c3ba6c.diff

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra added a comment. In D97736#2605535 , @phosek wrote: > Have you considered using an input linker script? We could generate `libc.so` > that could look something like: > > INPUT(libllvmlibc.a /lib/libc.so) > > We would need to pass

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

phosek added a comment. Have you considered using an input linker script? We could generate `libc.so` that could look something like: INPUT(libllvmlibc.a /lib/libc.so) We would need to pass `--sysroot` to the linker for this to work. The driver could remain completely agnostic of whether

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj added a comment. In D94500#2605515 , @HazardyKnusperkeks wrote: > In D94500#2604754 , @timwoj wrote: > >> Rebase onto master again > > `master` or `main`? Please rebase on `main`. That is where the pushes

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2604754 , @timwoj wrote: > Rebase onto master again `master` or `main`? Please rebase on `main`. That is where the pushes land. (And as far as I can see `master` hasn't been updated in quite some time.

[clang] bc172e5 - [clang][StaticAnalyzer] Compilation fix.

Author: Michael Kruse Date: 2021-03-04T23:23:58-06:00 New Revision: bc172e532a89754d47fef1306064a26a4dc0a76b URL: https://github.com/llvm/llvm-project/commit/bc172e532a89754d47fef1306064a26a4dc0a76b DIFF: https://github.com/llvm/llvm-project/commit/bc172e532a89754d47fef1306064a26a4dc0a76b.diff

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra updated this revision to Diff 328380. sivachandra added a comment. Remove empty '//' in lit test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97736/new/ https://reviews.llvm.org/D97736 Files:

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra added a comment. In D97736#2605432 , @echristo wrote: > In addition to the bikeshed below, I'm not a huge fan of this in general. I > think we should assume that the libc we link is complete and thus it would > just be named "libc." and in a

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra added a comment. In D97736#2605432 , @echristo wrote: > In addition to the bikeshed below, I'm not a huge fan of this in general. I > think we should assume that the libc we link is complete and thus it would > just be named "libc." and in a

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

echristo added a comment. In addition to the bikeshed below, I'm not a huge fan of this in general. I think we should assume that the libc we link is complete and thus it would just be named "libc." and in a sysroot somewhere. Another option is perhaps looking at the rtlib option, but I'd want

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ChuanqiXu added a comment. I am a little confusing about the problem. The example in the link tells the align of the `promise` instead of the `frame`. The address of `promise` and `frame` is not same. It looks like you're trying to do: + +---+

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

khchen added a comment. I didn't check why I got error in Failed Tests (1): Clang :: Driver/riscv64-toolchain.c Could you please double check it? Thanks! Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1599 +static std::string getGCCPath(const Driver , const ArgList ) {

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

Jim added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1744 + // which multi-lib should be used. + return ScanGCCMultilibConfig(D, TargetTriple, Path, Args, MultilibOutput, + Result); scanGCCMultilibConfig ?

[clang-tools-extra] 889da99 - [clang][AST] Fix Wreturn-type gcc warning (NFC)

Author: Yang Fan Date: 2021-03-05T11:24:55+08:00 New Revision: 889da99523930e81e4080084ab9530251c23873d URL: https://github.com/llvm/llvm-project/commit/889da99523930e81e4080084ab9530251c23873d DIFF: https://github.com/llvm/llvm-project/commit/889da99523930e81e4080084ab9530251c23873d.diff

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. Sorry, was a bit caught up with assignments. I will try to come up with a better implementation with the advice given by @NoQ and @steakhal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. Talking on the mailing list, I got a link on reinterpret_casting for pointer-to-member: https://timsong-cpp.github.io/cppwp/n4861/expr.reinterpret.cast#10 The gist is that this sort of cast is only valid if we cast back to the original type (that too with a caveat).

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

Jim added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1703 +} + } + Ms.emplace_back(Multilib); Do you have plan to support other kind of options to build multilib? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem updated this revision to Diff 328354. gulfem added a comment. Use TTI hook for target machine checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94355/new/ https://reviews.llvm.org/D94355 Files:

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. Thanks for explaining that it only affects "-B". While I believe that this change won't affect us in Chrome OS, I think it should be reviewed and approved by a few Linux distro contributors since there is already known reliance e.g. Android on the current behavior.

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

manojgupta added a comment. thanks, this is much needed documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 ___ cfe-commits mailing list

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. In D97993#2605157 , @manojgupta wrote: > I am not sure of the rationale or upside of this change and why do we want to > drop gcc detection? GCC does not need to do the GCC detection because it has > the needed information at

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

MaskRay added a comment. If the end goal is to provide a complete libc, and currently the usage is expected to shadow system libc (this has to be very careful, as I don't know how shadowing some important components like pthread shall work), perhaps the name should convey this point?

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. I am not sure of the rationale or upside of this change and why do we want to drop gcc detection? GCC does not need to do the GCC detection because it has the needed information at configure time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay created this revision. MaskRay added reviewers: hubert.reinterpretcast, manojgupta, nickdesaulniers, phosek. Herald added a subscriber: danielkiss. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In GCC, if `-B $prefix` is

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } rjmccall wrote: > ychen wrote: > > ychen wrote: > > >

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:680 +for (StringRef Arg : CmdArgs) { + if (Arg == "-lm" || Arg == "-lc") { +// TODO: Add -lllvmlibc before -lpthread when LLVM libc has pthread sivachandra wrote:

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:680 +for (StringRef Arg : CmdArgs) { + if (Arg == "-lm" || Arg == "-lc") { +// TODO: Add -lllvmlibc before -lpthread when LLVM libc has pthread phosek wrote: >

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

sivachandra updated this revision to Diff 328340. sivachandra added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97736/new/ https://reviews.llvm.org/D97736 Files: clang/include/clang/Driver/Options.td

[PATCH] D97990: [clang] Always provide relevant subobject for 'no viable comparison'

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnostics for defaulted no viable not-equal and relational operators where not providing relevant subobject in diagnostics, unlike the cases for

[clang] cedc532 - Fix clang for header move in LLVM/IR

Author: David Blaikie Date: 2021-03-04T16:20:44-08:00 New Revision: cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e URL: https://github.com/llvm/llvm-project/commit/cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e DIFF: https://github.com/llvm/llvm-project/commit/cedc53254a5d2e04e79cc0e7bf5a8c71fafa295e.diff

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

manojgupta added a comment. > With the special rule, it is: if --gcc-toolchain is $sysroot/usr, suppress > sysroot GCC detection as well. > > Clang -B and --gcc-toolchain have some weird behaviors. Hope you can share > your opinions on >

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

amccarth added a comment. From a Windows point of view, this LGTM. Comment at: clang/lib/Frontend/FrontendActions.cpp:841 } } The preceding block that detects the type of line separator seems ripe for factoring out into a separate function. It's a

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } ychen wrote: > ychen wrote: > > rjmccall wrote: > > >

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561abd83ffec: [WebAssembly] Disable uses of __clang_call_terminate (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 561abd8 - [WebAssembly] Disable uses of __clang_call_terminate

Author: Heejin Ahn Date: 2021-03-04T14:26:35-08:00 New Revision: 561abd83ffecc8d4ba8fcbbbcadb31efc55985c2 URL: https://github.com/llvm/llvm-project/commit/561abd83ffecc8d4ba8fcbbbcadb31efc55985c2 DIFF: https://github.com/llvm/llvm-project/commit/561abd83ffecc8d4ba8fcbbbcadb31efc55985c2.diff

[PATCH] D97983: [clangd] strictly respect formatting range

qchateau updated this revision to Diff 328314. qchateau added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97983/new/ https://reviews.llvm.org/D97983 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:680 +for (StringRef Arg : CmdArgs) { + if (Arg == "-lm" || Arg == "-lc") { +// TODO: Add -lllvmlibc before -lpthread when LLVM libc has pthread This wouldn't handle

[PATCH] D97983: [clangd] strictly respect formatting range

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Clang format will often format a

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 328308. timwoj added a comment. Rebase onto master again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/docs/ReleaseNotes.rst

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

manojgupta added a comment. In Chrome OS, we currently both "-B" and "--prefix". "-B" points to binutils bin directory and the "--prefix" has the binutils directory + target suffix. Should we drop "-B" and still get the same behavior? Sample invocation: '/usr/bin/clang++'

[clang] 1c2e7d2 - [MS] Fix crash involving gnu stmt exprs and inalloca

Author: Reid Kleckner Date: 2021-03-04T13:57:46-08:00 New Revision: 1c2e7d200df27e91631ba300965245518bfe252c URL: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c DIFF: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c.diff

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } ychen wrote: > rjmccall wrote: > > Okay, so you're

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } rjmccall wrote: > Okay, so you're implicitly increasing the

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } Okay, so you're implicitly increasing the coroutine size

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai added a comment. In D97878#2602077 , @plotfi wrote: > This makes sense to me. I approve. Can we move the 3/60 seconds number to a > const int value set somewhere higher up in the file as a global with a > comment explaining this as well?

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai updated this revision to Diff 328283. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 Files:

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added a comment. > The idea here is not to "ignore type alignment". `EmitPointerWithAlignment` > will sometimes return an alignment for a pointer that's less than the > alignment of the pointee type, e.g. because you're taking the address of a > packed struct field. The critical

[clang] 10264a1 - Introduce noundef attribute at call sites for stricter poison analysis

Author: Gui Andrade Date: 2021-03-04T12:15:12-08:00 New Revision: 10264a1b21aebf75a8102116c9648c3386e8021e URL: https://github.com/llvm/llvm-project/commit/10264a1b21aebf75a8102116c9648c3386e8021e DIFF: https://github.com/llvm/llvm-project/commit/10264a1b21aebf75a8102116c9648c3386e8021e.diff

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbff7faea2034: [clang-tidy] Add options to describe individual core increments to readability… (authored by massberg, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] bff7fae - [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

Author: Jens Massberg Date: 2021-03-04T21:02:27+01:00 New Revision: bff7faea2034abed4535645d7c771e67c1f2bb23 URL: https://github.com/llvm/llvm-project/commit/bff7faea2034abed4535645d7c771e67c1f2bb23 DIFF: https://github.com/llvm/llvm-project/commit/bff7faea2034abed4535645d7c771e67c1f2bb23.diff

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu added a comment. In D97101#2603321 , @thakis wrote: > This broke ContinuousSyncMode/basic.c in check-profile on macOS (see e.g. end > of >

[clang] 9783e20 - Revert "Revert "[Coverage] Emit gap region between statements if first statements contains terminate statements.""

Author: Zequan Wu Date: 2021-03-04T11:52:43-08:00 New Revision: 9783e2098800b954c55ae598a1ce5c4b93444fc0 URL: https://github.com/llvm/llvm-project/commit/9783e2098800b954c55ae598a1ce5c4b93444fc0 DIFF: https://github.com/llvm/llvm-project/commit/9783e2098800b954c55ae598a1ce5c4b93444fc0.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. @jansvoboda11 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Thanks! Reapplied the patch in https://github.com/llvm/llvm-project/commit/1900503595cbb84a4c6e140a9ba1a2c574c0586d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

rjmccall added a comment. In D97224#2604069 , @jyknight wrote: > In D97224#2596410 , @rjmccall wrote: > >> Do we really consider the existing atomic intrinsics to not impose added >> alignment restrictions? I'm

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

rnk added a comment. Yes, we took steps to suppress CRLF generation. Part of that was to avoid Windows-only test failures from trailing CR whitespace interacting with tools like `diff`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2602687 , @hans wrote: > In D92808#2601408 , @fhahn wrote: > >> In D92808#2600245 , @hans wrote: >> >>> Reverted in >>>

[clang] 1900503 - [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of

Author: Akira Hatanaka Date: 2021-03-04T11:22:30-08:00 New Revision: 1900503595cbb84a4c6e140a9ba1a2c574c0586d URL: https://github.com/llvm/llvm-project/commit/1900503595cbb84a4c6e140a9ba1a2c574c0586d DIFF:

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

jkorous added a comment. LGTM. Adding the comment would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 ___ cfe-commits mailing list

[PATCH] D97941: [Reland] "Do not apply calling conventions to MSVC entry points"

rnk added a comment. Seems reasonable Comment at: clang/lib/Sema/SemaDecl.cpp:11206-11207 +} else if (FT->getCallConv() != CC_X86StdCall) { + // Default calling convention for WinMain, wWinMain and DllMain is + // __stdcall + FT = Context.adjustFunctionType(

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

MaskRay added a comment. In D97894#2602638 , @mgorny wrote: > Well, I think this was mostly 'just in case' condition, so I guess it's fine. > Let's just wait for @manojgupta to give it some more testing. Thanks. I sent D97902

[PATCH] D97940: [clang-tidy] Extend LoopConvert on array with `!=` comparison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa85eb11129ce: [clang-tidy] Extend LoopConvert on array with `!=` comparison (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] a85eb11 - [clang-tidy] Extend LoopConvert on array with `!=` comparison

Author: Nathan James Date: 2021-03-04T18:58:59Z New Revision: a85eb11129ce941e91b5bc3b188e469aaca4425f URL: https://github.com/llvm/llvm-project/commit/a85eb11129ce941e91b5bc3b188e469aaca4425f DIFF: https://github.com/llvm/llvm-project/commit/a85eb11129ce941e91b5bc3b188e469aaca4425f.diff LOG:

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2603089 , @curdeius wrote: > LGTM. It's indeed more logical this way. > Hopefully the original author will confirm. I'll give him one week, if he or nobody else comes along to object I'll push it.

[PATCH] D97296: [analyzer] Add a new parameter ProgramStateRef to SValBuilder::evalCast function

ASDenysPetrov updated this revision to Diff 328238. ASDenysPetrov added a comment. Missed to add changes in unittests. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97296/new/ https://reviews.llvm.org/D97296 Files:

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2603912 , @lxfind wrote: > Could you describe in more detail what problem this patch solves? Yes, updated description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 328232. ychen edited the summary of this revision. ychen added a comment. - Add docs for `coro.align` - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36192790d84b: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs (authored by Conanap). Repository: rG LLVM Github

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added a comment. Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/D97535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97967: [HIP] do not use -munsafe-fp-atomics by default

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: jfb. yaxunl requested review of this revision. A bug was introduced when adding -munsafe-fp-atomics. By default it should be off. https://reviews.llvm.org/D97967 Files:

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

MaskRay updated this revision to Diff 328227. MaskRay added a comment. Add more information to --gcc-toolchain. Reference --gcc-toolchain in --prefix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 Files:

[PATCH] D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension

artemcm accepted this revision. artemcm added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97702/new/ https://reviews.llvm.org/D97702

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 328222. ArcsinX added a comment. Call `FileIndex::updateMain()` with an absolute file path in tests to avoid test failures in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

MaskRay updated this revision to Diff 328220. MaskRay marked 2 inline comments as done. MaskRay added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 Files:

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the compiler.

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight added a comment. In D97224#2596410 , @rjmccall wrote: > Do we really consider the existing atomic intrinsics to not impose added > alignment restrictions? I'm somewhat concerned that we're going to produce > IR here that's either really

[PATCH] D97224: Use Address for CGBuilder's CreateAtomicRMW and CreateAtomicCmpXchg.

jyknight updated this revision to Diff 328219. jyknight marked 2 inline comments as done. jyknight added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97224/new/ https://reviews.llvm.org/D97224 Files:

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added a comment. Thanks for the patch! It is a much needed clarification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97902/new/ https://reviews.llvm.org/D97902 ___ cfe-commits mailing

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:23 -Add to search path for binaries and object files used implicitly +Search $prefix/$triple-$file and $prefix$file for executables, libraries, includes and data files used by the

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz updated this revision to Diff 328206. adamcz added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97965/new/ https://reviews.llvm.org/D97965 Files: clang/lib/Sema/SemaTemplate.cpp

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz created this revision. adamcz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to trigger assertion when transforming c-tor with unparsed default argument. Now we ignore such constructors for this purpose. Repository: rG

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97552/new/ https://reviews.llvm.org/D97552

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

lxfind added a comment. Could you describe in more detail what problem this patch solves? Also, since you are adding a new intrinsics, please also update the coroutine documentation regarding this new intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension

Bigcheese added a comment. Looks fine to me, but it would be good for a Swift person to look at this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97702/new/ https://reviews.llvm.org/D97702 ___

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

njames93 added a comment. Tests haven't been added yet, wanted to gauge opinions on this first before fully committing to it. Comment at: clang/lib/ASTMatchers/Dynamic/TypoSuggester.cpp:40 +} // namespace clang \ No newline at end of file Duly noted :)

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

This revision was automatically updated to reflect the committed changes. Closed by commit rG9830901b341c: [clang] removes check against integral-to-pointer conversion... (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97512/new/

[clang] 9830901 - [clang] removes check against integral-to-pointer conversion...

Author: Christopher Di Bella Date: 2021-03-04T17:00:54Z New Revision: 9830901b341cfb884cdef00e0335c6e3e62d107a URL: https://github.com/llvm/llvm-project/commit/9830901b341cfb884cdef00e0335c6e3e62d107a DIFF:

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

njames93 created this revision. njames93 added reviewers: aaron.ballman, klimek, steveire. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is a typo in parsing and we can see a close

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre requested review of this revision. thopre added a comment. Requesting review since the logic has changed. This time I've also tested isfinite against glibc's result. All looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/

[PATCH] D97960: [clang-tidy] bugprone-signal-handler improvements: display call chain

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new feature to display the call chain if an unsafe

  1   2   >