[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4efd04f18c7: [clangd] Use URIs instead of paths in the index file list (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] c4efd04 - [clangd] Use URIs instead of paths in the index file list

Author: Aleksandr Platonov Date: 2021-03-06T10:47:05+03:00 New Revision: c4efd04f18c7e10c11de4a790f4d0c42f694d49b URL: https://github.com/llvm/llvm-project/commit/c4efd04f18c7e10c11de4a790f4d0c42f694d49b DIFF:

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebe6d3be0f73: [clang] Dont default to a specifically shared libunwind on mingw with a g++… (authored by mstorsjo). Repository: rG LLVM Github

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002dd47bdd67: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[clang] ebe6d3b - [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

Author: Martin Storsjö Date: 2021-03-06T08:50:46+02:00 New Revision: ebe6d3be0f73c15e64b1ebafd2a4b9fa836be78c URL: https://github.com/llvm/llvm-project/commit/ebe6d3be0f73c15e64b1ebafd2a4b9fa836be78c DIFF:

[clang] 002dd47 - [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

Author: Martin Storsjö Date: 2021-03-06T08:50:46+02:00 New Revision: 002dd47bdd674fad8186650f07458b1e062545df URL: https://github.com/llvm/llvm-project/commit/002dd47bdd674fad8186650f07458b1e062545df DIFF:

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

Quuxplusone added a comment.  Comment at: clang/lib/Sema/SemaExprCXX.cpp:4837 +// Enum types should always return false (same as UTT_IsSigned). +return !T->isEnumeralType() && T->isUnsignedIntegerType(); FWIW, I'd lose the parenthetical comment, and

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1199 + types. Note, before Clang 10, returned true for enumeration types if the + underlying type was signed, and returned false for floating-point types. * ``__is_standard_layout`` (C++, GNU,

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver created this revision. zoecarver added reviewers: ldionne, rsmith, tmatheson. zoecarver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updates __is_unsigned to have the same behavior as the standard specifies. This is in line

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + This seems to be assuming that the underlying C library's `stdalign.h` is C++ friendly. A C11 `stdalign.h` //does// define `alignof` and

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:163 // For candidate specified by --rocm-path we do not do strict check. +const SmallVectorImpl & tra wrote: > I'm not quite sure which

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } lewissbaker wrote: > ychen wrote: > > rjmccall wrote: >

[clang] e58d68f - Revert "[AMDGPU] Restore the s_memtime instruction in gfx1030"

Author: Mitch Phillips Date: 2021-03-05T18:24:59-08:00 New Revision: e58d68fcd06ddc7743e0419c0b364df3d44121b6 URL: https://github.com/llvm/llvm-project/commit/e58d68fcd06ddc7743e0419c0b364df3d44121b6 DIFF:

[PATCH] D98087: [clang] Fix constrained decltype(auto) deduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e6e82746ca: [clang] Fix constrained decltype(auto) deduction (authored by mizvekov, committed by rsmith). Repository: rG LLVM Github Monorepo

[clang] 71e6e82 - [clang] Fix constrained decltype(auto) deduction

Author: Matheus Izvekov Date: 2021-03-05T18:20:09-08:00 New Revision: 71e6e82746caba1a40a0faeb43fe0c0a1fadb77e URL: https://github.com/llvm/llvm-project/commit/71e6e82746caba1a40a0faeb43fe0c0a1fadb77e DIFF:

[PATCH] D98095: [clang] Fix ICE on invalid type parameters for concepts

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR48593. Constraints with invalid type parameters were causing a null pointer dereference. Signed-off-by: Matheus Izvekov Repository: rG

[PATCH] D98087: [clang] Fix constrained decltype(auto) deduction

mizvekov updated this revision to Diff 328711. mizvekov added a comment. Turns out someone had already reported this bug. This change puts "PR48384" in the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98087/new/

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a2a167b6ca7: [DirectoryWatcher] Increase timeout to make test less flaky (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/

[clang] 9a2a167 - [DirectoryWatcher] Increase timeout to make test less flaky

Author: Shoaib Meenai Date: 2021-03-05T17:49:14-08:00 New Revision: 9a2a167b6ca7c35b60846592d7c11332c1f424e3 URL: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3 DIFF: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3.diff

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

lewissbaker added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:4450 +Value *Extra = Builder.CreateSelect(Cmp, Diff, Zero); +return RValue::get(Builder.CreateAdd(SizeCall, Extra)); } ychen wrote: > rjmccall wrote: > > ychen wrote: > > >

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

hctim added a comment. Hello, it looks like this change broke the MSan and ASan buildbots. http://lab.llvm.org:8011/#/builders/5/builds/5327 FAIL: LLVM :: CodeGen/AMDGPU/GlobalISel/readcyclecounter.ll (39307 of 74613) TEST 'LLVM ::

[clang] f4ad7a1 - [PowerPC] Add missing double precision vec_all overloads to altivec.h

Author: Nemanja Ivanovic Date: 2021-03-05T18:42:12-06:00 New Revision: f4ad7a1a15b7378522a17df7278856449005b8e1 URL: https://github.com/llvm/llvm-project/commit/f4ad7a1a15b7378522a17df7278856449005b8e1 DIFF:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/altera-unroll-loops.rst:15 + +- This check is unable to determine the number of iterations in a `while` or + `do..while` loop; hence if such a loop is fully unrolled, a note is emitted

[PATCH] D98087: [clang] Fix constrained decltype(auto) deduction

mizvekov updated this revision to Diff 328689. mizvekov added a comment. Added new tests as suggested by rsmith. By the way, I still need help commiting this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98087/new/

[PATCH] D98087: [clang] Fix constrained decltype(auto) deduction

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! Comment at: clang/test/CXX/dcl/dcl.spec/dcl.type/dcl.spec.auto/p6.cpp:59-63 + True decltype(auto) e = a; + static_assert(is_same_v); + + True

[clang] abbe42d - PR49260: Improve diagnostics for no matching 'operator new'.

Author: Richard Smith Date: 2021-03-05T15:53:10-08:00 New Revision: abbe42d8b5e4e0f3a30adbf232c693712cf2899c URL: https://github.com/llvm/llvm-project/commit/abbe42d8b5e4e0f3a30adbf232c693712cf2899c DIFF: https://github.com/llvm/llvm-project/commit/abbe42d8b5e4e0f3a30adbf232c693712cf2899c.diff

[PATCH] D98087: [clang] Fix constrained decltype(auto) deduction

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this fix, constrained decltype(auto) behaves exactly the same as constrained regular auto. This fixes it so it deduces like decltype(auto).

[clang] 4b15b2d - [clang][OpenMP][docs] Update loop transformation status.

Author: Michael Kruse Date: 2021-03-05T17:26:55-06:00 New Revision: 4b15b2df23389be567814cedcfddc8008c354b3d URL: https://github.com/llvm/llvm-project/commit/4b15b2df23389be567814cedcfddc8008c354b3d DIFF: https://github.com/llvm/llvm-project/commit/4b15b2df23389be567814cedcfddc8008c354b3d.diff

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

daltenty added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || + !Args.hasArg(OPT_fvisibility))) No sure if we

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/Dynamic/Diagnostics.h:62-72 ET_RegistryMatcherNotFound = 1, -ET_RegistryWrongArgCount = 2, -ET_RegistryWrongArgType = 3, -ET_RegistryNotBindable = 4, -ET_RegistryAmbiguousOverload =

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

MaskRay accepted this revision. MaskRay added a comment. In D98023#2607944 , @mstorsjo wrote: > In D98023#2607854 , @MaskRay wrote: > >> I have tested the following configurations on x86_64-linux-gnu and I don't

[PATCH] D97963: [ASTMatchers][Dynamic] Provide Fallback and suggestions for typos.

njames93 updated this revision to Diff 328664. njames93 added a comment. Address clang-tidy issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97963/new/ https://reviews.llvm.org/D97963 Files:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 328663. njames93 marked 5 inline comments as done. njames93 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files:

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); I'm not entirely sure what `D.PrefixDirs` represents

[PATCH] D98023: [clang] Don't default to a specifically shared libunwind on mingw with a g++ driver

mstorsjo updated this revision to Diff 328657. mstorsjo retitled this revision from "[clang] Don't make the g++ driver imply an explicitly shared libunwind" to "[clang] Don't default to a specifically shared libunwind on mingw with a g++ driver". mstorsjo added a comment. Changed the condition

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

mstorsjo added a comment. In D98023#2607854 , @MaskRay wrote: > I have tested the following configurations on x86_64-linux-gnu and I don't > find a difference. > > CC=/tmp/RelA/bin/clang > CXX=/tmp/RelA/bin/clang++ > $CC -c a.c > $CC a.o '-###'

[PATCH] D98018: [Fuchsia] Enable Polly for first stage as well

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3cd2f42521fe: [Fuchsia] Enable Polly for first stage as well (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3cd2f42 - [Fuchsia] Enable Polly for first stage as well

Author: Petr Hosek Date: 2021-03-05T14:35:57-08:00 New Revision: 3cd2f42521fea89de3cf720fc0299690e82a7660 URL: https://github.com/llvm/llvm-project/commit/3cd2f42521fea89de3cf720fc0299690e82a7660 DIFF: https://github.com/llvm/llvm-project/commit/3cd2f42521fea89de3cf720fc0299690e82a7660.diff

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

tskeith accepted this revision. tskeith added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

MaskRay added a comment. I have tested the following configurations on x86_64-linux-gnu and I don't find a difference. CC=/tmp/RelA/bin/clang CXX=/tmp/RelA/bin/clang++ $CC -c a.c $CC a.o '-###' &> a/c.raw.txt $CC a.o --rtlib=compiler-rt --unwindlib=none '-###' &> a/c.rt.none.txt $CC

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

DiggerLin added a comment. in your summary , it looks clang will emit "-fvisibility default" to cc1 even if there is no -fvisibility in the clang command ? I compiled the clang with your patch, it looks do not always emit "-fvisibility default" to cc1. I understand wrong on your summary ?

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

guiand abandoned this revision. guiand added a comment. We decided to go with a positive flag for enabling noundef, so I'm closing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85788/new/ https://reviews.llvm.org/D85788

IMPORTANT NOTICE - Subscription to Mailman lists disabled immediately

All, We need to immediately disable subscription capabilities to all LLVM Mailman lists. The current Mailman server is being abused by subscribing valid email addresses to our lists and because the list requires confirmation, the email address gets “spam”. An email address is subscribed

[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78d0e91865f6: Refactor -funique-internal-linakge-names implementation. (authored by tmsriram). Herald added a project: clang. Herald added a

[clang] 78d0e91 - Refactor -funique-internal-linakge-names implementation.

Author: Sriraman Tallam Date: 2021-03-05T13:32:17-08:00 New Revision: 78d0e91865f6038adb23ec272c3e1e7e1525057f URL: https://github.com/llvm/llvm-project/commit/78d0e91865f6038adb23ec272c3e1e7e1525057f DIFF:

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 328632. DiggerLin added a comment. rebase code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. The notes cover functionality in clang added by commits from 16 July to 27th Jan. https://reviews.llvm.org/D98076 Files:

[PATCH] D98075: [Matrix] Implement += and -= for MatrixType

SaurabhJha created this revision. Herald added a subscriber: tschuett. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98075 Files: clang/lib/Sema/SemaExpr.cpp

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

rjmccall added a comment. In D97915#2607567 , @ychen wrote: > In D97915#2607338 , @rjmccall wrote: > >> Let's try to avoid adding a new builtin for what we acknowledge is a >> workaround. Builtins become part of

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg created this revision. Herald added subscribers: lebedev.ri, xazax.hun. Herald added a reviewer: lebedev.ri. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a macro is used within a function, the code inside the macro

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2605914 , @kentsommer wrote: > LGTM > > Sorry for the slow response! No problem, we all have some phases where we don't have or find the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2605517 , @timwoj wrote: > In D94500#2605515 , > @HazardyKnusperkeks wrote: > >> In D94500#2604754 , @timwoj wrote: >> >>>

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f9f94b2e2b: [clang-format] Rework Whitesmiths mode to use line-level values in… (authored by timwoj, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97927: [clang-format] Rename case sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b02794f0aeb: [clang-format] Rename case sorting (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7309404536c: [clang-format] Suppress diagnostics on second parse (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[clang] f7f9f94 - [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

Author: Tim Wojtulewicz Date: 2021-03-05T21:42:46+01:00 New Revision: f7f9f94b2e2b4c714bac9036f6b73a3df42daaff URL: https://github.com/llvm/llvm-project/commit/f7f9f94b2e2b4c714bac9036f6b73a3df42daaff DIFF:

[clang] 7b02794 - [clang-format] Rename case sorting

Author: Björn Schäpers Date: 2021-03-05T21:42:45+01:00 New Revision: 7b02794f0aeb7eaf68d18fffc3057c3c7d975d75 URL: https://github.com/llvm/llvm-project/commit/7b02794f0aeb7eaf68d18fffc3057c3c7d975d75 DIFF:

[clang] e730940 - [clang-format] Suppress diagnostics on second parse

Author: Björn Schäpers Date: 2021-03-05T21:42:45+01:00 New Revision: e7309404536cf7f389afc8678688f9e3726f1eb8 URL: https://github.com/llvm/llvm-project/commit/e7309404536cf7f389afc8678688f9e3726f1eb8 DIFF:

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a subscriber: tstellar. manojgupta added a comment. Thanks for the clarification. I do not have any objections but I feel that am not the right person to approve this change. @tstellar can you please review it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2de5aff1a08: [OpenMP] Handle non-function context before checking for diagnostic (authored by pmrao, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c2de5af - [OpenMP] Handle non-function context before checking for diagnostic

Author: PremAnand Rao Date: 2021-03-05T12:37:49-08:00 New Revision: c2de5aff1a08ce70507f2c0a53eeffa5135c5273 URL: https://github.com/llvm/llvm-project/commit/c2de5aff1a08ce70507f2c0a53eeffa5135c5273 DIFF: https://github.com/llvm/llvm-project/commit/c2de5aff1a08ce70507f2c0a53eeffa5135c5273.diff

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc28f600e558: [AMDGPU] Restore the s_memtime instruction in gfx1030 (authored by foad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] fc28f60 - [AMDGPU] Restore the s_memtime instruction in gfx1030

Author: Jay Foad Date: 2021-03-05T20:19:11Z New Revision: fc28f600e558c1344618bda149a068d6162b6f0b URL: https://github.com/llvm/llvm-project/commit/fc28f600e558c1344618bda149a068d6162b6f0b DIFF: https://github.com/llvm/llvm-project/commit/fc28f600e558c1344618bda149a068d6162b6f0b.diff LOG:

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. OK, I will merge it on Monday unless @tskeith has any other comments. Comment at: clang/include/clang/Driver/Options.td:4232-4233 HelpText<"Use INTEGER(KIND=8) for the result type in size-related intrinsics.">; +def fdebug_module_writer :

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2607338 , @rjmccall wrote: > Let's try to avoid adding a new builtin for what we acknowledge is a > workaround. Builtins become part of the language supported by the compiler, > so we shouldn't add them casually. If

[PATCH] D98068: Remove asserts for LocalInstantiationScope

yaxunl created this revision. yaxunl added reviewers: rsmith, rjmccall, tra. yaxunl requested review of this revision. A lambda in a function template may be recursively instantiated as the following example: template struct Number { static constexpr unsigned value = v; };

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

MaskRay added a comment. In D97993#2607523 , @manojgupta wrote: > Another concern is people generally want clang to work out of box without any > special arguments. As a user, after installing clang's distro package or > building from source, I expect

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

manojgupta added a comment. Another concern is people generally want clang to work out of box without any special arguments. As a user, after installing clang's distro package or building from source, I expect that basic compilation should work out-of-box which includes gcc detection. i.e.

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

mstorsjo added a subscriber: MaskRay. mstorsjo added a comment. In D98023#2606973 , @mati865 wrote: > I'm a bit worried about this code though: > > bool AsNeeded = LGT == LibGccType::UnspecifiedLibGcc && > !TC.getTriple().isAndroid()

[PATCH] D98022: [clang] Fix typos in the default logic for CLANG_DEFAULT_UNWINDLIB

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98022/new/ https://reviews.llvm.org/D98022

[PATCH] D46443: [libc++] Add missing cstdalign header

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Please wait for CI to finish! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov added a comment. @NoQ Thanks for your comment. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:877-879 + std::tie(IsZero, IsNotZero) = + getStateManager().getConstraintManager().isSymValWithinOrOutsideRange( + State, SE,

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @NoQ Thanks, I could finally draw your attention :) > When, and why, would a regular user use this functionality? IMO there is no reason to use evalCast without an **original** type. But I'm not sure that you can get an **original** type in every case. About

[PATCH] D97928: [AMDGPU] Restore the s_memtime instruction in gfx1030

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97928/new/ https://reviews.llvm.org/D97928

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 328579. ffrankies marked 12 inline comments as done. ffrankies added a comment. - Added support for `CXXForRangeStmt` loops - Added support for different for loop increments (`++`, `--`, `+=`, `-=`, `*=`, `\=`) - Depending on the exit condition, the

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

rjmccall added a comment. Let's try to avoid adding a new builtin for what we acknowledge is a workaround. Builtins become part of the language supported by the compiler, so we shouldn't add them casually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:1082-1084 auto *User = Function::Create(FunctionType::get(Int32Ty, false), GlobalValue::LinkOnceODRLinkage,

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

phosek created this revision. phosek added reviewers: vsk, davidxl. Herald added a subscriber: hiraditya. phosek requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. When using -fprofile-list to selectively apply

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7462 + def note_lambda_default_capture_fixit : Note< +"capture all by %select{value|reference}0">; def note_lambda_decl : Note<"lambda expression begins here">;

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added a comment. Thanks! The code looks right, my comments are mostly for the comments around to validate my mental model of the code structure and behavior. Comment at: clang/lib/Sema/SemaExpr.cpp:17413 + StringRef Separator = LSI->NumExplicitCaptures > 0 ? ", " :

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. In D97915#2605398 , @ChuanqiXu wrote: > I am a little confusing about the problem. The example in the link tells the > align of the `promise` instead of the `frame`. The address of `promise` and > `frame` is not same. It looks

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius accepted this revision as: curdeius. curdeius added a comment. LGTM but please wait for libc++ group approval. If you need someone to land it for you, please provide "Firstname Name " for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5951 const QualType EltTy = - cast(CondTy.getCanonicalType())->getElementType(); + CondTy->isVectorType() + ? cast(CondTy.getCanonicalType())->getElementType() Why

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328561. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

fhahn created this revision. fhahn added reviewers: rjmccall, erichkeane, aaron.ballman. fhahn requested review of this revision. Herald added a project: clang. This patch implements the conditional select operator for ext_vector_types in C++. It does so by using the same semantics as for C.

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328557. sbc100 marked 2 inline comments as done. sbc100 added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt

[PATCH] D46443: Add missing cstdalign header

sbc100 marked 2 inline comments as done. sbc100 added inline comments. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28 +#ifdef alignas +#error alignas should not be a macro in C++ +#endif + +#ifdef alignof +#error alignof should not be a macro in

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:1885 +let isReMaterializable = 1, isMoveImm = 1, Predicates = [PrefixInstrs] in { + def XXSPLTI32DX : I think it might be good to add a comment of why the `XXSPLTI32DX`

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

yaxunl added a comment. @tra I got some issue with this patch. There are cases that an expression using a host variable is compile-time constant, e.g. int x; __device__ void fun() { sizeof(x); } Do we want to allow that? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl added a comment. In D92363#2607072 , @yaxunl wrote: > @tra I got some issue with this patch. There are cases that an expression > using a host variable is compile-time constant, e.g. > > int x; > __device__ void fun() { > sizeof(x); > }

[PATCH] D92363: [HIP] Warn no --offload-arch option

yaxunl added a comment. @tra I got some issue with this patch. There are cases that an expression using a host variable is compile-time constant, e.g. int x; __device__ void fun() { sizeof(x); } Do we want to allow that? Thanks. CHANGES SINCE LAST ACTION

[PATCH] D46443: Add missing cstdalign header

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:8 +//===--===//

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

svenvh updated this revision to Diff 328549. svenvh added a comment. > You don't seem to be using write_imagef for OpenCL versions <= 1.2. But > should we be checking that the diagnostic is given? Good point, I have updated the test to check for the diagnostic. CHANGES SINCE LAST ACTION

[PATCH] D98023: [clang] Don't make the g++ driver imply an explicitly shared libunwind

mati865 added a comment. It's clear overlook from D79995 , that part is perfectly reasonable to me. I'm a bit worried about this code though: bool AsNeeded = LGT == LibGccType::UnspecifiedLibGcc && !TC.getTriple().isAndroid() &&

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 328533. khchen added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def

[PATCH] D46443: Add missing cstdalign header

sbc100 updated this revision to Diff 328538. sbc100 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 Files: libcxx/include/CMakeLists.txt libcxx/include/cstdalign

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:19-22 + alignof + alignas +__alignof_is_defined +__alignas_is_defined curdeius wrote: > You should test that each of these macros is really defined when including > `cstdalign`.

[PATCH] D46443: Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/test/libcxx/utilities/any/size_and_alignment.pass.cpp:16 #include +#include curdeius wrote: > This doesn't seem to be necessary. Or? > In C++, `alignof` is a keyword. You are right its not necessary in C++

[clang] ed95129 - Fix Wdocumentation unknown parameter warning. NFCI.

Author: Simon Pilgrim Date: 2021-03-05T15:58:20Z New Revision: ed951293affca9abd92c886432115f35065cad3c URL: https://github.com/llvm/llvm-project/commit/ed951293affca9abd92c886432115f35065cad3c DIFF: https://github.com/llvm/llvm-project/commit/ed951293affca9abd92c886432115f35065cad3c.diff

  1   2   >