[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330495. atirit added a comment. Fixed `AfterEnum`'s compatibility with `AllowShortEnumsOnASingleLine` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files:

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330493. mizvekov added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98160/new/ https://reviews.llvm.org/D98160 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

On Sat, Mar 13, 2021 at 9:36 AM Eric Christopher wrote: > > > On Fri, Mar 5, 2021 at 1:15 AM Siva Chandra via Phabricator < > revi...@reviews.llvm.org> wrote: > >> sivachandra added a comment. >> >> In D97736#2605535 , @phosek >> wrote: >> >> > Have you

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

SamuelMarks updated this revision to Diff 330487. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98594/new/ https://reviews.llvm.org/D98594 Files: clang/docs/HowToSetupToolingForLLVM.rst clang/docs/LibASTMatchersTutorial.rst Index: clang/docs/LibASTMatchersTutorial.rst

[PATCH] D98594: [clang/docs/LibASTMatchersTutorial.rst,clang/docs/HowToSetupToolingForLLVM.rst] ninja now uses `configure.py` rather than `bootstrap.py`

SamuelMarks created this revision. SamuelMarks added a project: LLVM. SamuelMarks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98594 Files:

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8968-8970 def note_defaulted_comparison_calls_deleted : Note< "defaulted %0 is implicitly deleted because it would invoke a deleted " "comparison function%select{| for member %2|

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. > If what you're suggesting is that Clang have a SYCL-specific page that serves > a similar purpose to https://clang.llvm.org/docs/OpenCLSupport.html, then I > agree we should have that (and it should be linked to from > https://clang.llvm.org/docs/index.html the

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 330484. mizvekov added a comment. - Uses yet another simpler approach: Since dependence should not matter (we were using the type of the expression after template instantiation anyway), we don't even need to build a `decltype` type here, and just get the

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/Sparc.cpp:160-164 + // Linux doesn't need these variants, but the BSDs do. + if (getTriple().getOS() !=

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

brad added a comment. I do not immediately see why the other tests are failing, but at a bare minimum the following test from clang/test/Preprocessor/predefined-arch-macros.c will have to be updated.. // RUN: %clang -mcpu=v9 -E -dM %s -o - 2>&1 \ // RUN: -target sparc-unknown-linux \

[PATCH] D94741: [Utils] Check for more global information in update_test_checks

nikic added a comment. It looks like this has broken handling of `getelementptr %T`, and generates `getelementptr [[T]]` for it now, see e.g. the first change in https://github.com/llvm/llvm-project/commit/7ee96429a0b057bcc97331a6a762fc3cd00aed61. In

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

tianshilei1992 updated this revision to Diff 330464. tianshilei1992 added a comment. remove the requirement of `size_t size` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 Files:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

jwakely added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > jwakely wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; jwakely wrote: > hubert.reinterpretcast wrote: > >

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

bryanpkc added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292 + std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr); + driverPath = driverPath.substr(0, driverPath.size() - 9); + return

Re: [PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

On Fri, Mar 5, 2021 at 1:15 AM Siva Chandra via Phabricator < revi...@reviews.llvm.org> wrote: > sivachandra added a comment. > > In D97736#2605535 , @phosek > wrote: > > > Have you considered using an input linker script? We could generate > `libc.so`

[PATCH] D98583: [ASTMatchers] Fix documentation for hasAnyBody matcher

njames93 created this revision. njames93 added reviewers: baloghadamsoftware, aaron.ballman. Herald added a subscriber: rnkovacs. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Looks like a oversight when the matcher was added.

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

aaron.ballman added a comment. In D89909#2623887 , @Anastasia wrote: > In D89909#2623250 , @aaron.ballman > wrote: > >> In D89909#2623211 , @Anastasia >> wrote: >> >>> In

[PATCH] D98574: [Sparc] Define the same macros for -mcpu=v9 as GCC on Linux

glaubitz created this revision. glaubitz added reviewers: jrtc27, ro, efriedma, brad, jfb, venkatra, jyknight. Herald added a subscriber: fedor.sergeev. glaubitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting SPARC V8+ or

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 330428. v.g.vassilev added a comment. Formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 Files: clang/include/clang/CodeGen/CodeGenAction.h clang/include/clang/Frontend/FrontendAction.h