[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder added a comment. This (and https://reviews.llvm.org/D99338) are both NFC changes once https://reviews.llvm.org/D97362 lands (they need the three-parameter version of `ProhibitCXX11Attributes()`). I can merge the three into one patch if you prefer. CHANGES SINCE LAST ACTION

[PATCH] D98783: [CUDA][HIP] Remove unused addr space casts

rjmccall added a comment. In D98783#2642269 , @tra wrote: > We may want to add someone with more expertise with the IR as a reviewer. I'd > like an educated opinion on whether the invisible dangling IR is something > that needs fixing in general or if

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

rsmith added a comment. Only a nit, please go ahead once Aaron is happy :) Comment at: clang/test/Parser/cxx2a-template-lambdas.cpp:25-29 +auto L11 = [] requires true(){}; +auto L12 = [] requires true() noexcept {}; +auto L13 = [] requires true() noexcept requires true {};

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5011 +!ValType->isFloatingType()) { + Diag(ExprRange.getBegin(), diag::err_atomic_op_needs_atomic_int_ptr_or_fp) << IsC11 << Ptr->getType() << Ptr->getSourceRange();

[PATCH] D99456: [C++2b] Support size_t literals

rsmith added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:640 isFloat16 = true; continue; } Looks like this might fix [[ https://godbolt.org/z/9Pe4qr1c7 | incorrect acceptance ]] of `1.0f16f` and `1.0f16L` in CUDA mode

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:1240 + if (auto *CE = dyn_cast(RV)) +::makeTailCallIfSwiftAsync(CE, Builder, CurFnInfo); +} What's with the explicit `::` here? Repository: rG LLVM Github Monorepo

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 334042. yrouban added a comment. fixed the nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Passes/StandardInstrumentations.h

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban marked 2 inline comments as done. yrouban added a comment. In D91327#2655786 , @kuhar wrote: > Just two nits from me. I think it looks fine, but I'm not familiar with the > new pass manager and don't feel confident enough to approve it. Jakub,

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

liaolucy added a comment. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99151/new/ https://reviews.llvm.org/D99151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2091 + static const char *const X32Triples[] = { + "x86_64-linux-gnux32","x86_64-unknown-linux-gnux32", + "x86_64-pc-linux-gnux32"}; Just add `x86_64-linux-gnux32`. It

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added inline comments. Comment at: clang/test/Driver/as-options.s:40 + +// RUN: %clang -Wa,--version -c -integrated-as %s -o /dev/null 2>&1 \ +// RUN: | FileCheck --check-prefix=NOWARN --allow-empty %s Drop `2>&1` because you specifically want to test

[PATCH] D99556: Add support to -Wa,--version in clang

MaskRay added a comment. gcc does not understand options in `-Wa,` so `-Wa,--version` needs to be used this way: `gcc -Wa,--version -c -x assembler /dev/null -o /dev/null` The verbose syntax makes it not that useful. If the kernel really wants to use it, I have no issue with it.

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 334037. AntonBikineev marked 2 inline comments as done. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 7 inline comments as done. AntonBikineev added a comment. Thanks Richard for taking a look! Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:190 InGroup, DefaultIgnore; +def ext_cxx2b_size_t_suffix : Extension< + "'size_t' suffix for

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

rjmccall added a subscriber: fhahn. rjmccall added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else mizvekov

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5821a58d8e4c: [RISCV] Add inline asm constraint vr and vm in Clang for RISC-V V. (authored by HsiangKai). Repository: rG LLVM Github Monorepo

[clang] 5821a58 - [RISCV] Add inline asm constraint 'vr' and 'vm' in Clang for RISC-V 'V'.

Author: Hsiangkai Wang Date: 2021-03-30T09:47:27+08:00 New Revision: 5821a58d8e4c5510a4ab30fa758a9d22f41c346a URL: https://github.com/llvm/llvm-project/commit/5821a58d8e4c5510a4ab30fa758a9d22f41c346a DIFF:

[PATCH] D99539: [OPENMP]Fix PR48740: OpenMP declare reduction in C does not require an initializer

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99539/new/ https://reviews.llvm.org/D99539

[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 created this revision. jcai19 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang currently only supports -Wa,--version when -no-integrated-as is used. This adds support to -Wa,--version with -integrated-as. Link:

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

wmi created this revision. wmi added a reviewer: tejohnson. Herald added subscribers: steven_wu, hiraditya, inglorion. wmi requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Currently during module importing, ThinLTO opens all the source

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov updated this revision to Diff 334016. mizvekov added a comment. Changes per rsmith review: Just print the non-canonical type in the diagnostics. Instead of printing the expression, make the caret point to it, instead of pointing to the constraint. Repository: rG LLVM Github Monorepo

[PATCH] D99360: [OpenMP][WIP] Add standard notes for ELF offload images

vzakhari added a comment. In D99360#2654244 , @MaskRay wrote: >> It might make sense to do the llvm-readobj portions of this patch in a >> separate review, since they are somewhat independent. > > +1. Patches touching

[PATCH] D99525: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99525/new/ https://reviews.llvm.org/D99525

[PATCH] D99551: [clang-offload-wrapper] Add standard notes for ELF offload images

vzakhari created this revision. vzakhari added reviewers: ABataev, sdmitriev, grokos. vzakhari added a project: OpenMP. Herald added a reviewer: alexshap. vzakhari requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1.

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1059 +else if (auto *F = dyn_cast(DC)) + goto unimplemented; // FIXME: get the return type here somehow... +else rjmccall wrote: > mizvekov wrote: > >

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FeatureModule.h:112 + }; + /// Can be called asynchronously before building an AST. + virtual std::unique_ptr astHooks() { return nullptr; } sammccall wrote: > kadircet wrote: > > sammccall

[PATCH] D99456: [C++2b] Support size_t literals

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:190 InGroup, DefaultIgnore; +def ext_cxx2b_size_t_suffix : Extension< + "'size_t' suffix for literals is a C++2b extension">, Should this be an `ExtWarn`? I think we

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet planned changes to this revision. kadircet added a comment. Herald added a project: clang-tools-extra. as discussed offline, this gets messy if the header can be included both as a system and quoted included, and the coding style actually prefers the quoted one. it is not a big deal

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

echristo added a comment. In D17183#2656771 , @jyknight wrote: > In general, I think it's extremely unfortunate that Clang and LLVM have > different copies of the same information. It's a problem for way more than > just this one situation. So, I really

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet updated this revision to Diff 333982. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98505/new/ https://reviews.llvm.org/D98505 Files:

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.h:77 + // list. + std::vector OpaqueData; }; sammccall wrote: > Hmm, you've replaced the json::Array with an array of objects :-) > Any

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2761 def note_expr_requirement_constraints_not_satisfied_simple : Note< - "%select{and|because}0 %1 does not satisfy %2:">; +

[PATCH] D99363: [Windows] Turn off text mode in TableGen and Rewriter to stop CRLF translation

aganea added a comment. In D99363#2653476 , @abhina.sreeskantharajan wrote: > There were a lot of similar patches so reverting all of them might be more > work than isolating the change that caused it and reverting that. It seems > that the patch you

[PATCH] D99539: [OPENMP]Fix PR48740: OpenMP declare reduction in C does not require an initializer

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If no initializer-clause is specified, the private variables will be

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:432 +["vv", "Uv", "UvUvUv"], +["vx", "Uv", "UvUvUe"]]>; + Should we have a common class for

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

nrieck added a comment. Ah, I missed transferring my commit access from svn. If anyone could commit for me, please do. In D99458#2655458 , @curdeius wrote: > Thinking out loud, do we test `volatile` at all? I see only the variants with block comments

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd8dd580ffd2: [NFC] clang-formatting zos-alignment.c (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99514/new/

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor improvement for attribute ordering. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:732-733 +// Parse (optional) attributes. MaybeParseGNUAttributes(Attrs); +

[clang] bd8dd58 - [NFC] clang-formatting zos-alignment.c

Author: Fanbo Meng Date: 2021-03-29T16:48:10-04:00 New Revision: bd8dd580ffd221dd38e28c609b30d9b6361efac7 URL: https://github.com/llvm/llvm-project/commit/bd8dd580ffd221dd38e28c609b30d9b6361efac7 DIFF: https://github.com/llvm/llvm-project/commit/bd8dd580ffd221dd38e28c609b30d9b6361efac7.diff

[PATCH] D98160: [clang] Use decltype((E)) for compound requirement type constraint

rsmith added a comment. Thanks, I like this approach. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2761 def note_expr_requirement_constraints_not_satisfied_simple : Note< - "%select{and|because}0 %1 does not satisfy %2:">; + "%select{and|because}0

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98616/new/ https://reviews.llvm.org/D98616

[PATCH] D99421: [ASTImporter] Import member specialization/instantiation of enum decls

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/unittests/AST/ASTImporterTest.cpp:6256 + EXPECT_TRUE(ToD); + EXPECT_TRUE(ToD->getMemberSpecializationInfo()); +} Is it worth also

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev updated this revision to Diff 333972. AntonBikineev marked an inline comment as done. AntonBikineev added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99456/new/ https://reviews.llvm.org/D99456 Files:

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec marked an inline comment as done. rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFoldOperands.cpp:100 bool tryFoldOMod(MachineInstr ); + bool tryFoldRegSeqence(MachineInstr ); + bool tryFoldLCSSAPhi(MachineInstr ); foad wrote:

[PATCH] D96906: [AMDGPU] gfx90a support

foad added inline comments. Herald added a subscriber: mstorsjo. Comment at: llvm/lib/Target/AMDGPU/SIFoldOperands.cpp:100 bool tryFoldOMod(MachineInstr ); + bool tryFoldRegSeqence(MachineInstr ); + bool tryFoldLCSSAPhi(MachineInstr ); Spelling "sequence".

[PATCH] D99456: [C++2b] Support size_t literals

AntonBikineev marked 9 inline comments as done. AntonBikineev added a comment. Thanks Aaron for taking a look! Addressed the comments. I also hope it's okay to test preprocessor in the same test (test/Lexer/size_t-literal.cpp). Comment at: clang/lib/Sema/SemaExpr.cpp:3911 +

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

aqjune added a comment. Herald added a subscriber: lxfind. Hello all, Is there a plan to enable `-enable-noundef-analysis` by default? It seems this patch is already addressing a lot of test cases. Another good news is that DeadArgElim is also fixed by D98899

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 333885. Ericson2314 added a comment. 1. Updating D99484 : Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is used as

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

aaron.ballman added a comment. Mostly looks good, just a few things with the tests. Comment at: clang/test/Parser/cxx-concepts-requires-clause.cpp:160-162 #if __cplusplus <= 202002L // expected-warning@-2{{is a C++2b extension}} #endif This warning seems

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

jyknight added a comment. In general, I think it's extremely unfortunate that Clang and LLVM have different copies of the same information. It's a problem for way more than just this one situation. So, I really don't like choice 1 -- I think it's moving in the wrong direction. The recent

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333965. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. mention OF_CRLF is Windows-only Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan added a comment. In D99426#2656582 , @MaskRay wrote: > In D99426#2656217 , @rnk wrote: > >> In D99426#2653725 , @MaskRay wrote: >> >>> This touches a

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

rsmith added a comment. In principle this seems reasonable to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17050 +auto Target = SemaRef.IdentifyCUDATarget(FD); +if (Var && Var->isFileVarDecl() && !Var->hasAttr() && +!Var->hasAttr() && !Var->hasAttr() && I suspect you want

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

abhina.sreeskantharajan updated this revision to Diff 333960. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. Rebase + I updated the comments in FileSystem.h to be a bit more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D99414: [clang][tooling] Create SourceManager for DiagnosticsEngine before command-line parsing

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks, the error message is much better now! When applying this patch locally and also undoing the fix in our internal tool (i.e. change it to `-ferror-limit=-1`), the error I get is:

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Anastasia added a comment. Do you plan to implement any of the following restriction? > To allocate local memory within a kernel, the user can either pass a > sycl::local_accessor object as a argument to an ND-range kernel (that has a > user-defined work-group size), or can define a variable

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

kadircet updated this revision to Diff 333956. kadircet marked 3 inline comments as done. kadircet added a comment. - Add comments to the unittest to explain why we chose incorrect behaviour. - Extract authorization logic to a helper. - Count dropped symbols separately in fuzzyfind tracer stats.

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'. WIP.

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:899 +public: + /// Build a 'sizes' AST node. + /// `sizes`->`full` Comment at: clang/include/clang/AST/OpenMPClause.h:902 + /// \param C Context of

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4302 +def cpp : Flag<["-"], "cpp">, Group, + HelpText<"Always add standard macro predefinitions">; +def nocpp : Flag<["-"], "nocpp">, Group, tskeith wrote: > This option affects

[PATCH] D99292: [flang][driver] Add support for `-cpp/-nocpp`

awarzynski updated this revision to Diff 333953. awarzynski added a comment. Make sure that `-cpp\-nocpp` controls command line macro definitions too As @tskeith pointed out, `-cpp\-nocpp` should also affect command line macro definitions (on top of standard macro predefinitions). With this

[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to respect mapping/privatization of declare target variables in the

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

MaskRay added a comment. In D99426#2656217 , @rnk wrote: > In D99426#2653725 , @MaskRay wrote: > >> This touches a lot of files. I am a bit worried that it would not be easy >> for a contributor to know

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen added a comment. So sorry.. those huge tests make the browser so slowly, should I split them in the different patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99524/new/ https://reviews.llvm.org/D99524

[PATCH] D99528: [RISCV][Clang] Add more RVV Integer intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99525: [RISCV][Clang] Add RVV vnsra, vnsrl and vwmul intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99524: [RISCV][Clang] Add some RVV Integer intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99233: [HIP] Add option --gpu-inline-threshold

tra added a comment. I'm concerned that if we make it a top-level option, it's likely to be cargo-culted and (mis)used as a sledgehammer in cases where it's not needed. I think the option should remain hidden. While thresholds do need to be tweaked, in my experience it happens very rarely.

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl added a comment. In D98193#2656326 , @tra wrote: > I think we also may want to check that we allow `sizeof(host_var)` in the GPU > code. We have tests for that at line 94 of test/SemaCUDA/device-use-host-var.cu CHANGES SINCE LAST ACTION

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:21 +// Zbb extension +TARGET_BUILTIN(__builtin_riscv_orc_b, "LiLi", "nc", "experimental-zbb") +TARGET_BUILTIN(__builtin_riscv32_orc_b, "ZiZi", "nc", "experimental-zbb")

[PATCH] D99521: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a project: clang. Need to bitcast the function pointer passed as a parameter to the real type to avoid possible problem with

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 333925. mizvekov added a comment. Small update making some invariants more clear, with some simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files:

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra added a comment. I think we also may want to check that we allow `sizeof(host_var)` in the GPU code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___ cfe-commits mailing list

[PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

rnk added a comment. I think 1 is OK as long as we can assert that things don't get out of sync. I like the idea of putting the prefix next to the data layout string. In the long run, splitting up Support might be reasonable, and pushing DataLayout down out of IR seems like something that

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99514/new/ https://reviews.llvm.org/D99514

[PATCH] D99426: [Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

rnk added a comment. In D99426#2653725 , @MaskRay wrote: > This touches a lot of files. I am a bit worried that it would not be easy for > a contributor to know OF_TextWithCRLF is needed to make SystemZ happy. Right, we need to separate text-ness for

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

protze.joachim added a comment. Thank you for working on this! It works for me. As you mentioned in D95460 , this makes the behavior more similar to gcc. I tested with `-Werror`: $ flang -fopenmp test-f77.f -ffree-form -c $ clang -fopenmp test-f77.o

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 333914. haberman added a comment. - Updated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/Basic/Attr.td

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman created this revision. haberman added reviewers: rsmith, aaron.ballman. haberman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a Clang-only change and depends on the existing "musttail" support already implemented in

[PATCH] D98146: OpaquePtr: Turn inalloca into a type attribute

dblaikie added a comment. In D98146#2654598 , @arsenm wrote: > 4fefed65637ec46c8c2edad6b07b5569ac61e9e5 > Please include the "Differential Revision: ..." line in the commit message -

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

Naghasan added inline comments. Comment at: clang/docs/SYCLSupport.md:914-919 +Default address space represents "Generic-memory", which is a virtual address +space which overlaps the global, local and private address spaces. SYCL mode +enables conversion to/from default address

[PATCH] D99338: [clang][parser] Allow GNU-style attributes in enum specifiers

aaron.ballman added a comment. To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

aaron.ballman added a comment. To be clear, this is expected to be an NFC change that allows D97362 to be applied without breaking bots? If so, it'd be helpful to have the changes as part of D97362 because they're critical to

[clang] d3ff65d - [Clang] Fix line numbers in CHECK lines.

Author: Florian Hahn Date: 2021-03-29T17:37:48+01:00 New Revision: d3ff65dc11d797c39bb44621d64eb679c09207de URL: https://github.com/llvm/llvm-project/commit/d3ff65dc11d797c39bb44621d64eb679c09207de DIFF: https://github.com/llvm/llvm-project/commit/d3ff65dc11d797c39bb44621d64eb679c09207de.diff

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius updated this revision to Diff 333910. curdeius added a comment. - Hoist common code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99489/new/ https://reviews.llvm.org/D99489 Files: clang/lib/Parse/ParseExprCXX.cpp

[clang] 9320ac9 - [Clang] Only run test when X86 backend is built.

Author: Florian Hahn Date: 2021-03-29T17:27:01+01:00 New Revision: 9320ac9b4965d769632398b620ca3e4af9b56b12 URL: https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12 DIFF: https://github.com/llvm/llvm-project/commit/9320ac9b4965d769632398b620ca3e4af9b56b12.diff

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

tra added a comment. LGTM for CUDA. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99297/new/ https://reviews.llvm.org/D99297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99514: [NFC] clang-formatting zos-alignment.c

fanbo-meng created this revision. fanbo-meng added a reviewer: abhina.sreeskantharajan. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99514 Files:

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

jdoerfert updated this revision to Diff 333895. jdoerfert added a comment. Add test for nvptx codegen, including wrapper attribute check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99506/new/ https://reviews.llvm.org/D99506 Files:

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1e0c7fdd720: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile… (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f1e0c7f - [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

Author: Fanbo Meng Date: 2021-03-29T12:06:30-04:00 New Revision: f1e0c7fdd72026f62e2c38ee249705fbb9213a30 URL: https://github.com/llvm/llvm-project/commit/f1e0c7fdd72026f62e2c38ee249705fbb9213a30 DIFF: https://github.com/llvm/llvm-project/commit/f1e0c7fdd72026f62e2c38ee249705fbb9213a30.diff

[PATCH] D99488: [SYCL][Doc] Add address space handling section to SYCL documentation

aaron.ballman added a comment. Mostly grammar related review comments, nothing substantive. Comment at: clang/docs/SYCLSupport.md:816 +### Address spaces handling + Comment at: clang/docs/SYCLSupport.md:818 + +SYCL specification uses C++

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

jdoerfert added a comment. In D99506#2655948 , @fhahn wrote: > Is it possible to add a test? There is a test for the presence of noinline, let me make it more explicit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99297: [OPENMP]Fix PR49636: Assertion `(!Entry.getAddress() || Entry.getAddress() == Addr) && "Resetting with the new address."' failed.

JonChesterfield added a comment. Nice, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99297/new/ https://reviews.llvm.org/D99297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99508: [SystemZ][z/OS] Add test of leading zero length bitfield in const/volatile struct

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM, have a small nit Comment at: clang/test/CodeGen/SystemZ/zos-alignment.c:26 + long:0; + short a; +} VS0;

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson marked 2 inline comments as done. probinson added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99199: Make -fcrash-diagnostics-dir control the Windows (mini-)dump location

probinson updated this revision to Diff 333884. probinson added a comment. Remove ifdefs, tweak descriptions/comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99199/new/ https://reviews.llvm.org/D99199 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D99506: [OpenMP][NFC] Move the `noinline` to the parallel entry point

fhahn added a comment. Is it possible to add a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99506/new/ https://reviews.llvm.org/D99506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99489: [clang] [PR49736] [C++2b] Correctly reject lambdas with requires clause and no parameter list

curdeius added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1435 + +WarnIfHasCUDATargetAttr(); } else if (Tok.isOneOf(tok::kw_mutable, tok::arrow, tok::kw___attribute, aaron.ballman wrote: > Rather than add this in both branches, I'd say

  1   2   >