[PATCH] D99556: Add support to -Wa,--version in clang

jcai19 added a comment. We can probably remove the -fno-integraetd-as case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___ cfe-commits mailing list

[PATCH] D99592: [PoC][Clang] Use TypeSize instead of uint64_t for getTypeAllocSize().

HsiangKai updated this revision to Diff 334590. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99592/new/ https://reviews.llvm.org/D99592 Files: clang/lib/CodeGen/CGCall.cpp

[clang] bfcd218 - [debug-info] support new tuning debugger type DBX for XCOFF DWARF

Author: Chen Zheng Date: 2021-04-01T00:11:30-04:00 New Revision: bfcd21876adc3498065e4da92799f613e730d475 URL: https://github.com/llvm/llvm-project/commit/bfcd21876adc3498065e4da92799f613e730d475 DIFF: https://github.com/llvm/llvm-project/commit/bfcd21876adc3498065e4da92799f613e730d475.diff

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added a comment. @skatkov, @fedor.sergeev, could you please review. During the long time this features is on the reconstruction we introduced a new bug in the LoopFlatten pass. See the comment https://reviews.llvm.org/D90940#inline-938253. CHANGES SINCE LAST ACTION

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

jdoerfert added a comment. In D99689#2662860 , @ABataev wrote: > In D99689#2662856 , @jdoerfert wrote: > >> In D99689#2662852 , @ABataev wrote: >> >>> In D99689#2662848

[PATCH] D99590: [Clang] Do not use memcpy for scalable struct copy.

HsiangKai updated this revision to Diff 334579. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99590/new/ https://reviews.llvm.org/D99590 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

HsiangKai updated this revision to Diff 334578. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99482/new/ https://reviews.llvm.org/D99482 Files: clang/lib/CodeGen/CGCall.cpp Index:

[PATCH] D99482: [PoC][Clang][CodeGen] Do not use getelementptr for scalable struct.

HsiangKai added a comment. In D99482#2661334 , @frasercrmck wrote: > Are there any tests for this? The only scalable struct types are Zvlsseg types in Clang. We have use cases in D99593 . I have no separate test cases in

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev added a comment. In D99689#2662856 , @jdoerfert wrote: > In D99689#2662852 , @ABataev wrote: > >> In D99689#2662848 , @jdoerfert >> wrote: >> >>> Can you please

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

jdoerfert added a comment. In D99689#2662852 , @ABataev wrote: > In D99689#2662848 , @jdoerfert wrote: > >> Can you please show me a test case or explain to me when/how this global is >> actually used. > > It is

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev added a comment. In D99689#2662848 , @jdoerfert wrote: > Can you please show me a test case or explain to me when/how this global is > actually used. It is passed as an argument to the target region. When libomptarget requests the memory for

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

jdoerfert added a comment. Can you please show me a test case or explain to me when/how this global is actually used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99689/new/ https://reviews.llvm.org/D99689

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422 + // Register all the standard instrumentation callbacks. If \p FAM is nullptr + // then PreservedCFGChecker is not registeredenabled. + void

[clang] a821999 - [clang][APINotes] Fix -Wunused-function warning (NFC)

Author: Yang Fan Date: 2021-04-01T09:52:43+08:00 New Revision: a8219991d0245db8f31a923ba7f24e6beda345b0 URL: https://github.com/llvm/llvm-project/commit/a8219991d0245db8f31a923ba7f24e6beda345b0 DIFF: https://github.com/llvm/llvm-project/commit/a8219991d0245db8f31a923ba7f24e6beda345b0.diff

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov updated this revision to Diff 334575. mizvekov added a comment. fix clang-tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696 Files: clang/include/clang/Sema/Sema.h

[PATCH] D99556: Add support to -Wa,--version in clang

dyung added a comment. It also fails with the PS4 triple because we default to an external assembler that isn't present: https://lab.llvm.org/buildbot/#/builders/139/builds/2161/steps/6/logs/FAIL__Clang__as-version_s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov added a comment. In D99696#2662816 , @Quuxplusone wrote: > Wow, nice catches. For posterity, here's the missed-optimization being > addressed IIUC: https://godbolt.org/z/MEoKGs7cE Thanks! And again thank you for providing test cases, it's what

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

Quuxplusone added a comment. Wow, nice catches. For posterity, here's the missed-optimization being addressed IIUC: https://godbolt.org/z/MEoKGs7cE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99696/new/ https://reviews.llvm.org/D99696

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

craig.topper requested changes to this revision. craig.topper added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/riscv_vector.td:761 +defm vfdiv : RVVFloatingBinBuiltinSet; +defm vfrdiv : RVVFloatingBinBuiltinSet; +

[PATCH] D99696: [clang] WIP: NRVO: Improvements and handling of more cases.

mizvekov created this revision. Herald added a subscriber: lxfind. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This expands NRVO propagation for more cases: Parse analysis improvement: Lambdas and Blocks with dependent

[PATCH] D98912: Fix -Winteger-overflow to diagnose regardless of the top-level syntactic form.

vsapsai added a comment. Looks good to me. Have a few clarification questions. Comment at: clang/lib/AST/ExprConstant.cpp:972-973 +// Determine if we might warn that the given expression exhibits undefined +// behavior. +bool mightWarnOnUndefinedBehavior(const

[PATCH] D99556: Add support to -Wa,--version in clang

nickdesaulniers added a comment. ah, sorry, I think we're missing a `// REQUIRES: linux` in the newly added test? I've pushed a revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556

[clang] bf2479c - Revert "Add support to -Wa,--version in clang"

Author: Nick Desaulniers Date: 2021-03-31T17:02:13-07:00 New Revision: bf2479c347c8ca88fefdb144d8bae0a7a4231e2a URL: https://github.com/llvm/llvm-project/commit/bf2479c347c8ca88fefdb144d8bae0a7a4231e2a DIFF:

[PATCH] D99556: Add support to -Wa,--version in clang

thakis added a comment. Different error on windows: http://45.33.8.238/win/36132/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 ___ cfe-commits

[PATCH] D99556: Add support to -Wa,--version in clang

thakis added a comment. Looks like the test fails on non-linux: http://45.33.8.238/macm1/6631/step_6.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

liaolucy added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99668/new/ https://reviews.llvm.org/D99668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:282 +} +// Encode vx/wx in the sufffix of mangled name +let Name = NAME # "_" # vx_suffixes_prototype[0], sufffix->suffix Comment at:

[PATCH] D99556: Add support to -Wa,--version in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jcai19 marked an inline comment as done. Closed by commit rG3cc3c0f8352e: Add support to -Wa,--version in clang (authored by jcai19). Changed prior to commit:

[clang] 3cc3c0f - Add support to -Wa,--version in clang

Author: Jian Cai Date: 2021-03-31T16:29:02-07:00 New Revision: 3cc3c0f8352ec33ca2f2636f94cb1d85fc57ac16 URL: https://github.com/llvm/llvm-project/commit/3cc3c0f8352ec33ca2f2636f94cb1d85fc57ac16 DIFF: https://github.com/llvm/llvm-project/commit/3cc3c0f8352ec33ca2f2636f94cb1d85fc57ac16.diff

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk updated this revision to Diff 334557. hvdijk edited the summary of this revision. hvdijk added a comment. I have also updated the summary to provide a more complete explanation of the changes, and hope the revised summary will answer @MaskRay's questions. Repository: rG LLVM Github

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2662570 , @glaubitz wrote: > Since I am a big fan of consistency, I would rather leave it as is (4.6) and > then bump to 10.2.0 in a follow-up commit. You are right that including the bump in this commit would either

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added a comment. I addressed nearly all of the comments. I have just a few more test cases to add: Obj-C blocks and ARC. I left one comment open re: a "regular" function. I'll dig into that more when I am adding the last few test cases. Comment at:

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 334556. haberman marked 37 inline comments as done. haberman added a comment. - Expanded and refined the semantic checks for musttail, per CR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/

[PATCH] D99661: [SemaObjC] Fix a -Wbridge-cast false-positive

ahatanak added a comment. I see a warning when I compile the following (contrived) example: typedef const struct __attribute__((objc_bridge(NSError))) __CFString * CFStringRef; extern "C" { typedef const struct __attribute__((objc_bridge(NSString))) __CFString * CFStringRef; }

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:379 + +// Second add the generic one. +P.assign(Path); ldionne wrote: > Doesn't that break `#include_next` if both directories exist? Generally > speaking, I think you

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#2662434 , @ldionne wrote: > I'm personally not so concerned with the Clang driver side of things, but > primarily with adding more complexity to the libc++ build. Shouldn't we be > driving things from the runtimes build

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2110 + static const char *const X32Triples[] = {"x86_64-linux-gnux32", + "x86_64-unknown-linux-gnux32", +

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2662440 , @hvdijk wrote: > In D52050#2662372 , @MaskRay wrote: > >> Mostly looks good. >> >>>

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334550. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, johnrusso, rbar, asb. Repository: rG LLVM Github Monorepo

[PATCH] D99689: [OPENMP]Add option -fopenmp-cuda-const-firstprivate to control address space of the corresponding global.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: jansvoboda11, dexonsmith, dang, guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Added options

[PATCH] D99688: [CUDA][HIP] rename -fcuda-flush-denormals-to-zero

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: jansvoboda11, dang, kerbowa, nhaehnle, jvesely. yaxunl requested review of this revision. Rename it to -fgpu-flush-denormals-to-zero https://reviews.llvm.org/D99688 Files:

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.h:30 +return LangOpts.CPlusPlus; + }; + Semicolon is not needed and should cause `-Wextra-semi` warnings. Repository: rG LLVM Github

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2662372 , @MaskRay wrote: > Mostly looks good. > >> `clang/test/Driver/Inputs/basic_cross_linux_tree/usr/lib/gcc/x86_64-unknown-linux-gnu/4.6.0/x32/crtbegin.o` > > Worth bumping the version. 4.6 is quite old and as a host

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I'm personally not so concerned with the Clang driver side of things, but primarily with adding more complexity to the libc++ build. Shouldn't we be driving things from the

[PATCH] D99037: [Matrix] Implement explicit type conversions for matrix types

fhahn added a comment. In D99037#2659477 , @SaurabhJha wrote: >> What code do you want to get out of this? Are there e.g. vectorized >> float->double conversions we can use, or is the operation basically doomed >> to break the matrix apart and put it

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann updated this revision to Diff 334527. mgartmann marked 4 inline comments as done. mgartmann added a comment. Refactored the code and documentation files according to the feedback received on the first diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

Eugene.Zelenko added a comment. It looks like new patch was not uploaded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 ___ cfe-commits mailing list

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

MaskRay added a comment. Mostly looks good. > `clang/test/Driver/Inputs/basic_cross_linux_tree/usr/lib/gcc/x86_64-unknown-linux-gnu/4.6.0/x32/crtbegin.o` Worth bumping the version. 4.6 is quite old and as a host compiler llvm-project has stopped supporting it. The distributions having 4.6 are

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2661296 , @LuoYuanke wrote: >> Unfortunately this is not possible to use an opaque type with the AMX >> intrinsics at the moment, because of the way they are define. It is possible >> to use opaque types with intrinsics

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

mgartmann marked 10 inline comments as done. mgartmann added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} riccibruno wrote: > Will this match

[PATCH] D94355: [Passes] Add relative lookup table converter pass

aeubanks added inline comments. Comment at: llvm/test/Other/opt-O3-pipeline-enable-matrix.ll:322-323 ; CHECK-NEXT: Simplify the CFG +; CHECK-NEXT: Relative Lookup Table Converter +; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT: Annotation Remarks

[PATCH] D99683: [HIP] Support ThinLTO

yaxunl created this revision. yaxunl added reviewers: tra, ashi1, scchan. Herald added subscribers: jansvoboda11, dang, hiraditya, inglorion. yaxunl requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. https://reviews.llvm.org/D99683 Files:

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added inline comments. Comment at: clang/docs/SYCLSupport.md:73 +the integration header is used (included) by the SYCL runtime implementation, so +the header must be available before the host compilation starts.* + bader wrote: > Naghasan wrote: > > >

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 334523. Max_S marked 7 inline comments as done. Max_S added a comment. Addressed last minor remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 Files:

[PATCH] D99190: WIP: [SYCL] Add design document for SYCL mode

keryell added a comment. In D99190#2659571 , @tschuett wrote: > The OMPIRBuilder is the modern version of late outlining: > https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h > You may consider to go that way

[PATCH] D94355: [Passes] Add relative lookup table converter pass

rnk added subscribers: aeubanks, rnk. rnk added inline comments. Comment at: llvm/test/Other/opt-O3-pipeline-enable-matrix.ll:322-323 ; CHECK-NEXT: Simplify the CFG +; CHECK-NEXT: Relative Lookup Table Converter +; CHECK-NEXT: FunctionPass Manager ; CHECK-NEXT:

[PATCH] D99521: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa28e835e9494: [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a28e835 - [OPENMP]Fix PR48885: Crash in passing firstprivate args to tasks on Apple M1.

Author: Alexey Bataev Date: 2021-03-31T13:00:58-07:00 New Revision: a28e835e9494af058bcbad667906271eec5da83b URL: https://github.com/llvm/llvm-project/commit/a28e835e9494af058bcbad667906271eec5da83b DIFF: https://github.com/llvm/llvm-project/commit/a28e835e9494af058bcbad667906271eec5da83b.diff

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino added a comment. In D99433#2662259 , @fhahn wrote: > In D99433#2661919 , > @everton.constantino wrote: > >> @fhahn Ok I see what you mean now, this sounds like a doable path and might >> be

[PATCH] D99681: [OpenMP] Pass mapping names to add components in a user defined mapper

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Currently the mapping names are not passed to the mapper

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

fhahn added a comment. In D99433#2661919 , @everton.constantino wrote: > @fhahn Ok I see what you mean now, this sounds like a doable path and might > be able to cover architectures with specialized matrix multiplication > instructions as well . > >

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

MaskRay added a comment. In D89013#2662167 , @phosek wrote: > In D89013#2660407 , @MaskRay wrote: > >> Regarding >> >> /usr/include/x86_64-unknown-linux-gnu/c++/v1 >> /usr/include/c++/v1 >> >> With GCC

[PATCH] D99611: [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints used.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66da4f6fc9c1: [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints… (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 66da4f6 - [OPENMP]Fix PR48658: [OpenMP 5.0] Compiler crash when OpenMP atomic sync hints used.

Author: Alexey Bataev Date: 2021-03-31T12:58:24-07:00 New Revision: 66da4f6fc9c1cd2a63f089b9888729292f0709f8 URL: https://github.com/llvm/llvm-project/commit/66da4f6fc9c1cd2a63f089b9888729292f0709f8 DIFF: https://github.com/llvm/llvm-project/commit/66da4f6fc9c1cd2a63f089b9888729292f0709f8.diff

[PATCH] D99679: [OPENMP51]Initial support for novariants clause

jyu2 created this revision. jyu2 added reviewers: mikerice, ABataev, jdoerfert. jyu2 added projects: LLVM, clang. Herald added subscribers: arphaman, guansong, yaxunl. Herald added a reviewer: sscalpone. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Added basic

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#2660407 , @MaskRay wrote: > Regarding > > /usr/include/x86_64-unknown-linux-gnu/c++/v1 > /usr/include/c++/v1 > > With GCC multiarch, some `include` search paths are preceded by > machine-os-env specific suffix

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek updated this revision to Diff 334506. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/fuchsia.cpp

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk updated this revision to Diff 334505. hvdijk retitled this revision from "WIP: [Driver] Fix architecture triplets and search paths for Linux x32" to "[Driver] Fix architecture triplets and search paths for Linux x32". hvdijk added a comment. Tests now updated differently, avoiding the

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, pengfei, kbsmith1. Herald added subscribers: dexonsmith, jfb, hiraditya. mibintc requested review of this revision. Herald added a subscriber: jdoerfert. Herald added a project: LLVM. This is a proposal to add a new llvm

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:203 +SmallVector Ret; +const auto = [](QualType QT) { + if (QT.isNull()) Comment at:

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp:110-147 +// Test target codegen - host bc file has to be created first. +// RUN: %clang_cc1 -DCK2 -verify -fopenmp -fopenmp-version=45 -fopenmp-cuda-mode -x c++ -triple

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen added inline comments. Comment at: clang/test/OpenMP/nvptx_target_parallel_proc_bind_codegen.cpp:110-147 +// Test target codegen - host bc file has to be created first. +// RUN: %clang_cc1 -DCK2 -verify -fopenmp -fopenmp-version=45 -fopenmp-cuda-mode -x c++ -triple

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcf680050686: [Driver] Move detectLibcxxIncludePath to ToolChain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/

[clang] fcf6800 - [Driver] Move detectLibcxxIncludePath to ToolChain

Author: Petr Hosek Date: 2021-03-31T10:50:44-07:00 New Revision: fcf6800506862586e2d409aaa03a1cff818edfcc URL: https://github.com/llvm/llvm-project/commit/fcf6800506862586e2d409aaa03a1cff818edfcc DIFF: https://github.com/llvm/llvm-project/commit/fcf6800506862586e2d409aaa03a1cff818edfcc.diff

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:1097 + // ignored values) that we don't warn on it. + if (Name.size() <= 1) +return ReservedIdentifierStatus::NotReserved; serge-sans-paille wrote: > rsmith wrote: > > Would it make sense to

[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45783d0e8a36: [WebAssembly] Implement i64x2 comparisons (authored by tlively). Changed prior to commit:

[clang] 45783d0 - [WebAssembly] Implement i64x2 comparisons

Author: Thomas Lively Date: 2021-03-31T10:46:17-07:00 New Revision: 45783d0e8a3632b7c1f5b0cdd258bfba1f8583e7 URL: https://github.com/llvm/llvm-project/commit/45783d0e8a3632b7c1f5b0cdd258bfba1f8583e7 DIFF: https://github.com/llvm/llvm-project/commit/45783d0e8a3632b7c1f5b0cdd258bfba1f8583e7.diff

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

ABataev added inline comments. Comment at: clang/test/OpenMP/distribute_parallel_for_proc_bind_codegen.cpp:108-135 +#ifdef CK2 + +typedef __INTPTR_TYPE__ intptr_t; + +// CK2-DAG: [[IDENT_T_TY:%.+]] = type { i32, i32, i32, i32, i8* } +// CK2-DAG: [[STR:@.+]] = private

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-select.ll:313 ; CHECK-NEXT:# fallthrough-return <2 x i64> %x, <2 x i64> %y) { %c = icmp slt <2 x i64> %a, %b tlively wrote: > dschuff

[PATCH] D99622: [OpenMP51] Accept `primary` as proc bind affinity policy in Clang

cchen updated this revision to Diff 334482. cchen added a comment. Add some codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99622/new/ https://reviews.llvm.org/D99622 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D99433: [Matrix] Including __builtin_matrix_multiply_add for the matrix type extension.

everton.constantino added a comment. @fhahn Ok I see what you mean now, this sounds like a doable path and might be able to cover architectures with specialized matrix multiplication instructions as well . Just to see if I understand correctly I can add a matrix_add intrinsic, do a travesal

[PATCH] D99623: [WebAssembly] Implement i64x2 comparisons

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:218 -TARGET_BUILTIN(__builtin_wasm_eq_i64x2, "V2LLiV2LLiV2LLi", "nc", "simd128") - dschuff wrote: > Is the builtin/intrinsic wrong now? Or just not necessary because

[PATCH] D99659: [analyzer][taint] Extent of heap regions should get taint sometimes

steakhal updated this revision to Diff 334474. steakhal added a comment. Add a FIXME about placing a NoteTag describing why the extent was getting tainted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99659/new/ https://reviews.llvm.org/D99659

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2661646 , @OikawaKirie wrote: > Can we automatically enable all test cases requiring z3 if clang is built > with z3? I do not think the patch D83677 > really make the problem fixed.

[PATCH] D99658: [analyzer] Fix clang_analyzer_getExtent for heap regions

steakhal updated this revision to Diff 334470. steakhal marked 3 inline comments as done. steakhal added a comment. This revision is now accepted and ready to land. Fix comments. I could not manage to create an `unknown` extent, where the behavior would diverge. Repository: rG LLVM Github

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99668: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, HsiangKai, evandro, liaolucy, jrtc27. Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D99456: [C++2b] Support size_t literals

Quuxplusone added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594 + // C++2b features. + if (LangOpts.CPlusPlus2b) +Builder.defineMacro("__cpp_size_t_suffix", "202011L"); if (LangOpts.Char8) AntonBikineev wrote: >

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

compnerd added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:127 + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}${LLVM_LIBDIR_SUFFIX} + RUNTIME DESTINATION

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

ldionne added a subscriber: phosek. ldionne added a comment. I am generally OK with the libcxx and libcxxabi changes. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:389 get_compiler_rt_target(${arch} target) -set(${install_dir}

[PATCH] D99320: [RISCV] [1/2] Add intrinsic for Zbb extension

craig.topper added a comment. In D99320#2661285 , @asb wrote: > Can I just check the reasoning on the naming? I see that the bitmanip 0.93 > spec proposes `_{rv,rv32,rv64}_{opname}` intrinsics. Does the > `__builtin__{riscv,riscv32,riscv64}_opname`

[PATCH] D99577: [RFC][OpenCL][PoC] Testing TableGen with diffing

Anastasia added a comment. This approach is really great because the testing is so quick! While it is not providing the coverage for invocation through clang, it can still be very valuable in various forms to enhance the testing and improve the coverage at very little cost. Thanks for working

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

njames93 added a comment. Is it not wise to also check the c standard library. So check for function refs to these names in the global or std namespace. `printf`, `vprintf`, `puts`, `putchar`, `scanf`, `scanf`, `getchar` and `gets` It may be a bit of a pain checking for usages of `stdin` and

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

OikawaKirie added a comment. In D83660#2661369 , @martong wrote: >> BTW, I was obstructed by the z3 requirement in the regression test case when >> I tried to understand your test case. Even though I set the variables >> LLVM_Z3_INSTALL_DIR and

[PATCH] D99663: [clang-cl] [Sema] Do not prefer integral conversion over floating-to-integral for MS compatibility 19.28 and higher.

curdeius created this revision. curdeius added reviewers: mstorsjo, thakis, phosek. Herald added a subscriber: dexonsmith. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As of MSVC 19.28 (2019 Update 8), integral conversion is no

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:1097 + // ignored values) that we don't warn on it. + if (Name.size() <= 1) +return ReservedIdentifierStatus::NotReserved; rsmith wrote: > Would it make sense to move the rest of

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 334445. serge-sans-paille added a comment. Herald added a subscriber: dexonsmith. Another round of review :-) I addressed both the scattering of `warnOnReservedIdentifier` and the code split between `Decl.cpp` and `IdentifierInfo.cpp`. CHANGES

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

steakhal added a comment. In D83660#2661369 , @martong wrote: > I went through the change and it looks good, seems like this is indeed a copy > paste error from line 132. > I checked the related conversation, and thanks for all the effort spent with >

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM, but please clean up the comments before landing. Comment at: clang/docs/ClangFormatStyleOptions.rst:2132 +**EmptyLineAfterAccessModifier**

  1   2   >