[PATCH] D102465: [Coroutines] Mark every parameter

lxfind created this revision. Herald added subscribers: ChuanqiXu, hoy, modimo, wenlei, hiraditya. lxfind requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo

[PATCH] D102459: [clang][ObjC] Allow different availability annotation on a method when implementing an optional protocol requirement

arphaman created this revision. arphaman added a reviewer: erik.pilkington. Herald added subscribers: ributzka, jfb. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. When an Objective-C method implements an optional protocol requirement, allow the method to use

[PATCH] D102338: [Sema] Always search the full function scope context if a potential availability violation is encountered

arphaman added a comment. Thanks for the patch! I think the new checking semantics behavior provided by this patch are fine and match what the Swift compiler allows in the `if #available` blocks in Swift. I will do some additional testing tomorrow but I'm hoping I can approve your patch in the

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

rnk added subscribers: vsk, rnk. rnk added inline comments. Herald added a subscriber: jeroen.dobbelaere. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5155 +#define BUILTIN(ID, TYPE, ATTRS) case RISCV::BI##ID: +#include "clang/Basic/BuiltinsRISCV.def" +#undef BUILTIN

[clang] d2f4b7d - Use enum comparison instead of generated switch/case, NFC

Author: Reid Kleckner Date: 2021-05-13T20:26:50-07:00 New Revision: d2f4b7d77828dba831f4b7429a7c970d71eb853b URL: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b DIFF: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b.diff

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); efriedma wrote: > Redefining `__INT16_TYPE__` like this is unusual.

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:69 + // default. + static bool supportsRelativeCXXVTables(const llvm::Triple ) { +return T.isOSFuchsia(); I think that `supports` here is a bit misleading, I'd expect the

[PATCH] D101139: Create install targets for scan-build-py.

aabbaabb updated this revision to Diff 345329. aabbaabb added a comment. put libs in 'lib' folder, 'analyze-*' and 'scan-*' compiler wrappers to 'libexec', also copy the resources in 'libscanbuild' Tests: To install: DESTDIR=${INSTALL_DIR} ninja install-scan-build-py -j1000 Test at source

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) {

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

morehouse updated this revision to Diff 345317. morehouse marked an inline comment as done. morehouse added a comment. - s/ENABLE_ALIASES/HWASAN_ENABLE_ALIASES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102288/new/

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

MaskRay added a comment. In D102090#2758316 , @xbolva00 wrote: >>> I cannot figure out how to make -fno-semantic-interposition specific to >>> llvm/ and clang/. > > Maybe @nikic knows? I think he is interested in this work, since the base > (reverted)

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Comment at: compiler-rt/test/hwasan/lit.site.cfg.py.in:10 +# Whether to use -mlam or not. +config.enable_aliases = lit_config.params.get("ENABLE_ALIASES",

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

hoy added a comment. In D102356#2758179 , @dblaikie wrote: > This was previously crashing, I guess? Testing should validate the behavior > beyond the crash, though - (presumably there's some more specific behavior > than "does not crash" that wasn't

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

xbolva00 added subscribers: nikic, xbolva00. xbolva00 added a comment. >> I cannot figure out how to make -fno-semantic-interposition specific to >> llvm/ and clang/. Maybe @nikic knows? I think he is interested in this work, since the base (reverted) commit introduced 4% compile time

[PATCH] D102185: Widen `name` stencil to support `TypeLoc` nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5c7c5d8230: Widen `name` stencil to support `TypeLoc` nodes. (authored by SilensAngelusNex, committed by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] be5c7c5 - Widen `name` stencil to support `TypeLoc` nodes.

Author: Weston Carvalho Date: 2021-05-13T23:23:12+01:00 New Revision: be5c7c5d8230428f024bd656beb48ef8462985ff URL: https://github.com/llvm/llvm-project/commit/be5c7c5d8230428f024bd656beb48ef8462985ff DIFF:

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83ff0ff46337: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 83ff0ff - [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

Author: Michael Kruse Date: 2021-05-13T17:15:34-05:00 New Revision: 83ff0ff46337422171fb36f934bd56c2bc1be15c URL: https://github.com/llvm/llvm-project/commit/83ff0ff46337422171fb36f934bd56c2bc1be15c DIFF: https://github.com/llvm/llvm-project/commit/83ff0ff46337422171fb36f934bd56c2bc1be15c.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2758189 , @lhames wrote: > Ok, looks like the JIT is getting the layout right, but clang-repl is > constructing a module with an little-endian layout for some reason. `clang-repl` is generating a module

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan added a comment. Ready for reviews. Let me know if I should add other reviewers for the flag/option processing. This shouldn't impact how the experimental flag is used. It's just processing it that's different. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88220: [C++20] P1825R0: More implicit moves

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) {

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan updated this revision to Diff 345293. leonardchan added a comment. Change the tablegen definition of `-f[no-]experimental-relative-c++-abi-vtables` from a BoolFOption to two separate flags so we can control the default value of the `RelativeCXXABIVTables` LangOption more

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

morehouse updated this revision to Diff 345295. morehouse marked an inline comment as done. morehouse added a comment. - Rename flag to -fsanitize-hwaddress-experimental-aliasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102288/new/

[PATCH] D102288: [HWASan] Add aliasing flag and enable HWASan to use it.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1551 +def fexperimental_sanitize_hwaddress_aliasing + : Flag<["-"], "fexperimental-sanitize-hwaddress-aliasing">, +Group, Please switch to

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

lhames added a comment. In D96033#2757930 , @hubert.reinterpretcast wrote: > ... > Command Output (stderr): > > triple: powerpc64-ibm-aix7.2.0.0 > datalayout: E-m:a-i64:64-n32:64-S128-v256:256:256-v512:512:512 > error: Added modules have incompatible

[clang] 71a0609 - [clang-repl] Temporarily disable the execute.cpp test on ppc64.

Author: Lang Hames Date: 2021-05-13T14:39:12-07:00 New Revision: 71a0609a2b533dbcd6826ad774b6bee5e9818644 URL: https://github.com/llvm/llvm-project/commit/71a0609a2b533dbcd6826ad774b6bee5e9818644 DIFF: https://github.com/llvm/llvm-project/commit/71a0609a2b533dbcd6826ad774b6bee5e9818644.diff

[PATCH] D102356: [UniqueLinkageName] Use exsiting GlobalDecl object instead of reconstructing one.

dblaikie added a comment. This was previously crashing, I guess? Testing should validate the behavior beyond the crash, though - (presumably there's some more specific behavior than "does not crash" that wasn't being tested for before - that certain names are mangled appropriately or

[PATCH] D102306: Add gfx1034

JonChesterfield added a comment. Is there documentation for the mapping from product names to gfx numbers? It's possible to work it out from roct's topology.cpp and the pci.ids table, but hopefully there's a table we could point users to as well. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

quinnp created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. quinnp requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Most of the builtins already had intrinsics and only needed to be

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse added inline comments. Comment at: clang/include/clang/Driver/Options.td:4172 +// on x86_64 and is subject to change in the future. For example, we may want +// to distinguish between LAM48 and LAM57 at some point. +def mlam : Flag<["-"], "mlam">, Group;

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse updated this revision to Diff 345284. morehouse added a comment. - Remove diffbase. - Use -fexperimental-sanitize-hwaddress-aliasing instead of -mlam. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102288/new/

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

morehouse updated this revision to Diff 345282. morehouse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Rebase onto D102288 . - Refactor to make LAM the default runtime. - Use alias runtime if specified. Repository:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) {

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc updated this revision to Diff 345273. mibintc added a comment. Corrected the failing lit test and applied the clang-format patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101640/new/ https://reviews.llvm.org/D101640 Files:

[PATCH] D100701: [clang][AVR] Redefine some types to be compatible with avr-gcc

efriedma added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:313 + Builder.defineMacro("__UINT16_TYPE__", "unsigned int"); + Builder.defineMacro("__INT16_TYPE__", "int"); Redefining `__INT16_TYPE__` like this is unusual. The macro is normally

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f05f4c8e66b: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions (authored by MaskRay). Changed prior to commit:

[clang] 4f05f4c - [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

Author: Fangrui Song Date: 2021-05-13T13:44:57-07:00 New Revision: 4f05f4c8e66bc76b1d94f5283494404382e3bacd URL: https://github.com/llvm/llvm-project/commit/4f05f4c8e66bc76b1d94f5283494404382e3bacd DIFF: https://github.com/llvm/llvm-project/commit/4f05f4c8e66bc76b1d94f5283494404382e3bacd.diff

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

hoy added a comment. In D98799#2757959 , @dblaikie wrote: >> I took another look. I think the divergence comes from >> getAs vs hasPrototype. The debug data generation uses >> hasPrototype while getAs is used as overloadable >> attribute processing as

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

MaskRay updated this revision to Diff 345268. MaskRay edited the summary of this revision. MaskRay added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102090/new/ https://reviews.llvm.org/D102090 Files:

[PATCH] D88220: [C++20] P1825R0: More implicit moves

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3226-3227 +CopyElisionSemanticsKind CESK = CES_Strict; +if (getLangOpts().CPlusPlus20) { + CESK = CES_ImplicitlyMovableCXX20; +} else if (getLangOpts().CPlusPlus11) { P1825

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. > I took another look. I think the divergence comes from > getAs vs hasPrototype. The debug data generation uses > hasPrototype while getAs is used as overloadable attribute > processing as long as unique linkage name processing before this change. More >

[PATCH] D102090: [CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions

MaskRay updated this revision to Diff 345264. MaskRay retitled this revision from "[CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions" to "[CMake][ELF] Link libLLVM.so and libclang-cpp.so with -Bsymbolic-functions". MaskRay edited the summary of this revision. MaskRay added a

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. I'll go simple - just drop -fno-semantic-interposition from this patch, as I cannot figure out how to make -fno-semantic-interposition specific to llvm/ and clang/. -Bsymbolic-functions

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757342 , @lhames wrote: > Hi Hubert, > > Could you apply the following patch and let me know the output from the > failing test? I'm trying to work out whether the JIT is getting the triple or > the

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

aaron.ballman added a reviewer: rsmith. aaron.ballman added a comment. In D101640#2757815 , @mibintc wrote: > In D101640#2757316 , @aaron.ballman > wrote: > >> In D101640#2757178

[PATCH] D99160: [X86][FastISEL] Support DW_TAG_call_site_parameter with FastISEL

dblaikie added a comment. ~5% object size growth (probably more heavily weighted towards object size when using Split DWARF (most of the growth is likely in the .debug_addr/rela.debug_addr in the .o file, rather than in the DIEs in the .dwo file)) seems like enough that I wouldn't really be

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { bjope wrote: >

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. https://reviews.llvm.org/D102433 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101640: [clang][patch] Add support for option -fextend-arguments={32,64}: widen integer arguments to int64 in unprototyped function calls

mibintc added a comment. In D101640#2757316 , @aaron.ballman wrote: > In D101640#2757178 , @mibintc wrote: > >> In D101640#2757039 , >> @aaron.ballman wrote: >> >>>

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Okay. This is a known issue https://bugs.llvm.org/show_bug.cgi?id=39439. I'll upload a new patch which includes`-verify-machineinstrs=0` as a temporary workaround. (See the sjlj-eh.ll test) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Something unrelated might be wrong with the test because I can reproduce the MachineVerifier issue (liveins + non-entry/landingpad) on llvm-stable (11.1) and even without the inline-asm call (replaced by a normal invoke to the target). Repository: rG LLVM Github

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

eugenis added inline comments. Comment at: clang/include/clang/Driver/Options.td:4172 +// on x86_64 and is subject to change in the future. For example, we may want +// to distinguish between LAM48 and LAM57 at some point. +def mlam : Flag<["-"], "mlam">, Group;

[PATCH] D102431: [clangd][QueryDriver] Dont check for existence of driver

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Execute implementations already

[PATCH] D102427: [HIP] Clean up llvm intrinsics using __asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa249ffa42137: [HIP] Clean up llvm intrinsics using __asm (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[clang] a249ffa - [HIP] Clean up llvm intrinsics using __asm

Author: Aaron En Ye Shi Date: 2021-05-13T18:55:51Z New Revision: a249ffa42137431d44d7db1d04f122300bc51533 URL: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533 DIFF: https://github.com/llvm/llvm-project/commit/a249ffa42137431d44d7db1d04f122300bc51533.diff

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Hmm, there is build-failure when buildbot is running extended tests (MachineVerifier): https://lab.llvm.org/buildbot/#/builders/16/builds/10825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

asmith accepted this revision. asmith added a comment. Thanks everyone for the great feedback! We'll move forward with landing this first patch and start the review of the next one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/

[PATCH] D102306: Add gfx1034

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG464e4dc50f4e: [AMDGPU] Add gfx1034 target (authored by aakanksha555). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits.

[clang] 464e4dc - [AMDGPU] Add gfx1034 target

Author: Aakanksha Patil Date: 2021-05-13T14:25:18-04:00 New Revision: 464e4dc50f4e6e058e12a7020385d5bf29fd1df6 URL: https://github.com/llvm/llvm-project/commit/464e4dc50f4e6e058e12a7020385d5bf29fd1df6 DIFF:

[PATCH] D102294: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages in condition.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ad2eeeadaf1: [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages. (authored by dergachev.a). Changed prior to commit:

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46c6c08c9428: [clang-tidy] bugprone-infinite-loop: forFunction() - forCallable(). (authored by dergachev.a). Repository: rG LLVM Github Monorepo

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a079dfdc992: [ASTMatchers] Add forCallable(), a generalization of forFunction(). (authored by dergachev.a). Herald added a project: clang.

[clang-tools-extra] 5ad2eee - [clang-tidy] bugprone-infinite-loop: React to ObjC ivars and messages.

Author: Artem Dergachev Date: 2021-05-13T11:25:02-07:00 New Revision: 5ad2eeeadaf15856332f66ed7c244d52a86b0be7 URL: https://github.com/llvm/llvm-project/commit/5ad2eeeadaf15856332f66ed7c244d52a86b0be7 DIFF:

[clang-tools-extra] 46c6c08 - [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

Author: Artem Dergachev Date: 2021-05-13T11:25:01-07:00 New Revision: 46c6c08c9428a36bdf88f51b1a14164aa4cbb93e URL: https://github.com/llvm/llvm-project/commit/46c6c08c9428a36bdf88f51b1a14164aa4cbb93e DIFF:

[PATCH] D102303: [ASTMatchers] Fix formatting around forFunction().

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd98ea528c0c: [ASTMatchers] NFC: Fix formatting around forFunction(). (authored by dergachev.a). Herald added a project: clang. Repository: rG

[clang] 6a079df - [ASTMatchers] Add forCallable(), a generalization of forFunction().

Author: Artem Dergachev Date: 2021-05-13T11:25:00-07:00 New Revision: 6a079dfdc992706408f2bde84c48bf76e52c4311 URL: https://github.com/llvm/llvm-project/commit/6a079dfdc992706408f2bde84c48bf76e52c4311 DIFF:

[clang] dd98ea5 - [ASTMatchers] NFC: Fix formatting around forFunction().

Author: Artem Dergachev Date: 2021-05-13T11:25:00-07:00 New Revision: dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d URL: https://github.com/llvm/llvm-project/commit/dd98ea528c0c23f5fee6d3dbafc261b81cca9f0d DIFF:

[clang] 0d8f91d - [NFC] Delete two newly-added test cases

Author: Roman Lebedev Date: 2021-05-13T21:23:01+03:00 New Revision: 0d8f91d2a9994619bb62c548a81eb605f0e768f7 URL: https://github.com/llvm/llvm-project/commit/0d8f91d2a9994619bb62c548a81eb605f0e768f7 DIFF: https://github.com/llvm/llvm-project/commit/0d8f91d2a9994619bb62c548a81eb605f0e768f7.diff

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. @Amanieu Thanks for the review and commit! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list

[PATCH] D102306: Add gfx1034

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 ___ cfe-commits mailing list

[clang] ecc4e9e - [NFC] Try to fix CodeGenCXX/thunk-wrong-return-type.cpp test

Author: Roman Lebedev Date: 2021-05-13T21:17:31+03:00 New Revision: ecc4e9e8f4cb7581cbc447bc838943176715695c URL: https://github.com/llvm/llvm-project/commit/ecc4e9e8f4cb7581cbc447bc838943176715695c DIFF: https://github.com/llvm/llvm-project/commit/ecc4e9e8f4cb7581cbc447bc838943176715695c.diff

[PATCH] D95745: Support unwinding from inline assembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec9fd483949: Support unwinding from inline assembly (authored by cynecx, committed by Amanieu). Repository: rG LLVM Github Monorepo CHANGES

[clang] 8ec9fd4 - Support unwinding from inline assembly

Author: cynecx Date: 2021-05-13T19:13:03+01:00 New Revision: 8ec9fd483949ca3b23053effcac226dcc56e7a95 URL: https://github.com/llvm/llvm-project/commit/8ec9fd483949ca3b23053effcac226dcc56e7a95 DIFF: https://github.com/llvm/llvm-project/commit/8ec9fd483949ca3b23053effcac226dcc56e7a95.diff LOG:

[clang] 9d3eb78 - [NFC] Try to fix CodeGenCXX/thunk-wrong-this.cpp test

Author: Roman Lebedev Date: 2021-05-13T21:10:14+03:00 New Revision: 9d3eb7885d916b22bc673334f71a10e3b2835174 URL: https://github.com/llvm/llvm-project/commit/9d3eb7885d916b22bc673334f71a10e3b2835174 DIFF: https://github.com/llvm/llvm-project/commit/9d3eb7885d916b22bc673334f71a10e3b2835174.diff

[PATCH] D102306: Add gfx1034

aakanksha555 updated this revision to Diff 345226. Herald added a subscriber: emaste. Herald added a reviewer: MaskRay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

leonardchan added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293 +static bool SupportsRelativeCXXVTables(const llvm::Triple ) { + return T.isOSFuchsia(); +} phosek wrote: > Could we instead enable it inside `FuchsiaCXXABI`? So we

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2757342 , @lhames wrote: > Hi Hubert, > > Could you apply the following patch and let me know the output from the > failing test? I'm trying to work out whether the JIT is getting the triple or > the

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Finally dealt with the other issues I need to take care. Let's resume the discussion. I printed out the decls that are duplicated. The list of very long, but the top ones all seem from glibc headers. For example (the number after 'c:' is the duplication count),

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345221. NoQ added a comment. Fix typo in documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345220. NoQ added a comment. Make examples for `forCallable()` more relatable given that the original matcher is now deprecated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files:

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. I would be great if someone with commit rights could push this through since I don't have commit rights :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

NoQ added a comment. Thx for the fix! In D102240#2757223 , @steakhal wrote: > In D102240#2756967 , @vsavchenko > wrote: > >> I couldn't transform `c == b` into a condition, so it crashes. > > Well, that's

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA added inline comments. Comment at: clang/test/Parser/altivec-non-type-vector.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-aix-xcoff -target-feature +altivec -fsyntax-only %s + Can you add tests for 64bit BE/LE linux and 32bit AIX/BE linux in this

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102214: [clang-tidy] bugprone-infinite-loop: forFunction() -> forCallable().

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Now, when we are done with `forCallable`, let's get to this one. It looks great to me, thanks for fixing it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D101672: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c57a9bd7d4c: Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC (authored by dexonsmith). Repository: rG LLVM Github

[clang] 7c57a9b - Modules: Simplify how DisableGeneratingGlobalModuleIndex is set, likely NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:39:40-07:00 New Revision: 7c57a9bd7d4c976b7a824472c427433359200e02 URL: https://github.com/llvm/llvm-project/commit/7c57a9bd7d4c976b7a824472c427433359200e02 DIFF:

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri abandoned this revision. lebedev.ri added a comment. Oh, i forgot that this review was here. I've just relanded this in rG16d03818412415c56efcd482d18c0cbdf712524c , after workarounding the thunk issue in

[PATCH] D102288: [HWASan] Add -fsanitize=lam flag and enable HWASan to use it.

morehouse updated this revision to Diff 345210. morehouse marked 4 inline comments as done. morehouse added a comment. Herald added a subscriber: dang. - Use -mlam option instead of -fsanitize=lam. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a624cec - [Clang][Codegen] Do not annotate thunk's this/return types with align/deref/nonnull attrs

Author: Roman Lebedev Date: 2021-05-13T20:33:08+03:00 New Revision: a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 URL: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4 DIFF: https://github.com/llvm/llvm-project/commit/a624cec56d4bf61c1f3cb7daf2d27dac59c56fa4.diff

[clang] 70aa462 - [NFC][Clang][Codegen] Add tests with wrong attributes on this/return of thunks

Author: Roman Lebedev Date: 2021-05-13T20:32:40+03:00 New Revision: 70aa4623de9fe2f609eab8969d7ef76b4c80084b URL: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b DIFF: https://github.com/llvm/llvm-project/commit/70aa4623de9fe2f609eab8969d7ef76b4c80084b.diff

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. OK, I agree with Aaron that having a separate matcher is reasonable. Thanks for the patient explanation :) LGTM from my side then. CHANGES SINCE LAST ACTION

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7597 +/// but does not match 'int y = 2'. +AST_MATCHER_P(Stmt, forCallable, internal::Matcher, InnerMatcher) { + const auto = Finder->getASTContext().getParents(Node);

[PATCH] D102213: [ASTMatchers] Add forCallable(), a generalization of forFunction().

NoQ updated this revision to Diff 345208. NoQ marked 2 inline comments as done. NoQ added a comment. Address review comments. Add a deprecation notice to `forFunction()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102213/new/ https://reviews.llvm.org/D102213 Files:

[PATCH] D101670: Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23e9146fba29: Modules: Rename ModuleBuildFailed = DisableGeneratingGlobalModuleIndex, NFC (authored by dexonsmith). Repository: rG LLVM Github

[clang] 23e9146 - Modules: Rename ModuleBuildFailed => DisableGeneratingGlobalModuleIndex, NFC

Author: Duncan P. N. Exon Smith Date: 2021-05-13T10:22:40-07:00 New Revision: 23e9146fba298d38142337b615e17067fb8ccb91 URL: https://github.com/llvm/llvm-project/commit/23e9146fba298d38142337b615e17067fb8ccb91 DIFF:

[clang] 45212de - [analyzer][solver] Prevent use of a null state

Author: Valeriy Savchenko Date: 2021-05-13T20:16:29+03:00 New Revision: 45212dec01b9be90596d8d6fa7586ce8c84e2622 URL: https://github.com/llvm/llvm-project/commit/45212dec01b9be90596d8d6fa7586ce8c84e2622 DIFF:

[PATCH] D102240: [analyzer][solver] Prevent use of a null state

This revision was automatically updated to reflect the committed changes. Closed by commit rG45212dec01b9: [analyzer][solver] Prevent use of a null state (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102240/new/

[PATCH] D102090: [CMake][ELF] Add -fno-semantic-interposition and -Bsymbolic-functions

MaskRay added a subscriber: marco-c. MaskRay added a comment. In D102090#2756605 , @Mordante wrote: > I tried to build the libc++ benchmarks locally and the benchmark with target > `to_chars_libcxx` fails to properly execute. Bi-section let to this

[PATCH] D101667: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c2afd5899df: Modules: Remove ModuleLoader::OtherUncachedFailure, NFC (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES

  1   2   >