[clang] 797ad70 - [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Author: Ten Tzen Date: 2021-05-17T22:42:17-07:00 New Revision: 797ad701522988e212495285dade8efac41a24d4 URL: https://github.com/llvm/llvm-project/commit/797ad701522988e212495285dade8efac41a24d4 DIFF: https://github.com/llvm/llvm-project/commit/797ad701522988e212495285dade8efac41a24d4.diff

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102654/new/ https://reviews.llvm.org/D102654

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2764946 , @hubert.reinterpretcast wrote: >> If that works on your platform I will happily open a review for the changes. > > From the behaviour observed in the 64-bit build, the 32-bit case might not >

[PATCH] D102663: Bug 49633 - Added warning for static inline global and namespaced declarations for c++17+

serberoth created this revision. serberoth added reviewers: erik.pilkington, rsmith, TH3CHARLie, fixing bugs in llvm. serberoth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Bug 49633 - Added a warning for global and namespace declared

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

clayborg added inline comments. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:92-93 +#elif defined(__APPLE__) && HAVE_CRASHREPORTER_INFO +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc ___crashreporter_info__,

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a reviewer: efriedma. benshi001 added a subscriber: efriedma. benshi001 added a comment. @efriedma Could you please help me review this patch? It relates to the one you have reviewed for me, and is also about wrong mangled function name in c++ on AVR. The previous patch has

[PATCH] D102568: [Driver] Delete -mimplicit-it=

raj.khem accepted this revision. raj.khem added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102568/new/ https://reviews.llvm.org/D102568 ___ cfe-commits mailing list

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f7d552cff8d: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal (authored by aeubanks). Repository: rG LLVM Github

[clang] 9f7d552 - [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

Author: Arthur Eubanks Date: 2021-05-17T18:41:17-07:00 New Revision: 9f7d552cff8d62250461ef396d9d4ffab4ecd378 URL: https://github.com/llvm/llvm-project/commit/9f7d552cff8d62250461ef396d9d4ffab4ecd378 DIFF:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

hubert.reinterpretcast added a comment. In D96033#2762182 , @v.g.vassilev wrote: > That patch should probably get us to a point where we can mark the test as > `XFAIL: system-aix` I've applied that patch to my 64-bit LLVM build and it does cause the

[PATCH] D102558: [Utils] Check for generated functions inline if possible

jdoerfert added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} ggeorgakoudis wrote: > The checks for the outlined function are missing? Good catch. It turns out functions that showed

[PATCH] D102558: [Utils] Check for generated functions inline if possible

jdoerfert updated this revision to Diff 346030. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. Skip duplicates in the line2spell_and_mangled_list as that causes functions to be missed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102558: [Utils] Check for generated functions inline if possible

ggeorgakoudis added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected:100 + } +} The checks for the outlined function are missing? Comment at:

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ABataev added a comment. In D101849#2764798 , @jdoerfert wrote: > In D101849#2764703 , @mikerice > wrote: > >>> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >>> -emit-llvm %s -o -

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a subscriber: ABataev. jdoerfert added a comment. In D101849#2764703 , @mikerice wrote: >> // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd >> -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 > > Is

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. This is a good catch, thank you for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102640/new/ https://reviews.llvm.org/D102640

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji marked an inline comment as done. jsji added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-line.cpp:149 -// CHECK-LABEL: define +// CHECK-LABEL: f11 __complex double f11() { dblaikie wrote: > Probably flesh that out a bit. Maybe

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji updated this revision to Diff 346011. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102654/new/ https://reviews.llvm.org/D102654 Files: clang/test/CodeGenCXX/debug-info-line.cpp Index:

[PATCH] D102531: PR45881: Properly use CXXThisOverride for templated lambda

ychen updated this revision to Diff 346010. ychen added a comment. - Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102531/new/ https://reviews.llvm.org/D102531 Files: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rGb99e2c56166a: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b99e2c5 - [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

Author: Ben Shi Date: 2021-05-18T07:06:12+08:00 New Revision: b99e2c56166a3a74ac9c49512c584d5b158ac9c6 URL: https://github.com/llvm/llvm-project/commit/b99e2c56166a3a74ac9c49512c584d5b158ac9c6 DIFF: https://github.com/llvm/llvm-project/commit/b99e2c56166a3a74ac9c49512c584d5b158ac9c6.diff LOG:

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2760639 , @yaxunl wrote: > I think the root cause might be duplicated decls are added to > Sema::DeclsToCheckForDeferredDiags defined in > >

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. > // RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -O1 -fopenmp-simd > -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK10 Is there a good reason to run this with -O1? Doing so makes it super sensitive to which llvm passes run and now this test fails for

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102638/new/ https://reviews.llvm.org/D102638

[PATCH] D100671: [ADT] Factor out in_place_t and expose in Optional ctor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5247c9347d: [ADT] Factor out in_place_t and expose in Optional ctor (authored by scott.linder). Changed prior to commit:

[clang] af5247c - [ADT] Factor out in_place_t and expose in Optional ctor

Author: Scott Linder Date: 2021-05-17T22:25:39Z New Revision: af5247c9347dcf1e30443786bdddf23ca705867a URL: https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a DIFF: https://github.com/llvm/llvm-project/commit/af5247c9347dcf1e30443786bdddf23ca705867a.diff LOG:

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-line.cpp:149 -// CHECK-LABEL: define +// CHECK-LABEL: f11 __complex double f11() { Probably flesh that out a bit. Maybe `define{{.*}}f11`? Repository: rG LLVM Github Monorepo

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

gulfem added a comment. > Looks like the same issue I fixed in https://reviews.llvm.org/rGd97bab651185. > Let me know if you have the issue after that commit. Thanks, that resolved the build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

jsji created this revision. jsji added reviewers: PowerPC, dblaikie, shchenz. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We use `CHECK-LABEL: define` to divide input stream into functions, this works well on most platforms. But

[PATCH] D102650: Old work on P0388. For reference in D102645. Not for review / commit.

rsmith created this revision. rsmith added a reviewer: urnathan. Herald added a subscriber: jfb. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102650 Files:

[PATCH] D102647: [Driver][test] Don't assume integrated-as

This revision was automatically updated to reflect the committed changes. Closed by commit rG82b52812471c: [Driver][test] Dont assume integrated-as (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102647/new/

[clang] 82b5281 - [Driver][test] Don't assume integrated-as

Author: Jinsong Ji Date: 2021-05-17T20:24:21Z New Revision: 82b52812471ca4e7228714aab15110bb740669d0 URL: https://github.com/llvm/llvm-project/commit/82b52812471ca4e7228714aab15110bb740669d0 DIFF: https://github.com/llvm/llvm-project/commit/82b52812471ca4e7228714aab15110bb740669d0.diff LOG:

[PATCH] D102015: [clang CodeGen] Don't crash on large atomic function parameter.

This revision was automatically updated to reflect the committed changes. Closed by commit rG698568b74c93: [clang CodeGen] Dont crash on large atomic function parameter. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 698568b - [clang CodeGen] Don't crash on large atomic function parameter.

Author: Eli Friedman Date: 2021-05-17T13:18:23-07:00 New Revision: 698568b74c93ab6d9374adc8bdc6e60fbcf41ff1 URL: https://github.com/llvm/llvm-project/commit/698568b74c93ab6d9374adc8bdc6e60fbcf41ff1 DIFF: https://github.com/llvm/llvm-project/commit/698568b74c93ab6d9374adc8bdc6e60fbcf41ff1.diff

[PATCH] D102647: [Driver][test] Don't assume integrated-as

jsji added a comment. In D102647#2764376 , @thakis wrote: > Are there any platforms left that don't default to integrated as? Which ones? > Is there a tracking bug for switching them? Thanks! Oh, I should have mentioned that in description, this is

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345977. hctim added a comment. Let's submit the "adding archs" part of the patch first, then land this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files:

[PATCH] D102647: [Driver][test] Don't assume integrated-as

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Are there any platforms left that don't default to integrated as? Which ones? Is there a tracking bug for switching them? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345975. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345973. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

eugenis added a comment. You are adding a new global to every translation unit. - Private linkage would not allow them to be merged, this can have significant binary size and RAM overhead. - There is no guarantee that any of these globals will end up to the left of any sanitized globals. With

[PATCH] D102647: [Driver][test] Don't assume integrated-as

jsji created this revision. jsji added reviewers: PowerPC, thakis, MaskRay, phosek, hubert.reinterpretcast. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The tests of fdebug-compilation-dir and -ffile-compilation-dir for `-x

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) -set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64})

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka updated this revision to Diff 345967. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added a comment. Would you mind to clang-format entire existing compiler-rt/test/scudo/ and than rebase this patch on top? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543

[clang] 3a0b6dc - Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable"

Author: Arthur Eubanks Date: 2021-05-17T12:16:10-07:00 New Revision: 3a0b6dc3e84bb91c0dbd721b1931e4a0ff396142 URL: https://github.com/llvm/llvm-project/commit/3a0b6dc3e84bb91c0dbd721b1931e4a0ff396142 DIFF:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

pcc added a comment. This warning seems to have a lot of false positives on things like reference arguments that are used as output parameters. For example here is a small sample of output from a stage2 build of part of LLVM: In file included from ../llvm/lib/BinaryFormat/Minidump.cpp:9:

[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

efriedma added inline comments. Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp:581 RTLIB::POWI_F128, RTLIB::POWI_PPCF128); if (!TLI.getLibcallName(LC)) { bjope wrote: >

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 345960. urnathan added a comment. rebased, trying to resolve bot failure, again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan updated this revision to Diff 345959. urnathan edited the summary of this revision. urnathan added a comment. rebased, trying to resolve patch 4's bot fail CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100276/new/ https://reviews.llvm.org/D100276 Files:

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559 + // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at +

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan updated this revision to Diff 345957. urnathan added a comment. rebased onto 3cdd05e519dd , (trying to fix patch 4's precommit failure) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

morehouse added a comment. In D102286#2764203 , @gulfem wrote: > We started seeing test failures in our Windows builds in Fuchsia after this > patch. > > FAILED: >

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. I don't plan to land this; I wrote it in case it comes up in code review. llvm's codegen will `report_fatal_error` for garbage sysregs. If it comes up again in the future, this phab review will still exist for

[PATCH] D100919: [AArch64] Support customizing stack protector guard

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f417789192e: [AArch64] Support customizing stack protector guard (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[clang] 0f41778 - [AArch64] Support customizing stack protector guard

Author: Nick Desaulniers Date: 2021-05-17T11:49:22-07:00 New Revision: 0f417789192e74f9d2fad0f6aee4efc394257176 URL: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176 DIFF:

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

gulfem added a comment. We started seeing test failures in our Windows builds in Fuchsia after this patch. FAILED: compiler-rt/lib/hwasan/CMakeFiles/RTHwasanAliases.aarch64.dir/hwasan_interceptors.cpp.o C:\b\s\w\ir\x\w\staging\llvm_build\.\bin\clang++.exe

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. Appreciate the reviews; ++beers_owed; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked 3 inline comments as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1954 + // than 23760. + // It might be nice to use AArch64::MOVi32imm here, which would get + // expanded in PreSched2

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 345949. nickdesaulniers added a comment. - braces, typo fix, add comment about additional approaches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files:

[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

steakhal created this revision. steakhal added reviewers: bkramer, martong, NoQ, Szelethus, mikhail.ramalho. Herald added subscribers: ASDenysPetrov, dkrupp, donat.nagy, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. Herald

[PATCH] D102280: [analyzer] Engine: fix crash with SEH __leave keyword

This revision was automatically updated to reflect the committed changes. Closed by commit rGebcf030efc5e: [analyzer] Engine: fix crash with SEH __leave keyword (authored by AbbasSabra, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ebcf030 - [analyzer] Engine: fix crash with SEH __leave keyword

Author: Abbas Sabra Date: 2021-05-17T20:10:26+02:00 New Revision: ebcf030efc5ef149e423f8fa2ca705b590a129ed URL: https://github.com/llvm/llvm-project/commit/ebcf030efc5ef149e423f8fa2ca705b590a129ed DIFF: https://github.com/llvm/llvm-project/commit/ebcf030efc5ef149e423f8fa2ca705b590a129ed.diff

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG14dfb3831c42: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable (authored by mbenfield, committed by

[clang] 14dfb38 - [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Author: Michael Benfield Date: 2021-05-17T11:02:26-07:00 New Revision: 14dfb3831c425c7f22540a2160424224008c257e URL: https://github.com/llvm/llvm-project/commit/14dfb3831c425c7f22540a2160424224008c257e DIFF:

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka added a comment. Would you mind to add compiler-rt/test/asan which triggers this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 ___

[PATCH] D102568: [Driver] Delete -mimplicit-it=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Seems fine to me; the only reference in all of Android that looks problematic might be building libaom for windows:

[PATCH] D102547: [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102547/new/ https://reviews.llvm.org/D102547 ___ cfe-commits mailing list

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345939. hctim added a comment. Add arm32 to supported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad accepted this revision. cryptoad added a comment. This revision is now accepted and ready to land. I think this is good, with the additional arch Comment at: compiler-rt/cmake/config-ix.cmake:338 set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 345931. leonardchan added a comment. Update to some feedback from first round of reviews. Minor refactoring of code that can be shared between the linux and fuchsia implementations. Still need to discuss refactoring the hwasan threads implementation.

[PATCH] D102640: [ASTimporter] Remove decl from lookup only if it has decl context

steakhal created this revision. steakhal added reviewers: teemperor, shafik, balazske, a.sidorin, martong. Herald added subscribers: whisperity, rnkovacs. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the case of

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

nickdesaulniers added a comment. LGTM but please review the linter warnings. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); did you mean to drop support for

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:873 + MatchVerifier Verifier; + testImport("int a[2] = {1, 2};" + "auto [declToImport, x] = a;", Can we add a larger variety of tests? Given how simple the

[PATCH] D102556: [HIP] Fix spack detection

This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG18cb17ce4cd5: [HIP] Fix spack detection (authored by yaxunl). Herald added a project: clang. Changed prior to commit:

[clang] 18cb17c - [HIP] Fix spack detection

Author: Yaxun (Sam) Liu Date: 2021-05-17T13:24:05-04:00 New Revision: 18cb17ce4cd54b9971550840b6f0b872de0d4c8c URL: https://github.com/llvm/llvm-project/commit/18cb17ce4cd54b9971550840b6f0b872de0d4c8c DIFF:

[PATCH] D101561: [Prototype] Introduce attribute for ignoring C++ ABI

aeubanks abandoned this revision. aeubanks added a comment. turns out this didn't have a good enough impact to pursue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101561/new/ https://reviews.llvm.org/D101561

[PATCH] D102488: [clang][deps] Prune unused header search paths

jansvoboda11 updated this revision to Diff 345922. jansvoboda11 added a comment. Make PCM parsing lazier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102488/new/ https://reviews.llvm.org/D102488 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D102638: [NFC] Pass GV value type instead of pointer type to GetOrCreateLLVMGlobal

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For opaque pointers, to avoid PointerType::getElementType(). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102638 Files:

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 updated this revision to Diff 345917. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf226e28a880f: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync… (authored by steffenlarsen, committed by tra). Changed prior to commit:

[PATCH] D100394: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rG02c2468864bb: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async… (authored by nyalloc, committed by tra). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[clang] f226e28 - [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

Author: Steffen Larsen Date: 2021-05-17T09:46:59-07:00 New Revision: f226e28a880f8e40b1bfd4c77b9768a667372d22 URL: https://github.com/llvm/llvm-project/commit/f226e28a880f8e40b1bfd4c77b9768a667372d22 DIFF:

[clang] 02c2468 - [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX cp.async instructions

Author: Stuart Adams Date: 2021-05-17T09:46:59-07:00 New Revision: 02c2468864bbb37f7b279aff84961815c1500b6c URL: https://github.com/llvm/llvm-project/commit/02c2468864bbb37f7b279aff84961815c1500b6c DIFF: https://github.com/llvm/llvm-project/commit/02c2468864bbb37f7b279aff84961815c1500b6c.diff

[PATCH] D102556: [HIP] Fix spack detection

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/test/Driver/rocm-detect.hip:115 + +// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at +// SPACK-MISS-SILENT-NOT: SPACK package rocm-device-libs-4.0.0 not found at

[PATCH] D102286: [HWASan] Build separate LAM runtime on x86_64.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5f58322368b0: [HWASan] Build separate LAM runtime on x86_64. (authored by morehouse). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 5f58322 - [HWASan] Build separate LAM runtime on x86_64.

Author: Matt Morehouse Date: 2021-05-17T09:19:06-07:00 New Revision: 5f58322368b070b63fe2b2559a54f646cb97e2c4 URL: https://github.com/llvm/llvm-project/commit/5f58322368b070b63fe2b2559a54f646cb97e2c4 DIFF:

[PATCH] D102556: [HIP] Fix spack detection

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a test nit. Comment at: clang/test/Driver/rocm-detect.hip:115 + +// SPACK-MISS-SILENT-NOT: SPACK package hip-4.0.0 not found at +// SPACK-MISS-SILENT-NOT: SPACK package

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim updated this revision to Diff 345906. hctim marked 2 inline comments as done. hctim added a comment. Address Kostya's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102543/new/ https://reviews.llvm.org/D102543 Files:

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

hctim marked 2 inline comments as done. hctim added a comment. In D102543#2763749 , @cryptoad wrote: > I think one of the remaining things to address is the supported architectures: > > set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}

[PATCH] D102306: Add gfx1034

kzhuravl added a subscriber: t-tye. kzhuravl added a comment. In D102306#2760806 , @tra wrote: > In D102306#2760775 , @msearles > wrote: > >> In D102306#2758166 , >>

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

cryptoad added a comment. I think one of the remaining things to address is the supported architectures: set(ALL_SCUDO_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS32} ${MIPS64} ${PPC64}) set(ALL_SCUDO_STANDALONE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64}) I am unclear as to

[clang] e092165 - [AIX] Implement AIX special bitfield related alignment rules

Author: Xiangling Liao Date: 2021-05-17T11:30:29-04:00 New Revision: e0921655b1ff8d4ba7c14be59252fe05b705920e URL: https://github.com/llvm/llvm-project/commit/e0921655b1ff8d4ba7c14be59252fe05b705920e DIFF:

[PATCH] D87029: [AIX] Implement AIX special bitfield related alignment rules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0921655b1ff: [AIX] Implement AIX special bitfield related alignment rules (authored by Xiangling_L). Changed prior to commit:

[PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

thakis added inline comments. Herald added subscribers: llvm-commits, kristina. Herald added a project: LLVM. Comment at: llvm/trunk/lib/Support/PrettyStackTrace.cpp:93 +extern "C" const char *__crashreporter_info__ +__attribute__((visibility("hidden"))) = 0; asm(".desc

[PATCH] D102633: [clang-scan-deps] Improvements to thread usage

saudi created this revision. saudi added reviewers: arphaman, dexonsmith, Bigcheese. saudi added projects: clang, LLVM. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Switching back to `std::thread` to simplify the logic, as `ThreadPool` adds a layer of task

[PATCH] D102339: [clang] On Windows, ignore case and separators when discarding duplicate dependency file paths.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. saudi marked 2 inline comments as done. Closed by commit rG6052a8a53559: [clang] In DependencyCollector on Windows, ignore case and separators when… (authored by

[clang] 6052a8a - [clang] In DependencyCollector on Windows, ignore case and separators when discarding duplicate dependency file paths.

Author: Sylvain Audi Date: 2021-05-17T10:32:52-04:00 New Revision: 6052a8a53559d667321637f7159353ab724a1141 URL: https://github.com/llvm/llvm-project/commit/6052a8a53559d667321637f7159353ab724a1141 DIFF: https://github.com/llvm/llvm-project/commit/6052a8a53559d667321637f7159353ab724a1141.diff

[PATCH] D101192: Add support for #elifdef and #elifndef

mibintc accepted this revision. mibintc added a comment. This revision is now accepted and ready to land. let 'er rip CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102569: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with incomplete type

This revision was automatically updated to reflect the committed changes. Closed by commit rGab92a4c26f54: [clang-tidy] Fix altera-struct-pack-align crash for struct fields with… (authored by jubnzv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >