[PATCH] D105135: [Internalize] Preserve variables externally initialized.

hliao updated this revision to Diff 355764. hliao added a comment. Fix typo. Kindly PING for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105135/new/ https://reviews.llvm.org/D105135 Files:

[PATCH] D105052: [clang][darwin] add support for Mac Catalyst availability

arphaman added a comment. Thanks for the feedback, I'll update this patch tomorrow. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105052/new/ https://reviews.llvm.org/D105052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, dcoughlin. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added a comment. In D105254#2851889 , @jrtc27 wrote: > Hm, AArch64 handles ExternalSymbolSDNode too, but I don't see how you could > ever end up with one... It can't and the code path is untested. I already deleted it from aarch64.

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

junparser added inline comments. Comment at: clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c:108 +// CHECK-128-NEXT:[[CASTFIXEDSVE:%.*]] = bitcast <2 x i8>* [[SAVED_VALUE]] to * +// CHECK-128-NEXT:[[TMP1:%.*]] = load , * [[CASTFIXEDSVE]], align 16, !tbaa [[TBAA6]]

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:24 +; RV64-NEXT:ret +entry: + %0 = tail call i8* asm "lui $0, %hi($1)\0Aaddi $0,$0,%lo($1)", "=r,S"(i32* nonnull @var) MaskRay wrote: > jrtc27 wrote: > > Label

[PATCH] D104616: [analyzer] Model comparision methods of std::unique_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:443-446 + auto RetVal = C.getSValBuilder().evalBinOp( + State, BOK, FirstPtrVal, SecondPtrVal, Call.getResultType()); + State = State->BindExpr(Call.getOriginExpr(),

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:24 +; RV64-NEXT:ret +entry: + %0 = tail call i8* asm "lui $0, %hi($1)\0Aaddi $0,$0,%lo($1)", "=r,S"(i32* nonnull @var) jrtc27 wrote: > Label isn't needed Omitting

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay updated this revision to Diff 355749. MaskRay marked 6 inline comments as done. MaskRay added a comment. scrub labels/comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/D105254 Files:

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG3afbf898044a: [clang][AArch64][SVE] Handle PRValue under VLAT - VLST cast (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105097/new/

[clang] 3afbf89 - [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

Author: Jun Ma Date: 2021-07-01T10:09:47+08:00 New Revision: 3afbf898044aa5839ed75273fa38a897abe9d3d4 URL: https://github.com/llvm/llvm-project/commit/3afbf898044aa5839ed75273fa38a897abe9d3d4 DIFF: https://github.com/llvm/llvm-project/commit/3afbf898044aa5839ed75273fa38a897abe9d3d4.diff LOG:

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae5433945f91: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant. (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ae54339 - [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

Author: Jun Ma Date: 2021-07-01T10:09:47+08:00 New Revision: ae5433945f915c2f0e39f8a026166cbdc8b0469c URL: https://github.com/llvm/llvm-project/commit/ae5433945f915c2f0e39f8a026166cbdc8b0469c DIFF: https://github.com/llvm/llvm-project/commit/ae5433945f915c2f0e39f8a026166cbdc8b0469c.diff LOG:

[PATCH] D105254: [RISCV] Support machine constraint "S"

jrtc27 added a comment. Hm, AArch64 handles ExternalSymbolSDNode too, but I don't see how you could ever end up with one... Comment at: llvm/test/CodeGen/RISCV/inline-asm-S-constraint.ll:7 + +; Function Attrs: nofree nosync nounwind readnone +define dso_local i8*

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty added a comment. In D105112#2850990 , @stevewan wrote: > I'm not familiar with `getCanonicalType()`, can you confirm whether it sees > through nested typedef's? Add a test case that hopefully will cover the case you intend Repository: rG

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

daltenty updated this revision to Diff 355741. daltenty added a comment. - Update test case with nested typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112 Files:

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

lkail added a comment. The wording might be inaccurate. It's better to rephrase to 'Load and Reserve and Store Conditional'. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1724 + +let Predicates = [HasP8Altivec] in { + def : Pat<(int_ppc_stdcx xoaddr:$dst, g8rc:$A),

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook,

[clang] e95106f - Add a target triple to fix failures on MS build bots.

Author: Richard Smith Date: 2021-06-30T17:27:26-07:00 New Revision: e95106f50190d7a25dfad57adf0317ca6cfa9a4f URL: https://github.com/llvm/llvm-project/commit/e95106f50190d7a25dfad57adf0317ca6cfa9a4f DIFF: https://github.com/llvm/llvm-project/commit/e95106f50190d7a25dfad57adf0317ca6cfa9a4f.diff

[PATCH] D105127: Implement P1401R5

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to bool">; def err_static_assert_failed :

[clang-tools-extra] 5b8ddd2 - Fix test following Clang change ef227b3.

Author: Richard Smith Date: 2021-06-30T17:11:55-07:00 New Revision: 5b8ddd2ccceb8de04bd020f286bc3ca38638ecb1 URL: https://github.com/llvm/llvm-project/commit/5b8ddd2ccceb8de04bd020f286bc3ca38638ecb1 DIFF: https://github.com/llvm/llvm-project/commit/5b8ddd2ccceb8de04bd020f286bc3ca38638ecb1.diff

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

owenpan added a comment. >> Else: >> ... > > Is there anything else in the "Else:" part above? Is there an option that we > forgot? No, it's just what you called "one other enum value for the default case without special handling." > I'm not sure if I understand you correctly. Is your

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh added a comment. I reproduced the ClangdTests::TargetDeclTest.Concept failure locally without this change, using llvm git commit 0c400e8953 . Will wait for upstream fix of the failed tests. CHANGES SINCE LAST ACTION

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355720. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D104871: [Docs] use -fprofile-generate for IR PGO and -fprofile-instr-generate for code coverage

zequanwu updated this revision to Diff 355718. zequanwu marked 4 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104871/new/ https://reviews.llvm.org/D104871 Files:

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov updated this revision to Diff 355714. mizvekov added a comment. - fix test diagnostic expectation using regular expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files:

[PATCH] D105242: [clang] Don't emit uninstantiated templates with -fdump-record-layouts-complete

daltenty created this revision. daltenty added a reviewer: stevewan. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A follow on to D104484 , this blocks the emitting of some template cases where

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355706. cor3ntin added a comment. - Apply the change to all C++ version - Add more tests for static_assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files:

[PATCH] D105127: Implement P1401R5

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1299 https://wg21.link/P1401R5;>P1401R5 - No + Clang 13 rsmith wrote: > This should be class `unreleased` (yellow) for now so that people can easily > tell what's in

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

chh updated this revision to Diff 355699. chh edited the summary of this revision. chh added a comment. Move almost all changes to MatchFinder into ClangTidy.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files:

[PATCH] D105236: [PowerPC] Implament Atomic Load and Stores Builtins

Conanap created this revision. Herald added subscribers: steven.zhang, shchenz, jfb, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implaments the atomic load and store

[PATCH] D105127: Implement P1401R5

cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:3929 + + if (IsConstexpr && !LangOpts.CPlusPlus2b && !CondExpr->isValueDependent()) { +llvm::APSInt Value(/*BitWidth*/ 1); rsmith wrote: >

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355698. cor3ntin added a comment. Replace !isUsable() by isInvalid() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files:

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355697. cor3ntin added a comment. Mark the feature as unreleased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files:

[PATCH] D105127: Implement P1401R5

rsmith added inline comments. Comment at: clang/www/cxx_status.html:1299 https://wg21.link/P1401R5;>P1401R5 - No + Clang 13 This should be class `unreleased` (yellow) for now so that people can easily tell what's in the most recent Clang

[PATCH] D105127: Implement P1401R5

rsmith added a comment. In D105127#2851443 , @rsmith wrote: > P1401R5 points out that we get `noexcept(bool)` wrong in the opposite > direction, permitting conversions to `bool` that we are supposed to reject. > While that rule didn't change as part of

[PATCH] D105127: Implement P1401R5

rsmith added a comment. Would we benefit from any more test coverage for the `static_assert` side of this paper, or is our (formerly wrong and now correct) behavior already well-covered by existing tests? (Similarly for `explicit(bool)`, do we already have good test coverage for the

[PATCH] D105127: Implement P1401R5

rsmith added a comment. P1401R5 points out that we get `noexcept(bool)` wrong in the opposite direction, permitting conversions to `bool` that we are supposed to reject. While that rule didn't change as part of P1401R5, it'd be nice to handle it as part of dealing with that paper.

[PATCH] D104680: [clang] Eliminate relational function pointer comparisons in all C++ modes

joerg added a comment. Is there any reason for breaking C++03 code here? I don't see the advantage to that at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104680/new/ https://reviews.llvm.org/D104680

[PATCH] D105127: Implement P1401R5

mizvekov added a comment. LGTM! Since you submitted this quite recently, I would wait some more time before landing, for any other people who might want to review this. Maybe wait for it to be a week old, ping anyone else you might want to get a review from, and wait a couple of days for them

[PATCH] D105226: [Clang] allow overriding -fbasic-block-sections

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcab5f89cfd9e: [Clang] allow overriding -fbasic-block-sections (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] cab5f89 - [Clang] allow overriding -fbasic-block-sections

Author: Artem Belevich Date: 2021-06-30T14:32:08-07:00 New Revision: cab5f89cfd9efa9166e1362972e460323b8254ef URL: https://github.com/llvm/llvm-project/commit/cab5f89cfd9efa9166e1362972e460323b8254ef DIFF:

[clang] ef227b3 - Add dumping support for RequiresExpr.

Author: Richard Smith Date: 2021-06-30T14:27:19-07:00 New Revision: ef227b32b63c53ca81ebd410c7fbd5af8fc22ec5 URL: https://github.com/llvm/llvm-project/commit/ef227b32b63c53ca81ebd410c7fbd5af8fc22ec5 DIFF: https://github.com/llvm/llvm-project/commit/ef227b32b63c53ca81ebd410c7fbd5af8fc22ec5.diff

[PATCH] D93525: [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

rsmith added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:390 +// RUN: clang-offload-bundler -unbundle -type=a -targets=openmp-amdgcn-amd-amdhsa--gfx906,openmp-amdgcn-amd-amdhsa--gfx908 -inputs=%t.input-archive.a

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

rsmith added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:435 +}; +A test1(B x) { return x; } // cxx98-error {{conversion}} {{is ambiguous}} + The "{{is ambiguous}}" here is not part of the expected-error and will be

[PATCH] D105226: [Clang] allow overriding -fbasic-block-sections

tra updated this revision to Diff 355681. tra edited the summary of this revision. tra added a comment. comment typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105226/new/ https://reviews.llvm.org/D105226 Files:

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

rsmith added a comment. Thanks! I think you may be missing an implementation of this rule: > A definition of a comparison operator as defaulted that appears in a class > shall be the first declaration of that function. In particular, this is now invalid: struct A; bool operator==(A, A);

[PATCH] D105226: [Clang] allow overriding -fbasic-block-sections

tmsriram accepted this revision. tmsriram added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105226/new/ https://reviews.llvm.org/D105226

[clang-tools-extra] a62579f - [clangd][nfc] Show more information in logs when compiler instance prepare fails

Author: Aleksandr Platonov Date: 2021-06-30T21:58:33+01:00 New Revision: a62579fc008e22b6c9e1544788644f5fceef15ce URL: https://github.com/llvm/llvm-project/commit/a62579fc008e22b6c9e1544788644f5fceef15ce DIFF:

[PATCH] D104056: [clangd][nfc] Show more information in logs when compiler instance prepare fails

This revision was automatically updated to reflect the committed changes. Closed by commit rGa62579fc008e: [clangd][nfc] Show more information in logs when compiler instance prepare fails (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105226: [Clang] allow overriding -fbasic-block-sections

tra created this revision. tra added reviewers: tmsriram, jlebar. Herald added subscribers: pengfei, bixia. tra requested review of this revision. Herald added a project: clang. We should not error out on non-x86 targets if `-fbasic-block-sections=none` is in effect. Also, filter it out for

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

NeHuang added inline comments. Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-fp.ll:18 + +define dso_local double @test_fsel(double %a, double %b, double %c) local_unnamed_addr #0 { +; CHECK-PWR7-LABEL: test_fsel you can remove `#0`, `#1` and `#2`

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

NeHuang added a comment. Overall looks good. Some nits as below. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fp.c:9 +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s + +double test_fric(double a) { - You can define three extern variables for

[PATCH] D105148: [CMake] Don't use -Bsymbolic-functions for MinGW targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf6770f9bd60: [CMake] Dont use -Bsymbolic-functions for MinGW targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105148/new/

[clang] bf6770f - [CMake] Don't use -Bsymbolic-functions for MinGW targets

Author: Martin Storsjö Date: 2021-06-30T22:54:26+03:00 New Revision: bf6770f9bd606643c8ea8a7ab03da5da5960e98e URL: https://github.com/llvm/llvm-project/commit/bf6770f9bd606643c8ea8a7ab03da5da5960e98e DIFF:

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 355666. cor3ntin added a comment. Fix Formatting in tests. Do not return early for value dependent expressions as PerformContextuallyConvertToBool performs checks that are expected to occur down the line Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105127: Implement P1401R5

cor3ntin added a comment. In D105127#2850975 , @mizvekov wrote: > So I read the paper, downloaded this patch, played around with it a little > bit, tried some different tests, like expressions with dependent types, > classes with regular/explicit

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > -u is a linker option used to pretend a symbol is undefined, this option are > common used for force pull-in weak symbol. for forcing archive member extraction. weak symbols

[PATCH] D105127: Implement P1401R5

mizvekov added a comment. Its unfortunate the buildbot does not have debug symbols. If you have not managed to reproduce it locally, here is the backtrace I got: FAIL: Clang :: CXX/except/except.spec/p1.cpp (1 of 1) TEST 'Clang :: CXX/except/except.spec/p1.cpp' FAILED

[PATCH] D105127: Implement P1401R5

cor3ntin added a comment. In D105127#2850975 , @mizvekov wrote: > So I read the paper, downloaded this patch, played around with it a little > bit, tried some different tests, like expressions with dependent types, > classes with regular/explicit

[PATCH] D105112: [clang] Add -fdump-record-layouts-canonical option

stevewan added a comment. I'm not familiar with `getCanonicalType()`, can you confirm whether it sees through nested typedef's? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105112/new/ https://reviews.llvm.org/D105112

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ychen added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2001 -if ((Shape.ABI == coro::ABI::Async || Shape.ABI == coro::ABI::Retcon || - Shape.ABI == coro::ABI::RetconOnce) && -!Shape.CoroSuspends.empty()) { - // Run the

[PATCH] D105127: Implement P1401R5

mizvekov requested changes to this revision. mizvekov added a comment. This revision now requires changes to proceed. So I read the paper, downloaded this patch, played around with it a little bit, tried some different tests, like expressions with dependent types, classes with regular/explicit

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added a reviewer: ronlieb. JonChesterfield added a comment. this unblocks the hazard I am concerned about for D104904 , namely it stops us defining `__CUDA__` when compiling amdgcn code that includes complex.h Comment at:

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, pdhaliwal. Herald added subscribers: guansong, kristof.beyls, tpr, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang requested changes to this revision. NeHuang added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:32 -// builtins for compatibility with the XL compiler +// XL Compatibility built-ins

[clang] 822b92a - [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

Author: Xun Li Date: 2021-06-30T11:38:14-07:00 New Revision: 822b92aae439c4ba2946980c8a27bd2c8a62d90c URL: https://github.com/llvm/llvm-project/commit/822b92aae439c4ba2946980c8a27bd2c8a62d90c DIFF: https://github.com/llvm/llvm-project/commit/822b92aae439c4ba2946980c8a27bd2c8a62d90c.diff LOG:

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG822b92aae439: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after… (authored by lxfind). Repository: rG LLVM Github

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/math.h:41 #pragma omp begin declare variant match( \ device = {arch(nvptx, nvptx64)}, implementation = {extension(match_any)})

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b0ddc2662ad: [clang][Fuchsia] Remove relative-vtables multilibs (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105145/new/

[clang] 9b0ddc2 - [clang][Fuchsia] Remove relative-vtables multilibs

Author: Leonard Chan Date: 2021-06-30T11:21:37-07:00 New Revision: 9b0ddc2662addaa563b632c577996e515e1a7802 URL: https://github.com/llvm/llvm-project/commit/9b0ddc2662addaa563b632c577996e515e1a7802 DIFF: https://github.com/llvm/llvm-project/commit/9b0ddc2662addaa563b632c577996e515e1a7802.diff

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355637. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/lib/hwasan/hwasan_fuchsia.cpp

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay updated this revision to Diff 355627. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Correct a couple of Nits prior to commit. (just updating patch for completeness) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/

Re: [PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

Doh, thank you Nico! On Wed, 30 Jun 2021, 18:54 Nico Weber via Phabricator, < revi...@reviews.llvm.org> wrote: > thakis added a comment. > > (fyi: this broke mac builds. i fixed that in > b56e5f8a10c1ec4fd3750bdd269fbad778820326 < >

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

dblaikie added a comment. In D98799#2850682 , @ahatanak wrote: > I think I've fixed all the places in CodeGen that create fake `FunctionDecl`s > and would cause clang to crash. Thanks, I really appreciate it! I'll have a go at unifying this mangled V

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

tianshilei1992 added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/math.h:41 #pragma omp begin declare variant match( \ device = {arch(nvptx, nvptx64)}, implementation = {extension(match_any)})

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

ahatanak added a comment. Herald added a subscriber: modimo. I think I've fixed all the places in CodeGen that create fake `FunctionDecl`s and would cause clang to crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98799/new/

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. tagged request changes because I think we should ifdef around complex before (or while) landing this, as defining `__CUDA__`, even transiently, is a user hostile thing to do from amdgpu openmp It is *really* ugly that we have cuda and hip implementations of

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

MyDeveloperDay added a comment. > I implemented a good fraction of the C# support and am confident that these > changes are an improvement. Thank you. I've been very grateful to you all (which is why I included you as reviewers) for filling in the gaps in the C# formatting, but I'm super

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

MyDeveloperDay added a comment. > is a smell that tells us to use an enum. I totally agree > Personally I find it harder to finder multiple options that concern the same > aspect of the code style rather than a single option. To be honest, I think we know the options some of the best (apart

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104854: Introduce intrinsic llvm.isnan

sepavloff updated this revision to Diff 355614. sepavloff added a comment. Missed optimization in X86 codegen proposed by Craig Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104854/new/ https://reviews.llvm.org/D104854 Files:

[PATCH] D105097: [clang][AArch64][SVE] Handle PRValue under VLAT <-> VLST cast

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/attr-arm-sve-vector-bits-globals.c:108 +// CHECK-128-NEXT:[[CASTFIXEDSVE:%.*]] = bitcast <2 x i8>* [[SAVED_VALUE]] to * +//

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2001 -if ((Shape.ABI == coro::ABI::Async || Shape.ABI == coro::ABI::Retcon || - Shape.ABI == coro::ABI::RetconOnce) && -!Shape.CoroSuspends.empty()) { - // Run the

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. Weird pre-existing stuff in cuda_complex_builtins. It has an #ifdef AMDGCN macro in it, despite 'cuda' in the name. I note there is no corresponding 'hip' complex builtins. The ifdef logic for stubbing out some functions (which is done with macros...) isn't

[PATCH] D105185: [AIX] Add _AIX73 version macro

Jake-Egan updated this revision to Diff 355613. Jake-Egan added a comment. Fixed formatting to be consistent with the other macro definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105185/new/ https://reviews.llvm.org/D105185 Files:

[PATCH] D104946: [AMDGPU] Add builtin functions image_bvh_intersect_ray

This revision was automatically updated to reflect the committed changes. Closed by commit rG434bd5bf5479: [AMDGPU] Add builtin functions image_bvh_intersect_ray (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 434bd5b - [AMDGPU] Add builtin functions image_bvh_intersect_ray

Author: Yaxun (Sam) Liu Date: 2021-06-30T13:10:47-04:00 New Revision: 434bd5bf5479615ea42e64a80ff994059f31f5f4 URL: https://github.com/llvm/llvm-project/commit/434bd5bf5479615ea42e64a80ff994059f31f5f4 DIFF:

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

ychen added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2115 + << "\n"); F.removeFnAttr(CORO_PRESPLIT_ATTR); drive-by nit: would it be better to move it up near `Coroutines.push_back();`?

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. Good spot. I've been feeding the following to various toolchains: // permute //#include //#include //#include #ifndef _OPENMP #error "OpenMP should be defined #endif #ifdef __CUDA__ #error "Cuda should not be defined" #endif

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_hip_cmath.h:96 +__DEVICE__ __CONSTEXPR__ bool isnan(float __x) { return ::__isnanf(__x); } +__DEVICE__ __CONSTEXPR__ bool isnan(double __x) { return ::__isnan(__x); } pdhaliwal wrote: >

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

aqjune added a comment. I asked @hyeongyukim (who is a participant of google summer of code) to rebase this patch and make an updated version. I thought it was a good goal for him to target, as the validity of the enable-noundef flag is already reviewed and the changes are syntactic updates to

RE: [PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

[AMD Official Use Only] It maybe that the patch does not expose __CUDA__ directly. Rather the patch works so well we finally see the pre-existing issue in complex.h ./clang/lib/Headers/openmp_wrappers/complex.h -Original Message- From: Jon Chesterfield via Phabricator Sent:

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

dblaikie added inline comments. Comment at: clang/test/SemaTemplate/class-template-id.cpp:12-14 +return ptr2; // expected-error{{cannot initialize return object of type 'A *' (aka 'A *') with an lvalue of type 'const A *'}} else { +return ptr3; //

[PATCH] D100553: [clangd] Log feature configuration (linux+asan+grpc) of the clangd build

thakis added a comment. (fyi: this broke mac builds. i fixed that in b56e5f8a10c1ec4fd3750bdd269fbad778820326 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100553/new/

[clang-tools-extra] b56e5f8 - [clangd] Unbreak mac build after 0c96a92d8666b8

Author: Nico Weber Date: 2021-06-30T12:53:38-04:00 New Revision: b56e5f8a10c1ec4fd3750bdd269fbad778820326 URL: https://github.com/llvm/llvm-project/commit/b56e5f8a10c1ec4fd3750bdd269fbad778820326 DIFF: https://github.com/llvm/llvm-project/commit/b56e5f8a10c1ec4fd3750bdd269fbad778820326.diff

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind updated this revision to Diff 355607. lxfind added a comment. fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95807/new/ https://reviews.llvm.org/D95807 Files: clang/test/CodeGenCoroutines/coro-newpm-pipeline.cpp

[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

lxfind added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2112-2114 StringRef Value = Attr.getValueAsString(); LLVM_DEBUG(dbgs() << "CoroSplit: Processing coroutine '" << F.getName() << "' state: " << Value << "\n");

[PATCH] D104797: [WebAssembly] Implementation of global.get/set for reftypes in LLVM IR

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyTargetMachine.cpp:130 TT.isArch64Bit() -? "e-m:e-p:64:64-i64:64-n32:64-S128-ni:1" -:

  1   2   >