[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1015 +break; + } + Adding `default: llvm_unreachable` would be nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:997 +static llvm::Value *emitLoadReserveIntrinsic(CodeGenFunction , + unsigned BuiltinID, Maybe rename to `emitPPCLoadReserveIntrinsic` should

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128")

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. It would be an excellent idea to try the libc++ test suite with this patch (make sure to pass `--param std=c++03`). Comment at: clang/lib/Sema/SemaStmt.cpp:3484 +

[clang] 514c033 - [OpenMP] Detect SPMD compatible kernels and execute them as such

Author: Johannes Doerfert Date: 2021-07-10T18:44:25-05:00 New Revision: 514c033db1e0c237eccd56b9fc11fe05a6baff39 URL: https://github.com/llvm/llvm-project/commit/514c033db1e0c237eccd56b9fc11fe05a6baff39 DIFF:

[clang] a706b94 - [OpenMP][NFCI] Re-enable two remarks tests after D101977 landed

Author: Johannes Doerfert Date: 2021-07-10T18:18:34-05:00 New Revision: a706b94ea5560a7733e403006a9066cc41e82b5d URL: https://github.com/llvm/llvm-project/commit/a706b94ea5560a7733e403006a9066cc41e82b5d DIFF:

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added a comment. looking at the failing test cases, for example `./clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c`, which are not test cases compiled for `PPC`, I'm seeing this following error: clang: /home/conanap/llvm/ccom/llvm-project/llvm/lib/IR/Instructions.cpp:494:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357765. cor3ntin added a comment. clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357764. cor3ntin added a comment. Fix avaibility attribute parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files:

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

mizvekov added a comment. In D104500#2867404 , @ldionne wrote: > I don't know what the state of those extensions is from Clang's perspective, > however one thing is clear - we use those extensions in libc++ very heavily. > If any such extension is

[PATCH] D105756: [clang] C++98 implicit moves are back with a vengeance

mizvekov created this revision. mizvekov edited the summary of this revision. mizvekov edited the summary of this revision. mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 357688. mizvekov added a comment. mizvekov updated this revision to Diff 357692. mizvekov

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 updated this revision to Diff 357756. predator5047 added a comment. Fix clang-tidy formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 updated this revision to Diff 357755. predator5047 added a comment. Fix clang-tidy warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. Regarding struct A; bool operator==(A, A); struct A { friend bool operator==(A, A) = default; // error, not first declaration }; GCC and msvc have marked P2085R0 as complete and do not implement this rule should I implement it anyway? I don't know if

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 updated this revision to Diff 357747. predator5047 added a comment. Addressed Richard's comments. Fix handling of friend functions. Added an error dialog for when enum type are used as params. Removed define outside of class dialog since it is no longer needed. Moved tests to

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357746. cor3ntin added a comment. Herald added a project: clang-tools-extra. Fix tests, windows compilation, formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/

[clang] f01d45c - Reland "[clang-repl] Allow passing in code as positional arguments."

Author: Vassil Vassilev Date: 2021-07-10T17:54:00Z New Revision: f01d45c378cd0271e279d971c79d6e4900f045e0 URL: https://github.com/llvm/llvm-project/commit/f01d45c378cd0271e279d971c79d6e4900f045e0 DIFF: https://github.com/llvm/llvm-project/commit/f01d45c378cd0271e279d971c79d6e4900f045e0.diff

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357741. cor3ntin added a comment. Fix asserts firing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang/include/clang/AST/Expr.h

[PATCH] D104898: [clang-repl] Allow passing in code as positional arguments.

v.g.vassilev added a comment. In D104898#2855751 , @hctim wrote: > Hi, looks like this change caused a regression on the sanitizer buildbots > (https://lab.llvm.org/buildbot/#/builders/169/builds/1290/steps/25/logs/stdio). > Error copied below for your

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jdoerfert marked an inline comment as done. Closed by commit rG1d5711c3eeb6: [OpenMP] Unified entry point for SPMD generic kernels in the device RTL (authored by

[clang] 1d5711c - [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

Author: Johannes Doerfert Date: 2021-07-10T12:32:50-05:00 New Revision: 1d5711c3eeb62098b46d4d383f2e849b9756105d URL: https://github.com/llvm/llvm-project/commit/1d5711c3eeb62098b46d4d383f2e849b9756105d DIFF:

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3275 -static bool SemaFeatureCheck(Sema , CallExpr *TheCall, - StringRef FeatureToCheck, unsigned DiagID) { +static bool SemaArchFeatureCheck(Sema , CallExpr *TheCall, +

[PATCH] D105666: [PowerPC] [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces that compare vector bool types with vector signed types

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105666/new/ https://reviews.llvm.org/D105666

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD updated this revision to Diff 357724. RedDocMD added a comment. Little refactors, one more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105421/new/ https://reviews.llvm.org/D105421 Files:

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357723. cor3ntin added a comment. - Support unevaluated str8ing literal in deprecated/nodiscard attributes - Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

pengfei updated this revision to Diff 357722. pengfei added a comment. Add tests for __extendhfxf2 and __truncxfhf2. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265 Files:

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

RedDocMD marked 4 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:195 +const SmallVector BasicOstreamName = {"basic_ostream"}; + vsavchenko wrote: > Same here + don't call it "Name"

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei updated this revision to Diff 357721. pengfei added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 Files: clang/include/clang/Basic/BuiltinsX86.def

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

HsiangKai updated this revision to Diff 357720. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103873/new/ https://reviews.llvm.org/D103873 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D103872: [Clang][RISCV] Implement vssseg.

HsiangKai updated this revision to Diff 357719. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103872/new/ https://reviews.llvm.org/D103872 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D103871: [Clang][RISCV] Implement vsseg.

HsiangKai updated this revision to Diff 357718. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103871/new/ https://reviews.llvm.org/D103871 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

HsiangKai updated this revision to Diff 357717. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103809/new/ https://reviews.llvm.org/D103809 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

HsiangKai updated this revision to Diff 357716. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103796/new/ https://reviews.llvm.org/D103796 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 357714. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang/include/clang/AST/Expr.h

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch proposes to handle in an uniform fashion the parsing of strings that are never evaluated, in asm statement, static assert, attrributes,

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > Should any known failure modes be documented? At present, I don't know of any, I think I could probably trick it with macros but then that is #clang-format all over, if you are using it feel free to log bugs in the

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. The part I'm confused about is that you're forcing it to use "*r". At the IR level, LLVM handles something like `call void asm sideeffect "#$0", "r"([8 x i64] %c)` fine. You'll have to do a bit of work to teach clang to emit that, but it shouldn't be that hard. I