[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:440 + State, {std::make_pair(CC->getCXXThisVal(), ArgVal)}, + C.getLocationContext(), PSK_DirectEscapeOnCall, ); RedDocMD wrote: > It seems to me

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

NoQ added a comment. Looks correct. Tests pls? I think that's one of the places where `clang_analyzer_dump()` is appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107720/new/ https://reviews.llvm.org/D107720

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107433/new/ https://reviews.llvm.org/D107433

[PATCH] D107433: [RISCV] Half-precision for vget/vset.

HsiangKai updated this revision to Diff 365065. HsiangKai added a comment. Update test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107433/new/ https://reviews.llvm.org/D107433 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365062. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365061. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/lib/Analysis/Consumed.cpp clang/lib/Sema/AnalysisBasedWarnings.cpp

[PATCH] D107723: [Clang] Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit updated this revision to Diff 365060. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107723/new/ https://reviews.llvm.org/D107723 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Analysis/Consumed.cpp

[PATCH] D107723: Moved warning of warnReturnTypestateForUnconsumableType back to SemaDeclAttr

gAlfonso-bit created this revision. Herald added a reviewer: aaron.ballman. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107723 Files:

[PATCH] D107720: [analyzer] Cleanup a FIXME in SValBuilder.cpp

vabridgers created this revision. vabridgers added reviewers: NoQ, vsavchenko, ASDenysPetrov, steakhal, martong. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. Oh, I should say I wasn't able to get this behavior to be exposed in a diagnostic in my limited testing - and attempting to add diagnostic cases caused me to lose the reproduction in the ast dumping, perhaps because I added some AST that tickled/fixed the disparity

[PATCH] D91311: Add new 'preferred_name' attribute.

dblaikie added a comment. While looking into some debug info issues* I've come across what I think are some inconsistencies in the handling of this attribute - @rsmith mind taking a look? Firstly, it looks like something isn't handled when it comes to templates where only the declaration of a

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added a comment. It's been pointed out to me that -lm is a linker flag so it's weird to require it at compile time. I haven't thought of a good fix for that yet. We don't need to splice in ocml for each compilation unit, so can move the test+splice into the link phase, except

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365046. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365045. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365044. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365043. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit updated this revision to Diff 365042. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h clang/lib/AST/Type.cpp Index: clang/lib/AST/Type.cpp

[PATCH] D107719: [Clang] Resolve FIXMEs in Types.h

gAlfonso-bit created this revision. gAlfonso-bit added projects: LLVM, clang. gAlfonso-bit requested review of this revision. Herald added a subscriber: cfe-commits. This includes removing ObjectiveC Object Pointers from the list of specifiers, as well as checking for C++ instead of using Scoped

[clang-tools-extra] c5c3cdb - [clangd] Populate-switch triggers when the whole condition is selected.

Author: Sam McCall Date: 2021-08-08T21:06:08+02:00 New Revision: c5c3cdb9c92895a63993cee70d2dd776ff9519c3 URL: https://github.com/llvm/llvm-project/commit/c5c3cdb9c92895a63993cee70d2dd776ff9519c3 DIFF: https://github.com/llvm/llvm-project/commit/c5c3cdb9c92895a63993cee70d2dd776ff9519c3.diff

[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

ArcsinX abandoned this revision. ArcsinX added a comment. As I can see, no chances for this to get approved. So. closing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107304/new/ https://reviews.llvm.org/D107304

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

MaskRay added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:17 +// RUN: %clang %s -### -no-canonical-prefixes -target avr --sysroot %S/Inputs/basic_avr_tree/usr/lib 2>&1 | FileCheck -check-prefix CC1D %s +// CC1D: clang{{.*}} "-cc1" "-triple" "avr" {{.*}}

[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a reviewer: a.sidorin. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - They need to be preserved even if there's no reference within the device code as

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

MaskRay added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:1 // A basic clang -cc1 command-line. MaskRay wrote: > You can UNSUPPORT windows if you don't want to wrestle with \ and / path > separators. UNSUPPORTED: system-windows CHANGES

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:460 + if (llvm::sys::fs::is_directory(Path)) +return Optional(Path); + Path = GCCParent + "/../avr"; `return Path;` Comment at:

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:440 + State, {std::make_pair(CC->getCXXThisVal(), ArgVal)}, + C.getLocationContext(), PSK_DirectEscapeOnCall, ); It seems to me that this

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 365031. RedDocMD added a comment. Further pointer escape Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files:

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie added a comment. In D106585#2905916 , @rnk wrote: > In D106585#2905663 , @dblaikie > wrote: > >> In D106585#2902588 , @dblaikie >> wrote: >> >>> Preserving

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3471 + ContainsFloatAtOffset(IRType, IROffset + 4, getDataLayout())) +return llvm::FixedVectorType::get(llvm::Type::getHalfTy(getVMContext()), 4); + LuoYuanke wrote: > For 2

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

LuoYuanke added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:3471 + ContainsFloatAtOffset(IRType, IROffset + 4, getDataLayout())) +return llvm::FixedVectorType::get(llvm::Type::getHalfTy(getVMContext()), 4); + For 2 float, return

[PATCH] D97753: [clang-tidy] Add a check for enforcing minimum length for variable names

0x8000- updated this revision to Diff 365016. 0x8000- added a comment. Updated documentation for all options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97753/new/ https://reviews.llvm.org/D97753 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

0x8000- added a comment. In D54943#2933179 , @JonasToth wrote: > In D54943#2633408 , @tiagoma wrote: > >> Can we get this in? I work in Microsoft Office and we have been using this >> checker and it works

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2633408 , @tiagoma wrote: > Can we get this in? I work in Microsoft Office and we have been using this > checker and it works great! There are a couple of issues with it and I would > like to contribute fixes. Hey,

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev updated this revision to Diff 365005. v.g.vassilev added a comment. Try to appease the windows pre-merge bot. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107049/new/ https://reviews.llvm.org/D107049 Files: clang/docs/ClangFormattedStatus.rst