[clang] 4357852 - [Remarks] Emit optimization remarks for atomics generating CAS loop

2021-08-14 Thread Anshil Gandhi via cfe-commits
Author: Anshil Gandhi Date: 2021-08-14T23:37:23-06:00 New Revision: 435785214f73ff0c92e97f2ade6356e3ba3bf661 URL: https://github.com/llvm/llvm-project/commit/435785214f73ff0c92e97f2ade6356e3ba3bf661 DIFF: https://github.com/llvm/llvm-project/commit/435785214f73ff0c92e97f2ade6356e3ba3bf661.diff

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

2021-08-14 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 366470. pengfei marked an inline comment as done. pengfei added a comment. Rebased. Add extra parentheses for macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105265/new/ https://reviews.llvm.org/D105265

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

2021-08-14 Thread Nathan Chancellor via Phabricator via cfe-commits
nathanchance added a comment. I have sent the following patches for the Linux kernel. These were the only instances of the warning that I found across the code base in all of the configurations that we usually test so thank you for the heads up so I could send fixes before this lands.

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

2021-08-14 Thread Pengfei Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1de9d6dae17: [X86] AVX512FP16 instructions enabling 2/6 (authored by pengfei). Changed prior to commit:

[clang] d2cb189 - [X86] Use a do {} while (0) in the _MM_EXTRACT_FLOAT implementation.

2021-08-14 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2021-08-14T16:41:55-07:00 New Revision: d2cb18918498b8a39657af2a495eba3e983c159b URL: https://github.com/llvm/llvm-project/commit/d2cb18918498b8a39657af2a495eba3e983c159b DIFF: https://github.com/llvm/llvm-project/commit/d2cb18918498b8a39657af2a495eba3e983c159b.diff

[clang] 73c4c32 - [X86] Use __builtin_bit_cast _mm_extract_ps instead of type punning through a union. NFC

2021-08-14 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2021-08-14T16:35:55-07:00 New Revision: 73c4c3276720b20525ce9ef5f8e4f0c20fd93862 URL: https://github.com/llvm/llvm-project/commit/73c4c3276720b20525ce9ef5f8e4f0c20fd93862 DIFF: https://github.com/llvm/llvm-project/commit/73c4c3276720b20525ce9ef5f8e4f0c20fd93862.diff

[PATCH] D107873: [clang-tidy] adds a const-qualified parameter check

2021-08-14 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 366457. cjdb retitled this revision from "[WIP][clang-tidy] adds a const-qualified parameter check" to "[clang-tidy] adds a const-qualified parameter check". cjdb added a comment. removes WIP tag from patch name Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

2021-08-14 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb marked an inline comment as done. cjdb added a comment. @jmarrec I believe you wanted to import a discussion from D107900 ? Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:57 +namespace { +bool

[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

2021-08-14 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb updated this revision to Diff 366456. cjdb marked 9 inline comments as done. cjdb added a comment. - adds user options - removes use of `auto` - fixes header comment - removes unused type - fixes documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

2021-08-14 Thread Alf via Phabricator via cfe-commits
gAlfonso-bit updated this revision to Diff 366451. gAlfonso-bit added a comment. Add ObjectPointerType to GetBaseType CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp Index:

[PATCH] D107961: [clang-format] Distinguish K C function definition and attribute

2021-08-14 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6928cf45516: [clang-format] Distinguish KR C function definition and attribute (authored by Owen owe...@users.noreply.github.com, committed by

[clang] f6928cf - [clang-format] Distinguish K C function definition and attribute

2021-08-14 Thread via cfe-commits
Author: Owen Date: 2021-08-14T05:00:40-07:00 New Revision: f6928cf45516503deb48f8175a982becc579dc8c URL: https://github.com/llvm/llvm-project/commit/f6928cf45516503deb48f8175a982becc579dc8c DIFF: https://github.com/llvm/llvm-project/commit/f6928cf45516503deb48f8175a982becc579dc8c.diff LOG:

[PATCH] D104975: Implement P1949

2021-08-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 366430. cor3ntin added a comment. Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h

[PATCH] D104975: Implement P1949

2021-08-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin marked 2 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:117 +def err_character_not_allowed : Error< + "character not allowed in identifiers">; def ext_unicode_whitespace : ExtWarn<

[PATCH] D104975: Implement P1949

2021-08-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D104975#2944703 , @rsmith wrote: > In D104975#2944313 , @cor3ntin > wrote: > >> @rsmith: I modified the script locally to support dxx: dup P - let me >> know if you think that's

[PATCH] D104975: Implement P1949

2021-08-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 366426. cor3ntin added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104975/new/ https://reviews.llvm.org/D104975 Files: clang/include/clang/Basic/CharInfo.h

[PATCH] D104975: Implement P1949

2021-08-14 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 366425. cor3ntin added a comment. - Support superseeding DRs with paper in make_cxx_dr_status (ie //drXXX: sup P) - Better diagnostic message when a codepoint is identifier continue but not identifier start - Provide a different diagnostic message for

[PATCH] D105479: [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

2021-08-14 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe866327c1f9: [clang-tidy] [PR50069] readability-braces-around-statements doesnt work well… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] fe86632 - [clang-tidy] [PR50069] readability-braces-around-statements doesn't work well with [[likely]] [[unlikely]]

2021-08-14 Thread via cfe-commits
Author: mydeveloperday Date: 2021-08-14T12:05:21+01:00 New Revision: fe866327c1f98a327767e80290dd08cedeadbfd6 URL: https://github.com/llvm/llvm-project/commit/fe866327c1f98a327767e80290dd08cedeadbfd6 DIFF:

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366423. peterjc123 added a comment. clang-tidy CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index:

[PATCH] D95168: [clang-format] Add InsertBraces option

2021-08-14 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Any thoughts about actually removing braces? eliding braces on single line functions would be very useful for LLVM, its like the most common review comment! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/

[PATCH] D108069: [CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly

2021-08-14 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. kaz7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Need to update a clang regression test for VE after https://reviews.llvm.org/D93769.

[PATCH] D108068: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 created this revision. peterjc123 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108068 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D108067: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 created this revision. peterjc123 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108067 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366416. peterjc123 added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp

[PATCH] D107958: [clang-format] NFC update the ClangFormatStyleOption.rst following previous change

2021-08-14 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0391165134fc: [clang-format] NFC update the ClangFormatStyleOption.rst following previous… (authored by MyDeveloperDay). Repository: rG LLVM

[clang] 0391165 - [clang-format] NFC update the ClangFormatStyleOption.rst following previous change

2021-08-14 Thread via cfe-commits
Author: mydeveloperday Date: 2021-08-14T10:41:58+01:00 New Revision: 0391165134fc2d19fd13170d87724c3b7bd7366e URL: https://github.com/llvm/llvm-project/commit/0391165134fc2d19fd13170d87724c3b7bd7366e DIFF:

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366413. peterjc123 added a comment. Skip in template classes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index:

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366410. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index:

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366407. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index:

[PATCH] D108021: [dllexport] Instantiate default ctor default args

2021-08-14 Thread Peter Jiachen via Phabricator via cfe-commits
peterjc123 updated this revision to Diff 366405. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108021/new/ https://reviews.llvm.org/D108021 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/CodeGenCXX/dllexport-ctor-closure-nested.cpp Index: