[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47d9d55c6660: [clangd] Do not show inlay hints pertaining to code in other files (authored by nridge). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 47d9d55 - [clangd] Do not show inlay hints pertaining to code in other files

Author: Nathan Ridge Date: 2021-08-16T01:58:23-04:00 New Revision: 47d9d55c66601ffb5939ce07a7eb3c96122c48d6 URL: https://github.com/llvm/llvm-project/commit/47d9d55c66601ffb5939ce07a7eb3c96122c48d6 DIFF: https://github.com/llvm/llvm-project/commit/47d9d55c66601ffb5939ce07a7eb3c96122c48d6.diff

[PATCH] D106934: [clangd] Do not inlay hints pertaining to code in other files

nridge updated this revision to Diff 366552. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106934/new/ https://reviews.llvm.org/D106934 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K C

owenpan updated this revision to Diff 366541. owenpan added a comment. Simplified the code slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108094/new/ https://reviews.llvm.org/D108094 Files: clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

pengfei added a comment. Thanks Craig! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105264/new/ https://reviews.llvm.org/D105264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95583: Frontend: Add -f{, no-}implicit-modules-uses-lock and -Rmodule-lock

arichardson added inline comments. Comment at: clang/test/Modules/implicit-modules-use-lock.m:21 + +// CHECK-NO-LOCKS-NOT: remark: +// CHECK-LOCKS: remark: locking '{{.*}}.pcm' to build module 'X' [-Rmodule-lock] jansvoboda11 wrote: > dexonsmith wrote: > >

[PATCH] D108083: add sanitizer support to hexagon

bcain added inline comments. Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:297-298 +linkSanitizerRuntimeDeps(HTC, CmdArgs); +// FIXME: sanitizer_common or only some require unwind? +CmdArgs.push_back("-lunwind"); + } I will try

[PATCH] D108094: [clang-format] Improve detection of parameter declarations in K C

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, krasimir. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clean up the detection of parameter

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 366524. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp Index:

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 366522. pestctrl added a comment. Only look for attributes in check string for unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 Files:

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:31087 +// Now widen to 128 bits. +unsigned NumConcats = 128 / TmpVT.getSizeInBits(); +MVT ConcatVT = MVT::getVectorVT(EleVT.getSimpleVT(), 8 * NumConcats);

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1955 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v32f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v32i16, Legal); +

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:145 + /// const emit multiple warnings otherwise. + const bool IsNormalVariableInTemplate = Function->isTemplateInstantiation(); + if

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. The check in the latest form can properly transform `llvm/lib` and `clang/` and requires 28 manual fixes afterwards (values and references are transformed, no other modifications). Some are good and not an issue with the analysis itself, some may or may not be an

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 366516. JonasToth added a comment. - fix: auto and type-dependent initializers fixed by ignoring them correctly in the matcher - fix docs on limitations - fix: deduplicate diagnostics from template instantiations Repository: rG LLVM Github Monorepo

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366515. yaron.keren added a comment. Support both Windows llvm-lit.py and Linux llvm-lit command name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files:

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl updated this revision to Diff 366513. pestctrl added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 Files: clang/lib/AST/Decl.cpp

[PATCH] D105264: [X86] AVX512FP16 instructions enabling 2/6

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:3197 + else if (PatchedName.endswith("sh")) +PatchedName = IsVCMP ? "vcmpsh" : "cmpsh"; + else if (PatchedName.endswith("ph")) pengfei wrote: >

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit added a comment. Not sure about the timing of base patch, but maybe this patch is also candidate for llvm 13 (backport)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 ___ cfe-commits

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366498. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366496. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719 Files: clang/include/clang/AST/Type.h Index: clang/include/clang/AST/Type.h

[PATCH] D107719: [Clang][AST][NFC] Resolve FIXME: Remove unused QualType ElementType member from the ASTContext class.

gAlfonso-bit updated this revision to Diff 366495. gAlfonso-bit added a comment. Herald added subscribers: llvm-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107719/new/ https://reviews.llvm.org/D107719

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren added a comment. looking into Linux failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 ___ cfe-commits mailing list

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren added reviewers: Orlando, probinson, tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Three tests fail when building and testing LLVM from the Visual C++ environment since

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 updated this revision to Diff 366490. xbolva00 added a comment. Rebased. Changed the warning text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

xbolva00 added a comment. sqlite3 +1.3% increase of compile time for -O0 -g is simply not acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

xbolva00 added a comment. http://llvm-compile-time-tracker.com/compare.php?from=530aa7e4da14fb22493ab7e175f8c34dd10333d3=435785214f73ff0c92e97f2ade6356e3ba3bf661=instructions Still same problem with -O0 -g. Please wait a bit for more people, dont rush. Repository: rG LLVM Github Monorepo

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG435785214f73: [Remarks] Emit optimization remarks for atomics generating CAS loop (authored by gandhi21299). Changed prior to commit: https://reviews.llvm.org/D106891?vs=366467=366475#toc Repository:

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. @xbolva00 I timed X86/opt-pipeline.ll passes and DTC executed in 0.1% of the total compile time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366467. gandhi21299 added a comment. reverting changes back to declaring ORE using `getAnalysis` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a subscriber: nikic. gandhi21299 added a comment. Also, @nikic suggested to construct ORE here if we cannot usefully preserve them. I am not sure if preserving the information is useful though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. I will actually revert my changes back with only the tests updated to see if the times are reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 marked an inline comment as done. gandhi21299 added a comment. @xbolva00 is concerned about Dominator Tree Construction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

arsenm added a comment. I don’t think constructing in the pass is the solution. Why exactly is this introducing such a big slowdown? Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:180 + ORE = std::make_shared(); auto = TPC->getTM(); There’s

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366463. gandhi21299 added a comment. Herald added a subscriber: nemanjai. - fixed breaking tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366455. gandhi21299 added a comment. - changed type of ORE from OptimizationRemarkEmitter* to std::shared_ptr and construct it within AtomicExpandPass, this solution is implemented to address for the regressions in many backends due to prerequisite

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

xbolva00 added a comment. http://llvm-compile-time-tracker.com/compare.php?from=1f2d40c47f5f8fd01d91d73a1f52044fe1c83225=c4e5425aa579d21530ef1766d7144b38a347f247=instructions Compile time regressions especially for -O0 -g are higher than expected with this patch. Repository: rG LLVM Github

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4e5425aa579: [Remarks] Emit optimization remarks for atomics generating CAS loop (authored by gandhi21299). Repository: rG LLVM Github Monorepo

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 added a comment. Thanks a lot for the review! I will merge this patch in as soon as the CI passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366357. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - combined all tests into one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:33 +float atomic_cas(__global atomic_float *d, float a) { + return __opencl_atomic_fetch_add(d, a, memory_order_relaxed, memory_scope_work_group); +} Just combine

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366349. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. - adding more tests in clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl for various scopes, memory_scope_work_item is called out as invalid by the compiler so excluded

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:32 +// GFX90A-CAS: atomicrmw fadd float addrspace(1)* {{.*}} syncscope("workgroup-one-as") monotonic +float atomic_cas_system(__global atomic_float *d, float a) { + return

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366343. gandhi21299 added a comment. - removed StringExtras.h inclusion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 Files:

[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

gandhi21299 updated this revision to Diff 366338. gandhi21299 added a comment. - replaced the OpenCL test - renamed filenames - added 'atomic' to the remark and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/

[clang] ccd7dda - [Clang] Updated warning-wall.c test file

Author: Dávid Bolvanský Date: 2021-08-15T13:54:58+02:00 New Revision: ccd7dda8e39adeaf5bbec3c7b68b68800dff7663 URL: https://github.com/llvm/llvm-project/commit/ccd7dda8e39adeaf5bbec3c7b68b68800dff7663 DIFF:

[clang] 079ca8e - [Clang] Put -Wbool-operation under -Wall

Author: Dávid Bolvanský Date: 2021-08-15T13:37:27+02:00 New Revision: 079ca8e312016bd4fbbd3b185087d4c6246c140b URL: https://github.com/llvm/llvm-project/commit/079ca8e312016bd4fbbd3b185087d4c6246c140b DIFF:

[clang] 49de607 - Revert "[Remarks] Emit optimization remarks for atomics generating CAS loop"

Author: Dávid Bolvanský Date: 2021-08-15T11:44:13+02:00 New Revision: 49de6070a2b7a9bb88ff7c935fea5176b1d9255f URL: https://github.com/llvm/llvm-project/commit/49de6070a2b7a9bb88ff7c935fea5176b1d9255f DIFF:

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 366482. JonasToth added a comment. - write documentation for const-analysis check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

xbolva00 added a comment. -Wbool-operation is basically enabled even without -Wall, but yeah, gcc only warns with -Wall specified. I will change it as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003

[PATCH] D105265: [X86] AVX512FP16 instructions enabling 3/6

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:1955 setOperationAction(ISD::SCALAR_TO_VECTOR, MVT::v32f16, Custom); + setOperationAction(ISD::SINT_TO_FP, MVT::v32i16, Legal); +

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 366480. JonasToth added a comment. - Merge branch 'main' into feature_rebase_const_transform_20210808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 Files:

[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth added a comment. In D54943#2944680 , @0x8000- wrote: > Using the checker now in our production BuildBot - no crashes and no false > positives. Can't say if there are false negatives, but at any rate the > checker is better than most

[PATCH] D108083: [DRAFT] add sanitizer support to hexagon

bcain created this revision. bcain added a reviewer: sidneym. Herald added subscribers: s.egerton, cryptoad, simoncook, fedor.sergeev, mgorny. bcain requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. This patch will need