[PATCH] D106577: [clang] Define __STDC_ISO_10646__

hubert.reinterpretcast added a comment. In D106577#2983709 , @ThePhD wrote: > What it does mean is that Clang and every other compiler - so long as they > pick a ISO10646-code point capable encoding for their `wchar_t` literals - > can define this

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

saiislam added a comment. In D105191#2985819 , @ye-luo wrote: > @saiislam since clang-nvlink-wrapper has landed, could you update this patch? @ye-luo , In the last multi-company OpenMP-dev meeting it was suggested that D106809

[clang] 9529901 - [clang] Add '-ast-dump-filter=' support

Author: oToToT Date: 2021-09-07T10:42:18+08:00 New Revision: 95299019e35b21a790a2f797bede1af98d84fcb5 URL: https://github.com/llvm/llvm-project/commit/95299019e35b21a790a2f797bede1af98d84fcb5 DIFF: https://github.com/llvm/llvm-project/commit/95299019e35b21a790a2f797bede1af98d84fcb5.diff LOG:

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

ye-luo added a comment. @saiislam since clang-nvlink-wrapper has landed, could you update this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>;

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai updated this revision to Diff 370980. HsiangKai added a comment. Use timm for the $policy argument in the patterns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 Files:

[PATCH] D109322: [RISCV] (2/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai added a comment. I didn't attach all the test update in this patch. It is too huge to collect them in one patch. I ever ran `check-clang` and all tests pass after I updated all the clang test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109338: [clang][OpenMP] Make IR function names for OpenMP-outlined blocks slightly less awful

lebedev.ri added a comment. In D109338#2985731 , @ABataev wrote: > Maybe use something close to target entries format? Encode function name and > line number of the region. This would help if there are several omp regions > in a function. Sure, i can

[PATCH] D109338: [clang][OpenMP] Make IR function names for OpenMP-outlined blocks slightly less awful

ABataev added a comment. Maybe use something close to target entries format? Encode function name and line number of the region. This would help if there are several omp regions in a function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

justinlatimer added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA,

[PATCH] D109338: [clang][OpenMP] Make IR function names for OpenMP-outlined blocks slightly less awful

lebedev.ri created this revision. lebedev.ri added reviewers: jdoerfert, ABataev, rjmccall. lebedev.ri added projects: OpenMP, clang. Herald added subscribers: zzheng, guansong, yaxunl. lebedev.ri requested review of this revision. Herald added a subscriber: sstefan1. I've recently had to stare

[PATCH] D108756: [clang] Add '-ast-dump-filter=' support

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, sounds OK! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108756/new/ https://reviews.llvm.org/D108756

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1665 + +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) ostannard wrote: > ostannard wrote: > > labrinea wrote: > > >

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 370955. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp clang/lib/AST/TypePrinter.cpp clang/unittests/AST/TypePrinterTest.cpp

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit updated this revision to Diff 370952. gAlfonso-bit added a comment. Added test to TypePrinter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 Files: clang/lib/AST/DeclPrinter.cpp clang/lib/AST/Type.cpp

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 370953. FederAndInk added a comment. only print info on generated plurals if there is a new plural Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 Files:

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. I still think the printing is unnecessary, tell me when the plurals will be different otherwise keep quiet? otherwise, it confuses people making them think they have to do something Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107775: [Clang][AST] Resolve FIXME: Remove ObjCObjectPointer from isSpecifierType

gAlfonso-bit added a comment. @dgoldman May I ask what tests? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107775/new/ https://reviews.llvm.org/D107775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 370944. FederAndInk added a comment. remove one print l17, tell me if we don't want the second print (now l17) fixed typo in the script coment -> comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia added a comment. Due to the release completion schedule and my planned absences, it is likely that this needs finalizing by the end of the week. Any small changes can still be added later on should you wish to improve something afterwards up until the release branch is frozen. I just

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 updated this revision to Diff 370931. jansvoboda11 added a comment. Attempt to fix tests in CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 Files:

[PATCH] D109328: [OpenCL] Supports optional writing to 3d images in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro __opencl_c_3d_image_writes in C++ for

[PATCH] D109327: [OpenCL][Docs] Release 13 notes

Anastasia created this revision. Anastasia added reviewers: azabaznov, olestrohm, Topotuna, svenvh, airlied, stuart, tstellar. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Major OpenCL functionality added in release 13.

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. @aaron.ballman a gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93110/new/ https://reviews.llvm.org/D93110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

ostannard added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1665 + +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) ostannard wrote: > labrinea wrote: > > ostannard wrote: > > > Are

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10687 def err_device_unsupported_type -: Error<"%0 requires %select{|%2 bit size}1 %3 type support, but device " -"'%4' does not support it">; +: Error<"%select{|%1

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

ostannard added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1665 + +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) labrinea wrote: > ostannard wrote: > > Are these optional also

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. In D109321#2985284 , @jhuber6 wrote: > In D109321#2985281 , @lebedev.ri > wrote: > >> Aha. But i don't think this is the right fix, >> the fact that the inlining manifests the miscompile

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

labrinea added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1665 + +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) ostannard wrote: > Are these optional also being passed through to

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

jhuber6 added a comment. In D109321#2985281 , @lebedev.ri wrote: > Aha. But i don't think this is the right fix, > the fact that the inlining manifests the miscompile is a symptom. Preventing the outlined region from being inlined would also hurt

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

lebedev.ri added a comment. Aha. But i don't think this is the right fix, the fact that the inlining manifests the miscompile is a symptom. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109321/new/ https://reviews.llvm.org/D109321

[PATCH] D105092: [RISCV] (1/2) Add the tail policy argument to builtins/intrinsics.

HsiangKai added a comment. Clang part: https://reviews.llvm.org/D109322 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105092/new/ https://reviews.llvm.org/D105092 ___ cfe-commits mailing list

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. `for (i = 0; i < N; i++)` --> `for (i = 1; i < N; i++)` #include using namespace std; int main() { float a[10]; int i, N = 10; for (i = 0; i < N; i++) a[i] = 0; #pragma omp simd for (i = 1; i < N; i++) { #pragma omp ordered

[PATCH] D109315: [clang] Check unsupported types in expressions

Fznamznon added a comment. No objections, just a couple of minors. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10687 def err_device_unsupported_type -: Error<"%0 requires %select{|%2 bit size}1 %3 type support, but device " -"'%4' does not

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. In D109321#2985244 , @peixin wrote: > The following test case fails after >

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin added a comment. The following test case fails after https://reviews.llvm.org/rGaf000197c4214926bd7d0862d86f89aed5f20da6. #include using namespace std; int main() { float a[10]; int i, N = 10; for (i = 0; i < N; i++) a[i] = 0; #pragma omp simd for

[PATCH] D109321: [clang][OpenMP] Fix the bug in codegen for ordered directive

peixin created this revision. peixin added reviewers: jhuber6, jdoerfert, kiranchandramohan, Meinersbur, clementval, kiranktp, Leporacanthicus, bryanpkc, arnamoy10, Chuanfeng. peixin added projects: LLVM, clang. Herald added subscribers: guansong, yaxunl. peixin requested review of this revision.

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:392

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia added a comment. @azabaznov and @airlied the main feedback I am looking for is whether I have missed any important patch and whether you agree with the judgement about the completion status. Note, that due to the release completion schedule and my planned absences it is likely that

[PATCH] D109320: [OpenCL][Docs] Update OpenCL 3.0 implementation status.

Anastasia created this revision. Anastasia added reviewers: azabaznov, airlied. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Updated a section of OpenCLSupport page to reflect the latest development in OpenCL 3.0 support for release 13. This table will

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

hans added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7428-7430 +def warn_bitwise_and_bool : Warning< + "bitwise and of boolean expressions; did you mean logical and?">, + InGroup; Quuxplusone wrote: > xbolva00 wrote: > >

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Cool! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/ https://reviews.llvm.org/D109150 ___ cfe-commits mailing

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk added inline comments. Comment at: clang/docs/tools/dump_format_style.py:17 +PLURALS_FILE = os.path.join(os.path.dirname(__file__), 'plurals.txt') +print(f'generated plurals (for yaml type) are stored in {PLURALS_FILE}') +print('you can use `git checkout --

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:17 +PLURALS_FILE = os.path.join(os.path.dirname(__file__), 'plurals.txt') +print(f'generated plurals (for yaml type) are stored in {PLURALS_FILE}') +print('you can use `git checkout --

[PATCH] D109265: [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6e8d25920c1: [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw (authored by pengfei). Repository: rG LLVM Github

[clang] e6e8d25 - [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw

Author: Wang, Pengfei Date: 2021-09-06T20:28:09+08:00 New Revision: e6e8d25920c1f1cffb58c6b3d52c2b4abbb4c963 URL: https://github.com/llvm/llvm-project/commit/e6e8d25920c1f1cffb58c6b3d52c2b4abbb4c963 DIFF: https://github.com/llvm/llvm-project/commit/e6e8d25920c1f1cffb58c6b3d52c2b4abbb4c963.diff

[clang] 52f7cd2 - [OpenCL] Fix condition macro name in test

Author: Justas Janickas Date: 2021-09-06T13:13:13+01:00 New Revision: 52f7cd23b4af84c9e195e9e2263b8ece8d233fe2 URL: https://github.com/llvm/llvm-project/commit/52f7cd23b4af84c9e195e9e2263b8ece8d233fe2 DIFF:

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

SjoerdMeijer added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1666 +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) + CmdArgs.push_back("-arm-fix-cmse-cve-2021-35465=1"); If

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna updated this revision to Diff 370895. Topotuna added a comment. Condition on OpenCL C / C++ for OpenCL version removed because it was redundant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109150/new/ https://reviews.llvm.org/D109150 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Topotuna added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9972 // OpenCL v1.2 s6.8 static is invalid for kernel functions. -if ((getLangOpts().OpenCLVersion >= 120) -&& (SC == SC_Static)) { +if ((getLangOpts().getOpenCLCompatibleVersion() >=

[PATCH] D109265: [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw

pengfei added a comment. Thanks Martin! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109265/new/ https://reviews.llvm.org/D109265 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. Thanks @erichkeane. SPIR-V diagnostics seem to work fine. There are a few cases that are not handled, so I submitted D109315 to review them separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

ostannard added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:1665 + +CmdArgs.push_back("-mllvm"); +if (A->getOption().matches(options::OPT_mfix_cmse_cve_2021_35465)) Are these optional also being passed through to the linker when

[PATCH] D109315: [clang] Check unsupported types in expressions

asavonic created this revision. asavonic added reviewers: erichkeane, Fznamznon. asavonic requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The patch adds diagnostics for cases like: float F3 =

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

FederAndInk updated this revision to Diff 370883. FederAndInk added a comment. rebase main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109307/new/ https://reviews.llvm.org/D109307

[PATCH] D109265: [X86][mingw] Modify the alignment of __m128/__m256/__m512 vector type for mingw

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Thanks, this does seem to do the right thing in the testcase you provided. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109265/new/

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109306/new/ https://reviews.llvm.org/D109306

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109305/new/ https://reviews.llvm.org/D109305

[PATCH] D108320: Add semantic token modifier for non-const reference parameter

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! This looks good to me to land as is. I'd like to see the std::map eliminated, but if you don't want to do this I'm happy to take a stab at it after. Want someone to commit this

[PATCH] D109150: [OpenCL] Disallows static kernel functions in C++ for OpenCL

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9972 // OpenCL v1.2 s6.8 static is invalid for kernel functions. -if ((getLangOpts().OpenCLVersion >= 120) -&& (SC == SC_Static)) { +if ((getLangOpts().getOpenCLCompatibleVersion() >=

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfae0dfa6421e: [Clang] Add __ibm128 type to represent ppc_fp128 (authored by qiucf). Changed prior to commit:

[clang] fae0dfa - [Clang] Add __ibm128 type to represent ppc_fp128

Author: Qiu Chaofan Date: 2021-09-06T18:00:58+08:00 New Revision: fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1 URL: https://github.com/llvm/llvm-project/commit/fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1 DIFF: https://github.com/llvm/llvm-project/commit/fae0dfa6421ea6c02f86ba7292fa782e1e2b69d1.diff

[PATCH] D108765: [docs] Fix documentation of clang-format BasedOnStyle type

MyDeveloperDay added a comment. Could you just rebase, I'm not getting a clean merge of ClangFormatStyleOptions.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108765/new/ https://reviews.llvm.org/D108765

[PATCH] D109002: [OpenCL] Supports optional image types in C++ for OpenCL 2021

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109002/new/ https://reviews.llvm.org/D109002 ___ cfe-commits mailing

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

karies added inline comments. Comment at: clang/unittests/Interpreter/ExceptionTests/CMakeLists.txt:2 +# The interpreter can throw an exception from user input. The test binary needs +# to be compiled with exception support to expect and catch the thrown +# exception.

[PATCH] D105462: [X86] Add CRC32 feature.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianqing marked an inline comment as done. Closed by commit rG12fa608af44a: [X86] Add CRC32 feature. (authored by tianqing). Changed prior to commit:

[clang] 12fa608 - [X86] Add CRC32 feature.

Author: Tianqing Wang Date: 2021-09-06T17:24:30+08:00 New Revision: 12fa608af44a80de8b655a8a984cd095908e7e80 URL: https://github.com/llvm/llvm-project/commit/12fa608af44a80de8b655a8a984cd095908e7e80 DIFF: https://github.com/llvm/llvm-project/commit/12fa608af44a80de8b655a8a984cd095908e7e80.diff

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

Hahnfeld added a comment. In D107049#2984835 , @v.g.vassilev wrote: > It looks like we hit https://bugs.llvm.org/show_bug.cgi?id=49692 I agree. Unfortunately, as described in the report, this is something that needs to be fixed on Apples side first.

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Topotuna marked an inline comment as done. Closed by commit rGcc9260a0fb7c: [OpenCL] Supports optional generic address space semantics in C++ for OpenCL… (authored by

[clang] cc9260a - [OpenCL] Supports optional generic address space semantics in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-06T10:20:38+01:00 New Revision: cc9260a0fb7c42ac8a8bb87eac1e11900c25ed20 URL: https://github.com/llvm/llvm-project/commit/cc9260a0fb7c42ac8a8bb87eac1e11900c25ed20 DIFF:

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added subscribers: karies, Hahnfeld. v.g.vassilev added a comment. In D107049#2982224 , @thakis wrote: > Thanks for fixing! Intel macs are happy now. > > But the test is still failing on arm macs: > http://45.33.8.238/macm1/17292/step_7.txt

[PATCH] D108556: [clangd] Don't highlight ObjC `id` and `instancetype`

kadircet added a comment. thanks, this looks great! just a question about the extra handling Comment at: clang-tools-extra/clangd/FindTarget.cpp:100 + // Even though ObjC `id` and `instancetype` are *implemented* via typedefs, we + // don't want to treat them like typedefs

[PATCH] D109210: [clang-tidy] Attach fixit to warning, not note, in add_new_check.py example

whisperity added a comment. @mattbeardsley Thank you for the explanation. (I'd wager some of your observations could even be added to some developer docs that's versioned in the repo. ) I'm not opposed to the changes at all. And indeed, it looks like `Note`s are really an advanced feature.

[PATCH] D108366: [clang][deps] Make resource directory deduction configurable

jansvoboda11 added a comment. @dexonsmith I have incorporated your suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/ https://reviews.llvm.org/D108366 ___ cfe-commits mailing list

[PATCH] D108461: [OpenCL] Supports optional generic address space sematics in C++ for OpenCL 2021

Topotuna marked an inline comment as done. Topotuna added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:413 OpenCLFeaturesMap, "__opencl_c_generic_address_space"); - Opts.OpenCLPipes = - hasFeatureEnabled(OpenCLFeaturesMap,

[PATCH] D109307: [OpenCL] Supports optional same image reads and writes in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Herald added a reviewer: aaron.ballman. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature

[PATCH] D109306: [OpenCL] Supports optional pipe types in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for a feature macro `__opencl_c_pipes` in C++ for OpenCL

[PATCH] D109305: [OpenCL] Supports optional program scope global variables in C++ for OpenCL 2021

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for macro `__opencl_c_program_scope_global_variables` in

[PATCH] D108366: [clang][deps] Deduce resource directory from the compiler path

jansvoboda11 updated this revision to Diff 370851. jansvoboda11 added a comment. Herald added a subscriber: ormris. Rebase on top of D108979 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108366/new/

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRDevices.td:515 +def : Device<"attiny1614", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny416", FamilyXMEGA, ELFArchXMEGA3>; +def : Device<"attiny816", FamilyXMEGA, ELFArchXMEGA3>;

[PATCH] D103136: [AVR] Add support for the tinyAVR 0-series and tinyAVR 1-seriesø

benshi001 added a reviewer: benshi001. benshi001 added a comment. I though the test clang/test/Misc/target-invalid-cpu-note.c should also be updated. BTW: What info (especially name and email) would like to see in the commit message ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e158363 - [clang-nvlink-wrapper] Add documentation in clang docs

Author: Saiyedul Islam Date: 2021-09-06T11:43:58+05:30 New Revision: e15836361cdfeb3a717a2ebae94c68286111369b URL: https://github.com/llvm/llvm-project/commit/e15836361cdfeb3a717a2ebae94c68286111369b DIFF:

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe15836361cdf: [clang-nvlink-wrapper] Add documentation in clang docs (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE