[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

aminya added a comment. I just hit this bug in my code where the subtraction of two size_t values resulted in a very large value. Fortunately, the address sanitizer immediately alerted me about the issue. It would be great to have such a warning in clang-tidy. Repository: rG LLVM Github

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

MaskRay added a subscriber: dim. MaskRay added a comment. In D111863#3072023 , @housel wrote: > It's also worth noting that FreeBSD's version of libgcc exception handling is > actually based on the libunwind code, with a local patch >

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. It's also worth noting that FreeBSD's version of libgcc exception handling is actually based on the libunwind code, with a local patch that implements compatibility with

[PATCH] D111692: [RISCV] Remove Zvamo C intrinsics and builtins.

craig.topper updated this revision to Diff 380587. craig.topper added a comment. Reduce scope since RISCVISAInfo landed. We need more changes to MC tests if we we remove Zvamo from RISCVISAInfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112028: [RISCV] Remove the HasSideEffects property from riscv_vector.td

This revision was automatically updated to reflect the committed changes. Closed by commit rG39a1fcb9cf59: [RISCV] Remove the HasSideEffects property from riscv_vector.td (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D112028?vs=380496=380583#toc Repository:

[clang] 39a1fcb - [RISCV] Remove the HasSideEffects property from riscv_vector.td

Author: Craig Topper Date: 2021-10-18T21:35:13-07:00 New Revision: 39a1fcb9cf5930eb3931ed0f9b8ef2f50dae4aa5 URL: https://github.com/llvm/llvm-project/commit/39a1fcb9cf5930eb3931ed0f9b8ef2f50dae4aa5 DIFF: https://github.com/llvm/llvm-project/commit/39a1fcb9cf5930eb3931ed0f9b8ef2f50dae4aa5.diff

[PATCH] D111923: [RISCV] Split RISCV vector builtins into their own file and namespace.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34173330bb3f: [RISCV] Split RISCV vector builtins into their own file and namespace. (authored by craig.topper). Repository: rG LLVM Github

[clang] 3417333 - [RISCV] Split RISCV vector builtins into their own file and namespace.

Author: Craig Topper Date: 2021-10-18T21:26:18-07:00 New Revision: 34173330bb3f372df0a0d7fd6b639a9812cf77bb URL: https://github.com/llvm/llvm-project/commit/34173330bb3f372df0a0d7fd6b639a9812cf77bb DIFF: https://github.com/llvm/llvm-project/commit/34173330bb3f372df0a0d7fd6b639a9812cf77bb.diff

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 380581. hliao added a comment. Fix formatting again following clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files:

[PATCH] D112053: [cuda] Add address space predicate funuctions.

hliao added a comment. With this patch, the following code could be compiled into the same PTX as NVCC. Check https://godbolt.org/z/q6EYE1q1o for the difference between NVCC and the current Clang output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112053: [cuda] Add address space predicate funuctions.

hliao created this revision. hliao added a reviewer: tra. Herald added subscribers: yaxunl, jholewinski. hliao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add the missing NVVM predicate builtins on address space checking - Redefine

[PATCH] D91815: Fix small typo in Block ABI docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94bc9d81bfc: Fix small typo in Block ABI docs (authored by dmaclach, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] a94bc9d - Fix small typo in Block ABI docs

Author: Dave MacLachlan Date: 2021-10-19T09:33:35+05:30 New Revision: a94bc9d81bfce2c697494431b4524fcee90a26cf URL: https://github.com/llvm/llvm-project/commit/a94bc9d81bfce2c697494431b4524fcee90a26cf DIFF:

[PATCH] D111529: Specify Clang vector builtins.

kito-cheng added inline comments. Comment at: clang/docs/LanguageExtensions.rst:579 + NaNs, fmax() return a NaN. + ET __builtin_reduce_add(VT a) \+ integer and

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao updated this revision to Diff 380574. hliao added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112041/new/ https://reviews.llvm.org/D112041 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll

[PATCH] D112050: [clang] NFC: return void in an alternative expression after call to void function.

zhouyizhou created this revision. zhouyizhou added a reviewer: clang. zhouyizhou requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is better to return void in an alternative expression after call to void function. Also, I processed

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson created this revision. mhjacobson added reviewers: rjmccall, ddunbar. Herald added subscribers: Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On targets where `ptrdiff_t` is smaller than `long`,

[PATCH] D111692: [RISCV] Remove Zvamo C intrinsics and builtins.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. Zvamo is not a part of standard V extension in the current stage. I am fine to remove it in the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111923: [RISCV] Split RISCV vector builtins into their own file and namespace.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111923/new/ https://reviews.llvm.org/D111923

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe678c5117710: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library (authored by noajshu, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e678c51 - [Support][ThinLTO] Move ThinLTO caching to LLVM Support library

Author: Noah Shutty Date: 2021-10-18T18:57:25-07:00 New Revision: e678c51177102845c93529d457b020f969125373 URL: https://github.com/llvm/llvm-project/commit/e678c51177102845c93529d457b020f969125373 DIFF: https://github.com/llvm/llvm-project/commit/e678c51177102845c93529d457b020f969125373.diff

[PATCH] D112028: [RISCV] Remove the HasSideEffects property from riscv_vector.td

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112028/new/ https://reviews.llvm.org/D112028

[PATCH] D111273: [clang-format-diff] Fix missing formatting for zero length git diff lines

lhames added a comment. Heads up -- I think I just hit an error due to this while formatting a local commit: % ./clang/tools/clang-format/git-clang-format HEAD~1 Assertion failed: (Line &&

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380554. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74531/new/ https://reviews.llvm.org/D74531 Files: clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp clang/test/PCH/pch-wasm.c

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380551. kateinoigakukun added a comment. Thank you for taking a look again. OK, I extracted `writeStringWithAlignment` and updated comment lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112041: [InferAddressSpaces] Support assumed addrspaces from addrspace predicates.

hliao created this revision. hliao added reviewers: tra, yaxunl, arsenm, rampitec. Herald added subscribers: jeroen.dobbelaere, ormris, foad, wenlei, bmahjour, kerbowa, asbirlea, rogfer01, steven_wu, george.burgess.iv, zzheng, hiraditya, nhaehnle, jvesely, jholewinski. hliao requested review of

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

lhames added a comment. In D111863#3071353 , @joerg wrote: > I would strongly prefer if ORCv2 doesn't depend on this. It essentially > forces libunwind to parse the whole section just to find the delimiters of > the FDEs. That's a lot of unnecessary

[clang] cb5a101 - [test] Remove tests pinned to the legacy PM

Author: Arthur Eubanks Date: 2021-10-18T16:40:46-07:00 New Revision: cb5a10199b32b5e1104ed36a490be73fa3bdf5ca URL: https://github.com/llvm/llvm-project/commit/cb5a10199b32b5e1104ed36a490be73fa3bdf5ca DIFF:

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian updated this revision to Diff 380542. ngzhian added a comment. Add title for relaxed swizzle instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112022/new/ https://reviews.llvm.org/D112022 Files:

[clang] 684b626 - [RISCV][TableGen] Remove HasMaskedOffOperand as a member of RVVIntrinsic. NFC

Author: Craig Topper Date: 2021-10-18T15:56:37-07:00 New Revision: 684b6265b31cabf422b01cd8937a3641c6df914f URL: https://github.com/llvm/llvm-project/commit/684b6265b31cabf422b01cd8937a3641c6df914f DIFF: https://github.com/llvm/llvm-project/commit/684b6265b31cabf422b01cd8937a3641c6df914f.diff

[PATCH] D111471: [NVPTX] Add a late SROA pass which allows optimizing away more allocas.

tra updated this revision to Diff 380538. tra added a comment. The test uses llc only now. Opt is not affected by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111471/new/ https://reviews.llvm.org/D111471 Files:

[clang] 0567f03 - [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

Author: Anshil Gandhi Date: 2021-10-18T16:53:15-06:00 New Revision: 0567f0333176e476e15b7f32b463f58f7475ff22 URL: https://github.com/llvm/llvm-project/commit/0567f0333176e476e15b7f32b463f58f7475ff22 DIFF: https://github.com/llvm/llvm-project/commit/0567f0333176e476e15b7f32b463f58f7475ff22.diff

[clang] b477b92 - [RISCV] Fix typo in comment. NFC

Author: Craig Topper Date: 2021-10-18T15:45:35-07:00 New Revision: b477b927749707982414d06674c7d2af276e046c URL: https://github.com/llvm/llvm-project/commit/b477b927749707982414d06674c7d2af276e046c DIFF: https://github.com/llvm/llvm-project/commit/b477b927749707982414d06674c7d2af276e046c.diff

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 380527. noajshu added a comment. Migrate references to Caching.cpp from llvm/utils/gn/secondary/llvm/lib/LTO/BUILD.gn to [...]/Support/BUILD.gn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/

[PATCH] D111471: [NVPTX] Add a late SROA pass which allows optimizing away more allocas.

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111471/new/ https://reviews.llvm.org/D111471

[PATCH] D111471: [NVPTX] Add a late SROA pass which allows optimizing away more allocas.

tra updated this revision to Diff 380524. tra added a comment. Moved the test to LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111471/new/ https://reviews.llvm.org/D111471 Files: llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

ASDenysPetrov updated this revision to Diff 380518. ASDenysPetrov added a comment. Rebased on top of D106681 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111542/new/ https://reviews.llvm.org/D111542 Files:

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks added a comment. In D84#3071422 , @dblaikie wrote: > Is there no diagnostic that could reasonably produce such a large value that > would be easy to test (without needing a giant binary, etc)? (seem surprising > to see this change without

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

dblaikie added a comment. Is there no diagnostic that could reasonably produce such a large value that would be easy to test (without needing a giant binary, etc)? (seem surprising to see this change without any test coverage) Like a 64 bit non-type template parameter or the like, perhaps?

[PATCH] D112032: [RISCV] Use a lambda to avoid having the Support library depend on Option library.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1053e0b27ce1: [RISCV] Use a lambda to avoid having the Support library depend on Option… (authored by craig.topper). Repository: rG LLVM Github

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru added a comment. I am using them but I can move to sphinx calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___ cfe-commits mailing list

[clang] 1053e0b - [RISCV] Use a lambda to avoid having the Support library depend on Option library.

Author: Craig Topper Date: 2021-10-18T13:39:37-07:00 New Revision: 1053e0b27ce135ce2da63af01aa986b9425386ee URL: https://github.com/llvm/llvm-project/commit/1053e0b27ce135ce2da63af01aa986b9425386ee DIFF: https://github.com/llvm/llvm-project/commit/1053e0b27ce135ce2da63af01aa986b9425386ee.diff

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added a comment. In D105168#3071330 , @jrtc27 wrote: > In D105168#3071321 , @craig.topper > wrote: > >> In D105168#3071249 , @jrtc27 wrote: >> >>> Two

[PATCH] D112032: [RISCV] Use a lambda to avoid having the Support library depend on Option library.

craig.topper created this revision. craig.topper added reviewers: jrtc27, kito-cheng, HsiangKai, khchen, arcbbb. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX,

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

steven_wu added a comment. In D111863#3071328 , @housel wrote: > In D111863#3069279 , @lhames wrote: > >> I think the ORC runtime provides a much more natural way to test this. Did >> you manage to come up with

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers added a comment. Also reported here: https://lore.kernel.org/llvm/1817774243.12566.1634255267713@localhost/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111009/new/ https://reviews.llvm.org/D111009

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

joerg added a comment. I would strongly prefer if ORCv2 doesn't depend on this. It essentially forces libunwind to parse the whole section just to find the delimiters of the FDEs. That's a lot of unnecessary work as JIT use normally allows registering functions individually. Repository: rG

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

jrtc27 added a comment. In D105168#3071321 , @craig.topper wrote: > In D105168#3071249 , @jrtc27 wrote: > >> Two options come to mind if we really need to be outputting a StringRef list: >> >> 1. (the simpler

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

housel added a comment. In D111863#3069279 , @lhames wrote: > I think the ORC runtime provides a much more natural way to test this. Did > you manage to come up with some ORC-runtime based tests in the end? My current plan is to automate what I've been

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added a comment. In D105168#3071249 , @jrtc27 wrote: > Two options come to mind if we really need to be outputting a StringRef list: > > 1. (the simpler option) Pass in a Twine -> `const char *` lambda that the > caller hooks up to

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, 18 Oct 2021 at 12:56, Aaron Ballman wrote: > On Mon, Oct 18, 2021 at 3:52 PM Richard Smith > wrote: > > > > On Mon, 18 Oct 2021 at 12:48, Aaron Ballman > wrote: > >> > >> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith > wrote: > >> > > >> > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman

[PATCH] D112030: [docs] Remove Makefile.sphinx files

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. We don't use them in libc++, fine by me to remove if the website documentation builders don't use them (IDK how that's set up). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112030: [docs] Remove Makefile.sphinx files

tstellar created this revision. tstellar added reviewers: sylvestre.ledru, pcc, silvas. tstellar requested review of this revision. Herald added projects: clang, libc++, LLVM. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Does anyone still use these? I

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 18, 2021 at 3:52 PM Richard Smith wrote: > > On Mon, 18 Oct 2021 at 12:48, Aaron Ballman wrote: >> >> On Mon, Oct 18, 2021 at 3:33 PM Richard Smith wrote: >> > >> > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits >> > wrote: >> >> >> >> >> >> Author: Aaron Ballman >>

[PATCH] D111529: Specify Clang vector builtins.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:557 +``i in [0, Number of elements / 2)``. If the numbers of elements is not a +power of 2, the vector is widening with neutral elements for the reduction +at the

[PATCH] D111529: Specify Clang vector builtins.

fhahn updated this revision to Diff 380500. fhahn marked an inline comment as done. fhahn added a comment. Fix wording: widening -> widened, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/ https://reviews.llvm.org/D111529 Files:

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, 18 Oct 2021 at 12:48, Aaron Ballman wrote: > On Mon, Oct 18, 2021 at 3:33 PM Richard Smith > wrote: > > > > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> > >> Author: Aaron Ballman > >> Date: 2021-10-17T07:54:48-04:00 > >>

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

jrtc27 added a comment. Two options come to mind if we really need to be outputting a StringRef: 1. (the simpler option) Pass in a Twine -> `const char *` lambda that the caller hooks up to Args.MakeArgString 2. (probably the nicer option) Invent our own MakeArgString that allocates from

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Mon, Oct 18, 2021 at 3:33 PM Richard Smith wrote: > > On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits > wrote: >> >> >> Author: Aaron Ballman >> Date: 2021-10-17T07:54:48-04:00 >> New Revision: 2edb89c746848c52964537268bf03e7906bf2542 >> >> URL: >>

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

teemperor added a comment. In D105168#3071152 , @craig.topper wrote: > In D105168#3069499 , @teemperor > wrote: > >> This broke the modules build: >> >> While building module 'LLVM_Utils' imported from >>

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 380498. noajshu added a comment. Update references to LTO/Caching in Gold plugin and Clang docs; rebase against main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371

Re: [clang] 2edb89c - Lex arguments for __has_cpp_attribute and friends as expanded tokens

On Sun, 17 Oct 2021 at 04:58, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2021-10-17T07:54:48-04:00 > New Revision: 2edb89c746848c52964537268bf03e7906bf2542 > > URL: >

[PATCH] D112028: [RISCV] Remove the HasSideEffects property from riscv_vector.td

craig.topper created this revision. craig.topper added reviewers: HsiangKai, kito-cheng, arcbbb, khchen. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[clang] 8e46e34 - Revert "[Support][ThinLTO] Move ThinLTO caching to LLVM Support library"

Author: Petr Hosek Date: 2021-10-18T12:24:05-07:00 New Revision: 8e46e34d243524b9a1f9487718ea60e990b35fa3 URL: https://github.com/llvm/llvm-project/commit/8e46e34d243524b9a1f9487718ea60e990b35fa3 DIFF: https://github.com/llvm/llvm-project/commit/8e46e34d243524b9a1f9487718ea60e990b35fa3.diff

[PATCH] D111009: Update inline builtin handling to honor gnu inline attribute

nickdesaulniers added a comment. See also: https://github.com/ClangBuiltLinux/linux/issues/1477. Surprising that this didn't show up in newer kernels, just older (but still supported) kernel versions. Sorry I missed that in my tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 92b8cc5 - [Support][ThinLTO] Move ThinLTO caching to LLVM Support library

Author: Noah Shutty Date: 2021-10-18T12:08:49-07:00 New Revision: 92b8cc52bbc8194f2cd6a5f742b874969421afca URL: https://github.com/llvm/llvm-project/commit/92b8cc52bbc8194f2cd6a5f742b874969421afca DIFF: https://github.com/llvm/llvm-project/commit/92b8cc52bbc8194f2cd6a5f742b874969421afca.diff

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92b8cc52bbc8: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library (authored by noajshu, committed by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added a comment. In D105168#3069499 , @teemperor wrote: > This broke the modules build: > > While building module 'LLVM_Utils' imported from > lvm/lib/Support/TargetParser.cpp:14: > In file included from :209: >

[PATCH] D111986: [Clang] Add elementwise abs builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3109 + Result = Builder.CreateBinaryIntrinsic( + llvm::Intrinsic::abs, Op0, Builder.getFalse(), nullptr, "elt.abs"); +else craig.topper wrote: > Did we discuss that

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) craig.topper wrote: >

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 380486. fhahn added a comment. Remove stray `!TyA->getAs()` check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D111529: Specify Clang vector builtins.

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:557 +``i in [0, Number of elements / 2)``. If the numbers of elements is not a +power of 2, the vector is widening with neutral elements for the reduction +at the end to the next power of 2.

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield created this revision. mbenfield added a reviewer: george.burgess.iv. Herald added a reviewer: aaron.ballman. mbenfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 5b949a6 - Fix crash when diagnosing a CTAD failure in an array new expression

Author: Aaron Ballman Date: 2021-10-18T14:01:55-04:00 New Revision: 5b949a649aff0406a878e8eb8d7d5efba0a55e4a URL: https://github.com/llvm/llvm-project/commit/5b949a649aff0406a878e8eb8d7d5efba0a55e4a DIFF: https://github.com/llvm/llvm-project/commit/5b949a649aff0406a878e8eb8d7d5efba0a55e4a.diff

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1365 + +def wasm_relaxed_swizzle : SDNode<"WebAssemblyISD::RELAXED_SWIZZLE", wasm_swizzle_t>; + @tlively i'm not 100% sure if this is needed or the right thing to do,

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D112020: [RISCV] Use clang_builtin_alias for all RISCV vector intrinsics.

craig.topper created this revision. craig.topper added reviewers: khchen, arcbbb, kito-cheng, HsiangKai, evandro. Herald added subscribers: achieveartificialintelligence, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, krasimir. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. clang-format `AlignConsecutiveMacros` feature causes real problems when using Win32

[PATCH] D111986: [Clang] Add elementwise abs builtin.

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3109 + Result = Builder.CreateBinaryIntrinsic( + llvm::Intrinsic::abs, Op0, Builder.getFalse(), nullptr, "elt.abs"); +else Did we discuss that this is different

[clang] 2e4e200 - Fix a comment in SemaSYCL to make sure I can commit

Author: Erich Keane Date: 2021-10-18T10:12:28-07:00 New Revision: 2e4e2004afc51303bbb8836e886363f2056d73eb URL: https://github.com/llvm/llvm-project/commit/2e4e2004afc51303bbb8836e886363f2056d73eb DIFF: https://github.com/llvm/llvm-project/commit/2e4e2004afc51303bbb8836e886363f2056d73eb.diff

[PATCH] D112001: [Clang] Add min/max reduction builtins.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) Is this indented incorrectly? There appear to be 2 ifs

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

steven_wu added a comment. I don't know enough about Dwarf unwinding but the implementation looks generally good. Can you please add a testcase indicating how ORCJIT is planning to use it? Comment at: libunwind/src/DwarfParser.hpp:158 + FDE_Info

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Config.h:89 /// Controls warnings and errors when parsing code. + enum IncludeCleanerPolicy { UnusedHeaders, None }; you've accidentally split this comment from its decl

[PATCH] D111975: [clang-format] [PR52015] clang-format should put __attribute__((foo)) on its own line before @interface / @implementation / @protocol

benhamilton accepted this revision. benhamilton added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111975/new/ https://reviews.llvm.org/D111975 ___ cfe-commits mailing list

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

steakhal marked 3 inline comments as done. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289 + /// E.g. { "std", "vector", "data" } -> "vector", "std" + auto begin_qualified_name_parts() const { +return

[PATCH] D106681: [analyzer][NFC] Move a block from `getBindingForElement` to separate functions

ASDenysPetrov updated this revision to Diff 380441. ASDenysPetrov retitled this revision from "[analyzer] Retrieve a value from list initialization of constant multi-dimensional array." to "[analyzer][NFC] Move a block from `getBindingForElement` to separate functions". ASDenysPetrov edited the

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

sbc100 added inline comments. Comment at: llvm/lib/MC/WasmObjectWriter.cpp:374 + // Custom sections in wasm also have a string identifier with extra paddings + // for alignment for special sections. + // TODO: support section alignment at asm and llvm level?

[PATCH] D112013: [clang][ASTImporter] Fix for importing functions with EST_Unevaluated prototype.

balazske created this revision. Herald added subscribers: steakhal, whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a

[clang] 1fb24fe - Reland [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

Author: Arthur Eubanks Date: 2021-10-18T09:08:16-07:00 New Revision: 1fb24fe85a19ae71b00875ff6c96ef1831dcf7e3 URL: https://github.com/llvm/llvm-project/commit/1fb24fe85a19ae71b00875ff6c96ef1831dcf7e3 DIFF:

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380436. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index:

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier added a comment. **Note**: manually tested the two scripts; - For `clang-tidy-diff.py` git diff -U0 --no-prefix --no-color $(git merge-base origin/master HEAD)..HEAD \ | ~/git/llvm-project/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py -quiet -clang-tidy-binary

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

whisperity added a comment. In D111909#3070593 , @schrc3b6 wrote: > I guess you don't want that to be cought if it is actually a tentative > definition. If I remember correctly for clang and gcc -fno-common is the > default. > I think we could do one

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380431. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index:

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier updated this revision to Diff 380429. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112008/new/ https://reviews.llvm.org/D112008 Files: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index:

[PATCH] D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code

schrc3b6 added a comment. In D111909#3069668 , @whisperity wrote: > Will `int I;` being in a header, with no initialiser, be caught? Currently it will be caught. 1 warning generated. ./foo.h:1:5: warning: variable 'i' defined in a header file;

[PATCH] D111534: [analyzer][NFC] Refactor CallEvent::isCalled()

ASDenysPetrov added a comment. Thank you for adding me. I'll make a deeper review later. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1289 + /// E.g. { "std", "vector", "data" } -> "vector", "std" + auto begin_qualified_name_parts() const {

[PATCH] D111870: [clangd] Add a way to enable IncludeCleaner through config

kbobyrev updated this revision to Diff 380426. kbobyrev added a comment. Fix the warning range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111870/new/ https://reviews.llvm.org/D111870 Files: clang-tools-extra/clangd/Config.h

[PATCH] D112008: Add -extra-arg-clang-tidy to {clang-tidy-diff,run-clang-tidy}.py

Xavier created this revision. Xavier added a reviewer: alexfh. Xavier added a project: clang-tools-extra. Xavier requested review of this revision. Herald added a subscriber: cfe-commits. This small patch adds a new `-extra-arg-clang-tidy` option to clang-tidy-diff and run-clang-tidy scripts.

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks added a comment. In D111973#3070519 , @aeubanks wrote: > In D111973#3069304 , @dblaikie > wrote: > >> Could you check some of the stats output is valid/expected, not just >> corrupt/garbage? "just

  1   2   >