[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 updated this revision to Diff 386749. jansvoboda11 added a comment. Add extra test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113676/new/ https://reviews.llvm.org/D113676 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks updated this revision to Diff 386748. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113738/new/ https://reviews.llvm.org/D113738 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/Config.h

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

zixuan-wu added a comment. Is this going to be reviewed again or committed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commits mailing list

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

zixuan-wu added a comment. In D8467#3125313 , @tstellar wrote: > In D8467#3095610 , @zixuan-wu wrote: > >> Hi, I am wondering could -fsized-deallocation this be enabled by default >> nowadays in 2021? > > Were you

[PATCH] D113738: [LTO] Allow passing -Os/-Oz as the optimization level

aeubanks created this revision. Herald added subscribers: ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, mgorny, emaste. Herald added a reviewer: MaskRay. Herald added a reviewer: gkm. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. aeubanks requested review

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:6713 } + unsigned Size = Is it not possible to check whether the category is empty here? If it's empty, you can avoid creating the global variable and abandon the builder.

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

phosek added a comment. This change seems to have broken two libc++ tests: libc++ :: std/utilities/any/any.nonmembers/any.cast/const_correctness.fail.cpp Script: -- : 'COMPILED WITH'; /b/s/w/ir/x/w/staging/llvm_build/./bin/clang++

[PATCH] D112903: [C++20] [Module] Fix bug47716 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 386730. ChuanqiXu added a comment. Remove dead codes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112903/new/ https://reviews.llvm.org/D112903 Files: clang/include/clang/AST/DeclBase.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D111477: DO NOT SUBMIT: workaround for context-sensitive use of non-type-template-parameter integer suffixes

dblaikie added a comment. Renamed in 6512098877c3a230bbd38bc81b14a4e5844739ff to `AlwaysIncludeTypeForTemplateArgument` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 6512098 - DebugInfo/Printing: Improve name of policy for including types for template arguments

Author: David Blaikie Date: 2021-11-11T21:59:27-08:00 New Revision: 6512098877c3a230bbd38bc81b14a4e5844739ff URL: https://github.com/llvm/llvm-project/commit/6512098877c3a230bbd38bc81b14a4e5844739ff DIFF: https://github.com/llvm/llvm-project/commit/6512098877c3a230bbd38bc81b14a4e5844739ff.diff

[PATCH] D112903: [C++20] [Module] Fix bug47716 and implement [module.interface]/p6

ChuanqiXu marked 3 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/test/CXX/module/module.interface/p2-2.cpp:1 +// The intention of this file to check we could only export declarations in namesapce scope. +// I move them here since

[PATCH] D112903: [C++20] [Module] Fix bug47716 and implement [module.interface]/p6

ChuanqiXu updated this revision to Diff 386728. ChuanqiXu retitled this revision from "[C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared" to "[C++20] [Module] Fix bug47716 and implement [module.interface]/p6". ChuanqiXu edited the summary

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD added a comment. ping, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. Any further feedback on the latest iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list

[PATCH] D113729: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8df26e7b4aea: [Fuchsia][CMake] Dont set libcxxabi and libunwind variables on Windows (authored by phosek). Repository: rG LLVM Github Monorepo

[clang] 8df26e7 - [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows

Author: Petr Hosek Date: 2021-11-11T19:29:39-08:00 New Revision: 8df26e7b4aeaad0b1777c6909db7b14fec347880 URL: https://github.com/llvm/llvm-project/commit/8df26e7b4aeaad0b1777c6909db7b14fec347880 DIFF: https://github.com/llvm/llvm-project/commit/8df26e7b4aeaad0b1777c6909db7b14fec347880.diff

[PATCH] D113729: [Fuchsia][CMake] Don't set libcxxabi and libunwind variables on Windows

phosek created this revision. phosek added a reviewer: haowei. Herald added subscribers: abrachet, mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't build libcxxabi and libunwind for Windows so don't set the

[PATCH] D51650: Implement target_clones multiversioning

jgorbe added a comment. This breaks some existing code (we have found this issue building the JPEG XL library at github.com/libjxl). This is a very simplified version of the problem: #pragma clang attribute push(__attribute__((target("sse2,ssse3"))), apply_to = function)

[PATCH] D106585: Fix clang debug info irgen of i128 enums

glandium added a comment. In D106585#3125280 , @rnk wrote: > In D106585#3122726 , @glandium > wrote: > >> It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 >>

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

jkorous accepted this revision. jkorous added a comment. LGTM if we have test coverage for all the cases. Comment at: clang/test/CodeGenObjC/category-class-empty.m:1 +// RUN: %clang_cc1 -triple i386-apple-darwin9 -O3 -emit-llvm -o - %s | FileCheck %s +// PR7431

[clang] 98f80d2 - [Driver] Fix unused variable warning in release builds. NFC.

Author: Benjamin Kramer Date: 2021-11-12T00:20:21+01:00 New Revision: 98f80d248d9c888c2219454c1f655bc324b80cdc URL: https://github.com/llvm/llvm-project/commit/98f80d248d9c888c2219454c1f655bc324b80cdc DIFF:

[PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:559 + // Get the resolved template arguments from the canonical type. + // FIXME: Handle the as-written arguments so the sugar is not lost. +

[PATCH] D113718: Don't append the working directory to absolute paths

aprantl created this revision. aprantl added reviewers: dblaikie, rastogishubham, kastiglione. aprantl added a project: debug-info. aprantl requested review of this revision. This fixes a bug that happens when using -fdebug-prefix-map to remap an absolute path to a relative path. Since the path

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

smekkley added a comment. Herald added a project: clang-tools-extra. For what it's worth, outgoing call is useful for looking at grand children and jump immediately. Also, clangd doesn't runs on embedded devices, so extra memory allocation isn't a concern at all for most users. @sammccall which

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

andrew.w.kaylor closed this revision. andrew.w.kaylor added a comment. Closed by commit by rGf04e387055e495e3e14570087d68e93593cf2918 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG0309e50f33f6: [Driver] Fix ToolChain::getSanitizerArgs (authored by yaxunl). Herald added a project: clang.

[clang] 0309e50 - [Driver] Fix ToolChain::getSanitizerArgs

Author: Yaxun (Sam) Liu Date: 2021-11-11T17:17:08-05:00 New Revision: 0309e50f33f616baa8fcac8365b728be3ccf06dd URL: https://github.com/llvm/llvm-project/commit/0309e50f33f616baa8fcac8365b728be3ccf06dd DIFF:

[PATCH] D113455: [clang][objc][codegen] Skip emitting ObjC category metadata when the category is empty

zoecarver accepted this revision. zoecarver added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:6683 + values.add(classMethodList); + isEmptyCategory &= + instanceMethodList->isNullValue() &&

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

leoetlino updated this revision to Diff 386642. leoetlino added a comment. fix formatting issues (sorry for the spam!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 Files:

[PATCH] D87858: [hip] Add HIP scope atomic ops.

hliao added a comment. In D87858#3125630 , @yaxunl wrote: > Hi Michael, would you like to continue working on this, or let someone from > AMD to take over? Thanks. please take over it. I will abandon it so that you could start it over. Repository:

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

rnk added a comment. This seems reasonable, but I worry about headers that contain AT style inline asm blobs, such as clang's own intrinsic headers. As you say, the directive is local. I would hate to end up in a place where we have to prefix every asm blob in clang/lib/Headers/*mmintrin.h

[PATCH] D87858: [hip] Add HIP scope atomic ops.

yaxunl added a comment. Hi Michael, would you like to continue working on this, or let someone from AMD to take over? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87858/new/ https://reviews.llvm.org/D87858

[PATCH] D113709: Don't consider `LinkageSpec` when calculating DeclContext `Encloses`

erichkeane created this revision. erichkeane added reviewers: hubert.reinterpretcast, rsmith, aaron.ballman, rjmccall. erichkeane requested review of this revision. We don't properly handle lookup through using declarations when there is a linkage spec in the common chain. This is because

[PATCH] D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers

fwolff created this revision. fwolff added reviewers: alexfh, carlosgalvezp. fwolff added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#38187. Constructors are actually already

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 ___ cfe-commits mailing list

[PATCH] D113707: [clang] Make -masm=intel affect inline asm style

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: dexonsmith, dang. thakis requested review of this revision. With this, void f() { __asm__("mov eax, ebx"); } now compiles with clang with -masm=intel. This matches gcc. The flag is not accepted in

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

rjmccall added a comment. In D8467#3125471 , @rnk wrote: > In D8467#3125386 , @rjmccall wrote: > >> Conceptually, this is (and will always be) a platform decision. On Apple >> platforms, we have a formalized

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield updated this revision to Diff 386623. mbenfield added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024 Files: clang/include/clang/Basic/Attr.td

[PATCH] D112024: [clang] diagnose_as attribute for Fortify diagnosing like builtins.

mbenfield added a comment. Would @george.burgess.iv and/or @aaron.ballman mind taking another look at the latest revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112024/new/ https://reviews.llvm.org/D112024

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

leoetlino updated this revision to Diff 386622. leoetlino added a comment. Fix Clang.CodeGenCXX::mangle-class-nttp.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 Files:

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:374 { PositiveSelfInitialization() : PositiveSelfInitialization() {} }; carlosgalvezp wrote: > fwolff wrote: > > carlosgalvezp

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff updated this revision to Diff 386620. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 Files: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp clang/lib/Sema/SemaDeclCXX.cpp Index:

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

rnk added a comment. In D8467#3125386 , @rjmccall wrote: > Conceptually, this is (and will always be) a platform decision. On Apple > platforms, we have a formalized concept of deployment target, where specific > minimum OS versions support sized

[PATCH] D108567: Implement #pragma clang final extension

beanz added a comment. In D108567#3110925 , @sberg wrote: > does not produce any warnings/errors for me and indicates that NULL silently > gets redefined as a null pointer constant in stddef.h. Is that intended? Nope, that's a bug. Fixed in

[clang] 3e7ad1f - Emit final macro diagnostics in system headers

Author: Chris Bieneman Date: 2021-11-11T13:51:26-06:00 New Revision: 3e7ad1f2b2c0a753749eaba88d369d6032a50764 URL: https://github.com/llvm/llvm-project/commit/3e7ad1f2b2c0a753749eaba88d369d6032a50764 DIFF:

[PATCH] D112914: Misleading identifier detection

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-misleading-identifier.rst:12 + +.. code-block:: c + aaronpuchert wrote: > Sphinx can't parse that (perhaps unsurprisingly), could you declare that as > having no

[clang-tools-extra] ac8c813 - Fix Sphinx build diagnostics

Author: Aaron Ballman Date: 2021-11-11T14:38:11-05:00 New Revision: ac8c813b89f62efcaff4d0c92fdf1a5dd29d795d URL: https://github.com/llvm/llvm-project/commit/ac8c813b89f62efcaff4d0c92fdf1a5dd29d795d DIFF: https://github.com/llvm/llvm-project/commit/ac8c813b89f62efcaff4d0c92fdf1a5dd29d795d.diff

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

rjmccall added a comment. Conceptually, this is (and will always be) a platform decision. On Apple platforms, we have a formalized concept of deployment target, where specific minimum OS versions support sized deallocation and others do not. On most other platforms, this is much vaguer —

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Nice :) This looks pretty straightforward, but given how core this is, wait for another approver or two. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42 -template

[PATCH] D51650: Implement target_clones multiversioning

This revision was automatically updated to reflect the committed changes. Closed by commit rG9deab60ae710: Implement target_clones multiversioning (authored by erichkeane). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D51650?vs=386573=386597#toc Repository:

[clang] 9deab60 - Implement target_clones multiversioning

Author: Erich Keane Date: 2021-11-11T11:11:16-08:00 New Revision: 9deab60ae710f8c4cc810cd680edfb64c803f42d URL: https://github.com/llvm/llvm-project/commit/9deab60ae710f8c4cc810cd680edfb64c803f42d DIFF: https://github.com/llvm/llvm-project/commit/9deab60ae710f8c4cc810cd680edfb64c803f42d.diff

[PATCH] D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG42102bce98e5: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 42102bc - [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support.

Author: Steven Wan Date: 2021-11-11T14:10:42-05:00 New Revision: 42102bce98e527f994a7bc68b2255d9e0462f6eb URL: https://github.com/llvm/llvm-project/commit/42102bce98e527f994a7bc68b2255d9e0462f6eb DIFF: https://github.com/llvm/llvm-project/commit/42102bce98e527f994a7bc68b2255d9e0462f6eb.diff

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

tstellar added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Were you planning to work on this? Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 386594. ggeorgakoudis added a comment. Herald added subscribers: asavonic, ormris. Update tests Fix for attributes to kmpc_alloc_aggregate_arg Do not emit allocations if there are no arguments in the aggregate Repository: rG LLVM Github Monorepo

[PATCH] D106585: Fix clang debug info irgen of i128 enums

rnk added a subscriber: hans. rnk added a comment. In D106585#3122726 , @glandium wrote: > It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 > . Are you sure

[PATCH] D51650: Implement target_clones multiversioning

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a nit with naming/wording. Feel free to land without additional review (unless you want more review, of course!). Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9868-9869

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

fowles added a comment. That is awesome! Thanks for much for the examples. Everything here LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113575/new/ https://reviews.llvm.org/D113575 ___

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG8188484daa41: [clang-apply-replacements] Correctly handle relative paths (authored by avogelsgesang, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8188484 - [clang-apply-replacements] Correctly handle relative paths

Author: Adrian Vogelsgesang Date: 2021-11-11T18:28:43Z New Revision: 8188484daa4195a2c8b5253765036fa2c6da7263 URL: https://github.com/llvm/llvm-project/commit/8188484daa4195a2c8b5253765036fa2c6da7263 DIFF:

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

leoetlino created this revision. leoetlino requested review of this revision. Herald added a project: clang. C++17 changed the definition of literal types so that unions that have at least one non-static data member of non-volatile literal type are also considered literal types. This patch

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

jcking1034 marked an inline comment as done. jcking1034 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4224 +/// float z; +/// auto f = [=]() { return x + y + z; }; +/// } fowles wrote: > it would be nice to be able to

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

jcking1034 updated this revision to Diff 386577. jcking1034 added a comment. Add additional unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113575/new/ https://reviews.llvm.org/D113575 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 386573. erichkeane added a comment. added C++ tests this time, changed how dupes are diagnosed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/ https://reviews.llvm.org/D51650 Files: clang/include/clang/AST/Decl.h

[PATCH] D113691: Comment AST: Recognize function-like objects via return type

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of pretending that function pointer type aliases or variables are functions, and thereby

[PATCH] D113690: Comment AST: Find out if function is variadic in DeclInfo::fill

aaronpuchert created this revision. aaronpuchert added a reviewer: gribozavr2. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Then we don't have to look into the declaration again. Also it's only natural to collect this

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

ymandel added a comment. I can land it for you. should be sometime this afternoon, but ping me tomorrow if you don't see any activity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/ https://reviews.llvm.org/D112647

[PATCH] D112647: [clang-apply-replacements] Correctly handle relative paths

avogelsgesang added a comment. Thanks for the reviews, @ymandel and @hokein! What are the next steps to get this landed? (I am a first time contributor and have no commit access) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112647/new/

[PATCH] D51650: Implement target_clones multiversioning

aaron.ballman added a comment. In D51650#3124859 , @erichkeane wrote: > Did all the things Aaron asked for, but required adding 'lambda not supported > yet' logic for this. I don't see the .cpp test file, did it get dropped by accident? Also,

[PATCH] D51650: Implement target_clones multiversioning

erichkeane updated this revision to Diff 386542. erichkeane marked 5 inline comments as done. erichkeane added a comment. Did all the things Aaron asked for, but required adding 'lambda not supported yet' logic for this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51650/new/

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 updated this revision to Diff 386541. jansvoboda11 added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113676/new/ https://reviews.llvm.org/D113676 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

steakhal added inline comments. Comment at: clang/test/Analysis/initialization.cpp:295-299 +void glob_cast_opposite_sign1() { + auto *ptr = (unsigned int *)glob_arr2; + auto x1 = ptr[0]; // no-warning + auto x2 = ptr[1]; // expected-warning{{garbage or undefined}} +}

[PATCH] D113623: [OpenMP][FIX] Pass the num_threads value directly to parallel_51

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I think this should be the right direction. LGTM. @grokos WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113623/new/

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG893efd0d665b: [X86] Honor command line features along with cpu_specific attribute (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 893efd0 - [X86] Honor command line features along with cpu_specific attribute

Author: Craig Topper Date: 2021-11-11T09:06:22-08:00 New Revision: 893efd0d665becb3478c750b2b4d3751c20ff39d URL: https://github.com/llvm/llvm-project/commit/893efd0d665becb3478c750b2b4d3751c20ff39d DIFF: https://github.com/llvm/llvm-project/commit/893efd0d665becb3478c750b2b4d3751c20ff39d.diff

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

tianshilei1992 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3082 + if (getTriple().getVendor() == llvm::Triple::OpenMP_VGPU) { +std::string BitcodeSuffix = "x86_64-vgpu"; +clang::driver::tools::addOpenMPDeviceRTL(getDriver(), DriverArgs,

[PATCH] D113664: [cmake] use project relative paths when generating ASTNodeAPI.json

mizvekov created this revision. Herald added a subscriber: mgorny. mizvekov published this revision for review. mizvekov added reviewers: steveire, phosek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

craig.topper updated this revision to Diff 386524. craig.topper added a comment. Add test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113647/new/ https://reviews.llvm.org/D113647 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

craig.topper added a comment. In D113647#3124363 , @erichkeane wrote: > Is there a lit-test that could be added to make sure this happens? We put > this in an llvm-attribute, so it should be checkable. Forgot to git add the file I wrote.

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9554 + +const auto = +Info.Ctx.getTargetInfo().getSupportedOpenCLOpts(); azabaznov wrote: > Anastasia wrote: > > What test case covers this change? It feels like something

[PATCH] D112230: [OpenCL] Add support of __opencl_c_device_enqueue feature macro.

azabaznov added a comment. Herald added a subscriber: Naghasan. > How about we clarify with Khronos whether it would be sufficient to add a > restriction like: > >> Program scope blocks are only supported when program scope variables feature >> is supported. That's sounds good to me.

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:124 + } + return SanitizerArgs(*this, JobArgs, /*DiagnoseErrors=*/false); } eugenis wrote: > SanitizerArgs SanArgs(*this, JobArgs,

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

yaxunl updated this revision to Diff 386518. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by Evgenii's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111443/new/ https://reviews.llvm.org/D111443 Files:

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

This revision was automatically updated to reflect the committed changes. NeHuang marked 5 inline comments as done. Closed by commit rG18fe0a0d9eb1: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics… (authored by NeHuang). Changed prior to commit:

[PATCH] D113654: [AIX] Set D111860's test unsupported on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG72362736c380: [AIX] Set D111860s test unsupported on AIX (authored by lkail). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113654/new/

[clang] 7236273 - [AIX] Set D111860's test unsupported on AIX

Author: Kai Luo Date: 2021-11-11T15:51:19Z New Revision: 72362736c380699a79ba43a1411baeab76205c39 URL: https://github.com/llvm/llvm-project/commit/72362736c380699a79ba43a1411baeab76205c39 DIFF: https://github.com/llvm/llvm-project/commit/72362736c380699a79ba43a1411baeab76205c39.diff LOG:

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:264 + if (Module || !AllowSearch || !HSOpts->ImplicitModuleMaps) { +noteModuleLookupUsage(Module, ImportLoc); return Module; This is the important change. Repository: rG

[PATCH] D113676: WIP: [clang][lex] Fix search path usage remark with modules

jansvoboda11 created this revision. jansvoboda11 added a reviewer: ahoppen. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When looking for module, `HeaderSearch::lookupModule` iterates through search paths, parses

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo comments from @steakhal! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Eugene.Zelenko added a comment. Please wait for @aaron.ballman approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51650: Implement target_clones multiversioning

aaron.ballman added a comment. Overall, I think this LGTM, but I did find a few nits. Can you fix the clang-format issues? Also, I'd like to see some C++ test coverage that shows how this works on template (partial) specializations, lambdas (with GNU-style syntax), and overloaded functions. If

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji accepted this revision as: jsji. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for enabling this for FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113451/new/ https://reviews.llvm.org/D113451

[PATCH] D113256: [AArch64][ARM] Enablement of Cortex-A710 Support

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113256/new/ https://reviews.llvm.org/D113256 ___ cfe-commits mailing list

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

carlosgalvezp added a comment. I was a bit confused as well about the ClangSA support in clang-tidy. What's the current status? Is clang-tidy running *all* checks from StaticAnalyzer? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64454/new/

[PATCH] D110927: [analyzer] Access stored value of a constant array through a pointer to another type

ASDenysPetrov added a comment. @steakhal > I think I know. Great! Thank you! Comment at: clang/test/Analysis/initialization.cpp:295-299 +void glob_cast_opposite_sign1() { + auto *ptr = (unsigned int *)glob_arr2; + auto x1 = ptr[0]; // no-warning + auto x2 = ptr[1]; //

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a qualified entity which is already declared

urnathan added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7784-7785 "because namespace %1 does not enclose namespace %2">; +def err_export_non_namespace_scope_name : Error<"cannot export %0 here since " + "only the entities in namespace

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Is there a lit-test that could be added to make sure this happens? We put this in an llvm-attribute, so it should be checkable. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D51650: Implement target_clones multiversioning

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. In D51650#3121789 , @erichkeane wrote: > But nit made. NIT: clang-format issues still present. Maybe you need to update your local

[PATCH] D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks

aaron.ballman added a comment. In D64454#3122281 , @steakhal wrote: > It seems like the list got pretty outdated by the time. > Do you think we should really refer to the clang-analyzer checks in this > list? What about simply referring to the clangsa

  1   2   >